GNU bug report logs - #60285
xref-query-replace-in-results could show an arrow pointing to the current item being replaced

Previous Next

Package: emacs;

Reported by: Daniel Martín <mardani29 <at> yahoo.es>

Date: Fri, 23 Dec 2022 19:17:02 UTC

Severity: wishlist

Full log


View this message in rfc822 format

From: Dmitry Gutov <dgutov <at> yandex.ru>
To: Daniel Martín <mardani29 <at> yahoo.es>, 60285 <at> debbugs.gnu.org
Subject: bug#60285: xref-query-replace-in-results could show an arrow pointing to the current item being replaced
Date: Sat, 24 Dec 2022 19:45:01 +0200
[Message part 1 (text/plain, inline)]
On 23/12/2022 21:16, Daniel Martín via Bug reports for GNU Emacs, the 
Swiss army knife of text editors wrote:
> Severity: wishlist
> 
> When you use xref-query-replace-in-results to replace some references,
> it'd be great if the xref buffer showed an overlay arrow (see
> xref--set-arrow) pointing to the reference being edited.  That'd give
> better context about the reference that is being edited and the global
> progress of the query replace operation.

SGTM.

Here's a patch which seems to work. It's a little tricky, though, and 
I'm at a loss with better variable names in some places.

Wish we had some unit tests here.
[xref-replace-with-arrow.diff (text/x-patch, attachment)]

This bug report was last modified 2 years and 151 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.