From unknown Wed Jun 18 23:13:04 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#60266 <60266@debbugs.gnu.org> To: bug#60266 <60266@debbugs.gnu.org> Subject: Status: [PATCH] gnu: Add form. Reply-To: bug#60266 <60266@debbugs.gnu.org> Date: Thu, 19 Jun 2025 06:13:04 +0000 retitle 60266 [PATCH] gnu: Add form. reassign 60266 guix-patches submitter 60266 Antero Mejr severity 60266 normal tag 60266 patch moreinfo thanks From debbugs-submit-bounces@debbugs.gnu.org Thu Dec 22 20:16:28 2022 Received: (at submit) by debbugs.gnu.org; 23 Dec 2022 01:16:28 +0000 Received: from localhost ([127.0.0.1]:36490 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p8Wfj-0000Ij-PN for submit@debbugs.gnu.org; Thu, 22 Dec 2022 20:16:28 -0500 Received: from lists.gnu.org ([209.51.188.17]:35940) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p8Wfh-0000Ia-VF for submit@debbugs.gnu.org; Thu, 22 Dec 2022 20:16:26 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p8Wfh-0000cw-PF for guix-patches@gnu.org; Thu, 22 Dec 2022 20:16:25 -0500 Received: from mout-p-201.mailbox.org ([80.241.56.171]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_CHACHA20_POLY1305:256) (Exim 4.90_1) (envelope-from ) id 1p8Wff-00015L-3L for guix-patches@gnu.org; Thu, 22 Dec 2022 20:16:25 -0500 Received: from smtp202.mailbox.org (smtp202.mailbox.org [10.196.197.202]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-384) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-201.mailbox.org (Postfix) with ESMTPS id 4NdTlh0Z4rz9sQq for ; Fri, 23 Dec 2022 02:16:16 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mailbox.org; s=mail20150812; t=1671758176; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=7dNNnZQoyd5DazpTDs7ZW7hpYBqIKyMSO6UhI88V0+U=; b=DBR+W5dDJr5gW32jGh5UoFBwKRsfz6sfKp/3UJxQVyDXwSEAjjA0a9gfv5ZrIcMntb9sas +Yw85qd4WevQ4bYbRkfRbRdicsRHhHvrVdBL8GAffo9vK1UG8Wt5fYKNAQ3l2ubUyGVXtx 3TArtsjsAcYX6qrM1+mjzR56PWd/hhYUPY6inbJa0hesCEtRHB1NEPwJ9f2RE3CbXUY/Ha yG9rEUVTSi323G+0QQtJBhWY5ut0/7uS0ykCHQNP0cWGCCRSfpd8pRNmnkvHVJOKO7nkaR ElO3IwIhkctzJyJvZhD/hSMLYUieTH33fA26PlG7eM2ChIcBM36b1x2X4CtBsA== From: Antero Mejr DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mailbox.org; s=mail20150812; t=1671758174; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=7dNNnZQoyd5DazpTDs7ZW7hpYBqIKyMSO6UhI88V0+U=; b=D6oZU5oar21fJQFra4GVHhaK01ipBGw/TmZZ0kjI9DiApAhborTAoaAo8pFtqGXDeIM5Dq peNoVnyhn+PsTekkNfDH18g28fk91lScq8pEjFDys0uprlQzYBjz/SHvnut8+0eBRFrqib uFEy/Enoe6BPQ3p8HYG6F5VIyuBf9EX/1u958oJXK1ydX93UYN+mA7F3x9qhbyt3Ble9oG aUJuQk19qPWPv0QvtQHaygpTnlJ1iUv3k6rsMkV2xIrOzSqFDtFehqN58ZskQ7lJKVnnUS /9F4KWXFBRcux0d79iKUnY6bTHTKlWC8Tvb2qcFesuihCQf2XcnnShJm+K1Hxg== To: guix-patches@gnu.org Subject: [PATCH] gnu: Add form. Date: Fri, 23 Dec 2022 01:15:51 +0000 Message-Id: <20221223011551.32708-1-antero@mailbox.org> MIME-Version: 1.0 X-Debbugs-Cc: efraim@flashner.co.il X-Debbugs-Cc: andreas@enge.fr X-Debbugs-Cc: bavier@posteo.net Content-Transfer-Encoding: 8bit X-MBO-RS-META: ir4kdnhecjowj4ht3hy9rdauckbtsubw X-MBO-RS-ID: 88dfc6705fa8a97f65d Received-SPF: pass client-ip=80.241.56.171; envelope-from=antero@mailbox.org; helo=mout-p-201.mailbox.org X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit Cc: Antero Mejr X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) * gnu/packages/maths.scm (form): New variable. --- x86_64 only due to test failures on other platforms. Developers say other platforms are not "tier 1" supported: https://github.com/vermaseren/form/issues/426 gnu/packages/maths.scm | 55 ++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 55 insertions(+) diff --git a/gnu/packages/maths.scm b/gnu/packages/maths.scm index 050450e12c..08ddd2ecb4 100644 --- a/gnu/packages/maths.scm +++ b/gnu/packages/maths.scm @@ -8161,3 +8161,58 @@ (define-public optizelle provided for applications written in C++ and Python. Parallel computation is supported via MPI.") (license license:bsd-2)))) + +(define-public form + (let ((commit "28e15eaf0856a0a012795298d6a4b570e764a8b1") + (revision "0")) + (package + (name "form") + (version (git-version "4.3.0" revision commit)) + (source (origin + (method git-fetch) + (uri (git-reference + (url "https://github.com/vermaseren/form") + (commit commit))) + (file-name (git-file-name name version)) + (sha256 + (base32 + "04i932lqwng2hmknvai1gmmb5j17rwrhlj11nr96w9bmj4sq736x")) + (modules '((guix build utils))) + (snippet #~(substitute* "check/examples.frm" + (("#pend_if valgrind\\?") + "#pend_if 0"))))) + (build-system gnu-build-system) + (native-inputs (list autoconf automake doxygen ruby)) + (inputs (list bash openmpi)) + (arguments + (list #:configure-flags #~(list "--enable-parform") + #:phases #~(modify-phases %standard-phases + (add-after 'unpack 'fix-hardcoded-path + (lambda _ + (substitute* "sources/extcmd.c" + (("/bin/sh") + (string-append #$(this-package-input "bash") + "/bin/sh"))))) + (add-after 'build 'build-doxygen + (lambda _ + (with-directory-excursion "doc/doxygen" + (invoke "make" "html")))) + (add-before 'check 'mpi-setup + #$%openmpi-setup) + (add-after 'install 'install-docs + (lambda _ + (let ((doc (string-append #$output "/share/doc/" + #$name "-" #$version + "/html"))) + (mkdir-p doc) + (copy-recursively "doc/doxygen/html" doc))))))) + (home-page "https://www.nikhef.nl/~form/maindir/maindir.html") + (synopsis "Symbolic manipulation system for very big expressions") + (description + "FORM is a symbolic manipulation system. It reads symbolic expressions +from files and executes symbolic/algebraic transformations upon them. The +answers are returned in a textual mathematical representation. The size of the +considered expressions in FORM is only limited by the available disk space and +not by the available RAM.") + (supported-systems '("x86_64-linux")) + (license license:gpl3+)))) -- 2.38.1 From debbugs-submit-bounces@debbugs.gnu.org Mon Jan 09 13:01:56 2023 Received: (at 60266) by debbugs.gnu.org; 9 Jan 2023 18:01:56 +0000 Received: from localhost ([127.0.0.1]:38119 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pEwT5-0004vY-OA for submit@debbugs.gnu.org; Mon, 09 Jan 2023 13:01:56 -0500 Received: from mout02.posteo.de ([185.67.36.66]:55095) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pEwT3-0004vK-G9 for 60266@debbugs.gnu.org; Mon, 09 Jan 2023 13:01:55 -0500 Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id 5A0D524040D for <60266@debbugs.gnu.org>; Mon, 9 Jan 2023 19:01:47 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1673287307; bh=a2StSm5Ewk1VwNUH0nK/S4cMlnP7kbsNRzI9BXXn54s=; h=Subject:From:To:Date:From; b=jo5+QO/UbJg88iDR8ggXU6cKyz5FEnLwrjaEcNllcni29xSrvJ/HZixQUX5KHhWp0 seXqC4RhAupPA9VuEH3Fz8MRAA1y4pO2yvN6jWewoEL4UOW2d+imzqv2b9gL7LS+4x FkBPL0sY7mIhVhiQpq1bH5l6k8f5B963bohKK2/gVDVBncH+1uNiM/uBTIlIisH2mz Cgq+biHgcqWqOPhIpFID28KPV8RV7MzgfZQUaDQ4uzR+W6LQJSUwndIwW5vcgN8WLt GeMrnzDN78HLkBdHAkRNHDf7klvHTyz5fCStfPc7Gj7wJIn0od3zHLB+23AeBYtZB3 aeUuod/m+xMVA== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4NrMFz4lf9z6tnG; Mon, 9 Jan 2023 19:01:43 +0100 (CET) Message-ID: <92910915624cad61de6c1fc75cbe6ac2b8c6fe27.camel@posteo.net> Subject: Re: [bug#60266] [PATCH] gnu: Add form. From: Eric Bavier To: Antero Mejr , 60266@debbugs.gnu.org Date: Mon, 09 Jan 2023 18:01:33 +0000 In-Reply-To: <20221223011551.32708-1-antero@mailbox.org> References: <20221223011551.32708-1-antero@mailbox.org> Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-fAls992NzDfjcNW52n3I" MIME-Version: 1.0 X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 60266 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) --=-fAls992NzDfjcNW52n3I Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hello Antero, Thank you for the patch. Sorry for the delayed reply, holidays and such. I was able to apply your patch and build a form package. A few comments: On Fri, 2022-12-23 at 01:15 +0000, Antero Mejr wrote: > * gnu/packages/maths.scm (form): New variable. > --- > x86_64 only due to test failures on other platforms. Developers > say other platforms are not "tier 1" supported: > https://github.com/vermaseren/form/issues/426 This may be better as a comment near the `supported-systems` field, along with a short summary of which tests fail on other systems. >=20 > gnu/packages/maths.scm | 55 ++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 55 insertions(+) >=20 > diff --git a/gnu/packages/maths.scm b/gnu/packages/maths.scm > index 050450e12c..08ddd2ecb4 100644 > --- a/gnu/packages/maths.scm > +++ b/gnu/packages/maths.scm > @@ -8161,3 +8161,58 @@ (define-public optizelle > provided for applications written in C++ and Python. Parallel > computation is supported via MPI.") > (license license:bsd-2)))) > + > +(define-public form > + (let ((commit "28e15eaf0856a0a012795298d6a4b570e764a8b1") This commit is downstream from the 4.3.0 release, so we should include in a comment the rationale for not using just the 4.3.0 release tarball. > + (revision "0")) > + (package > + (name "form") > + (version (git-version "4.3.0" revision commit)) > + (source (origin > + (method git-fetch) > + (uri (git-reference > + (url "https://github.com/vermaseren/form") > + (commit commit))) > + (file-name (git-file-name name version)) > + (sha256 > + (base32 > + "04i932lqwng2hmknvai1gmmb5j17rwrhlj11nr96w9bmj4sq736x"= )) > + (modules '((guix build utils))) > + (snippet #~(substitute* "check/examples.frm" > + (("#pend_if valgrind\\?") > + "#pend_if 0"))))) This snippet appears to be related to the specifics of this package build? E.g. if someone were to grab the source with `guix build -S form`, they would not be able to have valgrind support, correct? If that's the case, perhaps it would be better to apply this substitution in a build phase. > + (build-system gnu-build-system) > + (native-inputs (list autoconf automake doxygen ruby)) > + (inputs (list bash openmpi)) > + (arguments > + (list #:configure-flags #~(list "--enable-parform") For some other maths packages that have both a serial and MPI versions, we've usually provided two packages. See e.g. `petsc` and `petsc- openmpi`. This can be useful if someone does not need a full MPI- capable version of form, and the separation is easily achieved. Also, I see the default compilation flags include `-march=3Dnative`, which will most likely cause a problem with build farm substitutes or `guix challenge`. Could you figure out have to override these flags? Guix usually assumes `SSE2` capabilities for x86_64 targets, iirc.=20 Bonus points for enabling a "tunable" package (c.f. "Package Transformation Options"). > + #:phases #~(modify-phases %standard-phases > + (add-after 'unpack 'fix-hardcoded-path > + (lambda _ > + (substitute* "sources/extcmd.c" > + (("/bin/sh") > + (string-append #$(this-package-input "b= ash") > + "/bin/sh"))))) > + (add-after 'build 'build-doxygen > + (lambda _ > + (with-directory-excursion "doc/doxygen" > + (invoke "make" "html")))) > + (add-before 'check 'mpi-setup > + #$%openmpi-setup) > + (add-after 'install 'install-docs > + (lambda _ > + (let ((doc (string-append #$output "/share= /doc/" > + #$name "-" #$ver= sion > + "/html"))) > + (mkdir-p doc) > + (copy-recursively "doc/doxygen/html" doc= ))))))) > + (home-page "https://www.nikhef.nl/~form/maindir/maindir.html") Maybe we should use https://www.nikhef.nl/~form/ instead? This is the URL specified in the included manpage. > + (synopsis "Symbolic manipulation system for very big expressions") > + (description > + "FORM is a symbolic manipulation system. It reads symbolic expre= ssions > +from files and executes symbolic/algebraic transformations upon them. T= he > +answers are returned in a textual mathematical representation. The size= of the > +considered expressions in FORM is only limited by the available disk spa= ce and > +not by the available RAM.") > + (supported-systems '("x86_64-linux")) > + (license license:gpl3+)))) Thanks, `~Eric --=-fAls992NzDfjcNW52n3I Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- iQJGBAABCgAwFiEEo6S0GQB0CHyn3laYvEXKZ+L40AcFAmO8Vn0SHGJhdmllckBw b3N0ZW8ubmV0AAoJELxFymfi+NAHUpwQAJwkC27XBHydtH34AqDU7FgE6q5p75sY JaHfs+JrCEzU8nQqfMx0HErVokmQ1BL4pYaWoXxZwcKLspTsoFmVtIFb00ZUZar0 /jK5nbzjdpCruq+3VwX4yGHooe4KL+whsc1XpbDPrdemKa0NinJZNDRqFE1KptHy mBm9fVDjUojPdrbWe/Fk/e8Hn65+zz9Ue/n4prPK2DPv73Kryh2WoC+8fYeAjPU/ W95ozHDLneQzsbmE2W9ofgwtJpxZu0N3tQti++9QblYjoCwH7YCCM8l04FkMjNKl 9PoiCOlrv3Ak33MmiRm2qZ9CEq2vu+JFdXMcdwTU8wXwyWzCVH285IOft6HH8FE0 Y7eIKO+7YaojUpRE692ziRLMvTiMTtWbW5lo5o5Ge3yyXz7a22yAcO0VOWG66EeG vvuKsdwXMf+r2YAhaUkZo2Z5sYt1JEFl+ESMmJMSGQowW/QagVTJTaZTFEeO6Ag4 EM3z/e0lQTNKCwlTK+u1IfQBx0vFxiKsAUs2ySx6EPxdCJPeEZRe9iJJu7vfuP1i QrYNhZ/JeQSZ09wJX5OugnqwpJUNxUoRctwxO2S0t6576nvYAUB1uErdXSjcsVSJ EFhg0Sv5MsSsOCjcKNzPOOevT+fX14Llz1OtREUOfP4X3Cvnx+FWaZhZ5L1FNRsD 8seOIr9ABapd =0vQ5 -----END PGP SIGNATURE----- --=-fAls992NzDfjcNW52n3I-- From debbugs-submit-bounces@debbugs.gnu.org Sun Feb 19 17:42:54 2023 Received: (at 60266) by debbugs.gnu.org; 19 Feb 2023 22:42:54 +0000 Received: from localhost ([127.0.0.1]:49876 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pTsOU-0007IR-5j for submit@debbugs.gnu.org; Sun, 19 Feb 2023 17:42:54 -0500 Received: from hera.aquilenet.fr ([185.233.100.1]:52544) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pTsOS-0007I3-DC for 60266@debbugs.gnu.org; Sun, 19 Feb 2023 17:42:52 -0500 Received: from localhost (localhost [127.0.0.1]) by hera.aquilenet.fr (Postfix) with ESMTP id D70EBB76; Sun, 19 Feb 2023 23:42:31 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at hera.aquilenet.fr Received: from hera.aquilenet.fr ([127.0.0.1]) by localhost (hera.aquilenet.fr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id nDFk6SQf82Rv; Sun, 19 Feb 2023 23:42:31 +0100 (CET) Received: from jurong (unknown [IPv6:2001:861:c4:f2f0::c64]) by hera.aquilenet.fr (Postfix) with ESMTPSA id 65C2771A; Sun, 19 Feb 2023 23:42:31 +0100 (CET) Date: Sun, 19 Feb 2023 23:42:29 +0100 From: Andreas Enge To: 60266@debbugs.gnu.org Subject: Algebra Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 60266 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hello, I think this package should be in algebra.scm, not maths.scm. The names are not completely logical, actually maths is all maths that is not algebra (and a few packages are already in the maths module although they should not be). Andreas From debbugs-submit-bounces@debbugs.gnu.org Wed Mar 01 04:18:39 2023 Received: (at control) by debbugs.gnu.org; 1 Mar 2023 09:18:39 +0000 Received: from localhost ([127.0.0.1]:52672 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pXIbe-0004Mx-Pi for submit@debbugs.gnu.org; Wed, 01 Mar 2023 04:18:38 -0500 Received: from mira.cbaines.net ([212.71.252.8]:42298) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pXIbd-0004Mp-EE for control@debbugs.gnu.org; Wed, 01 Mar 2023 04:18:37 -0500 Received: from localhost (unknown [IPv6:2a02:8010:68c1:0:54d1:d5d4:280e:f699]) by mira.cbaines.net (Postfix) with ESMTPSA id 0674216C3D for ; Wed, 1 Mar 2023 09:18:37 +0000 (GMT) Received: from localhost (localhost [local]) by localhost (OpenSMTPD) with ESMTPA id 2099db20 for ; Wed, 1 Mar 2023 09:18:36 +0000 (UTC) From: Christopher Baines To: control@debbugs.gnu.org Subject: tag 60266 moreinfo Date: Wed, 01 Mar 2023 09:18:36 +0000 Message-ID: <87wn40q177.fsf@cbaines.net> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) tags 60266 + moreinfo quit From debbugs-submit-bounces@debbugs.gnu.org Wed Mar 15 21:08:02 2023 Received: (at 60266) by debbugs.gnu.org; 16 Mar 2023 01:08:02 +0000 Received: from localhost ([127.0.0.1]:40811 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pcc66-0008SX-Cc for submit@debbugs.gnu.org; Wed, 15 Mar 2023 21:08:02 -0400 Received: from mout-p-103.mailbox.org ([80.241.56.161]:44476) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pcc64-0008Ry-Ic for 60266@debbugs.gnu.org; Wed, 15 Mar 2023 21:08:01 -0400 Received: from smtp202.mailbox.org (smtp202.mailbox.org [IPv6:2001:67c:2050:b231:465::202]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-384) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-103.mailbox.org (Postfix) with ESMTPS id 4PcTdh0TkHz9sWV for <60266@debbugs.gnu.org>; Thu, 16 Mar 2023 02:07:52 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mailbox.org; s=mail20150812; t=1678928872; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=3189mhTCMv0cv2yXSAb+j2eK5KLYM+uQsiA46VKZYVI=; b=RCJkF83IWV7Yv9a1EOzHSynlL/7NN/3lyPTdURTtbj+eWn92QpmTLSkBj6FFNQRe6qnrPi 6rdTJjaAMm5q2jrMVC8nKon/Lzr1I7QG4enUX6lkc7vtB2h2n5/s6odYffwa0EgNgDCC6P OMDz8SFZHbZStLj30LODWZspnlip3dygKig8xpxV4hHIYBZnAqgA0Q5/AfkPjOzLgy5HI5 PkukcL3yXTi7BSlZzD8jZ1caiYh9UJuWlYRyQEzXhT/IUJWT/frNvF4lGH6Xm3aKm7vCz9 Hh1kswviKNLxPrtsfjI3bzrozwylxRSE4SxOTlEWlQ6XAN93GL3LOjkusjIOSw== From: Antero Mejr To: 60266@debbugs.gnu.org Subject: [PATCH v2 1/2] gnu: Add form. Date: Thu, 16 Mar 2023 01:07:44 +0000 Message-Id: <20230316010745.20987-1-antero@mailbox.org> MIME-Version: 1.0 X-Debbugs-Cc: efraim@flashner.co.il X-Debbugs-Cc: andreas@enge.fr X-Debbugs-Cc: bavier@posteo.net Content-Transfer-Encoding: 8bit X-MBO-RS-META: 18mr8tdy4b44jro6htd8o3c6jb1ywhr4 X-MBO-RS-ID: aca60c8f4d8cdb82074 X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 60266 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) * gnu/packages/algebra.scm (form): New variable. --- Changes from v1: moved to algebra.scm split out parform (mpi version) into separate package removed --march=native added comments explaining some package fields changed home-page gnu/packages/algebra.scm | 61 ++++++++++++++++++++++++++++++++++++++++ 1 file changed, 61 insertions(+) diff --git a/gnu/packages/algebra.scm b/gnu/packages/algebra.scm index 5842a166ad..5bce35a229 100644 --- a/gnu/packages/algebra.scm +++ b/gnu/packages/algebra.scm @@ -34,6 +34,7 @@ (define-module (gnu packages algebra) #:use-module (gnu packages) #:use-module (gnu packages autotools) + #:use-module (gnu packages bash) #:use-module (gnu packages bison) #:use-module (gnu packages boost) #:use-module (gnu packages check) @@ -58,6 +59,7 @@ (define-module (gnu packages algebra) #:use-module (gnu packages python) #:use-module (gnu packages python-xyz) #:use-module (gnu packages readline) + #:use-module (gnu packages ruby) #:use-module (gnu packages shells) #:use-module (gnu packages tex) #:use-module (gnu packages texinfo) @@ -1818,3 +1820,62 @@ (define-public sollya it offers a certified infinity norm, an automatic polynomial implementer, and a fast Remez algorithm.") (license license:cecill-c))) + +(define-public form + ;; using this commit as it removes some invalid/ambiguous license info + (let ((commit "e7c52d3b07abe21f21718f5e70ee138e856f15ac") + (revision "0")) + (package + (name "form") + (version (git-version "4.3.0" revision commit)) + (source (origin + (method git-fetch) + (uri (git-reference + (url "https://github.com/vermaseren/form") + (commit commit))) + (file-name (git-file-name name version)) + (sha256 + (base32 + "15pjpn5s8d3sva18syhyymh5v1dijchk0xkf6d0m7cl2sj3qxxxq")) + (modules '((guix build utils))) + ;; skip test that causes memory leak and fails + (snippet #~(substitute* "check/examples.frm" + (("#pend_if valgrind\\?") + "#pend_if 0"))))) + (build-system gnu-build-system) + (arguments + (list #:configure-flags #~'("--enable-native=no") + #:phases #~(modify-phases %standard-phases + (add-after 'unpack 'fix-hardcoded-path + (lambda _ + (substitute* "sources/extcmd.c" + (("/bin/sh") + (string-append + #$(this-package-input "bash-minimal") + "/bin/sh"))))) + (add-after 'build 'build-doxygen + (lambda _ + (with-directory-excursion "doc/doxygen" + (invoke "make" "html")))) + (add-after 'install 'install-docs + (lambda _ + (let ((doc (string-append + #$output "/share/doc/" #$name "-" + #$version "/html"))) + (mkdir-p doc) + (copy-recursively "doc/doxygen/html" doc))))))) + (native-inputs (list autoconf automake doxygen ruby)) + (inputs (list bash-minimal)) + (home-page "https://www.nikhef.nl/~form/") + (synopsis "Symbolic manipulation system for very big expressions") + (description + "FORM is a symbolic manipulation system. It reads symbolic expressions +from files and executes symbolic/algebraic transformations upon them. The +answers are returned in a textual mathematical representation. The size of +the considered expressions in FORM is only limited by the available disk space +and not by the available RAM.") + ;; x86_64 only due to test failures on other platforms. + ;; Developers say other platforms are not "tier 1" supported: + ;; https://github.com/vermaseren/form/issues/426 + (supported-systems '("x86_64-linux")) + (license license:gpl3+)))) -- 2.38.1 From debbugs-submit-bounces@debbugs.gnu.org Wed Mar 15 21:08:10 2023 Received: (at 60266) by debbugs.gnu.org; 16 Mar 2023 01:08:10 +0000 Received: from localhost ([127.0.0.1]:40815 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pcc6D-0008Ss-SJ for submit@debbugs.gnu.org; Wed, 15 Mar 2023 21:08:10 -0400 Received: from mout-p-101.mailbox.org ([80.241.56.151]:55948) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pcc6C-0008Se-IJ for 60266@debbugs.gnu.org; Wed, 15 Mar 2023 21:08:09 -0400 Received: from smtp2.mailbox.org (smtp2.mailbox.org [IPv6:2001:67c:2050:b231:465::2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-384) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-101.mailbox.org (Postfix) with ESMTPS id 4PcTdr3h5Zz9sZT for <60266@debbugs.gnu.org>; Thu, 16 Mar 2023 02:08:00 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mailbox.org; s=mail20150812; t=1678928880; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=/bHDogSZXrWhJu2X1f1NpP1mlIRztqG3Zob08x3CrHw=; b=Gk3jGzf4owbS+l0RyETpMzpjwhv4OiOw/3ckBuI2gNUPHEB+eXUkxtKVAib9O3Wg44qX37 ce0Ea/CxOakePbCOM367T2rtua6r0J5SNmVZ2pgfoeIGD/9bvsQj30/ggpIVWBxSrPiC7h zQ5iE/r2TrCwZCZe0AIFAgLqv7qqXq7XrLCjSE+o8+jMh8e+oTDVK/ep6sI1J2vKIi0gHo qGymlMFMFxNFDwNGTOAgahrLRdDiXrEuz5bCMm2BMeQB9Org/pxo1nV1C6UXKQ+xcv4k37 27V0e1aWvvc1p6mSIb1u33n5MNKozKbUwJ+eeXu71BAl9S7KvKVYttAxp6J0BQ== From: Antero Mejr To: 60266@debbugs.gnu.org Subject: [PATCH v2 2/2] gnu: Add parform. Date: Thu, 16 Mar 2023 01:07:45 +0000 Message-Id: <20230316010745.20987-2-antero@mailbox.org> In-Reply-To: <20230316010745.20987-1-antero@mailbox.org> References: <20230316010745.20987-1-antero@mailbox.org> MIME-Version: 1.0 X-Debbugs-Cc: efraim@flashner.co.il X-Debbugs-Cc: andreas@enge.fr X-Debbugs-Cc: bavier@posteo.net Content-Transfer-Encoding: 8bit X-MBO-RS-ID: 96f0123bbafc4b23471 X-MBO-RS-META: yi3n9wdig86wh6mcg4u9thraon6jw916 X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 60266 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) * gnu/packages/algebra.scm (parform): New variable. --- gnu/packages/algebra.scm | 17 +++++++++++++++++ 1 file changed, 17 insertions(+) diff --git a/gnu/packages/algebra.scm b/gnu/packages/algebra.scm index 5bce35a229..556b1583f8 100644 --- a/gnu/packages/algebra.scm +++ b/gnu/packages/algebra.scm @@ -1879,3 +1879,20 @@ (define-public form ;; https://github.com/vermaseren/form/issues/426 (supported-systems '("x86_64-linux")) (license license:gpl3+)))) + +(define-public parform + (package + (inherit form) + (name "parform") + (arguments + (substitute-keyword-arguments (package-arguments form) + ((#:configure-flags flags) + #~(cons* "--enable-parform=yes" #$flags)) + ((#:phases phases) + #~(modify-phases #$phases + (add-before 'check 'mpi-setup + #$%openmpi-setup))))) + (inputs (list bash-minimal openmpi)) + (description (string-append (package-description form) + " This package also includes +@code{parform}, a version of FORM parallelized using OpenMPI.")))) -- 2.38.1 From debbugs-submit-bounces@debbugs.gnu.org Wed Mar 15 21:16:13 2023 Received: (at 60266) by debbugs.gnu.org; 16 Mar 2023 01:16:13 +0000 Received: from localhost ([127.0.0.1]:40823 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pccE0-0000EV-Ta for submit@debbugs.gnu.org; Wed, 15 Mar 2023 21:16:13 -0400 Received: from mout-p-101.mailbox.org ([80.241.56.151]:58966) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pccDx-0000EF-QT for 60266@debbugs.gnu.org; Wed, 15 Mar 2023 21:16:10 -0400 Received: from smtp2.mailbox.org (smtp2.mailbox.org [IPv6:2001:67c:2050:b231:465::2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-384) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-101.mailbox.org (Postfix) with ESMTPS id 4PcTq52gv4z9skk; Thu, 16 Mar 2023 02:16:01 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mailbox.org; s=mail20150812; t=1678929361; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=QUOOPvRTOr7znoMT8OOc0lfgZuf7Xe0v8nBqj5T3n5w=; b=Q+pflYcQsLGFiaRzhh8PO2eG0BSeYWIIV2XF1NKTRLCsFckYqnwfQDIZvsSO8BpHvFOMhc T3K/8AWceSm47W4RPr6/q8aeg5owTO1mvTfhKk3VKVcH6YWuA4gYouH6dx9Bv6DkKQkaNX yPVPuF8mVyNsLMDAGcTXnpwvXXAJWeUgwR3QfHcm7BqMoXvGulDXNvmLl/6g3a8V2qD3wT JFYb4VmJQloE/CRKLZaslx1dZqf3C8VyWocvJApZb5+T2/xzYAWvo5NQBwieqAsJKHQ+9W /Bf6gGLYMFeCKIutc58t55O0+PH3lzuJGU43OLGNuHMPxVXitmTNnKcJsa1+FQ== From: Antero Mejr To: Eric Bavier Subject: Re: [bug#60266] [PATCH] gnu: Add form. In-Reply-To: <92910915624cad61de6c1fc75cbe6ac2b8c6fe27.camel@posteo.net> (Eric Bavier's message of "Mon, 09 Jan 2023 18:01:33 +0000") References: <20221223011551.32708-1-antero@mailbox.org> <92910915624cad61de6c1fc75cbe6ac2b8c6fe27.camel@posteo.net> Date: Thu, 16 Mar 2023 01:15:51 +0000 Message-ID: <871qlpzebc.fsf@mailbox.org> MIME-Version: 1.0 Content-Type: text/plain X-MBO-RS-META: 35ymkcjws83myez6uegbbgiutaj49phm X-MBO-RS-ID: 7058474efd6f7b1ed66 X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 60266 Cc: 60266@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Eric Bavier writes: >> x86_64 only due to test failures on other platforms. Developers >> say other platforms are not "tier 1" supported: >> https://github.com/vermaseren/form/issues/426 > > This may be better as a comment near the `supported-systems` field, > along with a short summary of which tests fail on other systems. Added comments in v2. > This commit is downstream from the 4.3.0 release, so we should include > in a comment the rationale for not using just the 4.3.0 release > tarball. Added rationale. >> + (snippet #~(substitute* "check/examples.frm" >> + (("#pend_if valgrind\\?") >> + "#pend_if 0"))))) > > This snippet appears to be related to the specifics of this package > build? E.g. if someone were to grab the source with `guix build -S > form`, they would not be able to have valgrind support, correct? If > that's the case, perhaps it would be better to apply this substitution > in a build phase. No, it's disabling a failing test that has a known problem (memory leak). Added a comment with the explanation. > For some other maths packages that have both a serial and MPI versions, > we've usually provided two packages. See e.g. `petsc` and `petsc- > openmpi`. This can be useful if someone does not need a full MPI- > capable version of form, and the separation is easily achieved. Moved the openMPI version to the parform package. > Also, I see the default compilation flags include `-march=native`, > which will most likely cause a problem with build farm substitutes or > `guix challenge`. Could you figure out have to override these flags? > Guix usually assumes `SSE2` capabilities for x86_64 targets, iirc. > Bonus points for enabling a "tunable" package (c.f. "Package > Transformation Options"). Disabled --march=native in v2. > Maybe we should use https://www.nikhef.nl/~form/ instead? This is the > URL specified in the included manpage. I used the other homepage so people can skip the weird "license agreement" page at https://www.nikhef.nl/~form/. But I changed it to your suggestion in v2. Thanks for the review. From debbugs-submit-bounces@debbugs.gnu.org Thu Mar 16 01:23:19 2023 Received: (at 60266) by debbugs.gnu.org; 16 Mar 2023 05:23:19 +0000 Received: from localhost ([127.0.0.1]:41013 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pcg58-00071P-RI for submit@debbugs.gnu.org; Thu, 16 Mar 2023 01:23:19 -0400 Received: from mail-ed1-f67.google.com ([209.85.208.67]:47081) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pcg57-000717-7G for 60266@debbugs.gnu.org; Thu, 16 Mar 2023 01:23:17 -0400 Received: by mail-ed1-f67.google.com with SMTP id eg48so2886959edb.13 for <60266@debbugs.gnu.org>; Wed, 15 Mar 2023 22:23:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1678944191; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=cKsMD9FbEQEDsTjOE2QQK+PfDG/rfY8rDtJEi8xa2mo=; b=fiqeEX7FFkkCg0OgZoScIBAaGTYHcak4YDrAOnfEuU1I0juE7nCswpVzM5JQZR/OSO w3Bj92Q2X8mfnx6cQtyh36I7o3yyqSYEHS6miv1bHmFAZ20zOd96Mbb2HRsXiHwHVj+r 3qr+rAzDLsRejigLa73vkcJ787K24SUuZdqvimf2veC5fcST3hyHy0F209d1wuqEFBH+ BdyAn7tS2Rkufbuwa79yf56KPLT8aWYU/VEoECelpDRYHrp5G0KhIlQc0wwseoTK07wq XpbZ7vKLENt2FiDd3NRWPo0g1opENQi6XKIsOeUvyLqjig2Kafh94CI2GnjLT7NoH6lk DaSg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678944191; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=cKsMD9FbEQEDsTjOE2QQK+PfDG/rfY8rDtJEi8xa2mo=; b=uRjwercke4dobk8Tsj/JGe4Dw7hR9Uycrpf1COAZu+UooF6188gE1IKD0QPwkq6nbP PEpB86QkBZpE1ddnI41MfreGfceg6MbkTMJEcw/FQh8QoczGHiDHxhwghxO1MlLYxFx5 UtJnS3SG6oan8tdYzeDSfkmIT8ssE9ldcZGt+eVYjoNSe7KjRhm0vc7Fnf6u838EkkvU XOAK6cD+31ZGzxhH9XYnGXT170JSpvMh2XD7TBHmIL8GdqSVUhHESMBUcFau3XFUttxs UuQDL2hs+rwpZ4LPaa84LNVNv7yPLghYTKqFkiIT1dqCaV2AEI2YkJ6KsAtCiE3PA02A 20ww== X-Gm-Message-State: AO0yUKVE3+0/PVvQn1huqKlbbCDSHY6xZcdn3o22sTlF93qNXqb2MHZH Hme0TPfjTQDyTkw8ISDrCkE= X-Google-Smtp-Source: AK7set/Xki267foU8fsVBEnWSjWSJwUDXbKtN8fUTXewUoHkmhVw+aObXTNOwEWtB2UikypSYCsVkw== X-Received: by 2002:a17:906:6a09:b0:888:b471:8e46 with SMTP id qw9-20020a1709066a0900b00888b4718e46mr10127276ejc.50.1678944191027; Wed, 15 Mar 2023 22:23:11 -0700 (PDT) Received: from lumine.fritz.box (85-127-52-93.dsl.dynamic.surfer.at. [85.127.52.93]) by smtp.gmail.com with ESMTPSA id lx20-20020a170906af1400b00930c6c01c9esm29113ejb.143.2023.03.15.22.23.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Mar 2023 22:23:10 -0700 (PDT) Message-ID: <73af16a03efa3f4dad83bde3571731ce7a277360.camel@gmail.com> Subject: Re: [bug#60266] [PATCH] gnu: Add form. From: Liliana Marie Prikler To: Antero Mejr , Eric Bavier Date: Thu, 16 Mar 2023 06:23:09 +0100 In-Reply-To: <871qlpzebc.fsf@mailbox.org> References: <20221223011551.32708-1-antero@mailbox.org> <92910915624cad61de6c1fc75cbe6ac2b8c6fe27.camel@posteo.net> <871qlpzebc.fsf@mailbox.org> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.46.0 MIME-Version: 1.0 X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 60266 Cc: 60266@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Am Donnerstag, dem 16.03.2023 um 01:15 +0000 schrieb Antero Mejr: > > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0 (snippet #~(substitute* "check/examples.frm" > > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0 (("#pend_if valgrind\\?") > > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 "#pend_if 0"))))) > >=20 > > This snippet appears to be related to the specifics of this package > > build?=C2=A0 E.g. if someone were to grab the source with `guix build -= S > > form`, they would not be able to have valgrind support, correct?=C2=A0 > > If that's the case, perhaps it would be better to apply this > > substitution in a build phase. >=20 > No, it's disabling a failing test that has a known problem (memory > leak). Added a comment with the explanation. Test failures should also be fixed at build time. Other than that, you could also try to fix the memory leak that causes the failure via a patch. > > Guix usually assumes `SSE2` capabilities for x86_64 targets, iirc.=20 It does, but not for i386 to i686, which also often see sse2 flags in=20 build systems. >=20 > I used the other homepage so people can skip the weird "license > agreement" page at https://www.nikhef.nl/~form/. Calling the GPL a license agreement is weird, and it doesn't help that=20 https://www.nikhef.nl/~form/maindir/ also refers to it. Perhaps we can raise an issue about that upstream? Cheers From debbugs-submit-bounces@debbugs.gnu.org Tue Mar 21 14:39:29 2023 Received: (at 60266) by debbugs.gnu.org; 21 Mar 2023 18:39:29 +0000 Received: from localhost ([127.0.0.1]:60590 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pegtN-00052N-B3 for submit@debbugs.gnu.org; Tue, 21 Mar 2023 14:39:29 -0400 Received: from mout-p-103.mailbox.org ([80.241.56.161]:38642) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pegtL-000529-QZ for 60266@debbugs.gnu.org; Tue, 21 Mar 2023 14:39:28 -0400 Received: from smtp202.mailbox.org (smtp202.mailbox.org [10.196.197.202]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-384) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-103.mailbox.org (Postfix) with ESMTPS id 4Ph0kb2jK6z9sVl for <60266@debbugs.gnu.org>; Tue, 21 Mar 2023 19:39:19 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mailbox.org; s=mail20150812; t=1679423959; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=oj8uodvZROcXmaYWcQfVUANgxAITFF1mEijuzRPVlR4=; b=m/ZbNVHrD0sasJu7OQEzC0FyauENUTNTBgzPgIcC3MxhF32HbIE/VRuNe6SjjgM+9PuDnw tjeQkA9s4lGJ8xfIe8xv0enBP3ti5blTzCE4VOf+WFFiRk969dArqnyZoDQnQis3ufo624 F69cb62sob8FNAx3C7P0mBv5G2+VSjvkgLQ8zI1TbMiFF0fQM53olg2hcUNpOIMK8uBPnv 69VYC2zDI03lHxGwGsoMOIbiuvpMbm+dAZ2LHDqzyEHOA0UfWUrHTJTS7U6yVm7IFUXwDY zMTMwgLEJ0aWhD3GZRvgIwV0WnDGm/qguJ49rN/lOrCTvk8MIKAd4wGOXv95Gg== From: Antero Mejr To: 60266@debbugs.gnu.org Subject: [PATCH v3 1/2] gnu: Add form. Date: Tue, 21 Mar 2023 18:39:01 +0000 Message-Id: <20230321183902.30605-1-antero@mailbox.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-MBO-RS-META: h3wzjub39yh773c6hkqzsadczfhdj4n4 X-MBO-RS-ID: d86581c735faf6c5bf3 X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 60266 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) * gnu/packages/algebra.scm (form): New variable. --- gnu/packages/algebra.scm | 60 ++++++++++++++++++++++++++++++++++++++++ 1 file changed, 60 insertions(+) diff --git a/gnu/packages/algebra.scm b/gnu/packages/algebra.scm index 5842a166ad..f6cb171e2a 100644 --- a/gnu/packages/algebra.scm +++ b/gnu/packages/algebra.scm @@ -34,6 +34,7 @@ (define-module (gnu packages algebra) #:use-module (gnu packages) #:use-module (gnu packages autotools) + #:use-module (gnu packages bash) #:use-module (gnu packages bison) #:use-module (gnu packages boost) #:use-module (gnu packages check) @@ -58,6 +59,7 @@ (define-module (gnu packages algebra) #:use-module (gnu packages python) #:use-module (gnu packages python-xyz) #:use-module (gnu packages readline) + #:use-module (gnu packages ruby) #:use-module (gnu packages shells) #:use-module (gnu packages tex) #:use-module (gnu packages texinfo) @@ -1818,3 +1820,61 @@ (define-public sollya it offers a certified infinity norm, an automatic polynomial implementer, and a fast Remez algorithm.") (license license:cecill-c))) + +(define-public form + ;; using this commit as it removes some invalid/ambiguous license info + (let ((commit "e7c52d3b07abe21f21718f5e70ee138e856f15ac") + (revision "0")) + (package + (name "form") + (version (git-version "4.3.0" revision commit)) + (source (origin + (method git-fetch) + (uri (git-reference + (url "https://github.com/vermaseren/form") + (commit commit))) + (file-name (git-file-name name version)) + (sha256 + (base32 + "15pjpn5s8d3sva18syhyymh5v1dijchk0xkf6d0m7cl2sj3qxxxq")))) + (build-system gnu-build-system) + (arguments + (list #:configure-flags #~'("--enable-native=no") + #:phases #~(modify-phases %standard-phases + (add-after 'unpack 'patch-src + (lambda _ + (substitute* "check/examples.frm" + ;; skip test that causes memory leak and fails + (("#pend_if valgrind\\?") + "#pend_if 0")) + (substitute* "sources/extcmd.c" + (("/bin/sh") + (string-append + #$(this-package-input "bash-minimal") + "/bin/sh"))))) + (add-after 'build 'build-doxygen + (lambda _ + (with-directory-excursion "doc/doxygen" + (invoke "make" "html")))) + (add-after 'install 'install-docs + (lambda _ + (let ((doc (string-append + #$output "/share/doc/" #$name "-" + #$version "/html"))) + (mkdir-p doc) + (copy-recursively "doc/doxygen/html" doc))))))) + (native-inputs (list autoconf automake doxygen ruby)) + (inputs (list bash-minimal)) + (home-page "https://www.nikhef.nl/~form/") + (synopsis "Symbolic manipulation system for very big expressions") + (description + "FORM is a symbolic manipulation system. It reads symbolic expressions +from files and executes symbolic/algebraic transformations upon them. The +answers are returned in a textual mathematical representation. The size of +the considered expressions in FORM is only limited by the available disk space +and not by the available RAM.") + ;; x86_64 only due to test failures on other platforms. + ;; Developers say other platforms are not "tier 1" supported: + ;; https://github.com/vermaseren/form/issues/426 + (supported-systems '("x86_64-linux")) + (license license:gpl3+)))) -- 2.38.1 From debbugs-submit-bounces@debbugs.gnu.org Tue Mar 21 14:39:38 2023 Received: (at 60266) by debbugs.gnu.org; 21 Mar 2023 18:39:38 +0000 Received: from localhost ([127.0.0.1]:60594 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pegtV-00052h-Qy for submit@debbugs.gnu.org; Tue, 21 Mar 2023 14:39:38 -0400 Received: from mout-p-103.mailbox.org ([80.241.56.161]:51334) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pegtU-00052V-1a for 60266@debbugs.gnu.org; Tue, 21 Mar 2023 14:39:36 -0400 Received: from smtp202.mailbox.org (smtp202.mailbox.org [IPv6:2001:67c:2050:b231:465::202]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-384) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-103.mailbox.org (Postfix) with ESMTPS id 4Ph0kl54xwz9sp1 for <60266@debbugs.gnu.org>; Tue, 21 Mar 2023 19:39:27 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mailbox.org; s=mail20150812; t=1679423967; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=1Ii2O+O8n89X6UCDpYIlTOJyJk7gPq+mMoLELdOBZIE=; b=fbVV5U3uHycuiVfapPGwXn8oCHf7pO9KS+SNidLoOqS4ESqaL6B/d35ljdfxscah2CXAUm Soy9r+O6dd4ZQSaHlq+GVddsZq//yb/0v2NrRw1CLxTwqx1H+P9l60ijLYdBnkZx4hOa67 BlDfdK10s1j9HOcl9cDIoTE83IRVZWhXwV37uyoUJ44Y1cJxAOCW7F7AVjkI+JwmoTHt6a aXhhrGLXZmp8IKZtY8rESFN7luAzP4g9krbBOnxJW/2TwjhL1JzfmgWEK4Hw0Mh5F/sOoO GN8QlwqDGnHbtIFzHau1Od67XzYJ50GrTkZFxd2oWWSfGof9omle6j1iNCPqJw== From: Antero Mejr To: 60266@debbugs.gnu.org Subject: [PATCH v3 2/2] gnu: Add parform. Date: Tue, 21 Mar 2023 18:39:02 +0000 Message-Id: <20230321183902.30605-2-antero@mailbox.org> In-Reply-To: <20230321183902.30605-1-antero@mailbox.org> References: <20230321183902.30605-1-antero@mailbox.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-MBO-RS-META: j9cgjp5op9tnb68ogb8wgpwa59176ris X-MBO-RS-ID: b40aeb06994df22de1a X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 60266 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) * gnu/packages/algebra.scm (parform): New variable. --- gnu/packages/algebra.scm | 17 +++++++++++++++++ 1 file changed, 17 insertions(+) diff --git a/gnu/packages/algebra.scm b/gnu/packages/algebra.scm index f6cb171e2a..e893bed722 100644 --- a/gnu/packages/algebra.scm +++ b/gnu/packages/algebra.scm @@ -1878,3 +1878,20 @@ (define-public form ;; https://github.com/vermaseren/form/issues/426 (supported-systems '("x86_64-linux")) (license license:gpl3+)))) + +(define-public parform + (package + (inherit form) + (name "parform") + (arguments + (substitute-keyword-arguments (package-arguments form) + ((#:configure-flags flags) + #~(cons* "--enable-parform=yes" #$flags)) + ((#:phases phases) + #~(modify-phases #$phases + (add-before 'check 'mpi-setup + #$%openmpi-setup))))) + (inputs (list bash-minimal openmpi)) + (description (string-append (package-description form) + " This package also includes +@code{parform}, a version of FORM parallelized using OpenMPI.")))) -- 2.38.1 From debbugs-submit-bounces@debbugs.gnu.org Tue Mar 21 14:54:17 2023 Received: (at 60266) by debbugs.gnu.org; 21 Mar 2023 18:54:17 +0000 Received: from localhost ([127.0.0.1]:60622 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1peh7g-0005W7-Nz for submit@debbugs.gnu.org; Tue, 21 Mar 2023 14:54:17 -0400 Received: from mout-p-101.mailbox.org ([80.241.56.151]:41388) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1peh7e-0005Vp-FV for 60266@debbugs.gnu.org; Tue, 21 Mar 2023 14:54:15 -0400 Received: from smtp202.mailbox.org (smtp202.mailbox.org [IPv6:2001:67c:2050:b231:465::202]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-384) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-101.mailbox.org (Postfix) with ESMTPS id 4Ph13f2PG9z9sV3; Tue, 21 Mar 2023 19:54:06 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mailbox.org; s=mail20150812; t=1679424846; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=7EkJgkY6KT1uGvvqHvmqv/sCL+N6g+Y17MhUQlmx8q8=; b=xjWTf93hlJPd2IZ7jUQKZl2rXH6BQ0XMdU73t00B6qs4hV03oJWSIpTIBP8cEww+IxhXdN 4l2oFne371q0uKzCSycY8am+IHB0bWR7RXzrlooPZfC8QIZvExWejqFTVA79pnZyKUdVPX xI2NWewXRgm46SPxLkxC7P08yct5mYK2IkuoCsOqAcWvw9yeRKsNVJMhTGjOeJAuNV/X8K GYQr0/wX+6tGbPk7N60CkgQNpGgRkHNOoskpBeglHVM0VmWpJsQ2eDpJ27UwyFhxBTqESZ aidKhXO+w8yIaL76vKHVmXMDllvTYXwFH6DOsTLTDfYK1LlFWOq64J7fO0juHA== From: Antero Mejr To: Liliana Marie Prikler Subject: Re: [bug#60266] [PATCH] gnu: Add form. In-Reply-To: <73af16a03efa3f4dad83bde3571731ce7a277360.camel@gmail.com> (Liliana Marie Prikler's message of "Thu, 16 Mar 2023 06:23:09 +0100") References: <20221223011551.32708-1-antero@mailbox.org> <92910915624cad61de6c1fc75cbe6ac2b8c6fe27.camel@posteo.net> <871qlpzebc.fsf@mailbox.org> <73af16a03efa3f4dad83bde3571731ce7a277360.camel@gmail.com> Date: Tue, 21 Mar 2023 18:53:58 +0000 Message-ID: <87cz523ph5.fsf@mailbox.org> MIME-Version: 1.0 Content-Type: text/plain X-MBO-RS-META: 77w4br1jkgkxrn4t3p1hxa7yxsswh1nu X-MBO-RS-ID: 727a88c7f32c3bdd838 X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 60266 Cc: 60266@debbugs.gnu.org, Eric Bavier X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Liliana Marie Prikler writes: > Test failures should also be fixed at build time. Other than that, you > could also try to fix the memory leak that causes the failure via a > patch. Fixed the test failure at build time in v3. >> > Guix usually assumes `SSE2` capabilities for x86_64 targets, iirc. > It does, but not for i386 to i686, which also often see sse2 flags in > build systems. I did some benchmarks on a few workloads with millions of terms. The "tunable" optimizations didn't consistently improve the performance. Sometimes it would be a couple percent faster, sometimes slower. So I didn't mark the package as tunable. >> I used the other homepage so people can skip the weird "license >> agreement" page at https://www.nikhef.nl/~form/. > Calling the GPL a license agreement is weird, and it doesn't help that > https://www.nikhef.nl/~form/maindir/ also refers to it. Perhaps we can > raise an issue about that upstream? I would prefer not to bother upstream further regarding the website, since I already had to ask them to change an invalid license statement in a file header (which they did). From debbugs-submit-bounces@debbugs.gnu.org Wed Mar 22 00:54:23 2023 Received: (at 60266-done) by debbugs.gnu.org; 22 Mar 2023 04:54:23 +0000 Received: from localhost ([127.0.0.1]:33201 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1peqUR-0007t1-5E for submit@debbugs.gnu.org; Wed, 22 Mar 2023 00:54:23 -0400 Received: from mout01.posteo.de ([185.67.36.65]:42323) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1peqUO-0007sm-Jj for 60266-done@debbugs.gnu.org; Wed, 22 Mar 2023 00:54:21 -0400 Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 20DD9240533 for <60266-done@debbugs.gnu.org>; Wed, 22 Mar 2023 05:54:13 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1679460854; bh=0NvzuAPzPNBHS6w6zsq9QaT7PIB1BMOh94Bhyef9aJI=; h=Subject:From:To:Cc:Date:From; b=B/wkq4CwWxHHBPC32IBVnwzonaKnXqMlITMoaoTLE5w0BHXaxDfyz0SXbNSkld1Ud FoolEwTVm8QrmplB1dVhh8I4I9NGrosLipTRI5DKqK1SEvxIE42sxl8uAgN5AGnYJ+ Il1BtL1DhNWUSnNqEqEG3+x7AXVs9g5iY4eon/dM4VNpXGmXrL/wy+CCPT/5JZBKL8 GOr0J90lW8wuBv9+ANRSFQQMlzLNrRarQtcWRZCl7UPoQYlGcny2s7RyRNfrf2pLpE 5SREYiK2B8mbHnSbKGmqxXa7uBgr2EZyyR1ISABusREE8vG67rdMWnZ4OiPr78iafj NHJJHwmRq8dRQ== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4PhGN34dqDz9rxM; Wed, 22 Mar 2023 05:54:11 +0100 (CET) Message-ID: <07209d425a70f9e21169478617feba541de5ca13.camel@posteo.net> Subject: Re: [bug#60266] [PATCH] gnu: Add form. From: Eric Bavier To: Antero Mejr , Liliana Marie Prikler Date: Wed, 22 Mar 2023 04:54:00 +0000 In-Reply-To: <87cz523ph5.fsf@mailbox.org> References: <20221223011551.32708-1-antero@mailbox.org> <92910915624cad61de6c1fc75cbe6ac2b8c6fe27.camel@posteo.net> <871qlpzebc.fsf@mailbox.org> <73af16a03efa3f4dad83bde3571731ce7a277360.camel@gmail.com> <87cz523ph5.fsf@mailbox.org> Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-hTd/EDLdswMGfsBU7HyM" MIME-Version: 1.0 X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 60266-done Cc: 60266-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) --=-hTd/EDLdswMGfsBU7HyM Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Antero, Thank you for your effort in this review. On Tue, 2023-03-21 at 18:53 +0000, Antero Mejr wrote: > > > > Guix usually assumes `SSE2` capabilities for x86_64 targets, iirc.= =20 > > It does, but not for i386 to i686, which also often see sse2 flags in= =20 > > build systems. >=20 > I did some benchmarks on a few workloads with millions of terms. The > "tunable" optimizations didn't consistently improve the > performance. Sometimes it would be a couple percent faster, sometimes > slower. So I didn't mark the package as tunable. I was watching my system load while `parform` was running its tests, and th= ings did not seem compute bound, so the package being not tunable seems fine to me. > > > I used the other homepage so people can skip the weird "license > > > agreement" page at https://www.nikhef.nl/~form/. > > Calling the GPL a license agreement is weird, and it doesn't help that= =20 > > https://www.nikhef.nl/~form/maindir/ also refers to it. Perhaps we can > > raise an issue about that upstream? >=20 > I would prefer not to bother upstream further regarding the website, > since I already had to ask them to change an invalid license statement > in a file header (which they did). Version 1 of the GPL used the term "license agreement" when describing itse= lf, so the phrasing is not *super* weird, just maybe a bit outdated. There are also p= lenty of free software projects, e.g. nodejs, that present users with an "accept this lic= ense agreement" prompt in their M$ installers. I've pushed these patches in=20 15ee08ebf23ea6bc5be9fa157889419aa079076a and 31bed61b8278d3736cc29055d60db068a1160071 with a small adjustment to appease `guix lint`: --- a/gnu/packages/algebra.scm +++ b/gnu/packages/algebra.scm @@ -1873,6 +1873,9 @@ (define-public form answers are returned in a textual mathematical representation. The size o= f the considered expressions in FORM is only limited by the available disk s= pace and not by the available RAM.") + ;; XXX: Ignore this CVE to work around a name clash with the unrelat= ed + ;; "neos/forms" package. + (properties '((lint-hidden-cve . ("CVE-2021-32697")))) ;; x86_64 only due to test failures on other platforms. ;; Developers say other platforms are not "tier 1" supported: ;; https://github.com/vermaseren/form/issues/426 Thanks again, `~Eric --=-hTd/EDLdswMGfsBU7HyM Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- iQJGBAABCgAwFiEEo6S0GQB0CHyn3laYvEXKZ+L40AcFAmQaiegSHGJhdmllckBw b3N0ZW8ubmV0AAoJELxFymfi+NAHilkP/RsIw/KHn2Yq5WQb93nUmKtlJo4cKbz2 qtH0AZbcTjRxWV3rgt0AFLjM6BHmvMM03AnpFudV3YG7y9O/BIsh3SwhzmpW9BVc KHLZumV2tK3UumEwASAKtUBXoxAFkY56yTJx6Mfx7m1zhbPj9RvqHnFLNTI711/2 uLfluhogAjpomoXMMNU/EYSnklxGJqmsqGXXsEqiGsmGzO3sWPnEZ+t3c6a29YWT 4BQOI251wYxyX24FYUYO1YQHnaOyF6808iGMDa1aIPsxMr0goz9IAR3faeNSSeCp yJmZ9kCZVWs7acYyCXGClS+n3wVtWYLXdy/zhzhLEKKlbrx+cJpU1IICIHMSNQMX jfUmlfc3Rp8Jue3xi5YukMI8VW4++2N29QhF+1B/xn3a9seTkqTC1u82Jtc6uYWv CWBQH+pa2Yp4fx+xTO048QNqZnQM3fQq/1CBsIRkQFmn2iwsArhpNKDEiNoZF77H LI6iiVpFJIaRJfhHNF/L4mKWiASGwKpFXQEEIjEWk1K1RChK5B7lx+QwH/dwRIe6 vDzFEDJjhwlECjFXkC08BSzuTm1Z5ZFfqVuHj4pYC5rZiTVwdLRzdCLR654s3CZd uceMbyoG0k0hp2nReMr7Wn3GuCni16xdWswCM4qo/s/gVoviMRss3+qOzLUtO6qd Rj5ALQB9zy/l =xtxq -----END PGP SIGNATURE----- --=-hTd/EDLdswMGfsBU7HyM-- From unknown Wed Jun 18 23:13:04 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Wed, 19 Apr 2023 11:24:17 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator