GNU bug report logs - #60256
29.0.60; Maybe improve tree sitter default treesit-language-at function

Previous Next

Full log

View this message in rfc822 format

From: Yuan Fu <casouri <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 60256 <at> debbugs.gnu.org, Wilhelm Hugo Kirschbaum <wilhelm <at> floatpays.co.za>
Subject: bug#60256: 29.0.60; Maybe improve tree sitter default  treesit-language-at function
Date: Sat, 24 Dec 2022 14:43:18 -0800

Eli Zaretskii <eliz <at> gnu.org> writes:

>> From: Wilhelm H Kirschbaum <wilhelm <at> floatpays.co.za>
>> Date: Thu, 22 Dec 2022 12:30:09 +0200
>> 
>> 
>> We can detect the language from treesit-parser-included-ranges, so
>> instead of taking the first parser from the list what about taking 
>> the first parser within known ranges?
>
> Yuan, any comments?

Yeah, sorry for the delay. I don’t think it’s worth it, because (1) I
expect major modes with multiple langauges to implement
treesit-language-at-point-function which takes care of all the work, and
(2) in the rare case where there are multiple languages and no
treesit-language-at-point-function, using the first language whose range
spans point (this patch) is not necessarily correct: the host language (eg, HTML
among HTML, CSS & JavaScript) always covers the whole buffer, only
embedded languages has ranges.

Yuan

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.