From unknown Sun Jun 22 17:13:19 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#60241 <60241@debbugs.gnu.org> To: bug#60241 <60241@debbugs.gnu.org> Subject: Status: 29.0.60; Fix regexp pattern case in hi-lock Reply-To: bug#60241 <60241@debbugs.gnu.org> Date: Mon, 23 Jun 2025 00:13:19 +0000 retitle 60241 29.0.60; Fix regexp pattern case in hi-lock reassign 60241 emacs submitter 60241 Juri Linkov severity 60241 normal tag 60241 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Wed Dec 21 12:29:49 2022 Received: (at submit) by debbugs.gnu.org; 21 Dec 2022 17:29:49 +0000 Received: from localhost ([127.0.0.1]:53025 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p82ua-0000Gp-Oc for submit@debbugs.gnu.org; Wed, 21 Dec 2022 12:29:49 -0500 Received: from lists.gnu.org ([209.51.188.17]:36914) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p82uZ-0000Gj-6F for submit@debbugs.gnu.org; Wed, 21 Dec 2022 12:29:47 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p82uZ-0003XG-0G for bug-gnu-emacs@gnu.org; Wed, 21 Dec 2022 12:29:47 -0500 Received: from relay9-d.mail.gandi.net ([217.70.183.199]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p82uX-0005k1-ED for bug-gnu-emacs@gnu.org; Wed, 21 Dec 2022 12:29:46 -0500 Received: (Authenticated sender: juri@linkov.net) by mail.gandi.net (Postfix) with ESMTPSA id B19E4FF806 for ; Wed, 21 Dec 2022 17:29:41 +0000 (UTC) From: Juri Linkov To: bug-gnu-emacs@gnu.org Subject: 29.0.60; Fix regexp pattern case in hi-lock Organization: LINKOV.NET Date: Wed, 21 Dec 2022 19:29:11 +0200 Message-ID: <86pmcc7jr8.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Received-SPF: pass client-ip=217.70.183.199; envelope-from=juri@linkov.net; helo=relay9-d.mail.gandi.net X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.6 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.6 (--) --=-=-= Content-Type: text/plain Version: 29.0.60 Tags: patch 0. emacs -Q 1. Type [ M-< C-s [ M-s h r RET M-s h u Debugger entered--Lisp error: (invalid-regexp "Unmatched [ or [^") hi-lock--regexps-at-point() command-execute(unhighlight-regexp) Here is a patch to fix this error: --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=hi-lock--regexps-at-point.patch diff --git a/lisp/hi-lock.el b/lisp/hi-lock.el index a45e74eca26..bc631747e6d 100644 --- a/lisp/hi-lock.el +++ b/lisp/hi-lock.el @@ -569,24 +569,29 @@ hi-lock--regexps-at-point (when (and face-before face-after (not (eq face-before face-after))) (setq face-before nil)) (when (or face-after face-before) - (let* ((hi-text - (buffer-substring-no-properties - (if face-before - (or (previous-single-property-change (point) 'face) - (point-min)) - (point)) - (if face-after - (or (next-single-property-change (point) 'face) - (point-max)) - (point))))) + (let* ((beg (if face-before + (or (previous-single-property-change (point) 'face) + (point-min)) + (point))) + (end (if face-after + (or (next-single-property-change (point) 'face) + (point-max)) + (point)))) ;; Compute hi-lock patterns that match the ;; highlighted text at point. Use this later in ;; during completing-read. (dolist (hi-lock-pattern hi-lock-interactive-patterns) - (let ((regexp (or (car (rassq hi-lock-pattern hi-lock-interactive-lighters)) - (car hi-lock-pattern)))) - (if (string-match regexp hi-text) - (push regexp regexps))))))) + (let ((pattern (or (rassq hi-lock-pattern hi-lock-interactive-lighters) + (car hi-lock-pattern)))) + (cond + ((stringp pattern) + (when (string-match pattern (buffer-substring-no-properties beg end)) + (push pattern regexps))) + ((functionp (cadr pattern)) + (save-excursion + (goto-char beg) + (when (funcall (cadr pattern) end) + (push (car pattern) regexps)))))))))) regexps)) (defvar-local hi-lock--unused-faces nil --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Thu Dec 29 12:46:20 2022 Received: (at 60241) by debbugs.gnu.org; 29 Dec 2022 17:46:20 +0000 Received: from localhost ([127.0.0.1]:60995 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pAwyy-0004M6-FA for submit@debbugs.gnu.org; Thu, 29 Dec 2022 12:46:20 -0500 Received: from relay9-d.mail.gandi.net ([217.70.183.199]:50931) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pAwyw-0004Lk-4v; Thu, 29 Dec 2022 12:46:18 -0500 Received: (Authenticated sender: juri@linkov.net) by mail.gandi.net (Postfix) with ESMTPSA id 1D3D7FF806; Thu, 29 Dec 2022 17:46:10 +0000 (UTC) From: Juri Linkov To: 60241@debbugs.gnu.org Subject: Re: bug#60241: 29.0.60; Fix regexp pattern case in hi-lock In-Reply-To: <86pmcc7jr8.fsf@mail.linkov.net> (Juri Linkov's message of "Wed, 21 Dec 2022 19:29:11 +0200") Organization: LINKOV.NET References: <86pmcc7jr8.fsf@mail.linkov.net> Date: Thu, 29 Dec 2022 19:45:32 +0200 Message-ID: <86wn6adryb.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 60241 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) close 60241 29.0.60 quit > 1. Type [ M-< C-s [ M-s h r RET M-s h u > > Debugger entered--Lisp error: (invalid-regexp "Unmatched [ or [^") > hi-lock--regexps-at-point() > command-execute(unhighlight-regexp) > > Here is a patch to fix this error: Pushed and closed. From unknown Sun Jun 22 17:13:19 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Fri, 27 Jan 2023 12:24:09 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator