GNU bug report logs - #60237
30.0.50; tree sitter core dumps when I edebug view a node

Previous Next

Full log

View this message in rfc822 format

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: Po Lu <luangruo <at> yahoo.com>
Cc: Eli Zaretskii <eliz <at> gnu.org>, mickey <at> masteringemacs.org, casouri <at> gmail.com, 60237 <at> debbugs.gnu.org
Subject: bug#60237: 30.0.50; tree sitter core dumps when I edebug view a node
Date: Thu, 02 Mar 2023 15:24:07 -0500

>> diff --git a/src/profiler.c b/src/profiler.c
>> index 81b5e7b0cf0..c99ed0a81a2 100644
>> --- a/src/profiler.c
>> +++ b/src/profiler.c
>> @@ -505,6 +505,8 @@ DEFUN ("profiler-memory-log",
>>  void
>>  malloc_probe (size_t size)
>>  {
>> +  if (EQ (backtrace_top_function (), QAutomatic_GC))
>> +    return;                     /* bug#60237 */
>>    eassert (HASH_TABLE_P (memory_log));
>>    record_backtrace (XHASH_TABLE (memory_log), min (size, MOST_POSITIVE_FIXNUM));
>>  }
>
> Shouldn't this be:
>
>   if (gc_in_progress)
>     return;

Sounds like a good idea.  If so that should apply to the cpu profiler
code as well.  It might be worthwhile to check the details to see if
there might be subtle differences (e.g. when we're running
`post-gc-hook` maybe?).


        Stefan

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.