GNU bug report logs - #60218
[PATCH 0/2] New teams.scm 'get-maintainer' command (for integration with patman)

Previous Next

Package: guix-patches;

Reported by: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>

Date: Tue, 20 Dec 2022 13:59:01 UTC

Severity: normal

Tags: patch

Done: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#60218: closed ([PATCH 0/2] New teams.scm 'get-maintainer'
 command (for integration with patman))
Date: Wed, 28 Dec 2022 20:43:02 +0000
[Message part 1 (text/plain, inline)]
Your message dated Wed, 28 Dec 2022 15:42:03 -0500
with message-id <87a6375kh0.fsf <at> gmail.com>
and subject line Re: bug#60218: [PATCH 0/2] New teams.scm 'get-maintainer' command (for integration with patman)
has caused the debbugs.gnu.org bug report #60218,
regarding [PATCH 0/2] New teams.scm 'get-maintainer' command (for integration with patman)
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
60218: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=60218
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems
[Message part 2 (message/rfc822, inline)]
From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: guix-patches <at> gnu.org
Cc: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
Subject: [PATCH 0/2] New teams.scm 'get-maintainer' command (for integration
 with patman)
Date: Tue, 20 Dec 2022 08:58:10 -0500
Along with the correct '.patman' configuration file for Guix, this makes it
possible to invoke the 'patman' command and have it add all the required
'--cc' directives, as computed by 'etc/teams.scm get-maintainers
<patch-file>'.


Maxim Cournoyer (2):
  teams: Add a "get-maintainer" command.
  .patman: New configuration file.

 .patman          |  9 +++++++++
 etc/teams.scm.in | 21 ++++++++++++++++++++-
 2 files changed, 29 insertions(+), 1 deletion(-)
 create mode 100644 .patman


base-commit: f28ca2447c5e2eef1ba6a3a11587380a665b0e26
-- 
2.38.1



[Message part 3 (message/rfc822, inline)]
From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: Mathieu Othacehe <othacehe <at> gnu.org>
Cc: Josselin Poiret <dev <at> jpoiret.xyz>, Christopher Baines <mail <at> cbaines.net>,
 Simon Tournier <zimon.toutoune <at> gmail.com>, 60218-done <at> debbugs.gnu.org,
 Ludovic Courtès <ludo <at> gnu.org>,
 Tobias Geerinckx-Rice <me <at> tobias.gr>, Ricardo Wurmus <rekado <at> elephly.net>
Subject: Re: bug#60218: [PATCH 0/2] New teams.scm 'get-maintainer' command
 (for integration with patman)
Date: Wed, 28 Dec 2022 15:42:03 -0500
Hi Mathieu,

Mathieu Othacehe <othacehe <at> gnu.org> writes:

> Hey,
>
>> Implemented in v2!  I guess it could be useful.  Note that it doesn't
>> parse the patch for the file names touched, instead it assumes the patch
>> was produced from a commit registered in git and then use the usual code
>> path (for simplicity).
>
> Nice! I think that it is fair to assume that the commit is registered in
> the local git repository.
>
> As a follow-up a documentation update could also be interesting as I
> think that the new 'cc-members patch' command is easier to use that the
> 'cc-member start end' variant.

OK!  I intend to document the use of patman along teams.scm, as I find
it helps automate things and keep submissions organized.  We can
probably briefly mention the tool, and point the interested user to its
full doc (which lives in u-boot-documentation).

> I had a look to the rest of the patchset it seems fine to me :)

OK, great!  I've now pushed the series.  Happy New Year!

-- 
Thanks,
Maxim


This bug report was last modified 2 years and 132 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.