From debbugs-submit-bounces@debbugs.gnu.org Tue Dec 20 08:58:21 2022 Received: (at submit) by debbugs.gnu.org; 20 Dec 2022 13:58:21 +0000 Received: from localhost ([127.0.0.1]:45030 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p7d8P-0002Z9-FI for submit@debbugs.gnu.org; Tue, 20 Dec 2022 08:58:21 -0500 Received: from lists.gnu.org ([209.51.188.17]:56758) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p7d8N-0002Z3-Ph for submit@debbugs.gnu.org; Tue, 20 Dec 2022 08:58:20 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p7d8N-0001oF-Gp for guix-patches@gnu.org; Tue, 20 Dec 2022 08:58:19 -0500 Received: from mail-qt1-x836.google.com ([2607:f8b0:4864:20::836]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1p7d8L-0001qe-Qz for guix-patches@gnu.org; Tue, 20 Dec 2022 08:58:19 -0500 Received: by mail-qt1-x836.google.com with SMTP id g7so10965854qts.1 for ; Tue, 20 Dec 2022 05:58:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=LHlk4kO+uTFVtfJ6ne+z+voO1DtpHCPzLp+DF20sF/4=; b=NHDO2A1q9ATLvSR+Ef7BoZMcCUDmgIqjccUvTNwZgT++pPvfZIPT3GyD/CKgKiJ7LW pUNliofD7ZEfCOVb+s/NrpFaY19lSdQHFhf/ebVYNGD8dC/IPpLXNDf+TnDhs9m5PS6K upZR8NtwTuKRyDZSLLzhjMbDVX8JIoaJ5h8Zxsu8XPzfWtOZ4sjJNGQIwefDxaHaP64L gsxsdqlaJzoc1S76AcLwVvlGTpVkgGVSH4JWG5fa/QacUnZPRhTBO67BxVP6YI+0gPTl rF9v/UFTBaFgSWUv/O1VCQYyO7p/JHu3hxGiHXwgRCupR+ts+tjUvZrIZpJLmmxRuW9F 0jBA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=LHlk4kO+uTFVtfJ6ne+z+voO1DtpHCPzLp+DF20sF/4=; b=kyn+AapeZs8U/joA3y6TBJZhoPc7cQ/rdolvcbZjetde+EuzFoDJYYdlDTcYkPPvcV Qlot7bbT8MPqOwlX/AfH55z7zTMeBmw76RFkUodu75X3NaClR9mkeaaigzwqLaDYX0P7 ow+YL8IKD5X99Wixa9BppSKA+pIGF4pB/JcRjghuaaD/P6NiEyOSjEaU7DMTq3OIIQfe YZUqU8mLy0LIOYatVoEteJ44iintkrCasReGOpH7ArEzFH/MSa8FG/XxIQvl0RklvJe0 PWhtn2W02566Kw365805Q9KvaCU4nXJnoV5Ln20OKY6/EHoZyUDI/fi08zp28AtvVeOH H+GQ== X-Gm-Message-State: ANoB5pmKL01v/BafpwEL0V2CLVYHryaU3yAh9dIaS1gRDgRpglJEggZh UG+FfIk7v0+eOhgp+poYlYk4T+0T27ziWA== X-Google-Smtp-Source: AA0mqf5Z7JCy2RBVCfEtZxZhKTpUDUZUDDSfnLhU6rxVGQAl9n0/cKvdet7Yud2ZHgWidbJBO54Qvg== X-Received: by 2002:ac8:745:0:b0:3a8:325:47e with SMTP id k5-20020ac80745000000b003a80325047emr59467727qth.54.1671544695991; Tue, 20 Dec 2022 05:58:15 -0800 (PST) Received: from localhost.localdomain ([2607:fad8:4:3::1002]) by smtp.gmail.com with ESMTPSA id ez5-20020a05622a4c8500b003a69de747c9sm7680097qtb.19.2022.12.20.05.58.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 20 Dec 2022 05:58:15 -0800 (PST) From: Maxim Cournoyer To: guix-patches@gnu.org Subject: [PATCH 0/2] New teams.scm 'get-maintainer' command (for integration with patman) Date: Tue, 20 Dec 2022 08:58:10 -0500 Message-Id: <20221220135810.28175-1-maxim.cournoyer@gmail.com> X-Mailer: git-send-email 2.38.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2607:f8b0:4864:20::836; envelope-from=maxim.cournoyer@gmail.com; helo=mail-qt1-x836.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit Cc: Maxim Cournoyer X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) Along with the correct '.patman' configuration file for Guix, this makes it possible to invoke the 'patman' command and have it add all the required '--cc' directives, as computed by 'etc/teams.scm get-maintainers '. Maxim Cournoyer (2): teams: Add a "get-maintainer" command. .patman: New configuration file. .patman | 9 +++++++++ etc/teams.scm.in | 21 ++++++++++++++++++++- 2 files changed, 29 insertions(+), 1 deletion(-) create mode 100644 .patman base-commit: f28ca2447c5e2eef1ba6a3a11587380a665b0e26 -- 2.38.1 From debbugs-submit-bounces@debbugs.gnu.org Tue Dec 20 09:14:07 2022 Received: (at 60218) by debbugs.gnu.org; 20 Dec 2022 14:14:07 +0000 Received: from localhost ([127.0.0.1]:45137 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p7dNf-0002lC-5P for submit@debbugs.gnu.org; Tue, 20 Dec 2022 09:14:07 -0500 Received: from mail-qt1-f178.google.com ([209.85.160.178]:35496) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p7dNd-0002kh-IC for 60218@debbugs.gnu.org; Tue, 20 Dec 2022 09:14:06 -0500 Received: by mail-qt1-f178.google.com with SMTP id h26so7144302qtu.2 for <60218@debbugs.gnu.org>; Tue, 20 Dec 2022 06:14:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=0A+sSH/3E6+l4VR8tkaKg2fQCtA2zuiHriQyaH5Bo3Q=; b=YoNM/UPzV1MNoxr6sO83cdvdCJL4JNxdSPGIt69vhz9qjprLXq78QAqJiLW8dyUu4L sQepGzmDKDlCqi55Y2ktwuPxbsmpJUdnI+IGXxr5vpBaGYO6NPv7GTxdKi02rs7tTAK1 idq1suBtZDD0AiyhX/oFfBVE1DPaLdLC5YOt3A7aHQZ9ARB+5juVqDWPlF6EC9o3Ffva hUjHe8Apw3zFenW6AEJ/ihkr2WvK9tVIHBo6n4xYzUH0QEaXa+kHHvbVGUS5z/5XG1iB hgPqz2XVUsH+3+/3pYpSExQqNACZ5+qWI1f6RLiFUQiQQ8qBns9AjuVStH1RHIbRS2fr 3ibA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=0A+sSH/3E6+l4VR8tkaKg2fQCtA2zuiHriQyaH5Bo3Q=; b=50ZUkCTUcpOT/7qXCbY4mIwH8Kiy8x1GjVKGLnogDRTEo4l2V3ad50XPMdeXucJoMj tsfE6IXAZ3yDrzv680CF0efHRqzjN9qhzx1Z4KScHIrBiJRIwgFDXH5+Bq27m0t8pl/s smj6xOpq9J9CVggR5vq66RoTsXya/879g3TIK8aAnGOCSnnSaw+f+rdke0tFaVDmL5Oi SmqoIi5DgAA2d2M7KE195W3zd/RFntnfM5qSgzQReRN7co7eL8SbmQh7siiA1fLDwoqu 7WuY/fG0jH+fp/qj3d6E4HFs23NHT2JXJAZbi/zTd5tpwA34JkmW4RTTE4ZsYaDo+Scj 436w== X-Gm-Message-State: ANoB5plygsPJnvs4L8rInti77x/cNajaEgvWJMm3QSjz/2TdsJYFYrQd DyOGiNApNT40eNnPqzKnPb8LIn7TpQ3x5bky X-Google-Smtp-Source: AA0mqf67iF4Mt6uNgYG8pqP1nFqu8r6WmNbRSmHm6IRsNguARzFB2a9s/Z0rNbTVSZDhwXRnmQ/M0w== X-Received: by 2002:ac8:745:0:b0:3a8:325:47e with SMTP id k5-20020ac80745000000b003a80325047emr59543985qth.54.1671545639651; Tue, 20 Dec 2022 06:13:59 -0800 (PST) Received: from localhost.localdomain ([2607:fad8:4:3::1002]) by smtp.gmail.com with ESMTPSA id c3-20020ac80543000000b003a6a7a20575sm7691759qth.73.2022.12.20.06.13.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 20 Dec 2022 06:13:59 -0800 (PST) From: Maxim Cournoyer To: 60218@debbugs.gnu.org Subject: [PATCH 1/2] teams: Add a "get-maintainer" command. Date: Tue, 20 Dec 2022 09:13:29 -0500 Message-Id: <20221220141330.30372-1-maxim.cournoyer@gmail.com> X-Mailer: git-send-email 2.38.1 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 60218 Cc: Josselin Poiret , Tobias Geerinckx-Rice , Maxim Cournoyer , Simon Tournier , Mathieu Othacehe , =?UTF-8?q?Ludovic=20Court=C3=A8s?= , Christopher Baines , Ricardo Wurmus X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) This can be used as a compatibility mode with the get_maintainer.pl Perl script included in the Linux (or U-Boot) source tree. * etc/teams.scm.in (git-patch->commit-id): New procedure. (main) : Register new command. Document it. --- etc/teams.scm.in | 22 +++++++++++++++++++++- 1 file changed, 21 insertions(+), 1 deletion(-) diff --git a/etc/teams.scm.in b/etc/teams.scm.in index aa38a3b798..4f02df79d5 100644 --- a/etc/teams.scm.in +++ b/etc/teams.scm.in @@ -5,6 +5,7 @@ ;;; GNU Guix --- Functional package management for GNU ;;; Copyright © 2022 Ricardo Wurmus ;;; Copyright © 2022 Mathieu Othacehe +;;; Copyright © 2022 Maxim Cournoyer ;;; ;;; This file is part of GNU Guix. ;;; @@ -34,6 +35,7 @@ (ice-9 format) (ice-9 regex) (ice-9 match) + (ice-9 rdelim) (guix ui) (git)) @@ -608,6 +610,15 @@ (define (diff-revisions rev-start rev-end) (const 0)) files)) +(define (git-patch->commit-id file) + "Parse the commit ID from the first line of FILE, a patch produced with git." + (call-with-input-file file + (lambda (port) + (let ((m (string-match "^From ([0-9a-f]{40})" (read-line port)))) + (unless m + (error "invalid patch file:" file)) + (match:substring m 1))))) + (define (main . args) (match args @@ -616,6 +627,14 @@ (define (main . args) (("cc-members" rev-start rev-end) (apply cc (find-team-by-scope (diff-revisions rev-start rev-end)))) + (("get-maintainer" patch-file) + (let* ((rev-end (git-patch->commit-id patch-file)) + (rev-start (string-append rev-end "^"))) + (apply main "list-members" + (map symbol->string + (map team-id + (find-team-by-scope + (diff-revisions rev-start rev-end))))))) (("list-teams" . args) (list-teams)) (("list-members" . team-names) @@ -631,6 +650,7 @@ (define (main . args) cc get git send-email flags for cc-ing cc-members cc teams related to files changed between revisions list-teams list teams and their members - list-members list members belonging to ~%")))) + list-members list members belonging to ~% + get-maintainer compatibility mode with Linux get_maintainer.pl")))) (apply main (cdr (command-line))) base-commit: f28ca2447c5e2eef1ba6a3a11587380a665b0e26 -- 2.38.1 From debbugs-submit-bounces@debbugs.gnu.org Tue Dec 20 09:14:13 2022 Received: (at 60218) by debbugs.gnu.org; 20 Dec 2022 14:14:13 +0000 Received: from localhost ([127.0.0.1]:45142 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p7dNl-0002lT-Iy for submit@debbugs.gnu.org; Tue, 20 Dec 2022 09:14:13 -0500 Received: from mail-qt1-f180.google.com ([209.85.160.180]:41827) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p7dNj-0002lB-TP for 60218@debbugs.gnu.org; Tue, 20 Dec 2022 09:14:12 -0500 Received: by mail-qt1-f180.google.com with SMTP id c7so10968579qtw.8 for <60218@debbugs.gnu.org>; Tue, 20 Dec 2022 06:14:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=lyxmTJRL5ssfbt/HXRguiZQqR+CU4ou1BUAxycNVgaU=; b=ASZRifhpBWedKbQZheHwSh7prWNSDjsfXVh/vb46epunmbxUc/fxkyyAeC1mXlYBiY rXBS6t/TW2s3UjwAIS6z9rVj5bqkRyBMa1xc/ng7t14HHYDAYfiamPGuEv5J8kOpODIC gD52b42EBNfnw4oT9Kk82vRehEx4WjsqnP2KdaSjZd31JDZwkFXfsklsMtneNTpdugcx 9jx6myDlwt80R1WeauDWUYcQQ/2Yt77K6O+SNkKJ1OZyBKpEZngosgxSItN2Y/bE4d3O nG7IXluG4+ZCFkbW/90nw/frOTfAC0h/dz8W9ZbZPgLzV+j1dlEGV4ulGAUi9gDrXZPz Sw7g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=lyxmTJRL5ssfbt/HXRguiZQqR+CU4ou1BUAxycNVgaU=; b=bHLIF3SSQkmbOIn0fYeEgGHoQv8bZpMtIuhhNPnG7bBGg6P/itGmh7MzbfFb0TsJ86 a367dNb2Jb1yFs9uPAOx6It1DknHOLiPdZ/JpZQ0xKVaWUIR4uRepfkjvcOWQnVfhS8C Wg9k5QMlZYgDk1cCz0tYrsXoPFRhNFWqtli2ZEABEW/8tGm3BQv6c6K4CE74MS82Y92B 1i+x3kT69Wxfy30MeA8YXzCigpGWdhcn88HRJrGMab9kh+PvbFFSq9ZjI57Nw+lNG9GF wENUfTaAfQ0Ydb9b9LBMiRxbGMGOHgR7RX+QR3++/SG+4ZOH86G2+StBc6TZAYFdnHDT gFiw== X-Gm-Message-State: AFqh2kqetip9u1yqUC0jq7DWUEdiR0wWbu/gIzswf42YHTmnVE7tZzSc Rwl0XKvC5uGBw4BHCoiPQTdwUNbEORPU+w== X-Google-Smtp-Source: AMrXdXubDVZwY4X6t7k9eX88/9HAQBgHGMuwY7qm4eKd2+LocheuauaOAEeKDRxFG3hsN4gpg4rk6A== X-Received: by 2002:ac8:45da:0:b0:3a9:7cb5:3669 with SMTP id e26-20020ac845da000000b003a97cb53669mr17384442qto.32.1671545646241; Tue, 20 Dec 2022 06:14:06 -0800 (PST) Received: from localhost.localdomain ([2607:fad8:4:3::1002]) by smtp.gmail.com with ESMTPSA id c3-20020ac80543000000b003a6a7a20575sm7691759qth.73.2022.12.20.06.14.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 20 Dec 2022 06:14:05 -0800 (PST) From: Maxim Cournoyer To: 60218@debbugs.gnu.org Subject: [PATCH 2/2] .patman: New configuration file. Date: Tue, 20 Dec 2022 09:13:30 -0500 Message-Id: <20221220141330.30372-2-maxim.cournoyer@gmail.com> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20221220141330.30372-1-maxim.cournoyer@gmail.com> References: <20221220141330.30372-1-maxim.cournoyer@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 60218 Cc: Maxim Cournoyer X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) * .patman: New file. --- .patman | 9 +++++++++ 1 file changed, 9 insertions(+) create mode 100644 .patman diff --git a/.patman b/.patman new file mode 100644 index 0000000000..4708bb5ea8 --- /dev/null +++ b/.patman @@ -0,0 +1,9 @@ +# This config file allows for Patchwork integration with +# https://patches.guix-patches.cbaines.net/. +[settings] +project: guix-patches +patchwork_url: https://patches.guix-patches.cbaines.net +add_signoff: False +# TODO: enable check_patch +check_patch: False +get_maintainer_script: etc/teams.scm get-maintainer -- 2.38.1 From debbugs-submit-bounces@debbugs.gnu.org Sat Dec 24 18:23:26 2022 Received: (at 60218) by debbugs.gnu.org; 24 Dec 2022 23:23:26 +0000 Received: from localhost ([127.0.0.1]:47308 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p9DrS-0001ZD-1F for submit@debbugs.gnu.org; Sat, 24 Dec 2022 18:23:26 -0500 Received: from sender4-of-o51.zoho.com ([136.143.188.51]:21157) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p9DrQ-0001Z1-A7 for 60218@debbugs.gnu.org; Sat, 24 Dec 2022 18:23:24 -0500 ARC-Seal: i=1; a=rsa-sha256; t=1671924193; cv=none; d=zohomail.com; s=zohoarc; b=lZAc7/KTgb/XYyPyD9WpDREnTWZO7nnOQ58FPH4AjxbKQ3sKxwbhhEJCgDdFn/8kue0YcdhIlbP+wYy6PveEPrvZIYh7Ielh5Xi6uXCs39MdISt3w18tcDrpcVit3njXZ38w2WXmZtDQjDD7ehj1o3Xag3VmbOmUfKLlhX5OzO0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1671924193; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=3Rh9v4ovj5CQIYdtMwgi97xSbSnYfGmZF1N2fwYQiHw=; b=Oh85d23F9tpZnc7R8/uMOWojZ+h42Eb04qylFIUREAtKUziP2HvJ+ONzDfEw6GH5d6qJIborQSXVoD9uMPXlMq15s9UXD6s+TpQlNKoARXusjUYjbJynka4P4pHF7W6QF0f267Iha34zXrhZRo29t58WqZYrc+QFqakO9+pc9pI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=elephly.net; spf=pass smtp.mailfrom=rekado@elephly.net; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1671924193; s=zoho; d=elephly.net; i=rekado@elephly.net; h=References:From:From:To:To:Cc:Cc:Subject:Subject:Date:Date:In-reply-to:Message-ID:MIME-Version:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To; bh=3Rh9v4ovj5CQIYdtMwgi97xSbSnYfGmZF1N2fwYQiHw=; b=TwYm6eYhIgRpJteo7wuqTl328kMR7zbAxarFAIhmyvY0lEzob+DdFU4/suSXxXn6 6gttagj6I8sYypYM+zmr24riBQzOVDhIXyEClE60c+QgN/8yDctMbpFkNxDwtaP6QCP BPEqeo0C2bK0Hn2yD2b7oL609f4nTJ0OwihrvwO0= Received: from localhost (48-111-142-46.pool.kielnet.net [46.142.111.48]) by mx.zohomail.com with SMTPS id 1671924192504176.84511553363586; Sat, 24 Dec 2022 15:23:12 -0800 (PST) References: <20221220141330.30372-1-maxim.cournoyer@gmail.com> User-agent: mu4e 1.8.13; emacs 28.2 From: Ricardo Wurmus To: Maxim Cournoyer Subject: Re: [PATCH 1/2] teams: Add a "get-maintainer" command. Date: Sun, 25 Dec 2022 00:15:39 +0100 In-reply-to: <20221220141330.30372-1-maxim.cournoyer@gmail.com> X-URL: https://elephly.net X-PGP-Key: https://elephly.net/rekado.pubkey X-PGP-Fingerprint: BCA6 89B6 3655 3801 C3C6 2150 197A 5888 235F ACAC Message-ID: <87tu1kbd43.fsf@elephly.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-ZohoMailClient: External X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 60218 Cc: Josselin Poiret , Tobias Geerinckx-Rice , Simon Tournier , Mathieu Othacehe , Ludovic =?utf-8?Q?Court=C3=A8s?= , Christopher Baines , 60218@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi Maxim, > This can be used as a compatibility mode with the get_maintainer.pl Perl > script included in the Linux (or U-Boot) source tree. > > * etc/teams.scm.in (git-patch->commit-id): New procedure. > (main) : Register new command. Document it. Interesting. > @@ -616,6 +627,14 @@ (define (main . args) > (("cc-members" rev-start rev-end) > (apply cc (find-team-by-scope > (diff-revisions rev-start rev-end)))) > + (("get-maintainer" patch-file) > + (let* ((rev-end (git-patch->commit-id patch-file)) > + (rev-start (string-append rev-end "^"))) This is to get the changes introduced by this patch-file right? In a format that allows you to use =E2=80=9Cdiff-revisions=E2=80=9D below, which= you need to run find-team-by-scope. > + (apply main "list-members" > + (map symbol->string > + (map team-id > + (find-team-by-scope > + (diff-revisions rev-start rev-end))))))) Here I=E2=80=99d do (map (compose symbol->string team-id) =E2=80=A6) instead of mapping twice. I haven=E2=80=99t used get_maintainer.pl before, but I don=E2=80=99t object= to this change if it=E2=80=99s useful to you. --=20 Ricardo From debbugs-submit-bounces@debbugs.gnu.org Mon Dec 26 22:19:54 2022 Received: (at 60218) by debbugs.gnu.org; 27 Dec 2022 03:19:54 +0000 Received: from localhost ([127.0.0.1]:54436 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pA0VO-0003Af-1I for submit@debbugs.gnu.org; Mon, 26 Dec 2022 22:19:54 -0500 Received: from mail-qv1-f42.google.com ([209.85.219.42]:39838) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pA0VK-0003AQ-Nm for 60218@debbugs.gnu.org; Mon, 26 Dec 2022 22:19:53 -0500 Received: by mail-qv1-f42.google.com with SMTP id db16so3027221qvb.6 for <60218@debbugs.gnu.org>; Mon, 26 Dec 2022 19:19:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to; bh=aSamRnJLWsNI7tcq4FY6wFJiIXyoT0i6w80a7jTWcZI=; b=IYXFAZShVS3EhXjrnza2sINUoMfHXH4G3o8u13olSQ9RkqiVcJhPMQjR/s77heRn3H RcImWYuRtRcOGgmI26E0JUa92xFUqdaRMFT4cBeL8AkqpCwpf12ZGwjgEWngBjxSRwpy mmym+qf7J6y74ofQu013T73sBtdYJexfufypYZrdl9fLnC+xo4bNmJScjA4byr+36k7O 2UcaZ0KvyY3W0WAFvXJvHMU/lty3dcq+JHPiPbrxOHBrDqADP6rw//qMFHf7msxEVAqi MjrJrRFlqGEX277ndB9GZR+dDrHn/84GJp7ZThVwYDAAQEiH52ssv7Ya2dG940lBQMT9 qpdg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=aSamRnJLWsNI7tcq4FY6wFJiIXyoT0i6w80a7jTWcZI=; b=V0dEEyki5PNrkUjWxiMayDStmEy86VW/hk8WRW+yP4PSf3FBrdm9t96xDT0NiqGmaT REoU/KLgGifYsXNMbWttBtQYhHroltE/tKRHJBPmC8DhCeycQfjiEYf/dZKlVoraAv34 VrNJNNufOmxid2dWzPNjTIqOdSB63fc11FXxISu3nxG4H2Ygsu3xvQqA7NydBGQA1B2i XaqTlYJzmYPwyJ8SVlYybLC+GypQUmuGwYj22MvrTkuF8dzvVPv9LG4wQU4Yc//L2cK3 +Mm1Q2LPaxKYlm4kk0aU6Qj9B25hsVaGZbi0CQQS1HjtRLLd4RQSBUgmuUAprTT2g3q/ SDGg== X-Gm-Message-State: AFqh2krk8788KYm96F6oqamT5453fEDd5WCO1tTIxef6s0uNQ9Q5oG7V F5qE6swdDtMkXyDx4ibZmC8= X-Google-Smtp-Source: AMrXdXu4rMBOPcfIZjAO5JvTqOhIiwKJLYurXknV7n4lWBd63sDhL4Zc2HwE99upLMKr5mwGDwRpfw== X-Received: by 2002:a05:6214:3608:b0:531:8652:43a0 with SMTP id nv8-20020a056214360800b00531865243a0mr6078393qvb.27.1672111185185; Mon, 26 Dec 2022 19:19:45 -0800 (PST) Received: from hurd (dsl-10-129-132.b2b2c.ca. [72.10.129.132]) by smtp.gmail.com with ESMTPSA id q22-20020a05620a0d9600b006eee3a09ff3sm6526qkl.69.2022.12.26.19.19.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 26 Dec 2022 19:19:44 -0800 (PST) From: Maxim Cournoyer To: Ricardo Wurmus Subject: Re: [PATCH 1/2] teams: Add a "get-maintainer" command. References: <20221220141330.30372-1-maxim.cournoyer@gmail.com> <87tu1kbd43.fsf@elephly.net> Date: Mon, 26 Dec 2022 22:19:43 -0500 In-Reply-To: <87tu1kbd43.fsf@elephly.net> (Ricardo Wurmus's message of "Sun, 25 Dec 2022 00:15:39 +0100") Message-ID: <87cz858re8.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 60218 Cc: Josselin Poiret , Tobias Geerinckx-Rice , Simon Tournier , Mathieu Othacehe , Ludovic =?utf-8?Q?Court=C3=A8s?= , Christopher Baines , 60218@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi Ricardo, Ricardo Wurmus writes: > Hi Maxim, > >> This can be used as a compatibility mode with the get_maintainer.pl Perl >> script included in the Linux (or U-Boot) source tree. >> >> * etc/teams.scm.in (git-patch->commit-id): New procedure. >> (main) : Register new command. Document it. > > Interesting. > >> @@ -616,6 +627,14 @@ (define (main . args) >> (("cc-members" rev-start rev-end) >> (apply cc (find-team-by-scope >> (diff-revisions rev-start rev-end)))) >> + (("get-maintainer" patch-file) >> + (let* ((rev-end (git-patch->commit-id patch-file)) >> + (rev-start (string-append rev-end "^"))) > > This is to get the changes introduced by this patch-file right? In a > format that allows you to use =E2=80=9Cdiff-revisions=E2=80=9D below, whi= ch you need to > run find-team-by-scope. Yes! The get-maintainer.pl script expects a single patch file rather than two git refspecs. >> + (apply main "list-members" >> + (map symbol->string >> + (map team-id >> + (find-team-by-scope >> + (diff-revisions rev-start rev-end))))))) > > Here I=E2=80=99d do > > (map (compose symbol->string team-id) =E2=80=A6) > > instead of mapping twice. Thanks, that's better. Adjusted locally. > I haven=E2=80=99t used get_maintainer.pl before, but I don=E2=80=99t obje= ct to this > change if it=E2=80=99s useful to you. It's useful in conjunction with patman (which is patch 2/2 of this series), which can be configured to use a get-maintainer like script to retrieve the people it should CC based on the patches it can 'git send-email' for you. If nobody else has a say, I'll push in about a week. Thanks for taking a look! --=20 Maxim From debbugs-submit-bounces@debbugs.gnu.org Tue Dec 27 05:00:36 2022 Received: (at 60218) by debbugs.gnu.org; 27 Dec 2022 10:00:36 +0000 Received: from localhost ([127.0.0.1]:54749 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pA6lA-0005O3-90 for submit@debbugs.gnu.org; Tue, 27 Dec 2022 05:00:36 -0500 Received: from eggs.gnu.org ([209.51.188.92]:41132) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pA6l8-0005Nq-2L for 60218@debbugs.gnu.org; Tue, 27 Dec 2022 05:00:34 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pA6kz-0007H4-Fq; Tue, 27 Dec 2022 05:00:27 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=9x8svpHEdU5/2tcjyn30gfaR+EAeWjQh2aHvl8Nmd1M=; b=sCRLvGgB5V+xQB+878yG sS7cMeyhLNmM8T41HURcnDwfl1gzHKvDJO01QLw9PYl1niF3CR4kE2gWQ2wROVubbVe6cLclFx3u2 snUVvmi4Fv1P7w3aB/fGGWlF64rMRuS1D/viqpISPMxu7WRAmz4V/SCeutcM5nl8FhkhXP5f38k3V lRhkDD6s2qfNZI0dCgP3kK+1ObDngCXPuXD3CByFv6BqMVhYPuUFvS8uncJdIZpIrXgceNZeXcTo4 +3Q1bwxnC2psA5gkzdiL3aLsaWtEmpz13OeaCLpKVIngREA+bMQR7/1Nrb7ACpjc1N2uoxcjAkGFX XPBqfevqx98Brw==; Received: from [2a01:cb18:832e:5f00:3563:417e:2a38:86d8] (helo=meije) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pA6kt-0008EP-TO; Tue, 27 Dec 2022 05:00:24 -0500 From: Mathieu Othacehe To: Maxim Cournoyer Subject: Re: bug#60218: [PATCH 0/2] New teams.scm 'get-maintainer' command (for integration with patman) References: <20221220135810.28175-1-maxim.cournoyer@gmail.com> <20221220141330.30372-1-maxim.cournoyer@gmail.com> Date: Tue, 27 Dec 2022 11:00:17 +0100 In-Reply-To: <20221220141330.30372-1-maxim.cournoyer@gmail.com> (Maxim Cournoyer's message of "Tue, 20 Dec 2022 09:13:29 -0500") Message-ID: <87pmc5maj2.fsf_-_@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 60218 Cc: Ricardo Wurmus , Josselin Poiret , Christopher Baines , Simon Tournier , Ludovic =?utf-8?Q?Court=C3=A8s?= , Tobias Geerinckx-Rice , 60218@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hey Maxim, > cc get git send-email flags for cc-ing > cc-members cc teams related to files changed between revisions > list-teams list teams and their members > - list-members list members belonging to ~%")))) > + list-members list members belonging to ~% > + get-maintainer compatibility mode with Linux get_maintainer.pl")))) Maybe it could be interesting to also add this patch mode to the cc-members command, this way for instance: cc-members [ | ...] and also have the get-maintainer command for compatibility with other tools? Thanks, Mathieu From debbugs-submit-bounces@debbugs.gnu.org Tue Dec 27 10:33:08 2022 Received: (at 60218) by debbugs.gnu.org; 27 Dec 2022 15:33:08 +0000 Received: from localhost ([127.0.0.1]:56322 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pABwy-0004lv-3y for submit@debbugs.gnu.org; Tue, 27 Dec 2022 10:33:08 -0500 Received: from mail-yw1-f175.google.com ([209.85.128.175]:40577) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pABww-0004lO-6C for 60218@debbugs.gnu.org; Tue, 27 Dec 2022 10:33:07 -0500 Received: by mail-yw1-f175.google.com with SMTP id 00721157ae682-381662c78a9so187990947b3.7 for <60218@debbugs.gnu.org>; Tue, 27 Dec 2022 07:33:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=s57eGhr74kAsANfbP2lLgpfygKdXVKHuxDI4py3egv8=; b=aLQvYGAz0jZ4vmdpwbXde/h+36D8+cck3SLNgPo20RWWi6PNYkmxFjgetK88aTAJWo AS46P7+EWX1wH8HTNXYE7tQfsuFRy4G9sQXcRa9BFJ4cakp1P/GpqddrptYtH9w3JQo1 4kztN64XuC5XIULYTDOG8QBkUNoP/F2SxHoyggdBOkRMoZyRKjGUE4EPrEhrQI/bWCTN 9X0UV/lGf4uEPL9cC25suoVGzGuovcsYY3TLUNfUp8klUeriTkKdMURNZhRC2zt9gz5e tamteOD0pSeAkh07btiVHY99po+XlUt+VY1mQWhUzrkf1UF1Rw1chJyvgJ3HXxdNqFET RykA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=s57eGhr74kAsANfbP2lLgpfygKdXVKHuxDI4py3egv8=; b=tqr/orKvWZVK/coBPtWyfzGsvfDDYktMbWULtUwt2x/qiQYDm8BBwAdLYkgZrKmPjh eGHm7EchoNvoQiNhlrwh2VG5RU913Ze9Plakj78K3G3L5sgkQUUP10ZG/CSHaDGJQhkf 2gbgbKRmvRbFcbzcsN2V8pRmRN6s/1g/XHyr71FQ16LdWochMYiKPnP1Q+iT06rAmb15 XOjfMCp7jP0hukIHOnV7Ea663yYnEMFfUZ/iAjawbYjIJ/5Kx/e+Di1GsvhwUh8DYnf0 dfbBW4r7iqEwYRrmfqhdrG3IUIhp/3+S4I23xILEQCsDDXyE57LhZ38s7WpmFGFr5/2A lp8w== X-Gm-Message-State: AFqh2kpkuBUllsWADLTbLugjSFBjEVYXVfL6bgvGShLkIetC+Fy/LFmi o1dRzLbHvlJHjWIj60cFUt+s/ab5Z4N4Xg== X-Google-Smtp-Source: AMrXdXsy0O7HDcsAvVTgtjHz4zhOBYQOTce2JHk4XK1QPMK66NDxM1KeD/71x1+ozNq+8n2NWMZArg== X-Received: by 2002:a05:7508:1318:b0:47:1cbf:91e0 with SMTP id cr24-20020a057508131800b000471cbf91e0mr1340182gbb.6.1672155180360; Tue, 27 Dec 2022 07:33:00 -0800 (PST) Received: from localhost.localdomain (dsl-10-129-132.b2b2c.ca. [72.10.129.132]) by smtp.gmail.com with ESMTPSA id bp13-20020a05620a458d00b006fefa5f7fc9sm9505322qkb.134.2022.12.27.07.32.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 27 Dec 2022 07:32:59 -0800 (PST) From: Maxim Cournoyer To: 60218@debbugs.gnu.org Subject: [PATCH v2 1/3] teams: Add a "get-maintainer" command. Date: Tue, 27 Dec 2022 10:32:46 -0500 Message-Id: <20221227153249.16793-1-maxim.cournoyer@gmail.com> X-Mailer: git-send-email 2.38.1 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 60218 Cc: rekado@elephly.net, othacehe@gnu.org, Maxim Cournoyer X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) This can be used as a compatibility mode with the get_maintainer.pl Perl script included in the Linux (or U-Boot) source tree. * etc/teams.scm.in (git-patch->commit-id): New procedure. (main) : Register new command. Document it. --- Changes in v2: - Move newline character (~%) in usage output to the bottom etc/teams.scm.in | 20 +++++++++++++++++++- 1 file changed, 19 insertions(+), 1 deletion(-) diff --git a/etc/teams.scm.in b/etc/teams.scm.in index f42a7f6f28..e50efea786 100644 --- a/etc/teams.scm.in +++ b/etc/teams.scm.in @@ -5,6 +5,7 @@ ;;; GNU Guix --- Functional package management for GNU ;;; Copyright © 2022 Ricardo Wurmus ;;; Copyright © 2022 Mathieu Othacehe +;;; Copyright © 2022 Maxim Cournoyer ;;; ;;; This file is part of GNU Guix. ;;; @@ -34,6 +35,7 @@ (ice-9 format) (ice-9 regex) (ice-9 match) + (ice-9 rdelim) (guix ui) (git)) @@ -623,6 +625,15 @@ (define (diff-revisions rev-start rev-end) (const 0)) files)) +(define (git-patch->commit-id file) + "Parse the commit ID from the first line of FILE, a patch produced with git." + (call-with-input-file file + (lambda (port) + (let ((m (string-match "^From ([0-9a-f]{40})" (read-line port)))) + (unless m + (error "invalid patch file:" file)) + (match:substring m 1))))) + (define (main . args) (match args @@ -631,6 +642,12 @@ (define (main . args) (("cc-members" rev-start rev-end) (apply cc (find-team-by-scope (diff-revisions rev-start rev-end)))) + (("get-maintainer" patch-file) + (let* ((rev-end (git-patch->commit-id patch-file)) + (rev-start (string-append rev-end "^"))) + (apply main "list-members" + (map (compose symbol->string team-id) + (find-team-by-scope (diff-revisions rev-start rev-end)))))) (("list-teams" . args) (list-teams)) (("list-members" . team-names) @@ -646,6 +663,7 @@ (define (main . args) cc get git send-email flags for cc-ing cc-members cc teams related to files changed between revisions list-teams list teams and their members - list-members list members belonging to ~%")))) + list-members list members belonging to + get-maintainer compatibility mode with Linux get_maintainer.pl~%")))) (apply main (cdr (command-line))) base-commit: 8f93a1e01a879ae026678dd92c18e2a2a49be540 -- 2.38.1 From debbugs-submit-bounces@debbugs.gnu.org Tue Dec 27 10:33:12 2022 Received: (at 60218) by debbugs.gnu.org; 27 Dec 2022 15:33:12 +0000 Received: from localhost ([127.0.0.1]:56325 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pABx1-0004mD-Jz for submit@debbugs.gnu.org; Tue, 27 Dec 2022 10:33:12 -0500 Received: from mail-yw1-f181.google.com ([209.85.128.181]:38516) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pABwz-0004lm-W5 for 60218@debbugs.gnu.org; Tue, 27 Dec 2022 10:33:10 -0500 Received: by mail-yw1-f181.google.com with SMTP id 00721157ae682-43ea87d0797so188193777b3.5 for <60218@debbugs.gnu.org>; Tue, 27 Dec 2022 07:33:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=vhub/hLekYxvyb67s2Cy4GEUHPeUb02MaNQEko9gUWM=; b=g+5RgQwVeAo+aahr1mfHhJp9FikmM6zwFoVe9FEwadr/97POjmj3mkKMjK0lPqvMAM Uenpy7f+SigBu7yvhIH5iBvSYjXv1DoFON3FFtCHjzbcGr/FSegG8237kOI+AmwMuaFi tHKTA8AA4PvexX/j7g416Pv8yiyaUVrIZVizkfpTnLrWlK3nKpGuu03+F+CsjoOYiJrn Pyq2LTPt38XKOStkyTBVEMGO6C0eUz4n3NJNErgUcLQNBlipo8Hs1Dof+OxkBj9WjMcj JuRUQEMiy7H9k63ExRHAclWSPHySv7BUYxJ3iBnpkO4dv2nytbC81oFJcX0aaaKVdEVE 7nvg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=vhub/hLekYxvyb67s2Cy4GEUHPeUb02MaNQEko9gUWM=; b=JJBhbRGcEh8LCo5HBu9jxCwtKN+n8kRgL1XpMAcN7FJidhJvkRR5w7Fh8ctUccxC/H RgP+VoW8SGn9QQ+iQEcZAJfrGCmxzGezUACFkxTBbDYjS2KANy01XuvDANVGtrtMqtrv 7sScReKIVg2fRnds3n1Hb9Cd+DUv+DmmPzX0KKxFM1/ObQg5SmIvJEQL0tHIB3X2IoTL OUA35jHZNVjo+nZOOpdojZxDV2HQJbiX0QLSVwAMtNAXvF6JaAfYAbtFZhusQwfDnl0R 73ZkhyWLjR+/0JiUAg+Z++io/QCJYk5mSZosiEWpNNyGpTxLasCBr5Jgvgu25daxZvh3 HvGA== X-Gm-Message-State: AFqh2krW80qSJvRkVmOCYNLFxzSMkbWKebq4APh9e5XkSrCt6K1O3SCk yHvo959p9qNGvn57I7NPWS9qNS/wzJ/QRA== X-Google-Smtp-Source: AMrXdXtKq6EY/rPU+Kq2E90xBgzGyMp1pcimNnKXyWh5fZB35EigVQAaS6zViL5t2VQ4LH14OKe/DQ== X-Received: by 2002:a05:7500:2486:b0:ec:9852:28c8 with SMTP id ba6-20020a057500248600b000ec985228c8mr1261500gab.74.1672155184239; Tue, 27 Dec 2022 07:33:04 -0800 (PST) Received: from localhost.localdomain (dsl-10-129-132.b2b2c.ca. [72.10.129.132]) by smtp.gmail.com with ESMTPSA id bp13-20020a05620a458d00b006fefa5f7fc9sm9505322qkb.134.2022.12.27.07.33.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 27 Dec 2022 07:33:03 -0800 (PST) From: Maxim Cournoyer To: 60218@debbugs.gnu.org Subject: [PATCH v2 2/3] teams: Allow a patch-file argument to cc-members. Date: Tue, 27 Dec 2022 10:32:47 -0500 Message-Id: <20221227153249.16793-2-maxim.cournoyer@gmail.com> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20221227153249.16793-1-maxim.cournoyer@gmail.com> References: <20221227153249.16793-1-maxim.cournoyer@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 60218 Cc: rekado@elephly.net, othacehe@gnu.org, Maxim Cournoyer X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) * etc/teams.scm.in (git-patch->revisions): New procedure. (main) [cc-members]: New match pattern to support patch file argument. [get-maintainer]: Simplify using the newly introduced procedure from above. (main): Update usage doc. --- Changes in v2: - New: support passing a patch file to the cc-members command etc/teams.scm.in | 34 ++++++++++++++++++++++++---------- 1 file changed, 24 insertions(+), 10 deletions(-) diff --git a/etc/teams.scm.in b/etc/teams.scm.in index e50efea786..96a04aca3d 100644 --- a/etc/teams.scm.in +++ b/etc/teams.scm.in @@ -634,20 +634,29 @@ (define (git-patch->commit-id file) (error "invalid patch file:" file)) (match:substring m 1))))) +(define (git-patch->revisions file) + "Return the start and end revisions of FILE, a patch file produced with git." + (let* ((rev-end (git-patch->commit-id file)) + (rev-start (string-append rev-end "^"))) + (list rev-start rev-end))) + (define (main . args) (match args (("cc" . team-names) (apply cc (map find-team team-names))) + (("cc-members" patch-file) + (unless (file-exists? patch-file) + (error "patch file does not exist:" patch-file)) + (apply main "cc-members" (git-patch->revisions patch-file))) (("cc-members" rev-start rev-end) (apply cc (find-team-by-scope (diff-revisions rev-start rev-end)))) (("get-maintainer" patch-file) - (let* ((rev-end (git-patch->commit-id patch-file)) - (rev-start (string-append rev-end "^"))) - (apply main "list-members" - (map (compose symbol->string team-id) - (find-team-by-scope (diff-revisions rev-start rev-end)))))) + (apply main "list-members" + (map (compose symbol->string team-id) + (find-team-by-scope (apply diff-revisions + (git-patch->revisions patch-file)))))) (("list-teams" . args) (list-teams)) (("list-members" . team-names) @@ -660,10 +669,15 @@ (define (main . args) "Usage: etc/teams.scm [] Commands: - cc get git send-email flags for cc-ing - cc-members cc teams related to files changed between revisions - list-teams list teams and their members - list-members list members belonging to - get-maintainer compatibility mode with Linux get_maintainer.pl~%")))) + cc + get git send-email flags for cc-ing + cc-members | patch + cc teams related to files changed between revisions or in a patch file + list-teams + list teams and their members + list-members + list members belonging to + get-maintainer + compatibility mode with Linux get_maintainer.pl~%")))) (apply main (cdr (command-line))) -- 2.38.1 From debbugs-submit-bounces@debbugs.gnu.org Tue Dec 27 10:33:17 2022 Received: (at 60218) by debbugs.gnu.org; 27 Dec 2022 15:33:17 +0000 Received: from localhost ([127.0.0.1]:56328 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pABx7-0004mW-2l for submit@debbugs.gnu.org; Tue, 27 Dec 2022 10:33:17 -0500 Received: from mail-oi1-f180.google.com ([209.85.167.180]:46939) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pABx5-0004mB-TY for 60218@debbugs.gnu.org; Tue, 27 Dec 2022 10:33:16 -0500 Received: by mail-oi1-f180.google.com with SMTP id r11so12648636oie.13 for <60218@debbugs.gnu.org>; Tue, 27 Dec 2022 07:33:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=kBtuwcSSiYTwcaJIJD9+C32WT92k6KmKJvscisIZR9k=; b=aOUUUn1pMxyfUdU4HUMUEZSK1erOG3eJicxMC3ZY/FLWX0zJFhJAP2H6DsdzceKmde i0TQXlxU1gVKYhCwzzXGMtlgp42HeXva6P5W6TyLH3BgkAljYGpd0xZqc8NuS1zHepuJ a5es6pzUIcDGlTeevpyIKb4x5y8PToUssW+QoqWJKwAN+IZ2sBzxnOJIk1TFQRUy+tEf FQntOt9siV6weUvm3SCWIWZwdEcWM+PEuzYs72GNk8JvCHrccrCePOQEpV1mdA55nKdm nCa4hCb3dJoETum/YEt9gjpmB/ztUGWMYbQu6t/NOegp8X47908HagPkLPfMJyrrgxJw tfhA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=kBtuwcSSiYTwcaJIJD9+C32WT92k6KmKJvscisIZR9k=; b=lm2B8nlYC1jiyvV/d/D3MkOb54k4efkm7pD3tc6UNnmjM7++vSJtoeBmD4/MdsWiZS dbAsTvSPPHYtbnefWFqiLOq/7rpHeaU5g4DYe7SiF2ZUYI+7N+ev6UjcTyk0yNvEt9Ii +V/N+oFE90oeVzvWfebmGBiANPalsyAdnu0ygkmEGAuxLUUmMucpny0CKpXSo0viZrOg Aioe1mhRg4xgLi0ydZW71ZUmIgQbfF7SfJf3Hwa3QLOjcPhl4fZfwSl1xRm02QJ2PIn3 AjStcJz5JmU1u2guh5qsFbMmaFzqpnRGay5U1ZMo7H4NKqPp0Z8B7ySZw3aXzccXJT2R damQ== X-Gm-Message-State: AFqh2konozxdJpfSbN7hnPn4zh3WWOpA8vOxkaDLOMLvStn9yb2/aic/ X8B+hHJUD3HXj+BvetUwjQ0ebfKr/HV7FA== X-Google-Smtp-Source: AMrXdXsQmAhvifhCcqwwG0oxxCJFBI8+KGN9Lq3dOY0wCSL+QAUyZ2Tpe6CB7nkERYd+LkZuJUw8vg== X-Received: by 2002:aca:3d57:0:b0:35e:d5f9:62e7 with SMTP id k84-20020aca3d57000000b0035ed5f962e7mr14780147oia.34.1672155190129; Tue, 27 Dec 2022 07:33:10 -0800 (PST) Received: from localhost.localdomain (dsl-10-129-132.b2b2c.ca. [72.10.129.132]) by smtp.gmail.com with ESMTPSA id bp13-20020a05620a458d00b006fefa5f7fc9sm9505322qkb.134.2022.12.27.07.33.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 27 Dec 2022 07:33:09 -0800 (PST) From: Maxim Cournoyer To: 60218@debbugs.gnu.org Subject: [PATCH v2 3/3] .patman: New configuration file. Date: Tue, 27 Dec 2022 10:32:48 -0500 Message-Id: <20221227153249.16793-3-maxim.cournoyer@gmail.com> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20221227153249.16793-1-maxim.cournoyer@gmail.com> References: <20221227153249.16793-1-maxim.cournoyer@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 60218 Cc: rekado@elephly.net, othacehe@gnu.org, Maxim Cournoyer X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) * .patman: New file. --- (no changes since v1) .patman | 9 +++++++++ 1 file changed, 9 insertions(+) create mode 100644 .patman diff --git a/.patman b/.patman new file mode 100644 index 0000000000..4708bb5ea8 --- /dev/null +++ b/.patman @@ -0,0 +1,9 @@ +# This config file allows for Patchwork integration with +# https://patches.guix-patches.cbaines.net/. +[settings] +project: guix-patches +patchwork_url: https://patches.guix-patches.cbaines.net +add_signoff: False +# TODO: enable check_patch +check_patch: False +get_maintainer_script: etc/teams.scm get-maintainer -- 2.38.1 From debbugs-submit-bounces@debbugs.gnu.org Tue Dec 27 10:35:20 2022 Received: (at 60218) by debbugs.gnu.org; 27 Dec 2022 15:35:20 +0000 Received: from localhost ([127.0.0.1]:56339 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pABz6-0004qJ-HR for submit@debbugs.gnu.org; Tue, 27 Dec 2022 10:35:20 -0500 Received: from mail-yb1-f177.google.com ([209.85.219.177]:45994) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pABz4-0004ps-T8 for 60218@debbugs.gnu.org; Tue, 27 Dec 2022 10:35:19 -0500 Received: by mail-yb1-f177.google.com with SMTP id n78so14718749yba.12 for <60218@debbugs.gnu.org>; Tue, 27 Dec 2022 07:35:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=ZR99+XNGVHGFPBeJ4x8kw33KqjqS0iPXVZ+HgQt0w9U=; b=WBB0xLMp3LleVEKElp3yiRykhNCdT7cKr3SSXKZNK6CIuggrDKkE0Qco12DN9wxGWx NksY6q4EwxF8tXxQBxBudpCSAgWgYDqlTUeZe0d4jHSc8yD8A5p0kAGUXVSomYsIj/Ma r5KLDoeEj54nWC/9lj86E/TvpgizEoSaYp0xKuMw8xjafl5GjEuyKUbV31UkljpH4njI qNasOClF0VN3CkMPeHzyq5u5WeKCSZ3RggDRiU+1PnI4lTNtwhMcaxpPhnaY0P9YuvAk 5cAE0tsliin61y8l0InNgOXsVz6XE34STvk7VQd1t1DApKSkNCtf8DUhSYgn5MWMgLO8 cErQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=ZR99+XNGVHGFPBeJ4x8kw33KqjqS0iPXVZ+HgQt0w9U=; b=VdIAps1WLM8P1eeyroP40Mk6MEHJ93Yd2GYPzossfNMScSkKxn0D32u9EeMWBFrdtv fkqOT6suJ38mjr7Vyy14WwjS7qCtdNJM2wZbi/MPsWAAAqD/vqLU9/mv3ZtiTarCl2lk I88XYCUBnAYXcJtHa9LiKCKT/c8ClKFbIx3rKbTA2fyZDXCuKROdBCIxMcaRz6vfPda/ Aqaundt+Fw/oBpNnws2FKJwuLjKP8mvp/+Bzq6op76eN5y0K8S4Q/f9Y8MC7bb1sZLNI BNazYO2OUAFvZSaEu7FtUaTwW2qJ/fZTzBN4SaTHcdrmj5AM+F4X3FKUE4B6VrfXxcqK 4vdQ== X-Gm-Message-State: AFqh2kraMf398gnMXo7XpS7s7Cz8zJwFR+9JaSV3tFunlGYTUOFHYOOo GO1C8HtxBwYBGo3265S5tfw= X-Google-Smtp-Source: AMrXdXtnHH3kSVR5I0xGRHtGNlR2S3cNVL0W3N0Ox6x4WUS8HV/KxAqwvoIReetZhEtKCOvhCReqoQ== X-Received: by 2002:a25:d281:0:b0:6fa:13a1:bf6b with SMTP id j123-20020a25d281000000b006fa13a1bf6bmr25595554ybg.3.1672155313475; Tue, 27 Dec 2022 07:35:13 -0800 (PST) Received: from hurd (dsl-10-129-132.b2b2c.ca. [72.10.129.132]) by smtp.gmail.com with ESMTPSA id bp33-20020a05620a45a100b006e99290e83fsm1094819qkb.107.2022.12.27.07.35.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 27 Dec 2022 07:35:13 -0800 (PST) From: Maxim Cournoyer To: Mathieu Othacehe Subject: Re: bug#60218: [PATCH 0/2] New teams.scm 'get-maintainer' command (for integration with patman) References: <20221220135810.28175-1-maxim.cournoyer@gmail.com> <20221220141330.30372-1-maxim.cournoyer@gmail.com> <87pmc5maj2.fsf_-_@gnu.org> Date: Tue, 27 Dec 2022 10:35:12 -0500 In-Reply-To: <87pmc5maj2.fsf_-_@gnu.org> (Mathieu Othacehe's message of "Tue, 27 Dec 2022 11:00:17 +0100") Message-ID: <8735907tcf.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 60218 Cc: Ricardo Wurmus , Josselin Poiret , Christopher Baines , Simon Tournier , Ludovic =?utf-8?Q?Court=C3=A8s?= , Tobias Geerinckx-Rice , 60218@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi Mathieu, Mathieu Othacehe writes: > Hey Maxim, > >> cc get git send-email flags for cc-ing >> cc-members cc teams related to files changed between revisions >> list-teams list teams and their members >> - list-members list members belonging to ~%")))) >> + list-members list members belonging to ~% >> + get-maintainer compatibility mode with Linux get_maintainer.pl")))) > > Maybe it could be interesting to also add this patch mode to the > cc-members command, this way for instance: > > cc-members [ | ...] Implemented in v2! I guess it could be useful. Note that it doesn't parse the patch for the file names touched, instead it assumes the patch was produced from a commit registered in git and then use the usual code path (for simplicity). -- Thanks, Maxim From debbugs-submit-bounces@debbugs.gnu.org Wed Dec 28 12:22:31 2022 Received: (at 60218) by debbugs.gnu.org; 28 Dec 2022 17:22:31 +0000 Received: from localhost ([127.0.0.1]:58528 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pAa8M-0000oc-M9 for submit@debbugs.gnu.org; Wed, 28 Dec 2022 12:22:30 -0500 Received: from eggs.gnu.org ([209.51.188.92]:36670) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pAa8L-0000oL-0B for 60218@debbugs.gnu.org; Wed, 28 Dec 2022 12:22:29 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pAa8E-0000VR-LV; Wed, 28 Dec 2022 12:22:22 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=WIZ8dBgtu+5FU2D8hZmF1Ezr2AhpqNbYxJYxB17ULuk=; b=iBMqCu4UvdjdMZgQ/ntV /yimfVuWPIcy9/iu+zYCMPSi13sINtMaepuT3de5zZPLCO+ZWiEVWSWjmDq01t6ai338WmuA6RPk6 unB1rcWk/44zXidLPjXeL3HQ6OIAzWOnnTgXvgc07vy+Nx4v9BYM2Sw8W0kywRC993ONrcv4aHFJ3 USMgLwhAY2qcpIoJJSHQFPjFhDzoWrjWuNxT8FThAbNruSbylO34Bu/mplCi6qA0/4SKYhTrFa2JI Y8eAhxDNoChLhE4LXqkSxdGUlV043uMi/ZwFrS/0jLZoGB/URJZ8EUzVGvqjew5SMRQK2A2oIFN9e FlF/DY6AmtS7qA==; Received: from [2a01:cb18:832e:5f00:3563:417e:2a38:86d8] (helo=meije) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pAa8D-0007Lg-V3; Wed, 28 Dec 2022 12:22:22 -0500 From: Mathieu Othacehe To: Maxim Cournoyer Subject: Re: bug#60218: [PATCH 0/2] New teams.scm 'get-maintainer' command (for integration with patman) References: <20221220135810.28175-1-maxim.cournoyer@gmail.com> <20221220141330.30372-1-maxim.cournoyer@gmail.com> <87pmc5maj2.fsf_-_@gnu.org> <8735907tcf.fsf@gmail.com> Date: Wed, 28 Dec 2022 18:22:18 +0100 In-Reply-To: <8735907tcf.fsf@gmail.com> (Maxim Cournoyer's message of "Tue, 27 Dec 2022 10:35:12 -0500") Message-ID: <87v8lvwiid.fsf_-_@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 60218 Cc: 60218@debbugs.gnu.org, Josselin Poiret , Christopher Baines , Simon Tournier , Ludovic =?utf-8?Q?Court=C3=A8s?= , Tobias Geerinckx-Rice , Ricardo Wurmus X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hey, > Implemented in v2! I guess it could be useful. Note that it doesn't > parse the patch for the file names touched, instead it assumes the patch > was produced from a commit registered in git and then use the usual code > path (for simplicity). Nice! I think that it is fair to assume that the commit is registered in the local git repository. As a follow-up a documentation update could also be interesting as I think that the new 'cc-members patch' command is easier to use that the 'cc-member start end' variant. I had a look to the rest of the patchset it seems fine to me :) Thanks, Mathieu From debbugs-submit-bounces@debbugs.gnu.org Wed Dec 28 15:42:12 2022 Received: (at 60218-done) by debbugs.gnu.org; 28 Dec 2022 20:42:12 +0000 Received: from localhost ([127.0.0.1]:58790 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pAdFb-0005O1-Qi for submit@debbugs.gnu.org; Wed, 28 Dec 2022 15:42:12 -0500 Received: from mail-qt1-f176.google.com ([209.85.160.176]:45629) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pAdFa-0005Nn-7a for 60218-done@debbugs.gnu.org; Wed, 28 Dec 2022 15:42:10 -0500 Received: by mail-qt1-f176.google.com with SMTP id h21so13540480qta.12 for <60218-done@debbugs.gnu.org>; Wed, 28 Dec 2022 12:42:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=1Swf5hW67M8Wds+/mBcEzJBUvElyPkevxg2KUvDbcW4=; b=Ry1BW/mMlEi5/LbMf/60wIM9CdEMw9/aubvYoRKcHu8+K31bHa53oeGhx8e7Yr86AP kmc/Fdm7os2T/8Bl0I70R29nbn1qLn39LxfrLtnBEL8XK+/O08u/NfEeLicOFFTBItN1 mjLMdF5i2BNLwKmJmGZJVf27K4vMO+jB020AOBlu8GFlJIHc8lk/Mj73yseEesom2oiZ mglzSVXGEKxebl4V5etDPfUPcNf1bG179/UqKW4cEfU6wXjERrJXNf2OQ9+/rxZVdkcI stT1r3LWjznPj0RRBwyyhH31G8dLYN9g5BTIvS1vRloRz8uBntIaWBem2G+DPyUOXzNY SdUw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=1Swf5hW67M8Wds+/mBcEzJBUvElyPkevxg2KUvDbcW4=; b=oeFO9Zd7M8COpCemDJVF2PmaGUlmmjwvmrxmUnnlnJztXOn0Z+gr6MBFw85oJ4Ebzw nYiyr/EdjmjWdtGbrndbcT2MPNHQdSIWMS8dhfOgdLXHXjBvTgFqBlyilKn5rqR4lOrV loYA3CLZofEZonfHGun/dro18S6cJRzKHiDkNQkmIFf/boKdXiCXibmKaZd6sB9uSkd8 XMbVez8bXkikZeOZkaVqRyt2BWwU/uDbBDH/FMGefwUD+2NE0AJR3YZCMQP6QQ0idZ45 1xbRSPjxFPZSbYneBwBKjPZ03TlbWJb2osqZC0z3kU52gLCI4Biihxm20L/jWMb8IUeX BsUQ== X-Gm-Message-State: AFqh2koicBnTEmGxp1B6m5xUjiEI7c5KFse99v1BZX9avcljB6IdSCzS HcDmLI2tipiCHVdmRdC2wFKTw+DaXxA1MT5u X-Google-Smtp-Source: AMrXdXvFxs78fVG+wfDmUwLL4c3vq2fSIs10ty85MpVTrWk58Z+DXTF02zF7syGHgnyDiWH5pVjoRg== X-Received: by 2002:ac8:688a:0:b0:3a8:26b1:3369 with SMTP id m10-20020ac8688a000000b003a826b13369mr36439871qtq.22.1672260124447; Wed, 28 Dec 2022 12:42:04 -0800 (PST) Received: from hurd (dsl-153-10.b2b2c.ca. [66.158.153.10]) by smtp.gmail.com with ESMTPSA id fc16-20020a05622a489000b003a6a7a20575sm10492491qtb.73.2022.12.28.12.42.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 28 Dec 2022 12:42:04 -0800 (PST) From: Maxim Cournoyer To: Mathieu Othacehe Subject: Re: bug#60218: [PATCH 0/2] New teams.scm 'get-maintainer' command (for integration with patman) References: <20221220135810.28175-1-maxim.cournoyer@gmail.com> <20221220141330.30372-1-maxim.cournoyer@gmail.com> <87pmc5maj2.fsf_-_@gnu.org> <8735907tcf.fsf@gmail.com> <87v8lvwiid.fsf_-_@gnu.org> Date: Wed, 28 Dec 2022 15:42:03 -0500 In-Reply-To: <87v8lvwiid.fsf_-_@gnu.org> (Mathieu Othacehe's message of "Wed, 28 Dec 2022 18:22:18 +0100") Message-ID: <87a6375kh0.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 60218-done Cc: Josselin Poiret , Christopher Baines , Simon Tournier , 60218-done@debbugs.gnu.org, Ludovic =?utf-8?Q?Court=C3=A8s?= , Tobias Geerinckx-Rice , Ricardo Wurmus X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi Mathieu, Mathieu Othacehe writes: > Hey, > >> Implemented in v2! I guess it could be useful. Note that it doesn't >> parse the patch for the file names touched, instead it assumes the patch >> was produced from a commit registered in git and then use the usual code >> path (for simplicity). > > Nice! I think that it is fair to assume that the commit is registered in > the local git repository. > > As a follow-up a documentation update could also be interesting as I > think that the new 'cc-members patch' command is easier to use that the > 'cc-member start end' variant. OK! I intend to document the use of patman along teams.scm, as I find it helps automate things and keep submissions organized. We can probably briefly mention the tool, and point the interested user to its full doc (which lives in u-boot-documentation). > I had a look to the rest of the patchset it seems fine to me :) OK, great! I've now pushed the series. Happy New Year! -- Thanks, Maxim From debbugs-submit-bounces@debbugs.gnu.org Fri Jan 06 13:01:30 2023 Received: (at 60218) by debbugs.gnu.org; 6 Jan 2023 18:01:30 +0000 Received: from localhost ([127.0.0.1]:55788 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pDr22-0006lS-4y for submit@debbugs.gnu.org; Fri, 06 Jan 2023 13:01:30 -0500 Received: from mail-wr1-f47.google.com ([209.85.221.47]:46623) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pDr20-0006l3-N6 for 60218@debbugs.gnu.org; Fri, 06 Jan 2023 13:01:29 -0500 Received: by mail-wr1-f47.google.com with SMTP id s9so1970154wru.13 for <60218@debbugs.gnu.org>; Fri, 06 Jan 2023 10:01:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:from:to:cc:subject:date:message-id:reply-to; bh=rSyDKNa7bRX5NiPS/lCJQl3xJwgwTIBPGA4u70iiLdc=; b=oMkwGGU8vWkffLKZQssTxPJVK2DQiG2Z40UgZ1SkzxAS2v2yOjFVdSK99OMNx/Z3tj XDEdivbB1uP0WExVAjbW2ljKU7x8IR8Ga3mAg5Sw0/O5msKnenEE1E+Nmwk3Ycodh51o 1av1HmZjPLyKu5tFJISlWPYILil2I1cmy/5T5Cw/qa/ITq4mcjmWXJI2OmoXmOELrl/q 6dLYvsIXQ8gd+XxXY+2f6kZ+EnGlLy731aSxPo+4II9PhWaTnv8D2okXL4lsC2fvHtah UKbmIRHGbn4+xhEPU2dwTWvfOfbpvLdgxyZz4wh63oAqHKfeh4xnbnLCqB5XsizG+Rc6 Nfvg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=rSyDKNa7bRX5NiPS/lCJQl3xJwgwTIBPGA4u70iiLdc=; b=m8j0EBhH6GYG7AvIIC2z+F9HG72eKWM1N7XVMhmK+JJM/Cg/CKtmvcy+QfRKSlu7/B OlGjxL5CMrWy+VENO8kO/2gJKQFvqyl7d1ypXIeFTIHk7tfLPVkh7vyU+ziB5h7vGwSW x7YdOpPWCAP0VRFiLzyTW0m2RKNi8Sr0KOaHo2g3WbGTWNvBO+zGtw2KuYMxg8/X0mau r62SMONTJBVo1wIuYHUnHMVhCLSegkDkMZnZxaf+XrgrI/wam9ERhoGyzlrlmOy2Wi4Y tL9vTQEJ8eHhX+ynECpI5T28HtrwlcBGZZ4fjFzhtj8I10Fpn51k31R02P8TCaG/Ivhc cB/w== X-Gm-Message-State: AFqh2kp8LR1KSGUt7TeultGDenZfTDZibiKKq0nrC4itC4jd9j/XrnOc TBWR8wTF51sz5r+Yp5JWE8E= X-Google-Smtp-Source: AMrXdXsjPFXgbBNeoKsu7H/Ah4NOB2VEmFs1uCX9XIKnhMJ1wAnzRuCzGECU8XPeE9vbwPbv6Y2Mmw== X-Received: by 2002:a05:6000:54a:b0:242:1ad2:15d8 with SMTP id b10-20020a056000054a00b002421ad215d8mr6764863wrf.3.1673028082674; Fri, 06 Jan 2023 10:01:22 -0800 (PST) Received: from pfiuh07 ([193.48.40.241]) by smtp.gmail.com with ESMTPSA id q20-20020a7bce94000000b003c6c3fb3cf6sm2461149wmj.18.2023.01.06.10.01.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Jan 2023 10:01:22 -0800 (PST) From: Simon Tournier To: Maxim Cournoyer , 60218@debbugs.gnu.org Subject: Re: [bug#60218] [PATCH v2 3/3] .patman: New configuration file. In-Reply-To: <20221227153249.16793-3-maxim.cournoyer@gmail.com> References: <20221227153249.16793-1-maxim.cournoyer@gmail.com> <20221227153249.16793-3-maxim.cournoyer@gmail.com> Date: Fri, 06 Jan 2023 18:26:06 +0100 Message-ID: <87h6x3h8wh.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 60218 Cc: rekado@elephly.net, othacehe@gnu.org, Maxim Cournoyer X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi Maxim, On Tue, 27 Dec 2022 at 10:32, Maxim Cournoyer wrote: > +++ b/.patman > @@ -0,0 +1,9 @@ > +# This config file allows for Patchwork integration with > +# https://patches.guix-patches.cbaines.net/. > +[settings] > +project: guix-patches > +patchwork_url: https://patches.guix-patches.cbaines.net > +add_signoff: False > +# TODO: enable check_patch > +check_patch: False > +get_maintainer_script: etc/teams.scm get-maintainer Maybe it could be worse to provide an example about how to use this .patman file. Maybe under Notifying Teams [1] or Teams [2]. WDYT? 1: https://guix.gnu.org/manual/devel/en/guix.html#Notifying-Teams-1 2: https://guix.gnu.org/manual/devel/en/guix.html#Teams Cheers, simon From debbugs-submit-bounces@debbugs.gnu.org Wed Jan 11 11:11:48 2023 Received: (at 60218) by debbugs.gnu.org; 11 Jan 2023 16:11:48 +0000 Received: from localhost ([127.0.0.1]:43616 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pFdhc-0001fS-Af for submit@debbugs.gnu.org; Wed, 11 Jan 2023 11:11:48 -0500 Received: from mail-wr1-f53.google.com ([209.85.221.53]:39505) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pFdhX-0001eo-Ts for 60218@debbugs.gnu.org; Wed, 11 Jan 2023 11:11:45 -0500 Received: by mail-wr1-f53.google.com with SMTP id z5so14502683wrt.6 for <60218@debbugs.gnu.org>; Wed, 11 Jan 2023 08:11:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:from:to:cc:subject:date:message-id :reply-to; bh=ApPg7PtOKZKjjPOCDiTGrH73vEjXiK99CvM2Ygku95E=; b=eeUWcMl0Pr93bJJtkTrOH09nLb/bKYdmlcl02BJ5wHTASu6EVnPrgvt8s3RJMLnJxk 39rSQXczYS1dLFfolJ8nt+yCKpCAOBNPvcSsVRoFrJP5mLy1kQi+VlwLq32aazf9unis 40wLXOwtN+Hf4qioasQZwBFCihP0TvXVIvWZPhr0LC7L+h2SrLBFT5TwxDFYu7oJ0lTV ZzRRazSJNJ0YLF+8AHtgaBOSJVGCVDAUtjgXpHrDnDxyfqYdbeVAjnPgVdtlwg/WzhPH g62vtzqKn9J1ZrKh6ImrSgn2zA50oTU17w/P2jY+lW93qEyB4QXyiEqqwQ7OyFZmHSz0 5M3Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ApPg7PtOKZKjjPOCDiTGrH73vEjXiK99CvM2Ygku95E=; b=Bhh4xU3xcrFOGqBt4Q8KQK50sVkhn3EXyEqe/yZxWYLZf/x/l5MpPRcVNO9Il3lt9C gKCzTAnPfPLsI10GFYY/3532ZoWik26pXjhZ7EV1YxNZJZ4olrac6zMIuhgxaoxVh40F Whtj7B+IgETKoBUvwY2H0KGGnD7piIR5/yh5hJlFOs+FzZs0skcEwzIkVQAFOB0qVmDs xOE3DaPJ8RUUMZGoDAay3bJx6A2+a4eCvHaEg3NIhS6pMka+B5Za46BKTZ0mtyBlCSNJ ICIm/T1/p3xoFhen7gJwVBRwP40SPudjMgP+oPAxQTJcneU/v9mVytOHHTY81EQWZfCz 1T4g== X-Gm-Message-State: AFqh2kql3g8PgtcoMS+j2GCZshEW9A452uGDzUWCq/zyDgvz7u3bGbqu 2enpiaAWCAmQHw6zaMdJDoY= X-Google-Smtp-Source: AMrXdXvCzvrZXtyJrPDNSkrxKuH+TZIsyd5LD6bUsSx7PVIQ6mPkinbbEKrylN3jPY+SwQyBWGrtng== X-Received: by 2002:a5d:4522:0:b0:2ba:1fdb:6133 with SMTP id j2-20020a5d4522000000b002ba1fdb6133mr2535778wra.7.1673453498261; Wed, 11 Jan 2023 08:11:38 -0800 (PST) Received: from lili ([2a01:e0a:59b:9120:65d2:2476:f637:db1e]) by smtp.gmail.com with ESMTPSA id e7-20020a056000120700b00241dd5de644sm14221367wrx.97.2023.01.11.08.11.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 11 Jan 2023 08:11:37 -0800 (PST) From: zimoun To: Maxim Cournoyer , 60218@debbugs.gnu.org Subject: Re: [bug#60218] [PATCH v2 3/3] .patman: New configuration file. In-Reply-To: <87h6x3h8wh.fsf@gmail.com> References: <20221227153249.16793-1-maxim.cournoyer@gmail.com> <20221227153249.16793-3-maxim.cournoyer@gmail.com> <87h6x3h8wh.fsf@gmail.com> Date: Wed, 11 Jan 2023 16:10:08 +0100 Message-ID: <86bkn55cq7.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 60218 Cc: rekado@elephly.net, othacehe@gnu.org, Maxim Cournoyer X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi Maxim, On Fri, 06 Jan 2023 at 18:26, Simon Tournier wro= te: > On Tue, 27 Dec 2022 at 10:32, Maxim Cournoyer = wrote: > >> +++ b/.patman >> @@ -0,0 +1,9 @@ >> +# This config file allows for Patchwork integration with >> +# https://patches.guix-patches.cbaines.net/. >> +[settings] >> +project: guix-patches >> +patchwork_url: https://patches.guix-patches.cbaines.net >> +add_signoff: False >> +# TODO: enable check_patch >> +check_patch: False >> +get_maintainer_script: etc/teams.scm get-maintainer > > Maybe it could be worse to provide an example about how to use this > .patman file. Maybe under Notifying Teams [1] or Teams [2]. WDYT? s/worse/worth :-) > 1: https://guix.gnu.org/manual/devel/en/guix.html#Notifying-Teams-1 > 2: https://guix.gnu.org/manual/devel/en/guix.html#Teams In #58813 [3], you suggest to reference to patman documentation. That=E2= =80=99s my suggestion, so let discuss overthere. :-) 3: Cheers, simon From unknown Sat Jun 21 05:20:26 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Thu, 09 Feb 2023 12:24:06 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator