From unknown Tue Jun 17 22:22:30 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#60212] [PATCH] gnu: Add emacs-fzf. Resent-From: jgart Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 20 Dec 2022 03:30:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 60212 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 60212@debbugs.gnu.org Cc: jgart X-Debbugs-Original-To: guix-patches@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.167150699610106 (code B ref -1); Tue, 20 Dec 2022 03:30:02 +0000 Received: (at submit) by debbugs.gnu.org; 20 Dec 2022 03:29:56 +0000 Received: from localhost ([127.0.0.1]:42014 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p7TKF-0002cw-VC for submit@debbugs.gnu.org; Mon, 19 Dec 2022 22:29:56 -0500 Received: from lists.gnu.org ([209.51.188.17]:37416) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p7TKC-0002cq-24 for submit@debbugs.gnu.org; Mon, 19 Dec 2022 22:29:54 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p7TKB-0000vH-TF for guix-patches@gnu.org; Mon, 19 Dec 2022 22:29:51 -0500 Received: from mx1.dismail.de ([78.46.223.134]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p7TK9-0002zs-52 for guix-patches@gnu.org; Mon, 19 Dec 2022 22:29:51 -0500 Received: from mx1.dismail.de (localhost [127.0.0.1]) by mx1.dismail.de (OpenSMTPD) with ESMTP id 9deb9ca1 for ; Tue, 20 Dec 2022 04:29:43 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=dismail.de; h=from:to:cc :subject:date:message-id:mime-version:content-transfer-encoding; s=20190914; bh=LHVsvL0SLf2aKswvfYJJMWI/1ZgaUhGqscRCB0rw4UI=; b= WoPqIeqRE4ddSH67sBgXq6CxGwN9EG0q1mne/KkrmD8FTp2LU5g6h401bkmTw1d9 lTpufcaurHy8DDhkwCqXjHxFN217Pbgt7sS/kvlvw7YCq5cEZmiTvGa3YNtwFDpo TbMEYHWA7mqexHhFwmGT/XKH/vNzuOxWDnW/gZn1uotqsF1B2RLIjLogVb8v+O0Z Pc4UgW9s06E0+54MD1fKo2pzKQjAY4i3bC7xowm0aLDYk/kce26ihgkIA+UodsUk LjBeWpjYin3O70V7bk/YuN397CXUTqpfw7TZ1nKuFvPAUIltjlKVyuqhXFmkGZ1b g6aI7cE52MYhlWmTZU9mBQ== Received: from smtp1.dismail.de ( [10.240.26.11]) by mx1.dismail.de (OpenSMTPD) with ESMTP id 0f6777c4 for ; Tue, 20 Dec 2022 04:29:43 +0100 (CET) Received: from smtp1.dismail.de (localhost [127.0.0.1]) by smtp1.dismail.de (OpenSMTPD) with ESMTP id 4f3473db for ; Tue, 20 Dec 2022 04:29:43 +0100 (CET) Received: by dismail.de (OpenSMTPD) with ESMTPSA id 8a2856a8 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Tue, 20 Dec 2022 04:29:42 +0100 (CET) From: jgart Date: Mon, 19 Dec 2022 21:29:16 -0600 Message-Id: <20221220032916.5047-1-jgart@dismail.de> X-Mailer: git-send-email 2.38.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=78.46.223.134; envelope-from=jgart@dismail.de; helo=mx1.dismail.de X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) * gnu/packages/emacs-xyz.scm (emacs-fzf): New variable. --- gnu/packages/emacs-xyz.scm | 32 ++++++++++++++++++++++++++++++++ 1 file changed, 32 insertions(+) diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm index f97775ce95..6a03d40aca 100644 --- a/gnu/packages/emacs-xyz.scm +++ b/gnu/packages/emacs-xyz.scm @@ -1283,6 +1283,38 @@ (define-public emacs-mct (license (list license:gpl3+ license:fdl1.3+)))) ; GFDLv1.3+ for the manual +(define-public emacs-fzf + (let ((commit "21912ebc7e1084aa88c9d8b7715e782a3978ed23") + (revision "0")) + (package + (name "emacs-fzf") + (version (git-version "0.0.2" revision commit)) + (source (origin + (method git-fetch) + (uri (git-reference + (url "https://github.com/bling/fzf.el") + (commit commit))) + (file-name (git-file-name name version)) + (sha256 + (base32 + "0gdqjh8996hb06bnnyhi94k69mjfrzyfgq00a9s4wwagv28sqmkj")))) + (build-system emacs-build-system) + (arguments + (list + #:tests? #f ; There are no tests. + #:phases + #~(modify-phases %standard-phases + (add-after 'unpack 'patch-fzf-executable + (lambda* (#:key inputs #:allow-other-keys) + (make-file-writable "fzf.el") + (emacs-substitute-variables "fzf.el" + ("fzf/executable" (search-input-file inputs "/bin/fzf")))))))) + (inputs (list fzf)) + (home-page "https://github.com/bling/fzf.el") + (synopsis "Front-end for fzf") + (description "An @command{emacs} front-end for @command{fzf}.") + (license license:gpl3+)))) + (define-public emacs-minions (package (name "emacs-minions") -- 2.38.1 From unknown Tue Jun 17 22:22:30 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#60212] [PATCH] gnu: Add emacs-fzf. Resent-From: Nicolas Goaziou Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 20 Dec 2022 10:27:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60212 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 60212@debbugs.gnu.org Cc: 60212-done@debbugs.gnu.org, jgart X-Debbugs-Original-To: jgart via Guix-patches via Received: via spool by submit@debbugs.gnu.org id=B.167153196915356 (code B ref -1); Tue, 20 Dec 2022 10:27:02 +0000 Received: (at submit) by debbugs.gnu.org; 20 Dec 2022 10:26:09 +0000 Received: from localhost ([127.0.0.1]:44031 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p7Zp2-0003zc-NJ for submit@debbugs.gnu.org; Tue, 20 Dec 2022 05:26:09 -0500 Received: from lists.gnu.org ([209.51.188.17]:52316) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p7Zp1-0003zW-Pj for submit@debbugs.gnu.org; Tue, 20 Dec 2022 05:26:08 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p7Zp1-0005lx-E4 for guix-patches@gnu.org; Tue, 20 Dec 2022 05:26:07 -0500 Received: from relay4-d.mail.gandi.net ([217.70.183.196]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p7Zox-0004UM-TZ for guix-patches@gnu.org; Tue, 20 Dec 2022 05:26:07 -0500 Received: (Authenticated sender: admin@nicolasgoaziou.fr) by mail.gandi.net (Postfix) with ESMTPSA id 01480E0004; Tue, 20 Dec 2022 10:25:59 +0000 (UTC) From: Nicolas Goaziou References: <20221220032916.5047-1-jgart@dismail.de> Date: Tue, 20 Dec 2022 11:25:58 +0100 In-Reply-To: <20221220032916.5047-1-jgart@dismail.de> (jgart via Guix-patches via's message of "Mon, 19 Dec 2022 21:29:16 -0600") Message-ID: <87ili6cqx5.fsf@nicolasgoaziou.fr> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=217.70.183.196; envelope-from=mail@nicolasgoaziou.fr; helo=relay4-d.mail.gandi.net X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.6 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.6 (--) Hello, jgart via Guix-patches via writes: > * gnu/packages/emacs-xyz.scm (emacs-fzf): New variable. Thank you. > + #~(modify-phases %standard-phases > + (add-after 'unpack 'patch-fzf-executable > + (lambda* (#:key inputs #:allow-other-keys) > + (make-file-writable "fzf.el") Nitpick: The expression above is usually not necessary, even though some package definitions use it. > + (emacs-substitute-variables "fzf.el" > + ("fzf/executable" (search-input-file inputs "/bin/fzf")))))))) > + (inputs (list fzf)) > + (home-page "https://github.com/bling/fzf.el") > + (synopsis "Front-end for fzf") I expounded it a bit. > + (description "An @command{emacs} front-end for @command{fzf}.") Please write full sentences in descriptions, even if upstream does not. Also, "@command{emacs}" conveys no more information than "Emacs". So does "@command{fzf}" vs "Fzf". The simpler the better, IMO. Applied! Regards, -- Nicolas Goaziou From unknown Tue Jun 17 22:22:30 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: jgart Subject: bug#60212: closed (Re: [bug#60212] [PATCH] gnu: Add emacs-fzf.) Message-ID: References: <87ili6cqx5.fsf@nicolasgoaziou.fr> <20221220032916.5047-1-jgart@dismail.de> X-Gnu-PR-Message: they-closed 60212 X-Gnu-PR-Package: guix-patches X-Gnu-PR-Keywords: patch Reply-To: 60212@debbugs.gnu.org Date: Tue, 20 Dec 2022 10:27:03 +0000 Content-Type: multipart/mixed; boundary="----------=_1671532023-15402-1" This is a multi-part message in MIME format... ------------=_1671532023-15402-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #60212: [PATCH] gnu: Add emacs-fzf. which was filed against the guix-patches package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 60212@debbugs.gnu.org. --=20 60212: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D60212 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1671532023-15402-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 60212-done) by debbugs.gnu.org; 20 Dec 2022 10:26:14 +0000 Received: from localhost ([127.0.0.1]:44033 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p7Zp8-0003zo-1w for submit@debbugs.gnu.org; Tue, 20 Dec 2022 05:26:14 -0500 Received: from relay4-d.mail.gandi.net ([217.70.183.196]:51071) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p7Zp1-0003zD-3n for 60212-done@debbugs.gnu.org; Tue, 20 Dec 2022 05:26:11 -0500 Received: (Authenticated sender: admin@nicolasgoaziou.fr) by mail.gandi.net (Postfix) with ESMTPSA id 01480E0004; Tue, 20 Dec 2022 10:25:59 +0000 (UTC) From: Nicolas Goaziou To: jgart via Guix-patches via Subject: Re: [bug#60212] [PATCH] gnu: Add emacs-fzf. References: <20221220032916.5047-1-jgart@dismail.de> Date: Tue, 20 Dec 2022 11:25:58 +0100 In-Reply-To: <20221220032916.5047-1-jgart@dismail.de> (jgart via Guix-patches via's message of "Mon, 19 Dec 2022 21:29:16 -0600") Message-ID: <87ili6cqx5.fsf@nicolasgoaziou.fr> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 60212-done Cc: 60212-done@debbugs.gnu.org, jgart X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Hello, jgart via Guix-patches via writes: > * gnu/packages/emacs-xyz.scm (emacs-fzf): New variable. Thank you. > + #~(modify-phases %standard-phases > + (add-after 'unpack 'patch-fzf-executable > + (lambda* (#:key inputs #:allow-other-keys) > + (make-file-writable "fzf.el") Nitpick: The expression above is usually not necessary, even though some package definitions use it. > + (emacs-substitute-variables "fzf.el" > + ("fzf/executable" (search-input-file inputs "/bin/fzf")))))))) > + (inputs (list fzf)) > + (home-page "https://github.com/bling/fzf.el") > + (synopsis "Front-end for fzf") I expounded it a bit. > + (description "An @command{emacs} front-end for @command{fzf}.") Please write full sentences in descriptions, even if upstream does not. Also, "@command{emacs}" conveys no more information than "Emacs". So does "@command{fzf}" vs "Fzf". The simpler the better, IMO. Applied! Regards, -- Nicolas Goaziou ------------=_1671532023-15402-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 20 Dec 2022 03:29:56 +0000 Received: from localhost ([127.0.0.1]:42014 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p7TKF-0002cw-VC for submit@debbugs.gnu.org; Mon, 19 Dec 2022 22:29:56 -0500 Received: from lists.gnu.org ([209.51.188.17]:37416) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p7TKC-0002cq-24 for submit@debbugs.gnu.org; Mon, 19 Dec 2022 22:29:54 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p7TKB-0000vH-TF for guix-patches@gnu.org; Mon, 19 Dec 2022 22:29:51 -0500 Received: from mx1.dismail.de ([78.46.223.134]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p7TK9-0002zs-52 for guix-patches@gnu.org; Mon, 19 Dec 2022 22:29:51 -0500 Received: from mx1.dismail.de (localhost [127.0.0.1]) by mx1.dismail.de (OpenSMTPD) with ESMTP id 9deb9ca1 for ; Tue, 20 Dec 2022 04:29:43 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=dismail.de; h=from:to:cc :subject:date:message-id:mime-version:content-transfer-encoding; s=20190914; bh=LHVsvL0SLf2aKswvfYJJMWI/1ZgaUhGqscRCB0rw4UI=; b= WoPqIeqRE4ddSH67sBgXq6CxGwN9EG0q1mne/KkrmD8FTp2LU5g6h401bkmTw1d9 lTpufcaurHy8DDhkwCqXjHxFN217Pbgt7sS/kvlvw7YCq5cEZmiTvGa3YNtwFDpo TbMEYHWA7mqexHhFwmGT/XKH/vNzuOxWDnW/gZn1uotqsF1B2RLIjLogVb8v+O0Z Pc4UgW9s06E0+54MD1fKo2pzKQjAY4i3bC7xowm0aLDYk/kce26ihgkIA+UodsUk LjBeWpjYin3O70V7bk/YuN397CXUTqpfw7TZ1nKuFvPAUIltjlKVyuqhXFmkGZ1b g6aI7cE52MYhlWmTZU9mBQ== Received: from smtp1.dismail.de ( [10.240.26.11]) by mx1.dismail.de (OpenSMTPD) with ESMTP id 0f6777c4 for ; Tue, 20 Dec 2022 04:29:43 +0100 (CET) Received: from smtp1.dismail.de (localhost [127.0.0.1]) by smtp1.dismail.de (OpenSMTPD) with ESMTP id 4f3473db for ; Tue, 20 Dec 2022 04:29:43 +0100 (CET) Received: by dismail.de (OpenSMTPD) with ESMTPSA id 8a2856a8 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Tue, 20 Dec 2022 04:29:42 +0100 (CET) From: jgart To: guix-patches@gnu.org Subject: [PATCH] gnu: Add emacs-fzf. Date: Mon, 19 Dec 2022 21:29:16 -0600 Message-Id: <20221220032916.5047-1-jgart@dismail.de> X-Mailer: git-send-email 2.38.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=78.46.223.134; envelope-from=jgart@dismail.de; helo=mx1.dismail.de X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-Debbugs-Envelope-To: submit Cc: jgart X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) * gnu/packages/emacs-xyz.scm (emacs-fzf): New variable. --- gnu/packages/emacs-xyz.scm | 32 ++++++++++++++++++++++++++++++++ 1 file changed, 32 insertions(+) diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm index f97775ce95..6a03d40aca 100644 --- a/gnu/packages/emacs-xyz.scm +++ b/gnu/packages/emacs-xyz.scm @@ -1283,6 +1283,38 @@ (define-public emacs-mct (license (list license:gpl3+ license:fdl1.3+)))) ; GFDLv1.3+ for the manual +(define-public emacs-fzf + (let ((commit "21912ebc7e1084aa88c9d8b7715e782a3978ed23") + (revision "0")) + (package + (name "emacs-fzf") + (version (git-version "0.0.2" revision commit)) + (source (origin + (method git-fetch) + (uri (git-reference + (url "https://github.com/bling/fzf.el") + (commit commit))) + (file-name (git-file-name name version)) + (sha256 + (base32 + "0gdqjh8996hb06bnnyhi94k69mjfrzyfgq00a9s4wwagv28sqmkj")))) + (build-system emacs-build-system) + (arguments + (list + #:tests? #f ; There are no tests. + #:phases + #~(modify-phases %standard-phases + (add-after 'unpack 'patch-fzf-executable + (lambda* (#:key inputs #:allow-other-keys) + (make-file-writable "fzf.el") + (emacs-substitute-variables "fzf.el" + ("fzf/executable" (search-input-file inputs "/bin/fzf")))))))) + (inputs (list fzf)) + (home-page "https://github.com/bling/fzf.el") + (synopsis "Front-end for fzf") + (description "An @command{emacs} front-end for @command{fzf}.") + (license license:gpl3+)))) + (define-public emacs-minions (package (name "emacs-minions") -- 2.38.1 ------------=_1671532023-15402-1-- From unknown Tue Jun 17 22:22:30 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#60212] [PATCH] gnu: Add emacs-fzf. Resent-From: "jgart" Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 21 Dec 2022 00:55:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60212 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: mail@nicolasgoaziou.fr, 60212@debbugs.gnu.org Cc: 60212-done@debbugs.gnu.org X-Debbugs-Original-To: "Nicolas Goaziou" , "jgart via Guix-patches via" Received: via spool by submit@debbugs.gnu.org id=B.167158406127023 (code B ref -1); Wed, 21 Dec 2022 00:55:02 +0000 Received: (at submit) by debbugs.gnu.org; 21 Dec 2022 00:54:21 +0000 Received: from localhost ([127.0.0.1]:48245 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p7nNE-00071n-OM for submit@debbugs.gnu.org; Tue, 20 Dec 2022 19:54:21 -0500 Received: from lists.gnu.org ([209.51.188.17]:34902) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p7nNC-00071c-Nl for submit@debbugs.gnu.org; Tue, 20 Dec 2022 19:54:19 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p7nNC-0005tn-AR for guix-patches@gnu.org; Tue, 20 Dec 2022 19:54:18 -0500 Received: from mx2.dismail.de ([159.69.191.136]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p7nNA-00025e-AL for guix-patches@gnu.org; Tue, 20 Dec 2022 19:54:18 -0500 Received: from mx2.dismail.de (localhost [127.0.0.1]) by mx2.dismail.de (OpenSMTPD) with ESMTP id 414ec6ce; Wed, 21 Dec 2022 01:54:12 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=dismail.de; h= mime-version:date:content-type:content-transfer-encoding:from :message-id:subject:to:cc:in-reply-to:references; s=20190914; bh=GRG1kwND5AUtJcb/D5vQ2HRelIWUbIA3C9TF1wWdV7Y=; b=XPRSe0kBkaQq EfWCXLS4Wceq8M3u7FC1NKGZPKmK4J0n8kbZmP3HQYk+Tw7nFgGOEEnrOrd0drpT HorxWS229IcIAREEWa7EM7wt0yJXUxB+vSgc+u66ceZ80Ftfpk+5C3pcrwKDP078 cKK6DsTFfEbDMtLDrMfYKhrEDwkYOab82Yo3osO0OOI/QkJwPtYbJAlgMKpOB74u hoWTzHp1V5sWkrUhvoTlRZ2OixmQCwi45bfI9zUyvgFPIBAp2LgZUidNFdCXrwAO ndNJu87HSVMmJ8Gxw1impgTK3GKKlnpyxypRMZalpLuF1obd5/B40ELjQjzmiR41 MJ8zeeBH5A== Received: from smtp1.dismail.de ( [10.240.26.11]) by mx2.dismail.de (OpenSMTPD) with ESMTP id 9a92c1e7; Wed, 21 Dec 2022 01:54:12 +0100 (CET) Received: from smtp1.dismail.de (localhost [127.0.0.1]) by smtp1.dismail.de (OpenSMTPD) with ESMTP id a4ed2e2c; Wed, 21 Dec 2022 01:54:12 +0100 (CET) Received: by dismail.de (OpenSMTPD) with ESMTPSA id 90e37d50 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Wed, 21 Dec 2022 01:54:12 +0100 (CET) MIME-Version: 1.0 Date: Wed, 21 Dec 2022 00:54:11 +0000 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Mailer: RainLoop/1.16.0a From: "jgart" Message-ID: <6dc428a54acf3ee157fd1a2784aa76b0@dismail.de> In-Reply-To: <87ili6cqx5.fsf@nicolasgoaziou.fr> References: <87ili6cqx5.fsf@nicolasgoaziou.fr> <20221220032916.5047-1-jgart@dismail.de> Received-SPF: pass client-ip=159.69.191.136; envelope-from=jgart@dismail.de; helo=mx2.dismail.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) I keep forgetting re @command I'll stop doing that. It has become a habit. Thanks for the review! It's much appreciated, jgart https://whereis.=E3=81=BF=E3=82=93=E3=81=AA/ December 20, 2022 4:26 AM, "Nicolas Goaziou" wro= te: > Hello, >=20 >=20jgart via Guix-patches via writes: >=20 >>=20* gnu/packages/emacs-xyz.scm (emacs-fzf): New variable. >=20 >=20Thank you. >=20 >>=20+ #~(modify-phases %standard-phases >> + (add-after 'unpack 'patch-fzf-executable >> + (lambda* (#:key inputs #:allow-other-keys) >> + (make-file-writable "fzf.el") >=20 >=20Nitpick: The expression above is usually not necessary, even though s= ome > package definitions use it. >=20 >>=20+ (emacs-substitute-variables "fzf.el" >> + ("fzf/executable" (search-input-file inputs "/bin/fzf")))))))) >> + (inputs (list fzf)) >> + (home-page "https://github.com/bling/fzf.el") >> + (synopsis "Front-end for fzf") >=20 >=20I expounded it a bit. >=20 >>=20+ (description "An @command{emacs} front-end for @command{fzf}.") >=20 >=20Please write full sentences in descriptions, even if upstream does no= t. >=20 >=20Also, "@command{emacs}" conveys no more information than "Emacs". So > does "@command{fzf}" vs "Fzf". The simpler the better, IMO. >=20 >=20Applied! >=20 >=20Regards, > -- > Nicolas Goaziou