From debbugs-submit-bounces@debbugs.gnu.org Mon Dec 19 18:09:35 2022 Received: (at submit) by debbugs.gnu.org; 19 Dec 2022 23:09:35 +0000 Received: from localhost ([127.0.0.1]:40926 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p7PGJ-0000EU-8k for submit@debbugs.gnu.org; Mon, 19 Dec 2022 18:09:35 -0500 Received: from lists.gnu.org ([209.51.188.17]:59204) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p7PGI-0000EO-9J for submit@debbugs.gnu.org; Mon, 19 Dec 2022 18:09:34 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p7PGI-0008PW-4U for bug-gnu-emacs@gnu.org; Mon, 19 Dec 2022 18:09:34 -0500 Received: from mail-mw2nam04olkn20828.outbound.protection.outlook.com ([2a01:111:f400:7e8c::828] helo=NAM04-MW2-obe.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p7PGG-0004yg-2A for bug-gnu-emacs@gnu.org; Mon, 19 Dec 2022 18:09:33 -0500 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LBxbDxBWhxlwIYKQZW4wkQt4K74d1sfl/ALTunNobxgpLoNOaoE2RP9QbfIWjaNPR2EgawzYq+At63vdUFSvaHjdxuFcDMS1o3B6YmeNHdTo2hJatkAKaGAgExy6doJhH4StLmuPfoByn43SgrwlLTefgPBTg1ettg6jTUCpSOkyGEfSIIxOfYnQHXHmRB1p/iwmCn0PiZbOIz4teC26OxGFC5P2fN6gtSRU7FHTOa+hpjdYH9skS5105dQzaeUUKaSwyHkUm7WwZfiZUbzPDs0Ri3HBDi5Xt+fhWdeFPzTfTajp/UW0jPwtmZ3pl1bNZ6RxsRkKyvt/Xapwfi2nrQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=U79ObT5a1kh/hOrUTmOihqyc1pmyEcnLK25EpXSuZ5c=; b=DpUaChAzvU4NKM+o1wl0bomCIqOOqnDVbCamVGISN23L0SiTc3WW2ndDos1wNZg5jLv3/Y5DCnJbQeMzGXwR68KqVR84CwKQuN/aPGA4VXp8LFisWDeIgA40ex02vlSmPu/nokBXFmRUnO1dEFUlLJTYVe+ux7joGbQMoBdWtw7vFILObzwwnmDYgfJWoYuLOR8wtgEcf6H6ViqCFa6eyr7SWmj0xDfhKt16iqa/+nZybtjoiBJVr8kwIIxGdNrzaP1FG30et9aA1bgsjjQLIM2UMaPoN/uFPuHqOir17wN4WaAUTh7C9QLnw3J3JRRSupyqz2PstSZBGed21NMcRg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hotmail.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=U79ObT5a1kh/hOrUTmOihqyc1pmyEcnLK25EpXSuZ5c=; b=IsE2/y+uFQDOF2RFOkyp0kLEUwA2Vtc9MIfW7+OF77Iwlfw10lHaJm7N7okJp2vkGns9GobTgvbj5uJ6u9iKlAPwN3Ouvzv1BPCbEnAK8QQpjRNamSM1Db3rPotgmhr+2n19aApM8ohm7KVG0Jv/LcIIm//nSIBop0/KlTcfb35GCG6b49nchNlnr7EDh4erlTu8L66KdqoMeW38yglBCsdVPAJ9POWIhdjEv2PRhuIktV3Vw5sRZjkFVnDPpx3XQIZHlj8RTRVoWIVQ8sM34xGTQu9JC/01UfWsxdg6wuUVpc1ZVEl3MdIMYCP9h9stcHJXw2gXPDj/2hAFsE3Dgw== Received: from PH8PR19MB7070.namprd19.prod.outlook.com (2603:10b6:510:222::9) by DS7PR19MB5784.namprd19.prod.outlook.com (2603:10b6:8:79::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5924.16; Mon, 19 Dec 2022 23:04:25 +0000 Received: from PH8PR19MB7070.namprd19.prod.outlook.com ([fe80::32c9:7ad8:d88f:a199]) by PH8PR19MB7070.namprd19.prod.outlook.com ([fe80::32c9:7ad8:d88f:a199%6]) with mapi id 15.20.5924.016; Mon, 19 Dec 2022 23:04:25 +0000 From: Gabriel do Nascimento Ribeiro To: "bug-gnu-emacs@gnu.org" Subject: 30.0.50; tab-bar height not recalculated when face changes Thread-Topic: 30.0.50; tab-bar height not recalculated when face changes Thread-Index: AQHZE/4pgSa3r1/DGUqNFlmfx8QNjg== Date: Mon, 19 Dec 2022 23:04:25 +0000 Message-ID: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: x-tmn: [capRBgPKO1nBRdGwDgcFta8Z3A+rZKQ8Pzx1TpnB849obMtfhHiM+oH0K78snREh] x-ms-publictraffictype: Email x-ms-traffictypediagnostic: PH8PR19MB7070:EE_|DS7PR19MB5784:EE_ x-ms-office365-filtering-correlation-id: 8872cce3-cb20-45af-0697-08dae2155fc7 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 3LAcAs/TjIje2aEj++eX6a/erf8pVp5oRI3MEhD6nCjgBvVaHCIYaZispVP/lqY6NIAI9+qWYT67vbxBKtern2AamrZH+CT1/hSAY3nuyVZHt2VSnwz9i4iG6PBYv0evKSTdqx21r9HYBqhpBL1Dga/qRS/0xrS230FECQii3qi3GCFZ2EgYANsQOXz2mDjk5zxs0XCjOVfL7itrzSUjC3mzPa+d+dU4aT1mbEJpva9SgSTNS//bEylnOYt8P7SCvtns3VFMNH9r9hQTpYxP2zAOTyox+6uW3W6Oq0ITHFw73rfzRiUxY45SXYetE9S0TDQTuJFZkN2fpEEMeZ+GUVqjE7FlmAHGDYnMovakfDcb27DG75knwHkciMKY+RI0H2Pkfoo8wufuKMFq16JnLZQbBNgb9/eb45Gnc/VvB1LFhwiyHjx13X2bRATEREi0kJqH415gEFLSe/MZjByTazKCYXduipa1ETg4W96QULLSI+6O3unB93E4MI9eGRmddfEkcH4Lzds7K72wRFLbnpTaC/plcXFgSNQnXyJI877mNO9UJ0vq6SPXd6Gvq/GqV+QlAM6Kq8bpk5eivUfx9UaD5qsfqxaD8xKRl0cxPiA= x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?RdauiLEeaOr31mv/s743c9UnoUCMzazoSDr5wIORFHaqrOfLOReMYsvaaz?= =?iso-8859-1?Q?Ueqvl/n5O5+zb8eo65ypPk5nItENuERPHUE0QrBeG8f8AcP6Qn2z5lEyEt?= =?iso-8859-1?Q?Lkm21Sk1jGNjnAAUYpWy6o+rSda7xYhJGhp9t8dWrOSswWF5QELPhByg3L?= =?iso-8859-1?Q?3WyP2cCj8BwHgP9OAB+DjiEIetyW9R8Rh7PUcntm3c/WyNSoHdDnk6m+9P?= =?iso-8859-1?Q?gjhyKCb4x1L+YkYsd2glZC71OWCgDlhFFIZstykE6MX4ND7+2O0WcWxiYv?= =?iso-8859-1?Q?VTRn771uapZHh4t5bzFrgbk+QusW2wXSuxk/lt1zcmy2obMfmSlWiepsmr?= =?iso-8859-1?Q?P2ZAMNnMoH0HwBVdKojPJzd8ceGAjUj7IaoGlssHCI6iMr3u9ps1XSdgX4?= =?iso-8859-1?Q?AoO6be8/MNcdHOBTMliR+IuefS5jNKV7+YJ7rSe35w4KnnCerxZkn2ZKh7?= =?iso-8859-1?Q?1h49Bcq+X9deynM7M6yQnAZOvyQ/lKiKBUlv6l4cS3RhjrBTfEXgYB1BNO?= =?iso-8859-1?Q?s+V0JolmUlkUMO0PEG6xB+XpugmTZ+U8RVNIh9HKGf7OQQNrG937MX4+EY?= =?iso-8859-1?Q?aBKirdvP05HXHx2P3XhyICPtcKo5S3AsKuOe9srTpV8yhClxKiIxPTLnZ9?= =?iso-8859-1?Q?qnvgIQEGVfkcF1WDJ6Yrde+FaKhqeMzttQHRkpRt65xj6+wV79f+r5l8BG?= =?iso-8859-1?Q?LcgnalJoxe4tvUT+KIQJtmHf3QGQWK8z9dTYj86B/ycSqHLf3tzM9RxIrf?= =?iso-8859-1?Q?F8Pyu5zDQ5wagyHohNLG1LFnXsMBfs05FSE8wcKLgIANNTS7wOQ1FoFa8n?= =?iso-8859-1?Q?XnN2fMQpWDOGQzqL2Jue8g0gl3QVH4UzfUwVvTT4BNAri/rzcqL/LK2Eeq?= =?iso-8859-1?Q?K6JcO5XUb33aAmeT7IXCTArG+jT16I6+hRkMbiE9JGvF6FoP94AZ91ke16?= =?iso-8859-1?Q?duN92Re7GXXg618Bj8dAgyJW7bEERlV0dGy8OI0IebErwNt5UDjdoO60p0?= =?iso-8859-1?Q?pPrkEpREixWjZTMpnyQAhpPqZ362zZvMz7qIAeNaZIkfW7rPhGfINAJM+l?= =?iso-8859-1?Q?8SseU/gKjstJFMd/fvv+RxpNQ89fCd3/jiS96LbqEsFu14WxUNU0et3xpy?= =?iso-8859-1?Q?OElxyf4JX27a2xNDE3zfkPP4PuIYSzVD1er4goVKhu7mSN+agCCxohTDlq?= =?iso-8859-1?Q?NnUbLWMlLP1TXCesOlCNabZedikOXMaHKfdP0JH/i+l5MC1aFGbrPY5ZrA?= =?iso-8859-1?Q?w8jzDL7ye6YWWTujpGLG3Toz+dLliIJiV7U9CkAPO079gRAuN+k3WApGUx?= =?iso-8859-1?Q?6PcuymGuwzOBUmPtHKG+QzFESFi5ptirXDnvoJohtS60hF6Sv7/VMRhCTO?= =?iso-8859-1?Q?1EWXxcZjg4WIbzT9KzLfAlOX7FmsGkzA=3D=3D?= Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: sct-15-20-4755-11-msonline-outlook-e7757.templateTenant X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH8PR19MB7070.namprd19.prod.outlook.com X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-CrossTenant-Network-Message-Id: 8872cce3-cb20-45af-0697-08dae2155fc7 X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Dec 2022 23:04:25.4791 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-rms-persistedconsumerorg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR19MB5784 Received-SPF: pass client-ip=2a01:111:f400:7e8c::828; envelope-from=gabriel376@hotmail.com; helo=NAM04-MW2-obe.outbound.protection.outlook.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.1 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.1 (--) Steps:=0A= =0A= 1) emacs -Q (master "ae91da52335aafaff5405a49c23460082dfb460d")=0A= =0A= 2) Enable tab-bar:=0A= =0A= (tab-bar-mode +1)=0A= =0A= 3) Change some face attribute of tab-bar to force increase the tab-bar=0A= height, e.g:=0A= =0A= (set-face-attribute 'tab-bar nil :box 4)=0A= (set-face-attribute 'tab-bar nil :height 1.2)=0A= =0A= Result: the new face is displayed and the tab-bar height is properly=0A= adjusted to reflect the new height.=0A= =0A= 4) Reset face attributes of tab-bar to force original height, e.g.:=0A= =0A= (set-face-attribute 'tab-bar nil :box nil)=0A= (set-face-attribute 'tab-bar nil :height 1.0)=0A= =0A= Result: the new face is displayed, but the tab-bar height is not=0A= properly adjusted to reflect the new height.=0A= =0A= ---=0A= Gabriel= From debbugs-submit-bounces@debbugs.gnu.org Sun Dec 25 03:51:29 2022 Received: (at 60210) by debbugs.gnu.org; 25 Dec 2022 08:51:29 +0000 Received: from localhost ([127.0.0.1]:47506 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p9MjA-00086x-P1 for submit@debbugs.gnu.org; Sun, 25 Dec 2022 03:51:28 -0500 Received: from relay9-d.mail.gandi.net ([217.70.183.199]:38971) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p9Mj8-00086c-St for 60210@debbugs.gnu.org; Sun, 25 Dec 2022 03:51:27 -0500 Received: (Authenticated sender: juri@linkov.net) by mail.gandi.net (Postfix) with ESMTPSA id D50BBFF805; Sun, 25 Dec 2022 08:51:18 +0000 (UTC) From: Juri Linkov To: Gabriel do Nascimento Ribeiro Subject: Re: bug#60210: 30.0.50; tab-bar height not recalculated when face changes In-Reply-To: (Gabriel do Nascimento Ribeiro's message of "Mon, 19 Dec 2022 23:04:25 +0000") Organization: LINKOV.NET References: Date: Sun, 25 Dec 2022 10:35:10 +0200 Message-ID: <86sfh350ok.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 60210 Cc: 60210@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > 2) Enable tab-bar: > > (tab-bar-mode +1) > > 3) Change some face attribute of tab-bar to force increase the tab-bar > height, e.g: > > (set-face-attribute 'tab-bar nil :box 4) > (set-face-attribute 'tab-bar nil :height 1.2) > > Result: the new face is displayed and the tab-bar height is properly > adjusted to reflect the new height. > > 4) Reset face attributes of tab-bar to force original height, e.g.: > > (set-face-attribute 'tab-bar nil :box nil) > (set-face-attribute 'tab-bar nil :height 1.0) > > Result: the new face is displayed, but the tab-bar height is not > properly adjusted to reflect the new height. It seems this is related to recent bug reports about fonts such as bug#52493, bug#58912, bug#59271, bug#59285, etc. since there is no such problem in Emacs 28. From debbugs-submit-bounces@debbugs.gnu.org Sun Dec 25 04:29:13 2022 Received: (at 60210) by debbugs.gnu.org; 25 Dec 2022 09:29:13 +0000 Received: from localhost ([127.0.0.1]:47558 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p9NJh-0005Rt-Ev for submit@debbugs.gnu.org; Sun, 25 Dec 2022 04:29:13 -0500 Received: from eggs.gnu.org ([209.51.188.92]:52154) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p9NJf-0005RX-TB for 60210@debbugs.gnu.org; Sun, 25 Dec 2022 04:29:12 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p9NJa-00050n-09; Sun, 25 Dec 2022 04:29:06 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=dLVT8TU7/p3pJX94boZsOjp3EW39Nja6O/ISdAoeZvE=; b=Rlt/zOvfpL/Q Mw7T1fEROadO6xAj8KGprMj6zai8gdIq2rRRZ2VswQa6oaM7UOzbsrtwWKvx6+OTFEEya0dWQi5il +SQWxx74Qm91PkGYhcZDDT5O1izX4FZrjV6L61g6CBI6f6ieJ6IbeovFf2XLHUrhkMRD5ibTkSjy5 xuurC3pF0Etqmiqfq3ifv3ri5tIOYo7xcLs1m1x+IVD6e2QyPrOik9gVJPqae60vlsa2FmTzALEc9 dRy+Q5VhD+kE+RD7SW0szKhc4vMuyuWQ/lcrcVZH6KMsM6ACiPyugabWRPK7MZ6g21CiFaDcK6t8Y qrWkETSfZiMAqVMVs3zzcw==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p9NJZ-0005Zo-6A; Sun, 25 Dec 2022 04:29:05 -0500 Date: Sun, 25 Dec 2022 11:29:05 +0200 Message-Id: <8335934yse.fsf@gnu.org> From: Eli Zaretskii To: Juri Linkov In-Reply-To: <86sfh350ok.fsf@mail.linkov.net> (message from Juri Linkov on Sun, 25 Dec 2022 10:35:10 +0200) Subject: Re: bug#60210: 30.0.50; tab-bar height not recalculated when face changes References: <86sfh350ok.fsf@mail.linkov.net> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 60210 Cc: 60210@debbugs.gnu.org, gabriel376@hotmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Cc: 60210@debbugs.gnu.org > From: Juri Linkov > Date: Sun, 25 Dec 2022 10:35:10 +0200 > > > 2) Enable tab-bar: > > > > (tab-bar-mode +1) > > > > 3) Change some face attribute of tab-bar to force increase the tab-bar > > height, e.g: > > > > (set-face-attribute 'tab-bar nil :box 4) > > (set-face-attribute 'tab-bar nil :height 1.2) > > > > Result: the new face is displayed and the tab-bar height is properly > > adjusted to reflect the new height. > > > > 4) Reset face attributes of tab-bar to force original height, e.g.: > > > > (set-face-attribute 'tab-bar nil :box nil) > > (set-face-attribute 'tab-bar nil :height 1.0) > > > > Result: the new face is displayed, but the tab-bar height is not > > properly adjusted to reflect the new height. > > It seems this is related to recent bug reports about fonts > such as bug#52493, bug#58912, bug#59271, bug#59285, etc. > since there is no such problem in Emacs 28. I doubt the font-related changes are relevant, but bisecting will be welcome. From debbugs-submit-bounces@debbugs.gnu.org Sun Dec 25 19:24:16 2022 Received: (at 60210) by debbugs.gnu.org; 26 Dec 2022 00:24:16 +0000 Received: from localhost ([127.0.0.1]:50420 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p9bHs-0002FF-Bx for submit@debbugs.gnu.org; Sun, 25 Dec 2022 19:24:16 -0500 Received: from heytings.org ([95.142.160.155]:45522) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p9bHq-0002F3-20 for 60210@debbugs.gnu.org; Sun, 25 Dec 2022 19:24:14 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=heytings.org; s=20220101; t=1672014252; bh=/gDmodI9XH4LMS0puO9MKAd+I7RpSRekEhUnE8q1IGg=; h=Date:From:To:cc:Subject:In-Reply-To:Message-ID:References:From; b=8Qav0h9SuidiR9IehQnwi5y1s2C1N8STeAgAXZkJWgfxYlyKK8MQk40oLFDS0GFaL 1syJAsY0tPcn+VQ62xUdhedI36g11dHgiVTdfnsN9tSFascQ3b29qvESLF0Rh18pIK JPjOJ6gOt1ViZMxOCJtpNuIuun66HviRXElJih3BeKTApW1pF/IfxIhtqJdN3pola8 raNtAvmYA4DaR3SA7BOqrPWetCizvPqv+jo5bptwrR4ig2jPo4us2G7mFrGNUj7lWP a87tWrV4WFzMKWk4sDfklA/ayuWiSkEMdtrR+jrrMY618s5rfgSW1yC/sphXb0xNLk 48Q8+5PVnOWWA== Date: Mon, 26 Dec 2022 00:24:11 +0000 From: Gregory Heytings To: Eli Zaretskii Subject: Re: bug#60210: 30.0.50; tab-bar height not recalculated when face changes In-Reply-To: <8335934yse.fsf@gnu.org> Message-ID: References: <86sfh350ok.fsf@mail.linkov.net> <8335934yse.fsf@gnu.org> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="bMZvIp2mfy" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 60210 Cc: 60210@debbugs.gnu.org, gabriel376@hotmail.com, Juri Linkov X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --bMZvIp2mfy Content-Type: text/plain; charset=us-ascii; format=flowed > > I doubt the font-related changes are relevant, but bisecting will be > welcome. > Indeed, the culprit is 5db4ec20fe. Patch attached. --bMZvIp2mfy Content-Type: text/x-diff; name=Improve-handling-of-tab-bar-height.patch Content-Transfer-Encoding: base64 Content-ID: Content-Disposition: attachment; filename=Improve-handling-of-tab-bar-height.patch RnJvbSBmMjA4MTU3NjUxM2U4YjZmYmE3MWU2N2YzNjYyMmNlYmU5MTVjNGM0 IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQ0KRnJvbTogR3JlZ29yeSBIZXl0 aW5ncyA8Z3JlZ29yeUBoZXl0aW5ncy5vcmc+DQpEYXRlOiBNb24sIDI2IERl YyAyMDIyIDAwOjIwOjU5ICswMDAwDQpTdWJqZWN0OiBbUEFUQ0hdIEltcHJv dmUgaGFuZGxpbmcgb2YgdGFiLWJhciBoZWlnaHQuDQoNCiogc3JjL3hkaXNw LmMgKHJlZGlzcGxheV90YWJfYmFyKTogV2hlbiAnYXV0by1yZXNpemUtdGFi LWJhcicgaXMNCm5vdCAnZ3Jvdy1vbmx5JywgYWxzbyBjb25zaWRlciB0aGUg Y2FzZSB3aGVuIHRoZSB0YWItYmFyIGhlaWdodA0KbmVlZHMgdG8gc2hyaW5r LiAgRml4ZXMgYnVnIzYwMjEwLg0KLS0tDQogc3JjL3hkaXNwLmMgfCA4ICsr KysrLS0tDQogMSBmaWxlIGNoYW5nZWQsIDUgaW5zZXJ0aW9ucygrKSwgMyBk ZWxldGlvbnMoLSkNCg0KZGlmZiAtLWdpdCBhL3NyYy94ZGlzcC5jIGIvc3Jj L3hkaXNwLmMNCmluZGV4IGVhMmQxMWU4YjRlLi5jOWIzYjE4N2ZlMiAxMDA2 NDQNCi0tLSBhL3NyYy94ZGlzcC5jDQorKysgYi9zcmMveGRpc3AuYw0KQEAg LTE0MjcxLDEyICsxNDI3MSwxNCBAQCByZWRpc3BsYXlfdGFiX2JhciAoc3Ry dWN0IGZyYW1lICpmKQ0KIAlmcmFtZV9kZWZhdWx0X3RhYl9iYXJfaGVpZ2h0 ID0gbmV3X2hlaWdodDsNCiAgICAgfQ0KIA0KLSAgLyogSWYgbmV3X2hlaWdo dCBvciBuZXdfbnJvd3MgaW5kaWNhdGUgdGhhdCB3ZSBuZWVkIHRvIGVubGFy Z2UgdGhlDQotICAgICB0YWItYmFyIHdpbmRvdywgd2UgY2FuIHJldHVybiBy aWdodCBhd2F5LiAgKi8NCisgIC8qIElmIG5ld19oZWlnaHQgb3IgbmV3X25y b3dzIGluZGljYXRlIHRoYXQgd2UgbmVlZCB0byBlbmxhcmdlIG9yDQorICAg ICBzaHJpbmsgdGhlIHRhYi1iYXIgd2luZG93LCB3ZSBjYW4gcmV0dXJuIHJp Z2h0IGF3YXkuICAqLw0KICAgaWYgKG5ld19ucm93cyA+IGYtPm5fdGFiX2Jh cl9yb3dzDQogICAgICAgfHwgKEVRIChWYXV0b19yZXNpemVfdGFiX2JhcnMs IFFncm93X29ubHkpDQogCSAgJiYgIWYtPm1pbmltaXplX3RhYl9iYXJfd2lu ZG93X3ANCi0JICAmJiBuZXdfaGVpZ2h0ID4gV0lORE9XX1BJWEVMX0hFSUdI VCAodykpKQ0KKwkgICYmIG5ld19oZWlnaHQgPiBXSU5ET1dfUElYRUxfSEVJ R0hUICh3KSkNCisgICAgICB8fCAoISBFUSAoVmF1dG9fcmVzaXplX3RhYl9i YXJzLCBRZ3Jvd19vbmx5KQ0KKwkgICYmIG5ld19oZWlnaHQgPCBXSU5ET1df UElYRUxfSEVJR0hUICh3KSkpDQogICAgIHsNCiAgICAgICBpZiAoRlJBTUVf VEVSTUlOQUwgKGYpLT5jaGFuZ2VfdGFiX2Jhcl9oZWlnaHRfaG9vaykNCiAJ RlJBTUVfVEVSTUlOQUwgKGYpLT5jaGFuZ2VfdGFiX2Jhcl9oZWlnaHRfaG9v ayAoZiwgbmV3X2hlaWdodCk7DQotLSANCjIuMzUuMQ0KDQo= --bMZvIp2mfy-- From debbugs-submit-bounces@debbugs.gnu.org Mon Dec 26 07:23:14 2022 Received: (at 60210) by debbugs.gnu.org; 26 Dec 2022 12:23:14 +0000 Received: from localhost ([127.0.0.1]:50891 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p9mVe-0006m2-7b for submit@debbugs.gnu.org; Mon, 26 Dec 2022 07:23:14 -0500 Received: from eggs.gnu.org ([209.51.188.92]:40606) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p9mVb-0006lo-SD for 60210@debbugs.gnu.org; Mon, 26 Dec 2022 07:23:13 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p9mVV-0006Yj-VA; Mon, 26 Dec 2022 07:23:06 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=k2Fx8fLSrtpuGefMFzJoDrokFf83w1QAJy8ox/aDr2I=; b=O/5gSvtV+8K0 c9/7eqRd4eLrrPQqoyRbh6MY6bxCEPVVA3HyHF1rMQqLefVK8uUrHates70x61UE5cJgBBWtbLGAS vrRVDbx6onIrcUQr3vt1mlNFVB5+nkAG68zdkQjbZQfQPWA9vFL5jfQ7+6Io/9v1MpvDKITh2zhIe +oNB3NJv31n6kiqKed4dAR6VOE4BfJsudfUITz9GihCqGVvD3dikk0m4Jc3ew1MG3iTP1c9rFeJi9 FsRb288RM/2dM0ziVTMLmOJZVB7FPZkmKZ5l7HGds4sYji2cBAvRznCvQkJrggrFPEBz3NlJOFCLx UI7vvo7Voi2PXWJ+MJQkqA==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p9mVV-00068U-Ah; Mon, 26 Dec 2022 07:23:05 -0500 Date: Mon, 26 Dec 2022 14:23:09 +0200 Message-Id: <83edsm2w2a.fsf@gnu.org> From: Eli Zaretskii To: Gregory Heytings In-Reply-To: (message from Gregory Heytings on Mon, 26 Dec 2022 00:24:11 +0000) Subject: Re: bug#60210: 30.0.50; tab-bar height not recalculated when face changes References: <86sfh350ok.fsf@mail.linkov.net> <8335934yse.fsf@gnu.org> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 60210 Cc: 60210@debbugs.gnu.org, gabriel376@hotmail.com, juri@linkov.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Mon, 26 Dec 2022 00:24:11 +0000 > From: Gregory Heytings > cc: Juri Linkov , 60210@debbugs.gnu.org, > gabriel376@hotmail.com > > > I doubt the font-related changes are relevant, but bisecting will be > > welcome. > > > > Indeed, the culprit is 5db4ec20fe. > > Patch attached. Thanks, this LGTM. If you tested this with tab bars of more than a single line, including when tabs are removed so a single line is once again long enough, please install on the release branch. From debbugs-submit-bounces@debbugs.gnu.org Mon Dec 26 08:36:25 2022 Received: (at 60210) by debbugs.gnu.org; 26 Dec 2022 13:36:25 +0000 Received: from localhost ([127.0.0.1]:50956 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p9neS-0002PA-TJ for submit@debbugs.gnu.org; Mon, 26 Dec 2022 08:36:25 -0500 Received: from heytings.org ([95.142.160.155]:46170) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p9neQ-0002P0-9r for 60210@debbugs.gnu.org; Mon, 26 Dec 2022 08:36:24 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=heytings.org; s=20220101; t=1672061781; bh=aL81Zdmmd5zvgenOpJZvu9uTldt62JEljnKpuhnwKAM=; h=Date:From:To:cc:Subject:In-Reply-To:Message-ID:References:From; b=JD5icYJgJWYwGEgnisJhQFRiOpn2/E8aEbMvjXcrQ6IvjK9pFgQwtNhPzfl/fMiYF MwIB0I2HWBRXIQ3WEvLPyiv9v25Mg2Fz3DtiQIjS8FBoOqZ3GtZSF4wcvOLeGF25Td z55acwD8wX2V7AK62vif347uL4OsKRuuc36qm2bu562nR19OaClBLw7TMWtVW887d+ 4gaRH5qcK2LrOnWkBFaEldB8xDn8GKTEvWIS4a7i5eooA9G7FcD8uybZtjH2iM+7Ep D6tfccIm1ySwtHvfTXtAbJvgwtEY+QVmPFLU6AD/XnxjUfmwJsxZp8LLYtlrTMNbCC MnxGnPgwQdRMw== Date: Mon, 26 Dec 2022 13:36:20 +0000 From: Gregory Heytings To: Eli Zaretskii Subject: Re: bug#60210: 30.0.50; tab-bar height not recalculated when face changes In-Reply-To: <83edsm2w2a.fsf@gnu.org> Message-ID: References: <86sfh350ok.fsf@mail.linkov.net> <8335934yse.fsf@gnu.org> <83edsm2w2a.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; format=flowed; charset=us-ascii X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 60210 Cc: 60210@debbugs.gnu.org, gabriel376@hotmail.com, juri@linkov.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) >>> I doubt the font-related changes are relevant, but bisecting will be >>> welcome. >> >> Indeed, the culprit is 5db4ec20fe. >> >> Patch attached. > > Thanks, this LGTM. If you tested this with tab bars of more than a > single line, including when tabs are removed so a single line is once > again long enough, please install on the release branch. > I did test it, but I don't use tab bars, so I'm not 110% sure. Juri, could you please test the patch? From debbugs-submit-bounces@debbugs.gnu.org Mon Dec 26 12:35:13 2022 Received: (at 60210) by debbugs.gnu.org; 26 Dec 2022 17:35:14 +0000 Received: from localhost ([127.0.0.1]:54050 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p9rNZ-0002uu-Ko for submit@debbugs.gnu.org; Mon, 26 Dec 2022 12:35:13 -0500 Received: from relay3-d.mail.gandi.net ([217.70.183.195]:49669) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p9rNX-0002ue-SM for 60210@debbugs.gnu.org; Mon, 26 Dec 2022 12:35:12 -0500 Received: (Authenticated sender: juri@linkov.net) by mail.gandi.net (Postfix) with ESMTPSA id 31BD260009; Mon, 26 Dec 2022 17:35:00 +0000 (UTC) From: Juri Linkov To: Gregory Heytings Subject: Re: bug#60210: 30.0.50; tab-bar height not recalculated when face changes In-Reply-To: (Gregory Heytings's message of "Mon, 26 Dec 2022 13:36:20 +0000") Organization: LINKOV.NET References: <86sfh350ok.fsf@mail.linkov.net> <8335934yse.fsf@gnu.org> <83edsm2w2a.fsf@gnu.org> Date: Mon, 26 Dec 2022 19:29:01 +0200 Message-ID: <86y1qurs4i.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 60210 Cc: 60210@debbugs.gnu.org, gabriel376@hotmail.com, Eli Zaretskii X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) >>>> I doubt the font-related changes are relevant, but bisecting will be >>>> welcome. >>> >>> Indeed, the culprit is 5db4ec20fe. >>> >>> Patch attached. >> >> Thanks, this LGTM. If you tested this with tab bars of more than >> a single line, including when tabs are removed so a single line is once >> again long enough, please install on the release branch. > > I did test it, but I don't use tab bars, so I'm not 110% sure. Juri, could > you please test the patch? Thanks for the patch. I tested it in emacs-29 with tab-bar-lines > 1 and see no problems. From debbugs-submit-bounces@debbugs.gnu.org Mon Dec 26 12:40:56 2022 Received: (at 60210-done) by debbugs.gnu.org; 26 Dec 2022 17:40:57 +0000 Received: from localhost ([127.0.0.1]:54062 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p9rT6-00033C-MU for submit@debbugs.gnu.org; Mon, 26 Dec 2022 12:40:56 -0500 Received: from heytings.org ([95.142.160.155]:46420) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p9rT4-000332-6Z for 60210-done@debbugs.gnu.org; Mon, 26 Dec 2022 12:40:55 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=heytings.org; s=20220101; t=1672076453; bh=I5vsd4cqgDOJ8TZBBke662aqNNIE6nk0yRd/Ij+2xx0=; h=Date:From:To:cc:Subject:In-Reply-To:Message-ID:References:From; b=5eL9BHNIpXew8w/ERx4U3gd7f4lDAXyHELY4EqjkaJ4+7/XlPEgPSARholFphZmzv dzHEUis4pzt8KLQn3hKeNLB2C2D2j8yVH3KLiKqKFm5tZn3dYz3enHYwadN9HclGjS eT/XvWJblj/6XRUbf0iVp95CNFx1hPkiAoSd+VbZRp4TJ8Y7XUVeTFB20DI+aQDFDC qsdA2sUo5FpFAoUJYICNYD4pb8t8FND5/aSoK6avDC4JvLyp4m4Wa1i2TCk4TE3MR6 shK+cg5sPvvGS5LgKgCkcqJefuO6ATPypgb68LbifR2ZOx0wsN+t71oGr67G3PM5iP o4NbV6jiphrPA== Date: Mon, 26 Dec 2022 17:40:52 +0000 From: Gregory Heytings To: Juri Linkov Subject: Re: bug#60210: 30.0.50; tab-bar height not recalculated when face changes In-Reply-To: <86y1qurs4i.fsf@mail.linkov.net> Message-ID: References: <86sfh350ok.fsf@mail.linkov.net> <8335934yse.fsf@gnu.org> <83edsm2w2a.fsf@gnu.org> <86y1qurs4i.fsf@mail.linkov.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 60210-done Cc: 60210-done@debbugs.gnu.org, gabriel376@hotmail.com, Eli Zaretskii X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) >>> Thanks, this LGTM. If you tested this with tab bars of more than a >>> single line, including when tabs are removed so a single line is once >>> again long enough, please install on the release branch. >> >> I did test it, but I don't use tab bars, so I'm not 110% sure. Juri, >> could you please test the patch? > > Thanks for the patch. I tested it in emacs-29 with tab-bar-lines > 1 > and see no problems. > Thanks! Pushed (b14bbd108e), and closing. From debbugs-submit-bounces@debbugs.gnu.org Sun Jan 01 12:56:39 2023 Received: (at 60210) by debbugs.gnu.org; 1 Jan 2023 17:56:39 +0000 Received: from localhost ([127.0.0.1]:41675 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pC2Zb-0004oB-4e for submit@debbugs.gnu.org; Sun, 01 Jan 2023 12:56:39 -0500 Received: from heytings.org ([95.142.160.155]:54678) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pC2ZZ-0004o3-Fv for 60210@debbugs.gnu.org; Sun, 01 Jan 2023 12:56:37 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=heytings.org; s=20220101; t=1672595796; bh=ehbaMcosPQUk7TJx3iScjBaGb+8EV1uRHzxHjPLpEPw=; h=Date:From:To:cc:Subject:In-Reply-To:Message-ID:References:From; b=ipAtGMjGVyxu5soK5QLF2TczjWpk6PdepC5autClu3ojXGygBZ9TEAB3AfOLUSQ6k QZ+egWjLpIVsUUq76ZrbRGww3oM34yLFUHagMzyazHDsoNjj2WzrtPXCtO8XS9XWZB 9Q0vcq0CibpiVncW95sRhJd4ET6Qo95La4oC5Xl0aOMmz3Gq5RCnX5+8eLkNrdGrp7 OfLswzTUI7K1FL3Zg8r6ngN8KbngvSEVyNf6owfj9iq2STxJovVZeXeManMNur5iXB XUxub/sPCtxLmQpgedoOfJh5ttWnEyjx2d3KDbuVsnTo+Fn6JjPQaYFDYCfH4pBDKx Hl09IAH0sZWBQ== Date: Sun, 01 Jan 2023 17:56:36 +0000 From: Gregory Heytings To: Juri Linkov , Eli Zaretskii Subject: Re: bug#60210: 30.0.50; tab-bar height not recalculated when face changes In-Reply-To: Message-ID: <226b32f79feedbfa05f1@heytings.org> References: <86sfh350ok.fsf@mail.linkov.net> <8335934yse.fsf@gnu.org> <83edsm2w2a.fsf@gnu.org> <86y1qurs4i.fsf@mail.linkov.net> MIME-Version: 1.0 Content-Type: text/plain; format=flowed; charset=us-ascii X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 60210 Cc: 60210@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > > Thanks! Pushed (b14bbd108e), and closing. > I got (privately) an interesting bug report about this commit. The bug is that, because of this change, the tab-bar is not displayed anymore (or is displayed but stays empty) in certain circumstances. It's a font-related bug again, so it might be difficult to reproduce. On my system, (set-face-attribute 'default nil :font "JetBrains Mono") (tab-bar-mode 1) triggers the bug. The bug is that, in redisplay_tab_bar, WINDOW_PIXEL_HEIGHT (w) uses the height of the default face, which is 39 pixels, whereas new_height, which is computed with tab_bar_height, uses the font of the tab-bar face (variable-pitch in emacs -Q). On my system, new_height is (with a single *scratch* tab) 36 pixels. Therefore new_height < WINDOW_PIXEL_HEIGHT (w), when in fact according to the logic of the code we should have new_height == WINDOW_PIXEL_HEIGHT (w). From debbugs-submit-bounces@debbugs.gnu.org Sun Jan 01 13:22:59 2023 Received: (at 60210) by debbugs.gnu.org; 1 Jan 2023 18:23:00 +0000 Received: from localhost ([127.0.0.1]:41725 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pC2z5-0005V3-Kc for submit@debbugs.gnu.org; Sun, 01 Jan 2023 13:22:59 -0500 Received: from eggs.gnu.org ([209.51.188.92]:39024) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pC2z4-0005Ur-28 for 60210@debbugs.gnu.org; Sun, 01 Jan 2023 13:22:58 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pC2yy-0006RL-AE; Sun, 01 Jan 2023 13:22:52 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=rVsJlEEseTOw8bS2nnVG4rJHDgGbnx5ugHS2mx9yxes=; b=gySxUMxseyfg XcHnpgGy7DbI3oFEFIp/QX3iVITlZbFe1zwDH++fmrGx5IQNrFO9DIWxSOD/OfB1j7i2+aNu6odkK 78EQ2dxmnLMAxMliTlONM2YkCuL99lDEuFngbSEZdmVFfGmRkkun+qRt5wPKF4rY9aaYGekb9NUaZ CsDLvG53SAtVFaO3mC/Ydph5M/dd+INnm/Nf5SRXGiJMOfXayflDBm7dAH0lvRjRWLzaFwQg8czAn OWybKE/ymclzN68GV0WJykCtQGVNN03gDS8fVQybXALWzmuqhDqy7TBp/EbTSVHe7G9qxtQpM8//i caPdyo8fo22tXdYBo59wdQ==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pC2yx-0003c7-LX; Sun, 01 Jan 2023 13:22:51 -0500 Date: Sun, 01 Jan 2023 20:22:56 +0200 Message-Id: <83o7ri2jy7.fsf@gnu.org> From: Eli Zaretskii To: Gregory Heytings In-Reply-To: <226b32f79feedbfa05f1@heytings.org> (message from Gregory Heytings on Sun, 01 Jan 2023 17:56:36 +0000) Subject: Re: bug#60210: 30.0.50; tab-bar height not recalculated when face changes References: <86sfh350ok.fsf@mail.linkov.net> <8335934yse.fsf@gnu.org> <83edsm2w2a.fsf@gnu.org> <86y1qurs4i.fsf@mail.linkov.net> <226b32f79feedbfa05f1@heytings.org> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 60210 Cc: 60210@debbugs.gnu.org, juri@linkov.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Sun, 01 Jan 2023 17:56:36 +0000 > From: Gregory Heytings > cc: 60210@debbugs.gnu.org > > The bug is that, in redisplay_tab_bar, WINDOW_PIXEL_HEIGHT (w) uses the > height of the default face, which is 39 pixels, whereas new_height, which > is computed with tab_bar_height, uses the font of the tab-bar face > (variable-pitch in emacs -Q). On my system, new_height is (with a single > *scratch* tab) 36 pixels. Therefore new_height < WINDOW_PIXEL_HEIGHT (w), > when in fact according to the logic of the code we should have new_height > == WINDOW_PIXEL_HEIGHT (w). I'm not sure I understand how the above causes the tab bar not to be displayed, or become empty. AFAIU, it just means the frame's change_tab_bar_height_hook will be called. What did I miss? From debbugs-submit-bounces@debbugs.gnu.org Sun Jan 01 16:51:00 2023 Received: (at 60210) by debbugs.gnu.org; 1 Jan 2023 21:51:00 +0000 Received: from localhost ([127.0.0.1]:41911 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pC6EO-0002kg-5F for submit@debbugs.gnu.org; Sun, 01 Jan 2023 16:51:00 -0500 Received: from heytings.org ([95.142.160.155]:54992) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pC6EL-0002kW-U8 for 60210@debbugs.gnu.org; Sun, 01 Jan 2023 16:50:58 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=heytings.org; s=20220101; t=1672609856; bh=ZnWJJ6qWlLNYkQOATjsZ2QOwjo5px7wQFt7HbqWfMzs=; h=Date:From:To:cc:Subject:In-Reply-To:Message-ID:References:From; b=EUSzkK92Pe0VPqkagXL8SIChQNMdtYLtuYBavSMul82Uq00L3PdJYMeF8rO6BNqO3 8yysRramOy29/smkrBwdTjzSJYZXT3u61E150A9bArmfTvCDuBu7JvJnffQxptMWju 4H1vPg6h/tVZdMg3Bc8gWqJ8nZ0AO/hKlGTaWYj9V8TBig634K/63VEio1F39lUXMs uALTv2J2wfi+N0MmknicAPdozdWWEQ9XdkSrdPVvNbNTIBbPHyFkXRLLXBHprMEJHe vSwlqiI/8Pnzu8E5+ll2EsBkRY2g7BeYNfBWc6kvoQEA5ZLgqWCTr0c+2DVUMuZ87c nnqQaF0WQoj/Q== Date: Sun, 01 Jan 2023 21:50:56 +0000 From: Gregory Heytings To: Eli Zaretskii Subject: Re: bug#60210: 30.0.50; tab-bar height not recalculated when face changes In-Reply-To: <83o7ri2jy7.fsf@gnu.org> Message-ID: <226b32f79fbbaf16469b@heytings.org> References: <86sfh350ok.fsf@mail.linkov.net> <8335934yse.fsf@gnu.org> <83edsm2w2a.fsf@gnu.org> <86y1qurs4i.fsf@mail.linkov.net> <226b32f79feedbfa05f1@heytings.org> <83o7ri2jy7.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; format=flowed; charset=us-ascii X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 60210 Cc: 60210@debbugs.gnu.org, juri@linkov.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) >> The bug is that, in redisplay_tab_bar, WINDOW_PIXEL_HEIGHT (w) uses the >> height of the default face, which is 39 pixels, whereas new_height, >> which is computed with tab_bar_height, uses the font of the tab-bar >> face (variable-pitch in emacs -Q). On my system, new_height is (with a >> single *scratch* tab) 36 pixels. Therefore new_height < >> WINDOW_PIXEL_HEIGHT (w), when in fact according to the logic of the >> code we should have new_height == WINDOW_PIXEL_HEIGHT (w). > > I'm not sure I understand how the above causes the tab bar not to be > displayed, or become empty. AFAIU, it just means the frame's > change_tab_bar_height_hook will be called. What did I miss? > I do not fully understand it either yet. A simpler recipe, which does not involve changing fonts: (set-face-attribute 'tab-bar nil :height 0.5) (tab-bar-mode 1) This should display a tiny tab-bar, it displays a white bar instead. In redisplay_tab_bar, new_height is set to half the height of a canonical line (17 and 34 on my system). Therefore redisplay_tab_bar returns true. The next redisplay cycle finds that WINDOW_TOTAL_LINES (w) == 0, and does nothing. From debbugs-submit-bounces@debbugs.gnu.org Sun Jan 01 22:29:54 2023 Received: (at 60210) by debbugs.gnu.org; 2 Jan 2023 03:29:54 +0000 Received: from localhost ([127.0.0.1]:42184 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pCBWM-00031f-0k for submit@debbugs.gnu.org; Sun, 01 Jan 2023 22:29:54 -0500 Received: from eggs.gnu.org ([209.51.188.92]:38876) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pCBWK-00031Q-J0 for 60210@debbugs.gnu.org; Sun, 01 Jan 2023 22:29:53 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pCBWE-0001Yv-L4; Sun, 01 Jan 2023 22:29:46 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=qkBUUvC0HMySPuayayQKX4IrarS2GNuwDmG4eup1ixc=; b=WZDtYyUgeLfq O0cwV540xcQjxClVXtrZHeUk7Gt5fH3dB+V1uZ3fNTfh/lNuBIPJ/ZP1vJ/5sQRGpl4n51K3IUF8Q ytxop3Zg2X2Pnnfhkf6G4iyLYv5ts6RGWKNxILMkUOTZiL3Rbd4GWiVG2VDvUWdEnfzGXtL6sq70v COxIa6xepaIqFdisii4XNZ7otRLYd3KlbXr2AuqjWhGeaWBVwvGhl7ILLaBkhSROqr4ex2w6L6mcp 3A+37faiOy/BGuj4EOniNcPEeCN9QwImMkXe4W2lM/JAMP1GywinZUr3mhGmR4q9StFQHuEMmXJ94 Ztztl5HTLP0rNFnLHUV7pg==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pCBWB-0000Ny-Lk; Sun, 01 Jan 2023 22:29:46 -0500 Date: Mon, 02 Jan 2023 05:29:50 +0200 Message-Id: <83bknh3975.fsf@gnu.org> From: Eli Zaretskii To: Gregory Heytings In-Reply-To: <226b32f79fbbaf16469b@heytings.org> (message from Gregory Heytings on Sun, 01 Jan 2023 21:50:56 +0000) Subject: Re: bug#60210: 30.0.50; tab-bar height not recalculated when face changes References: <86sfh350ok.fsf@mail.linkov.net> <8335934yse.fsf@gnu.org> <83edsm2w2a.fsf@gnu.org> <86y1qurs4i.fsf@mail.linkov.net> <226b32f79feedbfa05f1@heytings.org> <83o7ri2jy7.fsf@gnu.org> <226b32f79fbbaf16469b@heytings.org> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 60210 Cc: 60210@debbugs.gnu.org, juri@linkov.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Sun, 01 Jan 2023 21:50:56 +0000 > From: Gregory Heytings > cc: 60210@debbugs.gnu.org, juri@linkov.net > > > >> The bug is that, in redisplay_tab_bar, WINDOW_PIXEL_HEIGHT (w) uses the > >> height of the default face, which is 39 pixels, whereas new_height, > >> which is computed with tab_bar_height, uses the font of the tab-bar > >> face (variable-pitch in emacs -Q). On my system, new_height is (with a > >> single *scratch* tab) 36 pixels. Therefore new_height < > >> WINDOW_PIXEL_HEIGHT (w), when in fact according to the logic of the > >> code we should have new_height == WINDOW_PIXEL_HEIGHT (w). > > > > I'm not sure I understand how the above causes the tab bar not to be > > displayed, or become empty. AFAIU, it just means the frame's > > change_tab_bar_height_hook will be called. What did I miss? > > > > I do not fully understand it either yet. A simpler recipe, which does not > involve changing fonts: > > (set-face-attribute 'tab-bar nil :height 0.5) > (tab-bar-mode 1) > > This should display a tiny tab-bar, it displays a white bar instead. > > In redisplay_tab_bar, new_height is set to half the height of a canonical > line (17 and 34 on my system). Therefore redisplay_tab_bar returns true. > The next redisplay cycle finds that WINDOW_TOTAL_LINES (w) == 0, and does > nothing. Ah, if WINDOW_TOTAL_LINES becomes zero, that will indeed explain the problem. We should prevent that from happening as long as the tab bar is turned on. From debbugs-submit-bounces@debbugs.gnu.org Mon Jan 02 10:06:04 2023 Received: (at 60210) by debbugs.gnu.org; 2 Jan 2023 15:06:04 +0000 Received: from localhost ([127.0.0.1]:43806 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pCMO4-00063X-7B for submit@debbugs.gnu.org; Mon, 02 Jan 2023 10:06:04 -0500 Received: from eggs.gnu.org ([209.51.188.92]:43190) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pCMNz-00062t-2j for 60210@debbugs.gnu.org; Mon, 02 Jan 2023 10:06:02 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pCMNs-00058r-VW; Mon, 02 Jan 2023 10:05:52 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=4mibpVmwx0meau4q4N8ByBYfw5LUb8xlxmttktQeTEw=; b=G82yHhKJ8UO0 1ve6g4gEIn8D9IfSl33zQigvG8Dl0iHiOrQwSQidnS067XZqiteXDptvN6L+5w3seTWFxYipOWN6V Q30+U6lqTh/qVo1N3bClxvFRqWiAELLekDDY05ufw2POqRr/NjqkCcCPc26MJU/sHLIGyNfGd52EW Calc9kiVd2ONPGHsw5PE7FFrVlyBi+7EGBj8nNAgRY3F5GTMw+SAH9vpQttiCF2uZaSHNM4dAPATl 9U0fA9lJHSrtkq+onplx9iw9Rl6Yus87RV1uksK5QQGtUsiKNjhrNywTIFfxH4k5h2onVnFfjmIOM bBqflSYwCDnPAN46xipWOg==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pCMNi-0007Xc-Mh; Mon, 02 Jan 2023 10:05:52 -0500 Date: Mon, 02 Jan 2023 17:05:49 +0200 Message-Id: <83o7rh0yeq.fsf@gnu.org> From: Eli Zaretskii To: Gregory Heytings In-Reply-To: <226b32f79fbbaf16469b@heytings.org> (message from Gregory Heytings on Sun, 01 Jan 2023 21:50:56 +0000) Subject: Re: bug#60210: 30.0.50; tab-bar height not recalculated when face changes References: <86sfh350ok.fsf@mail.linkov.net> <8335934yse.fsf@gnu.org> <83edsm2w2a.fsf@gnu.org> <86y1qurs4i.fsf@mail.linkov.net> <226b32f79feedbfa05f1@heytings.org> <83o7ri2jy7.fsf@gnu.org> <226b32f79fbbaf16469b@heytings.org> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 60210 Cc: 60210@debbugs.gnu.org, juri@linkov.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Sun, 01 Jan 2023 21:50:56 +0000 > From: Gregory Heytings > cc: 60210@debbugs.gnu.org, juri@linkov.net > > > I'm not sure I understand how the above causes the tab bar not to be > > displayed, or become empty. AFAIU, it just means the frame's > > change_tab_bar_height_hook will be called. What did I miss? > > > > I do not fully understand it either yet. A simpler recipe, which does not > involve changing fonts: > > (set-face-attribute 'tab-bar nil :height 0.5) > (tab-bar-mode 1) > > This should display a tiny tab-bar, it displays a white bar instead. > > In redisplay_tab_bar, new_height is set to half the height of a canonical > line (17 and 34 on my system). Therefore redisplay_tab_bar returns true. > The next redisplay cycle finds that WINDOW_TOTAL_LINES (w) == 0, and does > nothing. Thanks, I hope I fixed this now on emacs-29, please re-test. From debbugs-submit-bounces@debbugs.gnu.org Mon Jan 02 10:28:41 2023 Received: (at 60210) by debbugs.gnu.org; 2 Jan 2023 15:28:41 +0000 Received: from localhost ([127.0.0.1]:43828 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pCMjw-0006hc-O7 for submit@debbugs.gnu.org; Mon, 02 Jan 2023 10:28:40 -0500 Received: from heytings.org ([95.142.160.155]:55942) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pCMjs-0006hP-GS for 60210@debbugs.gnu.org; Mon, 02 Jan 2023 10:28:39 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=heytings.org; s=20220101; t=1672673314; bh=oV3h0s3FYrCt9eykcmQEuaVxaRKzeORjoOVQDryP18g=; h=Date:From:To:cc:Subject:In-Reply-To:Message-ID:References:From; b=gledr0O15YeAHm1mR++GZx4jKt8oC2m2PBmSCBWYi+cbldmjJPR7wGh2lXRZbEyb6 3pmbXFjKT7Mfc1XxlBGZHZXQNlIGJmZtM9+2rao7KohP13mRmREK6XC5s73OlXkG2d HXQwkHYvJJZaJfEsgP32PXUchIQpx245uGKaYWAflVcqaq9pYALUoJccsNW1MPmiJH H6JhoOh7X7q/FH7j3Jm74MdOzXufEJjnNqfYRZtYrq9E72JsukcE7G2f2+IHYBBBQe q/kilddbRYs++8RKWMKRqRgDfbiKGyb9z0RHps38m8mmsb05U0K3dms0scF2yN/j2A jSfzAUuWXotgQ== Date: Mon, 02 Jan 2023 15:28:33 +0000 From: Gregory Heytings To: Eli Zaretskii Subject: Re: bug#60210: 30.0.50; tab-bar height not recalculated when face changes In-Reply-To: <83o7rh0yeq.fsf@gnu.org> Message-ID: <9bc9c69ac24f124330a2@heytings.org> References: <86sfh350ok.fsf@mail.linkov.net> <8335934yse.fsf@gnu.org> <83edsm2w2a.fsf@gnu.org> <86y1qurs4i.fsf@mail.linkov.net> <226b32f79feedbfa05f1@heytings.org> <83o7ri2jy7.fsf@gnu.org> <226b32f79fbbaf16469b@heytings.org> <83o7rh0yeq.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 60210 Cc: 60210@debbugs.gnu.org, juri@linkov.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > > Thanks, I hope I fixed this now on emacs-29, please re-test. > Thanks, it works now! My guess that is was a rounding problem was right. But I'm curious: in *_change_tab_bar_height we set f->tab_bar_lines, and in redisplay_tab_bar we check w->total_lines. Where is the former used to set the latter? From debbugs-submit-bounces@debbugs.gnu.org Mon Jan 02 11:53:06 2023 Received: (at 60210) by debbugs.gnu.org; 2 Jan 2023 16:53:06 +0000 Received: from localhost ([127.0.0.1]:43900 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pCO3e-0000bu-3L for submit@debbugs.gnu.org; Mon, 02 Jan 2023 11:53:06 -0500 Received: from eggs.gnu.org ([209.51.188.92]:40268) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pCO3Z-0000bN-R1 for 60210@debbugs.gnu.org; Mon, 02 Jan 2023 11:53:04 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pCO3S-0004yr-Gn; Mon, 02 Jan 2023 11:52:55 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=pu6Gj55jd404ggJ5n5hTfRB2Id+qoZkceJbjppWV1KQ=; b=arjdgPgFG+b8 aAlyO5IkWbgFCUF9bYTnzcWicVE97mX+qrPf7S/buC5KrYZUaNgIaw8C0qMbRplEUc2JYg0HA9yyB pCrIx8ztCs49chcib8ae4y3RGr7zU+0HWu2XRLlP2JW25GtqKdAA/QMOmwznSjq8YfOx4zBoptrvO VWarzaAC7A78WZMs3dWrsSMNXuEG8W5Cv1nBZ/hqOpUMaM5tAxeEWN1Z7oj3sAQArExKHdezYorRy XmG3u5GWkycfaL5pzIuH172sR5CQznR/SdathAxvcceKGSVg1BFrwpKlUtzLCQ14Rd8WtLcvbqzT3 tcssjtGWOPqihlaYcNY7gA==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pCO3R-0001Dq-RE; Mon, 02 Jan 2023 11:52:54 -0500 Date: Mon, 02 Jan 2023 18:53:00 +0200 Message-Id: <83mt70280j.fsf@gnu.org> From: Eli Zaretskii To: Gregory Heytings In-Reply-To: <9bc9c69ac24f124330a2@heytings.org> (message from Gregory Heytings on Mon, 02 Jan 2023 15:28:33 +0000) Subject: Re: bug#60210: 30.0.50; tab-bar height not recalculated when face changes References: <86sfh350ok.fsf@mail.linkov.net> <8335934yse.fsf@gnu.org> <83edsm2w2a.fsf@gnu.org> <86y1qurs4i.fsf@mail.linkov.net> <226b32f79feedbfa05f1@heytings.org> <83o7ri2jy7.fsf@gnu.org> <226b32f79fbbaf16469b@heytings.org> <83o7rh0yeq.fsf@gnu.org> <9bc9c69ac24f124330a2@heytings.org> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 60210 Cc: 60210@debbugs.gnu.org, juri@linkov.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Mon, 02 Jan 2023 15:28:33 +0000 > From: Gregory Heytings > cc: 60210@debbugs.gnu.org, juri@linkov.net > > > Thanks, I hope I fixed this now on emacs-29, please re-test. > > Thanks, it works now! My guess that is was a rounding problem was right. > But I'm curious: in *_change_tab_bar_height we set f->tab_bar_lines, and > in redisplay_tab_bar we check w->total_lines. Where is the former used to > set the latter? In adjust_frame_size and its subroutines, I guess. From debbugs-submit-bounces@debbugs.gnu.org Wed Jan 04 08:53:41 2023 Received: (at 60210) by debbugs.gnu.org; 4 Jan 2023 13:53:41 +0000 Received: from localhost ([127.0.0.1]:47963 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pD4D6-0004Xj-SV for submit@debbugs.gnu.org; Wed, 04 Jan 2023 08:53:41 -0500 Received: from heytings.org ([95.142.160.155]:58476) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pD4D4-0004Xa-Te for 60210@debbugs.gnu.org; Wed, 04 Jan 2023 08:53:39 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=heytings.org; s=20220101; t=1672840418; bh=4yl79sNfAh1LhjrB+xk5VZ21vxK6CoTFNJaQ7oZK00c=; h=Date:From:To:cc:Subject:In-Reply-To:Message-ID:References:From; b=i17CUrQVF9CRSwW9Tegt0grrDfO6YSt9w3kj36qV+XwwYhIb4MgYsr83G+nWuXl5I kzGp7FUOtDA09aqXQlEnNhw47ZL3d83bonGvGrO1JDpLgnqQZNTpLP1NC2j7pWDsg1 bdKl+P2HFbsENZ64cM/UHOB07jqD4aZoEXaHhYkn9SnHv36QbVVfqbfw9a6pYipdV0 Rnd9nMwg40fGwG+dwjMkehqH+UipOUhnJEmUvedz2P0+374Eg0HAps6C9xuG2oOuUl KRAWCm0o0sUFunjKDcj3XCggbxjKrHpyQpUhrGxX9KWtOEbWavQe+ihRW00tHGFzB9 GMU95cqcOsqRg== Date: Wed, 04 Jan 2023 13:53:36 +0000 From: Gregory Heytings To: Eli Zaretskii Subject: Re: bug#60210: 30.0.50; tab-bar height not recalculated when face changes In-Reply-To: <83mt70280j.fsf@gnu.org> Message-ID: References: <86sfh350ok.fsf@mail.linkov.net> <8335934yse.fsf@gnu.org> <83edsm2w2a.fsf@gnu.org> <86y1qurs4i.fsf@mail.linkov.net> <226b32f79feedbfa05f1@heytings.org> <83o7ri2jy7.fsf@gnu.org> <226b32f79fbbaf16469b@heytings.org> <83o7rh0yeq.fsf@gnu.org> <9bc9c69ac24f124330a2@heytings.org> <83mt70280j.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 60210 Cc: 60210@debbugs.gnu.org, juri@linkov.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) >>> Thanks, I hope I fixed this now on emacs-29, please re-test. >> >> Thanks, it works now! My guess that is was a rounding problem was >> right. But I'm curious: in *_change_tab_bar_height we set >> f->tab_bar_lines, and in redisplay_tab_bar we check w->total_lines. >> Where is the former used to set the latter? > > In adjust_frame_size and its subroutines, I guess. > Thanks, I'll have a look. The person who sent me the bug report confirmed that the bug is also fixed with his configuration, so all is well. From unknown Thu Aug 14 22:18:21 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Thu, 02 Feb 2023 12:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator