From debbugs-submit-bounces@debbugs.gnu.org Mon Dec 19 09:46:35 2022 Received: (at submit) by debbugs.gnu.org; 19 Dec 2022 14:46:35 +0000 Received: from localhost ([127.0.0.1]:38598 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p7HPX-00039y-F3 for submit@debbugs.gnu.org; Mon, 19 Dec 2022 09:46:35 -0500 Received: from lists.gnu.org ([209.51.188.17]:43176) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p7HPU-00039s-Uq for submit@debbugs.gnu.org; Mon, 19 Dec 2022 09:46:33 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p7HPU-00081t-DB for bug-guix@gnu.org; Mon, 19 Dec 2022 09:46:32 -0500 Received: from mira.cbaines.net ([2a01:7e00:e000:2f8:fd4d:b5c7:13fb:3d27]) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p7HPS-00041X-KV for bug-guix@gnu.org; Mon, 19 Dec 2022 09:46:32 -0500 Received: from localhost (unknown [IPv6:2a02:8010:68c1:0:3a91:a0a4:ecee:f157]) by mira.cbaines.net (Postfix) with ESMTPSA id D072627BBE9 for ; Mon, 19 Dec 2022 14:46:26 +0000 (GMT) Received: from felis (localhost [127.0.0.1]) by localhost (OpenSMTPD) with ESMTP id 76a6ae45 for ; Mon, 19 Dec 2022 14:46:30 +0000 (UTC) User-agent: mu4e 1.8.11; emacs 28.2 From: Christopher Baines To: bug-guix@gnu.org Subject: tests/cpio failure Date: Mon, 19 Dec 2022 14:44:20 +0000 Message-ID: <871qovo3i3.fsf@cbaines.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Received-SPF: pass client-ip=2a01:7e00:e000:2f8:fd4d:b5c7:13fb:3d27; envelope-from=mail@cbaines.net; helo=mira.cbaines.net X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) --=-=-= Content-Type: text/plain This test seems to fail, maybe because of high inode numbers, maybe something to with btrfs. I saw this with the failed builds here https://data.guix.gnu.org/gnu/store/kg93i3bmvpdfkiqyx6g9r7ywh0xpvm8w-guix-1.4.0 cbaines@milano-guix-1 ~$ guix repl GNU Guile 3.0.8 Copyright (C) 1995-2021 Free Software Foundation, Inc. Guile comes with ABSOLUTELY NO WARRANTY; for details type `,show w'. This program is free software, and you are welcome to redistribute it under certain conditions; type `,show c' for details. Enter `,help' for help. scheme@(guix-user)> (use-modules (guix cpio)) scheme@(guix-user)> (file->cpio-header "guix/guix.scm") $1 = #< magic: 460545 ino: 5031515288 mode: 33188 uid: 1003 gid: 998 nlink: 1 mtime: 1671460627 file-size: 1452 dev-maj: 0 dev-min: 24 rdev-maj: 0 rdev-min: 0 name-size: 14 checksum: 0> scheme@(guix-user)> (use-modules (rnrs io ports)) scheme@(guix-user)> (define header $1) scheme@(guix-user)> (call-with-values (lambda () (open-bytevector-output-port)) (lambda (port get-bv) (write-cpio-header header port) (let ((port (open-bytevector-input-port (get-bv)))) (equal? header (read-cpio-header port))))) $2 = #f scheme@(guix-user)> (call-with-values (lambda () (open-bytevector-output-port)) (lambda (port get-bv) (write-cpio-header header port) (let ((port (open-bytevector-input-port (get-bv)))) (equal? (peek "A" header) (peek "B" (read-cpio-header port)))))) ;;; ("A" #< magic: 460545 ino: 5031515288 mode: 33188 uid: 1003 gid: 998 nlink: 1 mtime: 1671460627 file-size: 1452 dev-maj: 0 dev-min: 24 rdev-maj: 0 rdev-min: 0 name-size: 14 checksum: 0>) ;;; ("B" #< magic: 460545 ino: 736547992 mode: 33188 uid: 1003 gid: 998 nlink: 1 mtime: 1671460627 file-size: 1452 dev-maj: 0 dev-min: 24 rdev-maj: 0 rdev-min: 0 name-size: 14 checksum: 0>) $3 = #f --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKlBAEBCgCPFiEEPonu50WOcg2XVOCyXiijOwuE9XcFAmOgeURfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcRHG1haWxAY2Jh aW5lcy5uZXQACgkQXiijOwuE9XcsXQ/+IpKoQFJ+yRd+fmrOShwFAL+Dt0TpiyEm xD3o0kxhAKFBKC8mgMZK1WNdljdZMNxWcpid1WxoejMn7DgK23jLl2VMWMC7NGsd BNLCf/6pNTUTP41w1D+CGtTPtkyqwr+DuKjMXm34mAxylnaQO7gP0TBLC798ERMy cddABM667ydUMZINkehgHs+X9N9a01g12qB5uy02Ydl6GO2EMLNSenD0NHcqAGmt 4eKsMXK8X2Lw4rjz5ZZu+JUbDm4B8TqmHR99dOr9+IpWNPp8EqXoHS9PLIyGn8ek EuSnEfMZTCcRmiQ+lG599/KpoXI+G1EW304BsjuohtGIANna4efNyASbBddOIYee Kt0iSaW7xgfxBQLPN1wI29+lvCO2mYGXW8ftKIRFVOGWiQjkqqHQdAlm2PpskYYd mRVnQXJcUCXJKlFdsaXJUQJlWV5pcdBz65WEglZNO4xl1obmINko5wm4jUkp4nir ZYq38xmponPP2r3kGemDwiIYXOzl2mpJEiPBYhWZiHvT0CI8ZByWe5FaOJ0TjBN4 yonZhS9H083ewWKJx1LugvEejmywduTdGj5isO8GyuVnSSu3cbwDWaobzuASr2qc 8KetWEwR7Pl8pOXqee1v6r/m1VCnDsXQoxI9WavObsBpdCf6UrmtwBXyFk0TuyFC +iwxXuChUWA= =wgpT -----END PGP SIGNATURE----- --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Mon Dec 19 10:00:34 2022 Received: (at 60202) by debbugs.gnu.org; 19 Dec 2022 15:00:34 +0000 Received: from localhost ([127.0.0.1]:38641 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p7Hd4-0003Lt-F1 for submit@debbugs.gnu.org; Mon, 19 Dec 2022 10:00:34 -0500 Received: from eggs.gnu.org ([209.51.188.92]:45966) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p7Hd0-0003Ln-Pb for 60202@debbugs.gnu.org; Mon, 19 Dec 2022 10:00:32 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p7Hcv-0006li-HB; Mon, 19 Dec 2022 10:00:25 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=pL6uA+gNEkCGVEKkn8ot3ITcaxw0F1BGIaAT288PYa8=; b=hydlyR1XTzMbRTWgGz2Z bPwVS/3H0gq7imAlD4ZRHH5C731TU9FnzGr0T5yGmrbVtER9qXmALPYjNJHXWu/HcjtzNsUzDCdez fRb5+HlXlJ4iMtNv1p5Xor9hGVf0DFYTJlx3uaiuhH1/Icd9TSe1NcztgfFnb2urK1EhM47E2xdkH PsenKjMUa50PHNixVHojHPe4fy7QEhA/F0HNWTahu7NCpbJ+nQVweTIT5nWs7yM5HAanJy8fqu2U9 xn8SsN/4CDdVLT1Sf4yAvlbYXt4x/5AS4lhBjeyrQLdY8ti21EbBs2+/IIsH3i19BAf1qC2n7g7XR /yUBtfcvqvdOmQ==; Received: from 91-160-117-201.subs.proxad.net ([91.160.117.201] helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p7Hcv-0003v0-5B; Mon, 19 Dec 2022 10:00:25 -0500 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Christopher Baines Subject: Re: bug#60202: tests/cpio failure References: <871qovo3i3.fsf@cbaines.net> Date: Mon, 19 Dec 2022 16:00:22 +0100 In-Reply-To: <871qovo3i3.fsf@cbaines.net> (Christopher Baines's message of "Mon, 19 Dec 2022 14:44:20 +0000") Message-ID: <87tu1rcubd.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 60202 Cc: 60202@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hi, Christopher Baines skribis: > This test seems to fail, maybe because of high inode numbers, maybe > something to with btrfs. Uh. > scheme@(guix-user)> (file->cpio-header "guix/guix.scm") > $1 =3D #< magic: 460545 ino: 5031515288 mode: 33188 uid: 100= 3 gid: 998 nlink: 1 mtime: 1671460627 file-size: 1452 dev-maj: 0 dev-min: 2= 4 rdev-maj: 0 rdev-min: 0 name-size: 14 checksum: 0> [...] > (let ((port (open-bytevector-input-port (get-bv)))) > (equal? (peek "A" header) > (peek "B" (read-cpio-header port)))))) > > ;;; ("A" #< magic: 460545 ino: 5031515288 mode: 33188 uid: 1= 003 gid: 998 nlink: 1 mtime: 1671460627 file-size: 1452 dev-maj: 0 dev-min:= 24 rdev-maj: 0 rdev-min: 0 name-size: 14 checksum: 0>) > > ;;; ("B" #< magic: 460545 ino: 736547992 mode: 33188 uid: 10= 03 gid: 998 nlink: 1 mtime: 1671460627 file-size: 1452 dev-maj: 0 dev-min: = 24 rdev-maj: 0 rdev-min: 0 name-size: 14 checksum: 0>) > $3 =3D #f (guix cpio) defines cpio headers like this: --8<---------------cut here---------------start------------->8--- (define-pack %make-cpio-header cpio-header? write-cpio-header read-cpio-header (magic 6 cpio-header-magic) (ino 8 cpio-header-inode) (mode 8 cpio-header-mode) (uid 8 cpio-header-uid) (gid 8 cpio-header-gid) (nlink 8 cpio-header-nlink) (mtime 8 cpio-header-mtime) (file-size 8 cpio-header-file-size) (dev-maj 8 cpio-header-device-major) (dev-min 8 cpio-header-device-minor) (rdev-maj 8 cpio-header-rdevice-major) (rdev-min 8 cpio-header-rdevice-minor) (name-size 8 cpio-header-name-size) (checksum 8 cpio-header-checksum)) ;0 for "newc" format --8<---------------cut here---------------end--------------->8--- The =E2=80=98ino=E2=80=99 value is stored as an 8-digit hexadecimal number= =E2=80=94i.e., on 32 bits. And, guess what: --8<---------------cut here---------------start------------->8--- scheme@(guile-user)> 5031515288 ;the inode number above $15 =3D 5031515288 scheme@(guile-user)> (expt 2 32) $16 =3D 4294967296 scheme@(guile-user)> (- $16 $15) $17 =3D -736547992 --8<---------------cut here---------------end--------------->8--- Noways, libc + kernel typically use a 64-bit =E2=80=98ino_t=E2=80=99, so fu= ndamentally the cpio format is =E2=80=9Cwrong=E2=80=9D. But what can we do? At least we can skip this test when that is the case (patch below). WDYT? Thanks, Ludo=E2=80=99. --=-=-= Content-Type: text/x-patch; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable diff --git a/tests/cpio.scm b/tests/cpio.scm index 516de0655b..832101d1bb 100644 --- a/tests/cpio.scm +++ b/tests/cpio.scm @@ -1,5 +1,5 @@ ;;; GNU Guix --- Functional package management for GNU -;;; Copyright =C2=A9 2015 Ludovic Court=C3=A8s +;;; Copyright =C2=A9 2015, 2022 Ludovic Court=C3=A8s ;;; ;;; This file is part of GNU Guix. ;;; @@ -31,12 +31,18 @@ (define-module (test-cpio) (define %cpio-program (which "cpio")) =20 +(define %test-file + (search-path %load-path "guix.scm")) + (test-begin "cpio") =20 +;; The cpio format expects 'ino' to fit in 32 bits. If we have a bigger i= node +;; number, skip this test. +(test-skip + (if (>=3D (stat:ino (lstat %test-file)) (expt 2 32)) 1 0)) (test-assert "file->cpio-header + write-cpio-header + read-cpio-header" - (let* ((file (search-path %load-path "guix.scm")) - (header (file->cpio-header file))) + (let* ((header (file->cpio-header %test-file))) (call-with-values (lambda () (open-bytevector-output-port)) --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Tue Dec 20 11:15:21 2022 Received: (at 60202-done) by debbugs.gnu.org; 20 Dec 2022 16:15:22 +0000 Received: from localhost ([127.0.0.1]:45756 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p7fGz-0006NP-LA for submit@debbugs.gnu.org; Tue, 20 Dec 2022 11:15:21 -0500 Received: from eggs.gnu.org ([209.51.188.92]:52226) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p7fGx-0006NH-U7 for 60202-done@debbugs.gnu.org; Tue, 20 Dec 2022 11:15:20 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p7fGs-0002T7-9o; Tue, 20 Dec 2022 11:15:14 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=54PRx72t/YkHWiDtSv2wpCzGDfdA8dHpvrkkrmRpI2I=; b=lLn0IfjqMy8q3TwMBAUV dsVKBNHnZ4ysC99yHx2S2wjlat8BBP9FD6p5KlNnNNtP+2XX6kbX0rxmQPoxW40HFiihzklFwJRVk RlyMhd7CsANFYdePoxqH/hgsZe3bA+XzyU7/bqvPIyVAB1nVFplcJm58mxbmrBTfeR3VrR1DNZQBz idsiFvatsBb/NPwyTvP0NAJticZkKmngP80U0lzMFSihEuQOFPau+mMehUqcN0bHp6oasxwK3I83V 6QjeKFBs/2ONkzpv6Cw+i+lvYHepQMaopSvfiXK7KBWvG8/LMsucR7VDJZn3Er1tU6CNGVTInbvY1 zAjlaJ0g1IIEcA==; Received: from [193.50.110.60] (helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p7fGn-0005Nx-Ky; Tue, 20 Dec 2022 11:15:14 -0500 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Christopher Baines Subject: Re: bug#60202: tests/cpio failure References: <871qovo3i3.fsf@cbaines.net> <87tu1rcubd.fsf@gnu.org> Date: Tue, 20 Dec 2022 17:15:07 +0100 In-Reply-To: <87tu1rcubd.fsf@gnu.org> ("Ludovic =?utf-8?Q?Court=C3=A8s=22'?= =?utf-8?Q?s?= message of "Mon, 19 Dec 2022 16:00:22 +0100") Message-ID: <87k02m59x0.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 60202-done Cc: 60202-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Ludovic Court=C3=A8s skribis: > At least we can skip this test when that is the case (patch below). > WDYT? I went ahead with this in 2880dc3046170e9129437caca586f13956d0d811. Ludo=E2=80=99. From unknown Sun Sep 07 18:03:22 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Wed, 18 Jan 2023 12:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator