GNU bug report logs - #60201
[PATCH] gnu: Add libswell

Previous Next

Package: guix-patches;

Reported by: Sughosha <Sughosha <at> proton.me>

Date: Mon, 19 Dec 2022 13:50:02 UTC

Severity: normal

Tags: patch

Done: Ricardo Wurmus <rekado <at> elephly.net>

Bug is archived. No further changes may be made.

Full log

Message #26 received at 60201 <at> debbugs.gnu.org (full text, mbox):

From: Ricardo Wurmus <rekado <at> elephly.net>
To: 60201 <at> debbugs.gnu.org
Subject: [PATCH] gnu: Add libswell
Date: Mon, 02 Jan 2023 12:32:19 +0100

Hi,

thank you for the patch!

Could you add a comment why tests are disabled?

I recommend using a gexp for the phases:

  (arguments
    (list
      ;; There are no tests.
      #:tests? #false
      #:phases
      #~(modify-phases … )))

Then you can use #$output instead of binding the ‘outputs’ keyword
argument and looking up the output with label ‘out’.

Is it really enough to just install the .so?  Shouldn’t the headers also
be installed?

Why are origin and commit separated as a global definition? That seems
unnecessary.

-- 
Ricardo
This bug report was last modified 2 years and 218 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.