Subject: [PATCH] gnu: Add libswell

From: Ricardo Wurmus <[email-masked]>
Date: Mon, 02 Jan 2023 12:32:19 +0100

Hi,

thank you for the patch!

Could you add a comment why tests are disabled?

I recommend using a gexp for the phases:

  (arguments
    (list
      ;; There are no tests.
      #:tests? #false
      #:phases
      #~(modify-phases … )))

Then you can use #$output instead of binding the ‘outputs’ keyword
argument and looking up the output with label ‘out’.

Is it really enough to just install the .so?  Shouldn’t the headers also
be installed?

Why are origin and commit separated as a global definition? That seems
unnecessary.

-- 
Ricardo