GNU bug report logs - #6020
coreutils-8.x: a simple feature enhancement, and how to do it

Previous Next

Full log

View this message in rfc822 format

From: Pádraig Brady <P <at> draigBrady.com>
To: Erik Auerswald <auerswal <at> unix-ag.uni-kl.de>
Cc: 6020 <at> debbugs.gnu.org, "Nelson H. F. Beebe" <beebe <at> math.utah.edu>
Subject: bug#6020: coreutils-8.x: a simple feature enhancement, and how to do it
Date: Thu, 29 Apr 2010 09:33:59 +0100

[Message part 1 (text/plain, inline)]

On 29/04/10 07:26, Erik Auerswald wrote:
> Hi,
> 
> two nit-picks regarding the test script below:
> 
> On Thu, Apr 29, 2010 at 12:39:46AM +0100, Pádraig Brady wrote:
>> [...]
>> @@ -0,0 +1,51 @@
>> +#!/bin/sh
>> +# Ensure sort -g sorts floating point limits correctly
>> [...]
>> +if test "$VERBOSE" = yes; then
>> +  set -x
>> +  mv --version
>      ^^
>      sort
> would be nicer.

Heh, I noticed that :)

>> +# See if sort should be using long doubles
>> +grep '^#define HAVE_C99_STRTOLD 1' $CONFIG_HEADER > /dev/null ||
>                                                      ^^^^^^^^^^^
>                                                      -q
> would be more concise.

and efficient (it exits on first match).

However, even though POSIX specifies -q, it's not portable.
Solaris' grep for example, does not support -q.
We'll start using it at some stage though.

My latest patch is attached which corrects the info docs
to mention strtold() not strtod().

Also the test is updated to exclude floats in non standard formats
just in case, and also checks the fr_FR locale where the RADIXCHAR is ','

cheers,
Pádraig.

[sort-long-double.diff (text/x-patch, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.