Subject: Re: bug#6020: coreutils-8.x: a simple feature enhancement, and how to do it

From: Erik Auerswald <[email-masked]>
Date: Thu, 29 Apr 2010 08:26:49 +0200

Hi,

two nit-picks regarding the test script below:

On Thu, Apr 29, 2010 at 12:39:46AM +0100, Pádraig Brady wrote:
> [...]
> @@ -0,0 +1,51 @@
> +#!/bin/sh
> +# Ensure sort -g sorts floating point limits correctly
> [...]
> +if test "$VERBOSE" = yes; then
> +  set -x
> +  mv --version
     ^^
     sort
would be nicer.

> +fi
> +
> +. $srcdir/test-lib.sh
> +getlimits_
> +
> +# See if sort should be using long doubles
> +grep '^#define HAVE_C99_STRTOLD 1' $CONFIG_HEADER > /dev/null ||
                                                     ^^^^^^^^^^^
                                                     -q
would be more concise.

Regards,
Erik