From debbugs-submit-bounces@debbugs.gnu.org Mon Dec 19 03:53:48 2022 Received: (at submit) by debbugs.gnu.org; 19 Dec 2022 08:53:48 +0000 Received: from localhost ([127.0.0.1]:38081 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p7Bu8-0002R6-2r for submit@debbugs.gnu.org; Mon, 19 Dec 2022 03:53:48 -0500 Received: from lists.gnu.org ([209.51.188.17]:42544) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p70nt-0004uq-KY for submit@debbugs.gnu.org; Sun, 18 Dec 2022 16:02:38 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p70nk-0005hq-A2 for guix-patches@gnu.org; Sun, 18 Dec 2022 16:02:37 -0500 Received: from pv50p00im-zteg10011501.me.com ([17.58.6.42]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p70ni-0007eN-Hq for guix-patches@gnu.org; Sun, 18 Dec 2022 16:02:28 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=icloud.com; s=1a1hai; t=1671397342; bh=2zVyLdxCeRGarqhe0KlpU5Po8fJpdNEETbkpLubVDAs=; h=From:To:Subject:Date:Message-Id:MIME-Version; b=Lls3W3S4tLt/X5IFejd36c6h9GsbqzMmSVXJfk6o4S7qAgMmb5EcJtTDUXBf+2BRb x30Y0OMAEmbHEUx8FcHl0i7d3tZoxpWkCZxUzGHN5tV73wpa0JrtL3UF4CJ+9vghHQ xax4MFLGUp+r+WC9VCO5UmoVVSSGClbzVystfiMP4fU4efi88DnTgkW1J0No8FoPi/ rniIfolWNsstZwXM6AE4lti+b0N4DzVCyMFzUs+iuADpUXReA3WLWtsMjDxd2EKAUl eZjXW8NcKXKWpCRIYEDnPN7r3JJRrUCbD2KnMk6T/hrZ2M8WdWMzRxjILTGaUln4j1 lfh3xrzj+Vq7g== Received: from localhost.localdomain (pv50p00im-dlb-asmtp-mailmevip.me.com [17.56.9.10]) by pv50p00im-zteg10011501.me.com (Postfix) with ESMTPSA id 991292E00E2; Sun, 18 Dec 2022 21:02:20 +0000 (UTC) From: Adam Kandur To: guix-patches@gnu.org Subject: [PATCH] gnu: Add python-tcod. Date: Mon, 19 Dec 2022 00:02:16 +0300 Message-Id: <20221218210216.3920-1-manualbot@icloud.com> X-Mailer: git-send-email 2.38.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Proofpoint-ORIG-GUID: GV3eQxS4WVyzAyDwPH786Uebd2IbYpsA X-Proofpoint-GUID: GV3eQxS4WVyzAyDwPH786Uebd2IbYpsA X-Proofpoint-Virus-Version: =?UTF-8?Q?vendor=3Dfsecure_engine=3D1.1.170-22c6f66c430a71ce266a39bfe25bc?= =?UTF-8?Q?2903e8d5c8f:6.0.517,18.0.883,17.11.64.514.0000000_definitions?= =?UTF-8?Q?=3D2022-06-21=5F08:2022-06-21=5F01,2022-06-21=5F08,2022-02-23?= =?UTF-8?Q?=5F01_signatures=3D0?= X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 spamscore=0 adultscore=0 bulkscore=0 phishscore=0 mlxscore=0 clxscore=1011 suspectscore=0 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2209130000 definitions=main-2212180200 Received-SPF: pass client-ip=17.58.6.42; envelope-from=manualbot@icloud.com; helo=pv50p00im-zteg10011501.me.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Mon, 19 Dec 2022 03:53:46 -0500 Cc: Adam Kandur X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) * gnu/packages/game-development.scm (python-tcod): New variable. --- gnu/packages/game-development.scm | 47 +++++++++++++++++++++++++++++++ 1 file changed, 47 insertions(+) diff --git a/gnu/packages/game-development.scm b/gnu/packages/game-development.scm index 8fec474d0b..2746c43a5f 100644 --- a/gnu/packages/game-development.scm +++ b/gnu/packages/game-development.scm @@ -64,6 +64,7 @@ (define-module (gnu packages game-development) #:use-module (gnu packages bash) #:use-module (gnu packages boost) #:use-module (gnu packages build-tools) + #:use-module (gnu packages c) #:use-module (gnu packages compression) #:use-module (gnu packages check) #:use-module (gnu packages curl) @@ -86,6 +87,7 @@ (define-module (gnu packages game-development) #:use-module (gnu packages guile) #:use-module (gnu packages image) #:use-module (gnu packages linux) + #:use-module (gnu packages libffi) #:use-module (gnu packages llvm) #:use-module (gnu packages lua) #:use-module (gnu packages m4) @@ -97,6 +99,7 @@ (define-module (gnu packages game-development) #:use-module (gnu packages pkg-config) #:use-module (gnu packages pulseaudio) #:use-module (gnu packages python) + #:use-module (gnu packages python-check) #:use-module (gnu packages python-web) #:use-module (gnu packages python-xyz) #:use-module (gnu packages readline) @@ -2604,6 +2607,50 @@ (define-public libtcod utilities frequently used in roguelikes.") (license license:bsd-3))) +(define-public python-tcod + ;; named branch is outdated + (let ((commit "d3419a5b4593c7df1580427fc07616d798c85856") + (revision "1")) + (package + (name "python-tcod") + (version "13.9.1") + (source + (origin + (method git-fetch) + (uri (git-reference + (url "https://github.com/libtcod/python-tcod") + (commit commit) + (recursive? #true))) + (file-name (git-file-name name version)) + (sha256 + (base32 + "1b0ligrswvz307bbx5jp8wnnqz52v5s4gcgakxy4i3jvccalm2if")))) + (build-system python-build-system) + ;; tests fail for a strange reason + ;; "ERROR docs/conf.py - FileNotFoundError", + ;; but this file is in the checkout + (arguments + '(#:tests? #f)) + (native-inputs + (list sdl2 + python-pcpp + python-pycparser + python-requests + python-pytest-runner + python-pytest-benchmark + python-pytest-cov)) + (propagated-inputs + (list python-numpy + python-typing-extensions + python-cffi)) + (home-page "https://github.com/libtcod/python-tcod") + (synopsis + "This library is a Python cffi port of libtcod") + (description + "A high-performance Python port of libtcod. +Includes the libtcodpy module for backwards compatibility with older projects.") + (license license:bsd-2)))) + (define-public warsow-qfusion ;; As of 2020-04-09, the latest stable version 2.1.0 is deprecated. ;; The 2.5 beta as published on the homepage is commit -- 2.38.1 From debbugs-submit-bounces@debbugs.gnu.org Thu Jan 26 04:43:04 2023 Received: (at control) by debbugs.gnu.org; 26 Jan 2023 09:43:04 +0000 Received: from localhost ([127.0.0.1]:60742 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pKyme-0000TN-9V for submit@debbugs.gnu.org; Thu, 26 Jan 2023 04:43:04 -0500 Received: from eggs.gnu.org ([209.51.188.92]:55638) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pKymb-0000Sr-Ob for control@debbugs.gnu.org; Thu, 26 Jan 2023 04:43:02 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pKymW-0001fC-Hu for control@debbugs.gnu.org; Thu, 26 Jan 2023 04:42:56 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:Subject:From:To:Date:in-reply-to: references; bh=7w8tOs6xClTtGFOhPjElliebsPtG/uQ26BX5UIq3v1A=; b=EJGP6h70t9iRiS +FN/8G9Vjnpuh2/hbwSRk00I2nqTaWdqOoST3N4pn/2tddNfog8DuOxkNiJcNpJ4XIDE/LrgEwvUO h+NfyFw+ufwqOSHPEOdf4FKPNxhtbcWoU7d7oLhNgMAmN4/Hu6kIjR1OoiXGSXLrkMNsEajdqL6uF yv7B9RdzFhjqdnkAGgCzxVVfyoBhKcIV5+e7t7xPKkoAkoPD5r34SvAKVySJaP9v8H9EzC6RJNJuE Cunwv3/zuXIC9PygM3wp7w2bVw0ytVsAVRm/SB2JStAXBbIVmouOf13NutEDYaRoLpweG09QIBCAE hm8v7CPeIGYbSBH0rnIA==; Received: from 91-160-117-201.subs.proxad.net ([91.160.117.201] helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pKymV-0001Fq-PA for control@debbugs.gnu.org; Thu, 26 Jan 2023 04:42:55 -0500 Date: Thu, 26 Jan 2023 10:42:54 +0100 Message-Id: <87o7qlr5r5.fsf@gnu.org> To: control@debbugs.gnu.org From: =?utf-8?Q?Ludovic_Court=C3=A8s?= Subject: control message for bug #60192 MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) merge 60192 60193 quit From debbugs-submit-bounces@debbugs.gnu.org Thu Jan 26 04:51:52 2023 Received: (at 60192) by debbugs.gnu.org; 26 Jan 2023 09:51:52 +0000 Received: from localhost ([127.0.0.1]:60749 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pKyvA-00034c-7g for submit@debbugs.gnu.org; Thu, 26 Jan 2023 04:51:52 -0500 Received: from eggs.gnu.org ([209.51.188.92]:55820) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pKyv7-00034O-8s for 60192@debbugs.gnu.org; Thu, 26 Jan 2023 04:51:50 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pKyv1-0006T7-Of; Thu, 26 Jan 2023 04:51:43 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=AtsulCkp15QGONrfrmnpVea7462Rqf/s+4Y+5qJOQ2k=; b=l67Q/0SxRoZzSmBh/NOR jgYFbYemAEmqSLj/a/1OGpI2WpuPCsThF/+gNjrSRF5Gep1dqK9mltQZ0rKGWjDsnJdDBQENb8Wna GmpBbSN8lvCDh5iAXvd2H/6uTS7pRX4pVC/Mduqahpgf31Ltk0hVvbWQFNWeNekCy0UkMNqN2dahp Tu+bylpEUz6vK5eX0l6mn/TKETiE7YINUD875ETUvFYct/cetT2yOFha1+0ZKDyYfrCd+tyP7eOsC psaNl/r+KNk7klcj0uHYo8ZHOzHH1FhJl0ViStsvPEPLrjoSUqizrJ5jfG/0i6Kz6AfugvMsafXXB Sxq8JEKX+h3ATw==; Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pKyv0-00029P-3h; Thu, 26 Jan 2023 04:51:42 -0500 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Adam Kandur Subject: Re: bug#60192: [PATCH] gnu: Add python-tcod. References: <20221218210216.3920-1-manualbot@icloud.com> Date: Thu, 26 Jan 2023 10:51:39 +0100 In-Reply-To: <20221218210216.3920-1-manualbot@icloud.com> (Adam Kandur's message of "Mon, 19 Dec 2022 00:02:16 +0300") Message-ID: <87k019r5ck.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 60192 Cc: 60192@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hi, Adam Kandur skribis: > * gnu/packages/game-development.scm (python-tcod): New variable. I suggest the attached changes. However, one comment: > + ;; tests fail for a strange reason > + ;; "ERROR docs/conf.py - FileNotFoundError", > + ;; but this file is in the checkout > + (arguments > + '(#:tests? #f)) > + (native-inputs > + (list sdl2 > + python-pcpp > + python-pycparser > + python-requests > + python-pytest-runner > + python-pytest-benchmark > + python-pytest-cov)) > + (propagated-inputs > + (list python-numpy > + python-typing-extensions > + python-cffi)) > + (home-page "https://github.com/libtcod/python-tcod") > + (synopsis > + "This library is a Python cffi port of libtcod") That =E2=80=98FileNotFoundError=E2=80=99, could it be because libtcod itsel= f is missing? I would expect libtocd to be in =E2=80=98inputs=E2=80=99 since this package= provides bindings to libtcod, no? > + (description > + "A high-performance Python port of libtcod. > +Includes the libtcodpy module for backwards compatibility with older pro= jects.") Please improve the synopsis and description as per: https://guix.gnu.org/manual/en/html_node/Synopses-and-Descriptions.html Could you send an updated patch? Thanks, Ludo=E2=80=99. --=-=-= Content-Type: text/plain Content-Disposition: inline diff --git a/gnu/packages/game-development.scm b/gnu/packages/game-development.scm index 304df3bd75..dd08241080 100644 --- a/gnu/packages/game-development.scm +++ b/gnu/packages/game-development.scm @@ -2584,11 +2584,12 @@ (define-public python-tcod (package (name "python-tcod") (version "13.9.1") + (home-page "https://github.com/libtcod/python-tcod") (source (origin (method git-fetch) (uri (git-reference - (url "https://github.com/libtcod/python-tcod") + (url home-page) (commit commit) (recursive? #true))) (file-name (git-file-name name version)) @@ -2613,7 +2614,6 @@ (define-public python-tcod (list python-numpy python-typing-extensions python-cffi)) - (home-page "https://github.com/libtcod/python-tcod") (synopsis "This library is a Python cffi port of libtcod") (description --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Thu Jan 26 13:50:19 2023 Received: (at 60192) by debbugs.gnu.org; 26 Jan 2023 18:50:19 +0000 Received: from localhost ([127.0.0.1]:36175 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pL7KF-0008Mn-5F for submit@debbugs.gnu.org; Thu, 26 Jan 2023 13:50:19 -0500 Received: from ms11p00im-qufo17291601.me.com ([17.58.38.45]:35446) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pL6PO-0006iz-Ph for 60192@debbugs.gnu.org; Thu, 26 Jan 2023 12:51:35 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=icloud.com; s=1a1hai; t=1674755489; bh=OI2UGYQ0e2N3g8fwM8B6XD6gAfslqe14wHQBlyrZJ4Q=; h=To:From:Subject:Date:Message-id:Content-Type:MIME-Version; b=b+kjZMKOkw3olis8b7GBen4kcwovzQR0iA512yWiOJEikFps9Sz6PYL0+VHGWC3YK 9S4ULqfk6Cz5n3YOOKF9CjYy7qzsrLOSj8SGLakqILm+g/yxy2t07gdBSpwU89VEum eOzn44962OfFMU2G/9i52tq85k7ZJDiF6GYKtBLL6QgFnIhr/tEOzZ0n9myKwb1Zin 6hUo7xXZXFo0h2MM/Wo6OMG1whOBOgGDOJUHm8K4AzNSpWT4gVmeVKaKvVFrPYXlgL cojiEeGNLRr7V2RUOFvfCMUUzSxsl9ik4kqmCoVtP4TeVBa39440p4Krk7wvfU0pYK oIp9UdAgZy9/g== Received: from ms11p00im-qufo17291601.me.com (ms11p00im-qufo17291601.me.com [17.58.38.45]) by ms11p00im-qufo17291601.me.com (Postfix) with ESMTPS id B5C013A0838; Thu, 26 Jan 2023 17:51:28 +0000 (UTC) Received: from localhost (ms11p00im-dlb-asmtpoutvip.me.com [10.52.196.131]) by ms11p00im-qufo17291601.me.com (Postfix) with ESMTPA id 9C1623A079B; Thu, 26 Jan 2023 17:51:28 +0000 (UTC) To: =?utf-8?B?THVkb3ZpYyBDb3VydMOocw==?= From: Adam Kandur Subject: Re: bug#60192: [PATCH] gnu: Add python-tcod. Date: Thu, 26 Jan 2023 17:51:28 -0000 X-Mailer: iCloud MailClientcurrent MailServer2308B104.10000-Famine2308-0-6c2ccbee4fd8 Message-id: Content-Type: multipart/alternative; boundary=Apple-Webmail-42--80faaf0a-f27c-4f44-bdd4-719252c78072 MIME-Version: 1.0 In-Reply-To: <87k019r5ck.fsf@gnu.org> References: <20221218210216.3920-1-manualbot@icloud.com> <87k019r5ck.fsf@gnu.org> X-Proofpoint-ORIG-GUID: Xum8RWK361Bs7bFsrxLUPx_BpWtZnUis X-Proofpoint-GUID: Xum8RWK361Bs7bFsrxLUPx_BpWtZnUis X-Proofpoint-Virus-Version: =?UTF-8?Q?vendor=3Dfsecure_engine=3D1.1.170-22c6f66c430a71ce266a39bfe25bc?= =?UTF-8?Q?2903e8d5c8f:6.0.425,18.0.816,17.0.605.474.0000000_definitions?= =?UTF-8?Q?=3D2022-01-18=5F01:2022-01-14=5F01,2022-01-18=5F01,2020-01-23?= =?UTF-8?Q?=5F02_signatures=3D0?= X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 malwarescore=0 phishscore=0 clxscore=1011 spamscore=0 suspectscore=0 mlxscore=0 bulkscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2209130000 definitions=main-2301260172 X-Spam-Score: -0.6 (/) X-Debbugs-Envelope-To: 60192 X-Mailman-Approved-At: Thu, 26 Jan 2023 13:50:17 -0500 Cc: 60192@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.6 (-) --Apple-Webmail-42--80faaf0a-f27c-4f44-bdd4-719252c78072 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8; format=flowed Sure, I will fix my patch and will try to build the package with suggested= input (probably next week).On Jan 26, 2023, at 1:51 AM, Ludovic Court=C3=A8= s wrote:Hi,Adam Kandur skribis:* gnu= /packages/game-development.scm (python-tcod): New variable.I suggest the a= ttached changes.However, one comment:+ ;; tests fail for a strange re= ason+ ;; "ERROR docs/conf.py - FileNotFoundError",+ ;; but this = file is in the checkout+ (arguments+ '(#:tests? #f))+ (nat= ive-inputs+ (list sdl2+ python-pcpp+ python-= pycparser+ python-requests+ python-pytest-runner+ = python-pytest-benchmark+ python-pytest-cov))+ = (propagated-inputs+ (list python-numpy+ python-typing-e= xtensions+ python-cffi))+ (home-page "https://github.com/= libtcod/python-tcod")+ (synopsis+ "This library is a Python cff= i port of libtcod")That =E2=80=98FileNotFoundError=E2=80=99, could it be b= ecause libtcod itself is missing?I would expect libtocd to be in =E2=80=98= inputs=E2=80=99 since this package providesbindings to libtcod, no?+ = (description+ "A high-performance Python port of libtcod.+Includes t= he libtcodpy module for backwards compatibility with older projects.")Plea= se improve the synopsis and description as per: https://guix.gnu.org/manua= l/en/html_node/Synopses-and-Descriptions.htmlCould you send an updated pat= ch?Thanks,Ludo=E2=80=99.diff --git a/gnu/packages/game-development.scm b/g= nu/packages/game-development.scmindex 304df3bd75..dd08241080 100644--- a/g= nu/packages/game-development.scm+++ b/gnu/packages/game-development.scm@@ = -2584,11 +2584,12 @@ (define-public python-tcod (package (name "python-tco= d") (version "13.9.1")+ (home-page "https://github.com/libtcod/python= -tcod") (source (origin (method git-fetch) (uri (git-reference- = (url "https://github.com/libtcod/python-tcod")+ (url hom= e-page) (commit commit) (recursive? #true))) (file-name (git-file-name nam= e version))@@ -2613,7 +2614,6 @@ (define-public python-tcod (list python-n= umpy python-typing-extensions python-cffi))- (home-page "https://gith= ub.com/libtcod/python-tcod") (synopsis "This library is a Python cffi port= of libtcod") (description --Apple-Webmail-42--80faaf0a-f27c-4f44-bdd4-719252c78072 Content-Type: multipart/related; type="text/html"; boundary=Apple-Webmail-86--80faaf0a-f27c-4f44-bdd4-719252c78072 --Apple-Webmail-86--80faaf0a-f27c-4f44-bdd4-719252c78072 Content-Transfer-Encoding: quoted-printable Content-Type: text/html; charset=utf-8;
Sure, I will fix my patch and will try to build the package with= suggested input (probably next week).

On Jan 26, 2023, at 1:51 AM, Ludovic Court=C3=A8s <ludo= @gnu.org> wrote:


= Hi,

Adam Kandur <manualbot@icloud.com> = skribis:

* gnu/packages/= game-development.scm (python-tcod): New variable.
I suggest the attached changes.

H= owever, one comment:

+ ;; tests fail for a strange reason
+ ;; "ERROR= docs/conf.py - FileNotFoundError",
+ ;; but this file = is in the checkout
+ (arguments
+ '= (#:tests? #f))
+ (native-inputs
+ (= list sdl2
+ python-pcpp
+ = python-pycparser
+ python-requests
=
+ python-pytest-runner
+ python= -pytest-benchmark
+ python-pytest-cov))
+ (propagated-inputs
+ (list python-numpy
+ python-typing-extensions
+ = python-cffi))
+ (synopsis
= + "This library is a Python cffi port of libtcod")

That =E2=80=98FileNotFoundError=E2=80=99, could i= t be because libtcod itself is missing?
I would expect libto= cd to be in =E2=80=98inputs=E2=80=99 since this package provides
=
bindings to libtcod, no?

+ (description
+ "A high-performance P= ython port of libtcod.
+Includes the libtcodpy module for ba= ckwards compatibility with older projects.")
Please improve the synopsis and description as per:
=


Could you send an updated patch?

<= div>Thanks,
Ludo=E2=80=99.
diff --g= it a/gnu/packages/game-development.scm b/gnu/packages/game-development.scm=
index 304df3bd75..dd08241080 100644
--- a/gnu= /packages/game-development.scm
+++ b/gnu/packages/game-devel= opment.scm
@@ -2584,11 +2584,12 @@ (define-public python-tco= d
(package
(name "python-tcod")
(version "13.9.1")
(source
(orig= in
(method git-fetch)
(uri (git-reference
+ (url home-page)
(co= mmit commit)
(recursive? #true)))
(file-name= (git-file-name name version))
@@ -2613,7 +2614,6 @@ (define= -public python-tcod
(list python-numpy
pytho= n-typing-extensions
python-cffi))
(= synopsis
"This library is a Python cffi port of libtcod")
(description
--Apple-Webmail-86--80faaf0a-f27c-4f44-bdd4-719252c78072-- --Apple-Webmail-42--80faaf0a-f27c-4f44-bdd4-719252c78072-- From debbugs-submit-bounces@debbugs.gnu.org Wed Mar 01 04:18:04 2023 Received: (at control) by debbugs.gnu.org; 1 Mar 2023 09:18:04 +0000 Received: from localhost ([127.0.0.1]:52667 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pXIb6-0004M3-Er for submit@debbugs.gnu.org; Wed, 01 Mar 2023 04:18:04 -0500 Received: from mira.cbaines.net ([212.71.252.8]:42296) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pXIb3-0004Ld-E0 for control@debbugs.gnu.org; Wed, 01 Mar 2023 04:18:03 -0500 Received: from localhost (unknown [IPv6:2a02:8010:68c1:0:54d1:d5d4:280e:f699]) by mira.cbaines.net (Postfix) with ESMTPSA id 5A5BE16C3D for ; Wed, 1 Mar 2023 09:18:00 +0000 (GMT) Received: from localhost (localhost [local]) by localhost (OpenSMTPD) with ESMTPA id c6bd7a32 for ; Wed, 1 Mar 2023 09:17:59 +0000 (UTC) From: Christopher Baines To: control@debbugs.gnu.org Subject: tag 60193 moreinfo Date: Wed, 01 Mar 2023 09:17:59 +0000 Message-ID: <877cw0ygmw.fsf@cbaines.net> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) tags 60193 + moreinfo quit From debbugs-submit-bounces@debbugs.gnu.org Wed Mar 22 07:00:57 2023 Received: (at 60192) by debbugs.gnu.org; 22 Mar 2023 11:00:57 +0000 Received: from localhost ([127.0.0.1]:33637 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pewDB-0003WZ-Bn for submit@debbugs.gnu.org; Wed, 22 Mar 2023 07:00:57 -0400 Received: from mail-yw1-f196.google.com ([209.85.128.196]:43718) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pewD9-0003WM-5w for 60192@debbugs.gnu.org; Wed, 22 Mar 2023 07:00:55 -0400 Received: by mail-yw1-f196.google.com with SMTP id 00721157ae682-53d277c1834so331126337b3.10 for <60192@debbugs.gnu.org>; Wed, 22 Mar 2023 04:00:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1679482849; h=to:subject:message-id:date:from:mime-version:from:to:cc:subject :date:message-id:reply-to; bh=xGbRnx76TO4pAsIWmeRR15GVtpBajsu0Uk7woVIL+Yc=; b=TbkT9hV9d7xuDNa1G+F4eGW+pgFkQFFttDxOmphiO0hoCA74/ihQ3kKlP0WPJNKzjO vkOV3JNyidjHdOX7twg5ulPeyJJNXbGhVgYkgm7fYQeHhhaTOywPi0UTn7kvpgihHm6B uISqAp58FRkYmkAmojWlA4PIgO51byS/3m0lA47ussp6rqFPbR5CXbn9fJWdl765hRQJ BMSGiK3XwCadYFz0biUb8AcGJrD3Dx79MYhJAi1K5ZK93r0og1PxDA+bEdurJYYdiFM+ 9GgJhmlOobh/mSJQrVT9G0QAxdYkEjKjnsKghgMFxKXxkbRPpjvYmsXdyZjG3jQGzVfy caCQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679482849; h=to:subject:message-id:date:from:mime-version:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=xGbRnx76TO4pAsIWmeRR15GVtpBajsu0Uk7woVIL+Yc=; b=aVuxZKoqGUbfbJIwnbzNZzPRW0RD/qLn125RZhcCp28AdElHRHCr7Xjpun+JWusci0 ILfhNXmbiN1pJMwgergVGgO7Y6+kxPMW0ehyv2vLL6KbjoTo1PYlQHL3qM9uDK7Ypw1O fck8hPGxb2TLSpCDqjIcQTm+G7VTBNKJM5hnoV13n8FMpWGQ272UQkpnE3RmGZbE6V0g dSMRUc3rXdTxKLljOn5y0udPE223hvRs3QruVc9bbOSduhBLZlX7AydgslPBUTUypR05 F6nD4yl2zoh8ur3+yWZUx797wRqmayR5L0AA2WocWzJ7Z2VMTNuRq4A8YWfezvOEd7LR 9m5g== X-Gm-Message-State: AAQBX9eenUbmSn47B7AvdOGrwXl3m3BClMCXrE+zoBm/VYRLRzsj6SqD suFvBfXso7uXmilFnYhXSxmNv/t1lqXERk0FRrBi2YblW0oln2cr X-Google-Smtp-Source: AKy350aM+hwBVcw5TdXzFMxxG1/VTTnfWVck4ZpYCEhphWZvrvdO3RwBt0h6sQGruTfSlQHA6JxOtb0b0cEOl3I+Sbw= X-Received: by 2002:a81:4305:0:b0:52e:e095:d840 with SMTP id q5-20020a814305000000b0052ee095d840mr2857632ywa.0.1679482849239; Wed, 22 Mar 2023 04:00:49 -0700 (PDT) MIME-Version: 1.0 From: Adam Kandur Date: Wed, 22 Mar 2023 14:00:38 +0300 Message-ID: Subject: Update on issue To: 60192@debbugs.gnu.org Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 60192 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi guix! First of all, sorry for the late reply. So, there are 2 problems with this package - turned off tests and wrong synopsis and description. So I tried to fix it and here is my suggestions: 1) I have added libtcod to propagated-inputs. Which seems reasonable because this package provides bindings to it. But unfortunately this didn't solve the problem with tests. Without them the package works fine and can be used in projects. 2) I suggest these synopsis and description (synopsis "Python port of libtcod") (description "Python package which provides bindings to libtcod. This allows Python users to use libtcod in their Python projects. libtcod itself is a collection of tools and algorithms for developing traditional roguelikes. Such as field-of-view, pathfinding, and a tile-based terminal emulator.") So if these changes are acceptable, can I resend an updated version?