GNU bug report logs - #60191
[PATCH] Fix `rcirc-buffer-process' not working on channel buffers

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Stefan Kangas <stefankangas <at> gmail.com>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#60191: closed ([PATCH] Fix `rcirc-buffer-process' not working
 on channel buffers)
Date: Wed, 12 Feb 2025 03:11:01 +0000

[Message part 1 (text/plain, inline)]

Your message dated Tue, 11 Feb 2025 19:09:52 -0800
with message-id <CADwFkm=9X2JNovHteHVyv8rEMAFq+gyQMt=1gpyuggvmux2f+w <at> mail.gmail.com>
and subject line Re: bug#60191: [PATCH] Fix `rcirc-buffer-process' not working on channel buffers
has caused the debbugs.gnu.org bug report #60191,
regarding [PATCH] Fix `rcirc-buffer-process' not working on channel buffers
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
60191: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=60191
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Thuna <thuna.cing <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] Fix `rcirc-buffer-process' not working on channel buffers
Date: Mon, 19 Dec 2022 09:47:57 +0100

[Message part 3 (text/plain, inline)]

Currently `rcirc-buffer-process' with no BUFFER argument defaults to
current buffer's `rcirc-server-buffer' instead of the current buffer
itself which leads to `rcirc-buffer-process' not working with channel
buffers.

This patch should hopefully fix that.

[0001-Fix-rcirc-buffer-process-not-working-on-channel-buff.patch (text/x-patch, attachment)]

[Message part 5 (message/rfc822, inline)]

From: Stefan Kangas <stefankangas <at> gmail.com>
To: Philip Kaludercic <philipk <at> posteo.net>
Cc: 60191-done <at> debbugs.gnu.org, Thuna <thuna.cing <at> gmail.com>
Subject: Re: bug#60191: [PATCH] Fix `rcirc-buffer-process' not working on
 channel buffers
Date: Tue, 11 Feb 2025 19:09:52 -0800

Version: 31.1

Philip Kaludercic <philipk <at> posteo.net> writes:

> Thuna <thuna.cing <at> gmail.com> writes:
>
>>> I do not understand what you mean by "not working" here, the code
>>> appears to do the same thing pre- and post-patch, in the process and the
>>> channel buffers.
>>
>> The problem is that when `rcirc-buffer-process' is explicitly called
>> with a channel buffer it returns nil, as the local variable
>> `rcirc-process' is set only in server buffers and the function checks
>> the server buffer only if the BUFFER argument is nil.
>>
>> This leads to a situation where `(rcirc-buffer-process)' and
>> `(rcirc-buffer-process (current-buffer))' do not behave in the same way
>> when called from channel buffers.
>
> OK, I get what you mean and the patch should be applied.  But IIUC you
> haven't signed the FSF CA, right?  If that is so, I am afraid I am not
> allowed to apply /your/ change myself...

The copyright assignment is now done, so I went ahead and installed this
patch as commit fb90e21af1b.  I'm therefore closing this bug report.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.