From unknown Fri Jun 20 19:56:06 2025 X-Loop: help-debbugs@gnu.org Subject: bug#60191: [PATCH] Fix `rcirc-buffer-process' not working on channel buffers Resent-From: Thuna Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 19 Dec 2022 08:49:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 60191 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: 60191@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.16714396909108 (code B ref -1); Mon, 19 Dec 2022 08:49:02 +0000 Received: (at submit) by debbugs.gnu.org; 19 Dec 2022 08:48:10 +0000 Received: from localhost ([127.0.0.1]:38077 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p7Bog-0002Mp-BA for submit@debbugs.gnu.org; Mon, 19 Dec 2022 03:48:10 -0500 Received: from lists.gnu.org ([209.51.188.17]:47974) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p7Bof-0002Me-Cq for submit@debbugs.gnu.org; Mon, 19 Dec 2022 03:48:09 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p7Bob-0006CV-OB for bug-gnu-emacs@gnu.org; Mon, 19 Dec 2022 03:48:08 -0500 Received: from mail-ej1-x62e.google.com ([2a00:1450:4864:20::62e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1p7BoX-0008Iq-NM for bug-gnu-emacs@gnu.org; Mon, 19 Dec 2022 03:48:04 -0500 Received: by mail-ej1-x62e.google.com with SMTP id x22so19714941ejs.11 for ; Mon, 19 Dec 2022 00:48:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:message-id:date:subject:to:from:from:to:cc:subject :date:message-id:reply-to; bh=QfVv0fXnVrKtAj/0TeoFu19C12NweMqj2jxXDOrMInY=; b=b3T5omFfOaW+tl53TZy6ViLBSTt3PwfYT4ii7SYQCHU7z9zmyo1A6y9XCSPwxS/6Rn j+hFglsVzX98nU8vLr0h9ws7qPgYC7+QH2sIr7Qv7S7V1SESKzoHCZVmvLBnnlojDccc nSSR3veLSnpXRd8h35+bmwcEv/Q4O9j0xHplNh301+Bl1/4RSnSVsnhlqBixZWXeWBVW hLT1H+I+O8pXjDXKxBVGl3h/cj+3q97zxLKsMV5u6xjcUMOwAsKquQA5IHnsHAuDSzYm Bd72RJubYuGEE77DJusVjArGQg3KR22JhJidO2rqWJY2loFT34c08njcJu8I+9ornuNV B7iw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:message-id:date:subject:to:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=QfVv0fXnVrKtAj/0TeoFu19C12NweMqj2jxXDOrMInY=; b=T5a2/R53l/i7rzojB6CXueIkfpIsmuUa1eENeGAEBNsuuU2DQzvG3F7T1GHFvjocbQ kazu7ck+Uyl/yUGxk8zqP+zio2T3mVKmxkhthjSUpJmBcsqznUszB9UoHYyWdyhpdfNY rHgFY21ETF+v30JWWRkeHtsRL4oF1UI+mGceQwK1zNGwkhLltG8+F3ildizMdvf4xpaS XVvAitp1sXnXu64Mb46gG97uPaYMpnThZ0zwGf+zyi/YW77YziA8jY85Vow0yEPNsbRC GwXdE4BAJiIYy7jHO/P+P03UIJMXSTrR46G9LTxMZAZRkm+vYr6xNFsUpmpZsUlRWjjM Xzcw== X-Gm-Message-State: ANoB5plh4tezFY72RP8UlyWSquMZZJb/vBs8q4FDS19CFyNeFUMhMcJT 8TstTKqH6V6BMLeVamGqRcgXCO6zYgA= X-Google-Smtp-Source: AA0mqf7wleXgujqFfkd1lgUa6TOL0DjjUijqE2RChOw0pd8xkWWgDEkiDcMl7DyVXEX+jHKDZxdFvw== X-Received: by 2002:a17:906:4dc9:b0:7c1:6fc:6048 with SMTP id f9-20020a1709064dc900b007c106fc6048mr35592992ejw.24.1671439679559; Mon, 19 Dec 2022 00:47:59 -0800 (PST) Received: from thuna (eduroam-085.unibocconi.it. [90.147.70.85]) by smtp.gmail.com with ESMTPSA id s9-20020a170906bc4900b007c0e6d6bd10sm4115219ejv.132.2022.12.19.00.47.58 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 19 Dec 2022 00:47:59 -0800 (PST) From: Thuna Date: Mon, 19 Dec 2022 09:47:57 +0100 Message-ID: <877cynrd8i.fsf@gmail.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Received-SPF: pass client-ip=2a00:1450:4864:20::62e; envelope-from=thuna.cing@gmail.com; helo=mail-ej1-x62e.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) --=-=-= Content-Type: text/plain Currently `rcirc-buffer-process' with no BUFFER argument defaults to current buffer's `rcirc-server-buffer' instead of the current buffer itself which leads to `rcirc-buffer-process' not working with channel buffers. This patch should hopefully fix that. --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-Fix-rcirc-buffer-process-not-working-on-channel-buff.patch Content-Description: The patch >From d17e7cbb34cf83098561c57b383f90d6a7bde50e Mon Sep 17 00:00:00 2001 From: Thuna Date: Mon, 19 Dec 2022 09:33:29 +0100 Subject: [PATCH] Fix `rcirc-buffer-process' not working on channel buffers * lisp/net/rcirc.el (rcirc-buffer-process): Look at BUFFER's `rcirc-server-buffer's `rcirc-process' instead. Signal an error if it has none. --- lisp/net/rcirc.el | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/lisp/net/rcirc.el b/lisp/net/rcirc.el index 96109dcd5c9..7afb625407e 100644 --- a/lisp/net/rcirc.el +++ b/lisp/net/rcirc.el @@ -1179,11 +1179,11 @@ rcirc-send-ctcp (defun rcirc-buffer-process (&optional buffer) "Return the process associated with channel BUFFER. With no argument or nil as argument, use the current buffer." - (let ((buffer (or buffer (and (buffer-live-p rcirc-server-buffer) - rcirc-server-buffer)))) - (if buffer - (buffer-local-value 'rcirc-process buffer) - rcirc-process))) + (let ((buffer (or buffer (current-buffer)))) + (buffer-local-value + 'rcirc-process + (or (buffer-local-value 'rcirc-server-buffer buffer) + (error "Not an rcirc buffer: %S" buffer))))) (defun rcirc-server-name (process) "Return PROCESS server name, given by the 001 response." -- 2.37.4 --=-=-=-- From unknown Fri Jun 20 19:56:06 2025 X-Loop: help-debbugs@gnu.org Subject: bug#60191: [PATCH] Fix `rcirc-buffer-process' not working on channel buffers Resent-From: Philip Kaludercic Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 01 May 2023 12:05:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60191 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Thuna Cc: 60191@debbugs.gnu.org Received: via spool by 60191-submit@debbugs.gnu.org id=B60191.168294268616858 (code B ref 60191); Mon, 01 May 2023 12:05:02 +0000 Received: (at 60191) by debbugs.gnu.org; 1 May 2023 12:04:46 +0000 Received: from localhost ([127.0.0.1]:39069 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ptSGr-0004No-Kc for submit@debbugs.gnu.org; Mon, 01 May 2023 08:04:45 -0400 Received: from mout02.posteo.de ([185.67.36.66]:58085) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ptSGo-0004NW-QL for 60191@debbugs.gnu.org; Mon, 01 May 2023 08:04:43 -0400 Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id 42C2C2401FA for <60191@debbugs.gnu.org>; Mon, 1 May 2023 14:04:37 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1682942677; bh=84IEz80YdE//LADqaEdbXgjoHyG0PY8ef7q58ewlPmw=; h=From:To:Cc:Subject:Autocrypt:Date:From; b=YbRM1y1ZW4ZmAk8fzf5Y8a8kjUwrZ7aWJS177GXsLyUDCqw9isqev6H5hpDeJCohb p70JKP2fTt4RPTQj+qftBSr7O0VLQ3u7rtdzT7Td2DKwyKKLfJ4cv5Xbde9NR6UE3n IyC7f3cOpPWqdeqp/KE122wC/FrivddMU5wdSnb8O5bLyFNo8pfS5oL1JXNwlzmNhH cKNzbnSR3MYHPWdhCqZvKwUXAygNMAgUMWnobX2DXGADJs2NbBrTuNOLqM4wdo1tjb BZ9QXFn/xRA0b0qbGj6h5C7p+OAccxlMKwFR9CR79VggPlDACBbpimHjh0y17MMskN 4RjRUTpGPZRtA== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4Q922D63NYz6twp; Mon, 1 May 2023 14:04:36 +0200 (CEST) From: Philip Kaludercic In-Reply-To: <877cynrd8i.fsf@gmail.com> (Thuna's message of "Mon, 19 Dec 2022 09:47:57 +0100") References: <877cynrd8i.fsf@gmail.com> Autocrypt: addr=philipk@posteo.net; keydata= mDMEZBBQQhYJKwYBBAHaRw8BAQdAHJuofBrfqFh12uQu0Yi7mrl525F28eTmwUDflFNmdui0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiWBBMWCAA+FiEEDg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwMFCQHhM4AFCwkI BwIGFQoJCAsCBBYCAwECHgECF4AACgkQ8xYDWXahwulikAEA77hloUiSrXgFkUVJhlKBpLCHUjA0 mWZ9j9w5d08+jVwBAK6c4iGP7j+/PhbkxaEKa4V3MzIl7zJkcNNjHCXmvFcEuDgEZBBQQhIKKwYB BAGXVQEFAQEHQI5NLiLRjZy3OfSt1dhCmFyn+fN/QKELUYQetiaoe+MMAwEIB4h+BBgWCAAmFiEE Dg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwwFCQHhM4AACgkQ8xYDWXahwukm+wEA8cml4JpK NeAu65rg+auKrPOP6TP/4YWRCTIvuYDm0joBALw98AMz7/qMHvSCeU/hw9PL6u6R2EScxtpKnWof z4oM Date: Mon, 01 May 2023 12:05:09 +0000 Message-ID: <875y9cqmtm.fsf@posteo.net> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Thuna writes: > Currently `rcirc-buffer-process' with no BUFFER argument defaults to > current buffer's `rcirc-server-buffer' instead of the current buffer > itself which leads to `rcirc-buffer-process' not working with channel > buffers. I do not understand what you mean by "not working" here, the code appears to do the same thing pre- and post-patch, in the process and the channel buffers. > This patch should hopefully fix that. > >>>From d17e7cbb34cf83098561c57b383f90d6a7bde50e Mon Sep 17 00:00:00 2001 > From: Thuna > Date: Mon, 19 Dec 2022 09:33:29 +0100 > Subject: [PATCH] Fix `rcirc-buffer-process' not working on channel buffers > > * lisp/net/rcirc.el (rcirc-buffer-process): Look at BUFFER's > `rcirc-server-buffer's `rcirc-process' instead. Signal an error if it > has none. > --- > lisp/net/rcirc.el | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/lisp/net/rcirc.el b/lisp/net/rcirc.el > index 96109dcd5c9..7afb625407e 100644 > --- a/lisp/net/rcirc.el > +++ b/lisp/net/rcirc.el > @@ -1179,11 +1179,11 @@ rcirc-send-ctcp > (defun rcirc-buffer-process (&optional buffer) > "Return the process associated with channel BUFFER. > With no argument or nil as argument, use the current buffer." > - (let ((buffer (or buffer (and (buffer-live-p rcirc-server-buffer) > - rcirc-server-buffer)))) > - (if buffer > - (buffer-local-value 'rcirc-process buffer) > - rcirc-process))) > + (let ((buffer (or buffer (current-buffer)))) > + (buffer-local-value > + 'rcirc-process > + (or (buffer-local-value 'rcirc-server-buffer buffer) > + (error "Not an rcirc buffer: %S" buffer))))) > > (defun rcirc-server-name (process) > "Return PROCESS server name, given by the 001 response." From unknown Fri Jun 20 19:56:06 2025 X-Loop: help-debbugs@gnu.org Subject: bug#60191: [PATCH] Fix `rcirc-buffer-process' not working on channel buffers Resent-From: Thuna Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 01 May 2023 20:06:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60191 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Philip Kaludercic Cc: 60191@debbugs.gnu.org Received: via spool by 60191-submit@debbugs.gnu.org id=B60191.168297154819143 (code B ref 60191); Mon, 01 May 2023 20:06:02 +0000 Received: (at 60191) by debbugs.gnu.org; 1 May 2023 20:05:48 +0000 Received: from localhost ([127.0.0.1]:41131 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ptZmO-0004yg-Ge for submit@debbugs.gnu.org; Mon, 01 May 2023 16:05:48 -0400 Received: from mail-ej1-f47.google.com ([209.85.218.47]:55380) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ptZmK-0004yP-G8 for 60191@debbugs.gnu.org; Mon, 01 May 2023 16:05:47 -0400 Received: by mail-ej1-f47.google.com with SMTP id a640c23a62f3a-95316faa3a8so590525266b.2 for <60191@debbugs.gnu.org>; Mon, 01 May 2023 13:05:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1682971537; x=1685563537; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:from:to:cc:subject:date:message-id:reply-to; bh=O87s3b5ubY9KvSE+YKYwjYf/8KesUqmCe7CcbEcAUcc=; b=RAxHzpQPIFVrXm0TAdVPW3sFPN/MHxhp9zVDBHxKbHIrZNh//Ynu+ecaEgwRcpSgFL 9wv62EGdtuU3xKjd3e8QBPT4jWIn/oQEiVqq9T3LDQPc30EYCeKAgKNzMiSXqdHnGHt2 DDUQCIOsQTGMHgma9InvgjJrvR2T0pRM4HSzLkyMu6yJ06nyRx+7Y6eYUK0XZYzhEQF8 AMBA9P9k/PddxJ8DZfVEH/8f1uRQqMvdpnbfWN1VGhzYpZ1IbLhTHW9PYiOMTCZUEPYw 2do8g9rHYCroLaIc8Fkf0wasb63v0WBPTn9SC9g2USQdO7WQ9RuDfFDEAeVNyq6y7ALZ 7aRg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682971537; x=1685563537; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=O87s3b5ubY9KvSE+YKYwjYf/8KesUqmCe7CcbEcAUcc=; b=a4hubjJUWaoBiZ2b2EVpRPY3vsafHg/l0pSLW8T7XqHe4XkckWQ5zR4dW7fEFXVTJO yBgfbEnMqcz/C+KI2JsOxXjxIcVYgnLYnoMI03XL3KsxJpwJWQBstp8ER+eAIP0W1itO pMhiXVSQSMfENreQkW0r8Ca3MC5HMp3VFmGPzB4WE49YiWg3RjVfyU5KcQhNlkRcyTS2 Gh5VqlcPcaMC8PZCKFVErQHUtR7LzVmx457o4MzVFagPsFuaP8yXHXicDeYwaO5TLXA8 jACJagvycAjN3eFEnx2Oqf0xEj2BFhKlwISXvgiRPtMZFZZ5YmX1jOzA1hmv5a9MrKue Rb/w== X-Gm-Message-State: AC+VfDytUBk/uaiwheifmaZZkA//WaWCwenns2gCIInnVTGfLfAvbTUp 15+WwF+pOVnysgnAJJ7yh/IwxknL2XY= X-Google-Smtp-Source: ACHHUZ6OmUY78A7rY5knyvXz7KQmHMbumY/3EWS/+dswZ/zZ5l2r5YgXpvoEHp15kG2agW54DbSyEQ== X-Received: by 2002:a17:906:fe45:b0:94a:4b7a:9886 with SMTP id wz5-20020a170906fe4500b0094a4b7a9886mr13819325ejb.12.1682971537021; Mon, 01 May 2023 13:05:37 -0700 (PDT) Received: from thuna (eduroam-063.unibocconi.it. [90.147.70.63]) by smtp.gmail.com with ESMTPSA id dn1-20020a17090794c100b00953381ea1b7sm15118500ejc.90.2023.05.01.13.05.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 May 2023 13:05:36 -0700 (PDT) From: Thuna In-Reply-To: <875y9cqmtm.fsf@posteo.net> References: <877cynrd8i.fsf@gmail.com> <875y9cqmtm.fsf@posteo.net> Date: Mon, 01 May 2023 22:05:35 +0200 Message-ID: <87lei7es1c.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > I do not understand what you mean by "not working" here, the code > appears to do the same thing pre- and post-patch, in the process and the > channel buffers. The problem is that when `rcirc-buffer-process' is explicitly called with a channel buffer it returns nil, as the local variable `rcirc-process' is set only in server buffers and the function checks the server buffer only if the BUFFER argument is nil. This leads to a situation where `(rcirc-buffer-process)' and `(rcirc-buffer-process (current-buffer))' do not behave in the same way when called from channel buffers. From unknown Fri Jun 20 19:56:06 2025 X-Loop: help-debbugs@gnu.org Subject: bug#60191: [PATCH] Fix `rcirc-buffer-process' not working on channel buffers Resent-From: Philip Kaludercic Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 01 May 2023 20:09:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60191 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Thuna Cc: 60191@debbugs.gnu.org Received: via spool by 60191-submit@debbugs.gnu.org id=B60191.168297172619411 (code B ref 60191); Mon, 01 May 2023 20:09:01 +0000 Received: (at 60191) by debbugs.gnu.org; 1 May 2023 20:08:46 +0000 Received: from localhost ([127.0.0.1]:41135 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ptZpG-000531-0m for submit@debbugs.gnu.org; Mon, 01 May 2023 16:08:46 -0400 Received: from mout01.posteo.de ([185.67.36.65]:33691) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ptZpD-00052n-Qi for 60191@debbugs.gnu.org; Mon, 01 May 2023 16:08:45 -0400 Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 4F83F24017B for <60191@debbugs.gnu.org>; Mon, 1 May 2023 22:08:37 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1682971717; bh=Pq6E4zofao6f0oCB6GWP+j6tn2cI4W9k7DBGh8s9rYg=; h=From:To:Cc:Subject:Autocrypt:Date:From; b=fY4TAw1z2JDO2sDHtHyLh5e2G156dM2x6WBukVTEumdSpM7q8Imm2xL7fEn+pCMK2 fh21orcuLVaH6S7dOO2OGP6UoG7IrnxpzhJadUYw2mfNwX6R/MwFp4UqiaW4marNqH IaT+Q4MqyGicny2/wKeTUn+7VN9Y0+yF/ds9ZvwW2Rxrq4Y++O6ktCxDpPoUm1BZ6e RgyXqezlCtPFL6gCE5ZF/QostsDnj1sXtBVtqbamWqXccLlboXHpI6mKkji+ch9SEF lHKUrDUqW7yHCNCo25GkIu4V89285J9bfDi+cUgMHh3NnTsS8Qq3p5ZBQYS++WmWJb sRYR7pzPcNvFA== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4Q9Dmh6sRqz9rxP; Mon, 1 May 2023 22:08:36 +0200 (CEST) From: Philip Kaludercic In-Reply-To: <87lei7es1c.fsf@gmail.com> (Thuna's message of "Mon, 01 May 2023 22:05:35 +0200") References: <877cynrd8i.fsf@gmail.com> <875y9cqmtm.fsf@posteo.net> <87lei7es1c.fsf@gmail.com> Autocrypt: addr=philipk@posteo.net; keydata= mDMEZBBQQhYJKwYBBAHaRw8BAQdAHJuofBrfqFh12uQu0Yi7mrl525F28eTmwUDflFNmdui0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiWBBMWCAA+FiEEDg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwMFCQHhM4AFCwkI BwIGFQoJCAsCBBYCAwECHgECF4AACgkQ8xYDWXahwulikAEA77hloUiSrXgFkUVJhlKBpLCHUjA0 mWZ9j9w5d08+jVwBAK6c4iGP7j+/PhbkxaEKa4V3MzIl7zJkcNNjHCXmvFcEuDgEZBBQQhIKKwYB BAGXVQEFAQEHQI5NLiLRjZy3OfSt1dhCmFyn+fN/QKELUYQetiaoe+MMAwEIB4h+BBgWCAAmFiEE Dg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwwFCQHhM4AACgkQ8xYDWXahwukm+wEA8cml4JpK NeAu65rg+auKrPOP6TP/4YWRCTIvuYDm0joBALw98AMz7/qMHvSCeU/hw9PL6u6R2EScxtpKnWof z4oM Date: Mon, 01 May 2023 20:09:09 +0000 Message-ID: <875y9bizkq.fsf@posteo.net> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Thuna writes: >> I do not understand what you mean by "not working" here, the code >> appears to do the same thing pre- and post-patch, in the process and the >> channel buffers. > > The problem is that when `rcirc-buffer-process' is explicitly called > with a channel buffer it returns nil, as the local variable > `rcirc-process' is set only in server buffers and the function checks > the server buffer only if the BUFFER argument is nil. > > This leads to a situation where `(rcirc-buffer-process)' and > `(rcirc-buffer-process (current-buffer))' do not behave in the same way > when called from channel buffers. OK, I get what you mean and the patch should be applied. But IIUC you haven't signed the FSF CA, right? If that is so, I am afraid I am not allowed to apply /your/ change myself... From unknown Fri Jun 20 19:56:06 2025 X-Loop: help-debbugs@gnu.org Subject: bug#60191: [PATCH] Fix `rcirc-buffer-process' not working on channel buffers Resent-From: Thuna Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 01 May 2023 21:35:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60191 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Philip Kaludercic Cc: 60191@debbugs.gnu.org Received: via spool by 60191-submit@debbugs.gnu.org id=B60191.168297685428261 (code B ref 60191); Mon, 01 May 2023 21:35:02 +0000 Received: (at 60191) by debbugs.gnu.org; 1 May 2023 21:34:14 +0000 Received: from localhost ([127.0.0.1]:41179 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ptb9y-0007Ll-Is for submit@debbugs.gnu.org; Mon, 01 May 2023 17:34:14 -0400 Received: from mail-ej1-f43.google.com ([209.85.218.43]:51394) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ptb9t-0007LU-2F for 60191@debbugs.gnu.org; Mon, 01 May 2023 17:34:13 -0400 Received: by mail-ej1-f43.google.com with SMTP id a640c23a62f3a-94f7a7a3351so599203366b.2 for <60191@debbugs.gnu.org>; Mon, 01 May 2023 14:34:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1682976843; x=1685568843; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:from:to:cc:subject:date:message-id:reply-to; bh=gqRblCERvsxWR8sigj3S1sUdy9brh8LEfFUNtsKRiZI=; b=rNCW4ls9JMfPNYBLpqE0/1LWiZPxB18ZYs7mi0dR7f/u3Zi1SZxhhXRQoBArhUCr/a a7K5cwlzwXzKLQt5iM1rJYdmXfq+Xofk/sVW3qUZlhCXsj8KGwzCGj5JC0eEEuCrmnmI A/oMXShcHLisu+THBUGVof+gfgu6etpSJdoSUbtncGWzKNrAfLA7bidQfqOE8JSnMJ0D skIcFQOrxQ0PObJrVajcuD8dMEw7kDapHTKHrOgXLmoutTqDA2C59btAQw5ok8y/aWK/ /3mzGXemAaUXc9im/FZXkMSBu8i+dRSIxupbfZtmUJ9UYE5TqsCgCEvGKH2oDClQ1fUa VV8A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682976843; x=1685568843; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=gqRblCERvsxWR8sigj3S1sUdy9brh8LEfFUNtsKRiZI=; b=UKf+30I4bKLDb449theaLD4eatf3G7hwDhps4vlVWNUFS+9shw9duj+k3mexh9KD6T BDp5o2itX3e5v9znZ/xDsXBW7O69dcBlKB9P8EsRigzIANRYntmQjhtKXJxSwbj4DDdA kTtdJZ/KveMnbSxKs6QtaGnIULZj2kBh87big4Vfdf7kN6ljafNM5pCHopR0hxPHtidY uoUDnZQX7frWrKCzpfoOr7AY2SzorcaqPCL01796fYPfoAdXymCQrv8VfhuHWdLUvpTv sq3vN+M3BaerkI07s+Npe85aA7eBwUm1jz1PAHkuARFDrF3oJarg6whxI17hpZWGKm+y 8nlQ== X-Gm-Message-State: AC+VfDy7fHlKGjknZhZukPjO6FBPVow653nGfetc36SBYNb2wpa5VN1n enPc4LQpLtcR1mg8fr2FTZuhmW3bAWY= X-Google-Smtp-Source: ACHHUZ6t+0xVH8PX8VQVc6h8P6iqKspzXfpSq2a2u8LzIDro5gfHXiCgu9+oz1jmyk3zlkWqb3blSQ== X-Received: by 2002:a17:907:948f:b0:94e:5c28:1c19 with SMTP id dm15-20020a170907948f00b0094e5c281c19mr14445327ejc.5.1682976842712; Mon, 01 May 2023 14:34:02 -0700 (PDT) Received: from thuna (eduroam-063.unibocconi.it. [90.147.70.63]) by smtp.gmail.com with ESMTPSA id d23-20020a170906345700b0094ee99eeb01sm15293710ejb.150.2023.05.01.14.34.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 May 2023 14:34:02 -0700 (PDT) From: Thuna In-Reply-To: <875y9bizkq.fsf@posteo.net> References: <877cynrd8i.fsf@gmail.com> <875y9cqmtm.fsf@posteo.net> <87lei7es1c.fsf@gmail.com> <875y9bizkq.fsf@posteo.net> Date: Mon, 01 May 2023 23:34:01 +0200 Message-ID: <87ednzenxy.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > OK, I get what you mean and the patch should be applied. But IIUC you > haven't signed the FSF CA, right? If that is so, I am afraid I am not > allowed to apply /your/ change myself... It will have to be on hold until the CA can be finalized, I'm afraid. My other patches are in a similar situation. I have applied for the CA quite a long time ago but unfortunately, my school is not being very receptive when it comes to the copyright disclaimer. I have mostly entrusted the matter with Craig Topham at , so you will have to contact them for any updates. From unknown Fri Jun 20 19:56:06 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Thuna Subject: bug#60191: closed (Re: bug#60191: [PATCH] Fix `rcirc-buffer-process' not working on channel buffers) Message-ID: References: <877cynrd8i.fsf@gmail.com> X-Gnu-PR-Message: they-closed 60191 X-Gnu-PR-Package: emacs X-Gnu-PR-Keywords: patch Reply-To: 60191@debbugs.gnu.org Date: Wed, 12 Feb 2025 03:11:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1739329862-2351-1" This is a multi-part message in MIME format... ------------=_1739329862-2351-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #60191: [PATCH] Fix `rcirc-buffer-process' not working on channel buffers which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 60191@debbugs.gnu.org. --=20 60191: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D60191 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1739329862-2351-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 60191-done) by debbugs.gnu.org; 12 Feb 2025 03:10:03 +0000 Received: from localhost ([127.0.0.1]:59899 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ti38U-0000UL-F3 for submit@debbugs.gnu.org; Tue, 11 Feb 2025 22:10:02 -0500 Received: from mail-ed1-x529.google.com ([2a00:1450:4864:20::529]:53742) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1ti38R-0000To-7H for 60191-done@debbugs.gnu.org; Tue, 11 Feb 2025 22:10:00 -0500 Received: by mail-ed1-x529.google.com with SMTP id 4fb4d7f45d1cf-5de5a8a96abso6623027a12.3 for <60191-done@debbugs.gnu.org>; Tue, 11 Feb 2025 19:09:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1739329793; x=1739934593; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:from:to:cc:subject:date:message-id:reply-to; bh=iQt7qefvig8XSNjsMQzoY9ssQssuxMY/cVB8I5bFLuU=; b=FFcFlqZWT62McT4juUpdbfthKAS3B2n0IEDh+evzVa/L/rGN9drn0AzDF/SI7qBozR SJ7mN9bv81X/FY1WjLkPitq3bY5r9b/yeUNuYyH/L01JNrt1gQZu85vgtgww7vrcnWPH ru0LyTDMh+iDGwpKxnPp5JTSXduCbcxxFRbWnly3BVyd5c7tgTK3lsvx6OnMw2Z8NCWV oHX/RLEdqTGRj/JtNqEAv2LDQ3jBF7H0R0S8Igh1b0L8fAYubL6/V1YLVzg0b9g91KRN DBzakMGmgCkW5Qy9ZcH+eXn34WF18T6H1Trc576/cUGQ4959Ft0z9LEyHtMTWABJGwXx PGtg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739329793; x=1739934593; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=iQt7qefvig8XSNjsMQzoY9ssQssuxMY/cVB8I5bFLuU=; b=lJbZcqYBBJ+IOfKIIa/C+jwzZGLZugf6fXr67yD9Cu3laVLB/A/vOTfSj9pOTKtEem G7UOg5aiLG8/V5F6LiXCyOeULIIDo7QQRAe0fCI13UyFwGRWUrATwiSBBronHgRknQtW PakYJgqZkFkAT0eg8zofZ/o/8MqlptaOOt6d0FUhoPoHSQ3/EmepQpCqBPyWpvOR2J9C J8QS+bAKMyFGvFFiyOCokwGuvabuLMcZnkEy3h/vla/L4MCfLyx96O+yUzxZa7TvdVb0 ZpmbZZcON9rYDVyRUSHX01kKNzfcI1L476aBC66lHoAt8kU186JBhzSsDa307NXAUuLA GmfA== X-Forwarded-Encrypted: i=1; AJvYcCV6uI5UZuqg3zoWaESgwQJp8qZve0nGOS8spUhXfPb4BG3zmdwtduRKyS5gQpqFKlrKQFH4zS+p3S74@debbugs.gnu.org X-Gm-Message-State: AOJu0YyGb4hYa8zqOL1MqBx+5gxpgEtnjxchuyQGs351MQT0nk0Gv2+h J2xufb/xJ9SFNjW130i98JYd9/3yV+LMsxy5Tzknx5ghBzTg5g3oRIY8M4oUbueG0p2yLvx/B7g za+BWtk1D4Xd9WfGNpoNp4vK5vLQ= X-Gm-Gg: ASbGncuu4NjxsHGx4L/X1HaBQkowlb0+2BKOqmXxRdA4cVg/5RiQstozmEEnhspE7PL HIOhilvdIZxVtCGzR0aulGieiA+8tOaGC4Kk0XCbbnTETjz7oqURb8T0g+SNXvx8L1cOXqx6p X-Google-Smtp-Source: AGHT+IGD2rRKFmuhEV3DCa/VQD7Z+wko/2O5G+F4uEKiVlde2DGRLPhUacRzlWU4HftTLzg8NqM1nf5BvtSgm8Sn+CI= X-Received: by 2002:a05:6402:3892:b0:5de:4a8b:4c9c with SMTP id 4fb4d7f45d1cf-5deade09820mr3014432a12.32.1739329792862; Tue, 11 Feb 2025 19:09:52 -0800 (PST) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Tue, 11 Feb 2025 19:09:52 -0800 From: Stefan Kangas In-Reply-To: <875y9bizkq.fsf@posteo.net> References: <877cynrd8i.fsf@gmail.com> <875y9cqmtm.fsf@posteo.net> <87lei7es1c.fsf@gmail.com> <875y9bizkq.fsf@posteo.net> MIME-Version: 1.0 Date: Tue, 11 Feb 2025 19:09:52 -0800 X-Gm-Features: AWEUYZkH20k_XPY1-5q5WUg9ArcIN1vizlE0iKgYq0tQEy6BwakPipruVYms5to Message-ID: Subject: Re: bug#60191: [PATCH] Fix `rcirc-buffer-process' not working on channel buffers To: Philip Kaludercic Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 60191-done Cc: 60191-done@debbugs.gnu.org, Thuna X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Version: 31.1 Philip Kaludercic writes: > Thuna writes: > >>> I do not understand what you mean by "not working" here, the code >>> appears to do the same thing pre- and post-patch, in the process and the >>> channel buffers. >> >> The problem is that when `rcirc-buffer-process' is explicitly called >> with a channel buffer it returns nil, as the local variable >> `rcirc-process' is set only in server buffers and the function checks >> the server buffer only if the BUFFER argument is nil. >> >> This leads to a situation where `(rcirc-buffer-process)' and >> `(rcirc-buffer-process (current-buffer))' do not behave in the same way >> when called from channel buffers. > > OK, I get what you mean and the patch should be applied. But IIUC you > haven't signed the FSF CA, right? If that is so, I am afraid I am not > allowed to apply /your/ change myself... The copyright assignment is now done, so I went ahead and installed this patch as commit fb90e21af1b. I'm therefore closing this bug report. ------------=_1739329862-2351-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 19 Dec 2022 08:48:10 +0000 Received: from localhost ([127.0.0.1]:38077 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p7Bog-0002Mp-BA for submit@debbugs.gnu.org; Mon, 19 Dec 2022 03:48:10 -0500 Received: from lists.gnu.org ([209.51.188.17]:47974) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p7Bof-0002Me-Cq for submit@debbugs.gnu.org; Mon, 19 Dec 2022 03:48:09 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p7Bob-0006CV-OB for bug-gnu-emacs@gnu.org; Mon, 19 Dec 2022 03:48:08 -0500 Received: from mail-ej1-x62e.google.com ([2a00:1450:4864:20::62e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1p7BoX-0008Iq-NM for bug-gnu-emacs@gnu.org; Mon, 19 Dec 2022 03:48:04 -0500 Received: by mail-ej1-x62e.google.com with SMTP id x22so19714941ejs.11 for ; Mon, 19 Dec 2022 00:48:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:message-id:date:subject:to:from:from:to:cc:subject :date:message-id:reply-to; bh=QfVv0fXnVrKtAj/0TeoFu19C12NweMqj2jxXDOrMInY=; b=b3T5omFfOaW+tl53TZy6ViLBSTt3PwfYT4ii7SYQCHU7z9zmyo1A6y9XCSPwxS/6Rn j+hFglsVzX98nU8vLr0h9ws7qPgYC7+QH2sIr7Qv7S7V1SESKzoHCZVmvLBnnlojDccc nSSR3veLSnpXRd8h35+bmwcEv/Q4O9j0xHplNh301+Bl1/4RSnSVsnhlqBixZWXeWBVW hLT1H+I+O8pXjDXKxBVGl3h/cj+3q97zxLKsMV5u6xjcUMOwAsKquQA5IHnsHAuDSzYm Bd72RJubYuGEE77DJusVjArGQg3KR22JhJidO2rqWJY2loFT34c08njcJu8I+9ornuNV B7iw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:message-id:date:subject:to:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=QfVv0fXnVrKtAj/0TeoFu19C12NweMqj2jxXDOrMInY=; b=T5a2/R53l/i7rzojB6CXueIkfpIsmuUa1eENeGAEBNsuuU2DQzvG3F7T1GHFvjocbQ kazu7ck+Uyl/yUGxk8zqP+zio2T3mVKmxkhthjSUpJmBcsqznUszB9UoHYyWdyhpdfNY rHgFY21ETF+v30JWWRkeHtsRL4oF1UI+mGceQwK1zNGwkhLltG8+F3ildizMdvf4xpaS XVvAitp1sXnXu64Mb46gG97uPaYMpnThZ0zwGf+zyi/YW77YziA8jY85Vow0yEPNsbRC GwXdE4BAJiIYy7jHO/P+P03UIJMXSTrR46G9LTxMZAZRkm+vYr6xNFsUpmpZsUlRWjjM Xzcw== X-Gm-Message-State: ANoB5plh4tezFY72RP8UlyWSquMZZJb/vBs8q4FDS19CFyNeFUMhMcJT 8TstTKqH6V6BMLeVamGqRcgXCO6zYgA= X-Google-Smtp-Source: AA0mqf7wleXgujqFfkd1lgUa6TOL0DjjUijqE2RChOw0pd8xkWWgDEkiDcMl7DyVXEX+jHKDZxdFvw== X-Received: by 2002:a17:906:4dc9:b0:7c1:6fc:6048 with SMTP id f9-20020a1709064dc900b007c106fc6048mr35592992ejw.24.1671439679559; Mon, 19 Dec 2022 00:47:59 -0800 (PST) Received: from thuna (eduroam-085.unibocconi.it. [90.147.70.85]) by smtp.gmail.com with ESMTPSA id s9-20020a170906bc4900b007c0e6d6bd10sm4115219ejv.132.2022.12.19.00.47.58 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 19 Dec 2022 00:47:59 -0800 (PST) From: Thuna To: bug-gnu-emacs@gnu.org Subject: [PATCH] Fix `rcirc-buffer-process' not working on channel buffers Date: Mon, 19 Dec 2022 09:47:57 +0100 Message-ID: <877cynrd8i.fsf@gmail.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Received-SPF: pass client-ip=2a00:1450:4864:20::62e; envelope-from=thuna.cing@gmail.com; helo=mail-ej1-x62e.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) --=-=-= Content-Type: text/plain Currently `rcirc-buffer-process' with no BUFFER argument defaults to current buffer's `rcirc-server-buffer' instead of the current buffer itself which leads to `rcirc-buffer-process' not working with channel buffers. This patch should hopefully fix that. --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-Fix-rcirc-buffer-process-not-working-on-channel-buff.patch Content-Description: The patch >From d17e7cbb34cf83098561c57b383f90d6a7bde50e Mon Sep 17 00:00:00 2001 From: Thuna Date: Mon, 19 Dec 2022 09:33:29 +0100 Subject: [PATCH] Fix `rcirc-buffer-process' not working on channel buffers * lisp/net/rcirc.el (rcirc-buffer-process): Look at BUFFER's `rcirc-server-buffer's `rcirc-process' instead. Signal an error if it has none. --- lisp/net/rcirc.el | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/lisp/net/rcirc.el b/lisp/net/rcirc.el index 96109dcd5c9..7afb625407e 100644 --- a/lisp/net/rcirc.el +++ b/lisp/net/rcirc.el @@ -1179,11 +1179,11 @@ rcirc-send-ctcp (defun rcirc-buffer-process (&optional buffer) "Return the process associated with channel BUFFER. With no argument or nil as argument, use the current buffer." - (let ((buffer (or buffer (and (buffer-live-p rcirc-server-buffer) - rcirc-server-buffer)))) - (if buffer - (buffer-local-value 'rcirc-process buffer) - rcirc-process))) + (let ((buffer (or buffer (current-buffer)))) + (buffer-local-value + 'rcirc-process + (or (buffer-local-value 'rcirc-server-buffer buffer) + (error "Not an rcirc buffer: %S" buffer))))) (defun rcirc-server-name (process) "Return PROCESS server name, given by the 001 response." -- 2.37.4 --=-=-=-- ------------=_1739329862-2351-1--