From debbugs-submit-bounces@debbugs.gnu.org Sun Dec 18 05:49:34 2022 Received: (at submit) by debbugs.gnu.org; 18 Dec 2022 10:49:34 +0000 Received: from localhost ([127.0.0.1]:33232 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p6rEb-0007FD-IZ for submit@debbugs.gnu.org; Sun, 18 Dec 2022 05:49:33 -0500 Received: from lists.gnu.org ([209.51.188.17]:49676) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p6rEZ-0007F6-9S for submit@debbugs.gnu.org; Sun, 18 Dec 2022 05:49:31 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p6rEV-0000L7-Hj for bug-gnu-emacs@gnu.org; Sun, 18 Dec 2022 05:49:31 -0500 Received: from mail-ej1-x633.google.com ([2a00:1450:4864:20::633]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1p6rET-0007vE-0H for bug-gnu-emacs@gnu.org; Sun, 18 Dec 2022 05:49:27 -0500 Received: by mail-ej1-x633.google.com with SMTP id vv4so15640654ejc.2 for ; Sun, 18 Dec 2022 02:49:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:user-agent:message-id:date:subject:to:from:from:to:cc :subject:date:message-id:reply-to; bh=sFolsOmzhD82y82f0LGaks9TW2ThvHqpXc3j8eeQdf0=; b=EIxHYja5JAV4ub/LVOY/MH2jVBCzR86JasVXPDuhuSgG9z73/J6eNRQ3nFlldZd9Pz WbKCocshxPUdx5X+SjW2H67OqP1lWAczAioz2kj/xGrYd1/8PAn2uCCtWTi8JT+4IWse Nr/MVbiviET/ALJuS5GxMp06JJEXtoXG/kAhyQx1sz4Du2+5iV+qJtBmpO0temPyS8pO 04xtbDFX8HFn2c0JTeuVBOr/eJUNf+PONGs54Lb+wS7POPdImyMk6sz0YsubfCyhwOTy KSmMx01WQ9o57Mcd+YcyntSJyQVDWXgQM42NXsWmtouBjtcOvIC+GjQOJ2x15LkFszxx mr3w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:user-agent:message-id:date:subject:to:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=sFolsOmzhD82y82f0LGaks9TW2ThvHqpXc3j8eeQdf0=; b=l7GK9oA1QyhvukOYwYoZBwP1ih3/qSZwTcLSdX9n1AVv2kDsRlugq+4tc1S9NHXPYA UMEHquyU8Ecu8bAfT18iT88ga0mLyJz0pWIHJmNRyN/0sO/1FTmbGGwIEqQPU0zAQBz2 T8mCrQptueKzuGLmNuqXesqAUkEIFwK2DGypMCgkMDBVaN7bTbtW8J87AHF3R4FMSG7C Gf1yCS9t4hu0Z9rdnJ8L9XTS53zL07SlVJ4ocVVgeLjYYvz9b6Fd/C1t/5rjtZ5cqvba RjIJSIvRIbhq0QZXxYePg1mMwew6MkLnlJdTC2i0cNcqEqepn4eT6g5AyIKAPyymkMCK 8u/w== X-Gm-Message-State: ANoB5pkPO5sCiPkKodUS2CrwE400Ktu/pt9gLrU8VkGEsF9jJj8VN1ll qBubDTEQIC6Vg1MqE8w2bIMH9Q8CmaE= X-Google-Smtp-Source: AA0mqf4zcp5QIgwp+rCxCAHnwQ+Wl/P6A1vfvgA11C5sPJb7mbkNF7QGBWE8JiLZEBLIK31t3+/TyQ== X-Received: by 2002:a17:907:674b:b0:7ae:5473:fdb8 with SMTP id qm11-20020a170907674b00b007ae5473fdb8mr36682029ejc.22.1671360562607; Sun, 18 Dec 2022 02:49:22 -0800 (PST) Received: from esmac.local ([192.116.36.52]) by smtp.gmail.com with ESMTPSA id e13-20020a170906314d00b0073ae9ba9ba8sm3006578eje.3.2022.12.18.02.49.21 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 18 Dec 2022 02:49:22 -0800 (PST) From: Eshel Yaron To: bug-gnu-emacs@gnu.org Subject: 30.0.50; sql-product-interactive doesn't switch to interactive buffer Date: Sun, 18 Dec 2022 12:49:20 +0200 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=2a00:1450:4864:20::633; envelope-from=eshelshay.yaron@gmail.com; helo=mail-ej1-x633.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) The docstring of sql-product-interactive states that "if [an interactive SQL] buffer exists and a process is running, just switch to [it]". However, sql-product-interactive seems to only display the existing interactive buffer, without actually switching to it. AFAICT this happens because sql-display-sqli-buffer-function defaults to display-buffer, which causes sql-display-buffer to invoke display-buffer instead of pop-to-buffer. In GNU Emacs 30.0.50 (build 15, x86_64-apple-darwin22.1.0, NS appkit-2299.00 Version 13.0 (Build 22A380)) of 2022-12-16 built on esmac Repository revision: 4331771222fe670bd45c460b5e4f68e0dd4dc3c1 Repository branch: master Windowing system distributor 'Apple', version 10.3.2299 System Description: macOS 13.0 Configured using: 'configure --with-native-compilation --enable-link-time-optimization --with-json --with-xwidgets --with-mailutils --with-imagemagick --without-dbus' Configured features: ACL GIF GLIB GMP GNUTLS IMAGEMAGICK JPEG JSON LCMS2 LIBXML2 MODULES NATIVE_COMP NOTIFY KQUEUE NS PDUMPER PNG RSVG SQLITE3 THREADS TIFF TOOLKIT_SCROLL_BARS TREE_SITTER WEBP XIM XWIDGETS ZLIB Important settings: value of $LC_CTYPE: UTF-8 locale-coding-system: utf-8-unix Major mode: SQL[Postgres] Minor modes in effect: tooltip-mode: t global-eldoc-mode: t show-paren-mode: t electric-indent-mode: t mouse-wheel-mode: t tool-bar-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t line-number-mode: t indent-tabs-mode: t transient-mark-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t Load-path shadows: None found. Features: (shadow sort mail-extr dabbrev emacsbug message mailcap yank-media puny dired dired-loaddefs rfc822 mml mml-sec epa derived epg rfc6068 epg-config gnus-util mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader sendmail rfc2047 rfc2045 ietf-drums mm-util mail-prsvr mail-utils cl-print debug backtrace find-func shortdoc text-property-search time-date help-fns radix-tree files-x sql auth-source eieio eieio-core password-cache json map byte-opt view thingatpt comint ansi-osc ansi-color ring cl-loaddefs comp comp-cstr warnings icons subr-x rx cl-seq cl-macs gv cl-extra help-mode bytecomp byte-compile cl-lib rmc iso-transl tooltip cconv eldoc paren electric uniquify ediff-hook vc-hooks lisp-float-type elisp-mode mwheel term/ns-win ns-win ucs-normalize mule-util term/common-win tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow isearch easymenu timer select scroll-bar mouse jit-lock font-lock syntax font-core term/tty-colors frame minibuffer nadvice seq simple cl-generic indonesian philippine cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite emoji-zwj charscript charprop case-table epa-hook jka-cmpr-hook help abbrev obarray oclosure cl-preloaded button loaddefs theme-loaddefs faces cus-face macroexp files window text-properties overlay sha1 md5 base64 format env code-pages mule custom widget keymap hashtable-print-readable backquote threads xwidget-internal kqueue cocoa ns lcms2 multi-tty make-network-process native-compile emacs) Memory information: ((conses 16 136590 9392) (symbols 48 8882 0) (strings 32 29054 1233) (string-bytes 1 1195471) (vectors 16 21293) (vector-slots 8 412771 17679) (floats 8 201 71) (intervals 56 1875 0) (buffers 984 18)) From debbugs-submit-bounces@debbugs.gnu.org Sun Dec 18 06:57:38 2022 Received: (at 60175) by debbugs.gnu.org; 18 Dec 2022 11:57:38 +0000 Received: from localhost ([127.0.0.1]:33538 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p6sIT-00088g-SW for submit@debbugs.gnu.org; Sun, 18 Dec 2022 06:57:38 -0500 Received: from eggs.gnu.org ([209.51.188.92]:54744) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p6sIS-00088W-Jm for 60175@debbugs.gnu.org; Sun, 18 Dec 2022 06:57:37 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p6sIM-0001nT-4f; Sun, 18 Dec 2022 06:57:30 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=7YfK8lQCE5YxQQ3RdTK4vPavFi60bEoz8wWEclTFDxw=; b=eKFB2gFhkcoO qCOr5kzMHJHvEac3zZZDM7/t4EnI1tq58rHyJTRxo1RuVfFltWAkuc0QAvqFj+YWmI6PE6HdixrPC sQSES80tA/1Pr/7to3TQRKD0up/FAzFMf5fqdSQYE0sijsTl8HPbDNMdFZ2sAfJ0WiAAxpSs2Vz5l oVUNHnEzjkCYIGr2YJx2qNlKSVB9yZYkOIvjsilDZ9qbyqzkTppsXO/9m2s9Hh4FMlf+U4hKQiTg1 6njUMIKJ1PNi6PspMUUbeLArIfkFl0990uXXCzg+NrBjpy9bFjcv6RD0U+MXzLXIYCCnzoeBxSaV1 YzCPFI2cDImL17QycSuJJQ==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p6sIJ-0000fu-SD; Sun, 18 Dec 2022 06:57:29 -0500 Date: Sun, 18 Dec 2022 13:57:35 +0200 Message-Id: <83cz8ggc0g.fsf@gnu.org> From: Eli Zaretskii To: Eshel Yaron , Michael R. Mauger In-Reply-To: (message from Eshel Yaron on Sun, 18 Dec 2022 12:49:20 +0200) Subject: Re: bug#60175: 30.0.50; sql-product-interactive doesn't switch to interactive buffer References: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 60175 Cc: 60175@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Eshel Yaron > Date: Sun, 18 Dec 2022 12:49:20 +0200 > > > The docstring of sql-product-interactive states that "if [an interactive > SQL] buffer exists and a process is running, just switch to [it]". > However, sql-product-interactive seems to only display the existing > interactive buffer, without actually switching to it. AFAICT this > happens because sql-display-sqli-buffer-function defaults to > display-buffer, which causes sql-display-buffer to invoke display-buffer > instead of pop-to-buffer. Thanks, I fixed the doc string one the emacs-29 branch. IMO, it isn't really clean that this command sometimes switches to that buffer and sometimes only displays it without selecting its window. But I'll leave that aspect to Michael (CC'ed).