GNU bug report logs - #60167
30.0.50; [PATCH]: Fix wrong capture in typescript-ts-mode

Previous Next

Package: emacs;

Reported by: Theodor Thornhill <theo <at> thornhill.no>

Date: Sat, 17 Dec 2022 19:16:02 UTC

Severity: normal

Tags: patch

Found in version 30.0.50

Done: Yuan Fu <casouri <at> gmail.com>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 60167 in the body.
You can then email your comments to 60167 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to jostein <at> secure.kjonigsen.net, casouri <at> gmail.com, bug-gnu-emacs <at> gnu.org:
bug#60167; Package emacs. (Sat, 17 Dec 2022 19:16:02 GMT) Full text and rfc822 format available.

Acknowledgement sent to Theodor Thornhill <theo <at> thornhill.no>:
New bug report received and forwarded. Copy sent to jostein <at> secure.kjonigsen.net, casouri <at> gmail.com, bug-gnu-emacs <at> gnu.org. (Sat, 17 Dec 2022 19:16:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Theodor Thornhill <theo <at> thornhill.no>
To: bug-gnu-emacs <at> gnu.org
Subject: 30.0.50; [PATCH]: Fix wrong capture in typescript-ts-mode
Date: Sat, 17 Dec 2022 20:15:17 +0100
[Message part 1 (text/plain, inline)]
Hi there!

We've had a small regression after
fbf0d3b796ac1b891be35b642878a1fd412ee5ea, and this patch fixes that.
Yuan, want to apply after Josteins agrees on this fix?  There's an
example of the currently failing code in the commit message.  There's
also a small whitespace fix inside - I hope that's ok.

Thanks guys :-)

Theo

[0001-Fix-wrong-capture-in-typescript-ts-mode.patch (text/x-diff, attachment)]

Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#60167; Package emacs. (Sat, 17 Dec 2022 23:38:02 GMT) Full text and rfc822 format available.

Message #8 received at 60167 <at> debbugs.gnu.org (full text, mbox):

From: Yuan Fu <casouri <at> gmail.com>
To: Theodor Thornhill <theo <at> thornhill.no>
Cc: 60167 <at> debbugs.gnu.org, jostein <at> secure.kjonigsen.net
Subject: Re: bug#60167: 30.0.50; [PATCH]: Fix wrong capture in 
 typescript-ts-mode
Date: Sat, 17 Dec 2022 15:37:30 -0800
Theodor Thornhill <theo <at> thornhill.no> writes:

> Hi there!
>
> We've had a small regression after
> fbf0d3b796ac1b891be35b642878a1fd412ee5ea, and this patch fixes that.
> Yuan, want to apply after Josteins agrees on this fix?  There's an
> example of the currently failing code in the commit message.  There's
> also a small whitespace fix inside - I hope that's ok.
>
> Thanks guys :-)
>
> Theo

Cool, I’ll wait for Jostein’s opinion :-)

Yuan




Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#60167; Package emacs. (Sun, 18 Dec 2022 06:26:02 GMT) Full text and rfc822 format available.

Message #11 received at 60167 <at> debbugs.gnu.org (full text, mbox):

From: Theodor Thornhill <theo <at> thornhill.no>
To: Yuan Fu <casouri <at> gmail.com>
Cc: 60167 <at> debbugs.gnu.org, jostein <at> secure.kjonigsen.net
Subject: Re: bug#60167: 30.0.50; [PATCH]: Fix wrong capture in  typescript-ts-mode
Date: Sun, 18 Dec 2022 07:25:03 +0100

On 18 December 2022 00:37:30 CET, Yuan Fu <casouri <at> gmail.com> wrote:
>
>Theodor Thornhill <theo <at> thornhill.no> writes:
>
>> Hi there!
>>
>> We've had a small regression after
>> fbf0d3b796ac1b891be35b642878a1fd412ee5ea, and this patch fixes that.
>> Yuan, want to apply after Josteins agrees on this fix?  There's an
>> example of the currently failing code in the commit message.  There's
>> also a small whitespace fix inside - I hope that's ok.
>>
>> Thanks guys :-)
>>
>> Theo
>
>Cool, I’ll wait for Jostein’s opinion :-)
>
>Yuan

He agreed :)
Theo




Reply sent to Yuan Fu <casouri <at> gmail.com>:
You have taken responsibility. (Sun, 18 Dec 2022 08:10:01 GMT) Full text and rfc822 format available.

Notification sent to Theodor Thornhill <theo <at> thornhill.no>:
bug acknowledged by developer. (Sun, 18 Dec 2022 08:10:01 GMT) Full text and rfc822 format available.

Message #16 received at 60167-done <at> debbugs.gnu.org (full text, mbox):

From: Yuan Fu <casouri <at> gmail.com>
To: Theodor Thornhill <theo <at> thornhill.no>
Cc: 60167-done <at> debbugs.gnu.org, jostein <at> secure.kjonigsen.net
Subject: Re: bug#60167: 30.0.50; [PATCH]: Fix wrong capture in 
 typescript-ts-mode
Date: Sun, 18 Dec 2022 00:08:59 -0800
Theodor Thornhill <theo <at> thornhill.no> writes:

> On 18 December 2022 00:37:30 CET, Yuan Fu <casouri <at> gmail.com> wrote:
>>
>>Theodor Thornhill <theo <at> thornhill.no> writes:
>>
>>> Hi there!
>>>
>>> We've had a small regression after
>>> fbf0d3b796ac1b891be35b642878a1fd412ee5ea, and this patch fixes that.
>>> Yuan, want to apply after Josteins agrees on this fix?  There's an
>>> example of the currently failing code in the commit message.  There's
>>> also a small whitespace fix inside - I hope that's ok.
>>>
>>> Thanks guys :-)
>>>
>>> Theo
>>
>>Cool, I’ll wait for Jostein’s opinion :-)
>>
>>Yuan
>
> He agreed :)
> Theo

Yeah I think I saw his message but it didn’t appear on debbugs for some
reason. Anyway, I applied the patch, thanks!

Yuan




bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Sun, 15 Jan 2023 12:24:08 GMT) Full text and rfc822 format available.

This bug report was last modified 2 years and 214 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.