GNU bug report logs - #60163
29.0.60; Error in post-command-hook (winner-save-old-configurations): (wrong-type-argument frame-live-p #<dead frame code action 0x563ea51cbf70>)

Previous Next

Package: emacs;

Reported by: 张云峰 <zhangyunfeng0101 <at> gmail.com>

Date: Sat, 17 Dec 2022 17:24:01 UTC

Severity: normal

Found in version 29.0.60

Done: Stefan Kangas <stefankangas <at> gmail.com>

Bug is archived. No further changes may be made.

Full log


Message #54 received at 60163 <at> debbugs.gnu.org (full text, mbox):

From: 张云峰 <zhangyunfeng0101 <at> gmail.com>
To: martin rudalics <rudalics <at> gmx.at>
Cc: 60163 <at> debbugs.gnu.org
Subject: Re: bug#60163: 29.0.60; Error in post-command-hook
 (winner-save-old-configurations): (wrong-type-argument frame-live-p #<dead
 frame code action 0x563ea51cbf70>)
Date: Thu, 22 Dec 2022 10:34:36 +0800
[Message part 1 (text/plain, inline)]
Hello, I tested your patch just now, unfortunately, it doesn't work。

martin rudalics <rudalics <at> gmx.at> 于2022年12月22日周四 01:06写道:

>  > echo "Please make sure 'clangd' has installed!"
>
> Sorry, but I don't have clangd installed either.
>
> But let's try one thing first: IIUC 'winner-save-old-configurations' can
> fail in the indicated way only if it tries to insert a dead frame.  So
> please try with the following trivial patch:
>
> diff --git a/lisp/winner.el b/lisp/winner.el
> index c8354b18be..9fd86ae23f 100644
> --- a/lisp/winner.el
> +++ b/lisp/winner.el
> @@ -178,7 +178,8 @@ winner-save-old-configurations
>         (setq winner-last-frames nil)
>         (setq winner-last-command this-command))
>       (dolist (frame winner-modified-list)
> -      (winner-insert-if-new frame))
> +      (when (frame-live-p frame)
> +        (winner-insert-if-new frame)))
>       (setq winner-modified-list nil)
>       (winner-remember)))
>
>
> I doubt it will help much but at least we can exclude one possible
> source of troubles.
>
> martin
>
[Message part 2 (text/html, inline)]

This bug report was last modified 1 year and 252 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.