Subject: Re: bug#60163: 29.0.60; Error in post-command-hook (winner-save-old-configurations): (wrong-type-argument frame-live-p #<dead frame code action 0x563ea51cbf70>)

From: 张云峰 <[email-masked]>
Date: Thu, 22 Dec 2022 10:34:36 +0800

Hello, I tested your patch just now, unfortunately, it doesn't work。

martin rudalics <[email-masked]> 于2022年12月22日周四 01:06写道：

>  > echo "Please make sure 'clangd' has installed!"
>
> Sorry, but I don't have clangd installed either.
>
> But let's try one thing first: IIUC 'winner-save-old-configurations' can
> fail in the indicated way only if it tries to insert a dead frame.  So
> please try with the following trivial patch:
>
> diff --git a/lisp/winner.el b/lisp/winner.el
> index c8354b18be..9fd86ae23f 100644
> --- a/lisp/winner.el
> +++ b/lisp/winner.el
> @@ -178,7 +178,8 @@ winner-save-old-configurations
>         (setq winner-last-frames nil)
>         (setq winner-last-command this-command))
>       (dolist (frame winner-modified-list)
> -      (winner-insert-if-new frame))
> +      (when (frame-live-p frame)
> +        (winner-insert-if-new frame)))
>       (setq winner-modified-list nil)
>       (winner-remember)))
>
>
> I doubt it will help much but at least we can exclude one possible
> source of troubles.
>
> martin
>