From unknown Sun Jun 15 08:40:05 2025 X-Loop: help-debbugs@gnu.org Subject: bug#60161: [PATCH] Allow customising windmove user options with an empty prefix Resent-From: Philip Kaludercic Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 17 Dec 2022 15:05:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 60161 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: 60161@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.16712894867267 (code B ref -1); Sat, 17 Dec 2022 15:05:01 +0000 Received: (at submit) by debbugs.gnu.org; 17 Dec 2022 15:04:46 +0000 Received: from localhost ([127.0.0.1]:56354 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p6Yk2-0001t9-CM for submit@debbugs.gnu.org; Sat, 17 Dec 2022 10:04:46 -0500 Received: from lists.gnu.org ([209.51.188.17]:59400) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p6Yk0-0001t3-PC for submit@debbugs.gnu.org; Sat, 17 Dec 2022 10:04:45 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p6Yk0-0000Tn-Dj for bug-gnu-emacs@gnu.org; Sat, 17 Dec 2022 10:04:44 -0500 Received: from mout01.posteo.de ([185.67.36.65]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p6Yjy-0001d3-DC for bug-gnu-emacs@gnu.org; Sat, 17 Dec 2022 10:04:44 -0500 Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 4FB78240026 for ; Sat, 17 Dec 2022 16:04:38 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1671289479; bh=iiOoOBnd2aKyK8AVtGoKr7HDYNQs2QgVWTi+ud7d0gU=; h=From:To:Subject:Date:From; b=XDKEQjso/aZEPTz3NaXut+wgAdKbwAEthYOuKIDrNnWwKgvHihBM0/8OwKYIZe6G0 503goWzOSaSFmGdzc8l9cRA27jvOr4EkHoWNlFRZf60AX0CXdXknoIiqwRGHW292DY iXHEUluoc2bBPM25qZh48d6HBA+t+Kv22ekj8rwhIEMCZLdf22MGw7+sPxzszL+m2x QXPn6O6IywNfLl58997pg10+oe3uGoa7aSpSi6F1HQF8Ad0wkmtJwn07v1fXmwHBJJ C5tomd3LUkOoFfa2p7hTrKml0QR192LtXjSJ7q8hRv0zx8SmJgoMebtvUXTsMkvnHo 1J+i0EoZC4/qA== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4NZ8QF6gyXz6tm9 for ; Sat, 17 Dec 2022 16:04:37 +0100 (CET) From: Philip Kaludercic Date: Sat, 17 Dec 2022 15:04:41 +0000 Message-ID: <87tu1ugjg6.fsf@posteo.net> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Received-SPF: pass client-ip=185.67.36.65; envelope-from=philipk@posteo.net; helo=mout01.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) --=-=-= Content-Type: text/plain Tags: patch I just switched to setopt, and noticed a few errors. Among these was `windmove-default-keybindings', which didn't want to set (setopt windmove-default-keybindings '(nil . nil)) while (setopt windmove-default-keybindings '("C-c" . nil)) is allowed. The mistake appears to be that the option type is misconfigured, and believes the car must be a keybinding, which hasn't been the case since Emacs 28. The patch below updates the type, resolving this issue. In GNU Emacs 29.0.60 (build 5, x86_64-pc-linux-gnu, GTK+ Version 3.24.35, cairo version 1.16.0) of 2022-12-14 built on quetzal Repository revision: 622838b957e240d700585050e9ddbd036e690513 Repository branch: emacs-29 System Description: Debian GNU/Linux bookworm/sid Configured using: 'configure --with-pgtk --with-imagemagick' --=-=-= Content-Type: text/patch Content-Disposition: attachment; filename=0001-Allow-customising-windmove-user-options-with-an-empt.patch >From feca8985392c227ee7caaaa69ac8bdc990a0256b Mon Sep 17 00:00:00 2001 From: Philip Kaludercic Date: Sat, 17 Dec 2022 15:54:40 +0100 Subject: [PATCH] Allow customising windmove user options with an empty prefix * lisp/windmove.el (windmove--default-keybindings-type): Handle nil as a prefix value. --- lisp/windmove.el | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/lisp/windmove.el b/lisp/windmove.el index 00e76df0a0..4311f082de 100644 --- a/lisp/windmove.el +++ b/lisp/windmove.el @@ -776,7 +776,8 @@ windmove-swap-states-default-keybindings (defconst windmove--default-keybindings-type `(choice (const :tag "Don't bind" nil) (cons :tag "Bind using" - (key-sequence :tag "Prefix") + (choice (key-sequence :tag "Prefix") + (const :tag "No Prefix" nil)) (set :tag "Modifier" :greedy t ;; See `(elisp) Keyboard Events' -- 2.35.1 --=-=-=-- From unknown Sun Jun 15 08:40:05 2025 X-Loop: help-debbugs@gnu.org Subject: bug#60161: [PATCH] Allow customising windmove user options with an empty prefix Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 18 Dec 2022 11:24:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60161 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Philip Kaludercic Cc: 60161@debbugs.gnu.org Received: via spool by 60161-submit@debbugs.gnu.org id=B60161.167136261529178 (code B ref 60161); Sun, 18 Dec 2022 11:24:02 +0000 Received: (at 60161) by debbugs.gnu.org; 18 Dec 2022 11:23:35 +0000 Received: from localhost ([127.0.0.1]:33373 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p6rlX-0007aY-7J for submit@debbugs.gnu.org; Sun, 18 Dec 2022 06:23:35 -0500 Received: from eggs.gnu.org ([209.51.188.92]:54610) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p6rlV-0007aN-Dp for 60161@debbugs.gnu.org; Sun, 18 Dec 2022 06:23:33 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p6rlP-0004V3-SM; Sun, 18 Dec 2022 06:23:27 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=MPYp2POB57QT8jNTJw4UnIUbhwVrnfaUz4vJI+4nGB8=; b=GXVy6CaAMh8W dFLSOZi8pkhvnh9HRlxx/Hrlarq+QZ6q4YCmXnWwWFkSNn3Z/uj89+ZpwvEabf+gKnJ4NOHWJyWhP nAo4Qu4vNX6lM1feroDm+PL4xz1YIpCC8f3eiNSN+F8Bb1403Iif+e+Ei/av/Yh/ggrViWEiXhWRz iD81ubFEFKbKiX+mUQrJkOBiAbmdN0sE3CF34zf6A9BpsqrTTtYVnRVM/689pt4/jYGbhopxEDipp zup8+HaofTAoQoDwnL3t2pzgO//4Ul/DMCdi50Z8I8kMrEbma/h+7xrQnMY5gf9jZM0Wccpll2Uvg eA81jvWXsF0wSxFm+odGDQ==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p6rlP-0007zT-8a; Sun, 18 Dec 2022 06:23:27 -0500 Date: Sun, 18 Dec 2022 13:23:34 +0200 Message-Id: <83k02pez0p.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: <87tu1ugjg6.fsf@posteo.net> (message from Philip Kaludercic on Sat, 17 Dec 2022 15:04:41 +0000) References: <87tu1ugjg6.fsf@posteo.net> X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Philip Kaludercic > Date: Sat, 17 Dec 2022 15:04:41 +0000 > > I just switched to setopt, and noticed a few errors. Among these was > `windmove-default-keybindings', which didn't want to set > > (setopt windmove-default-keybindings '(nil . nil)) > > while > > (setopt windmove-default-keybindings '("C-c" . nil)) > > is allowed. The mistake appears to be that the option type is > misconfigured, and believes the car must be a keybinding, which hasn't > been the case since Emacs 28. The patch below updates the type, > resolving this issue. Thanks, please install on the release branch. From unknown Sun Jun 15 08:40:05 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Philip Kaludercic Subject: bug#60161: closed (Re: bug#60161: [PATCH] Allow customising windmove user options with an empty prefix) Message-ID: References: <87zgblx7ca.fsf@posteo.net> <87tu1ugjg6.fsf@posteo.net> X-Gnu-PR-Message: they-closed 60161 X-Gnu-PR-Package: emacs X-Gnu-PR-Keywords: patch Reply-To: 60161@debbugs.gnu.org Date: Sun, 18 Dec 2022 11:47:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1671364022-30696-1" This is a multi-part message in MIME format... ------------=_1671364022-30696-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #60161: [PATCH] Allow customising windmove user options with an empty prefix which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 60161@debbugs.gnu.org. --=20 60161: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D60161 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1671364022-30696-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 60161-done) by debbugs.gnu.org; 18 Dec 2022 11:46:35 +0000 Received: from localhost ([127.0.0.1]:33477 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p6s7n-0007yU-4U for submit@debbugs.gnu.org; Sun, 18 Dec 2022 06:46:35 -0500 Received: from mout02.posteo.de ([185.67.36.66]:34581) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p6s7l-0007yJ-HG for 60161-done@debbugs.gnu.org; Sun, 18 Dec 2022 06:46:34 -0500 Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id 72AE2240105 for <60161-done@debbugs.gnu.org>; Sun, 18 Dec 2022 12:46:27 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1671363987; bh=aK9q0vhknQTUpf1eDAjxlRNNayf+Pslqqgnq6nES6Tc=; h=From:To:Cc:Subject:Date:From; b=HrBFwgAWCLbxEMElNhOr5L2hp4H4C+trCL7Iz7+MdfMcoZLn7FE/FBcNEMDxNts3a x4iqKhMf3qkOAEWcAJYSuTVmPHP9Bt28ZEu0w5qGro9TOAO4msA2dq4/sPBv+HYGf7 Wd5Pz2V5rIqehvZaprcNcZ5n7RA6oYoW2HZpCj6pBeiYmvCQoAeIHXTCcODxxl0BzJ g8UUFavoWanvcgWUOphB1CwnjDa3qQsvvuAXOTVvJ+f13HvkoP3xhKpUEP0KS0e3go peKiWZ+sAOldCkdpIHXcFBmCfrNbDnASjKCpF9GSS+FiNy50z8T4QTBuOGo8lHwX4L ssKDacU6T/Mzw== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4NZgz55hhVz9rxK; Sun, 18 Dec 2022 12:46:25 +0100 (CET) From: Philip Kaludercic To: Eli Zaretskii Subject: Re: bug#60161: [PATCH] Allow customising windmove user options with an empty prefix In-Reply-To: <83k02pez0p.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 18 Dec 2022 13:23:34 +0200") References: <87tu1ugjg6.fsf@posteo.net> <83k02pez0p.fsf@gnu.org> Date: Sun, 18 Dec 2022 11:46:29 +0000 Message-ID: <87zgblx7ca.fsf@posteo.net> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 60161-done Cc: 60161-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Eli Zaretskii writes: >> From: Philip Kaludercic >> Date: Sat, 17 Dec 2022 15:04:41 +0000 >> >> I just switched to setopt, and noticed a few errors. Among these was >> `windmove-default-keybindings', which didn't want to set >> >> (setopt windmove-default-keybindings '(nil . nil)) >> >> while >> >> (setopt windmove-default-keybindings '("C-c" . nil)) >> >> is allowed. The mistake appears to be that the option type is >> misconfigured, and believes the car must be a keybinding, which hasn't >> been the case since Emacs 28. The patch below updates the type, >> resolving this issue. > > Thanks, please install on the release branch. Pushed ------------=_1671364022-30696-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 17 Dec 2022 15:04:46 +0000 Received: from localhost ([127.0.0.1]:56354 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p6Yk2-0001t9-CM for submit@debbugs.gnu.org; Sat, 17 Dec 2022 10:04:46 -0500 Received: from lists.gnu.org ([209.51.188.17]:59400) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p6Yk0-0001t3-PC for submit@debbugs.gnu.org; Sat, 17 Dec 2022 10:04:45 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p6Yk0-0000Tn-Dj for bug-gnu-emacs@gnu.org; Sat, 17 Dec 2022 10:04:44 -0500 Received: from mout01.posteo.de ([185.67.36.65]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p6Yjy-0001d3-DC for bug-gnu-emacs@gnu.org; Sat, 17 Dec 2022 10:04:44 -0500 Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 4FB78240026 for ; Sat, 17 Dec 2022 16:04:38 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1671289479; bh=iiOoOBnd2aKyK8AVtGoKr7HDYNQs2QgVWTi+ud7d0gU=; h=From:To:Subject:Date:From; b=XDKEQjso/aZEPTz3NaXut+wgAdKbwAEthYOuKIDrNnWwKgvHihBM0/8OwKYIZe6G0 503goWzOSaSFmGdzc8l9cRA27jvOr4EkHoWNlFRZf60AX0CXdXknoIiqwRGHW292DY iXHEUluoc2bBPM25qZh48d6HBA+t+Kv22ekj8rwhIEMCZLdf22MGw7+sPxzszL+m2x QXPn6O6IywNfLl58997pg10+oe3uGoa7aSpSi6F1HQF8Ad0wkmtJwn07v1fXmwHBJJ C5tomd3LUkOoFfa2p7hTrKml0QR192LtXjSJ7q8hRv0zx8SmJgoMebtvUXTsMkvnHo 1J+i0EoZC4/qA== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4NZ8QF6gyXz6tm9 for ; Sat, 17 Dec 2022 16:04:37 +0100 (CET) From: Philip Kaludercic To: bug-gnu-emacs@gnu.org Subject: [PATCH] Allow customising windmove user options with an empty prefix Date: Sat, 17 Dec 2022 15:04:41 +0000 Message-ID: <87tu1ugjg6.fsf@posteo.net> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Received-SPF: pass client-ip=185.67.36.65; envelope-from=philipk@posteo.net; helo=mout01.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) --=-=-= Content-Type: text/plain Tags: patch I just switched to setopt, and noticed a few errors. Among these was `windmove-default-keybindings', which didn't want to set (setopt windmove-default-keybindings '(nil . nil)) while (setopt windmove-default-keybindings '("C-c" . nil)) is allowed. The mistake appears to be that the option type is misconfigured, and believes the car must be a keybinding, which hasn't been the case since Emacs 28. The patch below updates the type, resolving this issue. In GNU Emacs 29.0.60 (build 5, x86_64-pc-linux-gnu, GTK+ Version 3.24.35, cairo version 1.16.0) of 2022-12-14 built on quetzal Repository revision: 622838b957e240d700585050e9ddbd036e690513 Repository branch: emacs-29 System Description: Debian GNU/Linux bookworm/sid Configured using: 'configure --with-pgtk --with-imagemagick' --=-=-= Content-Type: text/patch Content-Disposition: attachment; filename=0001-Allow-customising-windmove-user-options-with-an-empt.patch >From feca8985392c227ee7caaaa69ac8bdc990a0256b Mon Sep 17 00:00:00 2001 From: Philip Kaludercic Date: Sat, 17 Dec 2022 15:54:40 +0100 Subject: [PATCH] Allow customising windmove user options with an empty prefix * lisp/windmove.el (windmove--default-keybindings-type): Handle nil as a prefix value. --- lisp/windmove.el | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/lisp/windmove.el b/lisp/windmove.el index 00e76df0a0..4311f082de 100644 --- a/lisp/windmove.el +++ b/lisp/windmove.el @@ -776,7 +776,8 @@ windmove-swap-states-default-keybindings (defconst windmove--default-keybindings-type `(choice (const :tag "Don't bind" nil) (cons :tag "Bind using" - (key-sequence :tag "Prefix") + (choice (key-sequence :tag "Prefix") + (const :tag "No Prefix" nil)) (set :tag "Modifier" :greedy t ;; See `(elisp) Keyboard Events' -- 2.35.1 --=-=-=-- ------------=_1671364022-30696-1--