From unknown Tue Aug 19 01:58:40 2025 X-Loop: help-debbugs@gnu.org Subject: bug#60157: 30.0.50; [PATCH]: Change interactive form in transpose-chars Resent-From: Theodor Thornhill Original-Sender: "Debbugs-submit" Resent-CC: monnier@iro.umontreal.ca, eliz@gnu.org, bug-gnu-emacs@gnu.org Resent-Date: Sat, 17 Dec 2022 12:25:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 60157 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: 60157@debbugs.gnu.org Cc: monnier@iro.umontreal.ca, eliz@gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org X-Debbugs-Original-Xcc: monnier@iro.umontreal.ca, eliz@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.167127984324236 (code B ref -1); Sat, 17 Dec 2022 12:25:01 +0000 Received: (at submit) by debbugs.gnu.org; 17 Dec 2022 12:24:03 +0000 Received: from localhost ([127.0.0.1]:55616 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p6WEV-0006Iq-9x for submit@debbugs.gnu.org; Sat, 17 Dec 2022 07:24:03 -0500 Received: from lists.gnu.org ([209.51.188.17]:40818) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p6WEU-0006Ik-1I for submit@debbugs.gnu.org; Sat, 17 Dec 2022 07:24:02 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p6WET-0001Rm-PK for bug-gnu-emacs@gnu.org; Sat, 17 Dec 2022 07:24:01 -0500 Received: from out-217.mta0.migadu.com ([91.218.175.217]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p6WEQ-0007OI-Sd for bug-gnu-emacs@gnu.org; Sat, 17 Dec 2022 07:24:01 -0500 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=thornhill.no; s=key1; t=1671279835; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type; bh=IzT8rbmzUXDLMuND8yjw8gcxQEymVw000B1q9x3IjoA=; b=RWp7C+B9YAfiyEcBZYCevOMEqIDbaiybF5T2R6kcDE3GqtwZpBGtNa9uPiM8Tn8hzMt94u 2TAYusnAeyoFZ4e1inR6+TjKbs6xPnDYrph2xttNabTArNE+ye25co7wk61Fgd8d+9zsv5 BemIROeve+aWy27ldTEoTjWp3NLaENu0k6zGeoLlKIKy2GWYN09wI3ERvzmAxhdCCGoa6q xlZtlnZreyfktgcXKX2mN/ri0f9vAAMqXCOr0wOp4tTiMXRNWJUnGH/fWwjGqNj5udg9Im /cwL/uiOsO58d4FkZB4EPtWj9Ae0FhkDbsVa6CjFx0b4eEH5SCL4xndzbHPwXQ== From: Theodor Thornhill Date: Sat, 17 Dec 2022 13:23:53 +0100 Message-ID: <87k02qte06.fsf@thornhill.no> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Migadu-Flow: FLOW_OUT Received-SPF: pass client-ip=91.218.175.217; envelope-from=theo@thornhill.no; helo=out-217.mta0.migadu.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) --=-=-= Content-Type: text/plain Hi Stefan and Eli! As a part of my investigation into transposing things using tree-sitter I promised to also introduce some improvements to both the code and documentation, as the latter is a little sparse. I'll add some patches while I work on the tree-sitter stuff. This commit simplifies the transpose-chars. The bug described in the commit history is no longer reproducible, so I think its complicated nature can be removed. What do you think? Theo --=-=-= Content-Type: text/x-diff Content-Disposition: attachment; filename=0001-Use-p-in-interactive-form-in-transpose-chars.patch >From f7d98eb478b9d10c15e6b2d168049e65fcd3c448 Mon Sep 17 00:00:00 2001 From: Theodor Thornhill Date: Sat, 17 Dec 2022 13:14:22 +0100 Subject: [PATCH] Use *p in interactive form in transpose-chars There are two changes in this commit. The first one is removal of an obsolete guard against moving into read-only text, as described in bug#17829. The second is a simplification of the code to make it more similar to its sibling commands. We can convert the prefix into a number immediately, rather than later. * lisp/simple.el (transpose-chars): Use '*p' instead of '*P' like the other transpose-* functions. --- lisp/simple.el | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/lisp/simple.el b/lisp/simple.el index dcc2242e49..bde65d96f1 100644 --- a/lisp/simple.el +++ b/lisp/simple.el @@ -8421,11 +8421,8 @@ transpose-chars With prefix arg ARG, effect is to take character before point and drag it forward past ARG other characters (backward if ARG negative). If no argument and at end of line, the previous two chars are exchanged." - (interactive "*P") - (when (and (null arg) (eolp) (not (bobp)) - (not (get-text-property (1- (point)) 'read-only))) - (forward-char -1)) - (transpose-subr 'forward-char (prefix-numeric-value arg))) + (interactive "*p") + (transpose-subr 'forward-char arg)) (defun transpose-words (arg) "Interchange words around point, leaving point at end of them. -- 2.34.1 --=-=-=-- From unknown Tue Aug 19 01:58:40 2025 X-Loop: help-debbugs@gnu.org Subject: bug#60157: 30.0.50; [PATCH]: Change interactive form in transpose-chars Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 24 Dec 2022 07:03:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60157 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Theodor Thornhill Cc: 60157@debbugs.gnu.org, monnier@iro.umontreal.ca Received: via spool by 60157-submit@debbugs.gnu.org id=B60157.16718653268805 (code B ref 60157); Sat, 24 Dec 2022 07:03:01 +0000 Received: (at 60157) by debbugs.gnu.org; 24 Dec 2022 07:02:06 +0000 Received: from localhost ([127.0.0.1]:41275 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p8yXl-0002Hx-MH for submit@debbugs.gnu.org; Sat, 24 Dec 2022 02:02:06 -0500 Received: from eggs.gnu.org ([209.51.188.92]:46460) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p8yXj-0002HZ-PZ for 60157@debbugs.gnu.org; Sat, 24 Dec 2022 02:02:04 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p8yXe-0004Ij-C8; Sat, 24 Dec 2022 02:01:58 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=MO4t05vloKypPDvDn2rNktenBgSGUroRHTJ9bocvzAk=; b=TGG1QluMh3Dm 3QzndSn8OKno7KYiGg+GAJtzq6unlYTuvoiNsfXdYkJRoSlc90uRcWsRL+JgxyeDUCwS26v8mK6k+ oekCOAAU7TiAepaKo6zzn9c02heeLNpHqLnOvn8Qu9PsYPgGd88880vqllNAGg8laJLzeYhG6XXy7 XJRCGQwxwlD9vYsLAypiyYFM6LJOx8w7u6Nx9inPBFg8zR6p7TssVgzfGKN0J9I577YVrP/Ide3yK qyDyiPmENB7FDhYdlMQaY5LC7mbB3EwJC2EUtG2ANX1gDAdot0o91SRp+MleI38/U1qm/Ex4vkxlW b/AdUd83FS/jBvZjne4dcQ==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p8yXd-0001pd-7F; Sat, 24 Dec 2022 02:01:57 -0500 Date: Sat, 24 Dec 2022 09:01:55 +0200 Message-Id: <83y1qx5lp8.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: <87k02qte06.fsf@thornhill.no> (message from Theodor Thornhill on Sat, 17 Dec 2022 13:23:53 +0100) References: <87k02qte06.fsf@thornhill.no> X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Cc: monnier@iro.umontreal.ca, eliz@gnu.org > From: Theodor Thornhill > Date: Sat, 17 Dec 2022 13:23:53 +0100 > > Hi Stefan and Eli! > > As a part of my investigation into transposing things using tree-sitter > I promised to also introduce some improvements to both the code and > documentation, as the latter is a little sparse. I'll add some patches > while I work on the tree-sitter stuff. > > This commit simplifies the transpose-chars. The bug described in the > commit history is no longer reproducible, so I think its complicated > nature can be removed. What do you think? > > Theo > > >From f7d98eb478b9d10c15e6b2d168049e65fcd3c448 Mon Sep 17 00:00:00 2001 > From: Theodor Thornhill > Date: Sat, 17 Dec 2022 13:14:22 +0100 > Subject: [PATCH] Use *p in interactive form in transpose-chars > > There are two changes in this commit. The first one is removal of an > obsolete guard against moving into read-only text, as described in > bug#17829. The second is a simplification of the code to make it more > similar to its sibling commands. We can convert the prefix into a > number immediately, rather than later. > > * lisp/simple.el (transpose-chars): Use '*p' instead of '*P' like the > other transpose-* functions. > --- > lisp/simple.el | 7 ++----- > 1 file changed, 2 insertions(+), 5 deletions(-) > > diff --git a/lisp/simple.el b/lisp/simple.el > index dcc2242e49..bde65d96f1 100644 > --- a/lisp/simple.el > +++ b/lisp/simple.el > @@ -8421,11 +8421,8 @@ transpose-chars > With prefix arg ARG, effect is to take character before point > and drag it forward past ARG other characters (backward if ARG negative). > If no argument and at end of line, the previous two chars are exchanged." > - (interactive "*P") > - (when (and (null arg) (eolp) (not (bobp)) > - (not (get-text-property (1- (point)) 'read-only))) > - (forward-char -1)) > - (transpose-subr 'forward-char (prefix-numeric-value arg))) > + (interactive "*p") > + (transpose-subr 'forward-char arg)) > > (defun transpose-words (arg) > "Interchange words around point, leaving point at end of them. > -- > 2.34.1 Stefan, any further comments, or should I install this? From unknown Tue Aug 19 01:58:40 2025 X-Loop: help-debbugs@gnu.org Subject: bug#60157: 30.0.50; [PATCH]: Change interactive form in transpose-chars Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 24 Dec 2022 13:42:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60157 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Eli Zaretskii Cc: 60157@debbugs.gnu.org, Theodor Thornhill Received: via spool by 60157-submit@debbugs.gnu.org id=B60157.16718892705469 (code B ref 60157); Sat, 24 Dec 2022 13:42:01 +0000 Received: (at 60157) by debbugs.gnu.org; 24 Dec 2022 13:41:10 +0000 Received: from localhost ([127.0.0.1]:43042 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p94ly-0001Q9-Fl for submit@debbugs.gnu.org; Sat, 24 Dec 2022 08:41:10 -0500 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:2197) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p94lv-0001Pv-W7 for 60157@debbugs.gnu.org; Sat, 24 Dec 2022 08:41:09 -0500 Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 215D6440C40; Sat, 24 Dec 2022 08:41:02 -0500 (EST) Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 90614440A40; Sat, 24 Dec 2022 08:41:00 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1671889260; bh=d+GQ1maGShLsxISRGagHIpvS/Oypd7Oo/9DiiTISDCI=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=ez8c4aI5m07pMtVKe9w6gpiCkoRlzxMHegsn+UVeI4WLyJPZg5+gv6aZhf2rnx5Dm KnKZQfmwzkN4r+O11aePxd7ic0bX8NW97+9dBmK5fQbex14GpCVqy4r1dFfynefKWb OSgPA5BN/L24Luu2e60T+4cAfjlw0mRMw1PG5pLTwHRI7XW7H1Ms7AI6HqeCkkp+Xd KpuEWyq/d6co5LyahB0C9VhT3wPeWF3MLHqix+OkOWeQrTyLSMKxAehfb5XQA1gDUl Yrl0Co1nJWLsuBikWaG0AB25kE0x2O3MpRVQbGEsaLRB2axZOqQr4fhXTA1Q/QMtIx /VjWnH+L/R2Pg== Received: from pastel (unknown [45.72.200.228]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 45B0F1205A2; Sat, 24 Dec 2022 08:41:00 -0500 (EST) From: Stefan Monnier In-Reply-To: <83y1qx5lp8.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 24 Dec 2022 09:01:55 +0200") Message-ID: References: <87k02qte06.fsf@thornhill.no> <83y1qx5lp8.fsf@gnu.org> Date: Sat, 24 Dec 2022 08:40:58 -0500 User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL -0.358 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) >> If no argument and at end of line, the previous two chars are exchanged." >> - (interactive "*P") >> - (when (and (null arg) (eolp) (not (bobp)) >> - (not (get-text-property (1- (point)) 'read-only))) >> - (forward-char -1)) Hmm... If you remove this, does it still behave as described on the last line of the docstring? >> + (transpose-subr 'forward-char arg)) Please use #' to quote function names. Stefan From unknown Tue Aug 19 01:58:40 2025 X-Loop: help-debbugs@gnu.org Subject: bug#60157: 30.0.50; [PATCH]: Change interactive form in transpose-chars Resent-From: Theodor Thornhill Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 24 Dec 2022 19:12:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60157 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Stefan Monnier , Eli Zaretskii Cc: 60157@debbugs.gnu.org Received: via spool by 60157-submit@debbugs.gnu.org id=B60157.167190910730755 (code B ref 60157); Sat, 24 Dec 2022 19:12:01 +0000 Received: (at 60157) by debbugs.gnu.org; 24 Dec 2022 19:11:47 +0000 Received: from localhost ([127.0.0.1]:47161 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p99vv-0007zy-5y for submit@debbugs.gnu.org; Sat, 24 Dec 2022 14:11:47 -0500 Received: from out-111.mta0.migadu.com ([91.218.175.111]:24060) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p99vs-0007zp-Fw for 60157@debbugs.gnu.org; Sat, 24 Dec 2022 14:11:45 -0500 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=thornhill.no; s=key1; t=1671909102; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=+cCQRs6oo/x9KgDuhEl7eRMMLso39k6btI1Zm1YtdIk=; b=oRCcpih0G1J+wNpfm2A8XW2El8bxPpVHnFR7wFJoJXA3/AUqj4BO0xC3BVSlKFw9f7ijv6 vCreXV8gT7M/42DtmOFCsJKiQ/PXhYJX4h3s3nnhB1ww7NvhkE8y+vTVgifn7r5m/uDk8O KUa+C6oBcJX1teJonzNg/aGQK1xCES4PrwtdrfBzsuNJBWJzQHK01hMyjSdT8YOUlR4xq2 NtqyAFu8zEGWDSKF7yiBhb1Kt95kWy7ZHu6Izn4VETTp/ybsW4ThFIuriTHMm1wZ6dHXx8 e1KqSB8/3x22xav8dlGLlVdLL6llZ1k/4htSFGsWW/NMtBymLfNPpAY4vt5PaQ== From: Theodor Thornhill In-Reply-To: References: <87k02qte06.fsf@thornhill.no> <83y1qx5lp8.fsf@gnu.org> Date: Sat, 24 Dec 2022 20:11:41 +0100 Message-ID: <87mt7cr502.fsf@thornhill.no> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Migadu-Flow: FLOW_OUT X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain Stefan Monnier writes: >>> If no argument and at end of line, the previous two chars are exchanged." >>> - (interactive "*P") >>> - (when (and (null arg) (eolp) (not (bobp)) >>> - (not (get-text-property (1- (point)) 'read-only))) >>> - (forward-char -1)) > > Hmm... If you remove this, does it still behave as described on the last > line of the docstring? > You're right. It does not. I fixed that in the latest patch. >>> + (transpose-subr 'forward-char arg)) > > Please use #' to quote function names. > Sure! Is this okay? Theo --=-=-= Content-Type: text/x-diff Content-Disposition: attachment; filename=0001-Use-p-in-interactive-form-in-transpose-chars.patch >From 21cabdb2779caa55a53c972150d9bee8a4ca14e5 Mon Sep 17 00:00:00 2001 From: Theodor Thornhill Date: Sat, 17 Dec 2022 13:14:22 +0100 Subject: [PATCH] Use *p in interactive form in transpose-chars * lisp/simple.el (transpose-chars): Use '*p' instead of '*P' like the other transpose-* functions. --- lisp/simple.el | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/lisp/simple.el b/lisp/simple.el index b3174eef7d..69a7189a35 100644 --- a/lisp/simple.el +++ b/lisp/simple.el @@ -8423,12 +8423,12 @@ transpose-chars "Interchange characters around point, moving forward one character. With prefix arg ARG, effect is to take character before point and drag it forward past ARG other characters (backward if ARG negative). -If no argument and at end of line, the previous two chars are exchanged." - (interactive "*P") - (when (and (null arg) (eolp) (not (bobp)) +If at end of line, the previous two chars are exchanged." + (interactive "*p") + (when (and (eolp) (not (bobp)) (not (get-text-property (1- (point)) 'read-only))) (forward-char -1)) - (transpose-subr 'forward-char (prefix-numeric-value arg))) + (transpose-subr #'forward-char arg)) (defun transpose-words (arg) "Interchange words around point, leaving point at end of them. -- 2.34.1 --=-=-=-- From unknown Tue Aug 19 01:58:40 2025 X-Loop: help-debbugs@gnu.org Subject: bug#60157: 30.0.50; [PATCH]: Change interactive form in transpose-chars Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 25 Dec 2022 01:12:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60157 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Theodor Thornhill Cc: 60157@debbugs.gnu.org, Eli Zaretskii Received: via spool by 60157-submit@debbugs.gnu.org id=B60157.167193070123120 (code B ref 60157); Sun, 25 Dec 2022 01:12:02 +0000 Received: (at 60157) by debbugs.gnu.org; 25 Dec 2022 01:11:41 +0000 Received: from localhost ([127.0.0.1]:47355 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p9FYC-00060p-LR for submit@debbugs.gnu.org; Sat, 24 Dec 2022 20:11:40 -0500 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:17887) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p9FYB-00060V-FX for 60157@debbugs.gnu.org; Sat, 24 Dec 2022 20:11:39 -0500 Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id CAB808087E; Sat, 24 Dec 2022 20:11:33 -0500 (EST) Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 6205380068; Sat, 24 Dec 2022 20:11:32 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1671930692; bh=0hsc6Ts5Q8qIPVA1Vm3NkGfzvOqWFvolVU6cYIhyKMo=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=PJr1d0Ahd4rEBjECCoO5REXNREzjx0Uvm9Mhhz3ZKw+Ckp09P/+JgL52esALOpR5D FiPLpok44F6T0EzXYLdvCUyL8yAv6GREYshoVaQcZQPQgxZ0dPxWgta9dcG0BFq52L ZQ+W13Ey0Tym5hZaVV6KyrLwmd4gnwThQSPHNZsespYfpNxvSNKGvQNZTlncAOCl4t W6jYwVzN+yCO6/kX54/yFfJHoWnJ2WUUEfuntlFDx1IPy15A9tORze3SO+3OfaIUAM Dt2mDAxKz3+Nz33DPG75gw0CynVRiK3XjEE5d3+h3gP8tzsBcOfjx0olRSUQwziZeR tdQrGnPFfaiHQ== Received: from pastel (unknown [45.72.200.228]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 37A65120321; Sat, 24 Dec 2022 20:11:32 -0500 (EST) From: Stefan Monnier In-Reply-To: <87mt7cr502.fsf@thornhill.no> (Theodor Thornhill's message of "Sat, 24 Dec 2022 20:11:41 +0100") Message-ID: References: <87k02qte06.fsf@thornhill.no> <83y1qx5lp8.fsf@gnu.org> <87mt7cr502.fsf@thornhill.no> Date: Sat, 24 Dec 2022 20:11:31 -0500 User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL -0.319 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Is this okay? The code is OK. I don't understand the motivation behind the change, tho. Stefan From unknown Tue Aug 19 01:58:40 2025 X-Loop: help-debbugs@gnu.org Subject: bug#60157: 30.0.50; [PATCH]: Change interactive form in transpose-chars Resent-From: Theodor Thornhill Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 25 Dec 2022 07:38:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60157 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Stefan Monnier Cc: 60157@debbugs.gnu.org, Eli Zaretskii Received: via spool by 60157-submit@debbugs.gnu.org id=B60157.167195386022124 (code B ref 60157); Sun, 25 Dec 2022 07:38:01 +0000 Received: (at 60157) by debbugs.gnu.org; 25 Dec 2022 07:37:40 +0000 Received: from localhost ([127.0.0.1]:47478 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p9LZj-0005km-Pd for submit@debbugs.gnu.org; Sun, 25 Dec 2022 02:37:40 -0500 Received: from out2.migadu.com ([188.165.223.204]:23568) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p9LZi-0005ke-25 for 60157@debbugs.gnu.org; Sun, 25 Dec 2022 02:37:39 -0500 Date: Sun, 25 Dec 2022 08:36:03 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=thornhill.no; s=key1; t=1671953857; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=E10E1oOJ2zt2h5yeyhWGIKnSqLLXYQOCuBKUHKg5xJ8=; b=g1TOdoNrGE4mASaMYauIPVOne4mmhTV0/1tQYnQfdyIf2aOpJTK6AboJnzWrmVE9JgeKRl /TLl5323V7GyO1iYE58ulxvqR8+1lt9Hvh5a9f65/F3F+4ytzCAdk416NKQaudE0vtSrpi oc2t9CkxVI22dAZRehv5+pYDn3pdap4z5K3KmVEEbjq/nqrz/zXc5mIQ6aXoFprVcDUAi+ QY20ILhDNAJp5CWD7A9YTN2qOQEc75q79U2Pzp1jjaEhCyZh/3h6Hb6X7o4+aQNuYfSjDh hj0yr/IGZmlH8Yfl9CxR9EPmJh9y0GM+34jwfgMCWHXgG0dqqVqe1KALWQhEIQ== X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Theodor Thornhill In-Reply-To: References: <87k02qte06.fsf@thornhill.no> <83y1qx5lp8.fsf@gnu.org> <87mt7cr502.fsf@thornhill.no> Message-ID: <73186582-AE99-4A2F-98CF-E1FCF78EB3AC@thornhill.no> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Migadu-Flow: FLOW_OUT X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On 25 December 2022 02:11:31 CET, Stefan Monnier wrote: >> Is this okay? > >The code is OK=2E >I don't understand the motivation behind the change, tho=2E > > > Stefan > Mostly uniformity with surrounding code and housekeeping, but if such chan= ges are unwanted, I'm fine with that too=2E Theo From debbugs-submit-bounces@debbugs.gnu.org Mon Sep 04 11:11:50 2023 Received: (at control) by debbugs.gnu.org; 4 Sep 2023 15:11:50 +0000 Received: from localhost ([127.0.0.1]:52225 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qdBF0-0008DK-9w for submit@debbugs.gnu.org; Mon, 04 Sep 2023 11:11:50 -0400 Received: from mail-lf1-x134.google.com ([2a00:1450:4864:20::134]:61926) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qdBEy-0008D4-Nj for control@debbugs.gnu.org; Mon, 04 Sep 2023 11:11:49 -0400 Received: by mail-lf1-x134.google.com with SMTP id 2adb3069b0e04-5007616b756so2651621e87.3 for ; Mon, 04 Sep 2023 08:11:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1693840303; x=1694445103; darn=debbugs.gnu.org; h=to:subject:message-id:date:mime-version:from:from:to:cc:subject :date:message-id:reply-to; bh=9KvyfXPEu7FuveK8BBxe5wp5Gf99gGQGgzKlKdfVJ8k=; b=j8CS/n2Y8Pv1q312hiwAHAZ9E9lFjAlVYnJ3wzsie9AswYaVxllMdt5DsEQqxShOUt zyM8CYezV3DFvCOtS/yhHBXnjR7FMRViS8LuT9bf6kSw6CLDpH0FjSO2XPV+5wxZ8nXx bsEc3ZUcsxgcQHApzSAI+ZqHyPW5TsaYI1S4K7IDVuYFpDgNWKzIOKLPuzyGLVAqDtV0 9TeHf2TuiP95YMMjUyKrvi3rzEd472XI6hDSs7MmRXfRLD4BIK+AsT2kq2ao3UNxuhCt uFYq7/FAsm049Roj8PwILfEBSxhMwTCNdup5tVRlrZtju51De1ll45Ogk9lo1fd5SEQ/ grNA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693840303; x=1694445103; h=to:subject:message-id:date:mime-version:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=9KvyfXPEu7FuveK8BBxe5wp5Gf99gGQGgzKlKdfVJ8k=; b=jDUxoU+FkUmkZub9r9W9GCwgbCnOiWBWpKcNUgoApovdviuedS5Tku5el7WFnzU3YX WHC5oA915JTHSxLQQ8tv67DVHLZ0e3gvwUYtDPhuHALmi1noSSZJmaw8uPSnOr2fDIt6 nqcG8pIaxZu63ywHPh+pwGgR+pVYFBDqgu69NCSuNP8U4C5v1DluOaLqW6a2nKnPfSbi aA8aKD4bdEO5UR0EEUpnGz+ozrsMhl5BTq186iRyVjuBJyTB9kMLadHIlF6eOfeCYK/W 0Fer9teQZURuldULLBW8SOdT6rZRsAa2+/3FKzgDRHHeMZrgmD5yS7rfR3RERc4Gomor r9vw== X-Gm-Message-State: AOJu0YwJ1cdNO/FYxOIJbHC+YUL6OTcZ42lMtjNXNfErF9HWzo3DGpKy 3iFxlsnlvjXVVcVpX4boL9ass5bzd1vt/ji8NPIluyyd X-Google-Smtp-Source: AGHT+IGnw7WuYWwW+yfMQ9An+GKPUw89LVs+cX94cOws+//DisQBd59maz11YhCAG1OWfce3pjOlogQBtmgKLya0SzM= X-Received: by 2002:a05:6512:10c7:b0:500:cb2b:8678 with SMTP id k7-20020a05651210c700b00500cb2b8678mr8511013lfg.40.1693840302633; Mon, 04 Sep 2023 08:11:42 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Mon, 4 Sep 2023 08:11:42 -0700 From: Stefan Kangas MIME-Version: 1.0 Date: Mon, 4 Sep 2023 08:11:42 -0700 Message-ID: Subject: control message for bug #60157 To: control@debbugs.gnu.org Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) severity 60157 wishlist quit From unknown Tue Aug 19 01:58:40 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Theodor Thornhill Subject: bug#60157: closed (Re: bug#60157: 30.0.50; [PATCH]: Change interactive form in transpose-chars) Message-ID: References: <87k02qte06.fsf@thornhill.no> X-Gnu-PR-Message: they-closed 60157 X-Gnu-PR-Package: emacs X-Gnu-PR-Keywords: patch Reply-To: 60157@debbugs.gnu.org Date: Wed, 06 Sep 2023 07:09:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1693984142-10555-1" This is a multi-part message in MIME format... ------------=_1693984142-10555-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #60157: 30.0.50; [PATCH]: Change interactive form in transpose-chars which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 60157@debbugs.gnu.org. --=20 60157: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D60157 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1693984142-10555-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 60157-done) by debbugs.gnu.org; 6 Sep 2023 07:08:14 +0000 Received: from localhost ([127.0.0.1]:60664 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qdme5-0002jD-Or for submit@debbugs.gnu.org; Wed, 06 Sep 2023 03:08:14 -0400 Received: from mail-lf1-x132.google.com ([2a00:1450:4864:20::132]:46149) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qdme3-0002iz-RD for 60157-done@debbugs.gnu.org; Wed, 06 Sep 2023 03:08:12 -0400 Received: by mail-lf1-x132.google.com with SMTP id 2adb3069b0e04-5007c8308c3so5328969e87.0 for <60157-done@debbugs.gnu.org>; Wed, 06 Sep 2023 00:08:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1693984085; x=1694588885; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:from:to:cc:subject:date:message-id:reply-to; bh=yVZHNAIn29AXz93M4SH79IsXTVCzgq10mjn1NzFpUjY=; b=CSRWY+nj5wc8VN2Vw7WNJfysISXxCFd+mvFvJrhP4rFqdwBK3Y5GTq657Uso93/NxR bDYrAdKBCPL4HGjp8lEEE7l4CtMIFfHd74kQtrH/JMidxzvUWY5rM/P888yER3K2obVO O1ZkO7bP9U3nKGWVAjzksz9EkTxV93euCloo2sJVAfbQ/egCjhHKOvQjS8aHKOtM5fye JXgcZlyfERWcIZjuAtoQxoBXsNA64IVwW+zGPXBpaLpUTmlsizhsXxg66p0gh8tP8ohU BvAVNpo5MAvkDy/OfBDLhHAW/YgEVhou+bIzWv9hD7LTzFKHjIXs+3yGzC0aBoZztDzd wObA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693984085; x=1694588885; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=yVZHNAIn29AXz93M4SH79IsXTVCzgq10mjn1NzFpUjY=; b=XGgbnblFaAIztrDLCV6hrkx+qYVWYeuGpolkqF8dixKLgsUoAEJVQsX52vcAYtCkIC 9Y06O1A5YuGArfJaDKNDnApKGc4qiAaj7uRwOobI2qlzpzP3eBPbitXR06iMXvAjH7F9 r48X/McQfAX4sIvbSz8TBMSXyYT5J2gk1/GIeMqcgoEb/Huji95ixNfKU0tqQxzIbYQO oeEQYX+xM8LlvsrlcCUByAPLz8ZjzV15uNszdJAsmjFRl12Aw8BRzvEj88F/AdmCu664 f8m8B5fbY78iqK/IaYcjzz3G9nX0gpnwEYJC+ZGbf/beDFSxvUeMKwBGzuHexuCWDOIp LPxw== X-Gm-Message-State: AOJu0YyjAfGtEC35f8WcqlvSRWlUKPU2YUrN17UiU7E9OuQ9s+x/ImPh 0+k7oOzV2eTm86PduYkqxrZ6DZyXLEr7/3UKbnI= X-Google-Smtp-Source: AGHT+IEBxToORyCigvZy30TL1N6imk5YChgK03IC55b9jRacBNiqPCfLZkcm1MvGA3eBvSVO4OILSCMCwTvRGYrgObE= X-Received: by 2002:a19:5f16:0:b0:500:91c1:9642 with SMTP id t22-20020a195f16000000b0050091c19642mr1469872lfb.21.1693984084753; Wed, 06 Sep 2023 00:08:04 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Wed, 6 Sep 2023 00:08:04 -0700 From: Stefan Kangas In-Reply-To: <73186582-AE99-4A2F-98CF-E1FCF78EB3AC@thornhill.no> (Theodor Thornhill's message of "Sun, 25 Dec 2022 08:36:03 +0100") References: <87k02qte06.fsf@thornhill.no> <83y1qx5lp8.fsf@gnu.org> <87mt7cr502.fsf@thornhill.no> <73186582-AE99-4A2F-98CF-E1FCF78EB3AC@thornhill.no> MIME-Version: 1.0 Date: Wed, 6 Sep 2023 00:08:04 -0700 Message-ID: Subject: Re: bug#60157: 30.0.50; [PATCH]: Change interactive form in transpose-chars To: Theodor Thornhill Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 60157-done Cc: 60157-done@debbugs.gnu.org, Eli Zaretskii , Stefan Monnier X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Version: 30.1 Theodor Thornhill writes: > On 25 December 2022 02:11:31 CET, Stefan Monnier wrote: >>> Is this okay? >> >>The code is OK. >>I don't understand the motivation behind the change, tho. >> > > Mostly uniformity with surrounding code and housekeeping, but if such changes are unwanted, I'm fine with that too. No further comments within 9 months. Pushed to master as commit 4ac83ee105a. Closing. ------------=_1693984142-10555-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 17 Dec 2022 12:24:03 +0000 Received: from localhost ([127.0.0.1]:55616 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p6WEV-0006Iq-9x for submit@debbugs.gnu.org; Sat, 17 Dec 2022 07:24:03 -0500 Received: from lists.gnu.org ([209.51.188.17]:40818) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p6WEU-0006Ik-1I for submit@debbugs.gnu.org; Sat, 17 Dec 2022 07:24:02 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p6WET-0001Rm-PK for bug-gnu-emacs@gnu.org; Sat, 17 Dec 2022 07:24:01 -0500 Received: from out-217.mta0.migadu.com ([91.218.175.217]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p6WEQ-0007OI-Sd for bug-gnu-emacs@gnu.org; Sat, 17 Dec 2022 07:24:01 -0500 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=thornhill.no; s=key1; t=1671279835; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type; bh=IzT8rbmzUXDLMuND8yjw8gcxQEymVw000B1q9x3IjoA=; b=RWp7C+B9YAfiyEcBZYCevOMEqIDbaiybF5T2R6kcDE3GqtwZpBGtNa9uPiM8Tn8hzMt94u 2TAYusnAeyoFZ4e1inR6+TjKbs6xPnDYrph2xttNabTArNE+ye25co7wk61Fgd8d+9zsv5 BemIROeve+aWy27ldTEoTjWp3NLaENu0k6zGeoLlKIKy2GWYN09wI3ERvzmAxhdCCGoa6q xlZtlnZreyfktgcXKX2mN/ri0f9vAAMqXCOr0wOp4tTiMXRNWJUnGH/fWwjGqNj5udg9Im /cwL/uiOsO58d4FkZB4EPtWj9Ae0FhkDbsVa6CjFx0b4eEH5SCL4xndzbHPwXQ== From: Theodor Thornhill To: bug-gnu-emacs@gnu.org Subject: 30.0.50; [PATCH]: Change interactive form in transpose-chars X-Debbugs-Cc: monnier@iro.umontreal.ca, eliz@gnu.org Date: Sat, 17 Dec 2022 13:23:53 +0100 Message-ID: <87k02qte06.fsf@thornhill.no> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Migadu-Flow: FLOW_OUT Received-SPF: pass client-ip=91.218.175.217; envelope-from=theo@thornhill.no; helo=out-217.mta0.migadu.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) --=-=-= Content-Type: text/plain Hi Stefan and Eli! As a part of my investigation into transposing things using tree-sitter I promised to also introduce some improvements to both the code and documentation, as the latter is a little sparse. I'll add some patches while I work on the tree-sitter stuff. This commit simplifies the transpose-chars. The bug described in the commit history is no longer reproducible, so I think its complicated nature can be removed. What do you think? Theo --=-=-= Content-Type: text/x-diff Content-Disposition: attachment; filename=0001-Use-p-in-interactive-form-in-transpose-chars.patch >From f7d98eb478b9d10c15e6b2d168049e65fcd3c448 Mon Sep 17 00:00:00 2001 From: Theodor Thornhill Date: Sat, 17 Dec 2022 13:14:22 +0100 Subject: [PATCH] Use *p in interactive form in transpose-chars There are two changes in this commit. The first one is removal of an obsolete guard against moving into read-only text, as described in bug#17829. The second is a simplification of the code to make it more similar to its sibling commands. We can convert the prefix into a number immediately, rather than later. * lisp/simple.el (transpose-chars): Use '*p' instead of '*P' like the other transpose-* functions. --- lisp/simple.el | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/lisp/simple.el b/lisp/simple.el index dcc2242e49..bde65d96f1 100644 --- a/lisp/simple.el +++ b/lisp/simple.el @@ -8421,11 +8421,8 @@ transpose-chars With prefix arg ARG, effect is to take character before point and drag it forward past ARG other characters (backward if ARG negative). If no argument and at end of line, the previous two chars are exchanged." - (interactive "*P") - (when (and (null arg) (eolp) (not (bobp)) - (not (get-text-property (1- (point)) 'read-only))) - (forward-char -1)) - (transpose-subr 'forward-char (prefix-numeric-value arg))) + (interactive "*p") + (transpose-subr 'forward-char arg)) (defun transpose-words (arg) "Interchange words around point, leaving point at end of them. -- 2.34.1 --=-=-=-- ------------=_1693984142-10555-1--