From unknown Fri Aug 15 16:22:19 2025 X-Loop: help-debbugs@gnu.org Subject: bug#60146: file-exists-in-trash-p needs better name or semantics Resent-From: Paul Eggert Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 17 Dec 2022 05:18:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 60146 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 60146@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.16712542498549 (code B ref -1); Sat, 17 Dec 2022 05:18:01 +0000 Received: (at submit) by debbugs.gnu.org; 17 Dec 2022 05:17:29 +0000 Received: from localhost ([127.0.0.1]:53799 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p6PZh-0002Dp-As for submit@debbugs.gnu.org; Sat, 17 Dec 2022 00:17:29 -0500 Received: from lists.gnu.org ([209.51.188.17]:53042) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p6PZZ-0002De-Pu for submit@debbugs.gnu.org; Sat, 17 Dec 2022 00:17:26 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p6PZZ-0001WO-Ef for bug-gnu-emacs@gnu.org; Sat, 17 Dec 2022 00:17:21 -0500 Received: from zimbra.cs.ucla.edu ([131.179.128.68]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p6PZX-0004WN-Da for bug-gnu-emacs@gnu.org; Sat, 17 Dec 2022 00:17:21 -0500 Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id EBA4A160040 for ; Fri, 16 Dec 2022 21:17:15 -0800 (PST) Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id 0JW2RfHhOK1K for ; Fri, 16 Dec 2022 21:17:15 -0800 (PST) Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 374BD160070 for ; Fri, 16 Dec 2022 21:17:15 -0800 (PST) DKIM-Filter: OpenDKIM Filter v2.9.2 zimbra.cs.ucla.edu 374BD160070 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cs.ucla.edu; s=78364E5A-2AF3-11ED-87FA-8298ECA2D365; t=1671254235; bh=wnE+KPWCrtGTiyqYDshZhZ1LFY1vKjx2Ye6pLW60WXg=; h=Message-ID:Date:MIME-Version:To:From:Subject:Content-Type: Content-Transfer-Encoding; b=PB1H46wk0QSRSP2YhKOa6JpMdpFCZAhhgz+A/3tS477afwHajyUHbsOoLoonaheJf HjlDSNzoQ/e4SdQod69YP64YX5lbezmfK/h5tchyKz4AjwqzRjY9mSvaRgNLRjIshl LJ3C29G9GkN3axdELtG4hy5jhWT0DNCySj2LzCVo= X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id fjmFJvYDrcZp for ; Fri, 16 Dec 2022 21:17:15 -0800 (PST) Received: from [100.115.92.201] (cpe-172-91-119-151.socal.res.rr.com [172.91.119.151]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id 0984F160040 for ; Fri, 16 Dec 2022 21:17:15 -0800 (PST) Message-ID: Date: Fri, 16 Dec 2022 21:17:13 -0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Content-Language: en-US From: Paul Eggert Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=131.179.128.68; envelope-from=eggert@cs.ucla.edu; helo=zimbra.cs.ucla.edu X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.6 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.6 (--) The recently-added function (file-exists-in-trash-p FILE) is poorly named since it's not really related to trash - it's simply checking for the existence of a directory entry named FILE. How about extending file-exists-p instead? (file-exists-p FILE t) would be like (file-exists-p FILE) except it would not follow symlinks. This extension can be implemented via a single system call on POSIX systems, and this would be more efficient and would avoid a race in the current implementation of file-exists-in-trash-p. (Though of course pretty much any use of this new function makes one vulnerable to races....) If extending file-exists-p is too much, at least please rename file-exists-in-trash-p to something like files--exists-nofollow-p, to indicate that it's private to files.el and to say better what it means. From unknown Fri Aug 15 16:22:19 2025 X-Loop: help-debbugs@gnu.org Subject: bug#60146: file-exists-in-trash-p needs better name or semantics Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 17 Dec 2022 08:48:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60146 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Paul Eggert , Lars Ingebrigtsen , Stefan Monnier Cc: 60146@debbugs.gnu.org Received: via spool by 60146-submit@debbugs.gnu.org id=B60146.167126687418767 (code B ref 60146); Sat, 17 Dec 2022 08:48:01 +0000 Received: (at 60146) by debbugs.gnu.org; 17 Dec 2022 08:47:54 +0000 Received: from localhost ([127.0.0.1]:54660 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p6SrJ-0004sb-Fo for submit@debbugs.gnu.org; Sat, 17 Dec 2022 03:47:53 -0500 Received: from eggs.gnu.org ([209.51.188.92]:60336) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p6SrE-0004rk-Sm for 60146@debbugs.gnu.org; Sat, 17 Dec 2022 03:47:52 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p6Sr8-0003Zd-Cr; Sat, 17 Dec 2022 03:47:42 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=lXbdB2AAw13qbulhbxe3WEkbEuu4Ftohx8VDmOvIn7w=; b=cqAOBEgKyfMF 0cggeMajAmGEHJruwtZR9lbdd0IltMVyqWtgpREbM/XZMCVocjMJe4zYdMzqNlYdKpmUPv8q+KKMG 7ZHgQeYENaWz3bTWPDS0/KSZpskxi3u1XG0Hm2DLjPBzoYEPznJ4r7N3+5zVMDativ9PM4XXEF+Gt PiqirNln23W1pg7RB/Bdjpj20kOhIqgwyEB7tQhexdlV80liW0nbJvDMm5xRjLgXPuL04PIfTqPjs VuQTPJTOpLpNG6Qvg5EBNQig/UBKGn2YWiBkuJZTOq+GyLPOeKqjGniG2Llhh9UjjBIhubY0r/t5u GKERYMdSWGJFvtIgHCCPsQ==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p6Sr7-0005jN-GG; Sat, 17 Dec 2022 03:47:41 -0500 Date: Sat, 17 Dec 2022 10:47:45 +0200 Message-Id: <83a63mifgu.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: (message from Paul Eggert on Fri, 16 Dec 2022 21:17:13 -0800) References: X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Fri, 16 Dec 2022 21:17:13 -0800 > From: Paul Eggert > > The recently-added function (file-exists-in-trash-p FILE) is poorly > named since it's not really related to trash - it's simply checking for > the existence of a directory entry named FILE. > > How about extending file-exists-p instead? (file-exists-p FILE t) would > be like (file-exists-p FILE) except it would not follow symlinks. This > extension can be implemented via a single system call on POSIX systems, > and this would be more efficient and would avoid a race in the current > implementation of file-exists-in-trash-p. (Though of course pretty much > any use of this new function makes one vulnerable to races....) > > If extending file-exists-p is too much, at least please rename > file-exists-in-trash-p to something like files--exists-nofollow-p, to > indicate that it's private to files.el and to say better what it means. I don't really mind renaming that function, but the reason I called it like I did was that apparently no one needed such a functionality in Emacs until now, except in this obscure use case of moving to trash. That seems to tell me that extending file-exists-p would be a solution waiting for the problem, something that we don't like doing. In any case, if we do decide to extend file-exists-p, it would need to be done on master, as that is not a trivial change, which has to be done in C. Lars, Stefan, WDYT? From unknown Fri Aug 15 16:22:19 2025 X-Loop: help-debbugs@gnu.org Subject: bug#60146: file-exists-in-trash-p needs better name or semantics Resent-From: Michael Albinus Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 17 Dec 2022 10:02:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60146 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Paul Eggert Cc: 60146@debbugs.gnu.org Received: via spool by 60146-submit@debbugs.gnu.org id=B60146.167127130922596 (code B ref 60146); Sat, 17 Dec 2022 10:02:02 +0000 Received: (at 60146) by debbugs.gnu.org; 17 Dec 2022 10:01:49 +0000 Received: from localhost ([127.0.0.1]:54966 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p6U0r-0005sO-7o for submit@debbugs.gnu.org; Sat, 17 Dec 2022 05:01:49 -0500 Received: from mout.gmx.net ([212.227.15.19]:50349) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p6U0o-0005sD-KR for 60146@debbugs.gnu.org; Sat, 17 Dec 2022 05:01:47 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.de; s=s31663417; t=1671271297; bh=bSjDBymoTy5asfSHCel9PU7jprzYtVsfMmarfdGRI5w=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date; b=DWbVaLcrKJH58GMTQdHsZVwtcb42+adEZw9gg4C8K3OMiS9ex8Wa3gSnDJE4vAUT3 j3Kb/aJTtR1YSJarQoXGKgMs2YElfsC93zQWAniJBPgxptVQqCnY86DF2XUPepU/eF yIUfM4bnJ3wVVuTM1nu1zPkvgJRj/ytxtLJEEEGPZsPSzfXxRKPUfWizYtWfqZvPxa +OZoQvU9Xvio4elbGjBht9rRwakuc99ZVfuFf+NwwYmMKiDb3LzrsarIttHtqyOWIS /y3yeseBcPWpDnbERKs5mGCBg4E849W1ZzP059aTDFBIK4ZJV20X9HsoEch+pbtpRq uETxBIOV6aZ9A== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from gandalf.gmx.de ([185.89.39.11]) by mail.gmx.net (mrgmx005 [212.227.17.190]) with ESMTPSA (Nemesis) id 1MmUHj-1ofhmT3wif-00iVva; Sat, 17 Dec 2022 11:01:37 +0100 From: Michael Albinus In-Reply-To: (Paul Eggert's message of "Fri, 16 Dec 2022 21:17:13 -0800") References: Date: Sat, 17 Dec 2022 11:01:35 +0100 Message-ID: <87tu1u9wn4.fsf@gmx.de> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:PCzALNDBQWkeIAsqb1bvTjupCqmk2DatgGb4iN6ej16CBv/bND4 yGTB/zdNUe/zlJgLLoPlDTCGlReWsVvpQ5d3FZuqqQvAPlIy+i8jbHScmXnywYT93JEoVvz rPWWL/c5zamWkbFIMks77f0FcWLMpQei5Oxy2ery+3nVFrfeM6dM8yD5LrvQkfajyiiJPVn YmSfoRzCRoDPyujeKXfPA== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:56axsXrT5Qs=;c5uaeT5j3MWiqL3zxmVR04PzmYc 8H1mf3+b0w9txfuglMlQonUc8YmnmqqYwosUPYknr0dlg3gpa4yFyrS5cVkII/IKu7Ofqu894 jeXgQ5tzXYdWA+BoxgaNxeLpVNfYq0NtQ5r1j8Srk2PMRUozvRDD2llXDdnWJzmVC1QFLQ8ka dDXXrrJxmSqQyAUpCo9n9I7ccILWfQxfjCTpwkxPHpXhXUkZi+oiMo8RxQP/yvTjtMqZcGOmN 8pvUE8EpUWzt9gks54xuSQ7NBVLLHT16nXyMKX+OZJMMUQvsuvICyiIQ3oMrhsxL8MfDHNNVO ZVLTolrKueuuRhmAdIBXYMkkRt04CQE48lOmPPHNSxI4hV3RITQ0HvBG4TAi/hNnNf5LlEFUH LSEkLJ/v6CIFQ/2NhPOxF/FZSRHkD8/L4vsCWJUrD/I/FEca2rmjSbGxGfy3op+87hXmgQohH Ri9xrYeHoJpvlE2Akbn1BjDUvVfxmt5Hi3BpYAEqxRsFYJWOJ8zPdriU5JkU7XJacR4qE11x8 zQf16kCwTVRZLA1XtgxA9auN5n7shebOMe49TsJINOyf6yZ/321QaCMGZzcpSCjD0PCVIiUwd 6twU1U2AKOaIdwoS3Grn+KE6G6plPuQgSmGcgXSTHbGDTC3zyQUiVINEczNCAKv4I1An3dyMs uX6b+aT4rrRlJMTLVsgauA3tNRjZwS6HDrfZcPkvMstc5p+K3O5MQAORiXUz7mQrKr3v4ZXzw X2vMGz2P3Bq+ObJjEgAPHRtRXKDF1a9wwlkhmprCmLsYxJssCV8CwjYMWosDq+VFgbvEi8VJ1 Tg2Bo4p4Z+0DV84BN93s1QmDPiG953I/zeT/6/IPFP9v+GsLc90rDWCk4F5M7gPbXcbD+9kqW be+nwDlLQ3wBWDbduPtG5SFWB7rhnLPQHSPG7g4mOSKKXKaDauZbEGGsjBGYKrXDcj6z4Gh3R KaH71w== X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Paul Eggert writes: Hi Paul, > How about extending file-exists-p instead? (file-exists-p FILE t) > would be like (file-exists-p FILE) except it would not follow > symlinks. This extension can be implemented via a single system call > on POSIX systems, and this would be more efficient and would avoid a > race in the current implementation of file-exists-in-trash-p. (Though > of course pretty much any use of this new function makes one > vulnerable to races....) Pls don't do it in the emacs-29 branch. file-exists-p checks for file name handlers, with all consequences for a changed signature. Best regards, Michael. From unknown Fri Aug 15 16:22:19 2025 X-Loop: help-debbugs@gnu.org Subject: bug#60146: file-exists-in-trash-p needs better name or semantics Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 17 Dec 2022 15:52:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60146 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii Cc: Lars Ingebrigtsen , Paul Eggert , 60146@debbugs.gnu.org Received: via spool by 60146-submit@debbugs.gnu.org id=B60146.16712923099018 (code B ref 60146); Sat, 17 Dec 2022 15:52:01 +0000 Received: (at 60146) by debbugs.gnu.org; 17 Dec 2022 15:51:49 +0000 Received: from localhost ([127.0.0.1]:56568 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p6ZTZ-0002LO-8F for submit@debbugs.gnu.org; Sat, 17 Dec 2022 10:51:49 -0500 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:3309) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p6ZTX-0002LI-S5 for 60146@debbugs.gnu.org; Sat, 17 Dec 2022 10:51:48 -0500 Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 7F04F81358; Sat, 17 Dec 2022 10:51:42 -0500 (EST) Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 2085C80853; Sat, 17 Dec 2022 10:51:41 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1671292301; bh=yzSwpJeCGMDXjqO8UvORT8CRYw3MF7LCdcF6U9h2N+k=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=XufZ876kCQwmhjyWc5t7EGDUDh3E2N19V/09aeCwVaNU7jn4bvYevflRd4ZMahIs1 Q7HkxT6bgNBj/BrdvpMYv3178aQcEoMYv7Vz/q5ttAcf343lXU6Y8w9HHrcV4qjUPN mu6By4lvr/A4KpJqmV+Ce2U8D+mOramtVWpOx0g9lNFzJ0EHEAmmZ01k9fC93RwtNW a2xD0mhYmCO6WG88ocn3wOv6JUX5YeQkDPmzEnVH1brNNvYXvGRpUHn0WR4LAa2+1H PNH3Eto1qmBn8bcuoLLgMSzknoK9PQO7rCIuyJ6Dq7DKj2uJVT2a6fylo/9A02Llo5 wOvu+nMgfkhjw== Received: from pastel (unknown [45.72.193.52]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id B5AC912022B; Sat, 17 Dec 2022 10:51:40 -0500 (EST) From: Stefan Monnier In-Reply-To: <83a63mifgu.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 17 Dec 2022 10:47:45 +0200") Message-ID: References: <83a63mifgu.fsf@gnu.org> Date: Sat, 17 Dec 2022 10:51:38 -0500 User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL -0.324 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > I don't really mind renaming that function, but the reason I called it > like I did was that apparently no one needed such a functionality in > Emacs until now, except in this obscure use case of moving to trash. > That seems to tell me that extending file-exists-p would be a solution > waiting for the problem, something that we don't like doing. Hmm... arguing about names, eh? Let me throw that hat into the ring: IIUC this is a variant of `file-exists-p` (currently) used only when dealing the trash, so I'd call it `trash--file-exists-p`. > In any case, if we do decide to extend file-exists-p, it would need to > be done on master, as that is not a trivial change, which has to be > done in C. Indeed, I see no need for that on emacs-29. Stefan From unknown Fri Aug 15 16:22:19 2025 X-Loop: help-debbugs@gnu.org Subject: bug#60146: file-exists-in-trash-p needs better name or semantics Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 17 Dec 2022 17:46:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60146 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Stefan Monnier Cc: larsi@gnus.org, eggert@cs.ucla.edu, 60146@debbugs.gnu.org Received: via spool by 60146-submit@debbugs.gnu.org id=B60146.167129911825569 (code B ref 60146); Sat, 17 Dec 2022 17:46:02 +0000 Received: (at 60146) by debbugs.gnu.org; 17 Dec 2022 17:45:18 +0000 Received: from localhost ([127.0.0.1]:57122 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p6bFN-0006dC-LM for submit@debbugs.gnu.org; Sat, 17 Dec 2022 12:45:17 -0500 Received: from eggs.gnu.org ([209.51.188.92]:43674) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p6bFM-0006MA-TP for 60146@debbugs.gnu.org; Sat, 17 Dec 2022 12:45:17 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p6bFF-0005VU-S7; Sat, 17 Dec 2022 12:45:10 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=4dqp3Yr4D8T+9juuV6nhT+QS/b2hilhd0Oau3fOzXR0=; b=XET1edaPJizy Mf3CkZuNDnOJvLeVbQ8D9X7GRhhRV9V75/LbhA+dfVMVsOCy3gOVL8ofSJacNiKDxeaaLxuKhxK3s g5C3l8Sy4D8tFvW/pImn4yVh1Ffa/YFv5+o+t83X081VEIZiH6HSFvQoi9V345iOckyls5LNC1uUT PbPAufw0IrIIpwwrary657tYsKT31M7mm6eyH7zxD01ocI5uin6zRo17cYAbpIdW7XDPFY1g4UkIV PoiuHvwvOG1BpwHwWR9CoHxZ5cmkfcA062DxODDaNpz9cROY83i4S/aLl6tQKmEihIGUIGPLsUYNG uBjnnsC7prMW2MvlGd+jAQ==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p6bF2-0003Cs-Ah; Sat, 17 Dec 2022 12:45:03 -0500 Date: Sat, 17 Dec 2022 19:45:02 +0200 Message-Id: <83fsddhqld.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: (message from Stefan Monnier on Sat, 17 Dec 2022 10:51:38 -0500) References: <83a63mifgu.fsf@gnu.org> X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Stefan Monnier > Cc: Paul Eggert , Lars Ingebrigtsen , > 60146@debbugs.gnu.org > Date: Sat, 17 Dec 2022 10:51:38 -0500 > > Let me throw that hat into the ring: IIUC this is a variant of > `file-exists-p` (currently) used only when dealing the trash, so I'd > call it `trash--file-exists-p`. Well, the function is defined in files.el, so starting the name with "trash" would be frowned upon... From unknown Fri Aug 15 16:22:19 2025 X-Loop: help-debbugs@gnu.org Subject: bug#60146: file-exists-in-trash-p needs better name or semantics Resent-From: Paul Eggert Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 17 Dec 2022 19:58:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60146 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii , Lars Ingebrigtsen , Stefan Monnier Cc: 60146@debbugs.gnu.org Received: via spool by 60146-submit@debbugs.gnu.org id=B60146.16713070694196 (code B ref 60146); Sat, 17 Dec 2022 19:58:02 +0000 Received: (at 60146) by debbugs.gnu.org; 17 Dec 2022 19:57:49 +0000 Received: from localhost ([127.0.0.1]:57711 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p6dJd-00015c-5Y for submit@debbugs.gnu.org; Sat, 17 Dec 2022 14:57:49 -0500 Received: from zimbra.cs.ucla.edu ([131.179.128.68]:52830) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p6dJb-00015S-J4 for 60146@debbugs.gnu.org; Sat, 17 Dec 2022 14:57:48 -0500 Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 4E9E1160090; Sat, 17 Dec 2022 11:57:41 -0800 (PST) Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id mTa8qT4cqBSA; Sat, 17 Dec 2022 11:57:39 -0800 (PST) Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id D4FD4160092; Sat, 17 Dec 2022 11:57:39 -0800 (PST) DKIM-Filter: OpenDKIM Filter v2.9.2 zimbra.cs.ucla.edu D4FD4160092 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cs.ucla.edu; s=78364E5A-2AF3-11ED-87FA-8298ECA2D365; t=1671307059; bh=6Slo/QRmRewAILMyYb99kJ24ATKRoADXngjnKlMabbw=; h=Content-Type:Message-ID:Date:MIME-Version:Subject:To:From; b=khUpkB93S8jamyg7KMjxhf/AcUc+JkH2CnBDEezGLaWoCEGylJKH7xzlaeLBIjNqZ VC21B1bkVfIQ8Cw54UHG5wYDMt7A7whFETsrosuf3WwN73O7fdCu8TnhcZr2rP8V2I LzlQ5YGoI48dbTPyN7TnPAmOKS7bKFNWiGhkTvgA= X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id VrfDw4_P4UVr; Sat, 17 Dec 2022 11:57:39 -0800 (PST) Received: from [192.168.86.236] (cpe-172-91-119-151.socal.res.rr.com [172.91.119.151]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id 80EDC160090; Sat, 17 Dec 2022 11:57:39 -0800 (PST) Content-Type: multipart/mixed; boundary="------------speWKBqJuzI0pLZskrhymeVl" Message-ID: <4b872c57-99fd-dc8c-a121-7f19be0f9d49@cs.ucla.edu> Date: Sat, 17 Dec 2022 11:57:39 -0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 References: <83a63mifgu.fsf@gnu.org> Content-Language: en-US From: Paul Eggert In-Reply-To: <83a63mifgu.fsf@gnu.org> X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) This is a multi-part message in MIME format. --------------speWKBqJuzI0pLZskrhymeVl Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 12/17/22 00:47, Eli Zaretskii wrote: > I don't really mind renaming that function, but the reason I called it > like I did was that apparently no one needed such a functionality in > Emacs until now, I have a bit of a different take. First, there's adequate functionality in Emacs now if we don't mind inefficiency, and it's already used; just call file-attributes. (Gnus does this, in nnmaildir-unlink at least, and I expect there are other uses.) Second, I wouldn't be surprised if other uses of file-exists-p have problems similar to the one you found in move-file-to-trash. Not that any of us have time to go scout for them right now. It's a minor point. Still, the name file-exists-in-trash-p really needs to go somehow as it's not a name that should be user-visible. How about the attached patch? --------------speWKBqJuzI0pLZskrhymeVl Content-Type: text/x-patch; charset=UTF-8; name="0001-Remove-file-exists-in-trash-p.patch" Content-Disposition: attachment; filename="0001-Remove-file-exists-in-trash-p.patch" Content-Transfer-Encoding: base64 RnJvbSBhZGNmMzExMmU3MjQzMWU0YzRhMjYxMDk0MWFmY2MyMzhlN2RkMjQzIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBQYXVsIEVnZ2VydCA8ZWdnZXJ0QGNzLnVjbGEuZWR1 PgpEYXRlOiBTYXQsIDE3IERlYyAyMDIyIDExOjU0OjQ2IC0wODAwClN1YmplY3Q6IFtQQVRD SF0gUmVtb3ZlIGZpbGUtZXhpc3RzLWluLXRyYXNoLXAKCiogbGlzcC9maWxlcy5lbCAoZmls ZS1leGlzdHMtaW4tdHJhc2gtcCk6IFJlbW92ZSwgYXMgdGhpcyBuYW1lIGlzCm5vdCBzdWl0 YWJsZSBmb3IgdXNlcnMuICBBbGwgdXNlcyByZXBsYWNlZCBieSBmaWxlLWF0dHJpYnV0ZXMs CndoaWNoIGlzIGdvb2QgZW5vdWdoIGhlcmUuCi0tLQogbGlzcC9maWxlcy5lbCB8IDE0ICsr Ky0tLS0tLS0tLS0tCiAxIGZpbGUgY2hhbmdlZCwgMyBpbnNlcnRpb25zKCspLCAxMSBkZWxl dGlvbnMoLSkKCmRpZmYgLS1naXQgYS9saXNwL2ZpbGVzLmVsIGIvbGlzcC9maWxlcy5lbApp bmRleCBjNzRlN2U4MDhlNC4uMTQ5NDgwYTZmMTAgMTAwNjQ0Ci0tLSBhL2xpc3AvZmlsZXMu ZWwKKysrIGIvbGlzcC9maWxlcy5lbApAQCAtODQ2NywxNCArODQ2Nyw2IEBAIHRyYXNoLS1o ZXhpZnktdGFibGUKIAogKGRlY2xhcmUtZnVuY3Rpb24gc3lzdGVtLW1vdmUtZmlsZS10by10 cmFzaCAidzMyZm5zLmMiIChmaWxlbmFtZSkpCiAKLShkZWZ1biBmaWxlLWV4aXN0cy1pbi10 cmFzaC1wIChmaWxlbmFtZSkKLSAgIlJldHVybiBub24tbmlsIGlmIEZJTEVOQU1FIGV4aXN0 cyBpbiB0aGUgdHJhc2guCi0KLVRoaXMgaXMgbGlrZSBgZmlsZS1leGlzdHMtcCcsIGJ1dCBp dCBhbHNvIHJldHVybnMgbm9uLW5pbAotaWYgRklMRU5BTUUgaXMgYSBkYW5nbGluZyBzeW1s aW5rLCB0byBhbGxvdyB0cmFzaGluZyBzdWNoIGZpbGVzLiIKLSAgKG9yIChmaWxlLWV4aXN0 cy1wIGZpbGVuYW1lKQotICAgICAgKGZpbGUtc3ltbGluay1wIGZpbGVuYW1lKSkpCi0KIChk ZWZ1biBtb3ZlLWZpbGUtdG8tdHJhc2ggKGZpbGVuYW1lKQogICAiTW92ZSB0aGUgZmlsZSAo b3IgZGlyZWN0b3J5KSBuYW1lZCBGSUxFTkFNRSB0byB0aGUgdHJhc2guCiBXaGVuIGBkZWxl dGUtYnktbW92aW5nLXRvLXRyYXNoJyBpcyBub24tbmlsLCB0aGlzIGZ1bmN0aW9uIGlzCkBA IC04NTA1LDcgKzg0OTcsNyBAQCBtb3ZlLWZpbGUtdG8tdHJhc2gKIAkgICAodW5sZXNzIChm aWxlLWRpcmVjdG9yeS1wIHRyYXNoLWRpcikKIAkgICAgIChtYWtlLWRpcmVjdG9yeSB0cmFz aC1kaXIgdCkpCiAJICAgOzsgRW5zdXJlIHRoYXQgdGhlIHRyYXNoZWQgZmlsZS1uYW1lIGlz IHVuaXF1ZS4KLQkgICAoaWYgKGZpbGUtZXhpc3RzLWluLXRyYXNoLXAgbmV3LWZuKQorCSAg IChpZiAoZmlsZS1hdHRyaWJ1dGVzIG5ldy1mbikKIAkgICAgICAgKGxldCAoKHZlcnNpb24t Y29udHJvbCB0KQogCQkgICAgIChiYWNrdXAtZGlyZWN0b3J5LWFsaXN0IG5pbCkpCiAJCSAo c2V0cSBuZXctZm4gKGNhciAoZmluZC1iYWNrdXAtZmlsZS1uYW1lIG5ldy1mbikpKSkpCkBA IC04NTgyLDcgKzg1NzQsNyBAQCBtb3ZlLWZpbGUtdG8tdHJhc2gKICAgICAgICAgICAgICAg ICAgOzsgV2UncmUgY2hlY2tpbmcgZnVydGhlciBkb3duIHdoZXRoZXIgdGhlIGluZm8gZmls ZQogICAgICAgICAgICAgICAgICA7OyBleGlzdHMsIGJ1dCB0aGUgZmlsZSBuYW1lIG1heSBl eGlzdCBpbiB0aGUgdHJhc2gKICAgICAgICAgICAgICAgICAgOzsgZGlyZWN0b3J5IGV2ZW4g aWYgdGhlcmUgaXMgbm8gaW5mbyBmaWxlIGZvciBpdC4KLSAgICAgICAgICAgICAgICAgKHdo ZW4gKGZpbGUtZXhpc3RzLWluLXRyYXNoLXAKKyAgICAgICAgICAgICAgICAgKHdoZW4gKGZp bGUtYXR0cmlidXRlcwogICAgICAgICAgICAgICAgICAgICAgICAgKGZpbGUtbmFtZS1jb25j YXQgdHJhc2gtZmlsZXMtZGlyIGZpbGVzLWJhc2UpKQogICAgICAgICAgICAgICAgICAgIChz ZXRxIG92ZXJ3cml0ZSB0CiAgICAgICAgICAgICAgICAgICAgICAgICAgZmlsZXMtYmFzZSAo ZmlsZS1uYW1lLW5vbmRpcmVjdG9yeQpAQCAtODYyMCw3ICs4NjEyLDcgQEAgbW92ZS1maWxl LXRvLXRyYXNoCiAJCSAobGV0ICgoZGVsZXRlLWJ5LW1vdmluZy10by10cmFzaCBuaWwpCiAJ CSAgICAgICAobmV3LWZuIChmaWxlLW5hbWUtY29uY2F0IHRyYXNoLWZpbGVzLWRpciBmaWxl cy1iYXNlKSkpCiAgICAgICAgICAgICAgICAgICAgKGlmIChvciAobm90IGlzLWRpcmVjdG9y eSkKLSAgICAgICAgICAgICAgICAgICAgICAgICAgIChub3QgKGZpbGUtZXhpc3RzLWluLXRy YXNoLXAgbmV3LWZuKSkpCisgICAgICAgICAgICAgICAgICAgICAgICAgICAobm90IChmaWxl LWF0dHJpYnV0ZXMgbmV3LWZuKSkpCiAgICAgICAgICAgICAgICAgICAgICAgIChyZW5hbWUt ZmlsZSBmbiBuZXctZm4gb3ZlcndyaXRlKQogICAgICAgICAgICAgICAgICAgICAgKGNvcHkt ZGlyZWN0b3J5IGZuCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgKGZp bGUtbmFtZS1hcy1kaXJlY3RvcnkgbmV3LWZuKQotLSAKMi4zOC4xCgo= --------------speWKBqJuzI0pLZskrhymeVl-- From unknown Fri Aug 15 16:22:19 2025 X-Loop: help-debbugs@gnu.org Subject: bug#60146: file-exists-in-trash-p needs better name or semantics Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 17 Dec 2022 20:10:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60146 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Paul Eggert Cc: larsi@gnus.org, monnier@iro.umontreal.ca, 60146@debbugs.gnu.org Received: via spool by 60146-submit@debbugs.gnu.org id=B60146.16713077884607 (code B ref 60146); Sat, 17 Dec 2022 20:10:01 +0000 Received: (at 60146) by debbugs.gnu.org; 17 Dec 2022 20:09:48 +0000 Received: from localhost ([127.0.0.1]:57761 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p6dVD-0001CF-KQ for submit@debbugs.gnu.org; Sat, 17 Dec 2022 15:09:47 -0500 Received: from eggs.gnu.org ([209.51.188.92]:47112) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p6dVB-0001C7-O9 for 60146@debbugs.gnu.org; Sat, 17 Dec 2022 15:09:46 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p6dV5-0003wD-84; Sat, 17 Dec 2022 15:09:39 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=2xnDiKAQCZYtBuz3K+1FUrtZl1cE5YjPoQOMxyewxm0=; b=MNXklND4X0H9 M+luhGXBia0MGWPTj3BX5FEdDJXGIq1rsf0Sm+JIjDoEZ7PW/IolLSpgC4k4RP7+KiqKDBGeX4IgS sYWLBOfwfAJgEmeiTu5pnt16KTYEzHDPAVXCG2I9TZD1auO1zSKFuvA6b238UBiJY2IgKkC0l48QL XJtgT7re1QnRzf2XQ8rYzZbcA/EqHMKa/4bEGVAC7GYvX8UoerhAQTbmJW1OLn6pZrgOdyjed5bxX 9AozEDCg9QDDnGZZttU9tjeIz5L9wJ312ZcIbIBEpGMfEbP14udvtiuDm9qLc5Db1j5U+I+meHYRL aTKtAHGHlqSzvcm2BjdmWw==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p6dV4-0005MM-OR; Sat, 17 Dec 2022 15:09:39 -0500 Date: Sat, 17 Dec 2022 22:09:43 +0200 Message-Id: <835ye9hjw8.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: <4b872c57-99fd-dc8c-a121-7f19be0f9d49@cs.ucla.edu> (message from Paul Eggert on Sat, 17 Dec 2022 11:57:39 -0800) References: <83a63mifgu.fsf@gnu.org> <4b872c57-99fd-dc8c-a121-7f19be0f9d49@cs.ucla.edu> X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Sat, 17 Dec 2022 11:57:39 -0800 > Cc: 60146@debbugs.gnu.org > From: Paul Eggert > > I have a bit of a different take. First, there's adequate functionality > in Emacs now if we don't mind inefficiency, and it's already used; just > call file-attributes. (Gnus does this, in nnmaildir-unlink at least, and > I expect there are other uses.) Second, I wouldn't be surprised if other > uses of file-exists-p have problems similar to the one you found in > move-file-to-trash. Not that any of us have time to go scout for them > right now. > > It's a minor point. Still, the name file-exists-in-trash-p really needs > to go somehow as it's not a name that should be user-visible. How about > the attached patch? If you can verify that it works in the scenario of bug#59986, I'm okay with this change. From unknown Fri Aug 15 16:22:19 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Paul Eggert Subject: bug#60146: closed (Re: bug#60146: file-exists-in-trash-p needs better name or semantics) Message-ID: References: <08f9aafc-34a4-de76-df7c-fb28d9bbc607@cs.ucla.edu> X-Gnu-PR-Message: they-closed 60146 X-Gnu-PR-Package: emacs Reply-To: 60146@debbugs.gnu.org Date: Sat, 17 Dec 2022 23:56:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1671321362-13805-1" This is a multi-part message in MIME format... ------------=_1671321362-13805-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #60146: file-exists-in-trash-p needs better name or semantics which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 60146@debbugs.gnu.org. --=20 60146: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D60146 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1671321362-13805-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 60146-done) by debbugs.gnu.org; 17 Dec 2022 23:55:56 +0000 Received: from localhost ([127.0.0.1]:58696 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p6h23-0003aR-JZ for submit@debbugs.gnu.org; Sat, 17 Dec 2022 18:55:55 -0500 Received: from zimbra.cs.ucla.edu ([131.179.128.68]:38494) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p6h21-0003aJ-Gm for 60146-done@debbugs.gnu.org; Sat, 17 Dec 2022 18:55:53 -0500 Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 1291B160066; Sat, 17 Dec 2022 15:55:48 -0800 (PST) Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id 31whvXEPs1qb; Sat, 17 Dec 2022 15:55:47 -0800 (PST) Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 2D5D6160092; Sat, 17 Dec 2022 15:55:47 -0800 (PST) DKIM-Filter: OpenDKIM Filter v2.9.2 zimbra.cs.ucla.edu 2D5D6160092 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cs.ucla.edu; s=78364E5A-2AF3-11ED-87FA-8298ECA2D365; t=1671321347; bh=YAoOKyVzto8iC5u49u+HZ/KK1IHyVETj9OGllVqkANc=; h=Message-ID:Date:MIME-Version:Subject:To:From:Content-Type: Content-Transfer-Encoding; b=Nf0Vd3SOKGRhJ0SSkCOlBHvYb2pro9VfpbJmxbKAdyLyjUzhVagqN09okfBEJGMrr BGTdaClfnwA8mdLPYEI/gwq66KnZfqk6Xc2FzRX9ox0pIX5tyPihpndjkf7XzU6TUV dFssd/MxzPrv991POEsWw186cEAn/q9rqhm+Dsow= X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id 89UvAkZ2M2zG; Sat, 17 Dec 2022 15:55:46 -0800 (PST) Received: from [192.168.86.236] (cpe-172-91-119-151.socal.res.rr.com [172.91.119.151]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id BC269160066; Sat, 17 Dec 2022 15:55:46 -0800 (PST) Message-ID: <08f9aafc-34a4-de76-df7c-fb28d9bbc607@cs.ucla.edu> Date: Sat, 17 Dec 2022 15:55:43 -0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: bug#60146: file-exists-in-trash-p needs better name or semantics Content-Language: en-US To: Eli Zaretskii References: <83a63mifgu.fsf@gnu.org> <4b872c57-99fd-dc8c-a121-7f19be0f9d49@cs.ucla.edu> <835ye9hjw8.fsf@gnu.org> From: Paul Eggert In-Reply-To: <835ye9hjw8.fsf@gnu.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 60146-done Cc: larsi@gnus.org, monnier@iro.umontreal.ca, 60146-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) On 12/17/22 12:09, Eli Zaretskii wrote: > If you can verify that it works in the scenario of bug#59986, I'm okay > with this change. Thanks, I checked that the patch works in that scenario (dangling symlink in the trash directory), and installed it. Closing the bug report. ------------=_1671321362-13805-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 17 Dec 2022 05:17:29 +0000 Received: from localhost ([127.0.0.1]:53799 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p6PZh-0002Dp-As for submit@debbugs.gnu.org; Sat, 17 Dec 2022 00:17:29 -0500 Received: from lists.gnu.org ([209.51.188.17]:53042) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p6PZZ-0002De-Pu for submit@debbugs.gnu.org; Sat, 17 Dec 2022 00:17:26 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p6PZZ-0001WO-Ef for bug-gnu-emacs@gnu.org; Sat, 17 Dec 2022 00:17:21 -0500 Received: from zimbra.cs.ucla.edu ([131.179.128.68]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p6PZX-0004WN-Da for bug-gnu-emacs@gnu.org; Sat, 17 Dec 2022 00:17:21 -0500 Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id EBA4A160040 for ; Fri, 16 Dec 2022 21:17:15 -0800 (PST) Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id 0JW2RfHhOK1K for ; Fri, 16 Dec 2022 21:17:15 -0800 (PST) Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 374BD160070 for ; Fri, 16 Dec 2022 21:17:15 -0800 (PST) DKIM-Filter: OpenDKIM Filter v2.9.2 zimbra.cs.ucla.edu 374BD160070 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cs.ucla.edu; s=78364E5A-2AF3-11ED-87FA-8298ECA2D365; t=1671254235; bh=wnE+KPWCrtGTiyqYDshZhZ1LFY1vKjx2Ye6pLW60WXg=; h=Message-ID:Date:MIME-Version:To:From:Subject:Content-Type: Content-Transfer-Encoding; b=PB1H46wk0QSRSP2YhKOa6JpMdpFCZAhhgz+A/3tS477afwHajyUHbsOoLoonaheJf HjlDSNzoQ/e4SdQod69YP64YX5lbezmfK/h5tchyKz4AjwqzRjY9mSvaRgNLRjIshl LJ3C29G9GkN3axdELtG4hy5jhWT0DNCySj2LzCVo= X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id fjmFJvYDrcZp for ; Fri, 16 Dec 2022 21:17:15 -0800 (PST) Received: from [100.115.92.201] (cpe-172-91-119-151.socal.res.rr.com [172.91.119.151]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id 0984F160040 for ; Fri, 16 Dec 2022 21:17:15 -0800 (PST) Message-ID: Date: Fri, 16 Dec 2022 21:17:13 -0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Content-Language: en-US To: bug-gnu-emacs@gnu.org From: Paul Eggert Subject: file-exists-in-trash-p needs better name or semantics Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=131.179.128.68; envelope-from=eggert@cs.ucla.edu; helo=zimbra.cs.ucla.edu X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.6 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.6 (--) The recently-added function (file-exists-in-trash-p FILE) is poorly named since it's not really related to trash - it's simply checking for the existence of a directory entry named FILE. How about extending file-exists-p instead? (file-exists-p FILE t) would be like (file-exists-p FILE) except it would not follow symlinks. This extension can be implemented via a single system call on POSIX systems, and this would be more efficient and would avoid a race in the current implementation of file-exists-in-trash-p. (Though of course pretty much any use of this new function makes one vulnerable to races....) If extending file-exists-p is too much, at least please rename file-exists-in-trash-p to something like files--exists-nofollow-p, to indicate that it's private to files.el and to say better what it means. ------------=_1671321362-13805-1--