GNU bug report logs - #60132
[PATCH 1/3] patman: remove extraneous imports

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 60132 in the body.
You can then email your comments to 60132 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: guix-patches <at> gnu.org
Cc: u-boot <at> lists.denx.de, Simon Glass <sjg <at> chromium.org>,
 Maxim Cournoyer <maxim.cournoyer <at> savoirfairelinux.com>
Subject: [PATCH 1/3] patman: remove extraneous imports
Date: Fri, 16 Dec 2022 20:45:27 -0500

* tools/patman/main.py: Remove extraneous imports and fix indentation.

Signed-off-by: Maxim Cournoyer <maxim.cournoyer <at> savoirfairelinux.com>
---

 tools/patman/main.py | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/tools/patman/main.py b/tools/patman/main.py
index 5a7756a221..8067a288ab 100755
--- a/tools/patman/main.py
+++ b/tools/patman/main.py
@@ -9,7 +9,6 @@
 from argparse import ArgumentParser
 import os
 import re
-import shutil
 import sys
 import traceback
 
@@ -19,7 +18,6 @@ if __name__ == "__main__":
     sys.path.append(os.path.join(our_path, '..'))
 
 # Our modules
-from patman import command
 from patman import control
 from patman import gitutil
 from patman import project
@@ -136,7 +134,6 @@ if not args.debug:
 
 # Run our meagre tests
 if args.cmd == 'test':
-    import doctest
     from patman import func_test
 
     result = test_util.run_test_suites(
@@ -183,7 +180,7 @@ elif args.cmd == 'status':
                                  args.show_comments, args.patchwork_url)
     except Exception as e:
         terminal.tprint('patman: %s: %s' % (type(e).__name__, e),
-                       colour=terminal.Color.RED)
+                        colour=terminal.Color.RED)
         if args.debug:
             print()
             traceback.print_exc()

base-commit: 9bd3d354a1a0712ac27c717df9ad60566b0406ee
-- 
2.38.1

Message #12 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Simon Glass <sjg <at> chromium.org>
To: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
Cc: u-boot <at> lists.denx.de,
 Maxim Cournoyer <maxim.cournoyer <at> savoirfairelinux.com>, guix-patches <at> gnu.org
Subject: Re: [PATCH 1/3] patman: remove extraneous imports
Date: Sat, 17 Dec 2022 15:24:32 -0700

On Fri, 16 Dec 2022 at 18:45, Maxim Cournoyer <maxim.cournoyer <at> gmail.com> wrote:
>
> * tools/patman/main.py: Remove extraneous imports and fix indentation.
>
> Signed-off-by: Maxim Cournoyer <maxim.cournoyer <at> savoirfairelinux.com>
> ---
>
>  tools/patman/main.py | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)

Reviewed-by: Simon Glass <sjg <at> chromium.org>

Message #15 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Simon Glass <sjg <at> chromium.org>
To: Simon Glass <sjg <at> chromium.org>
Cc: u-boot <at> lists.denx.de, Maxim Cournoyer <maxim.cournoyer <at> gmail.com>,
 Maxim Cournoyer <maxim.cournoyer <at> savoirfairelinux.com>, guix-patches <at> gnu.org
Subject: Re: [PATCH 3/3] patman: locate README.rst via importlib
Date: Wed, 21 Dec 2022 00:28:47 +0000

On Fri, 16 Dec 2022 at 18:45, Maxim Cournoyer <maxim.cournoyer <at> gmail.com> wrote:
>
> Rationale: this is more robust than assumptions about the file
> hierarchy layout of the installation of patman, for example on non
> file-hierarchy standard (FHS) systems such as Guix System or Nix OS.
>
> Signed-off-by: Maxim Cournoyer <maxim.cournoyer <at> savoirfairelinux.com>
> ---
>
>  tools/patman/main.py | 8 +++-----
>  1 file changed, 3 insertions(+), 5 deletions(-)
>

Reviewed-by: Simon Glass <sjg <at> chromium.org>

Applied to u-boot-dm/next, thanks!

Message #18 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Simon Glass <sjg <at> chromium.org>
To: Simon Glass <sjg <at> chromium.org>
Cc: u-boot <at> lists.denx.de, Maxim Cournoyer <maxim.cournoyer <at> gmail.com>,
 Maxim Cournoyer <maxim.cournoyer <at> savoirfairelinux.com>, guix-patches <at> gnu.org
Subject: Re: [PATCH 1/3] patman: remove extraneous imports
Date: Wed, 21 Dec 2022 00:28:51 +0000

On Fri, 16 Dec 2022 at 18:45, Maxim Cournoyer <maxim.cournoyer <at> gmail.com> wrote:
>
> * tools/patman/main.py: Remove extraneous imports and fix indentation.
>
> Signed-off-by: Maxim Cournoyer <maxim.cournoyer <at> savoirfairelinux.com>
> ---
>
>  tools/patman/main.py | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)

Reviewed-by: Simon Glass <sjg <at> chromium.org>

Applied to u-boot-dm/next, thanks!

Message #21 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Simon Glass <sjg <at> chromium.org>
To: Simon Glass <sjg <at> chromium.org>
Cc: u-boot <at> lists.denx.de, Maxim Cournoyer <maxim.cournoyer <at> gmail.com>,
 Maxim Cournoyer <maxim.cournoyer <at> savoirfairelinux.com>, guix-patches <at> gnu.org
Subject: Re: [PATCH 2/3] patman: fix installation of README.rst data file
Date: Wed, 21 Dec 2022 00:28:50 +0000

On Fri, 16 Dec 2022 at 18:45, Maxim Cournoyer <maxim.cournoyer <at> gmail.com> wrote:
>
> This fixes a regression introduced in commit 74df491051d6 ("buildman:
> Convert documentation to rST").
>
> Signed-off-by: Maxim Cournoyer <maxim.cournoyer <at> savoirfairelinux.com>
> ---
>
>  tools/patman/setup.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Simon Glass <sjg <at> chromium.org>

Applied to u-boot-dm/next, thanks!

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.