From unknown Wed Jun 18 23:16:20 2025 X-Loop: help-debbugs@gnu.org Subject: bug#60130: [PATCH] ; * lisp/subr.el (internal--with-narrowing): Simplify Resent-From: Philip Kaludercic Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 16 Dec 2022 23:14:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 60130 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: 60130@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.167123239130967 (code B ref -1); Fri, 16 Dec 2022 23:14:01 +0000 Received: (at submit) by debbugs.gnu.org; 16 Dec 2022 23:13:11 +0000 Received: from localhost ([127.0.0.1]:52079 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p6Jt8-00083P-Hy for submit@debbugs.gnu.org; Fri, 16 Dec 2022 18:13:10 -0500 Received: from lists.gnu.org ([209.51.188.17]:35066) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p6Jt4-00083J-Tu for submit@debbugs.gnu.org; Fri, 16 Dec 2022 18:13:09 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p6Jt4-0006zG-Oy for bug-gnu-emacs@gnu.org; Fri, 16 Dec 2022 18:13:06 -0500 Received: from mout02.posteo.de ([185.67.36.66]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p6Jt2-0003MC-65 for bug-gnu-emacs@gnu.org; Fri, 16 Dec 2022 18:13:06 -0500 Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id E66D7240101 for ; Sat, 17 Dec 2022 00:12:58 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1671232380; bh=ZmdmA2VGtGY+kPx6tz541e4qL8piw9vL+2VFT+epmoo=; h=From:To:Subject:Date:From; b=KHVzZOpOhEd4B4AXykD0CZ6OknYBIwWP/fuf9uCex10wFEhlfLBZL7D9p/0DK5XWl LX5QFvaua07Td65oMwbNANA+KmUhoKDTlJVXCgRgX+wsSIQUaa1dDn2qVObWB6ZG15 7+YqDdIYVFsC9w1cPG7P8MwxTTb+A3SU/ZO0N2VtRhtldVmu/5IssGBpU4RW0VsOZC CKbfUGuWFMUMtr9RzQGxegviOIBTm1GsOid0tfex4dDFbk6/x42yPIXcFjYBY1PO8G XYkDjp3iWmrazyAM7xuHaPZRMNaGkSquJeeArlfsnDCKyCK6BYGF4xI8Pipv8sTSHx i8UEgM6xPuIkQ== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4NYlJB0Mpdz6tmg for ; Sat, 17 Dec 2022 00:12:55 +0100 (CET) From: Philip Kaludercic Date: Fri, 16 Dec 2022 23:12:58 +0000 Message-ID: <87len70wp1.fsf@posteo.net> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Received-SPF: pass client-ip=185.67.36.66; envelope-from=philipk@posteo.net; helo=mout02.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) --=-=-= Content-Type: text/plain Tags: patch I am not sure if I am missing something, but shouldn't the above patch be "simpler" and more idiomatic? In GNU Emacs 29.0.60 (build 5, x86_64-pc-linux-gnu, GTK+ Version 3.24.35, cairo version 1.16.0) of 2022-12-14 built on quetzal Repository revision: 622838b957e240d700585050e9ddbd036e690513 Repository branch: emacs-29 System Description: Debian GNU/Linux bookworm/sid Configured using: 'configure --with-pgtk --with-imagemagick' --=-=-= Content-Type: text/patch Content-Disposition: attachment; filename=0001-lisp-subr.el-internal-with-narrowing-Simplify.patch >From 1d2e59dfc56e10b4576f7ae7524abceb5e5b74c6 Mon Sep 17 00:00:00 2001 From: Philip Kaludercic Date: Sat, 17 Dec 2022 00:11:46 +0100 Subject: [PATCH] ; * lisp/subr.el (internal--with-narrowing): Simplify --- lisp/subr.el | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/lisp/subr.el b/lisp/subr.el index e142eaa810..b21cce1669 100644 --- a/lisp/subr.el +++ b/lisp/subr.el @@ -3956,10 +3956,9 @@ with-narrowing (defun internal--with-narrowing (start end body &optional tag) "Helper function for `with-narrowing', which see." (save-restriction - (progn - (narrow-to-region start end) - (if tag (narrowing-lock tag)) - (funcall body)))) + (narrow-to-region start end) + (when tag (narrowing-lock tag)) + (funcall body))) (defun find-tag-default-bounds () "Determine the boundaries of the default tag, based on text at point. -- 2.35.1 --=-=-=-- From unknown Wed Jun 18 23:16:20 2025 X-Loop: help-debbugs@gnu.org Subject: bug#60130: [PATCH] ; * lisp/subr.el (internal--with-narrowing): Simplify Resent-From: Gregory Heytings Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 16 Dec 2022 23:32:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60130 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Philip Kaludercic Cc: 60130@debbugs.gnu.org Received: via spool by 60130-submit@debbugs.gnu.org id=B60130.167123348731787 (code B ref 60130); Fri, 16 Dec 2022 23:32:01 +0000 Received: (at 60130) by debbugs.gnu.org; 16 Dec 2022 23:31:27 +0000 Received: from localhost ([127.0.0.1]:52164 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p6KAo-0008Gd-Vc for submit@debbugs.gnu.org; Fri, 16 Dec 2022 18:31:27 -0500 Received: from heytings.org ([95.142.160.155]:33490) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p6KAm-0008GX-Ol for 60130@debbugs.gnu.org; Fri, 16 Dec 2022 18:31:25 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=heytings.org; s=20220101; t=1671233483; bh=orF0EaztdtVCo9uQKTzkk+l4/RP51HmmSpYH0lXLJfQ=; h=Date:From:To:cc:Subject:In-Reply-To:Message-ID:References:From; b=EbTVn+2H3ReCKZ9ICWp7za9tdzHDSdc1EJMQUK93HLISrFy67HY4bZF+IKYjq7WZh 1UoZIxgxcarOuoInYvs7rnszwal49HJLzjbo5b4XoZL5IZKnVMixY9tj4tEnz5y0np CN2h6s3Ii+r/gB7XLHe+EQu6TYX66TLUrFqcsjkj+klwrFlZtuiCPzivYu8nDe+I8n M3eZZM7FfP4QVEoNuvjT2dc2aRnn2vcsTBKjOc9kxthvn8b0BkFkD1YvNo3W1h7gbl L8XbFpYbugceOcweQhfYdozIE1c2MnyCPd0320pNinJb0ZJ5h9tlNHqrMZifDm89/L XxLOPIvU9IiKQ== Date: Fri, 16 Dec 2022 23:31:22 +0000 From: Gregory Heytings In-Reply-To: <87len70wp1.fsf@posteo.net> Message-ID: <07bcf6a532b951e467af@heytings.org> References: <87len70wp1.fsf@posteo.net> MIME-Version: 1.0 Content-Type: text/plain; format=flowed; charset=us-ascii X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > > I am not sure if I am missing something, but shouldn't the above patch > be "simpler" and more idiomatic? > Indeed. The "progn" is a remnant of an earlier version of that code, and can safely be removed. From unknown Wed Jun 18 23:16:20 2025 X-Loop: help-debbugs@gnu.org Subject: bug#60130: [PATCH] ; * lisp/subr.el (internal--with-narrowing): Simplify Resent-From: Philip Kaludercic Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 16 Dec 2022 23:41:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60130 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Gregory Heytings Cc: 60130@debbugs.gnu.org Received: via spool by 60130-submit@debbugs.gnu.org id=B60130.167123404532139 (code B ref 60130); Fri, 16 Dec 2022 23:41:03 +0000 Received: (at 60130) by debbugs.gnu.org; 16 Dec 2022 23:40:45 +0000 Received: from localhost ([127.0.0.1]:52209 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p6KJo-0008MJ-KH for submit@debbugs.gnu.org; Fri, 16 Dec 2022 18:40:44 -0500 Received: from mout01.posteo.de ([185.67.36.65]:49197) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p6KJl-0008Lx-BU for 60130@debbugs.gnu.org; Fri, 16 Dec 2022 18:40:42 -0500 Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 1C507240045 for <60130@debbugs.gnu.org>; Sat, 17 Dec 2022 00:40:34 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1671234035; bh=02CWnz4r5POeXL9cb1hS2TOmbKLb7177tmo11SXJEdI=; h=From:To:Cc:Subject:Date:From; b=gHIc6Efto5bwUPL/tJ9r/hZYlhOULIU1EqQ4t/MuVdMaM0Va05XuT4mLwsEF3Kfxq O6VCoqvf5+BBF69gLBr5kRLOP2V4MQ7whzL+nEE3sf2Kw/4nQ6HVeNU2pAtpkE0c2X 8ophhmWDCRthdxLkjz9lrLFBEZliVsHestnTkUy7kwNyAKRDajGh1ctA6R5xYiBBr6 KbLOsIkjGlCgEl9t9LFb5DFR14ECIfcT7ZmyLOj4b2QnYZigU/Y/+ysiQ4rHDTcD5b rFO5rAktNXltZ9DxEOsKCZjFjf1Dqo4sQsk0UyNWuo6y6HU/I5pEGph68C9vsKff+i +2w+mZuqH1wzQ== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4NYlw22xXcz9rxB; Sat, 17 Dec 2022 00:40:34 +0100 (CET) From: Philip Kaludercic In-Reply-To: <07bcf6a532b951e467af@heytings.org> (Gregory Heytings's message of "Fri, 16 Dec 2022 23:31:22 +0000") References: <87len70wp1.fsf@posteo.net> <07bcf6a532b951e467af@heytings.org> Date: Fri, 16 Dec 2022 23:40:37 +0000 Message-ID: <87h6xu29ze.fsf@posteo.net> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Gregory Heytings writes: >> >> I am not sure if I am missing something, but shouldn't the above >> patch be "simpler" and more idiomatic? >> > > Indeed. The "progn" is a remnant of an earlier version of that code, > and can safely be removed. Ok, I'll push the change. From debbugs-submit-bounces@debbugs.gnu.org Fri Dec 16 18:41:51 2022 Received: (at control) by debbugs.gnu.org; 16 Dec 2022 23:41:51 +0000 Received: from localhost ([127.0.0.1]:52220 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p6KKt-0008Nh-0I for submit@debbugs.gnu.org; Fri, 16 Dec 2022 18:41:51 -0500 Received: from mout02.posteo.de ([185.67.36.66]:37903) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p6KKr-0008Nb-Fa for control@debbugs.gnu.org; Fri, 16 Dec 2022 18:41:50 -0500 Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id 950E324010B for ; Sat, 17 Dec 2022 00:41:42 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1671234103; bh=oWG9npzoGX2VYX843nrbdhHcXeajoPwAvyvMVpwwh1M=; h=Date:To:From:Subject:From; b=QZlMxv+UPpI5JiIf0liHjTi5XX33egzhRwbIiQeEDKM7/zyCRvHXQsIUc1BGoE/Jg 5feKjeERBF/p2Wdpm1xq5gDv4aTd7kduOouYQyjjbwiMhAd9iSSTc9SJ5Lel5WfiqA 07Y2og+UPsaOag0qxvxa8senJzQ/S06DqXs4NlZVLkKgcWdMhbbAWd6J5ELkbJg+ma g/iCpjOBTHrFjX1YYjXXW4neCRCFfDyovJ0B5w8UQNhpsIiH258Knf2w2XNx3VttPD +jEvt29RS+pw1JyO3BrYC/EmvqnzeYzPRG4mTQpvNwn7czCTvHbH1CToa2mc16hIET 91nfF8gdbjcsg== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4NYlxL1bFnz9rxD for ; Sat, 17 Dec 2022 00:41:42 +0100 (CET) Date: Fri, 16 Dec 2022 23:41:46 +0000 Message-Id: <87fsde29xh.fsf@posteo.net> To: control@debbugs.gnu.org From: Philip Kaludercic Subject: control message for bug #60130 X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) close 60130 29.1 quit From unknown Wed Jun 18 23:16:20 2025 X-Loop: help-debbugs@gnu.org Subject: bug#60130: [PATCH] ; * lisp/subr.el (internal--with-narrowing): Simplify Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 17 Dec 2022 07:53:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60130 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Philip Kaludercic Cc: gregory@heytings.org, 60130@debbugs.gnu.org Received: via spool by 60130-submit@debbugs.gnu.org id=B60130.167126357216196 (code B ref 60130); Sat, 17 Dec 2022 07:53:01 +0000 Received: (at 60130) by debbugs.gnu.org; 17 Dec 2022 07:52:52 +0000 Received: from localhost ([127.0.0.1]:54447 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p6S04-0004DA-EE for submit@debbugs.gnu.org; Sat, 17 Dec 2022 02:52:52 -0500 Received: from eggs.gnu.org ([209.51.188.92]:42020) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p6S02-0004D4-Af for 60130@debbugs.gnu.org; Sat, 17 Dec 2022 02:52:51 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p6Rzw-0003DP-NV; Sat, 17 Dec 2022 02:52:44 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=h8VLciDU51aCUowTx/+5dD3Z0S9tD0Qpx9gyen8h5eE=; b=IDUecvky6B/U r7EQSSq5FcIsYgCr5hsZWvLS+rrXe/RwYRKcupF2BV0tvoRF9efGdK5XYkMvhfxBc5I+G7wZAop+M tyx1NDO3CJNPomiDCVX1OZ72S+8jtb6VKzJkjt6f01XOr8iHk8JnSVHgukQ89/PV5W8dw3KfWLB8m NBDSUeAruHmDXy6Qk5aYSMLIJZe26edtLXealUiEKGjbkyiS8hrOeilouItg08d+b0h+mrJ9ub1J2 HmjtnHp4pT34p8Gh+Qzz6JNtQUcqTkXuJRfLkmOLMh3OeEpcIG3ywZM3LvZVlMejfzznfG+XgZThd O9r083Ox13PJjUlYvvgosQ==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p6Rzw-0005XN-75; Sat, 17 Dec 2022 02:52:44 -0500 Date: Sat, 17 Dec 2022 09:52:49 +0200 Message-Id: <83iliaii0e.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: <87h6xu29ze.fsf@posteo.net> (message from Philip Kaludercic on Fri, 16 Dec 2022 23:40:37 +0000) References: <87len70wp1.fsf@posteo.net> <07bcf6a532b951e467af@heytings.org> <87h6xu29ze.fsf@posteo.net> X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Cc: 60130@debbugs.gnu.org > From: Philip Kaludercic > Date: Fri, 16 Dec 2022 23:40:37 +0000 > > Gregory Heytings writes: > > >> > >> I am not sure if I am missing something, but shouldn't the above > >> patch be "simpler" and more idiomatic? > >> > > > > Indeed. The "progn" is a remnant of an earlier version of that code, > > and can safely be removed. > > Ok, I'll push the change. Please don't install code cleanups on the release branch. I've reverted the commit on the release branch. Please install this on master instead. Thanks. From unknown Wed Jun 18 23:16:20 2025 X-Loop: help-debbugs@gnu.org Subject: bug#60130: [PATCH] ; * lisp/subr.el (internal--with-narrowing): Simplify Resent-From: Philip Kaludercic Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 17 Dec 2022 11:20:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60130 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Eli Zaretskii Cc: gregory@heytings.org, 60130@debbugs.gnu.org Received: via spool by 60130-submit@debbugs.gnu.org id=B60130.167127599311313 (code B ref 60130); Sat, 17 Dec 2022 11:20:01 +0000 Received: (at 60130) by debbugs.gnu.org; 17 Dec 2022 11:19:53 +0000 Received: from localhost ([127.0.0.1]:55315 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p6VEP-0002wP-1z for submit@debbugs.gnu.org; Sat, 17 Dec 2022 06:19:53 -0500 Received: from mout02.posteo.de ([185.67.36.66]:45429) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p6VEL-0002wJ-Qy for 60130@debbugs.gnu.org; Sat, 17 Dec 2022 06:19:51 -0500 Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id 0AF25240104 for <60130@debbugs.gnu.org>; Sat, 17 Dec 2022 12:19:43 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1671275984; bh=dJIbZ7cfRKRYKKLiDfQ+TK00DzMzppSWk3vaudH82lc=; h=From:To:Cc:Subject:Date:From; b=qw8/tYt6CCZqMmN4eA15XaeKTBVt0R2ZwXVbgeUYgO7M+RcdWTEnSwNhiKgdwYZIp KT+AyFlrcaIcniKchQctKG/gnc6GMZT3OYXLsya8yZYyJgulielxnsQ2+OjLORneu6 TzEejN4aERXfRS+3lbG2Y9a95EUhX7/H6VMWKC+37F2QYn7ttnk59Z+98qVbkdYgP4 404twwceKQlmJuDmGh/WGQzR5suyXWNnRY/MFo70EQcTZuERQetGr3N0Pnks/+Bzhm MnpKvXngG9+lc4Z6+rcCvsEfByNVmMpIFWij7LW9DLgCeWUfh6WxfHQWEpQDY/XR+V 7n9UPwZkn0sYw== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4NZ3Ql09vxz9rxF; Sat, 17 Dec 2022 12:19:42 +0100 (CET) From: Philip Kaludercic In-Reply-To: <83iliaii0e.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 17 Dec 2022 09:52:49 +0200") References: <87len70wp1.fsf@posteo.net> <07bcf6a532b951e467af@heytings.org> <87h6xu29ze.fsf@posteo.net> <83iliaii0e.fsf@gnu.org> Date: Sat, 17 Dec 2022 11:19:46 +0000 Message-ID: <87len646r1.fsf@posteo.net> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Eli Zaretskii writes: >> Cc: 60130@debbugs.gnu.org >> From: Philip Kaludercic >> Date: Fri, 16 Dec 2022 23:40:37 +0000 >> >> Gregory Heytings writes: >> >> >> >> >> I am not sure if I am missing something, but shouldn't the above >> >> patch be "simpler" and more idiomatic? >> >> >> > >> > Indeed. The "progn" is a remnant of an earlier version of that code, >> > and can safely be removed. >> >> Ok, I'll push the change. > > Please don't install code cleanups on the release branch. > > I've reverted the commit on the release branch. Please install this > on master instead. Sorry about that, I just cherry-picked the commit onto master. > Thanks. From unknown Wed Jun 18 23:16:20 2025 X-Loop: help-debbugs@gnu.org Subject: bug#60130: [PATCH] ; * lisp/subr.el (internal--with-narrowing): Simplify Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 17 Dec 2022 11:32:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60130 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Philip Kaludercic Cc: gregory@heytings.org, 60130@debbugs.gnu.org Received: via spool by 60130-submit@debbugs.gnu.org id=B60130.167127669312468 (code B ref 60130); Sat, 17 Dec 2022 11:32:02 +0000 Received: (at 60130) by debbugs.gnu.org; 17 Dec 2022 11:31:33 +0000 Received: from localhost ([127.0.0.1]:55364 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p6VPg-0003F2-Jw for submit@debbugs.gnu.org; Sat, 17 Dec 2022 06:31:32 -0500 Received: from eggs.gnu.org ([209.51.188.92]:33002) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p6VPe-0003Eq-36 for 60130@debbugs.gnu.org; Sat, 17 Dec 2022 06:31:31 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p6VPY-0005oh-Nc; Sat, 17 Dec 2022 06:31:24 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=Zzg/V6rJbpHvJZxBOD99eVR40yZLn9qXxiH4lpC9kYw=; b=HbyuSJqoxxJE +h39OCIL62a570ySOBxmamK1n0T30vSIJfb7uUS0fp1EhCpGMOsjbYVqePO3I0eDxGi6CNNrrh3rk +NxfeWbEPX4NIHWWgrcuoGZozqrl+c7GoroM4HhEmA+E2FwV/4oWjUh5d2cR5wkHDHsTLskbHcHpf 5qkU9R26J3YXcvEJvfjWZqD8IOHAPOlTm2PJIbbKYAA2fcFzNLszEoYe9s7UZXIXaAIEqZVQQdcnz QwYuRbHCKcXzRHXt0ELGBLy9saEUWnrNQpXDGJpMVi7VSWWNBcdpN9QUn8vzUm0pwzymvNPEWhYJH VM1ElNrddDLW8eNE/LOodQ==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p6VPY-0002cp-7a; Sat, 17 Dec 2022 06:31:24 -0500 Date: Sat, 17 Dec 2022 13:31:29 +0200 Message-Id: <831qoyi7vy.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: <87len646r1.fsf@posteo.net> (message from Philip Kaludercic on Sat, 17 Dec 2022 11:19:46 +0000) References: <87len70wp1.fsf@posteo.net> <07bcf6a532b951e467af@heytings.org> <87h6xu29ze.fsf@posteo.net> <83iliaii0e.fsf@gnu.org> <87len646r1.fsf@posteo.net> X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Philip Kaludercic > Cc: gregory@heytings.org, 60130@debbugs.gnu.org > Date: Sat, 17 Dec 2022 11:19:46 +0000 > > Eli Zaretskii writes: > > > I've reverted the commit on the release branch. Please install this > > on master instead. > > Sorry about that, I just cherry-picked the commit onto master. I hope the merge from the release branch to master will not revert your cherry-pick. From unknown Wed Jun 18 23:16:20 2025 X-Loop: help-debbugs@gnu.org Subject: bug#60130: [PATCH] ; * lisp/subr.el (internal--with-narrowing): Simplify Resent-From: Philip Kaludercic Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 17 Dec 2022 11:51:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60130 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Eli Zaretskii Cc: gregory@heytings.org, 60130@debbugs.gnu.org Received: via spool by 60130-submit@debbugs.gnu.org id=B60130.167127783013621 (code B ref 60130); Sat, 17 Dec 2022 11:51:02 +0000 Received: (at 60130) by debbugs.gnu.org; 17 Dec 2022 11:50:30 +0000 Received: from localhost ([127.0.0.1]:55466 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p6Vi2-0003Xd-9O for submit@debbugs.gnu.org; Sat, 17 Dec 2022 06:50:30 -0500 Received: from mout02.posteo.de ([185.67.36.66]:54137) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p6Vi0-0003XT-Js for 60130@debbugs.gnu.org; Sat, 17 Dec 2022 06:50:29 -0500 Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id DF2AE240106 for <60130@debbugs.gnu.org>; Sat, 17 Dec 2022 12:50:22 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1671277822; bh=kQjt1aVntNRM4tuLUAjWzOHDUQ1MBDO4E0SeM5I3dBY=; h=From:To:Cc:Subject:Date:From; b=TSP4HIwiVcWp7Emw6nT0sxN6LPcWsfdQLh3h+q8/GNeWwq/xJIIOfa4MiyGG1i1Ps m2v3UDZZ63M1n9JVmqzXe+W+oVvqHc4F+QpvkiWrnrAG0qtc7nliH1GiZk2RMwjaEt Yr+Xc/tuSctqzQKLjMWssXXfKjvI/qLqL/53n/xvORayTZz++DhRSlEt43wZX3/a6i t8K5a8iptcDKkwCheT7ZeitVO7ZKorZkLBGdYyg9E4VoTfiKAaxrPCcFEMCWWwEXsw DDLsG3InH4gXXaMeJsdYcvnR+rtaAnCyulWUJbmt4QJWrNFfq4d9jWzPGorTI6Vsra IuD5YuOJTn0lw== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4NZ4661Qq9z9rxF; Sat, 17 Dec 2022 12:50:21 +0100 (CET) From: Philip Kaludercic In-Reply-To: <831qoyi7vy.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 17 Dec 2022 13:31:29 +0200") References: <87len70wp1.fsf@posteo.net> <07bcf6a532b951e467af@heytings.org> <87h6xu29ze.fsf@posteo.net> <83iliaii0e.fsf@gnu.org> <87len646r1.fsf@posteo.net> <831qoyi7vy.fsf@gnu.org> Date: Sat, 17 Dec 2022 11:50:25 +0000 Message-ID: <87edsygsfy.fsf@posteo.net> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Eli Zaretskii writes: >> From: Philip Kaludercic >> Cc: gregory@heytings.org, 60130@debbugs.gnu.org >> Date: Sat, 17 Dec 2022 11:19:46 +0000 >> >> Eli Zaretskii writes: >> >> > I've reverted the commit on the release branch. Please install this >> > on master instead. >> >> Sorry about that, I just cherry-picked the commit onto master. > > I hope the merge from the release branch to master will not revert > your cherry-pick. >From my understanding of Git this shouldn't be the case (though it is an interesting question), but if it does happen, I will try and fix that.