GNU bug report logs - #60108
[PATCH] gnu: musescore: Fix build.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 60108 in the body.
You can then email your comments to 60108 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Liliana Marie Prikler <liliana.prikler <at> gmail.com>
To: guix-patches <at> gnu.org
Cc: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
Subject: [PATCH] gnu: musescore: Fix build.
Date: Fri, 16 Dec 2022 00:31:00 +0100

* gnu/packages/music.scm (musescore)[snippet]: Remove crashpad_handler and
associated install actions.
[arguments]<#:configure-flags>: Add “-DBUILD_DIAGNOSTICS=OFF”.
---
 gnu/packages/music.scm | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/music.scm b/gnu/packages/music.scm
index 614eb57791..0d7fb21701 100644
--- a/gnu/packages/music.scm
+++ b/gnu/packages/music.scm
@@ -4787,14 +4787,19 @@ (define-public musescore
         (base32 "16rcwr6fzghv8100syzicabqg8jqvng3zzsi6h3ja4zkp9hcbkcr"))
        (modules '((guix build utils)))
        (snippet
-        ;; Remove unused libraries.
         '(begin
+           ;; Remove unused libraries...
            (for-each delete-file-recursively
-                     '("thirdparty/freetype"))))))
+                     '("thirdparty/freetype"))
+           ;; ... and precompiled binaries.
+           (delete-file-recursively "src/diagnostics/crashpad_handler")
+           (substitute* "src/diagnostics/CMakeLists.txt"
+             (("install") "#install"))))))
     (build-system qt-build-system)
     (arguments
      `(#:configure-flags
        `("-DDOWNLOAD_SOUNDFONT=OFF"
+         "-DBUILD_DIAGNOSTICS=OFF"
          "-DMUSESCORE_BUILD_CONFIG=release"
          "-DUSE_SYSTEM_FREETYPE=ON")
        ;; There are tests, but no simple target to run.  The command used to
-- 
2.38.1

Message #8 received at 60108 <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: Liliana Marie Prikler <liliana.prikler <at> gmail.com>
Cc: 60108 <at> debbugs.gnu.org
Subject: Re: [bug#60108] [PATCH] gnu: musescore: Fix build.
Date: Fri, 16 Dec 2022 18:39:35 +0100

Hello,

Liliana Marie Prikler <liliana.prikler <at> gmail.com> writes:

> * gnu/packages/music.scm (musescore)[snippet]: Remove crashpad_handler and
> associated install actions.
> [arguments]<#:configure-flags>: Add “-DBUILD_DIAGNOSTICS=OFF”.

FWIW, qa.guix.gnu.org says it looks good to it.

Regards,
-- 
Nicolas Goaziou

Message #11 received at 60108 <at> debbugs.gnu.org (full text, mbox):

From: Vivien Kraus <vivien <at> planete-kraus.eu>
To: 60108 <at> debbugs.gnu.org
Subject: [PATCH] gnu: musescore: Fix build.
Date: Sun, 18 Dec 2022 17:27:01 +0100

I tried this patch, but unfortunately MuseScore crashes on startup,
saying that: qrc:/qml/DevTools/Preferences/SettingsPage.qml:24:1:
module "QtQuick.Dialogs" is not installed

I checked the source, and QtQuick.Dialogs is indeed imported in a bunch
of QML files.

I don’t know much about qt, so I’m not sure how to proceed. I tried to
copy the package for qtquick-controls to qtquick-dialogs, but guix
can’t find any source for that.

Best regards,

Vivien

Message #14 received at 60108 <at> debbugs.gnu.org (full text, mbox):

From: Vivien Kraus <vivien <at> planete-kraus.eu>
To: 60108 <at> debbugs.gnu.org
Subject: Re: [PATCH] gnu: musescore: Fix build.
Date: Sun, 18 Dec 2022 21:12:05 +0100

Le dimanche 18 décembre 2022 à 17:27 +0100, Vivien Kraus a écrit :
> I tried this patch, but unfortunately MuseScore crashes on startup,
> saying that: qrc:/qml/DevTools/Preferences/SettingsPage.qml:24:1:
> module "QtQuick.Dialogs" is not installed

Adding both qtquickcontrols-5 and qtquickcontrols2-5 fixes the issue :)

Message #17 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: Vivien Kraus via Guix-patches via <guix-patches <at> gnu.org>
Cc: 60108 <at> debbugs.gnu.org, Vivien Kraus <vivien <at> planete-kraus.eu>
Subject: Re: [bug#60108] [PATCH] gnu: musescore: Fix build.
Date: Mon, 19 Dec 2022 16:40:21 +0100

Hello,

Vivien Kraus via Guix-patches via <guix-patches <at> gnu.org> writes:

> Le dimanche 18 décembre 2022 à 17:27 +0100, Vivien Kraus a écrit :
>> I tried this patch, but unfortunately MuseScore crashes on startup,
>> saying that: qrc:/qml/DevTools/Preferences/SettingsPage.qml:24:1:
>> module "QtQuick.Dialogs" is not installed
>
> Adding both qtquickcontrols-5 and qtquickcontrols2-5 fixes the
> issue :)

Would you mind sending a patch including this, so that we can apply it
and close the issue?

Regards,
-- 
Nicolas Goaziou

Message #23 received at 60108 <at> debbugs.gnu.org (full text, mbox):

From: Vivien Kraus <vivien <at> planete-kraus.eu>
To: 60108 <at> debbugs.gnu.org
Cc: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
Subject: [PATCH v2] gnu: musescore: Fix build.
Date: Fri, 16 Dec 2022 00:31:00 +0100

From: Liliana Marie Prikler <liliana.prikler <at> gmail.com>

* gnu/packages/music.scm (musescore)[snippet]: Remove crashpad_handler and
associated install actions.
[arguments]<#:configure-flags>: Add “-DBUILD_DIAGNOSTICS=OFF”.
[inputs]: Add qtquickcontrols-5.
---
 gnu/packages/music.scm | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/music.scm b/gnu/packages/music.scm
index 614eb57791..bde01cb312 100644
--- a/gnu/packages/music.scm
+++ b/gnu/packages/music.scm
@@ -4787,14 +4787,19 @@ (define-public musescore
         (base32 "16rcwr6fzghv8100syzicabqg8jqvng3zzsi6h3ja4zkp9hcbkcr"))
        (modules '((guix build utils)))
        (snippet
-        ;; Remove unused libraries.
         '(begin
+           ;; Remove unused libraries...
            (for-each delete-file-recursively
-                     '("thirdparty/freetype"))))))
+                     '("thirdparty/freetype"))
+           ;; ... and precompiled binaries.
+           (delete-file-recursively "src/diagnostics/crashpad_handler")
+           (substitute* "src/diagnostics/CMakeLists.txt"
+             (("install") "#install"))))))
     (build-system qt-build-system)
     (arguments
      `(#:configure-flags
        `("-DDOWNLOAD_SOUNDFONT=OFF"
+         "-DBUILD_DIAGNOSTICS=OFF"
          "-DMUSESCORE_BUILD_CONFIG=release"
          "-DUSE_SYSTEM_FREETYPE=ON")
        ;; There are tests, but no simple target to run.  The command used to
@@ -4825,6 +4830,7 @@ (define-public musescore
            qtdeclarative-5
            qtgraphicaleffects
            qtnetworkauth-5
+           qtquickcontrols-5
            qtquickcontrols2-5
            qtscript
            qtsvg-5

base-commit: 05e4efe0c83c09929d15a0f5faa23a9afc0079e4
-- 
2.38.1

Message #26 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Vivien Kraus <vivien <at> planete-kraus.eu>
To: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>, Vivien Kraus via
 Guix-patches via <guix-patches <at> gnu.org>
Cc: 60108 <at> debbugs.gnu.org
Subject: Re: [bug#60108] [PATCH] gnu: musescore: Fix build.
Date: Mon, 19 Dec 2022 17:52:02 +0100

Le lundi 19 décembre 2022 à 16:40 +0100, Nicolas Goaziou a écrit :
> Would you mind sending a patch including this, so that we can apply
> it
> and close the issue?

I think I messed things up and the original "From:" header is now in
the commit message, sorry.

Can you fix it on your end? I’m not sure I know how to keep the patch
author information while still being able to send it.

Vivien

Message #32 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: Vivien Kraus via Guix-patches via <guix-patches <at> gnu.org>
Cc: 60108-done <at> debbugs.gnu.org, Vivien Kraus <vivien <at> planete-kraus.eu>
Subject: Re: [bug#60108] [PATCH v2] gnu: musescore: Fix build.
Date: Mon, 19 Dec 2022 18:19:08 +0100

Hello,

Vivien Kraus via Guix-patches via <guix-patches <at> gnu.org> writes:

> From: Liliana Marie Prikler <liliana.prikler <at> gmail.com>
>
> * gnu/packages/music.scm (musescore)[snippet]: Remove crashpad_handler and
> associated install actions.
> [arguments]<#:configure-flags>: Add “-DBUILD_DIAGNOSTICS=OFF”.
> [inputs]: Add qtquickcontrols-5.

Thanks to you both.

I added Vivien as a co-author and applied the patch. I'm closing this
issue. Feel free to re-open it if you think something is missing.

Regards,
-- 
Nicolas Goaziou

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.