GNU bug report logs - #60105
[PATCH] Add yaml-ts-mode

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Yuan Fu <casouri <at> gmail.com>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#60105: closed ([PATCH] Add yaml-ts-mode)
Date: Fri, 16 Dec 2022 22:56:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Fri, 16 Dec 2022 14:55:34 -0800
with message-id <C38AB5EC-0595-4BC6-994F-E88DAA8BD0D7 <at> gmail.com>
and subject line Re: bug#60105: [PATCH] Add yaml-ts-mode
has caused the debbugs.gnu.org bug report #60105,
regarding [PATCH] Add yaml-ts-mode
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
60105: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=60105
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Randy Taylor <dev <at> rjt.dev>
To: "bug-gnu-emacs <at> gnu.org" <bug-gnu-emacs <at> gnu.org>
Subject: [PATCH] Add yaml-ts-mode
Date: Thu, 15 Dec 2022 22:19:58 +0000

[Message part 3 (text/plain, inline)]

X-Debbugs-CC: casouri <at> gmail.com

[Message part 4 (text/html, inline)]

[0001-Add-yaml-ts-mode.patch (text/x-patch, attachment)]

[Message part 6 (message/rfc822, inline)]

From: Yuan Fu <casouri <at> gmail.com>
To: Randy Taylor <dev <at> rjt.dev>
Cc: Stefan Kangas <stefankangas <at> gmail.com>, 60105-done <at> debbugs.gnu.org
Subject: Re: bug#60105: [PATCH] Add yaml-ts-mode
Date: Fri, 16 Dec 2022 14:55:34 -0800

Randy Taylor <dev <at> rjt.dev> writes:

> On Thursday, December 15th, 2022 at 19:20, Stefan Kangas <stefankangas <at> gmail.com> wrote:
>> 
>> Randy Taylor dev <at> rjt.dev writes:
>> 
>> > diff --git a/lisp/progmodes/eglot.el b/lisp/progmodes/eglot.el
>> > index 9c5a361df7..4319623e64 100644
>> > --- a/lisp/progmodes/eglot.el
>> > +++ b/lisp/progmodes/eglot.el
>> > @@ -224,7 +224,7 @@ eglot-server-programs
>> > ((tex-mode context-mode texinfo-mode bibtex-mode)
>> > . ,(eglot-alternatives '("digestif" "texlab")))
>> > (erlang-mode . ("erlang_ls" "--transport" "stdio"))
>> > - (yaml-mode . ("yaml-language-server" "--stdio"))
>> > + ((yaml-mode yaml-ts-mode) . ("yaml-language-server" "--stdio"))
>> 
>> 
>> This is a nit, but I think it might make more sense to users if we put
>> the built-in mode first in the list. After all, the one we ship with
>> Emacs is, or will be, the standard mode.
>
> Sounds good to me. I'll submit another patch tomorrow making that change for the rest of the modes we've added (unless someone beats me to it).
>
> Attached is a new patch that applies cleanly against emacs-29 and has yaml-ts-mode come first for eglot.
>

LGTM, I applied the patch, thanks!

Yuan

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.