From debbugs-submit-bounces@debbugs.gnu.org Thu Dec 15 13:15:04 2022 Received: (at submit) by debbugs.gnu.org; 15 Dec 2022 18:15:04 +0000 Received: from localhost ([127.0.0.1]:44137 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p5sl6-0005pL-6u for submit@debbugs.gnu.org; Thu, 15 Dec 2022 13:15:04 -0500 Received: from lists.gnu.org ([209.51.188.17]:45484) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p5skt-0005gi-Fo for submit@debbugs.gnu.org; Thu, 15 Dec 2022 13:15:03 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p5skt-0000eq-7s for bug-gnu-emacs@gnu.org; Thu, 15 Dec 2022 13:14:51 -0500 Received: from mail-ej1-x635.google.com ([2a00:1450:4864:20::635]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1p5skr-0004qw-MJ for bug-gnu-emacs@gnu.org; Thu, 15 Dec 2022 13:14:50 -0500 Received: by mail-ej1-x635.google.com with SMTP id kw15so475972ejc.10 for ; Thu, 15 Dec 2022 10:14:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:user-agent:message-id:date:subject:to:from:from:to:cc :subject:date:message-id:reply-to; bh=esFDlvfAwiB9VpViMZCJyUu0AnYy+9ojVzOvMQ4udZM=; b=nU8KDuRJjoWey2SR8WKbSyiY4Akj+yBl9W2vNDKtfH1BcQjx8W4O8M/phgQpKnZB1b 9qFIeYBM1OXxterVT5cMVYh92My3LcSG3lpB4Q4h5y7vqnB1eZItNEHnpcw4pNgAscIv +MzfxgOgVw37sT789N60GIVjksxWZ5M+s0BMK0oDAbQGciP186Wui5zIPY5sKwyIC5Ya LMC3X6AjyO5P864KT3Q3/NvP9YPF+kvZHJCwaRnqIUyX+FyLzMTw+fHVRQn8QQiKFSH+ TEOrexflvvLBL+WhrrJ/VnYwQZeIQwje9Vm+QHB+vFrIEVDReXyoAObPDTv6fAmD9I/u D+Zg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:user-agent:message-id:date:subject:to:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=esFDlvfAwiB9VpViMZCJyUu0AnYy+9ojVzOvMQ4udZM=; b=bK7iznXwGv3ZbLOKi9c/DkSSipLumIdFT56ChMqIw/7vOO4KARCuR3puZfHoDPUCMJ udoo4aZICt2rb27OI5dC663SpO91cr5WG5Jc9OVBdmCpl+3TeKgH0wvbpHfQd8lt8/hY L+Cwn1jqplca68gUr5KkYSsoxbhRn/TDwUjBlIdN+2mI7dPVaZPlkj6sE7O6bsZ9mwxu 1FUeJ9usjMEESmUan5Ocz4aEP4llmZh1lXBXpB5UE290sDPmnXQdg+2dTVrimZFCgKj/ B6ekVPeEWinbJ3iIGbzVQlYp3Aa2AaNPV+wM+DXX5sQ1XgC1h2r26Ziv0Oht88j44Ff1 tnHg== X-Gm-Message-State: ANoB5pnrxXqkOBi3Upyks6bl0ToZf4EqJNxjCskpZWa+R+hx33iVwXv+ /AuJn6ZsWa3tNTGy/qVnqfuy9z8aRQk= X-Google-Smtp-Source: AA0mqf6HQbZIay9HGbll/whDihK7SSd1GkvQgcVWeUcC168yVWLWus/pztYsy86wubntOl0lY5hKvQ== X-Received: by 2002:a17:906:1614:b0:7aa:8f6c:334d with SMTP id m20-20020a170906161400b007aa8f6c334dmr17633064ejd.50.1671128087273; Thu, 15 Dec 2022 10:14:47 -0800 (PST) Received: from ars3 ([2a02:8109:8ac0:56d0::ea0f]) by smtp.gmail.com with ESMTPSA id d26-20020a1709067f1a00b00782e3cf7277sm7223641ejr.120.2022.12.15.10.14.45 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 15 Dec 2022 10:14:46 -0800 (PST) From: Augusto Stoffel To: bug-gnu-emacs@gnu.org Subject: 29.0.60; emacsclient adds unabbreviated names to file-name-history Date: Thu, 15 Dec 2022 19:14:45 +0100 Message-ID: <87wn6sleju.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=2a00:1450:4864:20::635; envelope-from=arstoffel@gmail.com; helo=mail-ej1-x635.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) 1. Start emacs -Q 2. M-x server-start RET 3. In a terminal, type /home/user/somefile Then "/home/user/somefile" is added to file-name-history. I would instead expect the abbreviated name, "~/somefile", to be added to history. In GNU Emacs 29.0.60 (build 3, x86_64-pc-linux-gnu, GTK+ Version 3.24.35, cairo version 1.17.6) of 2022-12-12 built on ars3 Repository revision: 14ac927aa61200485b87d035ca5797d8e89ffb7e Repository branch: emacs-29-grep-heading System Description: Fedora Linux 37 (Workstation Edition) Configured using: 'configure --with-pgtk' From debbugs-submit-bounces@debbugs.gnu.org Sat Dec 17 07:48:39 2022 Received: (at 60097) by debbugs.gnu.org; 17 Dec 2022 12:48:39 +0000 Received: from localhost ([127.0.0.1]:55748 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p6WcJ-0000Uu-86 for submit@debbugs.gnu.org; Sat, 17 Dec 2022 07:48:39 -0500 Received: from eggs.gnu.org ([209.51.188.92]:39674) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p6WcH-0000Uo-Vw for 60097@debbugs.gnu.org; Sat, 17 Dec 2022 07:48:38 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p6WcC-00033V-L4; Sat, 17 Dec 2022 07:48:32 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=YuSYqmUTou2ch+oEAWn9lSuP1sw+ZolLoKmKnR8ySLE=; b=FbxVqUZ95H3S bRWtXmlc6cVKNHJAIIEt/WfzMjQglYikTP6MLCN71Yhoz/xzsETvKU3T5pr43WKb17O3J71KtSs/b B8gEUMdienhGP8JE7YkS4syB0eZJYNIm8hO7US/zLd5gbwiv+h8Vi2X4VlIveKEd7PU6oZvXKZKCC z079EolPYIBdTk6YJp9FFJWlE9ZJglbgggSPKTpHvLTHppiGSIyjjpAR1ajEzbFd7wUcROhZk3nqD OQ4LjutaIKl5b08UOg0mfVpkT8G2YpGj8c7i26GU/dk1pdijLwM/1dW3GSAtZxyDRt179+01hGlw9 lSBcPVEVhc/RBbSYcbfnkA==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p6WcC-0007Zs-3l; Sat, 17 Dec 2022 07:48:32 -0500 Date: Sat, 17 Dec 2022 14:48:36 +0200 Message-Id: <83wn6qgpqz.fsf@gnu.org> From: Eli Zaretskii To: Augusto Stoffel In-Reply-To: <87wn6sleju.fsf@gmail.com> (message from Augusto Stoffel on Thu, 15 Dec 2022 19:14:45 +0100) Subject: Re: bug#60097: 29.0.60; emacsclient adds unabbreviated names to file-name-history References: <87wn6sleju.fsf@gmail.com> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 60097 Cc: 60097@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Augusto Stoffel > Date: Thu, 15 Dec 2022 19:14:45 +0100 > > > 1. Start emacs -Q > 2. M-x server-start RET > 3. In a terminal, type /home/user/somefile I guess you meant to type "emacsclient /home/user/somefile"? > Then "/home/user/somefile" is added to file-name-history. I would > instead expect the abbreviated name, "~/somefile", to be added to > history. Does the patch below do what you want? Btw, we don't do this consistently: "C-x C-f" doesn't record the abbreviated file name, it records the original one. diff --git a/lisp/server.el b/lisp/server.el index fd740d1..d963ee5 100644 --- a/lisp/server.el +++ b/lisp/server.el @@ -1495,7 +1495,7 @@ server-visit-files minibuffer-auto-raise)) (filen (car file)) (obuf (get-file-buffer filen))) - (add-to-history 'file-name-history filen) + (file-name-history--add filen) (if (null obuf) (progn (run-hooks 'pre-command-hook) From debbugs-submit-bounces@debbugs.gnu.org Mon Dec 19 05:21:00 2022 Received: (at 60097) by debbugs.gnu.org; 19 Dec 2022 10:21:00 +0000 Received: from localhost ([127.0.0.1]:38219 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p7DGW-0003Xh-FN for submit@debbugs.gnu.org; Mon, 19 Dec 2022 05:21:00 -0500 Received: from mail-ej1-f52.google.com ([209.85.218.52]:42962) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p7DGU-0003XZ-Mc for 60097@debbugs.gnu.org; Mon, 19 Dec 2022 05:20:59 -0500 Received: by mail-ej1-f52.google.com with SMTP id tz12so20265596ejc.9 for <60097@debbugs.gnu.org>; Mon, 19 Dec 2022 02:20:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=FyVZ6c3FM4GtahIo0e3lWSe71xa3THI8H54IxqNON0Q=; b=O7adHzCG73mgAfU4t/enMjJ7+H6cse77X7jDR4JdAPifWDUQUWoGGXXSpuLcuW+aHA /m9vfXEEi/vK7pG3pXWqAgRt4bkrmRC4et+Cllrei+hiPRaLZei1s3bs/lstKtYdyv6F stooTTnkcv5UR+CMdE/7Q1PtvBafrniQjPF5X5PYGFQVKyoZ/r0cgg8n4CW5RIu78feZ e17V16e2TMFz+FQvymPicBoNsGv6vR/2kDzdLVeCxk8eb3spWhFMAYQ7B6b4kh5IJqFR fydsaXETTm9/UM8YXV11g0Smroa/WYTG+Uwf8gJZ7hkr/MrJoyRwm/iQFRbUDP2tEb0U fZyw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=FyVZ6c3FM4GtahIo0e3lWSe71xa3THI8H54IxqNON0Q=; b=CJ9bq3Ai8fMD+Bp6wkDI6mDgJ8s+g7UhabPSn0f8msOvnf5fIccuwAdF251ic0MNsF cLf9qjVb+SEuUY5nIQVhX3CHEJ5KoF8W6fR5mK4IEoG01Z1/wY7bT1+BJohsRCt5K4dg MVhZsijNXyXJaTckYQP/9ILRfpb6sXUkwYOsp+8V3u4SscSzAyk1qd/k/ymq8hSRSwGM Q3hlYvcekQDQKqp3lGQiudSAArjLSPvZTx4QaNHXyVAJu+/glSdIcGPRIujPVWBioDS7 GeyySwX8mBUYgO8Mp0ePuTA2wYmiKA9c8YIiHFR45u4JbUZS717IUtecFLrtNc6G5fii lVuw== X-Gm-Message-State: ANoB5pk+9G3k4ql+ScIEjcTLKrKwAlsa8blRTMQ95tWHSsBmKGmQogb/ r0NGrh1V1HHI0Jmo1qbv0aZ5jUHbzXs= X-Google-Smtp-Source: AA0mqf7ITnyAdM9EyO9+TkumNbdpPfpLoF2a8gon6nZmGisFARV4rcNtUq549G68Hi6zjHIX+RdzfQ== X-Received: by 2002:a17:906:34c5:b0:7ae:e886:8ccb with SMTP id h5-20020a17090634c500b007aee8868ccbmr50245304ejb.14.1671445250253; Mon, 19 Dec 2022 02:20:50 -0800 (PST) Received: from ars3 ([2a02:8109:8ac0:56d0::a34]) by smtp.gmail.com with ESMTPSA id lb2-20020a170907784200b0078db5bddd9csm4172959ejc.22.2022.12.19.02.20.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 19 Dec 2022 02:20:49 -0800 (PST) From: Augusto Stoffel To: Eli Zaretskii Subject: Re: bug#60097: 29.0.60; emacsclient adds unabbreviated names to file-name-history In-Reply-To: <83wn6qgpqz.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 17 Dec 2022 14:48:36 +0200") References: <87wn6sleju.fsf@gmail.com> <83wn6qgpqz.fsf@gnu.org> Date: Mon, 19 Dec 2022 11:20:47 +0100 Message-ID: <874jtritj4.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 60097 Cc: 60097@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Sat, 17 Dec 2022 at 14:48, Eli Zaretskii wrote: > Does the patch below do what you want? Yes, exactly. > Btw, we don't do this consistently: "C-x C-f" doesn't record the > abbreviated file name, it records the original one. Indeed. But at least one is induced to type abbreviated file names, so I don't have a strong opinion. The problem that need fixing IMO is, say, when opening a file by clicking it in a file manager, in which case the absolute file name is passed and the user has no control over this. From debbugs-submit-bounces@debbugs.gnu.org Mon Dec 19 08:34:43 2022 Received: (at 60097-done) by debbugs.gnu.org; 19 Dec 2022 13:34:43 +0000 Received: from localhost ([127.0.0.1]:38523 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p7GHy-0002Qe-QU for submit@debbugs.gnu.org; Mon, 19 Dec 2022 08:34:43 -0500 Received: from eggs.gnu.org ([209.51.188.92]:59114) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p7GHw-0002QQ-Mr for 60097-done@debbugs.gnu.org; Mon, 19 Dec 2022 08:34:42 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p7GHr-0006Vt-Cl; Mon, 19 Dec 2022 08:34:35 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=v8Axv+PCRVckn4A+0R094khlkiuPt2UxDmmcZcTHA5E=; b=XsJB+Bv4Kc+9 SNIS9I67G2P6aLcRlDkeyRzFqxlnHYeGesuwf7tgTucPTv1LKCFN7H1G69geYIuM4vSCbh4lkpxDi 4aBR/moIJZ6Ge22YvXURl7qEN+bfKLR8octqdeZqIGBJXLbOdSCeOTLUASqHLl+SjwNOUJBYCOpnZ NZgd+jx2MmP6boj7He7XEsnVgOqq9njhRF+E+ZNsAVOoGTDZEGb1NK+pY1DhfwCyUDAJsAPmmiRbJ AQPfGRcjgEf13fEWk/RmKn/TV3nDlvAvO1oxa6loUDVgz38H1ZGSX4R/+w2NYdqezJUpztmOwJjui tnC5VEsRbiaIiVPgb1Adjg==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p7GHq-0005Da-Jb; Mon, 19 Dec 2022 08:34:34 -0500 Date: Mon, 19 Dec 2022 15:34:45 +0200 Message-Id: <83edsvecui.fsf@gnu.org> From: Eli Zaretskii To: Augusto Stoffel In-Reply-To: <874jtritj4.fsf@gmail.com> (message from Augusto Stoffel on Mon, 19 Dec 2022 11:20:47 +0100) Subject: Re: bug#60097: 29.0.60; emacsclient adds unabbreviated names to file-name-history References: <87wn6sleju.fsf@gmail.com> <83wn6qgpqz.fsf@gnu.org> <874jtritj4.fsf@gmail.com> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 60097-done Cc: 60097-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Augusto Stoffel > Cc: 60097@debbugs.gnu.org > Date: Mon, 19 Dec 2022 11:20:47 +0100 > > On Sat, 17 Dec 2022 at 14:48, Eli Zaretskii wrote: > > > Does the patch below do what you want? > > Yes, exactly. Thanks, installed on the emacs-29 branch. > > Btw, we don't do this consistently: "C-x C-f" doesn't record the > > abbreviated file name, it records the original one. > > Indeed. But at least one is induced to type abbreviated file names, so > I don't have a strong opinion. The problem that need fixing IMO is, > say, when opening a file by clicking it in a file manager, in which case > the absolute file name is passed and the user has no control over this. OK, so now we are at least a bit more consistent. Closing. From unknown Mon Aug 18 04:02:59 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Tue, 17 Jan 2023 12:24:11 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator