From debbugs-submit-bounces@debbugs.gnu.org Thu Dec 15 08:01:13 2022 Received: (at submit) by debbugs.gnu.org; 15 Dec 2022 13:01:13 +0000 Received: from localhost ([127.0.0.1]:42952 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p5nrM-0005lt-Gq for submit@debbugs.gnu.org; Thu, 15 Dec 2022 08:01:13 -0500 Received: from lists.gnu.org ([209.51.188.17]:57298) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p5nrH-0005ln-E8 for submit@debbugs.gnu.org; Thu, 15 Dec 2022 08:01:10 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p5nr5-0000ib-Ku for bug-gnu-emacs@gnu.org; Thu, 15 Dec 2022 08:01:03 -0500 Received: from out4-smtp.messagingengine.com ([66.111.4.28]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p5nr2-0000Mt-0h for bug-gnu-emacs@gnu.org; Thu, 15 Dec 2022 08:00:55 -0500 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id C61105C019F; Thu, 15 Dec 2022 07:55:37 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Thu, 15 Dec 2022 07:55:37 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= secure.kjonigsen.net; h=cc:content-type:date:date:from:from :in-reply-to:message-id:mime-version:reply-to:sender:subject :subject:to:to; s=fm1; t=1671108937; x=1671195337; bh=cjRSQWD/Ud /NnMHSMzD10/i30BeUJcCFd6j9avn3Eko=; b=dd4ORsyL0GMVbKKNj54mA+HXUe 8YHDExyuW8dXJDdCV4q7SyW5TdokHtnZt39F1SmWyvUxDqLyI47mkAcuAiJYxgS8 oLKvQ33NL4eLrcrjthiUPaq0hQPy5nks4WvExFeVpK5BBPHW+5l0bf7fRJZAaS/O RJY/szhZyTCg+oXSShdpFrZINpAfDR/6TDaUOArRY/iOEr4u1SbC7fQK1cy34a23 shbYcf3Xicy9Q8KU9nNTZKpLK8YvT/SVs06RGNdqpwgY40oVVPrk3kQuMQb7jPT2 XJ0ynzkZUHo/zuPyPDFjMK51LABRb8cbebvLYyfiP9aDxInqRxuNKnzfXX5w== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:message-id:mime-version :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1671108937; x= 1671195337; bh=cjRSQWD/Ud/NnMHSMzD10/i30BeUJcCFd6j9avn3Eko=; b=X KtisOj9zIT31X6i5lWINgWhv3A89+499cEkibWYJyHHyQ9vuelMlnHfDIOOnKPNr pKQi+/TeQG8aKci+l3msn4KIWCj1nPdVvU1njKXh8CHGLMDMiQhwx7vHBznRk578 DOOrBjff6O0bZfROBR//dbeNftvvStmMapyg/lMyvMHk5m3dAzOuCZfBgyAUbgqR reEgQ6GXuusInvRtZlPbj0c/H+HAsdUvYXnBjCN2YkJ6oigVRlC4pJmzxT2JG+vj WOxdRNYOpbc992GXv9iVd3yiO9CbBaLABhiJGwn2U8E/PChV7/WW16VzoTwS5KrQ m3tgd6e05maRPlRCCL6uA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrfeehgdeggecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpegtkfffgggfvffhufesmhdtreertdefjeenucfhrhhomheplfhoshhtvghinhcu mfhjpphnihhgshgvnhcuoehjohhsthgvihhnsehsvggtuhhrvgdrkhhjohhnihhgshgvnh drnhgvtheqnecuggftrfgrthhtvghrnhepudegvdfhvddujeffvefhudeljeeitedukeff hfefteevjedvfeegleevuddvtdevnecuffhomhgrihhnpehgihhthhhusgdrtghomhdpkh hjnhhighhsvghnrdhnohenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgr ihhlfhhrohhmpehjohhsthgvihhnsehsvggtuhhrvgdrkhhjohhnihhgshgvnhdrnhgvth X-ME-Proxy: Feedback-ID: ib2f84088:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 15 Dec 2022 07:55:36 -0500 (EST) Content-Type: multipart/mixed; boundary="------------YJk1JKRERc6QbegAIMSE9ND9" Message-ID: <60949726-279b-67c6-e960-0f6d6d158009@secure.kjonigsen.net> Date: Thu, 15 Dec 2022 13:55:36 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Content-Language: en-US To: "bug-gnu-emacs@gnu.org" , =?UTF-8?B?Sm/Do28gVMOhdm9yYQ==?= From: =?UTF-8?Q?Jostein_Kj=c3=b8nigsen?= Subject: 29.0.60; eglot doesn't support csharp-ls language server [PATCH] Received-SPF: pass client-ip=66.111.4.28; envelope-from=jostein@secure.kjonigsen.net; helo=out4-smtp.messagingengine.com X-Spam_score_int: -26 X-Spam_score: -2.7 X-Spam_bar: -- X-Spam_report: (-2.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.6 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.6 (--) This is a multi-part message in MIME format. --------------YJk1JKRERc6QbegAIMSE9ND9 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Right now eglot only knows about the Omnisharp Roslyn language server for C#. csharp-ls[1] is another popular language server and is supported by other LSP-clients, like lsp-mode. Eglot should support it too. Attached is a patch which introduces support for this language-server. [1] https://github.com/razzmatazz/csharp-language-server -- Jostein In GNU Emacs 29.0.60 (build 7, x86_64-pc-linux-gnu, GTK+ Version  3.24.33, cairo version 1.16.0) of 2022-12-15 built on dev-jostein Repository revision: 98ea7054a71d73f2eaaa802645a932580ede9ec9 Repository branch: emacs-29 Windowing system distributor 'The X.Org Foundation', version 11.0.12201001 System Description: Ubuntu 22.04.1 LTS Configured using:  'configure --with-json --with-tree-sitter' Configured features: ACL CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GPM GSETTINGS HARFBUZZ JPEG JSON LCMS2 LIBOTF LIBSELINUX LIBSYSTEMD LIBXML2 M17N_FLT MODULES NOTIFY INOTIFY PDUMPER PNG RSVG SECCOMP SOUND THREADS TIFF TOOLKIT_SCROLL_BARS TREE_SITTER X11 XDBE XIM XINPUT2 XPM GTK3 ZLIB Important settings:   value of $LC_MONETARY: nb_NO.UTF-8   value of $LC_NUMERIC: nb_NO.UTF-8   value of $LC_TIME: nb_NO.UTF-8   value of $LANG: en_US.UTF-8   locale-coding-system: utf-8-unix Major mode: NEWS Minor modes in effect:   global-git-commit-mode: t   magit-auto-revert-mode: t   dap-tooltip-mode: t   dap-ui-many-windows-mode: t   dap-ui-controls-mode: t   dap-ui-mode: t   dap-auto-configure-mode: t   dap-mode: t   flyspell-mode: t   treemacs-filewatch-mode: t   treemacs-follow-mode: t   treemacs-git-mode: t   treemacs-fringe-indicator-mode: t   editorconfig-mode: t   which-function-mode: t   outline-minor-mode: t   helm-mode: t   helm-minibuffer-history-mode: t   shell-dirtrack-mode: t   helm--remap-mouse-mode: t   async-bytecomp-package-mode: t   delete-selection-mode: t   global-auto-revert-mode: t   yas-global-mode: t   yas-minor-mode: t   global-nlinum-mode: t   nlinum-mode: t   ido-yes-or-no-mode: t   override-global-mode: t   server-mode: t   global-hl-line-mode: t   pixel-scroll-precision-mode: t   doom-modeline-mode: t   tooltip-mode: t   global-eldoc-mode: t   show-paren-mode: t   electric-indent-mode: t   mouse-wheel-mode: t   menu-bar-mode: t   file-name-shadow-mode: t   global-font-lock-mode: t   font-lock-mode: t   blink-cursor-mode: t   column-number-mode: t   line-number-mode: t   transient-mark-mode: t   auto-composition-mode: t   auto-encryption-mode: t   auto-compression-mode: t   button-mode: t Load-path shadows: /home/jostein/.emacs.d/elpa/transient-20221202.1727/transient hides /home/jostein/build/emacs/lisp/transient Features: (shadow sort emacsbug mule-util emacs-news-mode csharp-mode cc-langs eglot external-completion array jsonrpc ert flymake-proc flymake help-fns radix-tree cl-print tabify misearch multi-isearch rng-xsd xsd-regexp rng-cmpct rng-nxml rng-valid rng-loc rng-uri rng-parse nxml-parse rng-match rng-dt rng-util rng-pttrn nxml-ns nxml-mode nxml-outln nxml-rap nxml-util nxml-enc xmltok git-rebase vc-hg vc-bzr vc-src vc-sccs vc-cvs vc-rcs log-view vc bug-reference mail-extr magit-extras magit-submodule magit-obsolete magit-blame magit-stash magit-reflog magit-bisect magit-push magit-pull magit-fetch magit-clone magit-remote magit-commit magit-sequence magit-notes magit-worktree magit-tag magit-merge magit-branch magit-reset magit-files magit-refs magit-status magit magit-repos magit-apply magit-wip magit-log magit-diff smerge-mode diff git-commit log-edit message sendmail rfc822 mml mml-sec epa derived mm-decode mm-bodies mm-encode mail-parse rfc2231 rfc2047 rfc2045 ietf-drums mailabbrev gmm-utils mailheader pcvs-util magit-core magit-autorevert magit-margin magit-transient magit-process with-editor magit-mode transient magit-git magit-base magit-section crm compat-27 compat-26 yank-media sgml-mode facemenu dired-aux lsp-diagnostics lsp-headerline lsp-icons lsp-modeline dap-mouse dap-ui gdb-mi bindat gud bui bui-list bui-info bui-entry bui-core bui-history bui-button bui-utils lsp-lens dap-gdb-lldb dap-netcore dap-node dap-utils dap-pwsh dap-python dap-mode dap-tasks dap-launch posframe dap-overlays view typescript-ts-mode js cc-mode cc-fonts cc-guess cc-menus cc-cmds cc-styles cc-align cc-engine cc-vars cc-defs executable helm-command helm-elisp helm-eval edebug debug backtrace helm-info face-remap disp-table elec-pair flyspell ispell toml-ts-mode treesit vc-git diff-mode vc-dispatcher vc-svn winner ffap tramp-archive tramp-gvfs tramp-cache time-stamp zeroconf dbus add-log lsp-zig lsp-steep lsp-svelte lsp-sqls lsp-ruby-syntax-tree lsp-yaml lsp-xml lsp-vimscript lsp-vhdl lsp-volar lsp-vetur lsp-html lsp-verilog lsp-vala lsp-v lsp-typeprof lsp-ttcn3 lsp-toml lsp-terraform lsp-tex lsp-sorbet lsp-solargraph lsp-rust lsp-rf lsp-remark lsp-racket lsp-r lsp-purescript lsp-pylsp lsp-pyls lsp-pwsh lsp-php lsp-pls lsp-perlnavigator lsp-perl lsp-openscad lsp-ocaml lsp-magik lsp-nix lsp-nim lsp-nginx lsp-mint lsp-marksman lsp-markdown lsp-lua lsp-kotlin lsp-json lsp-javascript lsp-idris lsp-haxe lsp-groovy lsp-hack lsp-graphql lsp-gleam lsp-go lsp-completion lsp-gdscript lsp-fsharp lsp-fortran lsp-eslint lsp-erlang lsp-emmet lsp-elixir lsp-elm lsp-dockerfile lsp-docker yaml lsp-dhall lsp-d lsp-css lsp-csharp gnutls lsp-crystal lsp-cmake lsp-clojure lsp-treemacs lsp-treemacs-generic lsp-treemacs-themes treemacs-treelib treemacs treemacs-header-line treemacs-compatibility treemacs-mode treemacs-interface treemacs-persistence treemacs-filewatch-mode treemacs-follow-mode treemacs-rendering treemacs-annotations treemacs-async treemacs-workspaces treemacs-dom treemacs-visuals treemacs-fringe-indicator treemacs-scope pulse treemacs-faces treemacs-icons treemacs-themes treemacs-core-utils pfuture treemacs-logging treemacs-customization treemacs-macros lsp-semantic-tokens lsp-clangd lsp-beancount lsp-bash lsp-astro lsp-ansible lsp-angular lsp-ada warnings lsp-actionscript ido-completing-read+ memoize minibuf-eldef elisp-slime-nav paredit lsp-mode lsp-protocol tree-widget spinner network-stream nsm markdown-mode color lv inline ht ewoc epg rfc6068 epg-config highlight-symbol flycheck editorconfig editorconfig-core editorconfig-core-handle editorconfig-fnmatch company-oddmuse company-keywords company-etags etags fileloop generator company-gtags company-dabbrev-code company-dabbrev company-files company-clang company-capf company-cmake company-semantic company-template company-bbdb company which-func hideshow eww url-queue thingatpt shr pixel-fill kinsoku url-file svg xml dom puny mm-url gnus nnheader gnus-util mail-utils range mm-util mail-prsvr helm-imenu pcase imenu ob-plantuml org ob ob-tangle ob-ref ob-lob ob-table ob-exp org-macro org-src ob-comint org-pcomplete org-list org-footnote org-faces org-entities noutline outline ob-emacs-lisp ob-core ob-eval org-cycle org-table ol org-fold org-fold-core org-keys oc org-loaddefs find-func cal-menu calendar cal-loaddefs org-version org-compat org-macs helm-mode helm-misc helm-files image-dired image-dired-tags image-dired-external image-dired-util xdg image-mode dired dired-loaddefs exif tramp tramp-loaddefs trampver tramp-integration cus-edit pp cus-load icons wid-edit files-x tramp-compat shell pcomplete parse-time iso8601 time-date ls-lisp helm-buffers helm-occur helm-tags helm-locate helm-grep helm-regexp format-spec helm-utils helm-help helm-types helm helm-global-bindings helm-easymenu helm-core async-bytecomp helm-source helm-multi-match helm-lib async helm-config delsel autorevert filenotify yasnippet nlinum linum ido-yes-or-no advice ido edmacro kmacro use-package-bind-key bind-key easy-mmode xref project server hl-line pixel-scroll cua-base compile-eslint compile comint ansi-osc ansi-color ring doom-modeline doom-modeline-segments doom-modeline-env doom-modeline-core all-the-icons all-the-icons-faces data-material data-weathericons data-octicons data-fileicons data-faicons data-alltheicons shrink-path rx f f-shortdoc shortdoc text-property-search s dash compat compat-macs dracula-theme cl-extra help-mode use-package-ensure use-package-core finder-inf expand-region-autoloads ido-yes-or-no-autoloads doom-modeline-autoloads elisp-slime-nav-autoloads multiple-cursors-autoloads dracula-theme-autoloads crontab-mode-autoloads highlight-symbol-autoloads ssh-config-mode-autoloads dap-mode-autoloads lsp-treemacs-autoloads treemacs-autoloads cfrs-autoloads posframe-autoloads powershell-autoloads company-web-autoloads shrink-path-autoloads paredit-autoloads bui-autoloads all-the-icons-autoloads rust-mode-autoloads yaml-mode-autoloads helm-autoloads popup-autoloads helm-core-autoloads async-autoloads lsp-docker-autoloads yaml-autoloads lsp-mode-autoloads spinner-autoloads f-autoloads hydra-autoloads nlinum-autoloads ht-autoloads undo-tree-autoloads queue-autoloads ace-window-autoloads avy-autoloads cmake-mode-autoloads bmx-mode-autoloads s-autoloads company-autoloads ido-completing-read+-autoloads memoize-autoloads lv-autoloads magit-autoloads magit-section-autoloads git-commit-autoloads with-editor-autoloads transient-autoloads compat-autoloads editorconfig-autoloads yasnippet-autoloads web-completion-data-autoloads cargo-autoloads markdown-mode-autoloads pfuture-autoloads flycheck-autoloads pkg-info-autoloads epl-autoloads info dash-autoloads package browse-url url url-proxy url-privacy url-expand url-methods url-history url-cookie generate-lisp-file url-domsuf url-util mailcap url-handlers url-parse auth-source cl-seq eieio eieio-core cl-macs password-cache json subr-x map byte-opt gv bytecomp byte-compile url-vars cl-loaddefs cl-lib rmc iso-transl tooltip cconv eldoc paren electric uniquify ediff-hook vc-hooks lisp-float-type elisp-mode mwheel term/x-win x-win term/common-win x-dnd tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow isearch easymenu timer select scroll-bar mouse jit-lock font-lock syntax font-core term/tty-colors frame minibuffer nadvice seq simple cl-generic indonesian philippine cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite emoji-zwj charscript charprop case-table epa-hook jka-cmpr-hook help abbrev obarray oclosure cl-preloaded button loaddefs theme-loaddefs faces cus-face macroexp files window text-properties overlay sha1 md5 base64 format env code-pages mule custom widget keymap hashtable-print-readable backquote threads dbusbind inotify lcms2 dynamic-setting system-font-setting font-render-setting cairo move-toolbar gtk x-toolkit xinput2 x multi-tty make-network-process emacs) Memory information: ((conses 16 1130646 117537)  (symbols 48 60946 0)  (strings 32 291613 29702)  (string-bytes 1 8373686)  (vectors 16 160373)  (vector-slots 8 2626469 90522)  (floats 8 1114 778)  (intervals 56 70217 5529)  (buffers 984 64)) -- *Jostein Kjønigsen* jostein.kjønigsen.no jostein@kjonigsen.net - jostein@gmail.com --------------YJk1JKRERc6QbegAIMSE9ND9 Content-Type: text/x-patch; charset=UTF-8; name="0001-Eglot-Add-support-for-new-language-server-csharp-ls.patch" Content-Disposition: attachment; filename*0="0001-Eglot-Add-support-for-new-language-server-csharp-ls.pat"; filename*1="ch" Content-Transfer-Encoding: base64 RnJvbSA1NDY0MjgxZTJmZDE0YzY4MWZjMjNiMjc4YmMzOWFmNjM2ODJiZDJiIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiA9P1VURi04P3E/Sm9zdGVpbj0yMEtqPUMzPUI4bmln c2VuPz0gPGpvc3RlaW5Aa2pvbmlnc2VuLm5ldD4KRGF0ZTogVGh1LCAxNSBEZWMgMjAyMiAx Mzo0NDozOSArMDEwMApTdWJqZWN0OiBbUEFUQ0ggMS8yXSBFZ2xvdDogQWRkIHN1cHBvcnQg Zm9yIG5ldyBsYW5ndWFnZSBzZXJ2ZXI6IGNzaGFycC1scwoKQyMgaGFzIDIgcG9wdWxhciBs YW5ndWFnZSBzZXJ2ZXJzOiBPbW5pc2hhcnAgUm9zbHluIChhbHJlYWR5CnN1cHBvcnRlZCkg YW5kIGNzaGFycC1scyAobmV3ZXIsIG1vcmUgcGVyZm9ybWFudCkuCgoqIGxpc3AvcHJvZ21v ZGVzL2VnbG90LmVsOiBhZGQgbmV3IGMjIGxhbmd1YWdlIHNlcnZlciB0byBsaXN0LgotLS0K IGxpc3AvcHJvZ21vZGVzL2VnbG90LmVsIHwgNCArKystCiAxIGZpbGUgY2hhbmdlZCwgMyBp bnNlcnRpb25zKCspLCAxIGRlbGV0aW9uKC0pCgpkaWZmIC0tZ2l0IGEvbGlzcC9wcm9nbW9k ZXMvZWdsb3QuZWwgYi9saXNwL3Byb2dtb2Rlcy9lZ2xvdC5lbAppbmRleCA5YzVhMzYxZGY3 Yi4uODBhYWI3NzM2Y2IgMTAwNjQ0Ci0tLSBhL2xpc3AvcHJvZ21vZGVzL2VnbG90LmVsCisr KyBiL2xpc3AvcHJvZ21vZGVzL2VnbG90LmVsCkBAIC0yNDAsNyArMjQwLDkgQEAgZWdsb3Qt c2VydmVyLXByb2dyYW1zCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICgoY2xv anVyZS1tb2RlIGNsb2p1cmVzY3JpcHQtbW9kZSBjbG9qdXJlYy1tb2RlKQogICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgLiAoImNsb2p1cmUtbHNwIikpCiAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICgoY3NoYXJwLW1vZGUgY3NoYXJwLXRzLW1vZGUpCi0g ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAuICgib21uaXNoYXJwIiAiLWxzcCIp KQorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgLiAsKGVnbG90LWFsdGVybmF0 aXZlcworICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICcoKCJvbW5pc2hh cnAiICItbHNwIikKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICgi Y3NoYXJwLWxzIikpKSkKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgKHB1cmVz Y3JpcHQtbW9kZSAuICgicHVyZXNjcmlwdC1sYW5ndWFnZS1zZXJ2ZXIiICItLXN0ZGlvIikp CiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICgocGVybC1tb2RlIGNwZXJsLW1v ZGUpIC4gKCJwZXJsIiAiLU1QZXJsOjpMYW5ndWFnZVNlcnZlciIgIi1lIiAiUGVybDo6TGFu Z3VhZ2VTZXJ2ZXI6OnJ1biIpKQogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAo bWFya2Rvd24tbW9kZSAuICgibWFya3NtYW4iICJzZXJ2ZXIiKSkpCi0tIAoyLjM0LjEKCg== --------------YJk1JKRERc6QbegAIMSE9ND9-- From debbugs-submit-bounces@debbugs.gnu.org Thu Dec 15 16:28:42 2022 Received: (at 60089) by debbugs.gnu.org; 15 Dec 2022 21:28:42 +0000 Received: from localhost ([127.0.0.1]:45017 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p5vmU-0003xk-Ae for submit@debbugs.gnu.org; Thu, 15 Dec 2022 16:28:42 -0500 Received: from mail-ot1-f42.google.com ([209.85.210.42]:33748) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p5vmS-0003xe-11 for 60089@debbugs.gnu.org; Thu, 15 Dec 2022 16:28:41 -0500 Received: by mail-ot1-f42.google.com with SMTP id q18-20020a056830441200b006704633f258so312730otv.0 for <60089@debbugs.gnu.org>; Thu, 15 Dec 2022 13:28:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:to:subject:message-id:date:mime-version :references:in-reply-to:from:from:to:cc:subject:date:message-id :reply-to; bh=lzO6xhLCyUGnyPxf6Br252p97tkNITvWm1kSz2e23Ec=; b=dfECgGOIaWWY5KPzlPlhGwP1m5JumYK2SvhRE7jCjFBFu6+JbqDBUelZgHCnZJT1nh SZIV9yDaUgQHjzTs/q961TRUwQvhAdUTes2rR7y0RDh9pdyhEwhypSkaT5N9cLL4p75C Jl09SMGWZppkDcc21u3cjGOt6538RQTbOPXejt9jfXQZMsBacfc3xs05IBn1l2ZJCKqp vHBUatgp+PGumGDRd/komInPFOVj9mEskUmxgdd8av24xOI6SoqrUAxepQP1hsF/J+Rs 1TanYQRR3nb2jA2LUbl9oP4j87nWcJwH8+awEuJIL6E4tMOvdBVO3ybeCRA3YDjY4mJJ K1MA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:to:subject:message-id:date:mime-version :references:in-reply-to:from:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=lzO6xhLCyUGnyPxf6Br252p97tkNITvWm1kSz2e23Ec=; b=Aa4Oo7K3d1bpN9aenRC8w/tsBlZhwNbiI2z5009q/LvuyMH7NK94eYHE9XOI89WbvX zIXPf2Fmk/PDOR1qXx6JlNeKgRwbM5bv/kdJdScXfx6RAOfCVbaJcv2HuMuZVJzpMgvf R3Ppt190GaGNxVzFXeJChQGQl/KfoSYtNtnZJ5A8zX2OHUodUPkLZPTcsUSHFaDAaO3h Q7NuV6kBf+blQ/a+iMCWq7tSzibDfIrHxdHVpbcKa7PzxZWNf4e1unxxZwiDDoD0u5gN toG3Xxs4rl54bcX9ue/edvBZvyOelrQG2eUxKwmXqUDYLy3WB1yWuaqqTodbqQ5TYBGh n9Lw== X-Gm-Message-State: ANoB5pkW6Ze0nEwEXIaYw3YHQQTFOzYt89L8WJFG4sGbLL8T29CVTo5H dJLFjOlFsEXjyo8T4ROtNDjLgi3y6TYe5ikqg7g= X-Google-Smtp-Source: AA0mqf7OUNd8z+pTNy+QjeZgayqu2jrRpq0cEpj4ArAhQH8h4udAUy7ktq6mbsYD4frpODRD2QUThp/q/QTxytWQ7MQ= X-Received: by 2002:a05:6830:11cd:b0:66e:7741:ed1d with SMTP id v13-20020a05683011cd00b0066e7741ed1dmr12045657otq.224.1671139714340; Thu, 15 Dec 2022 13:28:34 -0800 (PST) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Thu, 15 Dec 2022 13:28:33 -0800 From: Stefan Kangas In-Reply-To: <60949726-279b-67c6-e960-0f6d6d158009@secure.kjonigsen.net> References: <60949726-279b-67c6-e960-0f6d6d158009@secure.kjonigsen.net> X-Hashcash: 1:20:221215:60089@debbugs.gnu.org::kMQyjJOf2Q+H2m+s:5Hqw MIME-Version: 1.0 Date: Thu, 15 Dec 2022 13:28:33 -0800 Message-ID: Subject: Re: bug#60089: 29.0.60; eglot doesn't support csharp-ls language server [PATCH] To: =?UTF-8?Q?Jostein_Kj=C3=B8nigsen?= , 60089@debbugs.gnu.org, joaotavora@gmail.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 60089 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Jostein Kj=C3=B8nigsen writes: > Right now eglot only knows about the Omnisharp Roslyn language server > for C#. > > csharp-ls[1] is another popular language server and is supported by > other LSP-clients, like lsp-mode. > > Eglot should support it too. > > Attached is a patch which introduces support for this language-server. > > [1] https://github.com/razzmatazz/csharp-language-server Could you give a rationale for why we should prefer omnisharp over csharp-ls? Why not the other way around? (I know nothing about C#.) From debbugs-submit-bounces@debbugs.gnu.org Thu Dec 15 16:50:00 2022 Received: (at 60089) by debbugs.gnu.org; 15 Dec 2022 21:50:00 +0000 Received: from localhost ([127.0.0.1]:45121 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p5w76-0004Ei-0T for submit@debbugs.gnu.org; Thu, 15 Dec 2022 16:50:00 -0500 Received: from out3-smtp.messagingengine.com ([66.111.4.27]:39513) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p5w74-0004Ec-Bm for 60089@debbugs.gnu.org; Thu, 15 Dec 2022 16:49:59 -0500 Received: from compute6.internal (compute6.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id E9F1A5C0131; Thu, 15 Dec 2022 16:49:52 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute6.internal (MEProxy); Thu, 15 Dec 2022 16:49:52 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= secure.kjonigsen.net; h=cc:cc:content-transfer-encoding :content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm1; t=1671140992; x=1671227392; bh=nDy2a4QS4g BCHh2Ksfa7whSUYklFOMx56b6piQmWL9I=; b=CgawgalazWz42uLBQCRXzDJxLE 45VHt58MwHkkrMQvoCMQ2zFa38knldfSsNnXwQDxzgpPp0wyX6nPmuctDDBHft41 yrtkYqFQ4NVpi/fjGWW5vE6r9refEoloA4WKiIzXp6/bTP6RyxPFnrlWLfuYrBIO XAXuxs3OCjqqfD/P9Q5xxf7iK1gjR1JRyUbXd4fG9tHAl1ySe4GKGzej/eLOPEJT WAD7aF5iZ/lW/ci7+FIjoF62gEGHSlYpVvY0wR8faCg89PpQoasQ6l2ZdOR2fjdq eUrerNiMhFq7MdCTRzqdKTkRbRMkONaTidy8cxaL31JxxJfzs8JCnrtNTh2A== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1671140992; x= 1671227392; bh=nDy2a4QS4gBCHh2Ksfa7whSUYklFOMx56b6piQmWL9I=; b=K W/ZBolPOT2UNfmT5+O9PMbirYw414uMA7jVuCebKwkQ6Tzh0fANbtNslANt2lASp ZNwWIQWauWBct5qrOadJxNqex+Te9F/JVrVCC5KqlQKl6sOxir2w1XVFsS/sa/ug vhj9lvHQqQdSh5yooKY0sYM78l6L3X9UVi+R5pxgXuD9VB7qefrb5Izs4m84rAtx SfpW4M2q917IG6ZofR36ufx/YrcuiBdrXvhTh3RDu4vPqXs5LhG8eIgHsCyO/22z IY4g1iE7gENhw66QGOY3Y1lzNvO+FXyCVJLmx+7YuBhM4ARMITRXdAWi+V2L2DPy tXOlDd0IwsyG0UjQRrDKw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrfeehgdduheduucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurheptgfghfggufffkfhfvegjvffosehtqhhmtdhhtdejnecuhfhrohhmpeflohhs thgvihhnucfmjhppnhhighhsvghnuceojhhoshhtvghinhesshgvtghurhgvrdhkjhhonh highhsvghnrdhnvghtqeenucggtffrrghtthgvrhhnpeekteegtdegjeettdehgedtieef hfegueelvdefvdfhvdfgteeuteduledthfejueenucffohhmrghinhepghhithhhuhgsrd gtohhmpdhkjhhnihhgshgvnhdrnhgvthenucevlhhushhtvghrufhiiigvpedtnecurfgr rhgrmhepmhgrihhlfhhrohhmpehjohhsthgvihhnsehsvggtuhhrvgdrkhhjohhnihhgsh gvnhdrnhgvth X-ME-Proxy: Feedback-ID: ib2f84088:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 15 Dec 2022 16:49:52 -0500 (EST) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable From: =?utf-8?Q?Jostein_Kj=C3=B8nigsen?= Mime-Version: 1.0 (1.0) Subject: Re: bug#60089: 29.0.60; eglot doesn't support csharp-ls language server [PATCH] Date: Thu, 15 Dec 2022 22:49:39 +0100 Message-Id: <49A0AC5D-0191-4D92-9B29-06BB086725AE@secure.kjonigsen.net> References: In-Reply-To: To: Stefan Kangas X-Mailer: iPhone Mail (20C65) X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 60089 Cc: 60089@debbugs.gnu.org, joaotavora@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) On 15 Dec 2022, at 22:28, Stefan Kangas wrote: >=20 > =EF=BB=BFJostein Kj=C3=B8nigsen writes: >=20 >> Right now eglot only knows about the Omnisharp Roslyn language server >> for C#. >>=20 >> csharp-ls[1] is another popular language server and is supported by >> other LSP-clients, like lsp-mode. >>=20 >> Eglot should support it too. >>=20 >> Attached is a patch which introduces support for this language-server. >>=20 >> [1] https://github.com/razzmatazz/csharp-language-server >=20 > Could you give a rationale for why we should prefer omnisharp over > csharp-ls? Why not the other way around? >=20 > (I know nothing about C#.) As far as presedence go, I have no personal preference here.=20 I myself use csharp-ls, because it=E2=80=99s faster, but it=E2=80=99s newer w= ith less lineage and only aims to support new =E2=80=9C.net core=E2=80=9D ty= pe projects.=20 Omnisharp is not as fast, but has been around for a longer time and official= ly also supports =E2=80=9Clegacy=E2=80=9D-style .net framework projects.=20 As such it probably make sense to present Omnisharp as the default, since it= offers the highest compatibility guarantees regardless of target code-base.= =20 =E2=80=94 Jostein Kj=C3=B8nigsen https://jostein.kj=C3=B8nigsen.net= From debbugs-submit-bounces@debbugs.gnu.org Thu Dec 15 21:24:23 2022 Received: (at 60089) by debbugs.gnu.org; 16 Dec 2022 02:24:23 +0000 Received: from localhost ([127.0.0.1]:46325 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p60Od-0007lj-CD for submit@debbugs.gnu.org; Thu, 15 Dec 2022 21:24:23 -0500 Received: from mail-oa1-f45.google.com ([209.85.160.45]:44754) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p60OW-0007lR-4k for 60089@debbugs.gnu.org; Thu, 15 Dec 2022 21:24:19 -0500 Received: by mail-oa1-f45.google.com with SMTP id 586e51a60fabf-1447c7aa004so1686263fac.11 for <60089@debbugs.gnu.org>; Thu, 15 Dec 2022 18:24:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date :mime-version:references:in-reply-to:from:from:to:cc:subject:date :message-id:reply-to; bh=FxnWvGAENZ5dQuS2YT8+Sn3OeR0yrw6ZUBWyTymXgtw=; b=gty2Msm5EIlULIuoJEFsyiZFpTPWENu4q1JFIjrcmOR/4PLKhrz/HwMPeX6soW5Wc3 ayZda2Ah0yJnuBjsFWtcNx89BwXV/6H657+VJVJFNjQuxwpA2c083CEhTHCSBS+7hBRL navdltk/H1bK/lxydlnGcKE8ybS1LNJpLdL9CNvfgHw043D5C9dFHOUiz1M5vbUwJZv+ h2jnQEQhLXw5RYbzkXn2lhXUi2BXEi2EGFJ5Baear1CL+wAiAi+j0+xWzRMwQXhcS3MD VMrkdISx+P4OazZahm9W4gV8/nvd9wo5Dy6psCbIfBbP0nfW75XkQ13IYbUWIzWEBuD3 +/WQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date :mime-version:references:in-reply-to:from:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=FxnWvGAENZ5dQuS2YT8+Sn3OeR0yrw6ZUBWyTymXgtw=; b=rmMSdrmzMFVNCPbRzSKf2sTN0XH9z6yJBHm5Rgr/rV0JidA0tSq3VIL3rwHFdzWtQp v7MQcAI9zLK1LPoGTyxA/HjmBNt4aZ6uTfMQL51VaHnxEiZjvbHupoUoQQ48evh19LrX uzcd6E07kvpYqEWLgOsjDdzOcDl/3m3QTNS8HehRj2famXFgBJ9+EJu0togZcesgjdoT B+BJ4lO3dbKwbzvG2FmR7mlvpWPcDwtdv3vE6MJRLccxIe2JHRYpfDLYVebb43gSsjHt 37i+OjR2miHKnCOO36CCtbMR/ZhguSs5DgDu7Twt5zvPWBjJ+7I5keTgzlTLlsFhu3WR kQrQ== X-Gm-Message-State: AFqh2kpHWdaZ8Z4hHZV+qiA+db8Z5c+ubSZb0cPHv97ce2l6EjCNbs6p fHJnCtnAIuinIGArJ9FZ+QRW7toxXTtZx1nKQwQ= X-Google-Smtp-Source: AMrXdXt6LjDF1+RnWRncnzTfcS/Qe4Bmt4LlRn6KhNNJWYOSY2Qh95TW6Q9BpAFeaTk/HV4S8BjpZqg4RSilPWGOoDA= X-Received: by 2002:a05:6870:ed4e:b0:145:3a7:99c with SMTP id ex14-20020a056870ed4e00b0014503a7099cmr324766oab.92.1671157450597; Thu, 15 Dec 2022 18:24:10 -0800 (PST) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Thu, 15 Dec 2022 18:24:10 -0800 From: Stefan Kangas In-Reply-To: <49A0AC5D-0191-4D92-9B29-06BB086725AE@secure.kjonigsen.net> References: <49A0AC5D-0191-4D92-9B29-06BB086725AE@secure.kjonigsen.net> X-Hashcash: 1:20:221216:60089@debbugs.gnu.org::pzXqW4Wqk4CbZjp9:DEFj MIME-Version: 1.0 Date: Thu, 15 Dec 2022 18:24:10 -0800 Message-ID: Subject: Re: bug#60089: 29.0.60; eglot doesn't support csharp-ls language server [PATCH] To: =?UTF-8?Q?Jostein_Kj=C3=B8nigsen?= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 60089 Cc: 60089@debbugs.gnu.org, joaotavora@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) close 60089 29.1 thanks Jostein Kj=C3=B8nigsen writes: > As such it probably make sense to present Omnisharp as the default, > since it offers the highest compatibility guarantees regardless of > target code-base. Thanks, so I pushed your patch to emacs-29 (commit 546aed3543). From unknown Tue Jun 17 20:32:45 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Fri, 13 Jan 2023 12:24:09 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator