GNU bug report logs - #60075
[PATCH 00/58] New julia patches

Previous Next

Package: guix-patches;

Reported by: Efraim Flashner <efraim <at> flashner.co.il>

Date: Wed, 14 Dec 2022 20:33:02 UTC

Severity: normal

Tags: patch

Done: Efraim Flashner <efraim <at> flashner.co.il>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: Efraim Flashner <efraim <at> flashner.co.il>
To: zimoun <zimon.toutoune <at> gmail.com>
Cc: 60075 <at> debbugs.gnu.org
Subject: [bug#60075] [PATCH 09/58] gnu: Add julia-irrationalconstants.
Date: Wed, 21 Dec 2022 19:09:17 +0200
[Message part 1 (text/plain, inline)]
On Mon, Dec 19, 2022 at 07:11:32PM +0100, zimoun wrote:
> Hi,
> 
> On Wed, 14 Dec 2022 at 22:35, Efraim Flashner <efraim <at> flashner.co.il> wrote:
> > * gnu/packages/julia-xyz.scm (julia-irrationalconstants): New variable.
> 
> [...]
> 
> > +    (description "This package defines the following irrational constants in Julia.")
> 
> This description looks incomplete.  I suggest to replace by:
> 
> --8<---------------cut here---------------start------------->8---
> This package defines more irrational constants in Julia.
> --8<---------------cut here---------------end--------------->8---
> 
> or by:
> 
> --8<---------------cut here---------------start------------->8---
> +      (description "This package provides these irrational constants:
> +@itemize
> +@item
> +@item twoπ       = 2π
> +@item fourπ      = 4π
> +@item halfπ      = π / 2
> +@item quartπ     = π / 4
> +@item invπ       = 1 / π
> +@item twoinvπ    = 2 / π
> +@item fourinvπ   = 4 / π
> +@item inv2π      = 1 / (2π)
> +@item inv4π      = 1 / (4π)
> +@item sqrt2      = √2
> +@item sqrt3      = √3
> +@item sqrtπ      = √π
> +@item sqrt2π     = √2π
> +@item sqrt4π     = √4π
> +@item sqrthalfπ  = √(π / 2)
> +@item invsqrt2   = 1 / √2
> +@item invsqrtπ   = 1 / √π
> +@item invsqrt2π  = 1 / √2π
> +@item loghalf    = log(1 / 2)
> +@item logtwo     = log(2)
> +@item logten     = log(10)
> +@item logπ       = log(π)
> +@item log2π      = log(2π)
> +@item log4π      = log(4π)
> +@end itemize")
> --8<---------------cut here---------------end--------------->8---
> 
> With a preference for the latter.

I'd argue that the original doesn't just look incomplete, it's not a
full sentence. I've gone with the second.

-- 
Efraim Flashner   <efraim <at> flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted
[signature.asc (application/pgp-signature, inline)]

This bug report was last modified 2 years and 244 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.