From debbugs-submit-bounces@debbugs.gnu.org Wed Dec 14 15:21:42 2022 Received: (at submit) by debbugs.gnu.org; 14 Dec 2022 20:21:43 +0000 Received: from localhost ([127.0.0.1]:41372 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p5YG6-0001JR-Fd for submit@debbugs.gnu.org; Wed, 14 Dec 2022 15:21:42 -0500 Received: from lists.gnu.org ([209.51.188.17]:39322) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p5YG3-0001JL-4f for submit@debbugs.gnu.org; Wed, 14 Dec 2022 15:21:41 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p5YG2-00039d-RZ for bug-gnu-emacs@gnu.org; Wed, 14 Dec 2022 15:21:38 -0500 Received: from mail-bn7nam10olkn2082e.outbound.protection.outlook.com ([2a01:111:f400:7e8a::82e] helo=NAM10-BN7-obe.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p5YG1-0004aJ-1z for bug-gnu-emacs@gnu.org; Wed, 14 Dec 2022 15:21:38 -0500 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HcdJYnRJkVTZV0C7EqgmbrfQn1Hq4k6Ts0SI90xOqp1xpE6eYnm9xtyuHAhENWXby0DklIyOdahEYGDL7SPi89KJpMqTsZjGJU1cKRewtlWClqSpMBaIdnCq3efps8i5BXFUY0ZfarXBPBAa/+CphXtwiSvDwnCKRwtk8ZDN+fTa/3Ry5eSI+CYVO6c4WCpjspeSH3njB7XQCDAjeP5QmfOXQ4LhbBYwBhaTpiVYWcEntZy6QFQrd6rk3rd53WcpqLVsVdmxTUiamms3/+oYkjDU3kZ2uNHBWCiYiV8gqOEaw56VBhZvHZ44wL2xWIxHWc6MQo0w3voZwixBrYowmg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=QZw0lFek7mIXY0TJ9cS+GOqiZ3pFQyYT8Oswd/ZtN34=; b=dDoDWY7+h2KZKwRiWID9LOh931mDpOT3fSJjVjsotd54CuHCdOsUgFd4y6+TVEdmWoyivcNNyw+Y4/yr5GYEx3+noRUAizXGg2n1n8cVp6NlEKLDhu5Bi2/MB7u6RV9WAlsxEReq3ep/43OI+nd+2PjEiWKpgQokChFiQYpYoTysYnsGUQPiR1ecqzhTFM9FKGEpL6a06tJBzR5sa+VWy6aDHCR6KtAfed1xNhiXDZj/E6N1bSojBMHKEnupk8uQQbHvKisoizKE9mcDOkkNT7z0yNvWxim08mOxbSi0ad6KcEqqp3iJXJbR7GpTlOEAw4iwpWigqoO/Qq+yNhg3Cg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hotmail.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=QZw0lFek7mIXY0TJ9cS+GOqiZ3pFQyYT8Oswd/ZtN34=; b=tjUGqipnm36sa3sdEkuTW9GQXpbv3EZOjAYpBwslk5BcMyOAiCxzg+YtBxGz9kUz96UYuMhVt75RThZYh0LKym9UyVzHmYbQj+CIetU58dvNJVSjLWcg9LFRwdvNq8013mQXcBgsXWccW5k26bAdEIJz3cTk3n6cr5en1i2XCPSDJNJxXcVmZ/YQ6DbhgGHrflRVL1NVUwBqXRc9d1zwrgbZ750Kw6mhHOERFWAKiK16ehZPJXtwQmFwJZtm0bNlcFtmLmPmsJ4mDwvY5ZLFzTcErxXwnZyWNFinsa8curld5+8fQeNweXQNm93QAivr8kSTT49bJ3AUJ3ErTcWsfA== Received: from PH8PR19MB7070.namprd19.prod.outlook.com (2603:10b6:510:222::9) by BY5PR19MB4113.namprd19.prod.outlook.com (2603:10b6:a03:22f::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5924.11; Wed, 14 Dec 2022 20:16:30 +0000 Received: from PH8PR19MB7070.namprd19.prod.outlook.com ([fe80::32c9:7ad8:d88f:a199]) by PH8PR19MB7070.namprd19.prod.outlook.com ([fe80::32c9:7ad8:d88f:a199%5]) with mapi id 15.20.5924.011; Wed, 14 Dec 2022 20:16:30 +0000 From: Gabriel To: bug-gnu-emacs@gnu.org Subject: 30.0.50; [PATCH] Tab bar group format not applied to current Date: Wed, 14 Dec 2022 17:16:24 -0300 Message-ID: Content-Type: multipart/mixed; boundary="=-=-=" X-TMN: [fLQuQYbsAO/Twa5ufr+Icbq4LylzfS/4ZLaxcgXXzQmYuEhENMvk5DcLlTLOO6Uf] X-ClientProxiedBy: CPXP152CA0012.LAMP152.PROD.OUTLOOK.COM (2603:10d6:103::24) To PH8PR19MB7070.namprd19.prod.outlook.com (2603:10b6:510:222::9) X-Microsoft-Original-Message-ID: <87pmclkag7.fsf@hotmail.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PH8PR19MB7070:EE_|BY5PR19MB4113:EE_ X-MS-Office365-Filtering-Correlation-Id: 0547487b-6eb1-4434-6a95-08dade101629 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Z4wVxXn5uMHudcU5PVLia8fk8BgEWMon6SIKQJ/CKGQR6wfKdspfHfwjYlib2p5XvKR0H8ipvplscM/0pDEH1P6zIQu9lJdq5o9JWvpeOLg7UZ39o6UVe83qOsZcsQGGepM3qOwpSu7gfCeO2if2LdoksTgByZOpVb2Fz4OU0oiHPteWgdPNH/RoqM96gO5uoALMgyN/Kw1cquPSF+v3qZat+r//hWcJrMDX5EdqmLXZCH03RxOBoX9sYtHvcoHY8fTvIj0tx1knz2T9iUyafTj+O/3gI3iTUySDLzF9l7qsGMSBMxsgnod4+mPmOZKZ3TFtD2tqlODc+lZl68jGbdNOaw9DswjGilT/48WdjD87qz6bNDgx0IlO+eXHDlytpW5itp9BZHjHqBemgb4GtI41czNz2+exaL5pOCjP+3pme+MFPHZ1wZjPAl7TRIQqw0fA/OYBxZheHx4czj+YNSAPYIiA82yho+Kl0vDjsiqEZ+L/wsZSip/kL+MLk6jwxqABe4iYA5H6d4POL3y5B+IkYwyssE69eW3omQ2fsrHLkBbFrzGeRZiWnMuYucX24Icv1Y72BmPXCwzN66Dn3/r+EycgszE13JdacCxnc+I= X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?h9JmSFjBqlHaQTWDaZNQJozk9vPX4Kx0KrY0luKIuRYQTUXCFPET6+PKK/aj?= =?us-ascii?Q?TSSWDmKj7WyMY+BBbfhPOoha94mWB13LJMB1nM8cXqvI+x8x88nSeSTi/Gls?= =?us-ascii?Q?dJGd/7W/9tNn2QFsci3kqHhAHSPXFf8sEerpRn7MQ2xe47U6mHYHHxtTPnRd?= =?us-ascii?Q?HmP8YePNr0oQOPkonmvegNrrHMkXwbWfTecL6V5usBzxtnZ3c8BmFv38CAXY?= =?us-ascii?Q?5hPnmPiYJfzEerdirpQ30NpGsvhoot+pamzbX50eqU79PIIQbax5mUeb9AN1?= =?us-ascii?Q?eCAGW3APhrxFgRHFyZpfYd+ImS+l3jBUhRWfZbGD2Iez4vNcJzkYR15YziEg?= =?us-ascii?Q?iMFEtFfHhKN1Cvr1SUdNM8H8Px0ArPjOUEakjnJ7+gVKsqqZ8PLxCeuA6EPO?= =?us-ascii?Q?DPeYCecaMFiYsN4dXO7nQHD8b2H4FpvayQbyv9pzEAgUKQZGatBFsjlaUc0D?= =?us-ascii?Q?cMUINv729zyXtyRKpIo3SCEXHgGERGp/8VdwaeYLBvKv0ZKyFGo2KdEPbiDr?= =?us-ascii?Q?1/HId1ekfPWIKPueMhB50ofCoWLQR/nzkk1XP8tKbyv2j1PH/8oVZvsqCtPG?= =?us-ascii?Q?TL54Ny3sMfU9Nsh0XZz+94+FYyZBGMTfwUrBqjz/xmanP4q2nTo5WZTTZJ0S?= =?us-ascii?Q?Glk0Xbq9ou70VctltJ9qzDdBFBF2gMTHoVUmwSa2AOW8upGpmSa43txxbS2a?= =?us-ascii?Q?qBrdjVPNHoJKaRjKEX0Rapr52cE6evvn4k3ZUNyA1FeaL7nxrKvQG8TprD2y?= =?us-ascii?Q?SHEGXmozip/9q0ApjlwwgMMFJLQRruVH1/uhNQjU++MXz2Z00ABIivKc5m4m?= =?us-ascii?Q?j6drzM7/cLOUGbJt/SNGlIuaSrP2eNtjH1RIQjr5hzPAbPZWgzIAZzjaqCDn?= =?us-ascii?Q?AXGdcTvJ98jKn+gXLeQNO0YYF+nbelL0mqmkfb2KIbshW/4vJb7gQAbIFF3z?= =?us-ascii?Q?+4AXcp4fUMY/3CgL+pXu5bWYbGK710WgqhRacLtfG8Z6NhGChXHvmvNWUZ+l?= =?us-ascii?Q?u2Yv4Gxw74WY3mlePTqqW7qs9em5eDOaVTfqHj1ykdci+dkaorNQbumrF0fd?= =?us-ascii?Q?HIdQryuecw2ZAdGoXSVN6DT1RNbvXnDuG/RmCsOk9NYqOnD0TA8YrtxT8ano?= =?us-ascii?Q?d5aDofhkdspY0bVbbA/ri4ig68625nvQrvvQ6eGm+z4ud32av4IV4aLhqKSJ?= =?us-ascii?Q?Uxn4mVe8+q1K2odApV44aPk3PGFGyT1cPbQnHHNBhoAsVcZKPHoXTji8RGG9?= =?us-ascii?Q?E2dLWmc2sjtDEleeojk44AG2r8mO3MQtFL7u/i708lqmURNoH4vOGuHgjCMZ?= =?us-ascii?Q?61W0cHgd4J9DSq4AOMGu7FZ7Dq0PL+dK2j64fWyd90CN5Q=3D=3D?= X-OriginatorOrg: sct-15-20-4755-11-msonline-outlook-e7757.templateTenant X-MS-Exchange-CrossTenant-Network-Message-Id: 0547487b-6eb1-4434-6a95-08dade101629 X-MS-Exchange-CrossTenant-AuthSource: PH8PR19MB7070.namprd19.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Dec 2022 20:16:30.3702 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR19MB4113 Received-SPF: pass client-ip=2a01:111:f400:7e8a::82e; envelope-from=gabriel376@hotmail.com; helo=NAM10-BN7-obe.outbound.protection.outlook.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.1 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.1 (--) --=-=-= Content-Type: text/plain Description: The user option 'tab-bar-tab-group-format-function' is not applied to current group tab, only to other group tabs. I suspect this is not intentional and could be fixed by the attached patch. Steps: 1) emacs -Q (master "42c757913a4c6acc07f8904df7def6b720bb23b4") 2) Enable tab bar and create some tabs and groups: (progn (tab-bar-mode 1) (tab-bar-change-tab-group "group1") (tab-new) (tab-bar-change-tab-group "group2") (tab-new) (tab-bar-change-tab-group "group2") (tab-new) (tab-bar-change-tab-group "group3")) 3) Set a custom function to format group tabs: (progn (defun my-tab-bar-group-format (tab i) (format "<%s (%s)>" (funcall tab-bar-tab-group-function tab) i)) (setopt tab-bar-format '(tab-bar-format-tabs-groups) tab-bar-tab-group-format-function 'my-tab-bar-group-format)) 4) Change tabs a couple of times with 'C-x t o' ('tab-next') Result: The 'tab-bar-tab-group-format-function' is not applied to format the current group tab, only to other group tabs. See attach patch for a proposed fix. If this behavior is intentional, I propose to update the doc string. --=-=-= Content-Type: text/x-diff Content-Disposition: attachment; filename=0001-Fix-incorrect-format-of-current-tab-bar-group.patch >From da2025d524da5b76e4f2bc81d51899d9b798888c Mon Sep 17 00:00:00 2001 From: Gabriel do Nascimento Ribeiro Date: Wed, 14 Dec 2022 17:10:28 -0300 Subject: [PATCH 1/1] Fix incorrect format of current tab bar group * lisp/tab-bar.el (tab-bar--format-tab-group): Make proper use of 'tab-bar--format-tab-group' to format the current tab bar group. --- lisp/tab-bar.el | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lisp/tab-bar.el b/lisp/tab-bar.el index 162e63fe23..65e424080d 100644 --- a/lisp/tab-bar.el +++ b/lisp/tab-bar.el @@ -882,7 +882,7 @@ tab-bar--format-tab-group `((,(intern (format "group-%i" i)) menu-item ,(if current-p - (propertize (funcall tab-bar-tab-group-function tab) + (propertize (funcall tab-bar-tab-group-format-function tab i) 'face 'tab-bar-tab-group-current) (funcall tab-bar-tab-group-format-function tab i)) ,(if current-p 'ignore -- 2.34.1 --=-=-= Content-Type: text/plain --- Gabriel --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Thu Dec 15 10:10:00 2022 Received: (at submit) by debbugs.gnu.org; 15 Dec 2022 15:10:00 +0000 Received: from localhost ([127.0.0.1]:43209 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p5prz-0007Hp-RR for submit@debbugs.gnu.org; Thu, 15 Dec 2022 10:10:00 -0500 Received: from lists.gnu.org ([209.51.188.17]:45846) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p5prx-0007Hj-Oi for submit@debbugs.gnu.org; Thu, 15 Dec 2022 10:09:58 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p5prx-0003ll-Hu for bug-gnu-emacs@gnu.org; Thu, 15 Dec 2022 10:09:57 -0500 Received: from mail-dm6nam12acsn2080a.outbound.protection.outlook.com ([2a01:111:f400:fe59::80a] helo=NAM12-DM6-obe.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p5pru-0007s4-PM for bug-gnu-emacs@gnu.org; Thu, 15 Dec 2022 10:09:57 -0500 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HIq5lmxMuf8qevp/BGVoX0USDqM9M/627fAHeYKbcD2L7isWwR+2KTP/zl3+Yn2cA+MZV1NgOn7UG97AkP/EDSkl9BWfSJdkocHV+njB/yaXdRmBGXcb0eCJ4F/H9BPjEsMeUMhwRxv7X6HMrmlkSetBFeSqJPr0WEj/ND+x8sN0BVUKdo1NLZKTVVd/B/gr+aMxv+c7Jz9sKchCWtfxcTTzoE9/U8aazXNsBGEW3lcXKmDr8+8uWcyxvU6ABqHOyqRuZAQmfaAhKdU6HD431FSTUibj6J1SWvIGhjoSm/+PTuLrqPZmABb8GWccXOYbykhY7RBUt2MoQOn/jl3jgw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=LUauhda4Z7isYA6DbRfjVAcwNuDLdfkXVCMLuVC050s=; b=KYYGBk8+/43k8EhBeY7g4E1oMsWu3g0PB8LvDVsd4zsRlTPivCZoE6/PUNatnslCamlpz0Gl6zS0+XM+K46/ALRdXT3iXRj2aEy9wZ/VSaIFQ0GCTqMv40kG7GUZAZUMCjKF62ZMmxUUZ5LOSjO7ThJk11TFqGcYq53aBx+kL29pabzQbbWBQQtkmQfgj+sf8Pq8v56g1YKBIZXiEaAqT+9J6b4hFq418K/r6DSexeltNNqYeX+vItdwAQP4Y1Wxzdb4c0zu83O3ttazGse0iwE38OZWtL5YO6ipnNo74ocvcTi4/hJ19Chy+pD2JXMDn+6WK4YZADLr4ucYyr8Ghw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hotmail.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=LUauhda4Z7isYA6DbRfjVAcwNuDLdfkXVCMLuVC050s=; b=pNxV4tFBP4pGOANeEbsV7FO2OOc3pw2tVbjnnhOaf8FYjWV0aGLjy1s3n2C44cQtnVQo0vFFyCbczEpQjnKpdtiAHA7bGi8dbBRAcYafTUa8S15anWP2TexWl0qjC+jMEMGzmLcEwC7WMeS14scdivANgLV7CFB9pOproPW2XDCWlvf42r3JC3GiCWNDl8EvzGX57UovHkvUUxgXFouFMtDobz+1NNBG8P0ffUlbgPDLuMFJH21KNpM0fUOeNmWgiGxpjy6063hSL7NFpWHGWu6X9JyUJos+vYKE6SfSP+B0wbSNJ8PgyEVqoQBjiuIiGiVsUlgeShrdWioxb99RCA== Received: from PH8PR19MB7070.namprd19.prod.outlook.com (2603:10b6:510:222::9) by SJ1PR19MB6378.namprd19.prod.outlook.com (2603:10b6:a03:457::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5924.12; Thu, 15 Dec 2022 15:04:47 +0000 Received: from PH8PR19MB7070.namprd19.prod.outlook.com ([fe80::32c9:7ad8:d88f:a199]) by PH8PR19MB7070.namprd19.prod.outlook.com ([fe80::32c9:7ad8:d88f:a199%5]) with mapi id 15.20.5924.011; Thu, 15 Dec 2022 15:04:47 +0000 From: Gabriel To: bug-gnu-emacs@gnu.org Subject: Re: bug#60073: 30.0.50; [PATCH] Tab bar group format not applied to current In-Reply-To: (Gabriel's message of "Wed, 14 Dec 2022 17:16:24 -0300") References: Date: Thu, 15 Dec 2022 12:04:42 -0300 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Content-Type: multipart/mixed; boundary="=-=-=" X-TMN: [/UvMvrin8MTjTQB1qpd4BK1GTXVdDZgndoawVJsV4skvY2EgZ36VEO6Ue9dypb0Y] X-ClientProxiedBy: CP5P284CA0020.BRAP284.PROD.OUTLOOK.COM (2603:10d6:103:94::7) To PH8PR19MB7070.namprd19.prod.outlook.com (2603:10b6:510:222::9) X-Microsoft-Original-Message-ID: <87359glncl.fsf@hotmail.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PH8PR19MB7070:EE_|SJ1PR19MB6378:EE_ X-MS-Office365-Filtering-Correlation-Id: 757d1f82-f60b-489c-ea50-08dadeadb505 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: zlH9hE1clfBnusNarRFGthWrWQlmUJP3oqHrAVzZM0Uhbug9BghMqLCMpq7Gj+miXHtf4ROOG6qrOwPJMaLZQlyGZc0Bnbm8XoXGuQpVYEDL4xxdSguLNVNRKKH4p79LDREVR6jtYXWmYYzDG9Ny2Bz99qybQjHXJqFQX26Ykj+Rn4wSN3qxKf21zZNp4CPfVLepi8evlYLhHlVyHYl2NpEJ4sNfcgHIQTpkmKvzcEvwrkPQsB8zG4ZNzmbuItUk4A2lR4nxc1gKW+uf4VzLG/5bXMgA+PtlgGvPvFXfdCOzeWaEJDDgB09C52rJoegg1IQbbcHnvAETFZ2/1B5rUcjTljTQyzCHclJHrc3DE/VVoS8koTFpli5W5MXGD66KzcS3T71rhA9rSQ+ClwqqnOAGegezS5VLr+kXssjft8lq+Zq55jOKqI1rw/11YCC5U1rTJ8YB8wXsEOODdTQRlUgQu/sk3UZlxK1N5hCGc3LmrwWw/GeYILJ58sLysJVkqOGa1SS4ilxbcXq+4uWmKMoIBFhEI5GDZY9fnaf1goIdjNosc+EaoTI/8P1Mvd+CiU8XgzAN9A3bx/4/LEbzS5kTBYzfehBQXEK9q7iJken4kHP37GYcC3OwXrJmeHIotIsM/+m30qoAvPYi/OpcB9GXP5FVnrsAqFo+eU5DNMg= X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?4kQfp0d9Bp/fJ7aayI6jIOicFlHinmLCvMJzxS5EyqxfyEbA6YUPB0iIeJAu?= =?us-ascii?Q?iqGpDbUQrWYsQ88dU3J5FkQJNuHwCZGtJ1o4czXID6drNFbpfJqQWXuIdRu+?= =?us-ascii?Q?kKimw5in3mAe0yokIWFfM93FYEKZE1+eo+RIAz3xM7TWkPhoghoTRYjRP9B2?= =?us-ascii?Q?r+oz4kYC+q6pjuxg1s1NzhM6YMwuo6KyJTjxKw6gy25KRCma7u9/7QeHyQ5y?= =?us-ascii?Q?IEG2hWlPG3bJEL12y3w4SqPd3/1A7CAjkjPePvY44G4bGXltjXslt8sDiyWC?= =?us-ascii?Q?2A/8Dc0RictOYQtJVoBOhk6p9uvLJO7qLtw1XG9G0y3LnlvpVNoa4QcJllml?= =?us-ascii?Q?aNNT5mCmqSf/QiOS/BjQyCF1M/dbs2IIN9yrfVyfmdpwGw8UxV/Et/jmXvPk?= =?us-ascii?Q?X/OkKN2b9jvZxcXqNgrsslXraLPM60FENf4b6VVtMbevrns7T/wdu3xBL5vR?= =?us-ascii?Q?iwcRjXaA6F68HOi9UaDaBEGTmMekxYQx5Atqose45rVuDK5mbtniVfCIvCsh?= =?us-ascii?Q?iz7OCBFYEAnUgjszC9HEnJN1vUJOwWjase+Z22YEQbeQnsEK01zhplKKY5E0?= =?us-ascii?Q?0C2EtqPXUNV+L8Y4m+0LJTt3amnSAOhg9ecpp4oNMhTkc8OheQi+cDMg4iJF?= =?us-ascii?Q?abdx+PyOvWbX/NsY4BTc0qJQKtFiNiR3CUNSgtOp/csG+uJqq4s0bdsZBEjx?= =?us-ascii?Q?aUNTQOpheRd1R4R08Jf2DgoEhGs8YHrjn/1s7Y7kUo+sn36yBBdQwmUeGWom?= =?us-ascii?Q?g5xbWCXvuTK4miu3xqwG9q8e5uLBOwCazOuBk0yXnzbqErRd7gxJ+mN/YfbV?= =?us-ascii?Q?HB1OVOfTUPpu+wAR5/FGm1OIW3AmSxKnxpfnNrKsY4PkWdxWTRdVMdTgZ7xf?= =?us-ascii?Q?OQnzXMqyB9pegNttz0vQjy3tjmI4oADLBzbrc6AB8hXrs5fD4nJkJuBxzgVE?= =?us-ascii?Q?oCsdaM3PhaY1LR+zMCEBHRYpMwYYhOuIpAeQvtxZVkGzVrx5t7N7r2eum35o?= =?us-ascii?Q?vgZIkXFujlGP9gPK5iVogSQjNB/yzvoHE7I756kg5t5L1fMj8Y9qGwQCSi6/?= =?us-ascii?Q?MLDeIxxqFIQqAMJRD+F3o/GChAvsIfQPSpy0f3j8IB4RncAcal3lfM+ZkPIU?= =?us-ascii?Q?QjfNgXIXy5VlSCRShnCcQKxfvuKvoZnh3j7N485LORnRhiCMzvRFwOYo96ko?= =?us-ascii?Q?8EbhcKDKTKPxi1HvVcdVJCQ+f4OKSiL691tDspU0Xm6DSrokgxHlWWKHWXCF?= =?us-ascii?Q?Q/jNA8Es5sLSxNaridESmLhdvrXVV1ds1R7kYsiYSQ9xfUlo6211+Lm8mmNv?= =?us-ascii?Q?SCeFcUIulPAGZsFgoCtCYLSPWJxFzObZZN4XMUcq8LvrLQ=3D=3D?= X-OriginatorOrg: sct-15-20-4755-11-msonline-outlook-e7757.templateTenant X-MS-Exchange-CrossTenant-Network-Message-Id: 757d1f82-f60b-489c-ea50-08dadeadb505 X-MS-Exchange-CrossTenant-AuthSource: PH8PR19MB7070.namprd19.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Dec 2022 15:04:47.8180 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ1PR19MB6378 Received-SPF: pass client-ip=2a01:111:f400:fe59::80a; envelope-from=gabriel376@hotmail.com; helo=NAM12-DM6-obe.outbound.protection.outlook.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.1 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.1 (--) --=-=-= Content-Type: text/plain Here is a new patch that also updates the function 'tab-bar-tab-group-format-default'. There are no breaking or functional changes in how the tab-bar behaves today. With this patch, the 'tab-bar-tab-group-format-function' behaves similarly to 'tab-bar-tab-name-format-function'. --=-=-= Content-Type: text/x-diff Content-Disposition: attachment; filename=0001-Make-tab-bar-tab-group-format-function-also-handle-c.patch >From 832e6ca6a5ce314e37a840356828c50adb94ebf4 Mon Sep 17 00:00:00 2001 From: Gabriel do Nascimento Ribeiro Date: Thu, 15 Dec 2022 11:58:30 -0300 Subject: [PATCH 1/1] Make tab-bar-tab-group-format-function also handle current group * lisp/tab-bar.el (tab-bar--format-tab-group): Call 'tab-bar-tab-group-format-default' to format current group tab. (tab-bar-tab-group-format-default): Update function to also handle current group tab. --- lisp/tab-bar.el | 22 +++++++++++----------- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/lisp/tab-bar.el b/lisp/tab-bar.el index 162e63fe23..1f25ee6d7e 100644 --- a/lisp/tab-bar.el +++ b/lisp/tab-bar.el @@ -844,8 +844,9 @@ tab-bar-tab-group-default (defcustom tab-bar-tab-group-format-function #'tab-bar-tab-group-format-default "Function to format a tab group name. -Function gets two arguments, a tab with a group name and its number, -and should return the formatted tab group name to display in the tab bar." +Function gets three arguments, a tab with a group name, its +number and an optional t when the tab is current, and should +return the formatted tab group name to display in the tab bar." :type 'function :initialize 'custom-initialize-default :set (lambda (sym val) @@ -854,11 +855,13 @@ tab-bar-tab-group-format-function :group 'tab-bar :version "28.1") -(defun tab-bar-tab-group-format-default (tab i) - (propertize - (concat (if tab-bar-tab-hints (format "%d " i) "") - (funcall tab-bar-tab-group-function tab)) - 'face 'tab-bar-tab-group-inactive)) +(defun tab-bar-tab-group-format-default (tab i &optional current-p) + (let ((name (concat (if tab-bar-tab-hints (format "%d " i) "") + (funcall tab-bar-tab-group-function tab))) + (face (if current-p + 'tab-bar-tab-group-current + 'tab-bar-tab-group-inactive))) + (propertize name 'face face))) (defcustom tab-bar-tab-group-face-function #'tab-bar-tab-group-face-default "Function to define a tab group face. @@ -881,10 +884,7 @@ tab-bar--format-tab-group `((,(intern (format "sep-%i" i)) menu-item ,(tab-bar-separator) ignore)) `((,(intern (format "group-%i" i)) menu-item - ,(if current-p - (propertize (funcall tab-bar-tab-group-function tab) - 'face 'tab-bar-tab-group-current) - (funcall tab-bar-tab-group-format-function tab i)) + ,(funcall tab-bar-tab-group-format-function tab i current-p) ,(if current-p 'ignore (or (alist-get 'binding tab) -- 2.34.1 --=-=-= Content-Type: text/plain --- Gabriel --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Thu Dec 15 13:04:52 2022 Received: (at 60073) by debbugs.gnu.org; 15 Dec 2022 18:04:52 +0000 Received: from localhost ([127.0.0.1]:44077 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p5sbE-0005a0-9Z for submit@debbugs.gnu.org; Thu, 15 Dec 2022 13:04:52 -0500 Received: from relay2-d.mail.gandi.net ([217.70.183.194]:55735) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p5sbA-0005Zc-Qu; Thu, 15 Dec 2022 13:04:50 -0500 Received: (Authenticated sender: juri@linkov.net) by mail.gandi.net (Postfix) with ESMTPSA id 8F1FE40006; Thu, 15 Dec 2022 18:04:41 +0000 (UTC) From: Juri Linkov To: Gabriel Subject: Re: bug#60073: 30.0.50; [PATCH] Tab bar group format not applied to current In-Reply-To: (Gabriel's message of "Thu, 15 Dec 2022 12:04:42 -0300") Organization: LINKOV.NET References: Date: Thu, 15 Dec 2022 20:04:06 +0200 Message-ID: <86fsdg8rxl.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 60073 Cc: 60073@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) close 60073 29.0.60 thanks > Here is a new patch that also updates the function > 'tab-bar-tab-group-format-default'. Thanks, pushed. > There are no breaking or functional changes in how the tab-bar behaves > today. It's a breaking change because we can't use a new call with three arguments to call the function that might be customized by users with two arguments. So I added a safety net. From debbugs-submit-bounces@debbugs.gnu.org Thu Dec 15 13:06:31 2022 Received: (at 60073) by debbugs.gnu.org; 15 Dec 2022 18:06:31 +0000 Received: from localhost ([127.0.0.1]:44097 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p5scp-0005bw-8m for submit@debbugs.gnu.org; Thu, 15 Dec 2022 13:06:31 -0500 Received: from relay11.mail.gandi.net ([217.70.178.231]:39835) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p5scn-0005bh-5t for 60073@debbugs.gnu.org; Thu, 15 Dec 2022 13:06:29 -0500 Received: (Authenticated sender: juri@linkov.net) by mail.gandi.net (Postfix) with ESMTPSA id 61C38100005; Thu, 15 Dec 2022 18:06:21 +0000 (UTC) From: Juri Linkov To: Gabriel Subject: Re: bug#60073: 30.0.50; [PATCH] Tab bar group format not applied to current In-Reply-To: (Gabriel's message of "Wed, 14 Dec 2022 17:16:24 -0300") Organization: LINKOV.NET References: Date: Thu, 15 Dec 2022 20:05:55 +0200 Message-ID: <864jtw8ruk.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 60073 Cc: 60073@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > Result: The 'tab-bar-tab-group-format-function' is not applied to format > the current group tab, only to other group tabs. See attach patch for a > proposed fix. If this behavior is intentional, I propose to update the > doc string. Indeed, this behavior was intentional because when tab-bar-tab-hints is non-nil then the number is already displayed on the current tab, so the group tab doesn't duplicate the same number. But you are right that tab-bar-tab-group-format-function should be called even for the current tab. From unknown Sat Sep 20 09:16:47 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Fri, 13 Jan 2023 12:24:07 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator