From unknown Thu Jun 19 12:37:51 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#60069 <60069@debbugs.gnu.org> To: bug#60069 <60069@debbugs.gnu.org> Subject: Status: [PATCH 2/2] guix-install.sh: Directly exit in case of errors in chk_require. Reply-To: bug#60069 <60069@debbugs.gnu.org> Date: Thu, 19 Jun 2025 19:37:51 +0000 retitle 60069 [PATCH 2/2] guix-install.sh: Directly exit in case of errors = in chk_require. reassign 60069 guix-patches submitter 60069 Maxim Cournoyer severity 60069 normal tag 60069 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Wed Dec 14 10:56:24 2022 Received: (at submit) by debbugs.gnu.org; 14 Dec 2022 15:56:24 +0000 Received: from localhost ([127.0.0.1]:40036 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p5U7M-0004aj-AT for submit@debbugs.gnu.org; Wed, 14 Dec 2022 10:56:24 -0500 Received: from lists.gnu.org ([209.51.188.17]:40692) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p5U7J-0004aW-4J for submit@debbugs.gnu.org; Wed, 14 Dec 2022 10:56:22 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p5U7I-0000Pw-Rg for guix-patches@gnu.org; Wed, 14 Dec 2022 10:56:20 -0500 Received: from mail-qt1-x82b.google.com ([2607:f8b0:4864:20::82b]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1p5U7H-0005aw-9d for guix-patches@gnu.org; Wed, 14 Dec 2022 10:56:20 -0500 Received: by mail-qt1-x82b.google.com with SMTP id fz10so2800590qtb.3 for ; Wed, 14 Dec 2022 07:56:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=r1e7GD9O2+hfD7OLoW8NerYiWInDFB5EbjU5xiHA/w8=; b=eAC9CsjU+4SXqay2a+y8/ziKameiGIy9B/Pb3DS5yQ0C9ITog4Ofi1DAfPzaAL1hyC iKlc47IkQWjFlxU6BMJ0iF+GOjau7M2enEMXodXe3ldRUvvqY7otH5RYIfiLc1M+EVwl MN692sw0Ecw8wn6hT4mFUwSaGJQz36XOiyZ7dlL1d6LaYlrh7cV/p+ChkHxBPsHIZ1t5 sGGVDAz9JqVTt8Z0so4vYTmpTWggmvRHATjrynxwHE44CkX7X1onXfhev+8mq9XyeRS9 9LZZfL1Gm3uhAZkeY8WwkBSXcdI7xRnDxaayZPuCSB7fazeNaz3I1FS63/n3/1wCYs5r lDjQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=r1e7GD9O2+hfD7OLoW8NerYiWInDFB5EbjU5xiHA/w8=; b=VT2q7/qHdnpqjy0Ya67wYq1LH6pbrteDyxzScIh4HrLIn+LGrCtWR2IE616+3+6/PP z7Qk45RYK+0PIvEBmOFiXi7uMcIAgyOquohFU5dY8XJglUO9USz1khG3URgDnHemcF9v o9ocUzN8jVUl05JJuqLUt8mwr9WKCUcaM29KnPc35o5c5j6a9taXJ45XfctsWZlTq3xM f/oPIDqwguMuDw593RyLhN45jyqWbe9RTHz5H3d+dX9CD0HAcZsEzEi3Fn2ZJ+QkKBal jqSZcrdvZs8hLSo03ijTuK8llJvDAwKhQwQQ4VRnNdyc5PX3q6c5245dmn9oFfpwPN5P evvQ== X-Gm-Message-State: ANoB5plhXiAdZ+MWk3YlL3sEmtka8gLo821Z3kb63AmIKVUQVihUC8m7 vfc3fMhUhEkkLRVTDWVe6yWyJqEPvQWiAA== X-Google-Smtp-Source: AA0mqf6uRwO1InbTRP97WvgEsbf2Iecwrno9NYY/R+nGTX9CFEQ6eaqzt0Q41E+yWV26BZjebSz1Rw== X-Received: by 2002:ac8:545a:0:b0:3a8:649:8d0a with SMTP id d26-20020ac8545a000000b003a806498d0amr27485103qtq.30.1671033378078; Wed, 14 Dec 2022 07:56:18 -0800 (PST) Received: from localhost.localdomain ([2607:fad8:4:3::1006]) by smtp.gmail.com with ESMTPSA id k10-20020ac8074a000000b00397b1c60780sm1829150qth.61.2022.12.14.07.56.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 14 Dec 2022 07:56:17 -0800 (PST) From: Maxim Cournoyer To: guix-patches@gnu.org Subject: [PATCH 2/2] guix-install.sh: Directly exit in case of errors in chk_require. Date: Wed, 14 Dec 2022 10:56:03 -0500 Message-Id: <20221214155603.29381-2-maxim.cournoyer@gmail.com> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20221214155603.29381-1-maxim.cournoyer@gmail.com> References: <20221214155603.29381-1-maxim.cournoyer@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2607:f8b0:4864:20::82b; envelope-from=maxim.cournoyer@gmail.com; helo=mail-qt1-x82b.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit Cc: Maxim Cournoyer X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) * etc/guix-install.sh (chk_require): Directly exit in case of errors in chk_require, instead of relying on 'set -e'. --- etc/guix-install.sh | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/etc/guix-install.sh b/etc/guix-install.sh index 06730f7e3f..0ca12f8b66 100755 --- a/etc/guix-install.sh +++ b/etc/guix-install.sh @@ -137,10 +137,8 @@ chk_require() command -v "$c" &>/dev/null || warn+=("$c") done - [ "${#warn}" -ne 0 ] && - { _err "${ERR}Missing commands: ${warn[*]}."; - return 1; } - + [ "${#warn}" -ne 0 ] && die "Missing commands: ${warn[*]}." + _msg "${PAS}verification of required commands completed" } -- 2.38.1 From debbugs-submit-bounces@debbugs.gnu.org Wed Dec 14 11:36:53 2022 Received: (at submit) by debbugs.gnu.org; 14 Dec 2022 16:36:53 +0000 Received: from localhost ([127.0.0.1]:40260 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p5UkX-00050b-B0 for submit@debbugs.gnu.org; Wed, 14 Dec 2022 11:36:53 -0500 Received: from lists.gnu.org ([209.51.188.17]:58238) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p5UkS-00050O-8D for submit@debbugs.gnu.org; Wed, 14 Dec 2022 11:36:48 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p5UkR-0001JY-Ba for guix-patches@gnu.org; Wed, 14 Dec 2022 11:36:48 -0500 Received: from tobias.gr ([2a02:c205:2020:6054::1]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p5UkP-0006EP-Ft for guix-patches@gnu.org; Wed, 14 Dec 2022 11:36:47 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; s=2018; bh=HQWdtX9z4rVL9 4fA4/3z189dhAr7Swfr5EOHsgR9Ykg=; h=in-reply-to:date:subject:cc:to: from:references; d=tobias.gr; b=kFkeeUlSn2xtEB1SxFpG0iYtdG3MDeAsDw0QRn vsp5E4N4hHfnUceXYurzrSmrU/BTsy2hzWtChCYEh4smppEkDnaN+rpfHnvUC+EFGu/IzS fbddBpkLbYkVfYSg0LNCxFuc8RWu+GdROA6WnSv0tD2MnWqiI2CNyO7oj6SyG35WbMZEJE 8VoU3DkT6XqS4xRWNZvR5nr7IaqqI1rpRL/RCNbQEzYklXmUCFw776i0NHhnLIUqv7ELuL sY0yt+mwlZgdVlF52ZBrTQ6uajX8GaG9uiJXzUk6z/Wluio2cuZBSwBlZK8zsldLPeCFHC YzlBeIbdWZsU7eoQBFrrindA== Received: by submission.tobias.gr (OpenSMTPD) with ESMTPSA id e9f87e7c (TLSv1.3:AEAD-AES256-GCM-SHA384:256:NO); Wed, 14 Dec 2022 16:36:41 +0000 (UTC) References: <20221214155603.29381-1-maxim.cournoyer@gmail.com> <20221214155603.29381-2-maxim.cournoyer@gmail.com> From: Tobias Geerinckx-Rice To: Maxim Cournoyer Subject: Re: [bug#60069] [PATCH 2/2] guix-install.sh: Directly exit in case of errors in chk_require. Date: Wed, 14 Dec 2022 17:37:19 +0100 In-reply-to: <20221214155603.29381-2-maxim.cournoyer@gmail.com> BIMI-Selector: v=BIMI1; s=default; Message-ID: <871qp2c54w.fsf@nckx> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Received-SPF: pass client-ip=2a02:c205:2020:6054::1; envelope-from=me@tobias.gr; helo=tobias.gr X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.6 (-) X-Debbugs-Envelope-To: submit Cc: 60069@debbugs.gnu.org, guix-patches@gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.6 (--) --=-=-= Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable Maxim Cournoyer =E5=86=99=E9=81=93=EF=BC=9A > - [ "${#warn}" -ne 0 ] && > - { _err "${ERR}Missing commands: ${warn[*]}."; > - return 1; } > -=20=20=20=20 > + [ "${#warn}" -ne 0 ] && die "Missing commands: ${warn[*]}." > + I did not run this, but will it not itself trigger -e when the=20 test is false? Kind regards, T G-R --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iIMEARYKACsWIQT12iAyS4c9C3o4dnINsP+IT1VteQUCY5n7/w0cbWVAdG9iaWFz LmdyAAoJEA2w/4hPVW153VEBAMZc1COX05j1JvkESrO5nlRi50eA3a+azXu7O3HW KAJoAQDMJihIBA5fp84NNcckxHto8PMi+dC9sXNcDFCU23NzAg== =1EgH -----END PGP SIGNATURE----- --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Wed Dec 14 13:17:50 2022 Received: (at submit) by debbugs.gnu.org; 14 Dec 2022 18:17:50 +0000 Received: from localhost ([127.0.0.1]:40786 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p5WKE-00068o-2k for submit@debbugs.gnu.org; Wed, 14 Dec 2022 13:17:50 -0500 Received: from lists.gnu.org ([209.51.188.17]:44776) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p5WKB-00068i-Dr for submit@debbugs.gnu.org; Wed, 14 Dec 2022 13:17:48 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p5WKB-0000V0-9Q for guix-patches@gnu.org; Wed, 14 Dec 2022 13:17:47 -0500 Received: from mail-qt1-x831.google.com ([2607:f8b0:4864:20::831]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1p5WK9-0003EZ-Lc for guix-patches@gnu.org; Wed, 14 Dec 2022 13:17:47 -0500 Received: by mail-qt1-x831.google.com with SMTP id c7so3138553qtw.8 for ; Wed, 14 Dec 2022 10:17:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to; bh=N3O5yoMWfCq4+RuSkSbTsCwToRoFDvtSI0ksz7f4p1Y=; b=fA75nu5uT0pbo11/BmQEVQQqwM5CgfhyRsRJzRpnoICWmALvx3CZfwj77uL3yF9q/P aLpqm6WkZX9PZdjhZWvNeJR4tsMozUMQ2I+RkyCTBaqfBKxf/3+bk0++54GqAsg8yM1K 6/8/0dEpm3CYdIQUba3FLKPwMpaxo/o0ZmM8pp70AAPvQCL3TfTh+eIBry/nXO+O/QlJ bpda+We6dmPAZNIp7jjmzA6XWLS9V8SrgWMph2yV/Ge+qQZwJnVpu23sBLZNHP7xD7Oe EBws7Icn4/z4wzyP9UC/b0blHVEMrNr8YqyElQUdC/Rtn9vAnI7mZZL4ub5m+LXJKIoY n6yA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=N3O5yoMWfCq4+RuSkSbTsCwToRoFDvtSI0ksz7f4p1Y=; b=C0VnObTN8DbjHxq7U6Emur+VMrBPjNunkqAAsHtpjjRbwRGtcOUhyI3SnlSEc4RWmQ LMIRtUuDCFRSE92Kbqf3XfbQHM7fPINWX3VdxAKQ2GWFqJs9cSd15D3lvsa24Gi9oKU8 8b78maevtwzkiTFS4hKbp4YmxfL0fHCZtyoc5XKYRyvxuq+mpyVwSbmBabbcQCzvlviK cUOYFNzXPeKgRnGJ4PIMaVZTwIzcgu4mimy2GxoEX8Vl+VhgpXUQ1EOB8TAAsa3Ft6UR AjWldT25SXSFATMwTXe8CWNz1TRrxvcEHOXx3CLONT0W2wdd4cIaZxU4YIy8Q7HvC+hh 4qMA== X-Gm-Message-State: ANoB5pmnxHYqUuSbSTvUg2WKKWjO8Rh21Xugv1hac8LMhlefMb1hZ7rn mrOjeATs2v48kpG46ONC2fKQBSHPM9EwSQ== X-Google-Smtp-Source: AA0mqf6fqqSFxCaMCnVhxXn9Hl8DAzz7TNBRs+SQSgmZPy2orbjFDORzVISHFL6ilgI9LG0hZy7Lpg== X-Received: by 2002:ac8:6042:0:b0:3a8:12be:4136 with SMTP id k2-20020ac86042000000b003a812be4136mr11029521qtm.8.1671041864372; Wed, 14 Dec 2022 10:17:44 -0800 (PST) Received: from hurd ([2607:fad8:4:3::1006]) by smtp.gmail.com with ESMTPSA id h9-20020ac81389000000b003a7ef7a758dsm2020260qtj.59.2022.12.14.10.17.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 14 Dec 2022 10:17:43 -0800 (PST) From: Maxim Cournoyer To: Tobias Geerinckx-Rice Subject: Re: [bug#60069] [PATCH 2/2] guix-install.sh: Directly exit in case of errors in chk_require. References: <20221214155603.29381-1-maxim.cournoyer@gmail.com> <20221214155603.29381-2-maxim.cournoyer@gmail.com> <871qp2c54w.fsf@nckx> Date: Wed, 14 Dec 2022 13:17:42 -0500 In-Reply-To: <871qp2c54w.fsf@nckx> (Tobias Geerinckx-Rice's message of "Wed, 14 Dec 2022 17:37:19 +0100") Message-ID: <875yed4zp5.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=2607:f8b0:4864:20::831; envelope-from=maxim.cournoyer@gmail.com; helo=mail-qt1-x831.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit Cc: 60069@debbugs.gnu.org, guix-patches@gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) Hi Tobias, Tobias Geerinckx-Rice writes: > Maxim Cournoyer =E5=86=99=E9=81=93=EF=BC=9A >> - [ "${#warn}" -ne 0 ] && >> - { _err "${ERR}Missing commands: ${warn[*]}."; >> - return 1; } >> - + [ "${#warn}" -ne 0 ] && die "Missing commands: >> ${warn[*]}." >> + > > I did not run this, but will it not itself trigger -e when the test > is false? This apparently falls in the special casing by Bash of what is considered a failure when using 'set -e'; here's a test: --8<---------------cut here---------------start------------->8--- $ cat test.sh #!/usr/bin/env bash set -e [ false ] && echo "hey, we made it!" --8<---------------cut here---------------end--------------->8--- --8<---------------cut here---------------start------------->8--- $ ./test.sh hey, we made it! --8<---------------cut here---------------end--------------->8--- I hope this answers your question. --=20 Thanks, Maxim From debbugs-submit-bounces@debbugs.gnu.org Wed Dec 14 13:33:36 2022 Received: (at 60069) by debbugs.gnu.org; 14 Dec 2022 18:33:37 +0000 Received: from localhost ([127.0.0.1]:40869 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p5WZU-0006K7-Ic for submit@debbugs.gnu.org; Wed, 14 Dec 2022 13:33:36 -0500 Received: from mail-qt1-f179.google.com ([209.85.160.179]:42944) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p5WZS-0006Jz-81 for 60069@debbugs.gnu.org; Wed, 14 Dec 2022 13:33:35 -0500 Received: by mail-qt1-f179.google.com with SMTP id i20so3172514qtw.9 for <60069@debbugs.gnu.org>; Wed, 14 Dec 2022 10:33:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to; bh=4MIQSjdRVCh/DcdPNSMD97BB2BNrPahVHI27ObVR+b0=; b=PQwOqnWIZ7c1pxsQlu8S1m0Pexy4aq7F6ad8EUOFTrVWsr64dBGbGcj+Rs1Aism/3k akUSNZlR42r4lZm9fNLcb0RLeIQezZ30L1aooTnBGGuGecnBEsgGnypIEU7O+4ElBrUw M1WPHp5OcJi96ZBC1TQofRUqr8RL+yZBXXRdH45dnZEQY5SZz9UvVP/W5OCIavkVsdJW peLvGZO+BJicBl40/jcMn1y+cNHxTZB0lFg07lwP6/yawDYkkF3x3nKJyjjs4om/V534 sZLp6D628/UXbI2T/C0/NpmOSne4Ql3z4kacLmZ2IHtmdRx70zbwWCmcZi+NIpfIVZlv oLNg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=4MIQSjdRVCh/DcdPNSMD97BB2BNrPahVHI27ObVR+b0=; b=WNJ+N2B8COctMuyzwpCciOnW5vEQQuhFtRGbIz0uR2wfcVnhhZue4fxXl3QOMz1zEr iPIAzA4LGPfl+qxh9GhCt8yUH3ZfNElSq7tMyI09Xblo5tA2ctSxBXXpUhCi20tgXjxB GNNdZPBTS8dZOKiBGNYqz1FgnrVMJZNHMCwSexb3zsqyuC+4bhfkjhNO7IiS8clL0F8q dqpZsWDJIE4MCIr9AgUFJd21G3/khynGRWYRQo9/Lp2XIHZY7z6axMSDxbGEK249Lt5t ExNIJWD/E4PLFUl3vt2MyI4jE3XbWRo/BlxgX0GgeimaonbzFZvvEgQDnIQkCiqYTJ4g AIRA== X-Gm-Message-State: ANoB5pn7mkramZvLk5YRGfdMInc0kDrMCd9ymB4yQFqMnGCxqyM1JtYV Dv9vF3BdhAmLAutbl7kR1VVklEj1hc9S4A== X-Google-Smtp-Source: AA0mqf7eoIkHH6hdwRlsHAdUaKcRDbT0Q5Q3zBz2DaBai+2bi6h0U7epX2rtca/p0paZzqCrCdNwpQ== X-Received: by 2002:a05:622a:1a1a:b0:3a8:cf9:d33d with SMTP id f26-20020a05622a1a1a00b003a80cf9d33dmr34325900qtb.4.1671042808555; Wed, 14 Dec 2022 10:33:28 -0800 (PST) Received: from hurd ([2607:fad8:4:3::1006]) by smtp.gmail.com with ESMTPSA id m5-20020ac84445000000b003a68f5d98c1sm2060006qtn.93.2022.12.14.10.33.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 14 Dec 2022 10:33:28 -0800 (PST) From: Maxim Cournoyer To: Tobias Geerinckx-Rice Subject: Re: bug#60069: [PATCH 2/2] guix-install.sh: Directly exit in case of errors in chk_require. References: <20221214155603.29381-1-maxim.cournoyer@gmail.com> <20221214155603.29381-2-maxim.cournoyer@gmail.com> <871qp2c54w.fsf@nckx> <875yed4zp5.fsf@gmail.com> Date: Wed, 14 Dec 2022 13:33:26 -0500 In-Reply-To: <875yed4zp5.fsf@gmail.com> (Maxim Cournoyer's message of "Wed, 14 Dec 2022 13:17:42 -0500") Message-ID: <87sfhh3keh.fsf_-_@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 60069 Cc: 60069@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi, Maxim Cournoyer writes: > Hi Tobias, > > Tobias Geerinckx-Rice writes: > >> Maxim Cournoyer =E5=86=99=E9=81=93=EF=BC=9A >>> - [ "${#warn}" -ne 0 ] && >>> - { _err "${ERR}Missing commands: ${warn[*]}."; >>> - return 1; } >>> - + [ "${#warn}" -ne 0 ] && die "Missing commands: >>> ${warn[*]}." >>> + >> >> I did not run this, but will it not itself trigger -e when the test >> is false? > > This apparently falls in the special casing by Bash of what is > considered a failure when using 'set -e'; here's a test: > > $ cat test.sh > #!/usr/bin/env bash > > set -e > > [ false ] && echo "hey, we made it!" > > $ ./test.sh > hey, we made it! The above example was bogus and unnecessary; looking at it more closely, the test would return true when the 'warn' array contains 1 or more items (missing commands), which would cause the die command to be invoked and the script to exit. The first test handling isn't modified, so it'll chain though the second part the same as it does now. I hope that's a better explanation. --=20 Thanks, Maxim From debbugs-submit-bounces@debbugs.gnu.org Wed Dec 14 15:47:21 2022 Received: (at control) by debbugs.gnu.org; 14 Dec 2022 20:47:21 +0000 Received: from localhost ([127.0.0.1]:41795 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p5Yeu-0004Dx-RO for submit@debbugs.gnu.org; Wed, 14 Dec 2022 15:47:20 -0500 Received: from mail-vs1-f42.google.com ([209.85.217.42]:40530) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p5Yer-0004Dr-Nn for control@debbugs.gnu.org; Wed, 14 Dec 2022 15:47:18 -0500 Received: by mail-vs1-f42.google.com with SMTP id 3so985250vsq.7 for ; Wed, 14 Dec 2022 12:47:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=subject:from:to:message-id:date:from:to:cc:subject:date:message-id :reply-to; bh=rS9DDSNjNe/3VXA49rs5Q4zy/BoI3JFxiRwal3/8Yug=; b=DdhTzP8WqduyM93i9W1D+js08F0Wl8zJWeY+u9+ql+uu9uHgtawSuLJn9oh10/b+5K F/jsTHck2Fr+x6VQhgTlWHS3hbKYNYuePJSZe4j2ycbwA9AoD7R0E+UEKKqavhqdkv2B 38uQ0407+lAB740d8SMsyDLK3FUCWTV/KTqQpNDFhWqp2gO1t5a5gZoRUpktMsAEmVe1 soEYjd2IlErggVebSnvhBajwTuB4rHYHeBLLB++WPbmfDUoXvYQ2XwZ0yBmmBznWW5zS XEL5hpMgwxVTFqXHRpXbgx2iimidJQvbBYf2CBX1ZuzOhAb0RYLmAYERFWaxnQwhZKnJ tXag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=subject:from:to:message-id:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=rS9DDSNjNe/3VXA49rs5Q4zy/BoI3JFxiRwal3/8Yug=; b=E7eeSxZE/fASNH6pB/D6NUNJbYs8GqreggGBNMIFZuctbGsou4k48CkLXpiczjpkzc 3NpZsLRmvtIA0nuOXzQFWcdvlan9jBZz30emCXobO1wll1065xrRVOYRFljeBGxEq4qv 6/kK2/CUNuKe50imaLxQlc2cCJ3Ti3mOTKyUugAAgGT874cEhn3I9Adh8TL5XtDwP6O8 u8k9jJNj4VjqD7KkOw22CF/KGwP88VlUJj/nQYqwr1kUNZThPjsJr41Fq3WwIjprDGLa AIWG4PByIFAM0x5h4X+zT5cMa0mmRnfGLFjV7A9d8f3M3LBKzLbn1y++2mTh687/lVxo PTBQ== X-Gm-Message-State: ANoB5plRMl1ej3xFawbYUftoHQp3y/YlRQ7ZolOrVWNivaniCmW/we62 6bBKvgtOciNmXTXiMC8A5t3fcUF9FXkEVQ== X-Google-Smtp-Source: AA0mqf6NHViIo+eazjJRm2mMcIY4iIPJZMY+50nWKZOjMHjLUwmCYiCiOTZwoaOGEVnH2Ag7ySSNZQ== X-Received: by 2002:a67:6a85:0:b0:3b0:b5fe:d847 with SMTP id f127-20020a676a85000000b003b0b5fed847mr15923287vsc.16.1671050832108; Wed, 14 Dec 2022 12:47:12 -0800 (PST) Received: from hurd ([2607:fad8:4:3::1006]) by smtp.gmail.com with ESMTPSA id r18-20020a05620a299200b006fed2788751sm10838769qkp.76.2022.12.14.12.47.11 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 14 Dec 2022 12:47:11 -0800 (PST) Date: Wed, 14 Dec 2022 15:47:10 -0500 Message-Id: <87cz8l3e7l.fsf@gmail.com> To: control@debbugs.gnu.org From: Maxim Cournoyer Subject: control message for bug #60068 X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) forcemerge 60068 60069 quit From debbugs-submit-bounces@debbugs.gnu.org Thu Dec 15 09:41:37 2022 Received: (at 60069) by debbugs.gnu.org; 15 Dec 2022 14:41:37 +0000 Received: from localhost ([127.0.0.1]:43085 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p5pQX-0006uE-8R for submit@debbugs.gnu.org; Thu, 15 Dec 2022 09:41:37 -0500 Received: from eggs.gnu.org ([209.51.188.92]:46400) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p5pQU-0006u3-MR; Thu, 15 Dec 2022 09:41:35 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p5pQN-0006xF-W6; Thu, 15 Dec 2022 09:41:28 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=3BuK762PYisDf5OdEqnu2pu6ZKEodWpL3849+Bg8YaI=; b=Md5xU6d4VK6E/W4tXb/U n1yfL2GTmkoGtglVOSpqDQZknkw4ERXQdOnG8XP8VZIXsGYR2qLjNrHIzfwKtvRjsv4PwJ1MIK1AR feigdZSh+v2dJ6nty5l3mzPWhdJ7QRDyxBAEUMxybhqvtmtC9bY/7r/ghzBsZ/OyDaG3XV2RPyIcx CyxrtLsWQLWdqzEClSX1B3yPZQfrwvn/xAJLn992R2oBJ4khO/LzuxJWLo9W49/mkzWT0dcuS80zA CowsA3JtV2lK65cH43FuhWLIfQyVNj1YqdvPgCQOUSmcg4Ila0l3r2ZF+GRaqHHJUvp7NnAMEiapY AcKYnrZKJ0Zq8Q==; Received: from [89.207.171.79] (helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p5pQL-00033L-RR; Thu, 15 Dec 2022 09:41:27 -0500 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Maxim Cournoyer Subject: Re: bug#60069: [PATCH 2/2] guix-install.sh: Directly exit in case of errors in chk_require. References: <20221214155603.29381-1-maxim.cournoyer@gmail.com> <20221214204640.16879-1-maxim.cournoyer@gmail.com> Date: Thu, 15 Dec 2022 15:41:17 +0100 In-Reply-To: <20221214204640.16879-1-maxim.cournoyer@gmail.com> (Maxim Cournoyer's message of "Wed, 14 Dec 2022 15:46:38 -0500") Message-ID: <871qp0pw4y.fsf_-_@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 60069 Cc: me@tobias.gr, 60069@debbugs.gnu.org, 60068@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hi, Maxim Cournoyer skribis: > * etc/guix-install.sh: (REQUIRE): Add missing "useradd" command. [...] > * etc/guix-install.sh (chk_require): Directly exit in case of errors in > chk_require, instead of relying on 'set -e'. These two patches LGTM; you can add them to =E2=80=98master=E2=80=99 and th= at way people will benefit from it when installing 1.4.0. Thanks! Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Thu Dec 15 09:43:39 2022 Received: (at 60069) by debbugs.gnu.org; 15 Dec 2022 14:43:39 +0000 Received: from localhost ([127.0.0.1]:43100 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p5pSV-0006wX-EW for submit@debbugs.gnu.org; Thu, 15 Dec 2022 09:43:39 -0500 Received: from eggs.gnu.org ([209.51.188.92]:46966) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p5pST-0006wO-Ry; Thu, 15 Dec 2022 09:43:38 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p5pSO-0007H4-Ke; Thu, 15 Dec 2022 09:43:32 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=mhraeYUF9QDM1RX4k5O9WuDSc8dzqcHl3TqeuXxXV+8=; b=Vg2bEpPbW73FZUuaja+m KVhI+a1sxFvB8h7QMybfUOGFP+xXAxMEvBlyvi5Hqsb2Kt2PArjdXzLljL4+srDkXf5SpRSkl9MS0 W4n+QYo3PyM2uGqw1flCYQhd9/jtTVunDvbt1qqoHp/9V5nYSQnNxrjjGvZgOEksKGqUjQtmOyE8z bIKwZoT05+v7k3XVvrWggpUN7c3deACbKpvga+k7DJ3nYK5RHSwfqPjJDO0TQX6cBD7iBNJzc3bLE cS8K44erDo9mKQDdZNpyPulJ14j2mfiRb1B5O26vpBDdlx7mw3VnLDommZ4wT2TsWm/VAIfo5N+FP 2h8et5J+hvP99A==; Received: from [89.207.171.79] (helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p5pSB-0003JN-9s; Thu, 15 Dec 2022 09:43:32 -0500 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Maxim Cournoyer Subject: Re: bug#60069: [PATCH 2/2] guix-install.sh: Directly exit in case of errors in chk_require. References: <20221214204640.16879-1-maxim.cournoyer@gmail.com> <20221214204640.16879-2-maxim.cournoyer@gmail.com> Date: Thu, 15 Dec 2022 15:43:16 +0100 In-Reply-To: <20221214204640.16879-2-maxim.cournoyer@gmail.com> (Maxim Cournoyer's message of "Wed, 14 Dec 2022 15:46:39 -0500") Message-ID: <87wn6sohh7.fsf_-_@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 60069 Cc: me@tobias.gr, 60069@debbugs.gnu.org, 60068@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Maxim Cournoyer skribis: > The need for this use case appeared when attempting to install Guix on a = truly > minimal image made with Buildroot, which lacked enough GNU components tha= t I > had to extract a guix pack to /gnu before attempting installation, which = would > then refuse to proceed because of the existing /gnu. > > * etc/guix-install.sh: Document environment variables. > (sys_create_store) [GUIX_ALLOW_OVERWRITE]: Skip pre-existing installation > checks and output a warning. Extract the tarball directly to /. Like Tobias, I=E2=80=99m reluctant to adding environment variables; I=E2=80= =99m also skeptical about the use case (I think it=E2=80=99s fine to let users remove their previous installation if that=E2=80=99s what they want). I also think we=E2=80=99d rather minimize changes to the script since we=E2= =80=99re a couple of days before the release. Thanks, Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Thu Dec 15 09:45:06 2022 Received: (at 60069) by debbugs.gnu.org; 15 Dec 2022 14:45:06 +0000 Received: from localhost ([127.0.0.1]:43109 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p5pTu-0006yM-7w for submit@debbugs.gnu.org; Thu, 15 Dec 2022 09:45:06 -0500 Received: from eggs.gnu.org ([209.51.188.92]:48258) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p5pTs-0006xd-BU; Thu, 15 Dec 2022 09:45:04 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p5pTn-0007Y5-48; Thu, 15 Dec 2022 09:44:59 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=mhraeYUF9QDM1RX4k5O9WuDSc8dzqcHl3TqeuXxXV+8=; b=izACIWKvsEx9r/w2Jr6N adTxcb7dUWItbZWf9xYpWA3UMGoUAXuUVHwuOVGEAohGwnqh+favwwNIiQSPAd5aEezt9cDUvc91H i8NNhVCRy841uRX+hoewomZaRQWI1lYRgXNFd4WBBi5eMq4Nkt59Q8TYyUj/QDxajzEq5+RlDA+1q OY5tHa6DtjJ5vNlTKL6e8sYIjyxcwbSE+FltmvQXT2JpnZmcJpBORJz1kkabBpsIbmUGC3Fs8Brpy XbmtUI+aEE25tdZLNEfkCWAa1onCbWPBKdZqlE6eEeVen7qv0feGZ0Fj9IUOYZvks+UGU3FG9+bh7 huQdEvYByxcXEA==; Received: from [89.207.171.79] (helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p5pTl-0003Rd-T8; Thu, 15 Dec 2022 09:44:58 -0500 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Maxim Cournoyer Subject: Re: bug#60069: [PATCH 2/2] guix-install.sh: Directly exit in case of errors in chk_require. In-Reply-To: <20221214204640.16879-2-maxim.cournoyer@gmail.com> (Maxim Cournoyer's message of "Wed, 14 Dec 2022 15:46:39 -0500") References: <20221214204640.16879-1-maxim.cournoyer@gmail.com> <20221214204640.16879-2-maxim.cournoyer@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) Date: Thu, 15 Dec 2022 15:44:54 +0100 Message-ID: <87v8mcoheh.fsf_-_@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 60069 Cc: me@tobias.gr, 60069@debbugs.gnu.org, 60068@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Maxim Cournoyer skribis: > The need for this use case appeared when attempting to install Guix on a = truly > minimal image made with Buildroot, which lacked enough GNU components tha= t I > had to extract a guix pack to /gnu before attempting installation, which = would > then refuse to proceed because of the existing /gnu. > > * etc/guix-install.sh: Document environment variables. > (sys_create_store) [GUIX_ALLOW_OVERWRITE]: Skip pre-existing installation > checks and output a warning. Extract the tarball directly to /. Like Tobias, I=E2=80=99m reluctant to adding environment variables; I=E2=80= =99m also skeptical about the use case (I think it=E2=80=99s fine to let users remove their previous installation if that=E2=80=99s what they want). I also think we=E2=80=99d rather minimize changes to the script since we=E2= =80=99re a couple of days before the release. Thanks, Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Fri Dec 16 00:07:34 2022 Received: (at 60069) by debbugs.gnu.org; 16 Dec 2022 05:07:34 +0000 Received: from localhost ([127.0.0.1]:47008 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p62wY-0003PN-8w for submit@debbugs.gnu.org; Fri, 16 Dec 2022 00:07:34 -0500 Received: from mail-qt1-f169.google.com ([209.85.160.169]:39667) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p62wV-0003PE-Sd; Fri, 16 Dec 2022 00:07:32 -0500 Received: by mail-qt1-f169.google.com with SMTP id s9so1925622qtx.6; Thu, 15 Dec 2022 21:07:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to; bh=+ruKiTPXMUnBVcGs5EQ6S/DYQCNXb1vLfFrgTcjzUrc=; b=gbDt0dDisxym1G8QPVTZEc4YQXShBsYxkz4/nkJc5lFqGts5P0G4tXNbxdJGWxGgse 6sFq3w23qzzHl1vEbCoiQS1VeIuStgAf59W2Nz7Oq33kLTCXjzBKgaOxhsUUXtLmgIfm 2uaWNRqMCxprawPMjE+K9XcSu7M0clYGdUpYScfm/ixKVsxFQy9OQY+hlJt3xtMKP6Ja nYxlsUfkRuYObarDWRNgWd7QiB4He6HlCICWZY64Rj28Kde29KeoZ0fw91ZcH6nHtXMB XnHJ6z90euHLhpu0w2VoDq0gAh2SRYsrWWKYNCl5C1g8hIo8DkIkuoZR2//4cUeIpJOy MHbg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=+ruKiTPXMUnBVcGs5EQ6S/DYQCNXb1vLfFrgTcjzUrc=; b=JxEEV+MMN7nntsb/XOk+t5r2LOCv9PtPVfErPdNNWOX/stu+Xte+XnN4wsvA7Ji9Cs KO811seUpd3KEu1QqIpTtHxPusce4x9J0P4dfUjg2Od6LXo1rPY8jVov6Noo5ekG4pz7 U+yvQElS2Gq3WRrak6mtcPygUJhbKX6B9K4/QTUIPPgUNuZWUivqG6F/ZTRYdrBgqRaV YSH/gq702OOey4x1n53rjuHEffojX0A1oNV//tEBcuHh7+Ev7Kjr8/NNwacG7CPdPoL5 XAjZSJuR/jkx9Wq93p1RH5I02MMvToOySenICAScLlbnmtxgO2vT2AyR6JWTR6mi5yq7 aEoA== X-Gm-Message-State: ANoB5pkBapyf9xAWNcE1A2lgOiIZK3PQ9JLNLp1PzjEmFUzMu2Tcn/A3 6NG6fjyk0GtFrXT1FM+OEt0= X-Google-Smtp-Source: AA0mqf7TOnSVZfAbeQWKei+AxDEdp100pfU5z/EIMfOtnE7ceCxWFBfemjOyrg+ipQB69gJbwSZdnA== X-Received: by 2002:ac8:5ec6:0:b0:3a7:eab2:e461 with SMTP id s6-20020ac85ec6000000b003a7eab2e461mr38684856qtx.25.1671167246412; Thu, 15 Dec 2022 21:07:26 -0800 (PST) Received: from hurd (dsl-10-129-63.b2b2c.ca. [72.10.129.63]) by smtp.gmail.com with ESMTPSA id t1-20020ac865c1000000b003a4f22c6507sm733994qto.48.2022.12.15.21.07.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 15 Dec 2022 21:07:25 -0800 (PST) From: Maxim Cournoyer To: Ludovic =?utf-8?Q?Court=C3=A8s?= Subject: Re: bug#60069: [PATCH 2/2] guix-install.sh: Directly exit in case of errors in chk_require. References: <20221214204640.16879-1-maxim.cournoyer@gmail.com> <20221214204640.16879-2-maxim.cournoyer@gmail.com> <87wn6sohh7.fsf_-_@gnu.org> Date: Fri, 16 Dec 2022 00:07:24 -0500 In-Reply-To: <87wn6sohh7.fsf_-_@gnu.org> ("Ludovic =?utf-8?Q?Court=C3=A8s?= =?utf-8?Q?=22's?= message of "Thu, 15 Dec 2022 15:43:16 +0100") Message-ID: <87wn6saqcz.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 60069 Cc: me@tobias.gr, 60069@debbugs.gnu.org, 60068@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi Ludovic, Ludovic Court=C3=A8s writes: > Maxim Cournoyer skribis: > >> The need for this use case appeared when attempting to install Guix on a= truly >> minimal image made with Buildroot, which lacked enough GNU components th= at I >> had to extract a guix pack to /gnu before attempting installation, which= would >> then refuse to proceed because of the existing /gnu. >> >> * etc/guix-install.sh: Document environment variables. >> (sys_create_store) [GUIX_ALLOW_OVERWRITE]: Skip pre-existing installation >> checks and output a warning. Extract the tarball directly to /. > > Like Tobias, I=E2=80=99m reluctant to adding environment variables; I=E2= =80=99m also > skeptical about the use case (I think it=E2=80=99s fine to let users remo= ve > their previous installation if that=E2=80=99s what they want). Removing my previous installation wouldn't have helped (it would have cleared the guix packs I needed to be able to run the installer). Without this change, I wouldn't have been able to install guix using guix-install.sh. It's niche, but I bet it'd help folks trying to install Guix on Alpine and similar minimal OSes. > I also think we=E2=80=99d rather minimize changes to the script since we= =E2=80=99re a > couple of days before the release. The change seems fairly small to me and would be easy to revert if it causes a problem. But I'll let you do the call, given you're the one pushing the release forward (thank you!). --=20 Thanks, Maxim From debbugs-submit-bounces@debbugs.gnu.org Thu Feb 16 23:25:02 2023 Received: (at control) by debbugs.gnu.org; 17 Feb 2023 04:25:02 +0000 Received: from localhost ([127.0.0.1]:38180 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pSsIv-0003EQ-VB for submit@debbugs.gnu.org; Thu, 16 Feb 2023 23:25:02 -0500 Received: from mail-qt1-f181.google.com ([209.85.160.181]:34432) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pSsIu-0003E1-7f for control@debbugs.gnu.org; Thu, 16 Feb 2023 23:25:00 -0500 Received: by mail-qt1-f181.google.com with SMTP id f10so4379468qtv.1 for ; Thu, 16 Feb 2023 20:25:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=subject:from:to:message-id:date:from:to:cc:subject:date:message-id :reply-to; bh=zwPyPLlMtVpXy9jFw0/z9cH1G3BL/d8H/aZHXiaotVQ=; b=AoUQSrVSSDdYsOS0dmxBhgj3+RA6OD6+QCGiqahlclfPiNsBelIPkEvkxTdFqeX9hy rEpg7evs1J6MnGq4nHI5nKa23186fSbNBPGsG9UOSxTGznaMYuznxstihFpJh0ApiLOE CSsj3LjVGOo1BkffmE43LDqft5Rd4ev60cqlEjJnXoWM50TEM4ZcEtoWEiLScdEuGLFk WkN3U1RY366bVGPRkQUIbXSvvzqAFdnPru4AhkgvrZ9EMaaNJTVjquUZV88Yjh6rgSHd ceP1/nEbirW6I+yMY6MCMLxjwbZmTvoIv2s5K2/eXP0lXhKr6i6n1ga9eCIOEEENBfkP E/7w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=subject:from:to:message-id:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=zwPyPLlMtVpXy9jFw0/z9cH1G3BL/d8H/aZHXiaotVQ=; b=HeZR15E0k6HLLlU4mZ1CyAydpgTAuHTWhd8GWPpzPWaWCu4MuIZ3LH7Jicun0AKCKi 0WGfj6dNniz3auPStZOFwtX+ul3RgB8h7qeazWnc/EKoe7I7d5fJ3RilgI6j2VWc3USg VtWx4V7R9JJoeI9t0MedY5NfVmitKjdvy4kf1SxkzwaRXzjbVbvyct0hyziNeuqjecjn 1g/Fcnee42Sa/REl1Q+msaQOhYL1aXW/1/PjFkTUNU7Ne9tPFn90zqsrsFyU/JLD4C0z PEJEbn9UzjajHxwfA9apyoJsnL0uVz5LBJNAzmzeUE2WDI1iJD3bli9R/2S4YXtVkiIQ QRSA== X-Gm-Message-State: AO0yUKUK+kE/IETiEQHiYy8K2/yw3QP4jX0W45cJnHx1FkHHNwSZQZOC CewenvSgmfKvPWxfcX+DS/NDHccIvBZKUA== X-Google-Smtp-Source: AK7set9cwhaHf5KB+j3fJGRT6sHVEzJqErOA2pJfp3ZIw7H9QsotG/yn/pgSDql5eOgnwWmlInoHgA== X-Received: by 2002:a05:622a:14d4:b0:3b8:2e48:921a with SMTP id u20-20020a05622a14d400b003b82e48921amr13199716qtx.57.1676607894161; Thu, 16 Feb 2023 20:24:54 -0800 (PST) Received: from hurd (dsl-152-188.b2b2c.ca. [66.158.152.188]) by smtp.gmail.com with ESMTPSA id b64-20020a37b243000000b0072ad54e36b2sm2509340qkf.93.2023.02.16.20.24.53 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 Feb 2023 20:24:53 -0800 (PST) Date: Fri, 17 Feb 2023 05:24:52 +0100 Message-Id: <874jrkudez.fsf@gmail.com> To: control@debbugs.gnu.org From: Maxim Cournoyer Subject: control message for bug #60069 X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) close 60069 quit From unknown Thu Jun 19 12:37:51 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Fri, 17 Mar 2023 11:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator