From unknown Sun Jun 15 08:10:51 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#60068 <60068@debbugs.gnu.org> To: bug#60068 <60068@debbugs.gnu.org> Subject: Status: [PATCH 1/2] guix-install.sh: Add GUIX_ALLOW_OVERWRITE environment variable. Reply-To: bug#60068 <60068@debbugs.gnu.org> Date: Sun, 15 Jun 2025 15:10:51 +0000 retitle 60068 [PATCH 1/2] guix-install.sh: Add GUIX_ALLOW_OVERWRITE environ= ment variable. reassign 60068 guix-patches submitter 60068 Maxim Cournoyer severity 60068 normal tag 60068 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Wed Dec 14 10:56:21 2022 Received: (at submit) by debbugs.gnu.org; 14 Dec 2022 15:56:21 +0000 Received: from localhost ([127.0.0.1]:40033 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p5U7I-0004aV-Uf for submit@debbugs.gnu.org; Wed, 14 Dec 2022 10:56:21 -0500 Received: from lists.gnu.org ([209.51.188.17]:40690) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p5U7D-0004aP-Lu for submit@debbugs.gnu.org; Wed, 14 Dec 2022 10:56:19 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p5U7D-0000PD-Ad for guix-patches@gnu.org; Wed, 14 Dec 2022 10:56:15 -0500 Received: from mail-qt1-x833.google.com ([2607:f8b0:4864:20::833]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1p5U7B-0005a5-Mj for guix-patches@gnu.org; Wed, 14 Dec 2022 10:56:15 -0500 Received: by mail-qt1-x833.google.com with SMTP id a16so2758197qtw.10 for ; Wed, 14 Dec 2022 07:56:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=M42CaM3Qax3m81KvT4f6PsgNBkAHyWRAS+1HMFRHEtk=; b=HFostAR0ZhgCw7CjopHSeTqjQwIhSuHIbUjRNas986ADoGTJh9TaF7br9Yj1nX5jzs y+IPNOXTmrKaaH4y2Bw8ViKqAOhuJI4cXF+99EF+JrfNdHNy//Gt3WUTMkTeo6t0X/lc sLCoxYWuuguagZ9WaUdDdawGUCObWdkeoeMbP9hXrAr3sKrF5w0H+oaUHMtcVgQtVclJ LpTJaRG2y7PQjY/lmgHsAkyNi9lvd7T6sDOnAf0JUL23BD3km8BsyCx6k3rIuVVcNLDA HMAc9oG1ezknioyZ3zrYKY8yOJAOVDS1IsW1SHMqRb9IRaM4LcZqRQNraoIceY/u76u7 A1Qg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=M42CaM3Qax3m81KvT4f6PsgNBkAHyWRAS+1HMFRHEtk=; b=BhtxVw4Sy6jrT7PM12Rx2GrXusDWIcPvRcgrUAqc3hvfaZ2hrI5mgF8TrRg8Lw88cg azAMHRzGDWrjV6fxY6orMJ5M9nKtaEcuAWtcheCPkvJGnhCCgT8eT99L7GrqrGlG8SJG vJ8iduaMy7N9hDS1ZLbGV2dNf/O+9hSqa+4j7AjrQdF++u25m2XXTrpAQ3vIRPRcK4ha JXgvd9afhUG0Cf+B8xdPjn7/ECq/0Wu7l6ujh0X4SU8TcWD8RyXqazlBacvy0NLVrXk8 c7I6Xkom16r3359Xfv7u3N7wrmFGABS5M9br+uPBFuWXzqe2Lcd1YqcOn005UXYt0eBL 9sQQ== X-Gm-Message-State: ANoB5plYGDaqx/VeCuJyzA8bITzHi7jg6HqDBuEp+pMJseG/ReyMh7Mq ZQFDhKIZnH8GBlOM+ThY0KTBI+wsweZAdQ== X-Google-Smtp-Source: AA0mqf6Kk27/Ini121UdPJZ5kt+8/u7x0qvDBwkAjhM8sDlWZp9S4zXyPoVFlRKqrpQVqGkizdoC5A== X-Received: by 2002:ac8:1099:0:b0:3a5:9267:ee07 with SMTP id a25-20020ac81099000000b003a59267ee07mr28823747qtj.63.1671033372016; Wed, 14 Dec 2022 07:56:12 -0800 (PST) Received: from localhost.localdomain ([2607:fad8:4:3::1006]) by smtp.gmail.com with ESMTPSA id k10-20020ac8074a000000b00397b1c60780sm1829150qth.61.2022.12.14.07.56.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 14 Dec 2022 07:56:11 -0800 (PST) From: Maxim Cournoyer To: guix-patches@gnu.org Subject: [PATCH 1/2] guix-install.sh: Add GUIX_ALLOW_OVERWRITE environment variable. Date: Wed, 14 Dec 2022 10:56:02 -0500 Message-Id: <20221214155603.29381-1-maxim.cournoyer@gmail.com> X-Mailer: git-send-email 2.38.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2607:f8b0:4864:20::833; envelope-from=maxim.cournoyer@gmail.com; helo=mail-qt1-x833.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit Cc: Maxim Cournoyer X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) The need for this use case appeared when attempting to install Guix on a truly minimal image made with Buildroot, which lacked enough GNU components that I had to extract a guix pack to /gnu before attempting installation, which would then refuse to proceed because of the existing /gnu. * etc/guix-install.sh: Document environment variables. (REQUIRE): Add missing "useradd" command. (sys_create_store) [GUIX_ALLOW_OVERWRITE]: Skip pre-existing installation checks and output a warning. Extract the tarball directly to /. --- etc/guix-install.sh | 26 +++++++++++++++++++++----- 1 file changed, 21 insertions(+), 5 deletions(-) diff --git a/etc/guix-install.sh b/etc/guix-install.sh index fb9006b3e2..06730f7e3f 100755 --- a/etc/guix-install.sh +++ b/etc/guix-install.sh @@ -29,6 +29,22 @@ # We require Bash but for portability we'd rather not use /bin/bash or # /usr/bin/env in the shebang, hence this hack. + +# Environment variables +# +# GUIX_BINARY_FILE_NAME +# +# Can be used to override the automatic download mechanism and point +# to a local Guix binary archive filename like +# "/tmp/guix-binary-1.4.0rc2.armhf-linux.tar.xz" +# +# GUIX_ALLOW_OVERWRITE +# +# Instead of aborting to avoid overwriting a previous installations, +# allow copying over /var/guix or /gnu. This can be useful when the +# installation required the user to extract Guix packs under /gnu to +# satisfy its dependencies. + if [ "x$BASH_VERSION" = "x" ] then exec bash "$0" "$@" @@ -53,6 +69,7 @@ REQUIRE=( "chmod" "uname" "groupadd" + "useradd" "tail" "tr" "xz" @@ -337,16 +354,15 @@ sys_create_store() _debug "--- [ ${FUNCNAME[0]} ] ---" - if [[ -e "/var/guix" || -e "/gnu" ]]; then + if [[ -z $GUIX_ALLOW_OVERWRITE && (-e /var/guix || -e /gnu) ]]; then die "A previous Guix installation was found. Refusing to overwrite." + else + _msg "${WAR}Overwriting existing installation!" fi cd "$tmp_path" - tar --extract --file "$pkg" && _msg "${PAS}unpacked archive" - _msg "${INF}Installing /var/guix and /gnu..." - mv "${tmp_path}/var/guix" /var/ - mv "${tmp_path}/gnu" / + tar --extract --file "$pkg" -C / _msg "${INF}Linking the root user's profile" mkdir -p ~root/.config/guix base-commit: 1b6e251ed1bae7aa2f544e8ccb6b4aaf872e77e6 -- 2.38.1 From debbugs-submit-bounces@debbugs.gnu.org Wed Dec 14 11:34:59 2022 Received: (at 60068) by debbugs.gnu.org; 14 Dec 2022 16:34:59 +0000 Received: from localhost ([127.0.0.1]:40238 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p5Uig-0004yd-TL for submit@debbugs.gnu.org; Wed, 14 Dec 2022 11:34:59 -0500 Received: from tobias.gr ([80.241.217.52]:55566) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p5Uid-0004yX-3b for 60068@debbugs.gnu.org; Wed, 14 Dec 2022 11:34:57 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; s=2018; bh=aUn/po7Ll9Pe9 CYGKOK7D4ZgNZjc9oqcBJETlzXaLFU=; h=in-reply-to:date:subject:cc:to: from:references; d=tobias.gr; b=ap8aGhr9j+KqO0xdPQNLulZ0FSuUHUUq9Vp3Do RB0I6t7L6UYziIHqgeIowJa7u2j07qPmT8Eg7gVFQnni0kccDfEiLBW504y+uW9+o+Ia0s 9oDD9T6jtP4b0VCJz6V8vwxIz30UBBE8PO5cHzWEqPJ8eBwfSFEl7A2QWaUQ4ngqpfQFn7 NcmFdu+IG66l5ybPh0tpdyytnzJ3czOk5Jw08vg6XrqGBIEe+bw6cOImLFLDmM8vaSgtJG ecMWp3nNse7n+91DR1MJPi9OmlDcoRfX+eELLyGocghdEcb9aZNv4hQDkff8LgoSpr/dJ4 WSzvR/Lokl/zr4oyLTGyr0TA== Received: by submission.tobias.gr (OpenSMTPD) with ESMTPSA id a8987525 (TLSv1.3:AEAD-AES256-GCM-SHA384:256:NO); Wed, 14 Dec 2022 16:34:50 +0000 (UTC) References: <20221214155603.29381-1-maxim.cournoyer@gmail.com> From: Tobias Geerinckx-Rice To: Maxim Cournoyer Subject: Re: [bug#60068] [PATCH 1/2] guix-install.sh: Add GUIX_ALLOW_OVERWRITE environment variable. Date: Wed, 14 Dec 2022 17:16:19 +0100 In-reply-to: <20221214155603.29381-1-maxim.cournoyer@gmail.com> BIMI-Selector: v=BIMI1; s=default; Message-ID: <875yeec57z.fsf@nckx> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 60068 Cc: 60068@debbugs.gnu.org, guix-patches@gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable Hi Maxim, Nice! More steps towards world domination. Maxim Cournoyer =E5=86=99=E9=81=93=EF=BC=9A > +# Environment variables These sound like they should be command-line arguments. [=E2=80=A6] Actually, I'm not totally sold on GUIX_ALLOW_OVERWRITE. It's not=20 solving much a problem. Instead, the error message could be specific about what it=20 considers a =E2=80=98previous Guix installation=E2=80=99 =E2=80=94 which wo= uld be a good=20 idea regardless =E2=80=94 and tell the admin exactly what needs to be=20 removed to continue. > "groupadd" > + "useradd" Good catch, but separate patch. (=E2=99=AA) > - if [[ -e "/var/guix" || -e "/gnu" ]]; then > + if [[ -z $GUIX_ALLOW_OVERWRITE && (-e /var/guix || -e /gnu)=20 > ]]; then > die "A previous Guix installation was found. Refusing=20 > to overwrite." > + else > + _msg "${WAR}Overwriting existing installation!" > fi >=20=20 > cd "$tmp_path" > - tar --extract --file "$pkg" && _msg "${PAS}unpacked=20 > archive" > - > _msg "${INF}Installing /var/guix and /gnu..." > - mv "${tmp_path}/var/guix" /var/ > - mv "${tmp_path}/gnu" / > + tar --extract --file "$pkg" -C / I'm still in favour of using something like =E2=80=98mktemp -d=20 /gnu.XXXXXX=E2=80=99 here if there's no security flaw I missed. WDYT? If the overwrite functionality is kept, we should remove the old=20 directories before re-populating them. Kind regards, T G-R --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iIMEARYKACsWIQT12iAyS4c9C3o4dnINsP+IT1VteQUCY5n7kA0cbWVAdG9iaWFz LmdyAAoJEA2w/4hPVW15JYQA/0MC+9Nq+MATmo1+I6w6hw1wcCsFaUR5bzjr3DyO vmKWAP9ZPyqhLEYgIENx0DPBEz0p8zLD2G/yx5gCCHWgFyEmAA== =++lV -----END PGP SIGNATURE----- --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Wed Dec 14 13:25:15 2022 Received: (at submit) by debbugs.gnu.org; 14 Dec 2022 18:25:15 +0000 Received: from localhost ([127.0.0.1]:40830 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p5WRP-0006EA-1V for submit@debbugs.gnu.org; Wed, 14 Dec 2022 13:25:15 -0500 Received: from lists.gnu.org ([209.51.188.17]:34684) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p5WRL-0006E2-IU for submit@debbugs.gnu.org; Wed, 14 Dec 2022 13:25:14 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p5WRL-0001v7-8p for guix-patches@gnu.org; Wed, 14 Dec 2022 13:25:11 -0500 Received: from mail-qt1-x833.google.com ([2607:f8b0:4864:20::833]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1p5WRI-0004VF-UJ for guix-patches@gnu.org; Wed, 14 Dec 2022 13:25:10 -0500 Received: by mail-qt1-x833.google.com with SMTP id z12so3174631qtv.5 for ; Wed, 14 Dec 2022 10:25:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to; bh=ovMA1yYudgloTuA9/nVOFX5koLSSm+x//KFueCR8NfA=; b=JPx4+mhXO3yhEDPDHYN6j6yJFSyYXWfokc1Dcc2p+HAckI0jdM97zQGpyopcsc5fLv B6LjJYYn6KsQa/t3a094b4ELfOeVc4VAkgOWkH7cx3bO9xmAJJU0uzvHyLIbWBNAPdVT ZgfyOQ3pFzaVeDGMD/XvAAjtDlseAUGDFP7/+mFCxeoAEQnBopO4LUQrjkLXmYKJcvjd biW+eejbpUv0PIRylJib3I2izd5GDH2yIvS6l4a9kwiQFThEY7uCNsfq0znBG9bHy//5 B486u4wEqg9RoEoCLZawsyuBtvn4KAkURpoR9C7GtLffsBpxIOm/cUI3kGn7XMNCeLgn /DhA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=ovMA1yYudgloTuA9/nVOFX5koLSSm+x//KFueCR8NfA=; b=CpIFHM+n/p0dFTleUNqYTxo3OGUMmQ5LAKvRpkQB8i7GHzdK8ZV1gCV2nMLqTg3q2f izYY97gZGs5fEBmeBITtarW0tCfTt1K1Ms9+Wx5Cwk77wsK9LqJk/vZy7C9GsyLRQKAq MZeVG+hIfUrQsWlqpBzAnJ1YCzZZN/SmnaZFm0qG0Mof+YngJjx8yUM1EVAsXQsx/bRY pYcEg4KNZOCw3ddkFH7va+pRkZMB6EPcW3KvB7B3W5MRQZBS2k2FQ/ym/nabma97cDaS 3Wq+EK0gY9eZ1l1SyVec1FiV+93cnM0WLBE9dh/pievgzqDKowxok45zjwxoW1spsP1T nFlA== X-Gm-Message-State: ANoB5pnkZLL+/NXIsCZt18qAxi3lQ1A7N92RU5ADLGYN0EjD2ZkHPS6+ 7tm26dsQk1nPWFpPY0zrk/ljqgT3qnzzLA== X-Google-Smtp-Source: AA0mqf6UwWje3HNfRkRJzf2OPgdyfwpGZlEb33km+PjFesdmqCnF9XiO8shfN+AB7uP+Pi4499JCuA== X-Received: by 2002:ac8:6f09:0:b0:3a8:1f82:5b66 with SMTP id bs9-20020ac86f09000000b003a81f825b66mr12481585qtb.18.1671042307693; Wed, 14 Dec 2022 10:25:07 -0800 (PST) Received: from hurd ([2607:fad8:4:3::1006]) by smtp.gmail.com with ESMTPSA id u13-20020a05620a430d00b006fbdeecad51sm10525718qko.48.2022.12.14.10.25.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 14 Dec 2022 10:25:07 -0800 (PST) From: Maxim Cournoyer To: Tobias Geerinckx-Rice Subject: Re: [bug#60068] [PATCH 1/2] guix-install.sh: Add GUIX_ALLOW_OVERWRITE environment variable. References: <20221214155603.29381-1-maxim.cournoyer@gmail.com> <875yeec57z.fsf@nckx> Date: Wed, 14 Dec 2022 13:25:06 -0500 In-Reply-To: <875yeec57z.fsf@nckx> (Tobias Geerinckx-Rice's message of "Wed, 14 Dec 2022 17:16:19 +0100") Message-ID: <87zgbp3ksd.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=2607:f8b0:4864:20::833; envelope-from=maxim.cournoyer@gmail.com; helo=mail-qt1-x833.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit Cc: 60068@debbugs.gnu.org, guix-patches@gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) Hi Tobias, Tobias Geerinckx-Rice writes: > Hi Maxim, > > Nice! More steps towards world domination. Eh :-) > Maxim Cournoyer =E5=86=99=E9=81=93=EF=BC=9A >> +# Environment variables > > These sound like they should be command-line arguments. I agree, but that'd require a loop, or GNU getopt, and I'm not motivated enough in the moment to re-design it :-). When we get there, we could add an --uninstall option too. > [=E2=80=A6] > > Actually, I'm not totally sold on GUIX_ALLOW_OVERWRITE. It's not > solving much a problem. The problem it solves for me was that I needed to use 'guix pack'd dependencies such as gpg, glibc for getent, and shadow's groupadd/useradd, etc. to satisfy the install script dependencies on my weird target OS (minimal busybox embedded OS); which are needed to be unpacked under /gnu, thus conflicting with the requirement that /gnu doesn't exist. I tried a relocatable pack, but it didn't work, at least for gpg (file not found error). > Instead, the error message could be specific about what it considers a > =E2=80=98previous Guix installation=E2=80=99 =E2=80=94 which would be a g= ood idea regardless =E2=80=94 > and tell the admin exactly what needs to be removed to continue. > >> "groupadd" >> + "useradd" > > Good catch, but separate patch. (=E2=99=AA) OK! >> - if [[ -e "/var/guix" || -e "/gnu" ]]; then >> + if [[ -z $GUIX_ALLOW_OVERWRITE && (-e /var/guix || -e /gnu) ]]; >> then >> die "A previous Guix installation was found. Refusing >> to overwrite." >> + else >> + _msg "${WAR}Overwriting existing installation!" >> fi >> cd "$tmp_path" >> - tar --extract --file "$pkg" && _msg "${PAS}unpacked archive" >> - >> _msg "${INF}Installing /var/guix and /gnu..." >> - mv "${tmp_path}/var/guix" /var/ >> - mv "${tmp_path}/gnu" / >> + tar --extract --file "$pkg" -C / > > I'm still in favour of using something like =E2=80=98mktemp -d /gnu.XXXXX= X=E2=80=99 > here if there's no security flaw I missed. WDYT? > > If the overwrite functionality is kept, we should remove the old > directories before re-populating them. Hopefully the reason the above makes more sense is also covered by my use case explanation above. Is the use case/change motivation a bit clearer now? --=20 Thanks, Maxim From debbugs-submit-bounces@debbugs.gnu.org Wed Dec 14 15:46:57 2022 Received: (at 60068) by debbugs.gnu.org; 14 Dec 2022 20:46:57 +0000 Received: from localhost ([127.0.0.1]:41784 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p5YeW-0004Cn-Ph for submit@debbugs.gnu.org; Wed, 14 Dec 2022 15:46:56 -0500 Received: from mail-qv1-f48.google.com ([209.85.219.48]:35536) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p5YeU-0004Cg-FI for 60068@debbugs.gnu.org; Wed, 14 Dec 2022 15:46:54 -0500 Received: by mail-qv1-f48.google.com with SMTP id i12so580233qvs.2 for <60068@debbugs.gnu.org>; Wed, 14 Dec 2022 12:46:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=s1S5diU0loMggoAHjZl0JwyWRf9X445sUSvA71M+bJE=; b=Ktp7ej3EuIc0YEgvKJA3EBwpUsaS/B9swHXFzYIDjiNoYQ3k1tHxMxa9xUX1LARRlL mrPe7wOFZ+sq89bukGX36SaqyM7MKNNn7j9iDkISxiCm/W2bihqyzB2o7cNrmJ0DoOnT zmKW66Qi/rzs7Ph+wlNBcN07n4e7bkyjoQgZ2pbYICUs6lzlCfmvXHtqLSFDw04vmAd6 nokyWtB/d9NgQy8y1/8kM2Z5znZm4d40hgJG+q2bA/2DADDiSfyi6iwMp+snJxDP+8g3 ogsIhXTWxSOLSiaiDLmWDvHjj6pwZkyV9CZnuxk5uaeN0yK0391UzuTAZ0vbXYwWrmvn wFBw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=s1S5diU0loMggoAHjZl0JwyWRf9X445sUSvA71M+bJE=; b=Gov9wjSPlC64gcWKMK+OfxcCruBcSAHgd7im6e/JBP2com6gT9726U4kZ35Yykx+fy IvAoOgC6VuULWnNdJ7N/+KYkrQbi1mCrQp5SWdw9L2AuroiqVi3JPmIqA1k8mMGaboAH FBeJ/04WoU+XtjQ9d0HMHkwpNaTIGNDZn47Zv+KHNwckgw6El7lLEhW8Wkb9pvyJLH8K LnIqgt3UokekUSFLChdP5Oy79GDtodhdJ6c01kYbF0TfvvXMSjMtzi+gB73jVPL85N1f WZRSppHtqtmucp+3+RUNZNI6H/l6vIJVJeyBCHz1WmPasQJFgaTaSKhaFuH2p2G1rpLV g+TQ== X-Gm-Message-State: ANoB5pnOVptg8bR7XXQzfvRnAu13psziZzD3WQNWoHa3qOENg+x3k+39 1JaY25HddaLK6T3MdW6OXZmYS+r+GA5wyw== X-Google-Smtp-Source: AA0mqf518wTVFsEkVgQFLv2qprarSxwVXtt+2NNGPeaY0Kw7nokfjB0VKrrp694LgPpuMXUpv/SRIg== X-Received: by 2002:a05:6214:3607:b0:4c7:6938:329d with SMTP id nv7-20020a056214360700b004c76938329dmr38867703qvb.0.1671050808689; Wed, 14 Dec 2022 12:46:48 -0800 (PST) Received: from localhost.localdomain ([2607:fad8:4:3::1006]) by smtp.gmail.com with ESMTPSA id p13-20020a05620a112d00b006f87d28ea3asm10192676qkk.54.2022.12.14.12.46.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 14 Dec 2022 12:46:48 -0800 (PST) From: Maxim Cournoyer To: 60068@debbugs.gnu.org Subject: [PATCH v2 1/3] guix-install.sh: Add missing "useradd" command. Date: Wed, 14 Dec 2022 15:46:38 -0500 Message-Id: <20221214204640.16879-1-maxim.cournoyer@gmail.com> X-Mailer: git-send-email 2.38.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 60068 Cc: me@tobias.gr, Maxim Cournoyer X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) * etc/guix-install.sh: (REQUIRE): Add missing "useradd" command. --- etc/guix-install.sh | 1 + 1 file changed, 1 insertion(+) diff --git a/etc/guix-install.sh b/etc/guix-install.sh index f008593d84..b8ea9e54c3 100755 --- a/etc/guix-install.sh +++ b/etc/guix-install.sh @@ -53,6 +53,7 @@ REQUIRE=( "chmod" "uname" "groupadd" + "useradd" "tail" "tr" "xz" base-commit: fa23fb86f7741570d194bba1f227016d9aa25881 -- 2.38.1 From debbugs-submit-bounces@debbugs.gnu.org Wed Dec 14 15:47:01 2022 Received: (at 60068) by debbugs.gnu.org; 14 Dec 2022 20:47:01 +0000 Received: from localhost ([127.0.0.1]:41787 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p5Yeb-0004D0-0m for submit@debbugs.gnu.org; Wed, 14 Dec 2022 15:47:01 -0500 Received: from mail-vk1-f176.google.com ([209.85.221.176]:36773) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p5YeZ-0004Ch-3b for 60068@debbugs.gnu.org; Wed, 14 Dec 2022 15:46:59 -0500 Received: by mail-vk1-f176.google.com with SMTP id l17so3761570vkk.3 for <60068@debbugs.gnu.org>; Wed, 14 Dec 2022 12:46:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Un0fZJVaLUxbKw8DTSotXo0HP/nDyh/LNRYFXBJIEhQ=; b=nJdd2Va10Aqw8PFd4EDn+eRpXEogj3qc7PtRYVR/WW8EkOd4qxex3yv9uORuMCKOnm pJ9o9LKx/bIkh40JnDp2kj+Kp0Qe+BJRDmOqtG/eXb7xxn4Bu5pf0QxjzcpcJ8lulOpD znDH2ytGXlyuIACV6yDAFW/4gqjQR7nDvR0Po5qnXHPLjxZAG6DOLlTi7RhLQS5P7jMl Dly82des+YGIbreRqKt3pkTT5ByF4u3vW1qjQ3qrk/GZ6+K+qlQjf0rfCXjo/YJy3Z6k eajfddUTTnZeNpFxnN/4zmx8S9jHLbN1Md5qJ7wT0+D+TRn7asnnfIl3H7bdkBEk0buQ R36w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Un0fZJVaLUxbKw8DTSotXo0HP/nDyh/LNRYFXBJIEhQ=; b=r+tJFgu9xzwVWRdnjYJP6JEDpQnl/odkHs+mf4rXWsp4LDO63GSbA4qCiIj5cS+MzJ d7JHpVkLSFHt847KTbfbkhaRFNioslFsANRht99Dmo0l0uCuv+PKzOnvADvZ2pD1sYNS 72YuiyumXwQ6Wr0AZLQ8Wc+mJci1nsGcxRQLpbCHzPn+f0EYCaek3jBTI1O2D/PR8IEJ h0yBB4PGzlczsl4SXiauuMj7xklw3mgloUPZl7/p3e5kjVd5K07oPIkKQ01cfTdFvkrn joZPZtRU6W1jTxc3k1PXepn0+RsEc7l4ipid3r5/55/RuAQjEwan1VHhILoiT7yWL7Sl ibiw== X-Gm-Message-State: ANoB5pn2qWIauvuAP6P7zb6V5At+eByVSSnX/qZbkwEKjM79ZttpCosA 9BnmsLP39dBr79ymFZ9m6QwTVR/fud60RQ== X-Google-Smtp-Source: AA0mqf51yW3eD6cDdoCOl1Nxef/3Y2DkEoLy7sKOAWtlJ8zH8oTMKBi+S86IRDFloZBDC+4ZaXHRiw== X-Received: by 2002:a1f:ea42:0:b0:3bd:fb7f:e385 with SMTP id i63-20020a1fea42000000b003bdfb7fe385mr13349086vkh.8.1671050813270; Wed, 14 Dec 2022 12:46:53 -0800 (PST) Received: from localhost.localdomain ([2607:fad8:4:3::1006]) by smtp.gmail.com with ESMTPSA id p13-20020a05620a112d00b006f87d28ea3asm10192676qkk.54.2022.12.14.12.46.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 14 Dec 2022 12:46:52 -0800 (PST) From: Maxim Cournoyer To: 60068@debbugs.gnu.org Subject: [PATCH v2 2/3] guix-install.sh: Add GUIX_ALLOW_OVERWRITE environment variable. Date: Wed, 14 Dec 2022 15:46:39 -0500 Message-Id: <20221214204640.16879-2-maxim.cournoyer@gmail.com> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20221214204640.16879-1-maxim.cournoyer@gmail.com> References: <20221214204640.16879-1-maxim.cournoyer@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 60068 Cc: me@tobias.gr, Maxim Cournoyer X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) The need for this use case appeared when attempting to install Guix on a truly minimal image made with Buildroot, which lacked enough GNU components that I had to extract a guix pack to /gnu before attempting installation, which would then refuse to proceed because of the existing /gnu. * etc/guix-install.sh: Document environment variables. (sys_create_store) [GUIX_ALLOW_OVERWRITE]: Skip pre-existing installation checks and output a warning. Extract the tarball directly to /. --- etc/guix-install.sh | 25 ++++++++++++++++++++----- 1 file changed, 20 insertions(+), 5 deletions(-) diff --git a/etc/guix-install.sh b/etc/guix-install.sh index b8ea9e54c3..62d85e765a 100755 --- a/etc/guix-install.sh +++ b/etc/guix-install.sh @@ -29,6 +29,22 @@ # We require Bash but for portability we'd rather not use /bin/bash or # /usr/bin/env in the shebang, hence this hack. + +# Environment variables +# +# GUIX_BINARY_FILE_NAME +# +# Can be used to override the automatic download mechanism and point +# to a local Guix binary archive filename like +# "/tmp/guix-binary-1.4.0rc2.armhf-linux.tar.xz" +# +# GUIX_ALLOW_OVERWRITE +# +# Instead of aborting to avoid overwriting a previous installations, +# allow copying over /var/guix or /gnu. This can be useful when the +# installation required the user to extract Guix packs under /gnu to +# satisfy its dependencies. + if [ "x$BASH_VERSION" = "x" ] then exec bash "$0" "$@" @@ -338,16 +354,15 @@ sys_create_store() _debug "--- [ ${FUNCNAME[0]} ] ---" - if [[ -e "/var/guix" || -e "/gnu" ]]; then + if [[ -z $GUIX_ALLOW_OVERWRITE && (-e /var/guix || -e /gnu) ]]; then die "A previous Guix installation was found. Refusing to overwrite." + else + _msg "${WAR}Overwriting existing installation!" fi cd "$tmp_path" - tar --extract --file "$pkg" && _msg "${PAS}unpacked archive" - _msg "${INF}Installing /var/guix and /gnu..." - mv "${tmp_path}/var/guix" /var/ - mv "${tmp_path}/gnu" / + tar --extract --file "$pkg" -C / _msg "${INF}Linking the root user's profile" mkdir -p ~root/.config/guix -- 2.38.1 From debbugs-submit-bounces@debbugs.gnu.org Wed Dec 14 15:47:05 2022 Received: (at 60068) by debbugs.gnu.org; 14 Dec 2022 20:47:05 +0000 Received: from localhost ([127.0.0.1]:41792 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p5Yef-0004Di-HT for submit@debbugs.gnu.org; Wed, 14 Dec 2022 15:47:05 -0500 Received: from mail-vk1-f175.google.com ([209.85.221.175]:43844) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p5Yec-0004Co-0I for 60068@debbugs.gnu.org; Wed, 14 Dec 2022 15:47:02 -0500 Received: by mail-vk1-f175.google.com with SMTP id g137so3743227vke.10 for <60068@debbugs.gnu.org>; Wed, 14 Dec 2022 12:47:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=45V4zygLPUbUUHmAG3m2+7+BRyv6ncJsMrXYIl7BXM4=; b=PZs+djoCMCmLZZb3IUHAwrIOdXIJ90y+uAWFfuuALzg3u6cwMORIY+pZIljB+Sid1q X9iN50cFHM6uWr84xtAOvGoQ8yynfGAIMHwvVDqNCC7Xwnu2ntgd+MAqJCPVMdrZ4dHR rMI3IJJHSEJbIYrb3V9IDdFTcV7rvcWNV/OhVFeyp/+nhWte1Q37jNz0L93QylxuFiIo IENN457vX3ppzv7aXTnc1AXpnlTnvC9pVFg+Lpzj5naH7JIQxcEPBbVv/M1KW2v1P5d3 RuhKy+SVmtDhFoDuKm+hs8Vw5H1ekz2lqgr7HWfqD7XpRoWXMMmIMp2CSjXZbFmRFJOy XcJw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=45V4zygLPUbUUHmAG3m2+7+BRyv6ncJsMrXYIl7BXM4=; b=SGGRiTIUfhv2dNkaoGKG98EN63MfvCDlGwJJKdUPu4OnY/rX0q6nMEaRfcQfDAJOSJ EWe0WfS6kpyV5ugKoTv41vni/Sxr8c4opmMrtxj7hpENpVEJe+w1Ze62jWgMFZsMy6Wt 9fDWjDjav9fbRGXcJno6n2awZbUL6VQmdE1QhBWhvUhMwyORN1xXa2lWzlOZG1wGXGcZ jVNI/Qo0K1/SaS3rPCua3q6NKDgMWDx0uPOArAjMXog+InCnxbtARHMOFSSF+mMSESRw /vpchpo3sdxbmry35T9BiV2YMD4vKb2kg3ysy/3JuK7jYfhLfb6s9cJjrTk4j3ytTgn2 XkWA== X-Gm-Message-State: ANoB5pkO9zJgb3pp6EAEhMr0hR5OV1/l77futnIGBRxsNHY9QDDUlaYe OosSL8g8hxbX83azM6BtRFdCLBRsK+33XQ== X-Google-Smtp-Source: AA0mqf5GCbN7rsc4OPyW9+4Pj/cv8X8B8CyDk/CyDy5K2+CP5gQ/D0Q+OdF5+K9/wOgs9V/5qgnXfg== X-Received: by 2002:a1f:9f42:0:b0:3bc:d00d:82e6 with SMTP id i63-20020a1f9f42000000b003bcd00d82e6mr15732643vke.2.1671050816393; Wed, 14 Dec 2022 12:46:56 -0800 (PST) Received: from localhost.localdomain ([2607:fad8:4:3::1006]) by smtp.gmail.com with ESMTPSA id p13-20020a05620a112d00b006f87d28ea3asm10192676qkk.54.2022.12.14.12.46.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 14 Dec 2022 12:46:56 -0800 (PST) From: Maxim Cournoyer To: 60068@debbugs.gnu.org Subject: [PATCH v2 3/3] guix-install.sh: Directly exit in case of errors in chk_require. Date: Wed, 14 Dec 2022 15:46:40 -0500 Message-Id: <20221214204640.16879-3-maxim.cournoyer@gmail.com> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20221214204640.16879-1-maxim.cournoyer@gmail.com> References: <20221214204640.16879-1-maxim.cournoyer@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 60068 Cc: me@tobias.gr, Maxim Cournoyer X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) * etc/guix-install.sh (chk_require): Directly exit in case of errors in chk_require, instead of relying on 'set -e'. --- etc/guix-install.sh | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/etc/guix-install.sh b/etc/guix-install.sh index 62d85e765a..ea10f35250 100755 --- a/etc/guix-install.sh +++ b/etc/guix-install.sh @@ -137,10 +137,8 @@ chk_require() command -v "$c" &>/dev/null || warn+=("$c") done - [ "${#warn}" -ne 0 ] && - { _err "${ERR}Missing commands: ${warn[*]}."; - return 1; } - + [ "${#warn}" -ne 0 ] && die "Missing commands: ${warn[*]}." + _msg "${PAS}verification of required commands completed" } -- 2.38.1 From debbugs-submit-bounces@debbugs.gnu.org Wed Dec 14 15:47:21 2022 Received: (at control) by debbugs.gnu.org; 14 Dec 2022 20:47:21 +0000 Received: from localhost ([127.0.0.1]:41795 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p5Yeu-0004Dx-RO for submit@debbugs.gnu.org; Wed, 14 Dec 2022 15:47:20 -0500 Received: from mail-vs1-f42.google.com ([209.85.217.42]:40530) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p5Yer-0004Dr-Nn for control@debbugs.gnu.org; Wed, 14 Dec 2022 15:47:18 -0500 Received: by mail-vs1-f42.google.com with SMTP id 3so985250vsq.7 for ; Wed, 14 Dec 2022 12:47:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=subject:from:to:message-id:date:from:to:cc:subject:date:message-id :reply-to; bh=rS9DDSNjNe/3VXA49rs5Q4zy/BoI3JFxiRwal3/8Yug=; b=DdhTzP8WqduyM93i9W1D+js08F0Wl8zJWeY+u9+ql+uu9uHgtawSuLJn9oh10/b+5K F/jsTHck2Fr+x6VQhgTlWHS3hbKYNYuePJSZe4j2ycbwA9AoD7R0E+UEKKqavhqdkv2B 38uQ0407+lAB740d8SMsyDLK3FUCWTV/KTqQpNDFhWqp2gO1t5a5gZoRUpktMsAEmVe1 soEYjd2IlErggVebSnvhBajwTuB4rHYHeBLLB++WPbmfDUoXvYQ2XwZ0yBmmBznWW5zS XEL5hpMgwxVTFqXHRpXbgx2iimidJQvbBYf2CBX1ZuzOhAb0RYLmAYERFWaxnQwhZKnJ tXag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=subject:from:to:message-id:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=rS9DDSNjNe/3VXA49rs5Q4zy/BoI3JFxiRwal3/8Yug=; b=E7eeSxZE/fASNH6pB/D6NUNJbYs8GqreggGBNMIFZuctbGsou4k48CkLXpiczjpkzc 3NpZsLRmvtIA0nuOXzQFWcdvlan9jBZz30emCXobO1wll1065xrRVOYRFljeBGxEq4qv 6/kK2/CUNuKe50imaLxQlc2cCJ3Ti3mOTKyUugAAgGT874cEhn3I9Adh8TL5XtDwP6O8 u8k9jJNj4VjqD7KkOw22CF/KGwP88VlUJj/nQYqwr1kUNZThPjsJr41Fq3WwIjprDGLa AIWG4PByIFAM0x5h4X+zT5cMa0mmRnfGLFjV7A9d8f3M3LBKzLbn1y++2mTh687/lVxo PTBQ== X-Gm-Message-State: ANoB5plRMl1ej3xFawbYUftoHQp3y/YlRQ7ZolOrVWNivaniCmW/we62 6bBKvgtOciNmXTXiMC8A5t3fcUF9FXkEVQ== X-Google-Smtp-Source: AA0mqf6NHViIo+eazjJRm2mMcIY4iIPJZMY+50nWKZOjMHjLUwmCYiCiOTZwoaOGEVnH2Ag7ySSNZQ== X-Received: by 2002:a67:6a85:0:b0:3b0:b5fe:d847 with SMTP id f127-20020a676a85000000b003b0b5fed847mr15923287vsc.16.1671050832108; Wed, 14 Dec 2022 12:47:12 -0800 (PST) Received: from hurd ([2607:fad8:4:3::1006]) by smtp.gmail.com with ESMTPSA id r18-20020a05620a299200b006fed2788751sm10838769qkp.76.2022.12.14.12.47.11 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 14 Dec 2022 12:47:11 -0800 (PST) Date: Wed, 14 Dec 2022 15:47:10 -0500 Message-Id: <87cz8l3e7l.fsf@gmail.com> To: control@debbugs.gnu.org From: Maxim Cournoyer Subject: control message for bug #60068 X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) forcemerge 60068 60069 quit From debbugs-submit-bounces@debbugs.gnu.org Thu Dec 15 09:41:37 2022 Received: (at 60068) by debbugs.gnu.org; 15 Dec 2022 14:41:37 +0000 Received: from localhost ([127.0.0.1]:43087 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p5pQX-0006uG-GN for submit@debbugs.gnu.org; Thu, 15 Dec 2022 09:41:37 -0500 Received: from eggs.gnu.org ([209.51.188.92]:46400) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p5pQU-0006u3-MR; Thu, 15 Dec 2022 09:41:35 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p5pQN-0006xF-W6; Thu, 15 Dec 2022 09:41:28 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=3BuK762PYisDf5OdEqnu2pu6ZKEodWpL3849+Bg8YaI=; b=Md5xU6d4VK6E/W4tXb/U n1yfL2GTmkoGtglVOSpqDQZknkw4ERXQdOnG8XP8VZIXsGYR2qLjNrHIzfwKtvRjsv4PwJ1MIK1AR feigdZSh+v2dJ6nty5l3mzPWhdJ7QRDyxBAEUMxybhqvtmtC9bY/7r/ghzBsZ/OyDaG3XV2RPyIcx CyxrtLsWQLWdqzEClSX1B3yPZQfrwvn/xAJLn992R2oBJ4khO/LzuxJWLo9W49/mkzWT0dcuS80zA CowsA3JtV2lK65cH43FuhWLIfQyVNj1YqdvPgCQOUSmcg4Ila0l3r2ZF+GRaqHHJUvp7NnAMEiapY AcKYnrZKJ0Zq8Q==; Received: from [89.207.171.79] (helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p5pQL-00033L-RR; Thu, 15 Dec 2022 09:41:27 -0500 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Maxim Cournoyer Subject: Re: bug#60069: [PATCH 2/2] guix-install.sh: Directly exit in case of errors in chk_require. References: <20221214155603.29381-1-maxim.cournoyer@gmail.com> <20221214204640.16879-1-maxim.cournoyer@gmail.com> Date: Thu, 15 Dec 2022 15:41:17 +0100 In-Reply-To: <20221214204640.16879-1-maxim.cournoyer@gmail.com> (Maxim Cournoyer's message of "Wed, 14 Dec 2022 15:46:38 -0500") Message-ID: <871qp0pw4y.fsf_-_@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 60068 Cc: me@tobias.gr, 60069@debbugs.gnu.org, 60068@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hi, Maxim Cournoyer skribis: > * etc/guix-install.sh: (REQUIRE): Add missing "useradd" command. [...] > * etc/guix-install.sh (chk_require): Directly exit in case of errors in > chk_require, instead of relying on 'set -e'. These two patches LGTM; you can add them to =E2=80=98master=E2=80=99 and th= at way people will benefit from it when installing 1.4.0. Thanks! Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Thu Dec 15 09:43:40 2022 Received: (at 60068) by debbugs.gnu.org; 15 Dec 2022 14:43:40 +0000 Received: from localhost ([127.0.0.1]:43102 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p5pSV-0006wZ-Po for submit@debbugs.gnu.org; Thu, 15 Dec 2022 09:43:40 -0500 Received: from eggs.gnu.org ([209.51.188.92]:46966) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p5pST-0006wO-Ry; Thu, 15 Dec 2022 09:43:38 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p5pSO-0007H4-Ke; Thu, 15 Dec 2022 09:43:32 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=mhraeYUF9QDM1RX4k5O9WuDSc8dzqcHl3TqeuXxXV+8=; b=Vg2bEpPbW73FZUuaja+m KVhI+a1sxFvB8h7QMybfUOGFP+xXAxMEvBlyvi5Hqsb2Kt2PArjdXzLljL4+srDkXf5SpRSkl9MS0 W4n+QYo3PyM2uGqw1flCYQhd9/jtTVunDvbt1qqoHp/9V5nYSQnNxrjjGvZgOEksKGqUjQtmOyE8z bIKwZoT05+v7k3XVvrWggpUN7c3deACbKpvga+k7DJ3nYK5RHSwfqPjJDO0TQX6cBD7iBNJzc3bLE cS8K44erDo9mKQDdZNpyPulJ14j2mfiRb1B5O26vpBDdlx7mw3VnLDommZ4wT2TsWm/VAIfo5N+FP 2h8et5J+hvP99A==; Received: from [89.207.171.79] (helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p5pSB-0003JN-9s; Thu, 15 Dec 2022 09:43:32 -0500 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Maxim Cournoyer Subject: Re: bug#60069: [PATCH 2/2] guix-install.sh: Directly exit in case of errors in chk_require. References: <20221214204640.16879-1-maxim.cournoyer@gmail.com> <20221214204640.16879-2-maxim.cournoyer@gmail.com> Date: Thu, 15 Dec 2022 15:43:16 +0100 In-Reply-To: <20221214204640.16879-2-maxim.cournoyer@gmail.com> (Maxim Cournoyer's message of "Wed, 14 Dec 2022 15:46:39 -0500") Message-ID: <87wn6sohh7.fsf_-_@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 60068 Cc: me@tobias.gr, 60069@debbugs.gnu.org, 60068@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Maxim Cournoyer skribis: > The need for this use case appeared when attempting to install Guix on a = truly > minimal image made with Buildroot, which lacked enough GNU components tha= t I > had to extract a guix pack to /gnu before attempting installation, which = would > then refuse to proceed because of the existing /gnu. > > * etc/guix-install.sh: Document environment variables. > (sys_create_store) [GUIX_ALLOW_OVERWRITE]: Skip pre-existing installation > checks and output a warning. Extract the tarball directly to /. Like Tobias, I=E2=80=99m reluctant to adding environment variables; I=E2=80= =99m also skeptical about the use case (I think it=E2=80=99s fine to let users remove their previous installation if that=E2=80=99s what they want). I also think we=E2=80=99d rather minimize changes to the script since we=E2= =80=99re a couple of days before the release. Thanks, Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Thu Dec 15 09:45:06 2022 Received: (at 60068) by debbugs.gnu.org; 15 Dec 2022 14:45:06 +0000 Received: from localhost ([127.0.0.1]:43111 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p5pTu-0006yO-HL for submit@debbugs.gnu.org; Thu, 15 Dec 2022 09:45:06 -0500 Received: from eggs.gnu.org ([209.51.188.92]:48258) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p5pTs-0006xd-BU; Thu, 15 Dec 2022 09:45:04 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p5pTn-0007Y5-48; Thu, 15 Dec 2022 09:44:59 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=mhraeYUF9QDM1RX4k5O9WuDSc8dzqcHl3TqeuXxXV+8=; b=izACIWKvsEx9r/w2Jr6N adTxcb7dUWItbZWf9xYpWA3UMGoUAXuUVHwuOVGEAohGwnqh+favwwNIiQSPAd5aEezt9cDUvc91H i8NNhVCRy841uRX+hoewomZaRQWI1lYRgXNFd4WBBi5eMq4Nkt59Q8TYyUj/QDxajzEq5+RlDA+1q OY5tHa6DtjJ5vNlTKL6e8sYIjyxcwbSE+FltmvQXT2JpnZmcJpBORJz1kkabBpsIbmUGC3Fs8Brpy XbmtUI+aEE25tdZLNEfkCWAa1onCbWPBKdZqlE6eEeVen7qv0feGZ0Fj9IUOYZvks+UGU3FG9+bh7 huQdEvYByxcXEA==; Received: from [89.207.171.79] (helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p5pTl-0003Rd-T8; Thu, 15 Dec 2022 09:44:58 -0500 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Maxim Cournoyer Subject: Re: bug#60069: [PATCH 2/2] guix-install.sh: Directly exit in case of errors in chk_require. In-Reply-To: <20221214204640.16879-2-maxim.cournoyer@gmail.com> (Maxim Cournoyer's message of "Wed, 14 Dec 2022 15:46:39 -0500") References: <20221214204640.16879-1-maxim.cournoyer@gmail.com> <20221214204640.16879-2-maxim.cournoyer@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) Date: Thu, 15 Dec 2022 15:44:54 +0100 Message-ID: <87v8mcoheh.fsf_-_@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 60068 Cc: me@tobias.gr, 60069@debbugs.gnu.org, 60068@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Maxim Cournoyer skribis: > The need for this use case appeared when attempting to install Guix on a = truly > minimal image made with Buildroot, which lacked enough GNU components tha= t I > had to extract a guix pack to /gnu before attempting installation, which = would > then refuse to proceed because of the existing /gnu. > > * etc/guix-install.sh: Document environment variables. > (sys_create_store) [GUIX_ALLOW_OVERWRITE]: Skip pre-existing installation > checks and output a warning. Extract the tarball directly to /. Like Tobias, I=E2=80=99m reluctant to adding environment variables; I=E2=80= =99m also skeptical about the use case (I think it=E2=80=99s fine to let users remove their previous installation if that=E2=80=99s what they want). I also think we=E2=80=99d rather minimize changes to the script since we=E2= =80=99re a couple of days before the release. Thanks, Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Fri Dec 16 00:07:36 2022 Received: (at 60068) by debbugs.gnu.org; 16 Dec 2022 05:07:36 +0000 Received: from localhost ([127.0.0.1]:47010 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p62wY-0003PP-MH for submit@debbugs.gnu.org; Fri, 16 Dec 2022 00:07:36 -0500 Received: from mail-qt1-f169.google.com ([209.85.160.169]:39667) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p62wV-0003PE-Sd; Fri, 16 Dec 2022 00:07:32 -0500 Received: by mail-qt1-f169.google.com with SMTP id s9so1925622qtx.6; Thu, 15 Dec 2022 21:07:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to; bh=+ruKiTPXMUnBVcGs5EQ6S/DYQCNXb1vLfFrgTcjzUrc=; b=gbDt0dDisxym1G8QPVTZEc4YQXShBsYxkz4/nkJc5lFqGts5P0G4tXNbxdJGWxGgse 6sFq3w23qzzHl1vEbCoiQS1VeIuStgAf59W2Nz7Oq33kLTCXjzBKgaOxhsUUXtLmgIfm 2uaWNRqMCxprawPMjE+K9XcSu7M0clYGdUpYScfm/ixKVsxFQy9OQY+hlJt3xtMKP6Ja nYxlsUfkRuYObarDWRNgWd7QiB4He6HlCICWZY64Rj28Kde29KeoZ0fw91ZcH6nHtXMB XnHJ6z90euHLhpu0w2VoDq0gAh2SRYsrWWKYNCl5C1g8hIo8DkIkuoZR2//4cUeIpJOy MHbg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=+ruKiTPXMUnBVcGs5EQ6S/DYQCNXb1vLfFrgTcjzUrc=; b=JxEEV+MMN7nntsb/XOk+t5r2LOCv9PtPVfErPdNNWOX/stu+Xte+XnN4wsvA7Ji9Cs KO811seUpd3KEu1QqIpTtHxPusce4x9J0P4dfUjg2Od6LXo1rPY8jVov6Noo5ekG4pz7 U+yvQElS2Gq3WRrak6mtcPygUJhbKX6B9K4/QTUIPPgUNuZWUivqG6F/ZTRYdrBgqRaV YSH/gq702OOey4x1n53rjuHEffojX0A1oNV//tEBcuHh7+Ev7Kjr8/NNwacG7CPdPoL5 XAjZSJuR/jkx9Wq93p1RH5I02MMvToOySenICAScLlbnmtxgO2vT2AyR6JWTR6mi5yq7 aEoA== X-Gm-Message-State: ANoB5pkBapyf9xAWNcE1A2lgOiIZK3PQ9JLNLp1PzjEmFUzMu2Tcn/A3 6NG6fjyk0GtFrXT1FM+OEt0= X-Google-Smtp-Source: AA0mqf7TOnSVZfAbeQWKei+AxDEdp100pfU5z/EIMfOtnE7ceCxWFBfemjOyrg+ipQB69gJbwSZdnA== X-Received: by 2002:ac8:5ec6:0:b0:3a7:eab2:e461 with SMTP id s6-20020ac85ec6000000b003a7eab2e461mr38684856qtx.25.1671167246412; Thu, 15 Dec 2022 21:07:26 -0800 (PST) Received: from hurd (dsl-10-129-63.b2b2c.ca. [72.10.129.63]) by smtp.gmail.com with ESMTPSA id t1-20020ac865c1000000b003a4f22c6507sm733994qto.48.2022.12.15.21.07.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 15 Dec 2022 21:07:25 -0800 (PST) From: Maxim Cournoyer To: Ludovic =?utf-8?Q?Court=C3=A8s?= Subject: Re: bug#60069: [PATCH 2/2] guix-install.sh: Directly exit in case of errors in chk_require. References: <20221214204640.16879-1-maxim.cournoyer@gmail.com> <20221214204640.16879-2-maxim.cournoyer@gmail.com> <87wn6sohh7.fsf_-_@gnu.org> Date: Fri, 16 Dec 2022 00:07:24 -0500 In-Reply-To: <87wn6sohh7.fsf_-_@gnu.org> ("Ludovic =?utf-8?Q?Court=C3=A8s?= =?utf-8?Q?=22's?= message of "Thu, 15 Dec 2022 15:43:16 +0100") Message-ID: <87wn6saqcz.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 60068 Cc: me@tobias.gr, 60069@debbugs.gnu.org, 60068@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi Ludovic, Ludovic Court=C3=A8s writes: > Maxim Cournoyer skribis: > >> The need for this use case appeared when attempting to install Guix on a= truly >> minimal image made with Buildroot, which lacked enough GNU components th= at I >> had to extract a guix pack to /gnu before attempting installation, which= would >> then refuse to proceed because of the existing /gnu. >> >> * etc/guix-install.sh: Document environment variables. >> (sys_create_store) [GUIX_ALLOW_OVERWRITE]: Skip pre-existing installation >> checks and output a warning. Extract the tarball directly to /. > > Like Tobias, I=E2=80=99m reluctant to adding environment variables; I=E2= =80=99m also > skeptical about the use case (I think it=E2=80=99s fine to let users remo= ve > their previous installation if that=E2=80=99s what they want). Removing my previous installation wouldn't have helped (it would have cleared the guix packs I needed to be able to run the installer). Without this change, I wouldn't have been able to install guix using guix-install.sh. It's niche, but I bet it'd help folks trying to install Guix on Alpine and similar minimal OSes. > I also think we=E2=80=99d rather minimize changes to the script since we= =E2=80=99re a > couple of days before the release. The change seems fairly small to me and would be easy to revert if it causes a problem. But I'll let you do the call, given you're the one pushing the release forward (thank you!). --=20 Thanks, Maxim From debbugs-submit-bounces@debbugs.gnu.org Fri Dec 16 00:24:28 2022 Received: (at 60068) by debbugs.gnu.org; 16 Dec 2022 05:24:28 +0000 Received: from localhost ([127.0.0.1]:47090 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p63Ct-0003Zd-UH for submit@debbugs.gnu.org; Fri, 16 Dec 2022 00:24:28 -0500 Received: from mail-qt1-f181.google.com ([209.85.160.181]:43619) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p63Cq-0003ZV-13 for 60068@debbugs.gnu.org; Fri, 16 Dec 2022 00:24:26 -0500 Received: by mail-qt1-f181.google.com with SMTP id a16so1925797qtw.10 for <60068@debbugs.gnu.org>; Thu, 15 Dec 2022 21:24:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to; bh=82xupxKQ7m07vG3SKiXE4zfJr3nbNMxOwCXiFHeGNB4=; b=VpAAa8gAHHEKLgo4Y4i9cKQph7pPUekii0ue9LSEK+Rvq6zcOrYjY7Usi0Rf2486HC qthgDLOuIISk90+bf9l9+VGynddizuA1nMjqcABEdfD4Zwoye/bc3oSGjc3zVXlVlge3 obx85nNuJsDapYa31/0yliPGlIa+XiCp9/kpME4FgDBwH/PW5SMOBCpdhAtXE9cGDYOR S6WnzexYlVNzBq3p/Q1wA/041Tjj8GGAR/ryJMkd0loM6jlBLo82b/KsbHXa7uGq2XYa nbpPDqD3ciGLq3yH64LWvVzXIJvegq38LlmzHHNNOpU4YD5U6APKX5aG+Vug05n7hEgg HsMQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=82xupxKQ7m07vG3SKiXE4zfJr3nbNMxOwCXiFHeGNB4=; b=y0R69uBUEifi0HlbJGQDqrd2XZETThWMDqAu9aYImCs84hIfmkJ3Xo6raY/+ezHYv5 QQU+kFfC/HRWUi4a32PVulEE/8pos6KmYmhN2jDtvGVIDE9t5Srpp5ANMkhUSEy38ULE 6Lq6MtL1tsHjG+eAKDvkgqU57knaomlBENSxogQbfvzd3lPadMdIw1r14CT5HYHV17hM Eij6hYoRwhyVmeYiq8PyNFkc2zPt0sb6UwKcuhUJP1HEtpFD4n23tKzb/KXCjoulQykw xQgrtwP+oTILT2lM87VNzBJxPb1V2XyAowEKgsgRjPXEn/783mykdka6jJfy3QAlvoo+ GZyg== X-Gm-Message-State: ANoB5pmSTy8LzRgei5HbUR62S+z6nw7YUFCF7ZBw2e99ndMZRFV1abmn oNGyumqlzZZpcj6dyhVan0c= X-Google-Smtp-Source: AA0mqf7aVrRhZT6v3L7sVTvpcdIgTnjkjQNH/lCdS2mRDP9PbxY4+7WmhPHfw7dEQVUGTMp5k0a8DA== X-Received: by 2002:ac8:7214:0:b0:3a8:2f0d:cc34 with SMTP id a20-20020ac87214000000b003a82f0dcc34mr10791221qtp.25.1671168258189; Thu, 15 Dec 2022 21:24:18 -0800 (PST) Received: from hurd (dsl-10-129-63.b2b2c.ca. [72.10.129.63]) by smtp.gmail.com with ESMTPSA id w7-20020ac86b07000000b003a50d92f9b4sm780469qts.1.2022.12.15.21.24.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 15 Dec 2022 21:24:17 -0800 (PST) From: Maxim Cournoyer To: Ludovic =?utf-8?Q?Court=C3=A8s?= Subject: Re: bug#60069: [PATCH 2/2] guix-install.sh: Directly exit in case of errors in chk_require. References: <20221214155603.29381-1-maxim.cournoyer@gmail.com> <20221214204640.16879-1-maxim.cournoyer@gmail.com> <871qp0pw4y.fsf_-_@gnu.org> Date: Fri, 16 Dec 2022 00:24:16 -0500 In-Reply-To: <871qp0pw4y.fsf_-_@gnu.org> ("Ludovic =?utf-8?Q?Court=C3=A8s?= =?utf-8?Q?=22's?= message of "Thu, 15 Dec 2022 15:41:17 +0100") Message-ID: <87k02rc45b.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 60068 Cc: me@tobias.gr, 60068@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi Ludo, Ludovic Court=C3=A8s writes: > Hi, > > Maxim Cournoyer skribis: > >> * etc/guix-install.sh: (REQUIRE): Add missing "useradd" command. > > [...] > >> * etc/guix-install.sh (chk_require): Directly exit in case of errors in >> chk_require, instead of relying on 'set -e'. > > These two patches LGTM; you can add them to =E2=80=98master=E2=80=99 and = that way people > will benefit from it when installing 1.4.0. Done, for the two patches mentioned above, leaving the GUIX_ALLOW_OVERWRITE one open for further discussions. --=20 Thanks, Maxim From debbugs-submit-bounces@debbugs.gnu.org Fri Feb 03 23:37:11 2023 Received: (at submit) by debbugs.gnu.org; 4 Feb 2023 04:37:11 +0000 Received: from localhost ([127.0.0.1]:40357 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pOAIY-0000Rm-Ud for submit@debbugs.gnu.org; Fri, 03 Feb 2023 23:37:11 -0500 Received: from lists.gnu.org ([209.51.188.17]:46228) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pOAIS-0000RV-VZ for submit@debbugs.gnu.org; Fri, 03 Feb 2023 23:37:09 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pOAIS-0005cq-Pc for guix-patches@gnu.org; Fri, 03 Feb 2023 23:37:04 -0500 Received: from mail-qv1-xf2d.google.com ([2607:f8b0:4864:20::f2d]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pOAIR-0008W4-Bj; Fri, 03 Feb 2023 23:37:04 -0500 Received: by mail-qv1-xf2d.google.com with SMTP id z6so174598qvp.11; Fri, 03 Feb 2023 20:37:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to; bh=fOarm2JYN2fj7CM1j+KA0Ij+owPkmdr//15spaXPLu0=; b=l1qqAn285HaOHwDLVYnoNk87aihx/PiR+sbBKNo6oxX4QxEgZtVT0ZdxbSAs1DPwOz QsYhddzkNaTb9+clBST3fL+22+iqUQwwJW2M3J2nXeG1gZbQlvHpCpyZaOYatMSUWLn6 2QRVU6Mlj1sthj+ndUEwMf1nhsUpgHtO2qVDva7VwQZteQznFlcXPbIr7RHKZHp6bOyq VX08U7MNidRxm9FbDFo+ektpoHYG3afSj+AR1D25BHuBM8Yg0hPuR9qSLG6oKEuO8604 AxQROE+Auj3Xkg3j8rPH4PYbfsLyVVfIag9eO5U95TV5aiwnDDUa1Kym0KXebkKu7cWn 709Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=fOarm2JYN2fj7CM1j+KA0Ij+owPkmdr//15spaXPLu0=; b=hRVLrs60gMr31K7BzaoXwENfxFoJMylpVeIPSj6TWuHzzhjwQSLT3UHffI7VE9fxKQ QYMm/XhNPFieyLslOXtbJuS0Og34m9ppPcQt35tqvBZRM+CW8bghOTbxavyrtVJegDae KrbX0q46f4MWhTdGURLpp+h62KootuGxTg/+b5ngDGF6+8l/oc0t+vob859XVtzWw8BP ddvkUdiZfmBC8n82k3BKenTxg2xRLF0LXPqgLipmGsvDeZQSjzZ80O4d+tkj6+vlVBKp 6hfhF9REKHCwx2HAGPFNCoN8qb+Pm8lBWLjqnJ2RWCo5h5zCCWMbH87S0J//GSPttVVU zAmg== X-Gm-Message-State: AO0yUKVh96/1+zJChqDI24Bkdy6I5vI4LQ7z4uzQZCo77oLhUuilCVJ9 HHQMXR6Ftzt7nKW2DMkw9ULJqMvCags= X-Google-Smtp-Source: AK7set8pNr3XHSJJSjjKOQX1nHQDGKVz6r2ynLv4aCw4DvW+vOd3UGtsUEpA6PoMKSH7fhiqK/LS+w== X-Received: by 2002:a05:6214:b69:b0:568:d79c:7a70 with SMTP id ey9-20020a0562140b6900b00568d79c7a70mr8574002qvb.1.1675485421113; Fri, 03 Feb 2023 20:37:01 -0800 (PST) Received: from hurd (dsl-10-136-177.b2b2c.ca. [72.10.136.177]) by smtp.gmail.com with ESMTPSA id k64-20020a37ba43000000b007023fc46b64sm3049727qkf.113.2023.02.03.20.37.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 03 Feb 2023 20:37:00 -0800 (PST) From: Maxim Cournoyer To: Tobias Geerinckx-Rice Subject: Re: [bug#60068] [PATCH 1/2] guix-install.sh: Add GUIX_ALLOW_OVERWRITE environment variable. References: <20221214155603.29381-1-maxim.cournoyer@gmail.com> <875yeec57z.fsf@nckx> <87zgbp3ksd.fsf@gmail.com> Date: Fri, 03 Feb 2023 23:36:59 -0500 In-Reply-To: <87zgbp3ksd.fsf@gmail.com> (Maxim Cournoyer's message of "Wed, 14 Dec 2022 13:25:06 -0500") Message-ID: <87mt5unj10.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=2607:f8b0:4864:20::f2d; envelope-from=maxim.cournoyer@gmail.com; helo=mail-qv1-xf2d.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit Cc: =?utf-8?Q?Ludovic_Court?= =?utf-8?Q?=C3=A8s?= , 60068@debbugs.gnu.org, guix-patches@gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) Hi Tobias and Ludovic, Had you seen my reply below? It seems you had perhaps misunderstood the use case at hand? Maxim Cournoyer writes: > Hi Tobias, > > Tobias Geerinckx-Rice writes: > >> Hi Maxim, >> >> Nice! More steps towards world domination. > > Eh :-) > >> Maxim Cournoyer =E5=86=99=E9=81=93=EF=BC=9A >>> +# Environment variables >> >> These sound like they should be command-line arguments. > > I agree, but that'd require a loop, or GNU getopt, and I'm not motivated > enough in the moment to re-design it :-). When we get there, we could > add an --uninstall option too. > >> [=E2=80=A6] >> >> Actually, I'm not totally sold on GUIX_ALLOW_OVERWRITE. It's not >> solving much a problem. > > The problem it solves for me was that I needed to use 'guix pack'd > dependencies such as gpg, glibc for getent, and shadow's > groupadd/useradd, etc. to satisfy the install script dependencies on my > weird target OS (minimal busybox embedded OS); which are needed to be > unpacked under /gnu, thus conflicting with the requirement that /gnu > doesn't exist. > > I tried a relocatable pack, but it didn't work, at least for gpg (file > not found error). --=20 Thanks, Maxim From debbugs-submit-bounces@debbugs.gnu.org Thu Feb 16 23:25:02 2023 Received: (at control) by debbugs.gnu.org; 17 Feb 2023 04:25:02 +0000 Received: from localhost ([127.0.0.1]:38180 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pSsIv-0003EQ-VB for submit@debbugs.gnu.org; Thu, 16 Feb 2023 23:25:02 -0500 Received: from mail-qt1-f181.google.com ([209.85.160.181]:34432) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pSsIu-0003E1-7f for control@debbugs.gnu.org; Thu, 16 Feb 2023 23:25:00 -0500 Received: by mail-qt1-f181.google.com with SMTP id f10so4379468qtv.1 for ; Thu, 16 Feb 2023 20:25:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=subject:from:to:message-id:date:from:to:cc:subject:date:message-id :reply-to; bh=zwPyPLlMtVpXy9jFw0/z9cH1G3BL/d8H/aZHXiaotVQ=; b=AoUQSrVSSDdYsOS0dmxBhgj3+RA6OD6+QCGiqahlclfPiNsBelIPkEvkxTdFqeX9hy rEpg7evs1J6MnGq4nHI5nKa23186fSbNBPGsG9UOSxTGznaMYuznxstihFpJh0ApiLOE CSsj3LjVGOo1BkffmE43LDqft5Rd4ev60cqlEjJnXoWM50TEM4ZcEtoWEiLScdEuGLFk WkN3U1RY366bVGPRkQUIbXSvvzqAFdnPru4AhkgvrZ9EMaaNJTVjquUZV88Yjh6rgSHd ceP1/nEbirW6I+yMY6MCMLxjwbZmTvoIv2s5K2/eXP0lXhKr6i6n1ga9eCIOEEENBfkP E/7w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=subject:from:to:message-id:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=zwPyPLlMtVpXy9jFw0/z9cH1G3BL/d8H/aZHXiaotVQ=; b=HeZR15E0k6HLLlU4mZ1CyAydpgTAuHTWhd8GWPpzPWaWCu4MuIZ3LH7Jicun0AKCKi 0WGfj6dNniz3auPStZOFwtX+ul3RgB8h7qeazWnc/EKoe7I7d5fJ3RilgI6j2VWc3USg VtWx4V7R9JJoeI9t0MedY5NfVmitKjdvy4kf1SxkzwaRXzjbVbvyct0hyziNeuqjecjn 1g/Fcnee42Sa/REl1Q+msaQOhYL1aXW/1/PjFkTUNU7Ne9tPFn90zqsrsFyU/JLD4C0z PEJEbn9UzjajHxwfA9apyoJsnL0uVz5LBJNAzmzeUE2WDI1iJD3bli9R/2S4YXtVkiIQ QRSA== X-Gm-Message-State: AO0yUKUK+kE/IETiEQHiYy8K2/yw3QP4jX0W45cJnHx1FkHHNwSZQZOC CewenvSgmfKvPWxfcX+DS/NDHccIvBZKUA== X-Google-Smtp-Source: AK7set9cwhaHf5KB+j3fJGRT6sHVEzJqErOA2pJfp3ZIw7H9QsotG/yn/pgSDql5eOgnwWmlInoHgA== X-Received: by 2002:a05:622a:14d4:b0:3b8:2e48:921a with SMTP id u20-20020a05622a14d400b003b82e48921amr13199716qtx.57.1676607894161; Thu, 16 Feb 2023 20:24:54 -0800 (PST) Received: from hurd (dsl-152-188.b2b2c.ca. [66.158.152.188]) by smtp.gmail.com with ESMTPSA id b64-20020a37b243000000b0072ad54e36b2sm2509340qkf.93.2023.02.16.20.24.53 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 Feb 2023 20:24:53 -0800 (PST) Date: Fri, 17 Feb 2023 05:24:52 +0100 Message-Id: <874jrkudez.fsf@gmail.com> To: control@debbugs.gnu.org From: Maxim Cournoyer Subject: control message for bug #60069 X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) close 60069 quit From unknown Sun Jun 15 08:10:51 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Fri, 17 Mar 2023 11:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator