GNU bug report logs - #60060
29.0.50; tramp-tests leave temporary files behind

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 60060 in the body.
You can then email your comments to 60060 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefankangas <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 29.0.50; tramp-tests leave temporary files behind
Date: Tue, 13 Dec 2022 23:37:40 -0800

Severity: wishlist

Running "make -C test tramp-tests" leaves files like these behind in the
/tmp directory when it's done:

  -rw------- 1 skangas skangas    0 2022-12-14 08:12 tramp.96wMX0
  -rw------- 1 skangas skangas    0 2022-12-14 08:12 tramp.Z0kdHt
  -rw------- 1 skangas skangas    0 2022-12-14 08:12 tramp.fzW51I
  -rw------- 1 skangas skangas    0 2022-12-14 08:12 tramp.gGLsr2
  -rw------- 1 skangas skangas    0 2022-12-14 08:12 tramp.pMvk3u
  -rw------- 1 skangas skangas    0 2022-12-14 08:12 tramp.pri8yI
  -rw------- 1 skangas skangas    0 2022-12-14 08:12 tramp.riZhlf

Could that be avoided?

Message #8 received at 60060 <at> debbugs.gnu.org (full text, mbox):

From: Michael Albinus <michael.albinus <at> gmx.de>
To: Stefan Kangas <stefankangas <at> gmail.com>
Cc: 60060 <at> debbugs.gnu.org
Subject: Re: bug#60060: 29.0.50; tramp-tests leave temporary files behind
Date: Thu, 15 Dec 2022 16:44:09 +0100

Stefan Kangas <stefankangas <at> gmail.com> writes:

Hi Stefan,

> Running "make -C test tramp-tests" leaves files like these behind in the
> /tmp directory when it's done:
>
>   -rw------- 1 skangas skangas    0 2022-12-14 08:12 tramp.96wMX0
>   -rw------- 1 skangas skangas    0 2022-12-14 08:12 tramp.Z0kdHt
>   -rw------- 1 skangas skangas    0 2022-12-14 08:12 tramp.fzW51I
>   -rw------- 1 skangas skangas    0 2022-12-14 08:12 tramp.gGLsr2
>   -rw------- 1 skangas skangas    0 2022-12-14 08:12 tramp.pMvk3u
>   -rw------- 1 skangas skangas    0 2022-12-14 08:12 tramp.pri8yI
>   -rw------- 1 skangas skangas    0 2022-12-14 08:12 tramp.riZhlf
>
> Could that be avoided?

I've pushed a fix to the emacs-29 branch which should cleanup failing
file-local-copy calls. In my environment, /tmp is clean now after
running tramp-tests.el.

Could you pls recheck?

Best regards, Michael.

Message #13 received at 60060-done <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefankangas <at> gmail.com>
To: Michael Albinus <michael.albinus <at> gmx.de>
Cc: 60060-done <at> debbugs.gnu.org
Subject: Re: bug#60060: 29.0.50; tramp-tests leave temporary files behind
Date: Thu, 15 Dec 2022 18:08:33 -0800

Michael Albinus <michael.albinus <at> gmx.de> writes:

> I've pushed a fix to the emacs-29 branch which should cleanup failing
> file-local-copy calls. In my environment, /tmp is clean now after
> running tramp-tests.el.
>
> Could you pls recheck?

I've tested using "make -C test tramp-tests".  After bootstrap,
everything is fine, so I'm closing this bug.  Thanks.

BTW, I saw this failure before bootstrap but I'm not sure if it's worth
fixing:

Test tramp-test47-delay-load backtrace:
  signal(ert-test-failed (((should (string-match-p (tramp-compat-rx "T
  ert-fail(((should (string-match-p (tramp-compat-rx "Tramp loaded: ni
  (if (unwind-protect (setq value-7735 (apply fn-7733 args-7734)) (set
  (let (form-description-7737) (if (unwind-protect (setq value-7735 (a
  (let ((value-7735 'ert-form-evaluation-aborted-7736)) (let (form-des
  (let* ((fn-7733 #'string-match-p) (args-7734 (condition-case err (le
  (let ((tm (car tail))) (let* ((fn-7733 #'string-match-p) (args-7734
  (while tail (let ((tm (car tail))) (let* ((fn-7733 #'string-match-p)
  (let ((tail '(t nil))) (while tail (let ((tm (car tail))) (let* ((fn
  (let ((default-directory (expand-file-name temporary-file-directory)
  (closure (tramp-inline-compress-start-size tramp-fuse-unmount-on-cle
  ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test
  ert-run-test(#s(ert-test :name tramp-test47-delay-load :documentatio
  ert-run-or-rerun-test(#s(ert--stats :selector ... :tests ... :test-m
  ert-run-tests((not (tag :unstable)) #f(compiled-function (event-type
  ert-run-tests-batch((not (tag :unstable)))
  ert-run-tests-batch-and-exit((not (tag :unstable)))
  command-line-1(("-L" ":." "-l" "ert" "-l" "lisp/net/tramp-tests.el"
  command-line()
  normal-top-level()
Test tramp-test47-delay-load condition:
    (ert-test-failed
     ((should
       (string-match-p
	(tramp-compat-rx "Tramp loaded: nil" ... "Tramp loaded: nil" ...
"Tramp loaded: " ... ...)
	(shell-command-to-string ...)))
      :form
      (string-match-p "Tramp loaded: nil[\n\15]+Tramp loaded:
nil[\n\15]+Tramp loaded: t[\n\15]+" "Tramp loaded: nil\nTramp loaded:
nil\nSource file ‘/home/skangas/wip/emacs/lisp/emacs-lisp/subr-x.el’
newer than byte-compiled file; using older file\nSource file
‘/home/skangas/wip/emacs/lisp/emacs-lisp/cl-macs.el’ newer than
byte-compiled file; using older file\nSource file
‘/home/skangas/wip/emacs/lisp/comint.el’ newer than byte-compiled
file; using older file\nSource file
‘/home/skangas/wip/emacs/lisp/cus-edit.el’ newer than byte-compiled
file; using older file\nTramp loaded: t\n")
      :value nil))
   FAILED  85/88  tramp-test47-delay-load (0.207643 sec) at
lisp/net/tramp-tests.el:7534

Message #16 received at 60060-done <at> debbugs.gnu.org (full text, mbox):

From: Michael Albinus <michael.albinus <at> gmx.de>
To: Stefan Kangas <stefankangas <at> gmail.com>
Cc: 60060-done <at> debbugs.gnu.org
Subject: Re: bug#60060: 29.0.50; tramp-tests leave temporary files behind
Date: Fri, 16 Dec 2022 09:42:31 +0100

Stefan Kangas <stefankangas <at> gmail.com> writes:

Hi Stefan,

>> I've pushed a fix to the emacs-29 branch which should cleanup failing
>> file-local-copy calls. In my environment, /tmp is clean now after
>> running tramp-tests.el.
>>
>> Could you pls recheck?
>
> I've tested using "make -C test tramp-tests".  After bootstrap,
> everything is fine, so I'm closing this bug.  Thanks.

Thanks for the confirmation.

> BTW, I saw this failure before bootstrap but I'm not sure if it's worth
> fixing:
>
> Test tramp-test47-delay-load condition:
>     (ert-test-failed
>      ((should
>        (string-match-p
> 	(tramp-compat-rx "Tramp loaded: nil" ... "Tramp loaded: nil" ...
> "Tramp loaded: " ... ...)
> 	(shell-command-to-string ...)))
>       :form
>       (string-match-p "Tramp loaded: nil[\n\15]+Tramp loaded:
> nil[\n\15]+Tramp loaded: t[\n\15]+" "Tramp loaded: nil\nTramp loaded:
> nil\nSource file ‘/home/skangas/wip/emacs/lisp/emacs-lisp/subr-x.el’
> newer than byte-compiled file; using older file\nSource file
> ‘/home/skangas/wip/emacs/lisp/emacs-lisp/cl-macs.el’ newer than
> byte-compiled file; using older file\nSource file
> ‘/home/skangas/wip/emacs/lisp/comint.el’ newer than byte-compiled
> file; using older file\nSource file
> ‘/home/skangas/wip/emacs/lisp/cus-edit.el’ newer than byte-compiled
> file; using older file\nTramp loaded: t\n")
>       :value nil))
>    FAILED  85/88  tramp-test47-delay-load (0.207643 sec) at
> lisp/net/tramp-tests.el:7534

No, it isn't an error. tramp-test47-delay-load checks messages in the
*Messages* buffer. Since your Emacs wan't compiled, there were also
messages like

--8<---------------cut here---------------start------------->8---
Source file ‘/home/skangas/wip/emacs/lisp/comint.el’ newer than byte-compiled file; using older file
--8<---------------cut here---------------end--------------->8---

which confuse this check.

Best regards, Michael.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.