GNU bug report logs - #60055
[PATCH] scripts: system: Skip initrd modules check when using --target.

Previous Next

Package: guix-patches;

Reported by: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>

Date: Wed, 14 Dec 2022 01:54:02 UTC

Severity: normal

Tags: patch

Done: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>

Bug is archived. No further changes may be made.

Full log

View this message in rfc822 format

From: Ludovic Courtès <ludo <at> gnu.org>
To: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
Cc: 60055 <at> debbugs.gnu.org
Subject: [bug#60055] [PATCH] scripts: system: Skip initrd modules check when using --target.
Date: Wed, 21 Dec 2022 14:34:48 +0100

Hi,

Maxim Cournoyer <maxim.cournoyer <at> gmail.com> skribis:

> * guix/scripts/system.scm (perform-action): Do not call CHECK-INITRD-MODULES
> when the %current-target-system parameter is set.

[...]

> +      (unless (%current-target-system)
> +        ;; Skip the check if the user is making use of --target, as it doesn't
> +        ;; make sense in this context.
> +        (check-initrd-modules os))))

s/doesn’t make sense.*/cannot be checked against the running kernel./

Otherwise LGTM, thanks!

Ludo’.
This bug report was last modified 2 years and 147 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.