GNU bug report logs - #60055
[PATCH] scripts: system: Skip initrd modules check when using --target.

Previous Next

Full log

Message #13 received at 60055-done <at> debbugs.gnu.org (full text, mbox):

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 60055-done <at> debbugs.gnu.org
Subject: Re: bug#60055: [PATCH] scripts: system: Skip initrd modules check
 when using --target.
Date: Wed, 21 Dec 2022 14:24:19 -0500

Hello,

Ludovic Courtès <ludo <at> gnu.org> writes:

> Hi,
>
> Maxim Cournoyer <maxim.cournoyer <at> gmail.com> skribis:
>
>> * guix/scripts/system.scm (perform-action): Do not call CHECK-INITRD-MODULES
>> when the %current-target-system parameter is set.
>
> [...]
>
>> +      (unless (%current-target-system)
>> +        ;; Skip the check if the user is making use of --target, as it doesn't
>> +        ;; make sense in this context.
>> +        (check-initrd-modules os))))
>
> s/doesn’t make sense.*/cannot be checked against the running kernel./
>
> Otherwise LGTM, thanks!

Thanks for precising the comment.  Applied with the suggestion!

-- 
Thanks,
Maxim

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.