From debbugs-submit-bounces@debbugs.gnu.org Tue Dec 13 20:53:13 2022 Received: (at submit) by debbugs.gnu.org; 14 Dec 2022 01:53:13 +0000 Received: from localhost ([127.0.0.1]:35868 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p5GxN-0008V8-4s for submit@debbugs.gnu.org; Tue, 13 Dec 2022 20:53:13 -0500 Received: from lists.gnu.org ([209.51.188.17]:37164) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p5GxL-0008V2-PR for submit@debbugs.gnu.org; Tue, 13 Dec 2022 20:53:12 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p5GxL-0001c3-H4 for guix-patches@gnu.org; Tue, 13 Dec 2022 20:53:11 -0500 Received: from mail-qt1-x835.google.com ([2607:f8b0:4864:20::835]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1p5GxJ-0000w7-Sw for guix-patches@gnu.org; Tue, 13 Dec 2022 20:53:11 -0500 Received: by mail-qt1-x835.google.com with SMTP id c7so1446280qtw.8 for ; Tue, 13 Dec 2022 17:53:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=dJch6qNnQaj+pUEZB0gyIza8S0QxPB5GtjuDGuUa2q4=; b=WGpgIDtW1Mg4HWWbOTJ2d1qj0qY4Y/h1DWXTyDTNqcpkde6208yfZDC/LWVZIpF+pp mrdeyVZSyNX/dMoSzJT/GrECOyegQPITulvd1ZWPMinN3uoDTUK7A5zNhLRH+iSZGHLW YRMq5EWmjmJ68pkytMXaI/pddLCvYz1NCw4GNGIV9QM8o5g34Of52GhOF7hAiqW6emqm LQqX6ri02QwlQoeGj38wx3WNTQ4zZzNnY80yOZxDMqRoAkHwf5Z1dgUH7dv2rdariJbg DBBuIMxIukkYloQePcXNF+IjgYMEuWw4xYg4y15513YJNpMC0W2qUxcyzy6UGC0ZDhGe gsqw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=dJch6qNnQaj+pUEZB0gyIza8S0QxPB5GtjuDGuUa2q4=; b=maCxc3I4URhWt8D4DHrjMAfRKu70TriFNqyMNoSpDgiqYdurt30ya9iT4AJYzXTqEf CiUG//3mSAj3fAgAbC+zwbX4a/haMcTrLCSW2uDK/ssEjbn1CkD6xhe1b19aoPQoZEGl vAAzkz0N35RviHP/0rIB31YbEZ3CdgURw4je1/m1BQpaJ8sDkIfTPOqxtBAe9YsL+Ebf xRoajkqbBkiz28RwH5bOFwycdFrqQ8iugR4+n+fVYH7NbUOVenps1YIQWNkIGXBhUZOy QC1J8IoRwdBkA7u+cl2iTq6x/itWbBy3vwj98+sZMhqSupXLMs5c4F/4MS9L9AZIVmJi fMwQ== X-Gm-Message-State: ANoB5plntUoQ7eAzHqOH4tAlGcuCKoiEIqeMrbnkffk/J2ZYhHRBx74I ZCMXO2yjdBQxH78QOO6YE+AbxaxmcmSQGQ== X-Google-Smtp-Source: AA0mqf66r8+k1QXFPdGLXsHdMptuuZKsOKixcWdSJO+yD9SfFiTaHltAiYrL49ifqvlog0Kjuv99/A== X-Received: by 2002:ac8:51cf:0:b0:3a5:7a7c:25ba with SMTP id d15-20020ac851cf000000b003a57a7c25bamr8068791qtn.38.1670982788454; Tue, 13 Dec 2022 17:53:08 -0800 (PST) Received: from localhost.localdomain ([2607:fad8:4:3::1006]) by smtp.gmail.com with ESMTPSA id p20-20020ac84614000000b003a611cb2a95sm909096qtn.9.2022.12.13.17.53.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 13 Dec 2022 17:53:07 -0800 (PST) From: Maxim Cournoyer To: guix-patches@gnu.org Subject: [PATCH] scripts: system: Skip initrd modules check when using --target. Date: Tue, 13 Dec 2022 20:53:03 -0500 Message-Id: <20221214015303.18991-1-maxim.cournoyer@gmail.com> X-Mailer: git-send-email 2.38.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2607:f8b0:4864:20::835; envelope-from=maxim.cournoyer@gmail.com; helo=mail-qt1-x835.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit Cc: Maxim Cournoyer X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) * guix/scripts/system.scm (perform-action): Do not call CHECK-INITRD-MODULES when the %current-target-system parameter is set. --- guix/scripts/system.scm | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/guix/scripts/system.scm b/guix/scripts/system.scm index 6482318168..54a79501ec 100644 --- a/guix/scripts/system.scm +++ b/guix/scripts/system.scm @@ -842,7 +842,10 @@ (define bootcfg (check-mapped-devices os) (when (zero? (getuid)) (check-file-system-availability (operating-system-file-systems os)) - (check-initrd-modules os))) + (unless (%current-target-system) + ;; Skip the check if the user is making use of --target, as it doesn't + ;; make sense in this context. + (check-initrd-modules os)))) (mlet* %store-monad ((sys (system-derivation-for-action image action base-commit: 0ffa501f2b3e83ae56e9c2bd31418439090e869a prerequisite-patch-id: 660177fb9eee55d11983ea9360c072730d0d21a5 prerequisite-patch-id: 776778c03bce9b7ad3ab94a120f42b764c00fcae prerequisite-patch-id: 4910d08bdc27384d76030b6ac491ad2c2ed0957f prerequisite-patch-id: fd4074fb4cf068ccac3122c19138f098a610542a prerequisite-patch-id: b9b6f21a2db3f7a5ef82bb11ed23f69749cc6b3d prerequisite-patch-id: 51cecbabc04c69d4338addaece536c42a075660f prerequisite-patch-id: 2c67bfd85b343a65440e6c63451e5417129dea6f prerequisite-patch-id: b24087b240dad97b6417e37176915c24a543e887 prerequisite-patch-id: 2b8e69760af1f7bfb66c1edb44471653b6b229d1 prerequisite-patch-id: 2cb8792eedc8cfc23b4728f9ec44366aa394b954 prerequisite-patch-id: 8684fb6949ced334698dbf32ae71dd76c5eb2cfe -- 2.38.1 From debbugs-submit-bounces@debbugs.gnu.org Wed Dec 21 08:34:59 2022 Received: (at 60055) by debbugs.gnu.org; 21 Dec 2022 13:34:59 +0000 Received: from localhost ([127.0.0.1]:51931 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p7zFL-0003nX-05 for submit@debbugs.gnu.org; Wed, 21 Dec 2022 08:34:59 -0500 Received: from eggs.gnu.org ([209.51.188.92]:59320) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p7zFJ-0003nP-E5 for 60055@debbugs.gnu.org; Wed, 21 Dec 2022 08:34:57 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p7zFD-0000xV-Dy; Wed, 21 Dec 2022 08:34:52 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=EZyJUvDaioA+fld5Xi6eDcsqi+JeVqYg+6WYG1WB1Ng=; b=b3gBJeQsIMznOgqG6+44 uB+v3DO577P+MM7vqQaIgPYGUOI+PFiszEn+XN50CKZiuuXRjsUVlpah3uNfnGemSMkwhoiN07daY +iG+EU6PGB1lBDf5RXjT0kBSOizJVDgGLjUCmqXcBI680j6MDBYRi/JNpEsWJ+95fAGWts4SPbcF6 r8SPbBAmDYrhW4coyyn1DnZUasj6fM82leuu+aXYFhYEzNc9AQF5sp1nFoP7CN+ImJZG+7G929H5h YObpMdmVehImqv91QFxARKS/+MF2Xl/a1aDPhEfspMjlQBgtcLbnsUcQ/7LUf+8O4y8nSFhJ85b8F MFMSJsTo+nMj7Q==; Received: from 91-160-117-201.subs.proxad.net ([91.160.117.201] helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p7zFC-0007sP-Un; Wed, 21 Dec 2022 08:34:51 -0500 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Maxim Cournoyer Subject: Re: bug#60055: [PATCH] scripts: system: Skip initrd modules check when using --target. References: <20221214015303.18991-1-maxim.cournoyer@gmail.com> Date: Wed, 21 Dec 2022 14:34:48 +0100 In-Reply-To: <20221214015303.18991-1-maxim.cournoyer@gmail.com> (Maxim Cournoyer's message of "Tue, 13 Dec 2022 20:53:03 -0500") Message-ID: <87wn6k518n.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 60055 Cc: 60055@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hi, Maxim Cournoyer skribis: > * guix/scripts/system.scm (perform-action): Do not call CHECK-INITRD-MODU= LES > when the %current-target-system parameter is set. [...] > + (unless (%current-target-system) > + ;; Skip the check if the user is making use of --target, as it d= oesn't > + ;; make sense in this context. > + (check-initrd-modules os)))) s/doesn=E2=80=99t make sense.*/cannot be checked against the running kernel= ./ Otherwise LGTM, thanks! Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Wed Dec 21 14:24:29 2022 Received: (at 60055-done) by debbugs.gnu.org; 21 Dec 2022 19:24:29 +0000 Received: from localhost ([127.0.0.1]:53521 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p84hZ-0001S8-8n for submit@debbugs.gnu.org; Wed, 21 Dec 2022 14:24:29 -0500 Received: from mail-qt1-f172.google.com ([209.85.160.172]:39463) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p84hX-0001S1-4x for 60055-done@debbugs.gnu.org; Wed, 21 Dec 2022 14:24:27 -0500 Received: by mail-qt1-f172.google.com with SMTP id s9so14472017qtx.6 for <60055-done@debbugs.gnu.org>; Wed, 21 Dec 2022 11:24:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to; bh=qhCiKaDnC4MyVEKTslORmzE2V0EqmHFaFc/qwFcx4DY=; b=dOwoDrje2Hk7WioCqzItEj6pSXFi6Rzm9R7UDdBBGWl7fUYdhjpiVE0hnKHevz4rLp C4+AoBbr+IloR068SW9TeCftOKjIMRk4Hci1r4pvs/IIEeQ4OyrujWG3lAdpgyb7ygw1 8FXD4wISevZ0VjKr9sDf/zywE0sM06j797RdFJGG0GU9eYL3OQ7+HDtwND7Lt9x3AsrP MZkUd4W0MlAWsaVhiXZm1uF/gqhF/NL81Qnlh4jz4D7atPLv760j0PH5mE2oPndMl0W1 mFJ3B39TFQttIFnT/qQT9m8HnIIm9NR3KU/8mXJ/+aNd++hr+cZ4fkKySBl1Qho4ROYs TJew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=qhCiKaDnC4MyVEKTslORmzE2V0EqmHFaFc/qwFcx4DY=; b=HV+TQwxsXld0IRjBmT5toXu41n/ANu+h4/uj/Rk66yrn7fU29zQ5tPck7AzZsqNBdV 5PLe+1k5KviVX0I5DzwWvlgnSOJ4fTE53GRP8hI8tbcAa4imJCUxlAiJBfkCnEV/Vve5 6NCFuDlvQTcrrSL0V6Tvy4JAojIHuUCMOVKMBeieeV9bv3gP+0VX9EzoABjHwvluHr5z aIVlWMDUrz2CDPxfqIwMsIGclvKSIwdE29yoghKbQCJpMLinPmlCamkpEkn2hqoFrBbL Qp08gePbO6TqEoubnBm3JNhtT1Z9eHafud2yG+9lR79YfrVfIoo1uEHPIrxtvcGs+GYV KaHg== X-Gm-Message-State: AFqh2krvMXiSAd1Gf4b3GOu4pyTScCtIcyKC1/e087OjEwAnOy4TTIFe Eb+BpdgaYvXsJUcqeHni5hEu+SxwN0iJIg== X-Google-Smtp-Source: AMrXdXs7GM+sQvX2XWfrROt7fDvI5cf/xxEJn/0AKZj3E76/D7UgsZ1+Jc9eq+ZJzO0WzMtbLO9t5A== X-Received: by 2002:ac8:70d0:0:b0:3a5:1ea1:bae2 with SMTP id g16-20020ac870d0000000b003a51ea1bae2mr3185749qtp.34.1671650661039; Wed, 21 Dec 2022 11:24:21 -0800 (PST) Received: from hurd ([2607:fad8:4:3::1002]) by smtp.gmail.com with ESMTPSA id v18-20020a05620a0f1200b006cf38fd659asm11675464qkl.103.2022.12.21.11.24.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 21 Dec 2022 11:24:20 -0800 (PST) From: Maxim Cournoyer To: Ludovic =?utf-8?Q?Court=C3=A8s?= Subject: Re: bug#60055: [PATCH] scripts: system: Skip initrd modules check when using --target. References: <20221214015303.18991-1-maxim.cournoyer@gmail.com> <87wn6k518n.fsf@gnu.org> Date: Wed, 21 Dec 2022 14:24:19 -0500 In-Reply-To: <87wn6k518n.fsf@gnu.org> ("Ludovic =?utf-8?Q?Court=C3=A8s=22'?= =?utf-8?Q?s?= message of "Wed, 21 Dec 2022 14:34:48 +0100") Message-ID: <87zgbg36ho.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 60055-done Cc: 60055-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hello, Ludovic Court=C3=A8s writes: > Hi, > > Maxim Cournoyer skribis: > >> * guix/scripts/system.scm (perform-action): Do not call CHECK-INITRD-MOD= ULES >> when the %current-target-system parameter is set. > > [...] > >> + (unless (%current-target-system) >> + ;; Skip the check if the user is making use of --target, as it = doesn't >> + ;; make sense in this context. >> + (check-initrd-modules os)))) > > s/doesn=E2=80=99t make sense.*/cannot be checked against the running kern= el./ > > Otherwise LGTM, thanks! Thanks for precising the comment. Applied with the suggestion! --=20 Thanks, Maxim From unknown Sat Jun 14 03:50:16 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Thu, 19 Jan 2023 12:24:07 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator