GNU bug report logs - #60025
[PATCH] Add go-ts-mode and go-mod-ts-mode

Previous Next

Full log

View this message in rfc822 format

From: Yuan Fu <casouri <at> gmail.com>
To: Randy Taylor <dev <at> rjt.dev>
Cc: Eli Zaretskii <eliz <at> gnu.org>, theo <at> thornhill.no, 60025 <at> debbugs.gnu.org
Subject: bug#60025: [PATCH] Add go-ts-mode and go-mod-ts-mode
Date: Tue, 13 Dec 2022 18:22:11 -0800

Randy Taylor <dev <at> rjt.dev> writes:

> On Tuesday, December 13th, 2022 at 07:25, Eli Zaretskii <eliz <at> gnu.org> wrote: 
>> 
>> > Cc: casouri <at> gmail.com, theo <at> thornhill.no
>> 
>> > Date: Tue, 13 Dec 2022 02:13:47 +0000
>> > From: Randy Taylor dev <at> rjt.dev
>> > 
>> > --- a/etc/NEWS
>> > +++ b/etc/NEWS
>> > @@ -3078,6 +3078,11 @@ A major mode based on the tree-sitter library for editing CMake files.
>> > It includes support for font-locking, indentation, Imenu, and
>> > which-func.
>> > 
>> > +** New major modes 'go-ts-mode' and 'go-mod-ts-mode'.
>> > +Major modes based on the tree-sitter library for editing programs in
>> > +the Go language. It includes support for font-locking, indentation,
>> > +Imenu, and which-func.
>> 
>> 
>> This should say something about go-mod-ts-mode, at least which files
>> it's supposed to support and for what purpose.
>
> Indeed, thanks. I decided to split them up, and I also added that they will be auto-enabled.
>
>> > +(add-to-list 'auto-mode-alist '("go\\.mod\\'" . go-mod-ts-mode))
>> 
>> 
>> Aren't the files's base name always exactly "go.mod" and nothing else?
>> If so, the regexp should be augmented, because we don't want to use
>> this moder for, say, foogo.mod or fubar-go.mod, right?
>
> Oops, that's right. Good catch.

Looks pretty good to me :-)

Yuan

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.