GNU bug report logs - #60022
configure.ac fix for C99 compatibility

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#60022: closed (configure.ac fix for C99 compatibility)
Date: Mon, 16 Jan 2023 22:20:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Mon, 16 Jan 2023 23:19:27 +0100
with message-id <87358aktqo.fsf <at> gnu.org>
and subject line Re: bug#60022: configure.ac fix for C99 compatibility
has caused the debbugs.gnu.org bug report #60022,
regarding configure.ac fix for C99 compatibility
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
60022: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=60022
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Florian Weimer <fweimer <at> redhat.com>
To: bug-guile <at> gnu.org
Subject: configure.ac fix for C99 compatibility
Date: Mon, 12 Dec 2022 22:35:33 +0100

This patch is needed to improve C99 compatibility:

diff --git a/configure.ac b/configure.ac
index b3879df1f..cc865a028 100644
--- a/configure.ac
+++ b/configure.ac
@@ -904,7 +904,7 @@ AC_CACHE_VAL(guile_cv_localtime_cache,
 AC_RUN_IFELSE([AC_LANG_SOURCE([[#include <time.h>
 #include <stdlib.h>
 extern char **environ;
-unset_TZ ()
+int unset_TZ ()
 {
   char **from, **to;
   for (to = from = environ; (*to = *from); from++)
@@ -913,7 +913,7 @@ unset_TZ ()
 }
 char TZ_GMT0[] = "TZ=GMT0";
 char TZ_PST8[] = "TZ=PST8";
-main()
+int main()
 {
   time_t now = time ((time_t *) 0);
   int hour_GMT0, hour_unset;

Future compilers are likely to reject implicit int types by default.

Found via:

  <https://fedoraproject.org/wiki/Changes/PortingToModernC>
  <https://fedoraproject.org/wiki/Toolchain/PortingToModernC>

Thanks,
Florian

[Message part 3 (message/rfc822, inline)]

From: Ludovic Courtès <ludo <at> gnu.org>
To: Florian Weimer <fweimer <at> redhat.com>
Cc: 60022-done <at> debbugs.gnu.org
Subject: Re: bug#60022: configure.ac fix for C99 compatibility
Date: Mon, 16 Jan 2023 23:19:27 +0100

Hi Florian,

Florian Weimer <fweimer <at> redhat.com> skribis:

> This patch is needed to improve C99 compatibility:
>
> diff --git a/configure.ac b/configure.ac
> index b3879df1f..cc865a028 100644
> --- a/configure.ac
> +++ b/configure.ac

Applied, thanks.

Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.