From unknown Wed Jun 18 00:24:19 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#60021 <60021@debbugs.gnu.org> To: bug#60021 <60021@debbugs.gnu.org> Subject: Status: 29.0.60; Eshell completion errors in the presence of buffer redirects Reply-To: bug#60021 <60021@debbugs.gnu.org> Date: Wed, 18 Jun 2025 07:24:19 +0000 retitle 60021 29.0.60; Eshell completion errors in the presence of buffer r= edirects reassign 60021 emacs submitter 60021 Daniel Mendler severity 60021 normal thanks From debbugs-submit-bounces@debbugs.gnu.org Mon Dec 12 16:24:02 2022 Received: (at submit) by debbugs.gnu.org; 12 Dec 2022 21:24:02 +0000 Received: from localhost ([127.0.0.1]:55496 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p4qHJ-0004Gw-U1 for submit@debbugs.gnu.org; Mon, 12 Dec 2022 16:24:02 -0500 Received: from lists.gnu.org ([209.51.188.17]:47478) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p4qHH-0004Gn-IT for submit@debbugs.gnu.org; Mon, 12 Dec 2022 16:24:00 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p4qHG-0001wV-TG for bug-gnu-emacs@gnu.org; Mon, 12 Dec 2022 16:23:59 -0500 Received: from server.qxqx.de ([2a01:4f8:121:346::180] helo=mail.qxqx.de) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p4qHB-00086D-BG for bug-gnu-emacs@gnu.org; Mon, 12 Dec 2022 16:23:56 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=qxqx.de; s=mail1392553390; h=Content-Type:MIME-Version:Message-ID:Date:Subject:To:From :Sender:Reply-To:Cc:Content-Transfer-Encoding:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: In-Reply-To:References:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=fIzmrcmnkFKmhQKFU+052Rccfoz4J6vrTvqen5nR+Qk=; b=FvTd0dLf7s3LHA78lnjKNOzUAY 3a+ckJ0Pu/OQcZOnfy8kX03MhpeZADF4wLaH4lfDpI7RBU/GkV1YZFMd1y7fm8TATvEFEyIVtoq39 4UlbEFE61e0NMX7HFvMpx78Mrf3wYMez4NYRoO/J7IMpiLoBwdrJ86hUcsKmJ8ATZb5A=; From: Daniel Mendler To: bug-gnu-emacs@gnu.org, arstoffel@gmail.com Subject: 29.0.60; Eshell completion errors in the presence of buffer redirects Date: Mon, 12 Dec 2022 22:23:47 +0100 Message-ID: <87pmconwnw.fsf@daniel-mendler.de> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=2a01:4f8:121:346::180; envelope-from=mail@daniel-mendler.de; helo=mail.qxqx.de X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) 1. Start emacs -Q 2. M-x eshell 3. ls > #<*scratch*> TAB The following error is observed: Debugger entered--Lisp error: (wrong-type-argument stringp #) pcomplete-match("\\`--[^=]+=\\(.*\\)" 0) pcomplete-here-using-help("ls --help") pcomplete/ls() pcomplete-completions() pcomplete-completions-at-point() In GNU Emacs 29.0.60 (build 1, x86_64-pc-linux-gnu, X toolkit, cairo version 1.16.0, Xaw scroll bars) of 2022-12-11 built on projects Repository revision: f221105723dc8d3ee9f3c8d1c2717058afbc6666 Repository branch: emacs-29 Windowing system distributor 'The X.Org Foundation', version 11.0.12004000 System Description: Debian GNU/Linux 10 (buster) Configured using: 'configure --prefix=/home/user/emacs/install --with-json --with-native-compilation --with-x-toolkit=athena --without-dbus --without-selinux --without-threads --without-gsettings --with-cairo' Configured features: CAIRO FREETYPE GIF GLIB GMP GNUTLS HARFBUZZ JPEG JSON LIBXML2 MODULES NATIVE_COMP NOTIFY INOTIFY PDUMPER PNG RSVG SECCOMP SOUND SQLITE3 TIFF TOOLKIT_SCROLL_BARS WEBP X11 XDBE XIM XINPUT2 XPM LUCID ZLIB Important settings: value of $LANG: en_US.UTF-8 locale-coding-system: utf-8-unix Major mode: Debugger Minor modes in effect: shell-dirtrack-mode: t tooltip-mode: t global-eldoc-mode: t show-paren-mode: t electric-indent-mode: t mouse-wheel-mode: t tool-bar-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t buffer-read-only: t line-number-mode: t indent-tabs-mode: t transient-mark-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t Load-path shadows: None found. Features: (shadow sort mail-extr emacsbug message mailcap yank-media puny dired dired-loaddefs rfc822 mml mml-sec password-cache epa derived epg rfc6068 epg-config gnus-util text-property-search time-date mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader sendmail rfc2047 rfc2045 ietf-drums mm-util mail-prsvr mail-utils help-fns radix-tree cl-print byte-opt debug backtrace find-func pcmpl-unix em-unix em-term term disp-table shell ehelp em-script em-prompt em-ls em-hist em-pred em-glob em-extpipe em-cmpl em-dirs esh-var pcomplete comint ansi-osc ansi-color ring em-basic em-banner em-alias esh-mode eshell esh-cmd generator esh-ext esh-opt esh-proc esh-io esh-arg esh-module esh-groups esh-util cus-edit pp cus-start cus-load wid-edit cl-loaddefs comp comp-cstr warnings icons subr-x rx cl-seq cl-macs gv cl-extra help-mode bytecomp byte-compile cl-lib files-x rmc iso-transl tooltip cconv eldoc paren electric uniquify ediff-hook vc-hooks lisp-float-type elisp-mode mwheel term/x-win x-win term/common-win x-dnd tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow isearch easymenu timer select scroll-bar mouse jit-lock font-lock syntax font-core term/tty-colors frame minibuffer nadvice seq simple cl-generic indonesian philippine cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite emoji-zwj charscript charprop case-table epa-hook jka-cmpr-hook help abbrev obarray oclosure cl-preloaded button loaddefs theme-loaddefs faces cus-face macroexp files window text-properties overlay sha1 md5 base64 format env code-pages mule custom widget keymap hashtable-print-readable backquote inotify dynamic-setting font-render-setting cairo x-toolkit xinput2 x multi-tty make-network-process native-compile emacs) Memory information: ((conses 16 134689 10796) (symbols 48 11140 0) (strings 32 32175 1832) (string-bytes 1 996479) (vectors 16 21968) (vector-slots 8 436129 17427) (floats 8 49 31) (intervals 56 529 0) (buffers 976 14)) From debbugs-submit-bounces@debbugs.gnu.org Mon Dec 12 17:24:28 2022 Received: (at 60021) by debbugs.gnu.org; 12 Dec 2022 22:24:28 +0000 Received: from localhost ([127.0.0.1]:55791 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p4rDo-0004zR-3t for submit@debbugs.gnu.org; Mon, 12 Dec 2022 17:24:28 -0500 Received: from heytings.org ([95.142.160.155]:55476) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p4rDl-0004zL-Uv for 60021@debbugs.gnu.org; Mon, 12 Dec 2022 17:24:26 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=heytings.org; s=20220101; t=1670883865; bh=POKFWf+bZQSKpPa9wmTPFejKXAEkewc+lMroWzN6qE8=; h=Date:From:To:cc:Subject:In-Reply-To:Message-ID:References:From; b=59gUp4LdP8krn1zFxg1ortoUvbp/n7Ki+u6xL8vhl0Y4XSXVFqhZd0ZPGMbSIZ51B LxDoy03ap/9pCI5aXH84Zg5vQLo4uQmyV6fjxO1Sd7Xjc5jWTehswJOwIhsDOfc394 pDZ3gyV1g1jpOWEEuPEnOsgVTzAeYYSaROXeclwL9NS1U4l7D5Xt+u4yyfYx3Xv9vA fvh+Ok15jSQHtw1HdDz9vRRjR5uKyYEwjO7Of+aAy9P+ZsGzCU+uadFr/56qbmLV5/ i5lKUUYZ6QYbK3QUrGDj6LP98g4FtoDf4QTOqijnhSJ8VjdsEs7pKwt3HfWRtb30Ec s3nBUma4RKnUw== Date: Mon, 12 Dec 2022 22:24:24 +0000 From: Gregory Heytings To: Daniel Mendler Subject: Re: bug#60021: 29.0.60; Eshell completion errors in the presence of buffer redirects In-Reply-To: <87pmconwnw.fsf@daniel-mendler.de> Message-ID: References: <87pmconwnw.fsf@daniel-mendler.de> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="Rf097YNNek" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 60021 Cc: arstoffel@gmail.com, 60021@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --Rf097YNNek Content-Type: text/plain; charset=us-ascii; format=flowed > > 1. Start emacs -Q > 2. M-x eshell > 3. ls > #<*scratch*> TAB > Thanks for your bug report. Can you check that the attached patch fixes that bug, without introducing other obvious regressions? --Rf097YNNek Content-Type: text/x-diff; name=Check-that-arguments-are-strings-in-pcomplete-here-u.patch Content-Transfer-Encoding: base64 Content-ID: Content-Disposition: attachment; filename=Check-that-arguments-are-strings-in-pcomplete-here-u.patch RnJvbSA2MDQxNmQzOWNkYTNlYmYzMzZiZGI3NzQ4N2QzYjdkOGQ0MjlmMWI2 IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQ0KRnJvbTogR3JlZ29yeSBIZXl0 aW5ncyA8Z3JlZ29yeUBoZXl0aW5ncy5vcmc+DQpEYXRlOiBNb24sIDEyIERl YyAyMDIyIDIyOjE2OjE4ICswMDAwDQpTdWJqZWN0OiBbUEFUQ0hdIENoZWNr IHRoYXQgYXJndW1lbnRzIGFyZSBzdHJpbmdzIGluIHBjb21wbGV0ZS1oZXJl LXVzaW5nLWhlbHANCg0KKiBsaXNwL3Bjb21wbGV0ZS5lbCAocGNvbXBsZXRl LWhlcmUtdXNpbmctaGVscCk6IENoZWNrIHRoYXQNCnBjb21wbGV0ZS1hcmdz IGFyZSBzdHJpbmdzIGJlZm9yZSBhcHBseWluZyBzdHJpbmcgb3BlcmF0aW9u cyBvbg0KdGhlbS4gIEZpeGVzIGJ1ZyM1OTk1NiBhbmQgYnVnIzYwMDIxLg0K LS0tDQogbGlzcC9wY29tcGxldGUuZWwgfCAxMiArKysrKysrKystLS0NCiAx IGZpbGUgY2hhbmdlZCwgOSBpbnNlcnRpb25zKCspLCAzIGRlbGV0aW9ucygt KQ0KDQpkaWZmIC0tZ2l0IGEvbGlzcC9wY29tcGxldGUuZWwgYi9saXNwL3Bj b21wbGV0ZS5lbA0KaW5kZXggNGUzYTg4YmJkYTguLmM2M2M0OTBiY2FhIDEw MDY0NA0KLS0tIGEvbGlzcC9wY29tcGxldGUuZWwNCisrKyBiL2xpc3AvcGNv bXBsZXRlLmVsDQpAQCAtMTQ0OSwxMiArMTQ0OSwxOCBAQCBwY29tcGxldGUt aGVyZS11c2luZy1oZWxwDQogVGhlIHN3aXRjaGVzIGFyZSBvYnRhaW5lZCBi eSBjYWxsaW5nIGBwY29tcGxldGUtZnJvbS1oZWxwJyB3aXRoDQogQ09NTUFO RCBhbmQgQVJHUyBhcyBhcmd1bWVudHMuIg0KICAgKHdoaWxlIChjb25kDQot ICAgICAgICAgICgoc3RyaW5nPSAiLS0iIChwY29tcGxldGUtYXJnIDEpKQ0K KyAgICAgICAgICAoKGxldCAoKGFyZyAocGNvbXBsZXRlLWFyZyAxKSkpDQor ICAgICAgICAgICAgIChpZiAoc3RyaW5ncCBhcmcpDQorICAgICAgICAgICAg ICAgICAoc3RyaW5nPSAiLS0iIGFyZykpKQ0KICAgICAgICAgICAgKHdoaWxl IChwY29tcGxldGUtaGVyZSAocGNvbXBsZXRlLWVudHJpZXMpKSkpDQotICAg ICAgICAgICgocGNvbXBsZXRlLW1hdGNoICJcXGAtLVtePV0rPVxcKC4qXFwp IiAwKQ0KKyAgICAgICAgICAoKGxldCAoKGFyZyAocGNvbXBsZXRlLWFyZyAw KSkpDQorICAgICAgICAgICAgIChpZiAoc3RyaW5ncCBhcmcpDQorICAgICAg ICAgICAgICAgICAocGNvbXBsZXRlLW1hdGNoICJcXGAtLVtePV0rPVxcKC4q XFwpIiAwKSkpDQogICAgICAgICAgICAocGNvbXBsZXRlLWhlcmUgKHBjb21w bGV0ZS1lbnRyaWVzKQ0KICAgICAgICAgICAgICAgICAgICAgICAgICAgIChw Y29tcGxldGUtbWF0Y2gtc3RyaW5nIDEgMCkpKQ0KLSAgICAgICAgICAoKHN0 cmluZy1wcmVmaXgtcCAiLSIgKHBjb21wbGV0ZS1hcmcgMCkpDQorICAgICAg ICAgICgobGV0ICgoYXJnIChwY29tcGxldGUtYXJnIDApKSkNCisgICAgICAg ICAgICAgKGlmIChzdHJpbmdwIGFyZykNCisgICAgICAgICAgICAgICAgIChz dHJpbmctcHJlZml4LXAgIi0iIGFyZykpKQ0KICAgICAgICAgICAgKHBjb21w bGV0ZS1oZXJlIChhcHBseSAjJ3Bjb21wbGV0ZS1mcm9tLWhlbHAgY29tbWFu ZCBhcmdzKSkpDQogICAgICAgICAgICh0IChwY29tcGxldGUtaGVyZSogKHBj b21wbGV0ZS1lbnRyaWVzKSkpKSkpDQogDQotLSANCjIuMzUuMQ0KDQo= --Rf097YNNek-- From debbugs-submit-bounces@debbugs.gnu.org Mon Dec 12 17:41:54 2022 Received: (at submit) by debbugs.gnu.org; 12 Dec 2022 22:41:54 +0000 Received: from localhost ([127.0.0.1]:55888 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p4rUf-0005Dl-Ow for submit@debbugs.gnu.org; Mon, 12 Dec 2022 17:41:54 -0500 Received: from lists.gnu.org ([209.51.188.17]:47992) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p4rUd-0005Df-Op for submit@debbugs.gnu.org; Mon, 12 Dec 2022 17:41:52 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p4rUd-0004MH-G7 for bug-gnu-emacs@gnu.org; Mon, 12 Dec 2022 17:41:51 -0500 Received: from mail-ej1-x62f.google.com ([2a00:1450:4864:20::62f]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1p4rUb-00085O-K5 for bug-gnu-emacs@gnu.org; Mon, 12 Dec 2022 17:41:51 -0500 Received: by mail-ej1-x62f.google.com with SMTP id qk9so32104867ejc.3 for ; Mon, 12 Dec 2022 14:41:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=1rMk9EfIZ3jyOl6sgk8vvLwgovUSDcU9VonpbADQiQ4=; b=lMVQndFfwh/wbuYKd1ganZMk5coUJxJyetGUIjS9AfGja5tiHszflqUgihYWWU8+Dj oTC5m3Wx2cE1MuuedtOUOWd1mReVUagr1SlQRb3UmigpjuuRpV4nbVUyo7oqVfD1eBFY XeGEkVtzj/v62iDkldFFiramxpMnKFB65RZ87twHZOIabLaWV2iybBGhIKpAd0EdTUwr 7lJbkLZqNrvDcWidcFfCSFVuiSPJ44z8+6Iu1fDHiRxsm5lBLI76io4HtQP4jzRuBidQ MOBHiPgyhmzATjGx1HQ4FB/CHx14MdVlxwnCd2P95mZLWSXIhDddegBVGiJK43LbIGSP Cyag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=1rMk9EfIZ3jyOl6sgk8vvLwgovUSDcU9VonpbADQiQ4=; b=h6T1u6ZCiACoxpk5SR4QPvbVshQWxMqynHZL9rWLpC0ul75V8aoy1w0YW458k1WcZ0 YGOb/Q9ZAdEZWPrJqjIASxc6NQ34CL0txTAPtPYdA/krQ4+kOlT5pTkzuIvOffS3TU33 vFgUvua50yDxwlunZXMTAGSMLecYkFTfZGwxbPGIme1xXlA4eEfd1QedgKpd3egRfamG J4M7cU3ErbtMTJjFWAvLju2EVyxylbs7XoJHpedKip7c6uEPPR4VQ9rWU2sa0kO4jSE7 y4USz6vohmh6oB3ZHgU1sfNGlqHgUVNk1wjHY1aLi3upqNAsMyv55TACVS4MclkiTnrr 9Bow== X-Gm-Message-State: ANoB5pnmlnsW9YpGuikeSY8k72oTzLwX9A8yzv4CutMbvpA79yc+THWX 5f7680quVYv6CNe6ENPvk6MVtsg3Fl7XAQ== X-Google-Smtp-Source: AA0mqf7xCRMguo/ae/kbOEUIe0R30X9FGse36ha9Az9o3Ve4zZCWS9Q7oEel8jFojMWe8KWM0cMp2A== X-Received: by 2002:a17:906:4911:b0:7c0:f71b:8b3 with SMTP id b17-20020a170906491100b007c0f71b08b3mr14361784ejq.57.1670884907392; Mon, 12 Dec 2022 14:41:47 -0800 (PST) Received: from ars3 ([2a02:8109:8ac0:56d0::911f]) by smtp.gmail.com with ESMTPSA id lb19-20020a170907785300b007c0a90663d5sm3758541ejc.162.2022.12.12.14.41.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 12 Dec 2022 14:41:46 -0800 (PST) From: Augusto Stoffel To: Daniel Mendler Subject: Re: 29.0.60; Eshell completion errors in the presence of buffer redirects In-Reply-To: <87pmconwnw.fsf@daniel-mendler.de> (Daniel Mendler's message of "Mon, 12 Dec 2022 22:23:47 +0100") References: <87pmconwnw.fsf@daniel-mendler.de> Date: Mon, 12 Dec 2022 23:41:45 +0100 Message-ID: <87cz8ont1y.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=2a00:1450:4864:20::62f; envelope-from=arstoffel@gmail.com; helo=mail-ej1-x62f.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit Cc: bug-gnu-emacs@gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) This is essentially the same as bug#59956. Note also that it's not limited to completion rules defined by pcomplete-here-using-help. On Mon, 12 Dec 2022 at 22:23, Daniel Mendler wrote: > 1. Start emacs -Q > 2. M-x eshell > 3. ls > #<*scratch*> TAB > > The following error is observed: > > Debugger entered--Lisp error: (wrong-type-argument stringp #) > pcomplete-match("\\`--[^=]+=\\(.*\\)" 0) > pcomplete-here-using-help("ls --help") > pcomplete/ls() > pcomplete-completions() > pcomplete-completions-at-point() > > In GNU Emacs 29.0.60 (build 1, x86_64-pc-linux-gnu, X toolkit, cairo > version 1.16.0, Xaw scroll bars) of 2022-12-11 built on projects > Repository revision: f221105723dc8d3ee9f3c8d1c2717058afbc6666 > Repository branch: emacs-29 > Windowing system distributor 'The X.Org Foundation', version 11.0.12004000 > System Description: Debian GNU/Linux 10 (buster) > > Configured using: > 'configure --prefix=/home/user/emacs/install --with-json > --with-native-compilation --with-x-toolkit=athena --without-dbus > --without-selinux --without-threads --without-gsettings --with-cairo' > > Configured features: > CAIRO FREETYPE GIF GLIB GMP GNUTLS HARFBUZZ JPEG JSON LIBXML2 MODULES > NATIVE_COMP NOTIFY INOTIFY PDUMPER PNG RSVG SECCOMP SOUND SQLITE3 TIFF > TOOLKIT_SCROLL_BARS WEBP X11 XDBE XIM XINPUT2 XPM LUCID ZLIB > > Important settings: > value of $LANG: en_US.UTF-8 > locale-coding-system: utf-8-unix > > Major mode: Debugger > > Minor modes in effect: > shell-dirtrack-mode: t > tooltip-mode: t > global-eldoc-mode: t > show-paren-mode: t > electric-indent-mode: t > mouse-wheel-mode: t > tool-bar-mode: t > menu-bar-mode: t > file-name-shadow-mode: t > global-font-lock-mode: t > font-lock-mode: t > blink-cursor-mode: t > buffer-read-only: t > line-number-mode: t > indent-tabs-mode: t > transient-mark-mode: t > auto-composition-mode: t > auto-encryption-mode: t > auto-compression-mode: t > > Load-path shadows: > None found. > > Features: > (shadow sort mail-extr emacsbug message mailcap yank-media puny dired > dired-loaddefs rfc822 mml mml-sec password-cache epa derived epg rfc6068 > epg-config gnus-util text-property-search time-date mm-decode mm-bodies > mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader sendmail > rfc2047 rfc2045 ietf-drums mm-util mail-prsvr mail-utils help-fns > radix-tree cl-print byte-opt debug backtrace find-func pcmpl-unix > em-unix em-term term disp-table shell ehelp em-script em-prompt em-ls > em-hist em-pred em-glob em-extpipe em-cmpl em-dirs esh-var pcomplete > comint ansi-osc ansi-color ring em-basic em-banner em-alias esh-mode > eshell esh-cmd generator esh-ext esh-opt esh-proc esh-io esh-arg > esh-module esh-groups esh-util cus-edit pp cus-start cus-load wid-edit > cl-loaddefs comp comp-cstr warnings icons subr-x rx cl-seq cl-macs gv > cl-extra help-mode bytecomp byte-compile cl-lib files-x rmc iso-transl > tooltip cconv eldoc paren electric uniquify ediff-hook vc-hooks > lisp-float-type elisp-mode mwheel term/x-win x-win term/common-win x-dnd > tool-bar dnd fontset image regexp-opt fringe tabulated-list replace > newcomment text-mode lisp-mode prog-mode register page tab-bar menu-bar > rfn-eshadow isearch easymenu timer select scroll-bar mouse jit-lock > font-lock syntax font-core term/tty-colors frame minibuffer nadvice seq > simple cl-generic indonesian philippine cham georgian utf-8-lang > misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms > cp51932 hebrew greek romanian slovak czech european ethiopic indian > cyrillic chinese composite emoji-zwj charscript charprop case-table > epa-hook jka-cmpr-hook help abbrev obarray oclosure cl-preloaded button > loaddefs theme-loaddefs faces cus-face macroexp files window > text-properties overlay sha1 md5 base64 format env code-pages mule > custom widget keymap hashtable-print-readable backquote inotify > dynamic-setting font-render-setting cairo x-toolkit xinput2 x multi-tty > make-network-process native-compile emacs) > > Memory information: > ((conses 16 134689 10796) > (symbols 48 11140 0) > (strings 32 32175 1832) > (string-bytes 1 996479) > (vectors 16 21968) > (vector-slots 8 436129 17427) > (floats 8 49 31) > (intervals 56 529 0) > (buffers 976 14)) From debbugs-submit-bounces@debbugs.gnu.org Mon Dec 12 17:46:03 2022 Received: (at submit) by debbugs.gnu.org; 12 Dec 2022 22:46:03 +0000 Received: from localhost ([127.0.0.1]:55922 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p4rYg-0005IZ-PP for submit@debbugs.gnu.org; Mon, 12 Dec 2022 17:46:03 -0500 Received: from lists.gnu.org ([209.51.188.17]:44330) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p4rYf-0005Hx-0b for submit@debbugs.gnu.org; Mon, 12 Dec 2022 17:46:01 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p4rYd-0000Lx-Pg for bug-gnu-emacs@gnu.org; Mon, 12 Dec 2022 17:46:00 -0500 Received: from server.qxqx.de ([2a01:4f8:121:346::180] helo=mail.qxqx.de) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p4rYb-0000mJ-K2 for bug-gnu-emacs@gnu.org; Mon, 12 Dec 2022 17:45:59 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=qxqx.de; s=mail1392553390; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=hHUV9eUiGq7Vo6PMXQHDRjvtfjr0Tmwlc+ahaMwJwS4=; b=rgdj+Gz2QNll6AYeHOEk6DfbRn pOQC7eyH4gaLyWc6NeqVw2wk+DihyB2PIN4aiKi6XPsGQE4x4XYXMqN3aIwMOHNzp1TeyoZKLVkBi eO/BZf4qMebPHQ0OWvfX+Nbp6hy07dmM2ZucgnSJwgYldlMUv0+xerCJ8kmfyDktLaC0=; Message-ID: <68035e55-b35f-4db8-7bec-3647c3045a2d@daniel-mendler.de> Date: Mon, 12 Dec 2022 23:45:49 +0100 MIME-Version: 1.0 Subject: Re: 29.0.60; Eshell completion errors in the presence of buffer redirects To: Augusto Stoffel References: <87pmconwnw.fsf@daniel-mendler.de> <87cz8ont1y.fsf@gmail.com> Content-Language: en-US From: Daniel Mendler In-Reply-To: <87cz8ont1y.fsf@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=2a01:4f8:121:346::180; envelope-from=mail@daniel-mendler.de; helo=mail.qxqx.de X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-Debbugs-Envelope-To: submit Cc: bug-gnu-emacs@gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) On 12/12/22 23:41, Augusto Stoffel wrote: > This is essentially the same as bug#59956. Note also that it's not > limited to completion rules defined by pcomplete-here-using-help. Yes, but the last time we discussed you said that Pcomplete arguments should only be strings, which seems clearly not to be the case. In #59956 the argument is a list and in #60021 it is a buffer. But I agree that it would have been better to attach this to the older report. Daniel From debbugs-submit-bounces@debbugs.gnu.org Mon Dec 12 17:51:52 2022 Received: (at 60021) by debbugs.gnu.org; 12 Dec 2022 22:51:52 +0000 Received: from localhost ([127.0.0.1]:55960 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p4reK-0005NH-Gi for submit@debbugs.gnu.org; Mon, 12 Dec 2022 17:51:52 -0500 Received: from server.qxqx.de ([178.63.65.180]:58727 helo=mail.qxqx.de) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p4reI-0005N9-B5 for 60021@debbugs.gnu.org; Mon, 12 Dec 2022 17:51:50 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=qxqx.de; s=mail1392553390; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=6tKvoXR2Q1ss4BI35J1F+R9meqsWA0WnbYY81WPzluo=; b=P5KVm2++xSSYpQwNPJ8BRRmnQW t0lJBz3TgRbsNpy5t7eufTjHhOYT9o5mPQLFzKw51o1GA4pOKzDxZt5BUDbKQs7ZfnWT7TL/QdZgQ tWs2MqU+OOUx3G2Nz+rZTPCp1UgVEMAlCdIfvCKe5P2MTCc0psepAYRGfDjr/ODGHXJM=; Message-ID: <17d95c0d-e0c5-b99d-c831-d9b815cbb25d@daniel-mendler.de> Date: Mon, 12 Dec 2022 23:51:41 +0100 MIME-Version: 1.0 Subject: Re: bug#60021: 29.0.60; Eshell completion errors in the presence of buffer redirects Content-Language: en-US To: Gregory Heytings References: <87pmconwnw.fsf@daniel-mendler.de> From: Daniel Mendler In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 60021 Cc: arstoffel@gmail.com, 60021@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) On 12/12/22 23:24, Gregory Heytings wrote: > Thanks for your bug report. Can you check that the attached patch fixes > that bug, without introducing other obvious regressions? Yes, in my quick tests it fixes both issues. But I am not familiar with the code in question. Hard to tell if it introduces other regressions. Maybe Augusto (cc'ed) could also take a look please? Daniel From debbugs-submit-bounces@debbugs.gnu.org Mon Dec 12 18:34:24 2022 Received: (at 60021) by debbugs.gnu.org; 12 Dec 2022 23:34:24 +0000 Received: from localhost ([127.0.0.1]:56220 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p4sJT-0008I9-Sr for submit@debbugs.gnu.org; Mon, 12 Dec 2022 18:34:24 -0500 Received: from heytings.org ([95.142.160.155]:55628) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p4sJR-0008I3-S1 for 60021@debbugs.gnu.org; Mon, 12 Dec 2022 18:34:22 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=heytings.org; s=20220101; t=1670888061; bh=3puf1P/vvFoPmRnI7QE7bJkt5ht2QNkVG3917dfFYVI=; h=Date:From:To:cc:Subject:In-Reply-To:Message-ID:References:From; b=lL5ZiWg5cmG6m1Tn2uyVLsiVp3kYRJjUt07yzbcCHacfHKPxbNqsx46LJR3hj3Arh yKVlYUKHC//VsxKHwmaWO6zewm5ccpjQd6LzctE5JCu2Gj+IgatHqf3exnjsRKex76 EAtNqMr4/RU2meCorVHJ9+sNitlnMtz3T2fbL2i/Dff5ffnOwok8JcnglcXst6CJ4R Alh2SFxeACCx/RkR8L4hbrrvsl9Iv4ErVZf+Wgy68VH5UTZt4aC/ZCv/ATF0SYo5iH kvzqlv6iL8xf6WQOGbn4sEKaE7GQ50HvzKwuNW8AkwWFxk3kvhGNVCvZ+s73HSEkHb VzuokgWknWMtQ== Date: Mon, 12 Dec 2022 23:34:20 +0000 From: Gregory Heytings To: Daniel Mendler Subject: Re: bug#60021: 29.0.60; Eshell completion errors in the presence of buffer redirects In-Reply-To: <17d95c0d-e0c5-b99d-c831-d9b815cbb25d@daniel-mendler.de> Message-ID: References: <87pmconwnw.fsf@daniel-mendler.de> <17d95c0d-e0c5-b99d-c831-d9b815cbb25d@daniel-mendler.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 60021 Cc: arstoffel@gmail.com, 60021@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) >> Thanks for your bug report. Can you check that the attached patch >> fixes that bug, without introducing other obvious regressions? > > Yes, in my quick tests it fixes both issues. But I am not familiar with > the code in question. Hard to tell if it introduces other regressions. > Maybe Augusto (cc'ed) could also take a look please? > He already did, and although it fixes the two reported recipes, it's alas not a proper fix for that bug. From debbugs-submit-bounces@debbugs.gnu.org Tue Dec 13 08:47:03 2022 Received: (at 60021) by debbugs.gnu.org; 13 Dec 2022 13:47:03 +0000 Received: from localhost ([127.0.0.1]:60510 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p55cd-0003wl-0F for submit@debbugs.gnu.org; Tue, 13 Dec 2022 08:47:03 -0500 Received: from server.qxqx.de ([178.63.65.180]:53347 helo=mail.qxqx.de) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p55ca-0003wE-DT for 60021@debbugs.gnu.org; Tue, 13 Dec 2022 08:47:01 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=qxqx.de; s=mail1392553390; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=MXCeyRlVjN53AG4QkA07vdxZu6se/HYG9LoAow81qts=; b=EXFj0YSY+u+EpBy83T1Bx6JAq4 8LBhfNcEFwRTiEYUPMlD2sou4eEf/HDzNPvhcPT7IMYCBN7dRTUnQVII3j3YD6lwyFETR1COaQPNa r2VIGdAmU1qbcRciO3bQQtg1Uyt3/aBSaaKE7A47sEW6jvjt5/hS7Yf673ZmDN1tRNlk=; Message-ID: <12e425eb-1fdc-a014-cf9c-e3ccb026f3b0@daniel-mendler.de> Date: Tue, 13 Dec 2022 14:46:52 +0100 MIME-Version: 1.0 Subject: Re: bug#60021: 29.0.60; Eshell completion errors in the presence of buffer redirects To: Gregory Heytings References: <87pmconwnw.fsf@daniel-mendler.de> <17d95c0d-e0c5-b99d-c831-d9b815cbb25d@daniel-mendler.de> Content-Language: en-US From: Daniel Mendler In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 60021 Cc: arstoffel@gmail.com, 60021@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) On 12/13/22 00:34, Gregory Heytings wrote: > >>> Thanks for your bug report. Can you check that the attached patch >>> fixes that bug, without introducing other obvious regressions? >> >> Yes, in my quick tests it fixes both issues. But I am not familiar with >> the code in question. Hard to tell if it introduces other regressions. >> Maybe Augusto (cc'ed) could also take a look please? >> > > He already did, and although it fixes the two reported recipes, it's alas > not a proper fix for that bug. Why is this not a proper fix? Is there some deep issue here? Is there a chance that this could be fixed in a better way? I have never looked deeply into the inner workings of Pcomplete, but from my experience the Pcomplete Capf unfortunately is one of the buggiest Capfs provided by Emacs. Nevertheless, I am a happy Eshell user. Completion in combination with my Corfu UI works quite well, but I also employ some advices which ignore errors in Pcomplete and prevent the Capf from modifying the buffer. Daniel From debbugs-submit-bounces@debbugs.gnu.org Tue Dec 13 08:50:15 2022 Received: (at 60021) by debbugs.gnu.org; 13 Dec 2022 13:50:15 +0000 Received: from localhost ([127.0.0.1]:60538 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p55fj-00042g-3a for submit@debbugs.gnu.org; Tue, 13 Dec 2022 08:50:15 -0500 Received: from heytings.org ([95.142.160.155]:56444) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p55fh-00042W-8v for 60021@debbugs.gnu.org; Tue, 13 Dec 2022 08:50:13 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=heytings.org; s=20220101; t=1670939411; bh=JJCikNi2GXyD0/rZ7MWCF5ff/HQNT+we8iedR4cs600=; h=Date:From:To:cc:Subject:In-Reply-To:Message-ID:References:From; b=GScB6nUSuG1OegUUbmF6GJEY/ZxWljRWE/J4aEwLKmF1X5UV/FZOYNyJbKAv+biIq US9ZSf3d6JYmaRsst7k9xYFaNouR5hOrIikMm7ykFXBoAEwLx4P/mm8b19foWCdiR8 3Kez8gXLk5ijXPWmP/22tjrXSQ7RG5LpYapr1dw4vpi166X6/S9XGWfp0Q2r+2vrFj sx6CY6mAkG+KoOFjJDL1sZrohdXFUyv3apSBpzbft77hQ/wGvxz0ebnYBk0XRwTj7H 9XY05ErZfZKpz/yLB0IHZv7k0k1wZGsVixzBcrfDxr7kmjB8SxR7w1/6nKIzF7iIwQ ozydebxbKLFpw== Date: Tue, 13 Dec 2022 13:50:11 +0000 From: Gregory Heytings To: Daniel Mendler Subject: Re: bug#60021: 29.0.60; Eshell completion errors in the presence of buffer redirects In-Reply-To: <12e425eb-1fdc-a014-cf9c-e3ccb026f3b0@daniel-mendler.de> Message-ID: References: <87pmconwnw.fsf@daniel-mendler.de> <17d95c0d-e0c5-b99d-c831-d9b815cbb25d@daniel-mendler.de> <12e425eb-1fdc-a014-cf9c-e3ccb026f3b0@daniel-mendler.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 60021 Cc: arstoffel@gmail.com, 60021@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) >> He already did, and although it fixes the two reported recipes, it's >> alas not a proper fix for that bug. > > Why is this not a proper fix? > Try cvs $exec-path SPC TAB. > > Is there some deep issue here? > AFAIU, yes. From debbugs-submit-bounces@debbugs.gnu.org Tue Dec 13 09:16:03 2022 Received: (at 60021) by debbugs.gnu.org; 13 Dec 2022 14:16:03 +0000 Received: from localhost ([127.0.0.1]:60712 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p564h-0004Nz-BS for submit@debbugs.gnu.org; Tue, 13 Dec 2022 09:16:03 -0500 Received: from server.qxqx.de ([178.63.65.180]:45275 helo=mail.qxqx.de) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p564f-0004Na-3i for 60021@debbugs.gnu.org; Tue, 13 Dec 2022 09:16:01 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=qxqx.de; s=mail1392553390; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=etGeU2vtqYxaBg/H00qT+oqnGuPCn6JbXZhqILTWaMU=; b=vUemD7wCAwvFMuZ9wmzImNJGJ5 CiKki5XUNUUEXTi2ewFoxJc+2gQVDnvZ2+LqE68xlpxf9hthwqBf8verHmwO5qpOXwUoPLxOJSZnZ UfrCNuGitGqHdL9kHtVLGSDfVr5IF5JKTaixuCH0p5cx1O1mh2t0XOiX0G3YqyG53WZc=; Message-ID: <9d2a08cf-888a-d939-4df4-d86af3bb6902@daniel-mendler.de> Date: Tue, 13 Dec 2022 15:15:52 +0100 MIME-Version: 1.0 Subject: Re: bug#60021: 29.0.60; Eshell completion errors in the presence of buffer redirects To: Gregory Heytings References: <87pmconwnw.fsf@daniel-mendler.de> <17d95c0d-e0c5-b99d-c831-d9b815cbb25d@daniel-mendler.de> <12e425eb-1fdc-a014-cf9c-e3ccb026f3b0@daniel-mendler.de> Content-Language: en-US From: Daniel Mendler In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 60021 Cc: arstoffel@gmail.com, 60021@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) On 12/13/22 14:50, Gregory Heytings wrote: > >>> He already did, and although it fixes the two reported recipes, it's >>> alas not a proper fix for that bug. >> >> Why is this not a proper fix? >> > > Try cvs $exec-path SPC TAB. I don't see what you mean. $exec-path is also expanded to a list, which then again breaks pcomplete-here-using-help. But this just seems to be the same issue as #59956. Daniel From debbugs-submit-bounces@debbugs.gnu.org Tue Dec 13 09:20:51 2022 Received: (at 60021) by debbugs.gnu.org; 13 Dec 2022 14:20:51 +0000 Received: from localhost ([127.0.0.1]:60735 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p569L-0004QY-19 for submit@debbugs.gnu.org; Tue, 13 Dec 2022 09:20:51 -0500 Received: from heytings.org ([95.142.160.155]:56496) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p569J-0004QS-Bt for 60021@debbugs.gnu.org; Tue, 13 Dec 2022 09:20:50 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=heytings.org; s=20220101; t=1670941248; bh=3pSCLBNSnHhMpdsrQZWWJYgX5A3Ni3n9XqeRTBf7YLE=; h=Date:From:To:cc:Subject:In-Reply-To:Message-ID:References:From; b=AjvEg2d/aUytbBLFdmnnMcHBMJH6rj5Xm7JGMj9TWyzyxXlIYa3C3qclA3iHnXXeB OvLSx5UvC03CjNqcFIHecU8DvHwro3aLGy04MC1sYLYciEkyQYUpqmh7x22IX4B2BU GLhobkbLry1KjMBDNcafzLFviRgV8m7NQmpmiV2oTAbgAuv9rQeccLfnHKr2PmHbPJ CX7h1Fu2414g3EUXjFZJMH1npNGYB+WLzLg8lVImHpsbGxGKrtofm7TI6vnHnD5tCu T86xnsF7wmRFLMX2J1/mGVuSJAvGk0rR+UeCkKXuihkwe5VR2AXr0B5m/aUympOmgO jQU8gWEZ9iYFw== Date: Tue, 13 Dec 2022 14:20:47 +0000 From: Gregory Heytings To: Daniel Mendler Subject: Re: bug#60021: 29.0.60; Eshell completion errors in the presence of buffer redirects In-Reply-To: <9d2a08cf-888a-d939-4df4-d86af3bb6902@daniel-mendler.de> Message-ID: References: <87pmconwnw.fsf@daniel-mendler.de> <17d95c0d-e0c5-b99d-c831-d9b815cbb25d@daniel-mendler.de> <12e425eb-1fdc-a014-cf9c-e3ccb026f3b0@daniel-mendler.de> <9d2a08cf-888a-d939-4df4-d86af3bb6902@daniel-mendler.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 60021 Cc: arstoffel@gmail.com, 60021@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) >> Try cvs $exec-path SPC TAB. > > I don't see what you mean. $exec-path is also expanded to a list, which > then again breaks pcomplete-here-using-help. But this just seems to be > the same issue as #59956. > I mean: try cvs $exec-path SPC TAB with the patch applied. You'll see that the problem is still there. From debbugs-submit-bounces@debbugs.gnu.org Mon Dec 19 17:24:43 2022 Received: (at 60021) by debbugs.gnu.org; 19 Dec 2022 22:24:43 +0000 Received: from localhost ([127.0.0.1]:40701 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p7OYt-0008GG-9z for submit@debbugs.gnu.org; Mon, 19 Dec 2022 17:24:43 -0500 Received: from heytings.org ([95.142.160.155]:37460) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p7OYs-0008GA-2E for 60021@debbugs.gnu.org; Mon, 19 Dec 2022 17:24:42 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=heytings.org; s=20220101; t=1671488681; bh=lTjUdSXu29o4ccT1jrlLsADG+MQynlVyDeLlHuH8jLQ=; h=Date:From:To:cc:Subject:In-Reply-To:Message-ID:References:From; b=wm7thVTHvn78r/uKbczoyXaTrK6Op/W6nJAoItyDI/ilUCUbxMOuOCFZV6EqwUBgq oQ2L6YbGHBD0kVNMX3vgCA99gtt9d0ff4FjJ8pW7Y92+XnJOgJiELKAIT11e9smqRi yoLeAiZTzMj5j+gPeQvo6t/PcWX8bYkIIM0hfTY6xmIyLhH3yE+ER/H2+Vg/1pr+lh NomIHj58/6aTzFbrjCs+oHv61kRE/nFOqGglxNSMEfXonlRtGvOWXy9nYbC8/DBTng GKi0y+30p01iMpFMKUhnReSPDNNy7uT8H1QXvnGVgekAvLCAAdX9iOKC+q8jIHyNrw pQm0VnULpQLIw== Date: Mon, 19 Dec 2022 22:24:40 +0000 From: Gregory Heytings To: Daniel Mendler Subject: Re: bug#60021: 29.0.60; Eshell completion errors in the presence of buffer redirects In-Reply-To: Message-ID: References: <87pmconwnw.fsf@daniel-mendler.de> <17d95c0d-e0c5-b99d-c831-d9b815cbb25d@daniel-mendler.de> <12e425eb-1fdc-a014-cf9c-e3ccb026f3b0@daniel-mendler.de> <9d2a08cf-888a-d939-4df4-d86af3bb6902@daniel-mendler.de> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="cYiCORjVvK" Content-ID: X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 60021 Cc: 60021@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --cYiCORjVvK Content-Type: text/plain; charset=us-ascii; format=flowed Content-ID: Daniel, can you please try the attached patch and tell us if it fixes the issue without introducing regressions? --cYiCORjVvK Content-Type: text/x-diff; name=Handle-non-string-values-in-pcomplete.patch; charset=us-ascii Content-Transfer-Encoding: base64 Content-ID: Content-Disposition: attachment; filename=Handle-non-string-values-in-pcomplete.patch RnJvbSA1YmVlOWQ4YmVjNDJkZGYzOGJiN2U4ZDhmMmExYjM2YWRiOTZhNTA2 IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQ0KRnJvbTogR3JlZ29yeSBIZXl0 aW5ncyA8Z3JlZ29yeUBoZXl0aW5ncy5vcmc+DQpEYXRlOiBNb24sIDE5IERl YyAyMDIyIDIyOjE4OjIyICswMDAwDQpTdWJqZWN0OiBbUEFUQ0hdIEhhbmRs ZSBub24tc3RyaW5nIHZhbHVlcyBpbiBwY29tcGxldGUNCg0KKiBsaXNwL3Bj b21wbGV0ZS5lbCAocGNvbXBsZXRlLWFyZyk6IFdoZW4NCnBjb21wbGV0ZS1w YXJzZS1hcmd1bWVudHMtZnVuY3Rpb24gcmV0dXJucyBhIG5vbi1zdHJpbmcg dmFsdWUsDQpyZXR1cm4gdGhlIHN0cmluZyB0aGUgdXNlciB0eXBlZCBpbiwg YW5kIGF0dGFjaCB0aGUgdmFsdWUgYXMgYQ0KdGV4dCBwcm9wZXJ0eSB0byB0 aGF0IHN0cmluZy4gIEZpeGVzIGJ1ZyM1OTk1NiBhbmQgYnVnIzYwMDIxLg0K LS0tDQogbGlzcC9wY29tcGxldGUuZWwgfCAyNyArKysrKysrKysrKysrKysr KysrKy0tLS0tLS0NCiAxIGZpbGUgY2hhbmdlZCwgMjAgaW5zZXJ0aW9ucygr KSwgNyBkZWxldGlvbnMoLSkNCg0KZGlmZiAtLWdpdCBhL2xpc3AvcGNvbXBs ZXRlLmVsIGIvbGlzcC9wY29tcGxldGUuZWwNCmluZGV4IDRlM2E4OGJiZGE4 Li5iMWZiZDg4YTM3NyAxMDA2NDQNCi0tLSBhL2xpc3AvcGNvbXBsZXRlLmVs DQorKysgYi9saXNwL3Bjb21wbGV0ZS5lbA0KQEAgLTY0NSwxMyArNjQ1LDI2 IEBAIHBjb21wbGV0ZS1hcmcNCiANCiBUaGUgT0ZGU0VUIGFyZ3VtZW50IGlz IGFkZGVkIHRvL3Rha2VuIGF3YXkgZnJvbSB0aGUgaW5kZXggdGhhdCB3aWxs IGJlDQogdXNlZC4gIFRoaXMgaXMgcmVhbGx5IG9ubHkgdXNlZnVsIHdpdGgg YGZpcnN0JyBhbmQgYGxhc3QnLCBmb3INCi1hY2Nlc3NpbmcgYWJzb2x1dGUg YXJndW1lbnQgcG9zaXRpb25zLiINCi0gIChudGggKCsgKHBjYXNlIGluZGV4 DQotCSAgICgnZmlyc3QgMCkNCi0JICAgKCdsYXN0ICBwY29tcGxldGUtbGFz dCkNCi0JICAgKF8gICAgICAoLSBwY29tcGxldGUtaW5kZXggKG9yIGluZGV4 IDApKSkpDQotCSAgKG9yIG9mZnNldCAwKSkNCi0gICAgICAgcGNvbXBsZXRl LWFyZ3MpKQ0KK2FjY2Vzc2luZyBhYnNvbHV0ZSBhcmd1bWVudCBwb3NpdGlv bnMuDQorDQorV2hlbiB0aGUgYXJndW1lbnQgaGFzIGJlZW4gdHJhbnNmb3Jt ZWQgaW50byBzb21ldGhpbmcgdGhhdCBpcyBub3QNCithIHN0cmluZyBieSBg cGNvbXBsZXRlLXBhcnNlLWFyZ3VtZW50cy1mdW5jdGlvbicsIHRoZSB0ZXh0 DQorcmVwcmVzZW50YXRpb24gb2YgdGhlIGFyZ3VtZW50LCBuYW1lbHkgd2hh dCB0aGUgdXNlciBhY3R1YWxseQ0KK3R5cGVkIGluLCBpcyByZXR1cm5lZCwg YW5kIHRoZSB2YWx1ZSBvZiB0aGUgYXJndW1lbnQgaXMgc3RvcmVkIGluDQor dGhlIHBjb21wbGV0ZS1hcmctdmFsdWUgdGV4dCBwcm9wZXJ0eSBvZiB0aGF0 IHN0cmluZy4iDQorICAobGV0ICgoYXJnDQorICAgICAgICAgKG50aCAoKyAo cGNhc2UgaW5kZXgNCisJICAgICAgICAgICAoJ2ZpcnN0IDApDQorCSAgICAg ICAgICAgKCdsYXN0ICBwY29tcGxldGUtbGFzdCkNCisJICAgICAgICAgICAo XyAgICAgICgtIHBjb21wbGV0ZS1pbmRleCAob3IgaW5kZXggMCkpKSkNCisJ ICAgICAgICAgKG9yIG9mZnNldCAwKSkNCisgICAgICAgICAgICAgIHBjb21w bGV0ZS1hcmdzKSkpDQorICAgIChpZiAoc3RyaW5ncCBhcmcpDQorICAgICAg ICBhcmcNCisgICAgICAocHJvcGVydGl6ZQ0KKyAgICAgICAoYnVmZmVyLXN1 YnN0cmluZyAocGNvbXBsZXRlLWJlZ2luIGluZGV4IG9mZnNldCkNCisgICAg ICAgICAgICAgICAgICAgICAgICAgKHBjb21wbGV0ZS1iZWdpbiAoMS0gKG9y IGluZGV4IDApKSBvZmZzZXQpKQ0KKyAgICAgICAncGNvbXBsZXRlLWFyZy12 YWx1ZSBhcmcpKSkpDQogDQogKGRlZnVuIHBjb21wbGV0ZS1iZWdpbiAoJm9w dGlvbmFsIGluZGV4IG9mZnNldCkNCiAgICJSZXR1cm4gdGhlIGJlZ2lubmlu ZyBwb3NpdGlvbiBvZiB0aGUgSU5ERVh0aCBhcmd1bWVudC4NCi0tIA0KMi4z NS4xDQoNCg== --cYiCORjVvK-- From debbugs-submit-bounces@debbugs.gnu.org Tue Dec 20 01:46:10 2022 Received: (at 60021) by debbugs.gnu.org; 20 Dec 2022 06:46:10 +0000 Received: from localhost ([127.0.0.1]:42904 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p7WO9-0007P6-QS for submit@debbugs.gnu.org; Tue, 20 Dec 2022 01:46:10 -0500 Received: from server.qxqx.de ([178.63.65.180]:46039 helo=mail.qxqx.de) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p7WO5-0007OU-An for 60021@debbugs.gnu.org; Tue, 20 Dec 2022 01:46:08 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=qxqx.de; s=mail1392553390; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=rJ7m+sv+i+bAReu+SzysuguLhN+7fPf0H0M5KDienuc=; b=p0GQKbzqyF8WJUh/xcXhYwa8Le Z/ION5AoiYI+SzraQwG13bTwxEy+DmoheTmQYf1chBfd80CSunBC9LzNA1ldugV4gLei0+7Cd0h8E VS0h3hBBy8q22ml0pjP/xUrJlNQvi/K7Qjv+Ljcevxp8ZRrG97QGfcE/sk7fS0N+yb/s=; Message-ID: <017a4928-bec0-68a8-82ea-ea8c305b32c4@daniel-mendler.de> Date: Tue, 20 Dec 2022 07:45:55 +0100 MIME-Version: 1.0 Subject: Re: bug#60021: 29.0.60; Eshell completion errors in the presence of buffer redirects To: Gregory Heytings References: <87pmconwnw.fsf@daniel-mendler.de> <17d95c0d-e0c5-b99d-c831-d9b815cbb25d@daniel-mendler.de> <12e425eb-1fdc-a014-cf9c-e3ccb026f3b0@daniel-mendler.de> <9d2a08cf-888a-d939-4df4-d86af3bb6902@daniel-mendler.de> Content-Language: en-US From: Daniel Mendler In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 60021 Cc: 60021@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) On 12/19/22 23:24, Gregory Heytings wrote: > Daniel, can you please try the attached patch and tell us if it fixes the > issue without introducing regressions? Thanks for looking into this! I inspected the patch and it seems like a reasonable fix for the problem. I wonder about the introduction of the `pcomplete-arg-value' string property. Is the introduction of this property necessary? Do you have a use case for this right now? If the recipes of #59956 and #60021 are fixed by this on your setup, I trust it will work properly on my setup. No reason for additional testing on my side. From debbugs-submit-bounces@debbugs.gnu.org Tue Dec 20 03:55:16 2022 Received: (at 60021) by debbugs.gnu.org; 20 Dec 2022 08:55:16 +0000 Received: from localhost ([127.0.0.1]:43502 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p7YP6-0000WT-BJ for submit@debbugs.gnu.org; Tue, 20 Dec 2022 03:55:16 -0500 Received: from heytings.org ([95.142.160.155]:38000) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p7YP5-0000WN-7C for 60021@debbugs.gnu.org; Tue, 20 Dec 2022 03:55:15 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=heytings.org; s=20220101; t=1671526513; bh=IohstmJ0N5wAlcgB8k2FOPZYb7L/fDf7a42ny94JYdo=; h=Date:From:To:cc:Subject:In-Reply-To:Message-ID:References:From; b=oP063ZXOOgxcU1nSubCtT7ce8tE9sd8vpc0ixCjT2vsERHVLrEYLHvbb1QtLr6f2I CTEQYawdrFDg3g1eYpBEk9WRQSmEUdDqg3vAWucXhm3cPceKb9j0aWS+hqOlnAAacM puQjaLcXDAo11CEhHYyGKlNfljmc/vetlyos+ORMQeb9+xAGp9StSuilQuz5DMzJ1Z g4Fibg/g5F1tqmcjIEOdwbCeC0r4ZXpc3cM1re8Xmh3hhNTyk3bVrZTb9kZGmf4JZz Rt6CPHNPK/Nfca1AiNfReY+gQhbyrnhDIwL3KJlTkzL0suSTYUPjuJwhT4v6hc07ZS 7rhF4ngI3ebOg== Date: Tue, 20 Dec 2022 08:55:13 +0000 From: Gregory Heytings To: Daniel Mendler Subject: Re: bug#60021: 29.0.60; Eshell completion errors in the presence of buffer redirects In-Reply-To: <017a4928-bec0-68a8-82ea-ea8c305b32c4@daniel-mendler.de> Message-ID: References: <87pmconwnw.fsf@daniel-mendler.de> <17d95c0d-e0c5-b99d-c831-d9b815cbb25d@daniel-mendler.de> <12e425eb-1fdc-a014-cf9c-e3ccb026f3b0@daniel-mendler.de> <9d2a08cf-888a-d939-4df4-d86af3bb6902@daniel-mendler.de> <017a4928-bec0-68a8-82ea-ea8c305b32c4@daniel-mendler.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 60021 Cc: 60021@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) >> Daniel, can you please try the attached patch and tell us if it fixes >> the issue without introducing regressions? > > Thanks for looking into this! > Thanks for your reply! > > I inspected the patch and it seems like a reasonable fix for the > problem. I wonder about the introduction of the `pcomplete-arg-value' > string property. Is the introduction of this property necessary? Do you > have a use case for this right now? > Not right now, no. It's a kind of compromise. Previously pcomplete-args (and pcomplete.el in general) assumed that pcomplete-parse-argument-function would return strings, and only strings. When that's not the case, such as in eshell, it fails. For example, with your recipe, when '#<*scratch*>' is parsed, a buffer object is returned. That value could have been transformed into a string with 'format', but that would mean that the original value has been lost (from the point of view of pcomplete). The solution we found is to wrap that value in a string, the textual representation of the argument, namely the string "#<*scratch*>" in your recipe. With that solution it becomes possible to design other pcomplete functions that would use that value. > > If the recipes of #59956 and #60021 are fixed by this on your setup, I > trust it will work properly on my setup. No reason for additional > testing on my side. > They are fixed, but I don't use eshell (and neither does Stefan M IIUC), so I may very well have missed some important other cases in which that fix would introduce a regression. From debbugs-submit-bounces@debbugs.gnu.org Tue Dec 20 04:47:23 2022 Received: (at 60021) by debbugs.gnu.org; 20 Dec 2022 09:47:23 +0000 Received: from localhost ([127.0.0.1]:43847 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p7ZDX-0003b4-4a for submit@debbugs.gnu.org; Tue, 20 Dec 2022 04:47:23 -0500 Received: from server.qxqx.de ([178.63.65.180]:36155 helo=mail.qxqx.de) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p7ZDV-0003ay-4f for 60021@debbugs.gnu.org; Tue, 20 Dec 2022 04:47:21 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=qxqx.de; s=mail1392553390; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=pdD9q99gRdGUNIAYGezkvWyvyUIPga9msZAwpQBhF4s=; b=XAXUyFm5Ea7aG4/f+XjVjbteys l4KR+oPF6B/2LZ2rhoivxckLMHPthh+5opawPhEeUQy3BNCLqBlomc8152VdMhhiZe0djXxK2TVtG m9rt3ZLNOXMlablYyFEL65QOW2e2doi+rRsj/VWDR4/ParqJcNT5liZCbpG1DEizBXUE=; Message-ID: <480d2d01-6f95-b105-65ea-ef0514bf7d68@daniel-mendler.de> Date: Tue, 20 Dec 2022 10:47:11 +0100 MIME-Version: 1.0 Subject: Re: bug#60021: 29.0.60; Eshell completion errors in the presence of buffer redirects To: Gregory Heytings References: <87pmconwnw.fsf@daniel-mendler.de> <17d95c0d-e0c5-b99d-c831-d9b815cbb25d@daniel-mendler.de> <12e425eb-1fdc-a014-cf9c-e3ccb026f3b0@daniel-mendler.de> <9d2a08cf-888a-d939-4df4-d86af3bb6902@daniel-mendler.de> <017a4928-bec0-68a8-82ea-ea8c305b32c4@daniel-mendler.de> Content-Language: en-US From: Daniel Mendler In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 60021 Cc: 60021@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) On 12/20/22 09:55, Gregory Heytings wrote: >> If the recipes of #59956 and #60021 are fixed by this on your setup, I >> trust it will work properly on my setup. No reason for additional >> testing on my side. >> > > They are fixed, but I don't use eshell (and neither does Stefan M IIUC), > so I may very well have missed some important other cases in which that > fix would introduce a regression. I installed the patch and I will see if something comes up during my normal Emacs usage. From debbugs-submit-bounces@debbugs.gnu.org Tue Dec 20 05:00:09 2022 Received: (at 60021) by debbugs.gnu.org; 20 Dec 2022 10:00:09 +0000 Received: from localhost ([127.0.0.1]:43901 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p7ZPt-0003la-J0 for submit@debbugs.gnu.org; Tue, 20 Dec 2022 05:00:09 -0500 Received: from heytings.org ([95.142.160.155]:38054) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p7ZPr-0003kO-3U for 60021@debbugs.gnu.org; Tue, 20 Dec 2022 05:00:07 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=heytings.org; s=20220101; t=1671530405; bh=ERE4BsGKKnT6DrwLECAUAdAgNPlHxnpC5mpTvwHsyLQ=; h=Date:From:To:cc:Subject:In-Reply-To:Message-ID:References:From; b=j6zRrixQ5A83ciw1BKC7JjgL9Cly0ENuJtLmhJITnXudUWbw6W40PfmjhZ04PIb2q G+BKzMRRHoc/SzSII/ZSgI2BKmSBLlsmzMDZiwCGS9wTGHn5JnJsK8f8FolPAyEeko LX2g26U0AxloTlYKMXOxRKbIJfEKJxb+kl/WKwgyL1QnU4+vrjMakQq8Fd27BqV75G 5hT/mpDuYthhEdjKMxW4UCWB6l6eVKoCbF+sgeV53VV0cMF4WTh1UZgJUfbUptTQxO pEuwFoPeX+Fwns25DhUyHd/X9Bmgcj4AibtCyiy250rtzRFrgxOBib5CkRA5gYRiOh DOTPbKN6rEMFA== Date: Tue, 20 Dec 2022 10:00:05 +0000 From: Gregory Heytings To: Daniel Mendler Subject: Re: bug#60021: 29.0.60; Eshell completion errors in the presence of buffer redirects In-Reply-To: <480d2d01-6f95-b105-65ea-ef0514bf7d68@daniel-mendler.de> Message-ID: References: <87pmconwnw.fsf@daniel-mendler.de> <17d95c0d-e0c5-b99d-c831-d9b815cbb25d@daniel-mendler.de> <12e425eb-1fdc-a014-cf9c-e3ccb026f3b0@daniel-mendler.de> <9d2a08cf-888a-d939-4df4-d86af3bb6902@daniel-mendler.de> <017a4928-bec0-68a8-82ea-ea8c305b32c4@daniel-mendler.de> <480d2d01-6f95-b105-65ea-ef0514bf7d68@daniel-mendler.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 60021 Cc: 60021@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) >>> If the recipes of #59956 and #60021 are fixed by this on your setup, I >>> trust it will work properly on my setup. No reason for additional >>> testing on my side. >> >> They are fixed, but I don't use eshell (and neither does Stefan M >> IIUC), so I may very well have missed some important other cases in >> which that fix would introduce a regression. > > I installed the patch and I will see if something comes up during my > normal Emacs usage. > Thanks. From debbugs-submit-bounces@debbugs.gnu.org Thu Dec 29 17:03:47 2022 Received: (at 60021-done) by debbugs.gnu.org; 29 Dec 2022 22:03:47 +0000 Received: from localhost ([127.0.0.1]:33079 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pB106-0001Xp-Ri for submit@debbugs.gnu.org; Thu, 29 Dec 2022 17:03:47 -0500 Received: from heytings.org ([95.142.160.155]:50710) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pB105-0001Xh-Dx for 60021-done@debbugs.gnu.org; Thu, 29 Dec 2022 17:03:45 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=heytings.org; s=20220101; t=1672351424; bh=z1y8dlOqPktWkjBf+bdvHHy81qefyPs6KyNboYYfElY=; h=Date:From:To:cc:Subject:In-Reply-To:Message-ID:References:From; b=Abbjz97EI2hy/8arIGxxT8oqA4979nZlmTrqlQxrsvWU/UERw5C+pzlBzUUtIH5Db HpuJEqPvF3ji/M4bDACfgJle1UP6pJnlRMe5WPjFlgevjSxdzgSZzROjk+ZYSD3rH/ Iu+FmjNfrrXmCx1x5RKEkbjJvw3MWqrA0tYq+iBtMnSi7JYCbq5xLrPlcwyBgLsY8G K05ipyYYiIuK0neevY1M4EYgfTwKtU6Kt+GWazBUlt8hhdl9ne7OLnTW2wSNcYz20p tBSIiCoxP0hdM1OoRU2llggnm9xFcTj6fSsTrq3CQgFof/VcdPQLicsNnHSlH2nwUA erKoYQOXb1pWw== Date: Thu, 29 Dec 2022 22:03:44 +0000 From: Gregory Heytings To: Daniel Mendler Subject: Re: bug#60021: 29.0.60; Eshell completion errors in the presence of buffer redirects In-Reply-To: Message-ID: <86ce08480301f35806fe@heytings.org> References: <87pmconwnw.fsf@daniel-mendler.de> <17d95c0d-e0c5-b99d-c831-d9b815cbb25d@daniel-mendler.de> <12e425eb-1fdc-a014-cf9c-e3ccb026f3b0@daniel-mendler.de> <9d2a08cf-888a-d939-4df4-d86af3bb6902@daniel-mendler.de> <017a4928-bec0-68a8-82ea-ea8c305b32c4@daniel-mendler.de> <480d2d01-6f95-b105-65ea-ef0514bf7d68@daniel-mendler.de> MIME-Version: 1.0 Content-Type: text/plain; format=flowed; charset=us-ascii X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 60021-done Cc: 60021-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) No further comments in a week, pushed (dafa6d6bad) and closing. From debbugs-submit-bounces@debbugs.gnu.org Thu Dec 29 23:42:43 2022 Received: (at 60021-done) by debbugs.gnu.org; 30 Dec 2022 04:42:43 +0000 Received: from localhost ([127.0.0.1]:33322 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pB7EB-0002NK-JI for submit@debbugs.gnu.org; Thu, 29 Dec 2022 23:42:43 -0500 Received: from server.qxqx.de ([178.63.65.180]:58417 helo=mail.qxqx.de) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pB7E8-0002N3-S1 for 60021-done@debbugs.gnu.org; Thu, 29 Dec 2022 23:42:42 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=qxqx.de; s=mail1392553390; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=LNMAFznV5h38itO7WH7WsstJ3OX0dEi3onJS+j7XiUY=; b=rUBOtp5XYxZxtPOG9aPBw8G3YA YyL3cSdiBp/NGqV3pRS1DixRZW6tSN7fyXmGN0wPYlp3sBklhkVUTv0eckHxV3rAYP++HS1qcMbab twGkwUlv5/uDCg6XmBU8m3V+6/nJUl/km8+kgvYlRRQm0VrpPVymLFux/tEngGB1Sl00=; Message-ID: <6959650f-7c60-31ae-c799-186e5976ae9c@daniel-mendler.de> Date: Fri, 30 Dec 2022 05:42:32 +0100 MIME-Version: 1.0 Subject: Re: bug#60021: 29.0.60; Eshell completion errors in the presence of buffer redirects To: Gregory Heytings References: <87pmconwnw.fsf@daniel-mendler.de> <17d95c0d-e0c5-b99d-c831-d9b815cbb25d@daniel-mendler.de> <12e425eb-1fdc-a014-cf9c-e3ccb026f3b0@daniel-mendler.de> <9d2a08cf-888a-d939-4df4-d86af3bb6902@daniel-mendler.de> <017a4928-bec0-68a8-82ea-ea8c305b32c4@daniel-mendler.de> <480d2d01-6f95-b105-65ea-ef0514bf7d68@daniel-mendler.de> <86ce08480301f35806fe@heytings.org> Content-Language: en-US From: Daniel Mendler In-Reply-To: <86ce08480301f35806fe@heytings.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 60021-done Cc: 60021-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) On 12/29/22 23:03, Gregory Heytings wrote: > > No further comments in a week, pushed (dafa6d6bad) and closing. Hello Gregory, I am afraid but closing the bug was premature. Your patch dafa6d6bad is broken, since it doesn't cater for the INDEX values 'last and 'first, when you extract the buffer substring. Daniel From unknown Wed Jun 18 00:24:19 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Fri, 27 Jan 2023 12:24:07 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator