GNU bug report logs -
#60015
29.0.60; multi-line messages truncated in non-selected minibuffer
Previous Next
Reported by: Juri Linkov <juri <at> linkov.net>
Date: Mon, 12 Dec 2022 18:08:02 UTC
Severity: normal
Found in version 29.0.60
Done: Eli Zaretskii <eliz <at> gnu.org>
Bug is archived. No further changes may be made.
Full log
View this message in rfc822 format
[Message part 1 (text/plain, inline)]
Your bug report
#60015: 29.0.60; multi-line messages truncated in non-selected minibuffer
which was filed against the emacs package, has been closed.
The explanation is attached below, along with your original report.
If you require more details, please reply to 60015 <at> debbugs.gnu.org.
--
60015: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=60015
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems
[Message part 2 (message/rfc822, inline)]
> From: Juri Linkov <juri <at> linkov.net>
> Cc: martin rudalics <rudalics <at> gmx.at>, 60015 <at> debbugs.gnu.org
> Date: Sat, 17 Dec 2022 19:39:49 +0200
>
> > Juri, does the patch below give good results? It's a bit of overkill,
> > since the mini-window usually doesn't need any resizing, but maybe
> > that is not too bad.
> >
> > If it seems to solve the problem, would you please run with this for a
> > couple of weeks, and report back if you see any problems? If there
> > are no problems, I'll then install this on the emacs-29 branch.
> >
> > diff --git a/src/xdisp.c b/src/xdisp.c
> > index d14cd46..45da496 100644
> > --- a/src/xdisp.c
> > +++ b/src/xdisp.c
> > @@ -19429,6 +19429,13 @@ redisplay_window (Lisp_Object window, bool just_this_one_p)
> > blank_row (w, row, y);
> > goto finish_scroll_bars;
> > }
> > + else if (minibuf_level >= 1)
> > + {
> > + /* We could have a message produced by set-minibuffer-message
> > + displayed in the mini-window as an overlay, so resize the
> > + mini-window if needed. */
> > + resize_mini_window (w, false);
> > + }
>
> I tested it for a while and see no problems with it.
Thanks, installed on the emacs-29 branch, and closing this bug.
[Message part 3 (message/rfc822, inline)]
[Message part 4 (text/plain, inline)]
0. emacs -Q
1. (run-with-timer 5 5 'message "abc\ndef")
2. then activate the minibuffer and switch back to the original buffer
3. after some time observe that only the first line of the multi-line message
is displayed in the minibuffer
I don't know where this problem comes from, but it's impossible to use
edebug to debug minibuffer-related bugs while the minibuffer is active,
because only an old message is displayed, not the most recent,
when using set-multi-message to collect messages. So here is
at least the fix for set-multi-message:
[set-multi-message.patch (text/x-diff, inline)]
diff --git a/lisp/minibuffer.el b/lisp/minibuffer.el
index cfdf2b43f42..36553eca1ad 100644
--- a/lisp/minibuffer.el
+++ b/lisp/minibuffer.el
@@ -914,6 +914,11 @@ set-multi-message
"Return recent messages as one string to display in the echo area.
Note that this feature works best only when `resize-mini-windows'
is at its default value `grow-only'."
+ (if (and (active-minibuffer-window) (not (minibufferp)))
+ ;; Multi-line messages are limited to one line only
+ ;; when the minibuffer window is active and not selected.
+ ;; So don't return a multi-line string in this case:
+ message
(let ((last-message (car multi-message-list)))
(unless (and last-message (equal message (aref last-message 1)))
(when last-message
@@ -931,7 +936,7 @@ set-multi-message
(setf (nthcdr multi-message-max multi-message-list) nil)))
(mapconcat (lambda (m) (aref m 1))
(reverse multi-message-list)
- multi-message-separator)))
+ multi-message-separator))))
(defun clear-minibuffer-message ()
"Clear minibuffer message.
This bug report was last modified 2 years and 185 days ago.
Previous Next
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997,2003 nCipher Corporation Ltd,
1994-97 Ian Jackson.