From debbugs-submit-bounces@debbugs.gnu.org Mon Dec 12 13:07:26 2022 Received: (at submit) by debbugs.gnu.org; 12 Dec 2022 18:07:26 +0000 Received: from localhost ([127.0.0.1]:54458 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p4nD4-0001su-97 for submit@debbugs.gnu.org; Mon, 12 Dec 2022 13:07:26 -0500 Received: from lists.gnu.org ([209.51.188.17]:59548) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p4nD2-0001so-Hh for submit@debbugs.gnu.org; Mon, 12 Dec 2022 13:07:25 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p4nD2-00078N-DG for bug-gnu-emacs@gnu.org; Mon, 12 Dec 2022 13:07:24 -0500 Received: from relay11.mail.gandi.net ([217.70.178.231]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p4nD0-00080K-SG for bug-gnu-emacs@gnu.org; Mon, 12 Dec 2022 13:07:24 -0500 Received: (Authenticated sender: juri@linkov.net) by mail.gandi.net (Postfix) with ESMTPSA id 3249410000A for ; Mon, 12 Dec 2022 18:07:17 +0000 (UTC) From: Juri Linkov To: bug-gnu-emacs@gnu.org Subject: 29.0.60; multi-line messages truncated in non-selected minibuffer Organization: LINKOV.NET Date: Mon, 12 Dec 2022 20:03:41 +0200 Message-ID: <86y1rco5xe.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Received-SPF: pass client-ip=217.70.178.231; envelope-from=juri@linkov.net; helo=relay11.mail.gandi.net X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.6 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.6 (--) --=-=-= Content-Type: text/plain 0. emacs -Q 1. (run-with-timer 5 5 'message "abc\ndef") 2. then activate the minibuffer and switch back to the original buffer 3. after some time observe that only the first line of the multi-line message is displayed in the minibuffer I don't know where this problem comes from, but it's impossible to use edebug to debug minibuffer-related bugs while the minibuffer is active, because only an old message is displayed, not the most recent, when using set-multi-message to collect messages. So here is at least the fix for set-multi-message: --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=set-multi-message.patch diff --git a/lisp/minibuffer.el b/lisp/minibuffer.el index cfdf2b43f42..36553eca1ad 100644 --- a/lisp/minibuffer.el +++ b/lisp/minibuffer.el @@ -914,6 +914,11 @@ set-multi-message "Return recent messages as one string to display in the echo area. Note that this feature works best only when `resize-mini-windows' is at its default value `grow-only'." + (if (and (active-minibuffer-window) (not (minibufferp))) + ;; Multi-line messages are limited to one line only + ;; when the minibuffer window is active and not selected. + ;; So don't return a multi-line string in this case: + message (let ((last-message (car multi-message-list))) (unless (and last-message (equal message (aref last-message 1))) (when last-message @@ -931,7 +936,7 @@ set-multi-message (setf (nthcdr multi-message-max multi-message-list) nil))) (mapconcat (lambda (m) (aref m 1)) (reverse multi-message-list) - multi-message-separator))) + multi-message-separator)))) (defun clear-minibuffer-message () "Clear minibuffer message. --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Mon Dec 12 13:19:55 2022 Received: (at 60015) by debbugs.gnu.org; 12 Dec 2022 18:19:55 +0000 Received: from localhost ([127.0.0.1]:54533 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p4nP9-00022g-FA for submit@debbugs.gnu.org; Mon, 12 Dec 2022 13:19:55 -0500 Received: from eggs.gnu.org ([209.51.188.92]:46990) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p4nP7-00022a-IQ for 60015@debbugs.gnu.org; Mon, 12 Dec 2022 13:19:54 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p4nP1-0003RQ-8C; Mon, 12 Dec 2022 13:19:47 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=gtIGWNdF/dcc2u7OG8zTnSi6U6NHTL5yR6yFuGsEWxc=; b=jPX2Tic50+AE SAoiqycAQhZ07ac5FwTru3dFrCk4EhC9TasnxkKFRcN1JrihdAP83+LzvxvUPL/rFriKy7KG2vEJG Pp/N18D414XoK3aSsIV6tiXCpVfjMJFq4ZrVi6ih7di/XZyNGPnjlcE7VTUhp46zfCJezK9mHxeH1 JOkeFIj4dUKC4XW6Wn9/hjfcgp+mZIN8A9LoRAZbU6Nru8wapD8+eOPfwRkVi7RCJ14PGfyLUt1Ps tmFgKt4ZzOI2Zjwn8tknugQnwjubOphxgCO7fsrKvLLKqys0Wfu1srF8HDl/SVArO8Ty4l1GJJgcE giCWP0xbLVS7V+YEsVPZ5Q==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p4nOz-0006tB-PB; Mon, 12 Dec 2022 13:19:46 -0500 Date: Mon, 12 Dec 2022 20:19:48 +0200 Message-Id: <83cz8oqybf.fsf@gnu.org> From: Eli Zaretskii To: Juri Linkov In-Reply-To: <86y1rco5xe.fsf@mail.linkov.net> (message from Juri Linkov on Mon, 12 Dec 2022 20:03:41 +0200) Subject: Re: bug#60015: 29.0.60; multi-line messages truncated in non-selected minibuffer References: <86y1rco5xe.fsf@mail.linkov.net> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 60015 Cc: 60015@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Juri Linkov > Date: Mon, 12 Dec 2022 20:03:41 +0200 > > 0. emacs -Q > 1. (run-with-timer 5 5 'message "abc\ndef") > 2. then activate the minibuffer and switch back to the original buffer > 3. after some time observe that only the first line of the multi-line message > is displayed in the minibuffer Doesn't happen here (I waited for 2.5 minutes). Is the recipe complete and exact? Does it perhaps matter how do you "switch back to the original buffer"? (I used a mouse click.) When the problem happens, what do you see in *Messages*? Anything other that "abc\ndef"? From debbugs-submit-bounces@debbugs.gnu.org Mon Dec 12 13:37:55 2022 Received: (at 60015) by debbugs.gnu.org; 12 Dec 2022 18:37:55 +0000 Received: from localhost ([127.0.0.1]:54624 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p4ngZ-0002GC-3B for submit@debbugs.gnu.org; Mon, 12 Dec 2022 13:37:55 -0500 Received: from relay9-d.mail.gandi.net ([217.70.183.199]:49099) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p4ngX-0002G4-QJ for 60015@debbugs.gnu.org; Mon, 12 Dec 2022 13:37:54 -0500 Received: (Authenticated sender: juri@linkov.net) by mail.gandi.net (Postfix) with ESMTPSA id 2FA9AFF802; Mon, 12 Dec 2022 18:37:46 +0000 (UTC) From: Juri Linkov To: Eli Zaretskii Subject: Re: bug#60015: 29.0.60; multi-line messages truncated in non-selected minibuffer In-Reply-To: <83cz8oqybf.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 12 Dec 2022 20:19:48 +0200") Organization: LINKOV.NET References: <86y1rco5xe.fsf@mail.linkov.net> <83cz8oqybf.fsf@gnu.org> Date: Mon, 12 Dec 2022 20:37:05 +0200 Message-ID: <86zgbsmpta.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 60015 Cc: 60015@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) >> 1. (run-with-timer 5 5 'message "abc\ndef") >> 2. then activate the minibuffer and switch back to the original buffer >> 3. after some time observe that only the first line of the multi-line message >> is displayed in the minibuffer > > Doesn't happen here (I waited for 2.5 minutes). Is the recipe > complete and exact? Does it perhaps matter how do you "switch back to > the original buffer"? (I used a mouse click.) It's essential to ensure that the height of the minibuffer/echo area initially is not more than 1 line. Otherwise, when it's already resized to fit multi-line messages, then all lines are displayed. > When the problem happens, what do you see in *Messages*? Anything > other that "abc\ndef"? Only the first line "abc" is displayed in the minibuffer as the minibuffer message. From debbugs-submit-bounces@debbugs.gnu.org Mon Dec 12 14:20:57 2022 Received: (at 60015) by debbugs.gnu.org; 12 Dec 2022 19:20:57 +0000 Received: from localhost ([127.0.0.1]:54824 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p4oMD-0002lq-93 for submit@debbugs.gnu.org; Mon, 12 Dec 2022 14:20:57 -0500 Received: from eggs.gnu.org ([209.51.188.92]:60348) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p4oMB-0002lk-IG for 60015@debbugs.gnu.org; Mon, 12 Dec 2022 14:20:56 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p4oM5-00032f-6F; Mon, 12 Dec 2022 14:20:49 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=hhJ8Uli5ptSCAo2M52XTa5YFCyw0hjnCs0bU5udl+b8=; b=SgDQHbsuq8HC QGtxuefKOftv7Nc1PW70q8o6K/6m/wb6qt69Mru/jr3djQgBNjWB40HxYjDfB5R214d2xg20os6hz UvsoqZOysXU3RQqIlutmWhF3at/mjPC4ELA8WdX1j1xHquYhEoOFoPBnC/DbHPlr6gAG5rfs5ioHW GXbzHRQlbxPRVXwtNysAEMfrrL7hZEa0Mk8oEnlevxsS6eNBepVZtuq9oHDJoPj8/CqZDk0LN1PgG cNRL18UKnzbdpRM8JVF+95gGqaiy9iLXdp7WHo1mnE+0hcfAD+niBeusbAWYiH0JUN4Tk4FgU9uZ0 iyM6PUfR47MBvRSrjpmnJQ==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p4oM4-0004H5-Bv; Mon, 12 Dec 2022 14:20:49 -0500 Date: Mon, 12 Dec 2022 21:20:49 +0200 Message-Id: <83a63sqvhq.fsf@gnu.org> From: Eli Zaretskii To: Juri Linkov In-Reply-To: <86zgbsmpta.fsf@mail.linkov.net> (message from Juri Linkov on Mon, 12 Dec 2022 20:37:05 +0200) Subject: Re: bug#60015: 29.0.60; multi-line messages truncated in non-selected minibuffer References: <86y1rco5xe.fsf@mail.linkov.net> <83cz8oqybf.fsf@gnu.org> <86zgbsmpta.fsf@mail.linkov.net> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 60015 Cc: 60015@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Juri Linkov > Cc: 60015@debbugs.gnu.org > Date: Mon, 12 Dec 2022 20:37:05 +0200 > > >> 1. (run-with-timer 5 5 'message "abc\ndef") > >> 2. then activate the minibuffer and switch back to the original buffer > >> 3. after some time observe that only the first line of the multi-line message > >> is displayed in the minibuffer > > > > Doesn't happen here (I waited for 2.5 minutes). Is the recipe > > complete and exact? Does it perhaps matter how do you "switch back to > > the original buffer"? (I used a mouse click.) > > It's essential to ensure that the height of the minibuffer/echo area > initially is not more than 1 line. That's so by default, so "emacs -Q" should ensure that. Right? > > When the problem happens, what do you see in *Messages*? Anything > > other that "abc\ndef"? > > Only the first line "abc" is displayed in the minibuffer > as the minibuffer message. I asked about the *Messages* buffer, not about the minibuffer. From debbugs-submit-bounces@debbugs.gnu.org Tue Dec 13 12:29:19 2022 Received: (at 60015) by debbugs.gnu.org; 13 Dec 2022 17:29:19 +0000 Received: from localhost ([127.0.0.1]:33493 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p595j-0006g5-AI for submit@debbugs.gnu.org; Tue, 13 Dec 2022 12:29:19 -0500 Received: from relay4-d.mail.gandi.net ([217.70.183.196]:38231) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p595h-0006fl-Oo for 60015@debbugs.gnu.org; Tue, 13 Dec 2022 12:29:18 -0500 Received: (Authenticated sender: juri@linkov.net) by mail.gandi.net (Postfix) with ESMTPSA id A50B3E0008; Tue, 13 Dec 2022 17:29:09 +0000 (UTC) From: Juri Linkov To: Eli Zaretskii Subject: Re: bug#60015: 29.0.60; multi-line messages truncated in non-selected minibuffer In-Reply-To: <83a63sqvhq.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 12 Dec 2022 21:20:49 +0200") Organization: LINKOV.NET References: <86y1rco5xe.fsf@mail.linkov.net> <83cz8oqybf.fsf@gnu.org> <86zgbsmpta.fsf@mail.linkov.net> <83a63sqvhq.fsf@gnu.org> Date: Tue, 13 Dec 2022 19:20:06 +0200 Message-ID: <865yefw7o5.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 60015 Cc: 60015@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) >> >> 1. (run-with-timer 5 5 'message "abc\ndef") >> >> 2. then activate the minibuffer and switch back to the original buffer >> >> 3. after some time observe that only the first line of the multi-line message >> >> is displayed in the minibuffer >> > >> > Doesn't happen here (I waited for 2.5 minutes). Is the recipe >> > complete and exact? Does it perhaps matter how do you "switch back to >> > the original buffer"? (I used a mouse click.) >> >> It's essential to ensure that the height of the minibuffer/echo area >> initially is not more than 1 line. > > That's so by default, so "emacs -Q" should ensure that. Right? Evaluating the first line above resizes the minibuffer, and the timer resizes the minibuffer, so it's difficult to find a moment when it's exactly 1 line high. I have no idea how to simplify this test case. >> > When the problem happens, what do you see in *Messages*? Anything >> > other that "abc\ndef"? >> >> Only the first line "abc" is displayed in the minibuffer >> as the minibuffer message. > > I asked about the *Messages* buffer, not about the minibuffer. Sorry. The *Messages* buffer shows all lines of the multi-line string. From debbugs-submit-bounces@debbugs.gnu.org Tue Dec 13 12:44:23 2022 Received: (at 60015) by debbugs.gnu.org; 13 Dec 2022 17:44:23 +0000 Received: from localhost ([127.0.0.1]:33596 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p59KJ-0006ra-FU for submit@debbugs.gnu.org; Tue, 13 Dec 2022 12:44:23 -0500 Received: from eggs.gnu.org ([209.51.188.92]:36728) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p59KI-0006rU-H5 for 60015@debbugs.gnu.org; Tue, 13 Dec 2022 12:44:23 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p59KD-0002Pv-5F; Tue, 13 Dec 2022 12:44:17 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=J2ilaNJlK93V3oGOEbBhRC2DfxQUJX6sxVHJSQmgeZA=; b=XOowAKpcoLMn BPXQVtSI3qpwlIQYJ8cZ8kSdH08GF6E8D2WM2xOXmq8mj8iDZ/nII39veQFhAy5FYUV9OjAXhrDNx wOOLPeDkgkuMbIrvvxrQC9HOAnr/jmcz30uPv8ZSuyIMnGwuTVvC87CqQcT7mgC9rFVwCEwkwzLHy 9JlBVfy+9lumIVMd+MtU2i6uFgiV7aWSsT1RU+tT69Mm5p16nD2chnBtUCwl7fbnmpmbthRodUhqo RjvSivclALYfaXI6pzaEAiconW1wgGa2ZZpueHjixw93J/LcgyjS4CUqrYXFiw/VQL+iDAreD4cFR to49E/LhsGvaKYtTbWgQjw==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p59KA-0002Oi-0Z; Tue, 13 Dec 2022 12:44:14 -0500 Date: Tue, 13 Dec 2022 19:44:17 +0200 Message-Id: <83r0x3nqq6.fsf@gnu.org> From: Eli Zaretskii To: Juri Linkov In-Reply-To: <865yefw7o5.fsf@mail.linkov.net> (message from Juri Linkov on Tue, 13 Dec 2022 19:20:06 +0200) Subject: Re: bug#60015: 29.0.60; multi-line messages truncated in non-selected minibuffer References: <86y1rco5xe.fsf@mail.linkov.net> <83cz8oqybf.fsf@gnu.org> <86zgbsmpta.fsf@mail.linkov.net> <83a63sqvhq.fsf@gnu.org> <865yefw7o5.fsf@mail.linkov.net> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 60015 Cc: 60015@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Juri Linkov > Cc: 60015@debbugs.gnu.org > Date: Tue, 13 Dec 2022 19:20:06 +0200 > > >> > Doesn't happen here (I waited for 2.5 minutes). Is the recipe > >> > complete and exact? Does it perhaps matter how do you "switch back to > >> > the original buffer"? (I used a mouse click.) > >> > >> It's essential to ensure that the height of the minibuffer/echo area > >> initially is not more than 1 line. > > > > That's so by default, so "emacs -Q" should ensure that. Right? > > Evaluating the first line above resizes the minibuffer, > and the timer resizes the minibuffer, so it's difficult > to find a moment when it's exactly 1 line high. You said "initially", so I thought you were talking about what happens before the recipe is started. Are you saying that you see the echo-area go down to 1 line _after_ the timer is started? If so, to unlock this puzzle we need to understand what causes the mini-window to resize back to 1 line. The default value of resize-mini-windows is 'grow-only', so it isn't supposed to shrink back to 1 line. > >> > When the problem happens, what do you see in *Messages*? Anything > >> > other that "abc\ndef"? > >> > >> Only the first line "abc" is displayed in the minibuffer > >> as the minibuffer message. > > > > I asked about the *Messages* buffer, not about the minibuffer. > > Sorry. The *Messages* buffer shows all lines of the multi-line string. And nothing else? I hoped you will see there something that would explain why the mini-window resized back to 1 line. From debbugs-submit-bounces@debbugs.gnu.org Tue Dec 13 12:57:32 2022 Received: (at 60015) by debbugs.gnu.org; 13 Dec 2022 17:57:32 +0000 Received: from localhost ([127.0.0.1]:33678 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p59X2-0000ta-Kp for submit@debbugs.gnu.org; Tue, 13 Dec 2022 12:57:32 -0500 Received: from relay11.mail.gandi.net ([217.70.178.231]:58839) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p59X0-0000tU-U3 for 60015@debbugs.gnu.org; Tue, 13 Dec 2022 12:57:31 -0500 Received: (Authenticated sender: juri@linkov.net) by mail.gandi.net (Postfix) with ESMTPSA id B8D70100002; Tue, 13 Dec 2022 17:57:22 +0000 (UTC) From: Juri Linkov To: Eli Zaretskii Subject: Re: bug#60015: 29.0.60; multi-line messages truncated in non-selected minibuffer In-Reply-To: <83r0x3nqq6.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 13 Dec 2022 19:44:17 +0200") Organization: LINKOV.NET References: <86y1rco5xe.fsf@mail.linkov.net> <83cz8oqybf.fsf@gnu.org> <86zgbsmpta.fsf@mail.linkov.net> <83a63sqvhq.fsf@gnu.org> <865yefw7o5.fsf@mail.linkov.net> <83r0x3nqq6.fsf@gnu.org> Date: Tue, 13 Dec 2022 19:56:55 +0200 Message-ID: <86h6xzrxug.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 60015 Cc: 60015@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > Are you saying that you see the echo-area go down to 1 line _after_ > the timer is started? If so, to unlock this puzzle we need to > understand what causes the mini-window to resize back to 1 line. The > default value of resize-mini-windows is 'grow-only', so it isn't > supposed to shrink back to 1 line. The echo-area doesn't go down to 1 line automatically. You need to force it to have the height of 1 line to be able to see the bug. I use C-g to resize it back to 1 line. Then multi-line message from the timer displays only the first line. From debbugs-submit-bounces@debbugs.gnu.org Thu Dec 15 02:56:44 2022 Received: (at 60015) by debbugs.gnu.org; 15 Dec 2022 07:56:44 +0000 Received: from localhost ([127.0.0.1]:42481 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p5j6i-000802-1V for submit@debbugs.gnu.org; Thu, 15 Dec 2022 02:56:44 -0500 Received: from relay2-d.mail.gandi.net ([217.70.183.194]:33231) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p5j6e-0007zu-Io for 60015@debbugs.gnu.org; Thu, 15 Dec 2022 02:56:42 -0500 Received: (Authenticated sender: juri@linkov.net) by mail.gandi.net (Postfix) with ESMTPSA id 08D3740004; Thu, 15 Dec 2022 07:56:33 +0000 (UTC) From: Juri Linkov To: Eli Zaretskii Subject: Re: bug#60015: 29.0.60; multi-line messages truncated in non-selected minibuffer In-Reply-To: <86h6xzrxug.fsf@mail.linkov.net> (Juri Linkov's message of "Tue, 13 Dec 2022 19:56:55 +0200") Organization: LINKOV.NET References: <86y1rco5xe.fsf@mail.linkov.net> <83cz8oqybf.fsf@gnu.org> <86zgbsmpta.fsf@mail.linkov.net> <83a63sqvhq.fsf@gnu.org> <865yefw7o5.fsf@mail.linkov.net> <83r0x3nqq6.fsf@gnu.org> <86h6xzrxug.fsf@mail.linkov.net> Date: Thu, 15 Dec 2022 09:44:42 +0200 Message-ID: <86mt7pgkzh.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 60015 Cc: 60015@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Here is a better test case. Please evaluate: (progn (keymap-global-set "C-c C-c" (lambda () (interactive) (message "abc\ndef"))) nil) Then the bug can be reproduced with just these keys: M-x C-x o C-c C-c Only the top line is displayed in the minibuffer. From debbugs-submit-bounces@debbugs.gnu.org Thu Dec 15 05:18:27 2022 Received: (at 60015) by debbugs.gnu.org; 15 Dec 2022 10:18:27 +0000 Received: from localhost ([127.0.0.1]:42727 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p5lJr-0001Gw-BW for submit@debbugs.gnu.org; Thu, 15 Dec 2022 05:18:27 -0500 Received: from mout.gmx.net ([212.227.17.21]:54369) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p5lJn-0001Gq-Ou for 60015@debbugs.gnu.org; Thu, 15 Dec 2022 05:18:26 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.at; s=s31663417; t=1671099497; bh=hLpIOAmgQtBIDXrGRZLT3R01EbSD2+HCyslrjppITPk=; h=X-UI-Sender-Class:Date:Subject:To:Cc:References:From:In-Reply-To; b=uK0QId4effMCPif/DU+e0Rzstt3WuCkL5ZpAKZrA3Ou4qBRjxhcSWfdA/MrT0P21k ORh1LO8mOQKIcBeoSYYGnCUNsBAAI0MZRZd2EqmL6gaaxKlG7D71rWo20/jmUaTVSe dh9eH5v7eKbbGRavpThkjaSI5ghtC7WDeaWzsVtjOs1jhVfeW/ZcocQczTZOBtst2v 5Ox3BVoP0OpxbY+o5UrO/N0hEQpAjfmj0LRV9FO5a2W4vdsazQXJ/DvajW5rAAX5CF GojI/dbG2YXPh2YCK34oCdrTnzbchoTnUsdsRk5HuXG5JOpOOIWvHSqb9FcVebQ3o9 jEq/2AIGipgXg== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from [192.168.1.100] ([213.142.96.182]) by mail.gmx.net (mrgmx105 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MtfJX-1omadb3gsh-00v71h; Thu, 15 Dec 2022 11:18:16 +0100 Message-ID: <32f8777a-2bc3-961c-e773-46451f2b9282@gmx.at> Date: Thu, 15 Dec 2022 11:18:15 +0100 MIME-Version: 1.0 Subject: Re: bug#60015: 29.0.60; multi-line messages truncated in non-selected minibuffer Content-Language: en-US To: Juri Linkov , Eli Zaretskii References: <86y1rco5xe.fsf@mail.linkov.net> <83cz8oqybf.fsf@gnu.org> <86zgbsmpta.fsf@mail.linkov.net> <83a63sqvhq.fsf@gnu.org> <865yefw7o5.fsf@mail.linkov.net> <83r0x3nqq6.fsf@gnu.org> <86h6xzrxug.fsf@mail.linkov.net> <86mt7pgkzh.fsf@mail.linkov.net> From: martin rudalics In-Reply-To: <86mt7pgkzh.fsf@mail.linkov.net> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K1:Ds6D4mF4fn+a0RLWREW4UB0CRXTEzdk/RaXrmNqUWjjJgDdsrvM SELzbQPZh2V/RFFn5HjGzyQ9Qwr0oSPkbPOPyBHJV8x4/bRqWGoMwg8aolSYtFVlueiAmHU aERtUCYmfPpnM+X6asQ9HDPVew0rdB8/9fgmm5CFY13lSZoYVbwToxcn8U8YR5c3xp8PBxW xcGeKCKpV1hhWRH72OALQ== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:oKCdCUUwdUQ=;vXvRdMU23hQR2LDZcM0nTQq+ntv GJWmCITWgtm0+J1nmGzpPmGEMhCNCFq/Fvdor5FSOKY0fOB56KjFiMhUOoJo7MywDsqmRE5P5 f7x0Il8Q3BmBWQ8cDm5AED7acXI1+Xi7F2bFnVZDkAjW8qg2Qcjc/+fbIaACK1kACpmwwA1+t q0PeH9szvNK6wXTpiVZxOFI1j/lwarKdcK8H28k4Buysh8mLRYBpFtXX6qM8T9gO8Enq6YVaV YdNExSsiTj5osZk90L8YnEBpdRtgOFh7VeCuyy1VfuXTz/5hRczqfQ1GF+0stQty9qXHUTZiR bBd6BR26MP4ujrrAGSth84dzowNAFrCyh5XkU257ahRYF+LET6OQT2ovJQA1Q6Ns1UchSRJ+X gG4/oFOovJPBfhbkhB0pCj4AoL+O/N9RcXOmJnLucvXt549ZgurNwpfvrJchNcBixOrmbjraw OIGh81h7ACBqkKKI6tvkPmzXgbPMxhpfSt/6LSs4yEhwRhEZcS3pl4sS/LuMdGWFRsPAXfEV3 uxmvrhE+1iiYZxP3KC0+FOrS70Xbu+a/Z2AGVWp4bgdmnnYRYTigEKwTc1ssh5Y0BMIox+c4g SWGb9RuOC3bSFNqPl1XVzwtS7sR03gw2q35nF7rveDtFUBWmHDky594M4qA2LFVxCHH7vmiP6 Mr2/PvZO1323FYRgTgA7keGKCtbchPfJAVB0CqDR/tdjuyk1enooapt4UAuVzJ/9hGG8ilJ4f rsJvRHbAvRcrTYeJJ8y4U33PC28tJQUFaoMunvnGhaUNJ2cmhXLrQOuhfXbJUdps0g7realBN SPwDO6N0NzSgZrVSHZjg63bv/2xqbeUBjD8YLeey0+8Hr5mfKdh4LSNxBViAOuL2Gz/Qmm+sE AZNwsw+hRDIQHrI0XCRQYWjW2zu4J3/WJvPZPzQxSvqq1aE44M9TltS9pbbIiJg88R2+pv9jP EU826DKnq0UThkQ8l6U+jerwyCs= X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 60015 Cc: 60015@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > Here is a better test case. Please evaluate: > > (progn > (keymap-global-set "C-c C-c" (lambda () (interactive) (message "abc\ndef"))) > nil) > > Then the bug can be reproduced with just these keys: > > M-x > C-x o > C-c C-c > > Only the top line is displayed in the minibuffer. This is caused by resize_echo_area_exactly in xdisp.c. If you replace Lisp_Object resize_exactly = (minibuf_level == 0 ? Qt : Qnil); with Lisp_Object resize_exactly = Qt; the echo area gets resized. martin From debbugs-submit-bounces@debbugs.gnu.org Thu Dec 15 08:36:35 2022 Received: (at 60015) by debbugs.gnu.org; 15 Dec 2022 13:36:36 +0000 Received: from localhost ([127.0.0.1]:43009 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p5oPb-0006Bj-IO for submit@debbugs.gnu.org; Thu, 15 Dec 2022 08:36:35 -0500 Received: from eggs.gnu.org ([209.51.188.92]:50378) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p5oPX-0006BZ-Ec for 60015@debbugs.gnu.org; Thu, 15 Dec 2022 08:36:34 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p5oPR-0005po-SX; Thu, 15 Dec 2022 08:36:25 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=IV8GxMq9n3mpGfmHCm19/Em1vEjZiDYE6cNbeIl0nuM=; b=sEdhMeWfAxfM ZdwSiGfAu4Me0lS4wHX0WbtzXqcT5oQVei1H0CKPZvSWfgCuJ2KDT0BeGQBdL+R4nKUgItFCapGgA Qp5jXyPwJcweAdXEkc6VPkQ2IczZDb/j6h1ydU7FusK1MeGwVgGnku/NThiPvD3Ir+8AgnuwpPRv3 sJ+2OffC8lhHT+OgdugwCE4HmAu7tCRoCM+rErLdCKz8n962KsDlpE8glw2gjtE1VKHz69V9fFn/I gZC4sB/59a9XzztkEl/ziVePXcIn917G7kLidNjeYNdhyrbYdJHeXEB+LOUkW7FH/gxb4/CKqqPRJ OsJ6ubGISQNaR7SVx4Nmow==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p5oPR-0004Gv-1B; Thu, 15 Dec 2022 08:36:25 -0500 Date: Thu, 15 Dec 2022 15:36:24 +0200 Message-Id: <837cyslrfr.fsf@gnu.org> From: Eli Zaretskii To: martin rudalics In-Reply-To: <32f8777a-2bc3-961c-e773-46451f2b9282@gmx.at> (message from martin rudalics on Thu, 15 Dec 2022 11:18:15 +0100) Subject: Re: bug#60015: 29.0.60; multi-line messages truncated in non-selected minibuffer References: <86y1rco5xe.fsf@mail.linkov.net> <83cz8oqybf.fsf@gnu.org> <86zgbsmpta.fsf@mail.linkov.net> <83a63sqvhq.fsf@gnu.org> <865yefw7o5.fsf@mail.linkov.net> <83r0x3nqq6.fsf@gnu.org> <86h6xzrxug.fsf@mail.linkov.net> <86mt7pgkzh.fsf@mail.linkov.net> <32f8777a-2bc3-961c-e773-46451f2b9282@gmx.at> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 60015 Cc: 60015@debbugs.gnu.org, juri@linkov.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Thu, 15 Dec 2022 11:18:15 +0100 > Cc: 60015@debbugs.gnu.org > From: martin rudalics > > > Here is a better test case. Please evaluate: > > > > (progn > > (keymap-global-set "C-c C-c" (lambda () (interactive) (message "abc\ndef"))) > > nil) > > > > Then the bug can be reproduced with just these keys: > > > > M-x > > C-x o > > C-c C-c > > > > Only the top line is displayed in the minibuffer. > > This is caused by resize_echo_area_exactly in xdisp.c. If you replace > > Lisp_Object resize_exactly = (minibuf_level == 0 ? Qt : Qnil); > > with > > Lisp_Object resize_exactly = Qt; > > the echo area gets resized. Are you sure this is the reason and the possible fix? The commentary to resize_echo_area_exactly says: /* Resize the echo area window to exactly the size needed for the currently displayed message, if there is one. If a mini-buffer is active, don't shrink it. */ which makes a lot of sense. And resize_mini_window, which does the job and accepts the argument you suggest to make Qt always, has this single place where it looks at that argument (called EXACT_P): if (EQ (Vresize_mini_windows, Qgrow_only)) { /* Let it grow only, until we display an empty message, in which case the window shrinks again. */ if (height > old_height) grow_mini_window (w, height - old_height); else if (height < old_height && (exact_p || BEGV == ZV)) shrink_mini_window (w); } So this argument cannot have any effect on enlarging the mini-window, only on shrinking it. Or am I missing something? From debbugs-submit-bounces@debbugs.gnu.org Thu Dec 15 09:30:12 2022 Received: (at 60015) by debbugs.gnu.org; 15 Dec 2022 14:30:12 +0000 Received: from localhost ([127.0.0.1]:43072 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p5pFT-0006nc-UZ for submit@debbugs.gnu.org; Thu, 15 Dec 2022 09:30:12 -0500 Received: from eggs.gnu.org ([209.51.188.92]:60130) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p5pFS-0006mS-Lu for 60015@debbugs.gnu.org; Thu, 15 Dec 2022 09:30:11 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p5pFN-0001Cp-1A; Thu, 15 Dec 2022 09:30:05 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=nGJR0PSjNHqS1YtfoCc26HOg3tKrm1hLfO6Hi5o+ctM=; b=j7xoDO4MRO0O Rz1jz2O7vNH3H6LSroQk/e7WNdyRvTeA4sApyZKgSQQoZRMoMTSguV5nT48rUoxivjQdjaKUZaOlG KmviUhbEp+bDudv0Ojsvd9/SVilr6XWjKoUGtR2eDh2rzqQJFd9TAKkwiTJSSplVkiuzecdioYbmX rvzv2p5iSYHPA8KaLBSIwtlYOOFVapyCxO6Cm6UvsdLe4m+i/iOnMwO6Tchnzf/Yin18weCXHJYJD +UB+LgJnSO4WBrKhSdahdJaNrf3MFlqTj+jXwloGfxxfUoFn0LFd5GJ8AkJjTCXXpt1nYvBiFqgAF CJg79M5Zgd9AvOO5+oWFEA==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p5pFL-0003VV-MB; Thu, 15 Dec 2022 09:30:04 -0500 Date: Thu, 15 Dec 2022 16:30:03 +0200 Message-Id: <83359gloyc.fsf@gnu.org> From: Eli Zaretskii To: rudalics@gmx.at In-Reply-To: <837cyslrfr.fsf@gnu.org> (message from Eli Zaretskii on Thu, 15 Dec 2022 15:36:24 +0200) Subject: Re: bug#60015: 29.0.60; multi-line messages truncated in non-selected minibuffer References: <86y1rco5xe.fsf@mail.linkov.net> <83cz8oqybf.fsf@gnu.org> <86zgbsmpta.fsf@mail.linkov.net> <83a63sqvhq.fsf@gnu.org> <865yefw7o5.fsf@mail.linkov.net> <83r0x3nqq6.fsf@gnu.org> <86h6xzrxug.fsf@mail.linkov.net> <86mt7pgkzh.fsf@mail.linkov.net> <32f8777a-2bc3-961c-e773-46451f2b9282@gmx.at> <837cyslrfr.fsf@gnu.org> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 60015 Cc: 60015@debbugs.gnu.org, juri@linkov.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Cc: 60015@debbugs.gnu.org, juri@linkov.net > Date: Thu, 15 Dec 2022 15:36:24 +0200 > From: Eli Zaretskii > > > This is caused by resize_echo_area_exactly in xdisp.c. If you replace > > > > Lisp_Object resize_exactly = (minibuf_level == 0 ? Qt : Qnil); > > > > with > > > > Lisp_Object resize_exactly = Qt; > > > > the echo area gets resized. > > Are you sure this is the reason and the possible fix? AFAICT, resize_echo_area_exactly doesn't get called in this scenario. Which might be part of the problem. From debbugs-submit-bounces@debbugs.gnu.org Thu Dec 15 10:07:54 2022 Received: (at 60015) by debbugs.gnu.org; 15 Dec 2022 15:07:54 +0000 Received: from localhost ([127.0.0.1]:43193 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p5ppy-0007GS-2s for submit@debbugs.gnu.org; Thu, 15 Dec 2022 10:07:54 -0500 Received: from mout.gmx.net ([212.227.15.19]:51211) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p5ppw-0007GK-Ba for 60015@debbugs.gnu.org; Thu, 15 Dec 2022 10:07:53 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.at; s=s31663417; t=1671116863; bh=W95av2ekNrIwxHFMByx+0K8xDR5hed5EGkyVdT0wVmI=; h=X-UI-Sender-Class:Date:Subject:To:Cc:References:From:In-Reply-To; b=HjkAbt2DRoExQjRCen6stcruDqUhRmRsv6GMD6Pjif+2/dUWcoHa8NxeNThjd2A3Q ULV3oACeb8xzzN/TW9uKNqM379+Lvt6iY3hb50ybB/yZ0dLo0wdray2r/nMSqafqSM N7fVmhv3Gc4Iph6aO/mZn0eMlWQkz1QM0A2D080cp1Lc/SG/FT2KddSYI8s06OS3z7 mK8GQSb/0JFvNdvTMAZN0F1QJAFvBdiC3uwBJadML8g025wzEANUdaUYQwMAjKMwoy un8WnWfBYtcuxzsrY0/r/cOaiDHivAOjqJRoaCTamkokjBY1j1mQt//KoAxCvMibvl IxaYj1WP+eLfw== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from [192.168.1.100] ([213.142.96.182]) by mail.gmx.net (mrgmx005 [212.227.17.190]) with ESMTPSA (Nemesis) id 1M8QWA-1p1Pyx2aEi-004UWs; Thu, 15 Dec 2022 16:07:43 +0100 Message-ID: <7fdcca3f-ab71-fb91-990b-d708e585d5b7@gmx.at> Date: Thu, 15 Dec 2022 16:07:42 +0100 MIME-Version: 1.0 Subject: Re: bug#60015: 29.0.60; multi-line messages truncated in non-selected minibuffer Content-Language: en-US To: Eli Zaretskii References: <86y1rco5xe.fsf@mail.linkov.net> <83cz8oqybf.fsf@gnu.org> <86zgbsmpta.fsf@mail.linkov.net> <83a63sqvhq.fsf@gnu.org> <865yefw7o5.fsf@mail.linkov.net> <83r0x3nqq6.fsf@gnu.org> <86h6xzrxug.fsf@mail.linkov.net> <86mt7pgkzh.fsf@mail.linkov.net> <32f8777a-2bc3-961c-e773-46451f2b9282@gmx.at> <837cyslrfr.fsf@gnu.org> <83359gloyc.fsf@gnu.org> From: martin rudalics In-Reply-To: <83359gloyc.fsf@gnu.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K1:mON8GdHkJWYx/UGR5RxS0A8yH3EzbZtryaz1D89B0MxLZMSOwgk 2Ar3Qtbunp9x8SZRK9y5sJuhNrRoQUkJ3lQHhgSXzaxzJoUJKNA+ILqIUhb46RE8RTirun9 VS+peSJ5RS2rNdaJrD9xRA3WA4rLtnxpeAGal0tXCZT7vMgNJssR5unC2qNDNzFg1C9zNpt yYs3edbbEloE1voTRaIWQ== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:oV7LHqg5nYA=;DCuYSJcYyPAuuY1ZNLzAomFZMMM LWRRQsNQnxb4VMyGD9LO8uJdyszXsTdYtju2u1ExRlX6adrSSMGUsGckKNc4adGr3VSRkOVKu YCw3R2X56sTBZ0BVK+2KK90q57DklItggGE+iunuSZ8PAARnhXTJ1d48setQ5bqwgUiAK8nXZ WKtTS1WzRf5BdehUls3BvzzDHljDDZ5WtQkgx8tf1Fthe+Fs0kcn6M/EC2e4WFPs0eupFffaX FJHrQytwby2IR8ebI+EaVmLUPuWN9xOEZlaau+YYP4cHbDGCcIXX8gAW+VBtxp+73CzCx5cPC ijfX/stuT/eOjZFGcXHtowX+feLpctkRCrZe0W9VsCAZ0wfxom0d1K3+zIgfNRB216byfpD+4 8ICHW/cN7aBbcUzu87T+9IGFBWwkHjfLnQmVIyaqPfzbzxwhQUH7jfyJwZgeKESTPcasEDkEN 4nMndQ7uBFefCDFNGQD+z2aZmEfydOQqD384EaqwBQN3J0HHqIowyAuMzlu9phajdzqfj2mPs 4QIs2dnwEjH4TrlJ4J996PNrlsajFIw991mva5gYGd4svP7G8HwI0vglvvI9uMwRZ8BFtNVIn iy9ogsIB6yu9Y71lICHGFjrsvZ+HMSxDMIMPTQXKteKgeUrL2s03nBWbtiX0i6/Maj6TjJbuI LiEsS71Om47kNgfxnb0Q6ABzY2qqbCfa4AMAhoJ5fxxe2t4VEps/j/WLz3QwX1pILfcd4uT+D ur+nfiDH6A+PfDJWeDJnua4YRTok6IZZ2OGuWVg9rCUU3UPb+8fd2O3WE0F1Nwyo804q+0OTk lmKMleeahyCXh5OaAvcyNMWjcEHOC8t1vgbgzm/IGD4DJsCu1bT9s6z/JbLV0l/KOCTsR0KmY nxJ2Su435uZixfErTEwyRCqM+ieabnBYogYoS4/iehmRcvzd8PPJUOnC98KnYGPyG03pWVJ30 sw9Mgg== X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 60015 Cc: 60015@debbugs.gnu.org, juri@linkov.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > Are you sure this is the reason and the possible fix? It's neither. > AFAICT, resize_echo_area_exactly doesn't get called in this scenario. > Which might be part of the problem. What I see is that if (!NILP (echo_area_buffer[0]) || minibuf_level == 0) evaluates to false in echo_area_display. So the problem seems to be with 'set-message-functions' and there I'm lost. martin From debbugs-submit-bounces@debbugs.gnu.org Thu Dec 15 10:12:17 2022 Received: (at 60015) by debbugs.gnu.org; 15 Dec 2022 15:12:17 +0000 Received: from localhost ([127.0.0.1]:43225 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p5puD-0007Jg-FW for submit@debbugs.gnu.org; Thu, 15 Dec 2022 10:12:17 -0500 Received: from mout.gmx.net ([212.227.15.18]:46453) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p5pu9-0007JX-1Y for 60015@debbugs.gnu.org; Thu, 15 Dec 2022 10:12:15 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.at; s=s31663417; t=1671117126; bh=zukq8AJ+Uf5ybxHSKohQRd9yFuPIDnS2LLfaoVfRX/A=; h=X-UI-Sender-Class:Date:Subject:From:To:Cc:References:In-Reply-To; b=pe0qb7OtsZb3aIl7dvhXyP1DBRuuNQ4NiJNa1ot46jCx4D7phBZmVM/tKpvVWuBrN a1HTQKKBX1vEA4nHM56FhX25NV53M0oi7juz5NwJf/l3duaK8HbnlKQED/SRecVs7Y HyLAte3e2yvcDyQTxm6HgrRbUUhWatPWJOnBEOaYMuH4RN4xNd938GznNENdiVIWy3 945KArRTz0dWsufXFSkDPlMNG+BljTeQC5vHjlzAYBCwe3adroMjJ3JVGmLA9Kzf2R TQcL9KGb6JbtZu8GLUzqAShF+nV4+jqB06BKxgpgUOhJ7U6H5f/NX8DyEq1GoO+uF+ pB5OFlU8pw1MQ== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from [192.168.1.100] ([213.142.96.182]) by mail.gmx.net (mrgmx004 [212.227.17.190]) with ESMTPSA (Nemesis) id 1Mk0JW-1odKik33Zw-00kT1d; Thu, 15 Dec 2022 16:12:06 +0100 Message-ID: <3c5cf7d7-d61f-ba61-8b3e-205b57775833@gmx.at> Date: Thu, 15 Dec 2022 16:12:05 +0100 MIME-Version: 1.0 Subject: Re: bug#60015: 29.0.60; multi-line messages truncated in non-selected minibuffer Content-Language: en-US From: martin rudalics To: Eli Zaretskii References: <86y1rco5xe.fsf@mail.linkov.net> <83cz8oqybf.fsf@gnu.org> <86zgbsmpta.fsf@mail.linkov.net> <83a63sqvhq.fsf@gnu.org> <865yefw7o5.fsf@mail.linkov.net> <83r0x3nqq6.fsf@gnu.org> <86h6xzrxug.fsf@mail.linkov.net> <86mt7pgkzh.fsf@mail.linkov.net> <32f8777a-2bc3-961c-e773-46451f2b9282@gmx.at> <837cyslrfr.fsf@gnu.org> <83359gloyc.fsf@gnu.org> <7fdcca3f-ab71-fb91-990b-d708e585d5b7@gmx.at> In-Reply-To: <7fdcca3f-ab71-fb91-990b-d708e585d5b7@gmx.at> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K1:bCri96QOmjNFrtnmKbnyUhP9pHPkXx5RneAfg/sZw/uF/YltvIJ HFbp3ks9pJLacD7Znb1tYexwvcB5aKo3jRWVRrOpQzGkltbHwJQSCI3nYUYvvGr8l6TBKLn 8K+zMJ1SQBEzCR6eqNpvwnXd90ZOFuJSiyBvXNhLE3uHMj4+KDQc4nrPTgW/xBjdcZFJTuJ z7lk3T1L48hV4o0ELaIjQ== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:oHORML2jbCc=;5OFC7br8J0CyEFoRBcordIavgTu 8EhTH+ifaWkR5rTJX7Z88k1ofRJDvFNVodTS28VTBzJCImwOsxmlEXHg63BUnl/mW1kcTYNdH CJI9nf/x6FMSIlh/RY+Rp0DFypS9yvn0/+YukP8rVcCu+ExZKjzMiS/scxHDGDamT4ZlzC1nB I/xuOm5X4PzYUAG87rt1n/4SiV9Ub3Il+2RWaKDmNF+LpPHcRNTlsQWve+53mMpjp0zDR7hob irZV7UyV50dIN92b+tP7Sd/TOcWYrkPj6WiIsN9VqttRVu2ezDhBYslEus9VLPVelrJSgSDQx J0GW3pZLxmsfgmqiEutw+yysOMrap3OkL+nE6jYyG1M+H330btPjrcK3JqJwzaqlX1/U0v61S PHKUcb4GfTp53je/EtS+aqyeH9wXtkm89LvXs3PrhYALtNyhOrlQ1Td8Bm/cU0I6iKFqWIw6O F1Nqalyh6GtWfylJlbO873Gow8QJ6oZ0EJfuQCmLB1LJ4PE1iKkLmet6z7WHtpiOOqkFbI463 ASXzarNrFMme2XXzr75n5vteltSU/gj6y3FRxB0D/uvKTCFs1fsvEjeXEaXsFHLpMfzjiSTvi MqOSCbUW84IeGAQgLgyHlIYqlguIWbYqGdUtEa8VUjYiL8G5QsW1MkAuTJwFstEe20pE85XO3 0TFVU18jzzR6+UMOSKixAotD/I+I10ycDPvxZwYxhE2X+zUpkvRXBdDjdjjo6bwAnogKr8thH pRC90TEtRj5yXjO6Zb7OWziPDMuEOs+jraluhyAWUYqrUH7qgScMlv/wHTIf3LbaAH1FV/cIM QRCnQhpErwz4Bfmi3A2sbWLZv3vJ/grNJw95m4OmTaA1jxupxQdVtdQoGGLmhwu0IweQR5HED FLGCNFKS4FAvwytPj+e5cXstmx0akt3rVW8qwB7LqQeQ+0mZB0EH53ZRWHvbFV7Y9kMCqC6SP kYH05v62RSXqI7UBWZHToXjpLpo= X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 60015 Cc: 60015@debbugs.gnu.org, juri@linkov.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > So the problem seems to be > with 'set-message-functions' and there I'm lost. BTW (setq set-message-functions nil) fixes it here. martin From debbugs-submit-bounces@debbugs.gnu.org Thu Dec 15 10:30:28 2022 Received: (at 60015) by debbugs.gnu.org; 15 Dec 2022 15:30:28 +0000 Received: from localhost ([127.0.0.1]:43314 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p5qBo-0007VH-6H for submit@debbugs.gnu.org; Thu, 15 Dec 2022 10:30:28 -0500 Received: from eggs.gnu.org ([209.51.188.92]:35780) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p5qBm-0007V9-7E for 60015@debbugs.gnu.org; Thu, 15 Dec 2022 10:30:26 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p5qBg-0001iS-Iw; Thu, 15 Dec 2022 10:30:20 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=UmPw78UCXyjIqi7iIVETJ/Cvi4gmAkcHg/XU+opFVcI=; b=AG4mUhAqUnlu 5mAO07DccOvJSZ8WULxNPDtEg6/jQipFs3y1DqMccMfEBNfkKlVcBm3jhyLnIZJY2S9Jew1TgqCqy TJdPhpWK2l+nEov9+sQ1/yJ1u0crvpnx3ExRiYWdUWGcj5dMSDVJtgy7LRWkEOYcm1Nbp0/XyybKl etTb6VMt+8bnhb9syDOMG+Sebs1OwRX34ZYITxayT2P84k8opAnlQpmYMeTze2s0ZnRv6JnZVN+KH oUQngSOCRlY3scLGN7zQwo5nebtoU6eNKEnmO79U67t3NWueOAJqiUldogdqVAciM0o8vDwJbmFPE VlabAHjFKcWpgo6QTRQjZw==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p5qBc-0001Of-IF; Thu, 15 Dec 2022 10:30:17 -0500 Date: Thu, 15 Dec 2022 17:30:13 +0200 Message-Id: <831qp0lm62.fsf@gnu.org> From: Eli Zaretskii To: martin rudalics In-Reply-To: <3c5cf7d7-d61f-ba61-8b3e-205b57775833@gmx.at> (message from martin rudalics on Thu, 15 Dec 2022 16:12:05 +0100) Subject: Re: bug#60015: 29.0.60; multi-line messages truncated in non-selected minibuffer References: <86y1rco5xe.fsf@mail.linkov.net> <83cz8oqybf.fsf@gnu.org> <86zgbsmpta.fsf@mail.linkov.net> <83a63sqvhq.fsf@gnu.org> <865yefw7o5.fsf@mail.linkov.net> <83r0x3nqq6.fsf@gnu.org> <86h6xzrxug.fsf@mail.linkov.net> <86mt7pgkzh.fsf@mail.linkov.net> <32f8777a-2bc3-961c-e773-46451f2b9282@gmx.at> <837cyslrfr.fsf@gnu.org> <83359gloyc.fsf@gnu.org> <7fdcca3f-ab71-fb91-990b-d708e585d5b7@gmx.at> <3c5cf7d7-d61f-ba61-8b3e-205b57775833@gmx.at> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 60015 Cc: 60015@debbugs.gnu.org, juri@linkov.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Thu, 15 Dec 2022 16:12:05 +0100 > From: martin rudalics > Cc: 60015@debbugs.gnu.org, juri@linkov.net > > > So the problem seems to be > > with 'set-message-functions' and there I'm lost. > > BTW > > (setq set-message-functions nil) > > fixes it here. Of course. Because then the temporary-message-shown-as-overlay feature is disabled, and we show messages via xdisp.c code. Like I said: this particular issue happens because in this scenario set-minibuffer-message bypasses the "normal" code in message3_nolog which displays messages "normally". We just add an overlay to the minibuffer, and expect redisplay_window to resize the mini-window as part of its redrawing all the windows. But redisplay_window doesn't. Juri, does the patch below give good results? It's a bit of overkill, since the mini-window usually doesn't need any resizing, but maybe that is not too bad. If it seems to solve the problem, would you please run with this for a couple of weeks, and report back if you see any problems? If there are no problems, I'll then install this on the emacs-29 branch. diff --git a/src/xdisp.c b/src/xdisp.c index d14cd46..45da496 100644 --- a/src/xdisp.c +++ b/src/xdisp.c @@ -19429,6 +19429,13 @@ redisplay_window (Lisp_Object window, bool just_this_one_p) blank_row (w, row, y); goto finish_scroll_bars; } + else if (minibuf_level >= 1) + { + /* We could have a message produced by set-minibuffer-message + displayed in the mini-window as an overlay, so resize the + mini-window if needed. */ + resize_mini_window (w, false); + } clear_glyph_matrix (w->desired_matrix); } From debbugs-submit-bounces@debbugs.gnu.org Thu Dec 15 11:44:33 2022 Received: (at 60015) by debbugs.gnu.org; 15 Dec 2022 16:44:34 +0000 Received: from localhost ([127.0.0.1]:43679 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p5rLV-0008UE-Lz for submit@debbugs.gnu.org; Thu, 15 Dec 2022 11:44:33 -0500 Received: from heytings.org ([95.142.160.155]:59776) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p5rLT-0008U8-77 for 60015@debbugs.gnu.org; Thu, 15 Dec 2022 11:44:32 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=heytings.org; s=20220101; t=1671122670; bh=Ad6CHKaOY8v39Ve3Ro7hnsI0hSld6rO8oBGQL4dgH04=; h=Date:From:To:cc:Subject:In-Reply-To:Message-ID:References:From; b=jIw5QolqlSdElqFXvjOZ8VmWYieg2NNXQKpR8y/JyJ6lpY9uIcTa3RHyg03vZUloN T8i1u9BPqmhu9h3Lu2Wg/onCTCIGX+WgIFsNsmW1IS3glnSstLCb2xXak3HebnppSp A8KnYOSTNcywwxQPkEkK4IyXeJCYKVeKCvxkD+qMzThnmJqhTQJBD2GxVdG5XQuG7i A0TkHZR5epaEQS3sq0yA5crzT2ubvitjLDKzHmes19McZXjjaKKwmra9F2Ta+LxuyP HYO657T4vPKGAqfYQm9/faMKj88n8yELaT1XiYbM7zc2Y04MLz/QdU49XNDslRA08v 3ppKbJSHmMg2A== Date: Thu, 15 Dec 2022 16:44:29 +0000 From: Gregory Heytings To: Juri Linkov Subject: Re: bug#60015: 29.0.60; multi-line messages truncated in non-selected minibuffer In-Reply-To: <86mt7pgkzh.fsf@mail.linkov.net> Message-ID: References: <86y1rco5xe.fsf@mail.linkov.net> <83cz8oqybf.fsf@gnu.org> <86zgbsmpta.fsf@mail.linkov.net> <83a63sqvhq.fsf@gnu.org> <865yefw7o5.fsf@mail.linkov.net> <83r0x3nqq6.fsf@gnu.org> <86h6xzrxug.fsf@mail.linkov.net> <86mt7pgkzh.fsf@mail.linkov.net> MIME-Version: 1.0 Content-Type: text/plain; format=flowed; charset=us-ascii X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 60015 Cc: Eli Zaretskii , 60015@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > > Here is a better test case. Please evaluate: > > (progn > (keymap-global-set "C-c C-c" (lambda () (interactive) (message "abc\ndef"))) > nil) > > Then the bug can be reproduced with just these keys: > > M-x > C-x o > C-c C-c > > Only the top line is displayed in the minibuffer. > Is this not something that can be solved in set-minibuffer-message, like this: diff --git a/lisp/minibuffer.el b/lisp/minibuffer.el index 6e42296e7ba..c10a6401180 100644 --- a/lisp/minibuffer.el +++ b/lisp/minibuffer.el @@ -817,6 +817,11 @@ set-minibuffer-message ;; Make sure we can put-text-property. (copy-sequence message) (concat " [" message "]"))) + (let ((window-lines (window-height minibuf-window)) + (message-lines (length (split-string message "\n")))) + (when (> message-lines window-lines) + (with-selected-window minibuf-window + (enlarge-window (- message-lines window-lines))))) (unless (or (null minibuffer-message-properties) ;; Don't overwrite the face properties the caller has set (text-properties-at 0 message)) From debbugs-submit-bounces@debbugs.gnu.org Thu Dec 15 12:03:40 2022 Received: (at 60015) by debbugs.gnu.org; 15 Dec 2022 17:03:40 +0000 Received: from localhost ([127.0.0.1]:43785 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p5re0-0002dk-7l for submit@debbugs.gnu.org; Thu, 15 Dec 2022 12:03:40 -0500 Received: from eggs.gnu.org ([209.51.188.92]:40254) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p5rdy-0002de-G5 for 60015@debbugs.gnu.org; Thu, 15 Dec 2022 12:03:38 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p5rds-0003Lf-Kr; Thu, 15 Dec 2022 12:03:32 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=548uSK5WCbb9qjKzmdFwAw0KB6BRItIdst1gplySRQI=; b=SKEAgHb7ZyVr nPteI03fbtUICFNAdmafOK5uHsLQ8xmKkuwJVedth8zzk/v2Ta+9k+M+lzI8auXpoMejDdJSF2Qef un2fiHVeyITv6nfGOeCeTgk0Ilpa3bNbY9GeoCnKQrTow9z9l1SgGfq9Fw4CcQM76WpzFYcv7J5Z2 Ba/KV77Dvpt4zCsDix9lsTLxQo3Gi6CxSfRS8sN8f8LqzEouAoIFOZAWw1twm5VnCDAxzTTr+WLg7 S/VgFuY4FypwAsptJSxoNxByzZgwIn2X3OtmDksaqPQo4XkjU1GrL/qVJoQK0E7z2gpBAABFr0gm4 rZDUosCdYp1XIsLANHLYBg==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p5rdq-0004sl-OI; Thu, 15 Dec 2022 12:03:32 -0500 Date: Thu, 15 Dec 2022 19:03:30 +0200 Message-Id: <83v8mck3a5.fsf@gnu.org> From: Eli Zaretskii To: Gregory Heytings In-Reply-To: (message from Gregory Heytings on Thu, 15 Dec 2022 16:44:29 +0000) Subject: Re: bug#60015: 29.0.60; multi-line messages truncated in non-selected minibuffer References: <86y1rco5xe.fsf@mail.linkov.net> <83cz8oqybf.fsf@gnu.org> <86zgbsmpta.fsf@mail.linkov.net> <83a63sqvhq.fsf@gnu.org> <865yefw7o5.fsf@mail.linkov.net> <83r0x3nqq6.fsf@gnu.org> <86h6xzrxug.fsf@mail.linkov.net> <86mt7pgkzh.fsf@mail.linkov.net> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 60015 Cc: 60015@debbugs.gnu.org, juri@linkov.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Thu, 15 Dec 2022 16:44:29 +0000 > From: Gregory Heytings > cc: Eli Zaretskii , 60015@debbugs.gnu.org > > Is this not something that can be solved in set-minibuffer-message, like > this: > > diff --git a/lisp/minibuffer.el b/lisp/minibuffer.el > index 6e42296e7ba..c10a6401180 100644 > --- a/lisp/minibuffer.el > +++ b/lisp/minibuffer.el > @@ -817,6 +817,11 @@ set-minibuffer-message > ;; Make sure we can put-text-property. > (copy-sequence message) > (concat " [" message "]"))) > + (let ((window-lines (window-height minibuf-window)) > + (message-lines (length (split-string message "\n")))) > + (when (> message-lines window-lines) > + (with-selected-window minibuf-window > + (enlarge-window (- message-lines window-lines))))) > (unless (or (null minibuffer-message-properties) > ;; Don't overwrite the face properties the caller has set > (text-properties-at 0 message)) This won't catch the case of a single very long line (which wraps to produce several screen lines). Also, unconditionally enlarging the mini-window is not a good idea because it might already be tall enough. Try the above in the recipe posted by Juri, but then type "C-c C-c" several times -- doesn't it keep enlarging the mini-window with each "C-c C-c"? From debbugs-submit-bounces@debbugs.gnu.org Thu Dec 15 12:39:51 2022 Received: (at 60015) by debbugs.gnu.org; 15 Dec 2022 17:39:51 +0000 Received: from localhost ([127.0.0.1]:43948 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p5sD1-000308-C6 for submit@debbugs.gnu.org; Thu, 15 Dec 2022 12:39:51 -0500 Received: from relay9-d.mail.gandi.net ([217.70.183.199]:56181) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p5sCx-0002zh-9q for 60015@debbugs.gnu.org; Thu, 15 Dec 2022 12:39:47 -0500 Received: (Authenticated sender: juri@linkov.net) by mail.gandi.net (Postfix) with ESMTPSA id B3E03FF805; Thu, 15 Dec 2022 17:39:40 +0000 (UTC) From: Juri Linkov To: Eli Zaretskii Subject: Re: bug#60015: 29.0.60; multi-line messages truncated in non-selected minibuffer In-Reply-To: <831qp0lm62.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 15 Dec 2022 17:30:13 +0200") Organization: LINKOV.NET References: <86y1rco5xe.fsf@mail.linkov.net> <83cz8oqybf.fsf@gnu.org> <86zgbsmpta.fsf@mail.linkov.net> <83a63sqvhq.fsf@gnu.org> <865yefw7o5.fsf@mail.linkov.net> <83r0x3nqq6.fsf@gnu.org> <86h6xzrxug.fsf@mail.linkov.net> <86mt7pgkzh.fsf@mail.linkov.net> <32f8777a-2bc3-961c-e773-46451f2b9282@gmx.at> <837cyslrfr.fsf@gnu.org> <83359gloyc.fsf@gnu.org> <7fdcca3f-ab71-fb91-990b-d708e585d5b7@gmx.at> <3c5cf7d7-d61f-ba61-8b3e-205b57775833@gmx.at> <831qp0lm62.fsf@gnu.org> Date: Thu, 15 Dec 2022 19:35:43 +0200 Message-ID: <86a63oa8a0.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 60015 Cc: martin rudalics , 60015@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > Juri, does the patch below give good results? It's a bit of overkill, > since the mini-window usually doesn't need any resizing, but maybe > that is not too bad. > > If it seems to solve the problem, would you please run with this for a > couple of weeks, and report back if you see any problems? If there > are no problems, I'll then install this on the emacs-29 branch. I'll test it for a while. From debbugs-submit-bounces@debbugs.gnu.org Thu Dec 15 12:39:55 2022 Received: (at 60015) by debbugs.gnu.org; 15 Dec 2022 17:39:55 +0000 Received: from localhost ([127.0.0.1]:43951 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p5sD4-00030K-L6 for submit@debbugs.gnu.org; Thu, 15 Dec 2022 12:39:55 -0500 Received: from relay7-d.mail.gandi.net ([217.70.183.200]:58599) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p5sD2-000300-KJ for 60015@debbugs.gnu.org; Thu, 15 Dec 2022 12:39:53 -0500 Received: (Authenticated sender: juri@linkov.net) by mail.gandi.net (Postfix) with ESMTPSA id 9EB7920002; Thu, 15 Dec 2022 17:39:43 +0000 (UTC) From: Juri Linkov To: Eli Zaretskii Subject: Re: bug#60015: 29.0.60; multi-line messages truncated in non-selected minibuffer In-Reply-To: <83v8mck3a5.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 15 Dec 2022 19:03:30 +0200") Organization: LINKOV.NET References: <86y1rco5xe.fsf@mail.linkov.net> <83cz8oqybf.fsf@gnu.org> <86zgbsmpta.fsf@mail.linkov.net> <83a63sqvhq.fsf@gnu.org> <865yefw7o5.fsf@mail.linkov.net> <83r0x3nqq6.fsf@gnu.org> <86h6xzrxug.fsf@mail.linkov.net> <86mt7pgkzh.fsf@mail.linkov.net> <83v8mck3a5.fsf@gnu.org> Date: Thu, 15 Dec 2022 19:37:03 +0200 Message-ID: <861qp0a87s.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 60015 Cc: Gregory Heytings , 60015@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) >> Is this not something that can be solved in set-minibuffer-message, like >> this: >> >> diff --git a/lisp/minibuffer.el b/lisp/minibuffer.el >> index 6e42296e7ba..c10a6401180 100644 >> --- a/lisp/minibuffer.el >> +++ b/lisp/minibuffer.el >> @@ -817,6 +817,11 @@ set-minibuffer-message >> ;; Make sure we can put-text-property. >> (copy-sequence message) >> (concat " [" message "]"))) >> + (let ((window-lines (window-height minibuf-window)) >> + (message-lines (length (split-string message "\n")))) >> + (when (> message-lines window-lines) >> + (with-selected-window minibuf-window >> + (enlarge-window (- message-lines window-lines))))) >> (unless (or (null minibuffer-message-properties) >> ;; Don't overwrite the face properties the caller has set >> (text-properties-at 0 message)) > > This won't catch the case of a single very long line (which wraps to > produce several screen lines). Testing shows that it doesn't handle wrapped lines. > Also, unconditionally enlarging the mini-window is not a good idea > because it might already be tall enough. Try the above in the recipe > posted by Juri, but then type "C-c C-c" several times -- doesn't it > keep enlarging the mini-window with each "C-c C-c"? But OTOH it doesn't keep enlarging the mini-window with each "C-c C-c". From debbugs-submit-bounces@debbugs.gnu.org Thu Dec 15 16:52:38 2022 Received: (at 60015) by debbugs.gnu.org; 15 Dec 2022 21:52:38 +0000 Received: from localhost ([127.0.0.1]:45140 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p5w9e-0004Gy-5P for submit@debbugs.gnu.org; Thu, 15 Dec 2022 16:52:38 -0500 Received: from heytings.org ([95.142.160.155]:60154) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p5w9a-0004Gm-VF for 60015@debbugs.gnu.org; Thu, 15 Dec 2022 16:52:36 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=heytings.org; s=20220101; t=1671141153; bh=MmmRlUuMpJX5bJMl2FE4T8Nt0nagUX8EoljOkfQ9cB0=; h=Date:From:To:cc:Subject:In-Reply-To:Message-ID:References:From; b=0ct6U4w+n32M6smxx7Z12olVad+3ZyW2QmmsSqffGUGogeGJIHTSbdoa0VceV/943 Lmj97UqI2iJHJ5rDJX3zXqw9QR5E2x0qolY/jOF0OQ40weqA9xD7UMROMpJ9jZ0jFp U2Tn//Rf0pvOywHekdi/u/5JTp+CpQ4oFofxRf5LaA+BjRQHooBaA7rUacrzvkmi39 XeH9VqdIZjBtJJjy6WFyOcb4lNI7MUh5K/FR/13P2B0xSlSei5vQpUR8VEIxqahoJC wnP9cgaJ66JPIvfBY/XtzxzLm1DVscVUwY0SvDkAphSUlXou0p3IPT29KYNz5I3L/V mFLRJ1R/jg9yA== Date: Thu, 15 Dec 2022 21:52:33 +0000 From: Gregory Heytings To: Juri Linkov Subject: Re: bug#60015: 29.0.60; multi-line messages truncated in non-selected minibuffer In-Reply-To: <861qp0a87s.fsf@mail.linkov.net> Message-ID: References: <86y1rco5xe.fsf@mail.linkov.net> <83cz8oqybf.fsf@gnu.org> <86zgbsmpta.fsf@mail.linkov.net> <83a63sqvhq.fsf@gnu.org> <865yefw7o5.fsf@mail.linkov.net> <83r0x3nqq6.fsf@gnu.org> <86h6xzrxug.fsf@mail.linkov.net> <86mt7pgkzh.fsf@mail.linkov.net> <83v8mck3a5.fsf@gnu.org> <861qp0a87s.fsf@mail.linkov.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 60015 Cc: Eli Zaretskii , 60015@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) >>> + (let ((window-lines (window-height minibuf-window)) >>> + (message-lines (length (split-string message "\n")))) >>> + (when (> message-lines window-lines) >>> + (with-selected-window minibuf-window >>> + (enlarge-window (- message-lines window-lines))))) >> >> This won't catch the case of a single very long line (which wraps to >> produce several screen lines). > > Testing shows that it doesn't handle wrapped lines. > Indeed, but that wasn't part of your problem statement ;-) From debbugs-submit-bounces@debbugs.gnu.org Sat Dec 17 13:06:51 2022 Received: (at 60015) by debbugs.gnu.org; 17 Dec 2022 18:06:51 +0000 Received: from localhost ([127.0.0.1]:57243 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p6baF-0008QC-E0 for submit@debbugs.gnu.org; Sat, 17 Dec 2022 13:06:51 -0500 Received: from relay4-d.mail.gandi.net ([217.70.183.196]:45133) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p6baD-0008Q5-UQ for 60015@debbugs.gnu.org; Sat, 17 Dec 2022 13:06:50 -0500 Received: (Authenticated sender: juri@linkov.net) by mail.gandi.net (Postfix) with ESMTPSA id 1E2EAE0002; Sat, 17 Dec 2022 18:06:42 +0000 (UTC) From: Juri Linkov To: Eli Zaretskii Subject: Re: bug#60015: 29.0.60; multi-line messages truncated in non-selected minibuffer In-Reply-To: <831qp0lm62.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 15 Dec 2022 17:30:13 +0200") Organization: LINKOV.NET References: <86y1rco5xe.fsf@mail.linkov.net> <83cz8oqybf.fsf@gnu.org> <86zgbsmpta.fsf@mail.linkov.net> <83a63sqvhq.fsf@gnu.org> <865yefw7o5.fsf@mail.linkov.net> <83r0x3nqq6.fsf@gnu.org> <86h6xzrxug.fsf@mail.linkov.net> <86mt7pgkzh.fsf@mail.linkov.net> <32f8777a-2bc3-961c-e773-46451f2b9282@gmx.at> <837cyslrfr.fsf@gnu.org> <83359gloyc.fsf@gnu.org> <7fdcca3f-ab71-fb91-990b-d708e585d5b7@gmx.at> <3c5cf7d7-d61f-ba61-8b3e-205b57775833@gmx.at> <831qp0lm62.fsf@gnu.org> Date: Sat, 17 Dec 2022 19:39:49 +0200 Message-ID: <868rj6ylne.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 60015 Cc: martin rudalics , 60015@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > Juri, does the patch below give good results? It's a bit of overkill, > since the mini-window usually doesn't need any resizing, but maybe > that is not too bad. > > If it seems to solve the problem, would you please run with this for a > couple of weeks, and report back if you see any problems? If there > are no problems, I'll then install this on the emacs-29 branch. > > diff --git a/src/xdisp.c b/src/xdisp.c > index d14cd46..45da496 100644 > --- a/src/xdisp.c > +++ b/src/xdisp.c > @@ -19429,6 +19429,13 @@ redisplay_window (Lisp_Object window, bool just_this_one_p) > blank_row (w, row, y); > goto finish_scroll_bars; > } > + else if (minibuf_level >= 1) > + { > + /* We could have a message produced by set-minibuffer-message > + displayed in the mini-window as an overlay, so resize the > + mini-window if needed. */ > + resize_mini_window (w, false); > + } I tested it for a while and see no problems with it. From debbugs-submit-bounces@debbugs.gnu.org Sat Dec 17 13:45:44 2022 Received: (at 60015-done) by debbugs.gnu.org; 17 Dec 2022 18:45:44 +0000 Received: from localhost ([127.0.0.1]:57402 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p6cBs-0000Mc-Cu for submit@debbugs.gnu.org; Sat, 17 Dec 2022 13:45:44 -0500 Received: from eggs.gnu.org ([209.51.188.92]:47884) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p6cBr-0000MS-8y for 60015-done@debbugs.gnu.org; Sat, 17 Dec 2022 13:45:43 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p6cBf-0007bE-TI; Sat, 17 Dec 2022 13:45:37 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=Pr4JtBvge+zN64fRmJSEtzD4ZnKxPnjVRgQvouuGP4c=; b=To3Vza7STCLy SKlPNdFAmSwNTO07Rm7XEgMBKYNfgylzHEtXCtsuwqlvkkHiTzJfQvV0K4CWPK/DGRFvqGYSZSJPs VV7Y1uG1/NUU49G6yvbW7EdxbLCLUWLA3Dd3Nv1wvzm3hS7+P4pTZhV720WDA4IKgN/xd7X6Ornfu 2d7quxiU/ikT8/njtof5/UNfh3t6hVqDdAbBI7V3HPLMgQgewAT/q1M/o1nnYzXG+U0hm/N+px7jq JhYzTjvePo/yqa6jtnmK90M498NpzVqGOCgbdjt+ZSAYD36KodT9tRI2u295WesrurUGbHqlwivF7 1oq0WpFWERt08EeEbAO1rg==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p6cBc-0003wD-FE; Sat, 17 Dec 2022 13:45:31 -0500 Date: Sat, 17 Dec 2022 20:45:34 +0200 Message-Id: <837cyphnsh.fsf@gnu.org> From: Eli Zaretskii To: Juri Linkov In-Reply-To: <868rj6ylne.fsf@mail.linkov.net> (message from Juri Linkov on Sat, 17 Dec 2022 19:39:49 +0200) Subject: Re: bug#60015: 29.0.60; multi-line messages truncated in non-selected minibuffer References: <86y1rco5xe.fsf@mail.linkov.net> <83cz8oqybf.fsf@gnu.org> <86zgbsmpta.fsf@mail.linkov.net> <83a63sqvhq.fsf@gnu.org> <865yefw7o5.fsf@mail.linkov.net> <83r0x3nqq6.fsf@gnu.org> <86h6xzrxug.fsf@mail.linkov.net> <86mt7pgkzh.fsf@mail.linkov.net> <32f8777a-2bc3-961c-e773-46451f2b9282@gmx.at> <837cyslrfr.fsf@gnu.org> <83359gloyc.fsf@gnu.org> <7fdcca3f-ab71-fb91-990b-d708e585d5b7@gmx.at> <3c5cf7d7-d61f-ba61-8b3e-205b57775833@gmx.at> <831qp0lm62.fsf@gnu.org> <868rj6ylne.fsf@mail.linkov.net> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 60015-done Cc: rudalics@gmx.at, 60015-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Juri Linkov > Cc: martin rudalics , 60015@debbugs.gnu.org > Date: Sat, 17 Dec 2022 19:39:49 +0200 > > > Juri, does the patch below give good results? It's a bit of overkill, > > since the mini-window usually doesn't need any resizing, but maybe > > that is not too bad. > > > > If it seems to solve the problem, would you please run with this for a > > couple of weeks, and report back if you see any problems? If there > > are no problems, I'll then install this on the emacs-29 branch. > > > > diff --git a/src/xdisp.c b/src/xdisp.c > > index d14cd46..45da496 100644 > > --- a/src/xdisp.c > > +++ b/src/xdisp.c > > @@ -19429,6 +19429,13 @@ redisplay_window (Lisp_Object window, bool just_this_one_p) > > blank_row (w, row, y); > > goto finish_scroll_bars; > > } > > + else if (minibuf_level >= 1) > > + { > > + /* We could have a message produced by set-minibuffer-message > > + displayed in the mini-window as an overlay, so resize the > > + mini-window if needed. */ > > + resize_mini_window (w, false); > > + } > > I tested it for a while and see no problems with it. Thanks, installed on the emacs-29 branch, and closing this bug. From unknown Mon Jun 16 23:41:48 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sun, 15 Jan 2023 12:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator