GNU bug report logs - #60001
[PATCH] Improve completion of treesit-check-indent command

Previous Next

Full log

Message #16 received at 60001 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Yuan Fu <casouri <at> gmail.com>
Cc: 60001 <at> debbugs.gnu.org, mardani29 <at> yahoo.es
Subject: Re: bug#60001: [PATCH] Improve completion of treesit-check-indent 
 command
Date: Sun, 08 Jan 2023 13:53:33 +0200

> From: Yuan Fu <casouri <at> gmail.com>
> Date: Sat, 7 Jan 2023 15:13:54 -0800
> Cc: Daniel Martín <mardani29 <at> yahoo.es>,
>  60001 <at> debbugs.gnu.org
> 
> 
> Eli Zaretskii <eliz <at> gnu.org> writes:
> 
> >> Date: Mon, 12 Dec 2022 11:53:00 +0100
> >> From:  Daniel Martín via "Bug reports for GNU Emacs,
> >>  the Swiss army knife of text editors" <bug-gnu-emacs <at> gnu.org>
> >> 
> >> The treesit-check-indent command is not really related to Tree-sitter
> >> and could be in a more general place than treesit.el.  WDYT?
> >
> > I agree, but then we'd need a definition for it that doesn't need
> > tree-sitter support.  Is that easy to provide?
> >
> >> In any case, I have a patch to improve this command a bit by offering
> >> more accurate completion for major modes, not Emacs commands.  I have
> >> also tried to improve its documentation a bit.
> >
> > How about a read-major-mode function in subr.el?
> >
> > But I think all these generalizations and improvements should go to
> > master.  On the release branch, I'd prefer to leave
> > treesit-check-indent alone.
> 
> Has this patch been pushed to master?

No, I don't think so.

> Should I close this report?

If you agree with the change, please install it.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.