From unknown Tue Jun 17 20:18:58 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#60001 <60001@debbugs.gnu.org> To: bug#60001 <60001@debbugs.gnu.org> Subject: Status: [PATCH] Improve completion of treesit-check-indent command Reply-To: bug#60001 <60001@debbugs.gnu.org> Date: Wed, 18 Jun 2025 03:18:58 +0000 retitle 60001 [PATCH] Improve completion of treesit-check-indent command reassign 60001 emacs submitter 60001 Daniel Mart=C3=ADn severity 60001 wishlist tag 60001 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Mon Dec 12 05:53:13 2022 Received: (at submit) by debbugs.gnu.org; 12 Dec 2022 10:53:13 +0000 Received: from localhost ([127.0.0.1]:52171 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p4gQr-00007a-5i for submit@debbugs.gnu.org; Mon, 12 Dec 2022 05:53:13 -0500 Received: from lists.gnu.org ([209.51.188.17]:45274) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p4gQp-00007T-NM for submit@debbugs.gnu.org; Mon, 12 Dec 2022 05:53:12 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p4gQn-0002oa-Sg for bug-gnu-emacs@gnu.org; Mon, 12 Dec 2022 05:53:11 -0500 Received: from sonic306-19.consmr.mail.ir2.yahoo.com ([77.238.176.205]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1p4gQl-0001W2-VD for bug-gnu-emacs@gnu.org; Mon, 12 Dec 2022 05:53:09 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.es; s=s2048; t=1670842385; bh=/E0fB+wCaVnqvwIC4V654F0LHFNrBKBz3fd0K+xBFXg=; h=From:To:Subject:Date:References:From:Subject:Reply-To; b=TB/xgjffDWRx7No8Y9gTIS118CxjNN2e4QgM+CvKmCKCOy4Rjh4ZvU3ziTMTEy6I2Pl5PPiUwSExchch4jh8teA6Bk1A01/pE3OVwA4oEvTDfzzUqF1JfE3Cl45Dg0n8JDofwuc+bw+MwUU4uxqW3HdyslkJNMKm+AMVKphAHzb3Xc0BAUoeGLOtWY1dr4Sv7Jv0hEkroYICBWBVASJI0gjdlhc2F+0vxlgmrpKRcSzmgsc9uIGlvgKv0Cb54MlVNdZzjYPh+21tW/kyclys/oMrjJIRXdL6H+uXXHcF281kQkzOs2wXp4J0WbZ6es0COZYOjeuG2EwV2MJRdiLwYQ== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1670842385; bh=gmDj+8cMCJUlnLJcvb8vO5VckSXfEbACkimCv3Y0UxD=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=L9RM4/0fbEgIf3pNYoRzpa5YD87rGcxSelELltBz16tgXT2eroJPFcJtmeX8+HgkIwHDOjOX1uLTxtZFYiNQwRCOAhD7XO+E7YYhZ3VmHDsjgnw1mPD9qptQ4j4k1P342PwbrUSwRz8q20I80J4EcdApaTATjOpn8pydGg6EfOmgWD8Iqr4FJ5/pUBiszcpt5Xb0zx4PvDH7OSLAKyOeyiYXFS/p/inYjckaffNp9XBs3+yyQ56P16sOtf9EhbG8V/bXqkXhIGGfG1fNACnISW6NSS+ecOxayMT+doyyaNOK7lFMEDLCBJucOnzBmo48pKcS6s1hG+2U9GLdCmeCzQ== X-YMail-OSG: 6C7Z9aoVM1k2DjNA2xrhWXWmohQOswlhH.bimdj7fFJdgDb4KfQdqM4NYlmhORI WqN2i7Xs2CdDuK4uQhYQqR3PZjipwgYBnjPPZLcFXz0B86_gY5p0u2X.aZ26rnBlRti6aj65zsNq nh6YOaiYE0sCxM75s14fRgHMxJkSVMcGvglSoaTyCNU4dL2tvrjhvygwxDo1PInqEDd1cmm2GGBC R6FjYimoUxdKtOMEfg1fAqipNS.1PXzgVvfs7E1ULUV0Mm0NSGNZ_6dGqI9zoQr9s5TVAVScXWdX lZMteVEmtFKqC524SN38u153gTA1MbHAQA4rs2Cy8q7TlAH3s0nGubf1ruNjbxMUs7qxi.QbXmo4 HLe6XEnilzZ2k7NKBH0y9icQj0peRXeS20wTseJ1n0LEUkI5zGNrrdd4ZlRuwR75Ucl22fUqtDrH JS3Ovhxwik1owI1Poyup8M0hSII0V1GJe_DcTLcrmNV3fNghMO7LtUdMous2f48xH_qcQIR1ftoO .Pw7LeBkesgz2LU6pFTCLTOCN8dvCACIEZnwOQcLg_u9_l3lAo6Fn1tZps9HbcoV6iSisvV.1jA2 5yPiTNane4Iz6ErWnICVd2H8oonVZl65jB9ZdmdrVoVNb7W9laCctwXilfIhJ5plJaTDwxsLrF0O Ry88m5UC2QPpajFwt4UkcD_H_7ZF9wBwvYj4HASSd6GolQY2bOikzwjmMeYwNkiReKygCaOzaAIg FZYWGsMDbPopNnKJUUapeI6A7k0tQojrmUxQ.ed_4SujDUM9TsmXbOufM_avWeuyZ_3oFopjvVEe kJddCKI2Cx4I._W0aL1Yq2GbDEfcPgY1eHc4ZxLC4abxhgBFZDXwlWUAbtMihVeUSWyUFx0L5bYV Oj9sPiRxAKP6mVAimTHZPNg0I5tEFDUMAajwNRoQidbv3sLItH6f0Ce0tPxOXrEwsJp4zRqQV1Yb JC30gb4_AwBTCxXj9adW.KbTfkCoxnEWDb6wkCU0_EeDIeUoRmZRNABMKgx.Kpi_uaDk8GuSG8t2 iiqkQ0F_TTLRdkxe4p9KFp.aIeeTUBrEffp7V2TMISeFznq7.pDnVN21Kw15H3DIGvYDaRrbhUS4 t.sxfeUDj8uIMHwRasyvOgY34sHkckYwKPna0PlmKc_CqSjYNWgXHlN3KjewVTsbnPy19vrorw4z KVmXEx45fbSBPddX.b9YsqbOfc8a4xnMDDhBuU36M3uo1tj.W0lj_2jSWn41or38zpz_CeS8C9pg hVBmXVfNxlpsU5g_K7nnmNThFOBUXsfqn.xTNZ9BLc8ncagAfAsVbBwLJkB_TYfELtp5SYzcOaja j4Bur7brG90w0E8RpL0C6SQCKmN7H2wYyU.iSd74tz.8qbDRiq.kM9Qvri14vTcurBNzo0L_WWL0 VylANjPg9T14rUe7vTu3_kARUF4gHpmRmcgsXrppYOQ..Aii_GckieJ2nfekK0S5ugdzPizHCAil Pf3wLdfVcRFWQIAHY6FtuAiEZF83hfxLhH30YHQkDQxbLPnPlv8CvvxkmZ0iknoK2NrUKyXrNn2a spwpTGSC7Kj9EDFNgreP0mUn2cIMAHO4pSt_5v_xbNzoO4oDbukEN9vyQlyAMZYDjN.dWktEH2aA vWnu_js0PCCfj4NMUBpN3F0_1Rp2LRCab73YbH6VZhAUGAOs46J3LSRk50xrTxb_T2I.weCpoTKp 2XPHpJgUGfHOHRWAxUI.Q7jloQiueZZti5UArWp9VozrI638vfdqDb4aZY.H5OGlLktaAylvFDRa V.Bbvd857mV__06RJiNXcJ.jdfieGIP9kmTHvqyqL_DZM24P1AREalFitEv44iv.gamlPHqjCDv9 u3H_IKwiru3WZyqc7dL9ZAdD2MUWvqcPCs6CslkvcmtMzC0JWdU3sRynU9.QI9fEuURWZR1pu_k6 V0TDD.o18F7TkIdN3jCe.6zXVptVlcLDpDINAReuycdNhTUZ2Jf9wEtRvzbi_FrsgZ35GcweOorg sZCIAvj2fy52wsLwi3ajl96YuZAjh5.SAgfKIrHUfeom0F3dXB7uhFK8TayMCBEuzijh44cUXVfo s6Yu4QxoyVDaDlGE9e9924ONBOGN_B5JH62zZBZ6kgUytjxO1vvda.jTR7tKWj.YrfpW2ULLqlMW hnxwCeoSB7PA2HFKzht.89rXt02ZbER9XPZILDtHK3e8LLsffBmLvfa.ZQSlMp9RfX_F5X12fcuI pF1PsnZ3F5_yJhp2kQKRgP25qp_Ao X-Sonic-MF: Received: from sonic.gate.mail.ne1.yahoo.com by sonic306.consmr.mail.ir2.yahoo.com with HTTP; Mon, 12 Dec 2022 10:53:05 +0000 Received: by hermes--production-ir2-5795fc58c8-7hl5q (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID bb74469f613b55ce5d2ae83368092076; Mon, 12 Dec 2022 10:53:02 +0000 (UTC) From: =?utf-8?Q?Daniel_Mart=C3=ADn?= To: bug-gnu-emacs@gnu.org Subject: [PATCH] Improve completion of treesit-check-indent command Date: Mon, 12 Dec 2022 11:53:00 +0100 Message-ID: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" References: X-Mailer: WebService/1.1.20926 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo Content-Length: 2597 Received-SPF: pass client-ip=77.238.176.205; envelope-from=mardani29@yahoo.es; helo=sonic306-19.consmr.mail.ir2.yahoo.com X-Spam_score_int: -17 X-Spam_score: -1.8 X-Spam_bar: - X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) --=-=-= Content-Type: text/plain Tags: patch The treesit-check-indent command is not really related to Tree-sitter and could be in a more general place than treesit.el. WDYT? In any case, I have a patch to improve this command a bit by offering more accurate completion for major modes, not Emacs commands. I have also tried to improve its documentation a bit. Thanks. --=-=-= Content-Type: text/patch Content-Disposition: attachment; filename=0001-Improve-completion-of-treesit-check-indent-command.patch >From e6699c1671f3f13fa7d98ef958c0159e80aa2645 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Daniel=20Mart=C3=ADn?= Date: Mon, 12 Dec 2022 11:33:01 +0100 Subject: [PATCH] Improve completion of treesit-check-indent command * lisp/treesit.el (treesit--read-major-mode): Helper function to provide completion for most major modes. (treesit-check-indent): Use the new interactive spec and improve the docstring. --- lisp/treesit.el | 26 +++++++++++++++++++++----- 1 file changed, 21 insertions(+), 5 deletions(-) diff --git a/lisp/treesit.el b/lisp/treesit.el index 85154d0d1c..de18796628 100644 --- a/lisp/treesit.el +++ b/lisp/treesit.el @@ -1469,12 +1469,28 @@ treesit-simple-indent (message "No matched rule")) (cons nil nil)))))) -(defun treesit-check-indent (mode) - "Check current buffer's indentation against a major mode MODE. +(defun treesit--read-major-mode () + "Read a major mode using completion. +Helper function to use in the `interactive' spec of `treesit-check-indent'." + (let* ((default (and (symbolp major-mode) (symbol-name major-mode))) + (mode + (completing-read + (format-prompt "Target major mode" default) + obarray + (lambda (sym) + (and (string-match-p "-mode\\'" (symbol-name sym)) + (not (or (memq sym minor-mode-list) + (string-match-p "-minor-mode\\'" + (symbol-name sym)))))) + nil nil nil default nil))) + (cond + ((equal mode "nil") nil) + ((and (stringp mode) (fboundp (intern mode))) (intern mode)) + (t mode)))) -Pop up a diff buffer showing the difference. Correct -indentation (target) is in green, current indentation is in red." - (interactive "CTarget major mode: ") +(defun treesit-check-indent (mode) + "Compare the current buffer with how major mode MODE would indent it." + (interactive (list (treesit--read-major-mode))) (let ((source-buf (current-buffer))) (with-temp-buffer (insert-buffer-substring source-buf) -- 2.34.1 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Mon Dec 12 09:00:33 2022 Received: (at 60001) by debbugs.gnu.org; 12 Dec 2022 14:00:33 +0000 Received: from localhost ([127.0.0.1]:53123 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p4jM8-0007CQ-RY for submit@debbugs.gnu.org; Mon, 12 Dec 2022 09:00:33 -0500 Received: from eggs.gnu.org ([209.51.188.92]:43064) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p4jM7-0007CI-6i for 60001@debbugs.gnu.org; Mon, 12 Dec 2022 09:00:31 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p4jM0-0000Im-TP; Mon, 12 Dec 2022 09:00:25 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=n0/vs1PY0xzjlwaFwoshadFXTJqCae69OquRCP6NNsI=; b=m7zsfOfEZ7dQDFHn+em8 1ATKemPRG/Q/y/E6gHlpwdurdizKEoOIGUh/OJcDbtqnEShUngw8Dqtj/yxw4FiMuzwGUFjo8WOCY XAE5ahMpaB5bzrrIIel/R+2pZWnNbVCPaE+7BiwKSphhiJnzsa+wuh5ZFuz8FTj6e7OXMjyOUB6vP 0w8G6O0NQ+Qbn4kN0I13F+AUdVZg7TXt0aYSkXjF03FLFtfKhohsaxnvHmI2ouz31j5GH6tRYJfyV brD4CoLeCD/mxdGnjlZm0lLGdX5AnXSFd3BooSFr/XvVPTOg2qNwAjrlmFS0HKzc3iXWfMymobNDG W9o+5pi8qQSXMw==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p4jLy-00082N-Rm; Mon, 12 Dec 2022 09:00:23 -0500 Date: Mon, 12 Dec 2022 16:00:24 +0200 Message-Id: <838rjcsow7.fsf@gnu.org> From: Eli Zaretskii To: Daniel =?iso-8859-1?Q?Mart=EDn?= In-Reply-To: (bug-gnu-emacs@gnu.org) Subject: Re: bug#60001: [PATCH] Improve completion of treesit-check-indent command References: MIME-version: 1.0 Content-type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 60001 Cc: 60001@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Mon, 12 Dec 2022 11:53:00 +0100 > From: Daniel Martín via "Bug reports for GNU Emacs, > the Swiss army knife of text editors" > > The treesit-check-indent command is not really related to Tree-sitter > and could be in a more general place than treesit.el. WDYT? I agree, but then we'd need a definition for it that doesn't need tree-sitter support. Is that easy to provide? > In any case, I have a patch to improve this command a bit by offering > more accurate completion for major modes, not Emacs commands. I have > also tried to improve its documentation a bit. How about a read-major-mode function in subr.el? But I think all these generalizations and improvements should go to master. On the release branch, I'd prefer to leave treesit-check-indent alone. From debbugs-submit-bounces@debbugs.gnu.org Mon Dec 12 19:48:02 2022 Received: (at control) by debbugs.gnu.org; 13 Dec 2022 00:48:02 +0000 Received: from localhost ([127.0.0.1]:56582 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p4tSk-0000vk-80 for submit@debbugs.gnu.org; Mon, 12 Dec 2022 19:48:02 -0500 Received: from mail-oi1-f179.google.com ([209.85.167.179]:42740) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p4tSj-0000uz-8s for control@debbugs.gnu.org; Mon, 12 Dec 2022 19:48:01 -0500 Received: by mail-oi1-f179.google.com with SMTP id q186so12874902oia.9 for ; Mon, 12 Dec 2022 16:48:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:subject:message-id:date:mime-version:from:from:to:cc:subject :date:message-id:reply-to; bh=/yP4Ej5GcxNC/+rr39lj6jEmaAUK3gA1MnPnyXuVcVU=; b=aqFxnPfJGhVEQrbYWnbtHJT9a0gjbBoB895A2STC8lBHu7HKL4HMwPXaR1jLAVsYkY W6x3KXPYzL1LcdtYcs7WTXLt4s5TnV7He6JAYQ0zWckESCqBo24IqKzHsetfmYaGMSZa RlHG/xt8sauBh9ral3zlwcUdrHodtckWf1qX2hbs2Ho2p0n+kpAeDP7OWZbSwhxz88aZ /+BYCZx+8AEjPiWUU79U9MekNApnX2YIiWASUCuJVTaYl7FpY4BkTmWx7nKwkXwM0qOi Vu3UhQvmWH3JIr3LJBQ+EzkTMHddcQJiX9wlRD2KSy2lRxYrb3d047n/aNeUr9WVnyDk aKLA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:subject:message-id:date:mime-version:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=/yP4Ej5GcxNC/+rr39lj6jEmaAUK3gA1MnPnyXuVcVU=; b=J/riAf86Ptz33eA66vBkg1tz0y3p6g1Ru/hacP6sI8W7/IGtVjjXb3gwcw16Wlm9cE rdFhzSXedPh+QPZbpxdNrbezt+yKlMbE6hPPzAuNffa00btfzp4Yhc6dZLRfY+Bu9PEV SH0isik7MDr3O5Z+/3G2jKDNCAlTyshP6SvkBeoxM5zb9pb/Y0NygpHd/rOUVTpCSfh+ M6zRgYbmVxnJsuzuhYvr9kBs4RIx3bD0/GVbDATSYy6RriUHIG/7PFrnYcfO0VUfogIv wRi2CBTRRInZLWaTESIL56Kg/OwBqgEKYt9wSYiYbiQvyPsQbT9y8QlVZ8pkCx5tNz0h TnVw== X-Gm-Message-State: ANoB5pmZpm0y/f1qko9BIuJUvCMvyZPfNpJVArat9YJKEwdsXHdT5SJW IbJgwLqOl/+xe7e9GmczjDv8JX53XAcfXZto5C8aRDYb X-Google-Smtp-Source: AA0mqf6IO4A09+EbZNhwufqvKT46RmldWal4OZJr8S/7kpnGIix7M+frqs28zB2+7w9RjAwAenra3J5zy1SNAKRxsqM= X-Received: by 2002:a05:6808:493:b0:35e:ac60:2452 with SMTP id z19-20020a056808049300b0035eac602452mr5274oid.92.1670892475784; Mon, 12 Dec 2022 16:47:55 -0800 (PST) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Mon, 12 Dec 2022 16:47:55 -0800 From: Stefan Kangas X-Hashcash: 1:20:221213:control@debbugs.gnu.org::7QtJ0d3e9y4vZmMh:19Xr MIME-Version: 1.0 Date: Mon, 12 Dec 2022 16:47:55 -0800 Message-ID: Subject: control message for bug #60001 To: control@debbugs.gnu.org Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) severity 60001 wishlist quit From debbugs-submit-bounces@debbugs.gnu.org Sat Jan 07 18:14:04 2023 Received: (at 60001) by debbugs.gnu.org; 7 Jan 2023 23:14:04 +0000 Received: from localhost ([127.0.0.1]:59227 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pEIO4-0007TO-7R for submit@debbugs.gnu.org; Sat, 07 Jan 2023 18:14:04 -0500 Received: from mail-pl1-f169.google.com ([209.85.214.169]:35571) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pEIO1-0007Si-UY for 60001@debbugs.gnu.org; Sat, 07 Jan 2023 18:14:02 -0500 Received: by mail-pl1-f169.google.com with SMTP id y1so5605410plb.2 for <60001@debbugs.gnu.org>; Sat, 07 Jan 2023 15:14:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:cc:date:message-id:subject:mime-version :content-transfer-encoding:from:from:to:cc:subject:date:message-id :reply-to; bh=ktMg1WO2MDSADcN75lyce4/o/kBB4K+Iq/cKJGbYP58=; b=kV2HcAYo4jmcUa1z9EFzPULi+m0PkKLKza+0GRv/PS4KzdnbDqDHIcftVr/DyQxfM6 DcYi5nIxL9FdK0cbfomZlvnxOp/MiGvt1iItwYThoMmyT9BsaI0oBRg0sYwATVGIit0n zRzZK94pM7fuFT/7VL+o2KXfbaahodhkU5DIpJ/BXKdXjGhMSZ6fcqMqpYW74qBDFpNV 3x1icq0F/SQxnKYU7VK1qTgXj7Fz6ZtsCjFD4yvN2MExxPDA8muKe8LIL5VLUnmxUy28 dwA/B/Nmtu/JczEb+51YsBD1aq3gYwPiZRfj1svaTRISBd0yIzJFSle9QQYDlmeGkEU2 lBLw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:cc:date:message-id:subject:mime-version :content-transfer-encoding:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ktMg1WO2MDSADcN75lyce4/o/kBB4K+Iq/cKJGbYP58=; b=2i615adXk0wRjx2towP7Z8JB7QGmCvJCfUyYOcBa3m/yCKP2/WVLsw5FGFX3ZkHWTs GxD2D8YD6UZv3s89sJzWkbvkTxJ1er+dKErEPErUS/fuKAh3JlQtja2KCke7bbkg1Vom a/Z25kYBzB1Xzdh1T6wuEfVhk4H617YqZCGDgRzpDBYKOu9F9FCj4pVSfzm3r3Q7CUIL S0cc8oDk/a1g/ChCHY0mZcHH5ZcrVz/wbcC0IZmctD0QkjaiatcVCRCYSkkPRfcIHgSP nvjJ6tLo8poU/Pyxvv/d3xMRyaofpbbR6AnbhapaUccQgk1eJk2j1yA6rJ5fVlGzJQSV tn5g== X-Gm-Message-State: AFqh2kokgPF97k2lHZNSP5YwcvxnokzxDc4CK4pHZLnpKGqlMZYHNmnS H5J94iEk/ZBjXqJ71816pJs= X-Google-Smtp-Source: AMrXdXtkMcWK/8pfcuuMiEFADQNPk08H4yVRUJaAQP+0ZSBMuw0V6n4EOqcoRUvOvhH8WAecKttqyA== X-Received: by 2002:a17:902:e152:b0:193:3de:b777 with SMTP id d18-20020a170902e15200b0019303deb777mr8849135pla.43.1673133236257; Sat, 07 Jan 2023 15:13:56 -0800 (PST) Received: from smtpclient.apple (cpe-172-117-161-177.socal.res.rr.com. [172.117.161.177]) by smtp.gmail.com with ESMTPSA id n7-20020a170902e54700b00191292875desm3205374plf.279.2023.01.07.15.13.55 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sat, 07 Jan 2023 15:13:55 -0800 (PST) From: Yuan Fu Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.1\)) Subject: Re: bug#60001: [PATCH] Improve completion of treesit-check-indent command Message-Id: <7FDC90A2-7616-434D-9737-4463F083C3F2@gmail.com> Date: Sat, 7 Jan 2023 15:13:54 -0800 To: Eli Zaretskii X-Mailer: Apple Mail (2.3696.120.41.1.1) X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 60001 Cc: 60001@debbugs.gnu.org, =?utf-8?Q?Daniel_Mart=C3=ADn?= X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Eli Zaretskii writes: >> Date: Mon, 12 Dec 2022 11:53:00 +0100 >> From: Daniel Mart=C3=ADn via "Bug reports for GNU Emacs, >> the Swiss army knife of text editors" >>=20 >> The treesit-check-indent command is not really related to Tree-sitter >> and could be in a more general place than treesit.el. WDYT? > > I agree, but then we'd need a definition for it that doesn't need > tree-sitter support. Is that easy to provide? > >> In any case, I have a patch to improve this command a bit by offering >> more accurate completion for major modes, not Emacs commands. I have >> also tried to improve its documentation a bit. > > How about a read-major-mode function in subr.el? > > But I think all these generalizations and improvements should go to > master. On the release branch, I'd prefer to leave > treesit-check-indent alone. Has this patch been pushed to master? Should I close this report? Yuan From debbugs-submit-bounces@debbugs.gnu.org Sun Jan 08 06:53:18 2023 Received: (at 60001) by debbugs.gnu.org; 8 Jan 2023 11:53:18 +0000 Received: from localhost ([127.0.0.1]:60088 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pEUEn-0005yP-Sr for submit@debbugs.gnu.org; Sun, 08 Jan 2023 06:53:18 -0500 Received: from eggs.gnu.org ([209.51.188.92]:38124) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pEUEm-0005y9-9N for 60001@debbugs.gnu.org; Sun, 08 Jan 2023 06:53:16 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pEUEf-0003PL-UP; Sun, 08 Jan 2023 06:53:10 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=+eMwyE1thTS75mMpx1fcepwdc4yY6kVfMmF2Y2m4sSc=; b=XEo2HajQVDMjiUfgERW0 G4nu8pdxWuX/vA2T7T1TEsQklDTQtL4WVhAAT2SWLWf5EDGjDO/v73GlQ7C+ne5pec55BRdhQU4OZ pxF57XnBzZHI+8lZ6tddfzZs6U7SUAkTLSNIGJasvXMsBNVghh4NE1krD+lL5UKy/AZB0HWnKeVDZ T2erQaIz8Vfnh2HgZjhoUBFxptIhH/BZ6gJ4WDx/Nv0RWzK164pbGb3Pa9QkI7rbxteFCnegP7WeN 605Av6PJ9HEf9pspe7Wr3aGJyq15jKP8n5U6WuDht0DD94qgngIBY7HcqV8IdosSL/0LANwU8vbo0 gsTHrWCx9F6A/A==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pEUEf-0005Sd-Fw; Sun, 08 Jan 2023 06:53:09 -0500 Date: Sun, 08 Jan 2023 13:53:33 +0200 Message-Id: <83358lqm2q.fsf@gnu.org> From: Eli Zaretskii To: Yuan Fu In-Reply-To: <7FDC90A2-7616-434D-9737-4463F083C3F2@gmail.com> (message from Yuan Fu on Sat, 7 Jan 2023 15:13:54 -0800) Subject: Re: bug#60001: [PATCH] Improve completion of treesit-check-indent command References: <7FDC90A2-7616-434D-9737-4463F083C3F2@gmail.com> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 60001 Cc: 60001@debbugs.gnu.org, mardani29@yahoo.es X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Yuan Fu > Date: Sat, 7 Jan 2023 15:13:54 -0800 > Cc: Daniel Martín , > 60001@debbugs.gnu.org > > > Eli Zaretskii writes: > > >> Date: Mon, 12 Dec 2022 11:53:00 +0100 > >> From: Daniel Martín via "Bug reports for GNU Emacs, > >> the Swiss army knife of text editors" > >> > >> The treesit-check-indent command is not really related to Tree-sitter > >> and could be in a more general place than treesit.el. WDYT? > > > > I agree, but then we'd need a definition for it that doesn't need > > tree-sitter support. Is that easy to provide? > > > >> In any case, I have a patch to improve this command a bit by offering > >> more accurate completion for major modes, not Emacs commands. I have > >> also tried to improve its documentation a bit. > > > > How about a read-major-mode function in subr.el? > > > > But I think all these generalizations and improvements should go to > > master. On the release branch, I'd prefer to leave > > treesit-check-indent alone. > > Has this patch been pushed to master? No, I don't think so. > Should I close this report? If you agree with the change, please install it. From debbugs-submit-bounces@debbugs.gnu.org Mon Sep 04 16:02:34 2023 Received: (at 60001) by debbugs.gnu.org; 4 Sep 2023 20:02:35 +0000 Received: from localhost ([127.0.0.1]:52687 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qdFmM-0001Vp-Hx for submit@debbugs.gnu.org; Mon, 04 Sep 2023 16:02:34 -0400 Received: from mail-lf1-x130.google.com ([2a00:1450:4864:20::130]:54603) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qdFmI-0001VY-3p for 60001@debbugs.gnu.org; Mon, 04 Sep 2023 16:02:33 -0400 Received: by mail-lf1-x130.google.com with SMTP id 2adb3069b0e04-50078e52537so2978024e87.1 for <60001@debbugs.gnu.org>; Mon, 04 Sep 2023 13:02:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1693857744; x=1694462544; darn=debbugs.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date :mime-version:references:in-reply-to:from:from:to:cc:subject:date :message-id:reply-to; bh=4DfcfVGwZYLhwrkaxeMuZON4BpzDcbTC/sXJd4hbYeE=; b=FzricrB7FfZosHm3zBylEABJ0b5sclJHZ4i4rllXTydnCQ9EsgPqXsAE/KVisjXP23 ao2pLaRw7ofwi5Kdm9BAgMxNYoDtLJ4VQKhn+NbqDOfCxlGWLrLSWOAbGYkydUR7jcld 0RfbNsQBCLF4jvgsza+82OvRM5XqV+JoiIc67NG9GlaB7+kfzdOtUzpuLDg1yo7hDGln sWBc3GyCaJoZKJvp4/XjGrV9iB3cujYxID7W6Q2pNK87+4nJzuVdTiww5K462nUxU+Jt aLXgqSTmUCgoMVSYo/UCvrKvDHuILskCVrmuYshI5XJxhoyzG6CLv4zjcvz3zV5zPk8+ UiZw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693857744; x=1694462544; h=content-transfer-encoding:cc:to:subject:message-id:date :mime-version:references:in-reply-to:from:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=4DfcfVGwZYLhwrkaxeMuZON4BpzDcbTC/sXJd4hbYeE=; b=XJp6v9QAE5IB6+0pMmTtR5ZtTI1micmnL3ngbC8At27LgtKUEXmabHx90pZCQPI/HI JE4cthe/UZH/JAcR0YUQ6VG3NspGRB1z0l23/HmxIrJd8bIl5P2hsO0NnQQ/hfmJsaa8 kf77NAZufHuKE2/fZ+x3B1RHQiKj34gr89q4A9eHop4CPRSn1nHjxOW76ufyKQbExvt6 CscppBNY9AWtI8fB5/poYsRAcK12x0oZkiQhPRjsJzNsk7i41uJuA/AMTZTXDtblXASV pUN8+9qNw0c1rzFAkqdHjPxPVga+9G2JDwioBGdvcrf7U/67pTZd5IuItxTeDGH2dhmB n1YA== X-Gm-Message-State: AOJu0YwUiSzpb2uxR6bd3IYOzNHGaUYQQFFz2kBY5TMoFJL+xeBh/ZS/ Le8jVhakFDgX/uAqHg9tKyMzq6CaJBkm82NGyqo= X-Google-Smtp-Source: AGHT+IHrwPS7grtx7fn3InYg7WUVkeW+vefNv0T2TsYla+HXl12/Ua8YAoah8kXTgiCzFSq87dJxHTC8aKIsZifGMWw= X-Received: by 2002:a05:6512:3085:b0:4f8:ff52:93b7 with SMTP id z5-20020a056512308500b004f8ff5293b7mr9892330lfd.30.1693857743819; Mon, 04 Sep 2023 13:02:23 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Mon, 4 Sep 2023 13:02:23 -0700 From: Stefan Kangas In-Reply-To: <83358lqm2q.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 08 Jan 2023 13:53:33 +0200") References: <7FDC90A2-7616-434D-9737-4463F083C3F2@gmail.com> <83358lqm2q.fsf@gnu.org> MIME-Version: 1.0 Date: Mon, 4 Sep 2023 13:02:23 -0700 Message-ID: Subject: Re: bug#60001: [PATCH] Improve completion of treesit-check-indent command To: Eli Zaretskii Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 60001 Cc: 60001@debbugs.gnu.org, Yuan Fu , mardani29@yahoo.es X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Eli Zaretskii writes: >> From: Yuan Fu >> Date: Sat, 7 Jan 2023 15:13:54 -0800 >> Cc: Daniel Mart=C3=ADn , >> 60001@debbugs.gnu.org >> >> >> Eli Zaretskii writes: >> >> >> Date: Mon, 12 Dec 2022 11:53:00 +0100 >> >> From: Daniel Mart=C3=ADn via "Bug reports for GNU Emacs, >> >> the Swiss army knife of text editors" >> >> >> >> The treesit-check-indent command is not really related to Tree-sitter >> >> and could be in a more general place than treesit.el. WDYT? >> > >> > I agree, but then we'd need a definition for it that doesn't need >> > tree-sitter support. Is that easy to provide? >> > >> >> In any case, I have a patch to improve this command a bit by offering >> >> more accurate completion for major modes, not Emacs commands. I have >> >> also tried to improve its documentation a bit. >> > >> > How about a read-major-mode function in subr.el? >> > >> > But I think all these generalizations and improvements should go to >> > master. On the release branch, I'd prefer to leave >> > treesit-check-indent alone. >> >> Has this patch been pushed to master? > > No, I don't think so. > >> Should I close this report? > > If you agree with the change, please install it. It seems like this patch was never installed. Should it be? From debbugs-submit-bounces@debbugs.gnu.org Tue Sep 05 06:52:07 2023 Received: (at 60001) by debbugs.gnu.org; 5 Sep 2023 10:52:07 +0000 Received: from localhost ([127.0.0.1]:54281 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qdTfC-00083y-Op for submit@debbugs.gnu.org; Tue, 05 Sep 2023 06:52:07 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:33388) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qdTfA-00083S-Ug for 60001@debbugs.gnu.org; Tue, 05 Sep 2023 06:52:05 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qdTf5-0006KF-3Z; Tue, 05 Sep 2023 06:51:59 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=HG7CiHGhgKbwvQaX/+XPTxhzhc1YDGXlIB8nULpOI2s=; b=I3iBGVWCC7Nf xQuVGGMK8qtyj8576wU9+sOXqKENx5snDkNgY8RMeiELxKM5GxFHY2Sa2Pka4cgkoNrSTVtVO6T7l GEAP7DhCIuIhDhQ+bmph9P8dV7cSSSM8gN97RX592uF4yA9ManPJ3cKj5uCiddOvDeRqH58d/GhvO 9cbz79pctpn36FTGXOYAxFWMr4UggKtpQhNCYDbQ2E2+CCyj79diXq+NPKTOVdlas1U6tNAhn1o5v 32kViVgYXzSETxTvJY+eVzQsgdGf0bOwllwALcI/liT2+BC8+YlBw7TX9WkzoLNZhzog7kRGxom2f DdmUbbnvNc+XaDVfbJa8LQ==; Date: Tue, 05 Sep 2023 13:51:31 +0300 Message-Id: <83pm2w51vw.fsf@gnu.org> From: Eli Zaretskii To: Stefan Kangas In-Reply-To: (message from Stefan Kangas on Mon, 4 Sep 2023 13:02:23 -0700) Subject: Re: bug#60001: [PATCH] Improve completion of treesit-check-indent command References: <7FDC90A2-7616-434D-9737-4463F083C3F2@gmail.com> <83358lqm2q.fsf@gnu.org> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 60001 Cc: 60001@debbugs.gnu.org, casouri@gmail.com, mardani29@yahoo.es X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Stefan Kangas > Date: Mon, 4 Sep 2023 13:02:23 -0700 > Cc: Yuan Fu , 60001@debbugs.gnu.org, mardani29@yahoo.es > > Eli Zaretskii writes: > > >> Should I close this report? > > > > If you agree with the change, please install it. > > It seems like this patch was never installed. Should it be? I think so, yes. From debbugs-submit-bounces@debbugs.gnu.org Tue Sep 05 16:41:05 2023 Received: (at 60001-done) by debbugs.gnu.org; 5 Sep 2023 20:41:05 +0000 Received: from localhost ([127.0.0.1]:59577 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qdcrB-0000j7-9b for submit@debbugs.gnu.org; Tue, 05 Sep 2023 16:41:05 -0400 Received: from mail-lf1-x131.google.com ([2a00:1450:4864:20::131]:48525) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qdcr9-0000iS-Ek for 60001-done@debbugs.gnu.org; Tue, 05 Sep 2023 16:41:04 -0400 Received: by mail-lf1-x131.google.com with SMTP id 2adb3069b0e04-500d13a8fafso5187041e87.1 for <60001-done@debbugs.gnu.org>; Tue, 05 Sep 2023 13:41:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1693946454; x=1694551254; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:from:to:cc:subject:date:message-id:reply-to; bh=yerzKamk12HqmcRHBBf2Q4Pp5dk4CtCO+MmFErvaRCg=; b=eCGU4keF0k/EvmlL2Xpkojtmq8UiJrw6RxRX+J8ZtBcg1B8eD8ozHQGPwa58ojYTpA R/Vs7mR/dSBkqor2hqELOhTDEX3lube7AbbpQx+K2bAff89E9g9fUBC8rtQgKVXQXxoh qhJ7XrB/SVm80v1IcjXdtPnYPKNmGRjZrKW6xmrHov8uaXxH9X4LrsRd69TfkVVX7lbo SS/LLpdQcObLdl+Cesht+/NgsnPp2N0NdLLzI302i1rkgGQrOfg/jBYbGieHXNOAsVs/ 7cgm3DyvX8rEXMIj1mP4THjF/YWClvf5Poh82kSxcsD0+dCcyttQKWnBYBHgRKIDFGyA uJ/w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693946454; x=1694551254; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=yerzKamk12HqmcRHBBf2Q4Pp5dk4CtCO+MmFErvaRCg=; b=M3MFQm2ju0ZM6CnA97RebQj9CIkE1jbHrioV9t32LorxT70yc8au6UQ+FydvPntCRS mgtWILsFrUHvTY7J6vdwWV7Hnf6+mIPsRWOB2KvbK/at/Km+XMEgUqurV+X5WU6da+py WXKxtT0rej67sUZ+eu+/dnSw3bDkgn3SdsfJIryf3HVkBPBay4LPijXAzEY1wINrr6wO NTnHD5rEe9fFH5zFN8T8dLfwHuv6oIqQ2w1lwbeGl9qGLtjNqDjkmnE2ewnyw7DzB64f 5TLuiLtxBj0QbtWil00k2Q6L+hxljzSeFrUZWdrNnT3zNwPrk1xm0AZklQjc43g4Pb/1 j9ag== X-Gm-Message-State: AOJu0YxW22Mj2yDG4WOZSD0Vi/QorMi8g3gqKt2D+w1uQE1gZvMLv0aa HKd2BdoiPcel8AgPPGtP4VskO0BXFpQON1AHWSA= X-Google-Smtp-Source: AGHT+IEACGg662WbvCsLlCm5kBakfCw+52vdmMatbflTI509DDxBAccerbKqW//nSBUTYUYqINzQoOpykqIevZLV8ok= X-Received: by 2002:a05:6512:447:b0:4fb:893e:8ffc with SMTP id y7-20020a056512044700b004fb893e8ffcmr597844lfk.17.1693946454363; Tue, 05 Sep 2023 13:40:54 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Tue, 5 Sep 2023 13:40:53 -0700 From: Stefan Kangas In-Reply-To: <83pm2w51vw.fsf@gnu.org> References: <7FDC90A2-7616-434D-9737-4463F083C3F2@gmail.com> <83358lqm2q.fsf@gnu.org> <83pm2w51vw.fsf@gnu.org> MIME-Version: 1.0 Date: Tue, 5 Sep 2023 13:40:53 -0700 Message-ID: Subject: Re: bug#60001: [PATCH] Improve completion of treesit-check-indent command To: Eli Zaretskii Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 60001-done Cc: 60001-done@debbugs.gnu.org, casouri@gmail.com, mardani29@yahoo.es X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Version: 30.1 Eli Zaretskii writes: >> From: Stefan Kangas >> Date: Mon, 4 Sep 2023 13:02:23 -0700 >> Cc: Yuan Fu , 60001@debbugs.gnu.org, mardani29@yahoo.es >> >> Eli Zaretskii writes: >> >> >> Should I close this report? >> > >> > If you agree with the change, please install it. >> >> It seems like this patch was never installed. Should it be? > > I think so, yes. Thanks, pushed to master as commit cd6dcfad107. From debbugs-submit-bounces@debbugs.gnu.org Wed Sep 06 03:14:50 2023 Received: (at 60001) by debbugs.gnu.org; 6 Sep 2023 07:14:50 +0000 Received: from localhost ([127.0.0.1]:60680 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qdmkL-0002tO-PQ for submit@debbugs.gnu.org; Wed, 06 Sep 2023 03:14:50 -0400 Received: from relay3-d.mail.gandi.net ([2001:4b98:dc4:8::223]:55783) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qdmkJ-0002tA-J3 for 60001@debbugs.gnu.org; Wed, 06 Sep 2023 03:14:40 -0400 Received: by mail.gandi.net (Postfix) with ESMTPSA id 3E1836000B; Wed, 6 Sep 2023 07:14:29 +0000 (UTC) From: Juri Linkov To: 60001@debbugs.gnu.org Subject: Re: bug#60001: [PATCH] Improve completion of treesit-check-indent command In-Reply-To: (Stefan Kangas's message of "Tue, 5 Sep 2023 13:40:53 -0700") Organization: LINKOV.NET References: <7FDC90A2-7616-434D-9737-4463F083C3F2@gmail.com> <83358lqm2q.fsf@gnu.org> <83pm2w51vw.fsf@gnu.org> Date: Wed, 06 Sep 2023 09:53:05 +0300 Message-ID: <86pm2v22ri.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-GND-Sasl: juri@linkov.net X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 60001 Cc: stefankangas@gmail.com, mardani29@yahoo.es X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) >>> > If you agree with the change, please install it. >>> >>> It seems like this patch was never installed. Should it be? >> >> I think so, yes. > > Thanks, pushed to master as commit cd6dcfad107. Would it be possible to avoid code duplication in 'treesit--read-major-mode' with the same code as in 'read-file-local-variable-mode'? Maybe by creating a new core function to read a major mode? From unknown Tue Jun 17 20:18:58 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Wed, 04 Oct 2023 11:24:05 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator