From unknown Sun Jun 15 08:40:00 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#59994 <59994@debbugs.gnu.org> To: bug#59994 <59994@debbugs.gnu.org> Subject: Status: [PATCH] tests: Don't try to prevent flex to include unistd.h Reply-To: bug#59994 <59994@debbugs.gnu.org> Date: Sun, 15 Jun 2025 15:40:00 +0000 retitle 59994 [PATCH] tests: Don't try to prevent flex to include unistd.h reassign 59994 automake-patches submitter 59994 Frederic Berat severity 59994 normal tag 59994 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Mon Dec 12 03:43:16 2022 Received: (at submit) by debbugs.gnu.org; 12 Dec 2022 08:43:16 +0000 Received: from localhost ([127.0.0.1]:51443 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p4eP5-0004px-Ea for submit@debbugs.gnu.org; Mon, 12 Dec 2022 03:43:16 -0500 Received: from lists.gnu.org ([209.51.188.17]:34576) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p4cuz-0001IX-QA for submit@debbugs.gnu.org; Mon, 12 Dec 2022 02:08:06 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p4cuy-0004VM-C2 for automake-patches@gnu.org; Mon, 12 Dec 2022 02:08:05 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p4cuw-00076B-IN for automake-patches@gnu.org; Mon, 12 Dec 2022 02:08:04 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1670828881; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=2XDiVNI3ZAMJ94Kltsaq9KCdZ7A2mBEr25zTZ5VD4us=; b=O/pyMRLxHxBFVlvXTk+BW4QkwBzGkuk/S74TBsWcHCIZw3LUx06hBJSqPhNq7hnJF+tDxo WwEPs+X3w/8B7mRp5pXcVrKt4M5kVYEuLide6xZ3L8m/Gwnv5aCk3iw1jr6PyDc8fQ9IO6 0v18mN7vLSselcocRZbgoP6ZNfM8/Uk= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-561-k3NC3U5bObO5Y-JYGn4uwg-1; Mon, 12 Dec 2022 02:08:00 -0500 X-MC-Unique: k3NC3U5bObO5Y-JYGn4uwg-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 1D01529AA2E3 for ; Mon, 12 Dec 2022 07:08:00 +0000 (UTC) Received: from Nymeria-redhat.redhat.com (unknown [10.39.192.133]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 5947E53A7; Mon, 12 Dec 2022 07:07:59 +0000 (UTC) From: Frederic Berat To: automake-patches@gnu.org Subject: [PATCH] tests: Don't try to prevent flex to include unistd.h Date: Mon, 12 Dec 2022 08:07:52 +0100 Message-Id: <20221212070752.1635797-1-fberat@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.5 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=170.10.129.124; envelope-from=fberat@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Mon, 12 Dec 2022 03:43:10 -0500 Cc: =?UTF-8?q?Fr=C3=A9d=C3=A9ric=20B=C3=A9rat?= X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) From: Frédéric Bérat Hello, This patch is mainly a proposal. While the macro can simply be removed as explained below, another possibility it to add a flex option "--never-interactive" to prevent flex to make use of "isatty". -- 8< -- This is related to an effort to prepare Automake for future GCC/Clang versions which set c99 as default standard to be used. Future version of flex make the "NO_UNISTD" flag a no-op, and include unistd.h by default. In current version of flex, not having this header leads to implicit function declarations that are not compatible with c99 standard. On top of that, while flex dedicated test were having this macro set, the yacc ones didn't have it despise their use of Flex. Thus, if this macro was ever useful, it looks like nobody actually cared. --- t/cond35.sh | 3 --- t/lex-clean.sh | 3 --- t/lex-depend.sh | 3 --- t/lex-header.sh | 3 --- t/lex-lib.sh | 3 --- t/lex-libobj.sh | 3 --- t/lex-line.sh | 3 --- t/lex-multiple.sh | 3 --- t/lex-nodist.sh | 3 --- t/lex-noyywrap.sh | 3 --- t/lex3.sh | 3 --- t/lex5.sh | 3 --- t/lexvpath.sh | 9 --------- t/silent-lex.sh | 3 --- 14 files changed, 48 deletions(-) diff --git a/t/cond35.sh b/t/cond35.sh index bad133970..435e02ffc 100644 --- a/t/cond35.sh +++ b/t/cond35.sh @@ -58,9 +58,6 @@ $FGREP 'tparse.h' Makefile.in # For debugging. test $($FGREP -c 'tparse.h:' Makefile.in) -eq 1 cat > tscan.l << 'END' -%{ -#define YY_NO_UNISTD_H 1 -%} %% "END" return EOF; %% diff --git a/t/lex-clean.sh b/t/lex-clean.sh index e53da8fd2..6ab451173 100644 --- a/t/lex-clean.sh +++ b/t/lex-clean.sh @@ -52,9 +52,6 @@ LDADD = $(LEXLIB) END cat > lexer.l << 'END' -%{ -#define YY_NO_UNISTD_H 1 -%} %% "GOOD" return EOF; . diff --git a/t/lex-depend.sh b/t/lex-depend.sh index c6fde8c1f..7fbf60370 100644 --- a/t/lex-depend.sh +++ b/t/lex-depend.sh @@ -42,9 +42,6 @@ test-obj-updated: joe.$(OBJEXT) END cat > joe.l << 'END' -%{ -#define YY_NO_UNISTD_H 1 -%} %% "foo" return EOF; . diff --git a/t/lex-header.sh b/t/lex-header.sh index 73beb95b6..46e8be60c 100644 --- a/t/lex-header.sh +++ b/t/lex-header.sh @@ -45,9 +45,6 @@ END cat > lexer.l << 'END' %option noyywrap -%{ -#define YY_NO_UNISTD_H 1 -%} %% "GOOD" return EOF; . diff --git a/t/lex-lib.sh b/t/lex-lib.sh index a251534d5..4ec75abe4 100644 --- a/t/lex-lib.sh +++ b/t/lex-lib.sh @@ -47,9 +47,6 @@ int yywrap (void) END cat > foo.l <<'END' -%{ -#define YY_NO_UNISTD_H 1 -%} %% "END" return EOF; . diff --git a/t/lex-libobj.sh b/t/lex-libobj.sh index 5d4c13ebd..50ac10bb0 100644 --- a/t/lex-libobj.sh +++ b/t/lex-libobj.sh @@ -45,9 +45,6 @@ int yywrap (void) END cat > foo.l <<'END' -%{ -#define YY_NO_UNISTD_H 1 -%} %% "END" return EOF; . diff --git a/t/lex-line.sh b/t/lex-line.sh index ef2a2a808..6107d0664 100644 --- a/t/lex-line.sh +++ b/t/lex-line.sh @@ -57,9 +57,6 @@ dir/quux.@OBJEXT@: dir/quux.c END cat > zardoz.l << 'END' -%{ -#define YY_NO_UNISTD_H 1 -%} %% "END" return EOF; . diff --git a/t/lex-multiple.sh b/t/lex-multiple.sh index bf119ec84..5f4695deb 100644 --- a/t/lex-multiple.sh +++ b/t/lex-multiple.sh @@ -76,9 +76,6 @@ int main (int argc, char *argv[]) END cat > 0.l << 'END' -%{ -#define YY_NO_UNISTD_H 1 -%} %% "VANILLA" { printf (":%s:\n", yytext); return 121; } . { printf (":%s:\n", yytext); return 1; } diff --git a/t/lex-nodist.sh b/t/lex-nodist.sh index 187dd5437..4a4d0f01c 100644 --- a/t/lex-nodist.sh +++ b/t/lex-nodist.sh @@ -45,9 +45,6 @@ check-local: test-build test-dist lexer.l: rm -f $@ $@-t :; { : \ - && echo '%{' \ - && echo '#define YY_NO_UNISTD_H 1' \ - && echo '%}' \ && echo '%%' \ && echo '"GOOD" return EOF;' \ && echo '.'; \ diff --git a/t/lex-noyywrap.sh b/t/lex-noyywrap.sh index c11813429..0451dbcf5 100644 --- a/t/lex-noyywrap.sh +++ b/t/lex-noyywrap.sh @@ -37,9 +37,6 @@ END cat > foo.l << 'END' %option noyywrap -%{ -#define YY_NO_UNISTD_H 1 -%} %% "GOOD" return EOF; . diff --git a/t/lex3.sh b/t/lex3.sh index 7de5fe2a6..9e54e7abf 100644 --- a/t/lex3.sh +++ b/t/lex3.sh @@ -33,9 +33,6 @@ foo_SOURCES = foo.l END cat > foo.l << 'END' -%{ -#define YY_NO_UNISTD_H 1 -%} %% "GOOD" return EOF; . diff --git a/t/lex5.sh b/t/lex5.sh index 0563a35ee..da354e2ac 100644 --- a/t/lex5.sh +++ b/t/lex5.sh @@ -36,9 +36,6 @@ END mkdir foo cat > foo/foo.l << 'END' -%{ -#define YY_NO_UNISTD_H 1 -%} %% "END" return EOF; . diff --git a/t/lexvpath.sh b/t/lexvpath.sh index 84187a916..33fab0a80 100644 --- a/t/lexvpath.sh +++ b/t/lexvpath.sh @@ -44,9 +44,6 @@ END # Original lexer, with a "foobar" comment cat > lexer.l << 'END' -%{ -#define YY_NO_UNISTD_H 1 -%} %% "END" return EOF; . @@ -89,9 +86,6 @@ $sleep # New lexer, with 'fubar' comment. cat > ../lexer.l << 'END' -%{ -#define YY_NO_UNISTD_H 1 -%} %% "END" return EOF; . @@ -112,9 +106,6 @@ $sleep # New lexer, with 'maude' comment. cat > ../lexer.l << 'END' -%{ -#define YY_NO_UNISTD_H 1 -%} %% "END" return EOF; . diff --git a/t/silent-lex.sh b/t/silent-lex.sh index f319eee93..c15a30a9d 100644 --- a/t/silent-lex.sh +++ b/t/silent-lex.sh @@ -50,9 +50,6 @@ LDADD = $(LEXLIB) EOF cat > foo.l <<'EOF' -%{ -#define YY_NO_UNISTD_H 1 -%} %% "END" return EOF; . -- 2.38.1 From debbugs-submit-bounces@debbugs.gnu.org Mon Dec 12 15:20:52 2022 Received: (at submit) by debbugs.gnu.org; 12 Dec 2022 20:20:52 +0000 Received: from localhost ([127.0.0.1]:55125 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p4pIC-0003Sd-H9 for submit@debbugs.gnu.org; Mon, 12 Dec 2022 15:20:52 -0500 Received: from lists.gnu.org ([209.51.188.17]:56334) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p4pIB-0003SX-BM for submit@debbugs.gnu.org; Mon, 12 Dec 2022 15:20:51 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p4pIB-0006In-32 for automake-patches@gnu.org; Mon, 12 Dec 2022 15:20:51 -0500 Received: from out4-smtp.messagingengine.com ([66.111.4.28]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p4pI9-0004QR-LC for automake-patches@gnu.org; Mon, 12 Dec 2022 15:20:50 -0500 Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 6A7535C0166 for ; Mon, 12 Dec 2022 15:20:47 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Mon, 12 Dec 2022 15:20:47 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=owlfolio.org; h= cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm1; t=1670876447; x= 1670962847; bh=XQUNeOMYODDKYQeloWwUz46/cDfwVrAgY9+OuTZEpRc=; b=m bg2drYRjCaWZvhNB9jvYj2Y97QT3eFCF7erNEvvv/TifuoycNsdsdVb4gfRRd9HH KxY1zCi7vdmAPPaXA45XkogjDR9ZE9Tv6Q4sXW3hByZwI5w2JrDsVCGVub3yrgxi ojr+YCWv43Mgpg9YLYi5qNFIe1nSuSc232miPqVJOTLIh5mWDP2CZMZEO5vYysR1 HdcSu0tuJBkUlUxwAJfj0PAnq2us7YWyzTE+KTOeJZ9MtbDWF2niw4b76IYNu6WV Ea0+H1fn8+Pn4Mit+klJvt7zqj9I9YySasyfSSE3wDNsFOQ40Ho/BpimCj89JqUj esCuWSL4gfasbMNrTC0mA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:date:feedback-id:feedback-id:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to:x-me-proxy:x-me-proxy:x-me-sender :x-me-sender:x-sasl-enc; s=fm2; t=1670876447; x=1670962847; bh=X QUNeOMYODDKYQeloWwUz46/cDfwVrAgY9+OuTZEpRc=; b=gE2/sSG2PpplSTtNT 7aT/aZCMK6kJZzdim3BhjybKvs9LA9gTcQwTPnfm8MBy8rs9VeVVoUxWvZaNekL8 uGH6MEcEeiKB9Nf7sVVTbJqHZrtfjXjmvjCLc3woFnYbDJk1wU0yJ6eH4faQYzFi dmtfNvqgnY9DLtmqrOugsZ0rppOiLwtEdPJvk9qqNo/0b72vgqvNmuiPOQnnwpP5 QmfGm9Kr4dwFJRqTwdMml3vjJgH5Q9YiXkmplrqnH5qC9+yPTrFjeZwHIRtYXDRq j5zqg3m/VjofADCjgM1OxYZAxxq9v7IV84MQ011zeaOd3Ny6pm2ME++saZA8LJuQ +9oEg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrvdekgdduuddvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpefkffggfgfuvfhfhfgjtgfgsehtje ertddtfeejnecuhfhrohhmpegkrggtkhcuhggvihhnsggvrhhguceoiigrtghksehofihl fhholhhiohdrohhrgheqnecuggftrfgrthhtvghrnhepgedvueegveefudfhvdffudejhf fgleektdduvdeffedvueeuhfduiefgtdevjeefnecuvehluhhsthgvrhfuihiivgeptden ucfrrghrrghmpehmrghilhhfrhhomhepiigrtghksehofihlfhholhhiohdrohhrgh X-ME-Proxy: Feedback-ID: i876146a2:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA for ; Mon, 12 Dec 2022 15:20:47 -0500 (EST) Message-ID: <6cbed749-0346-f89d-28e0-5e459cbca47d@owlfolio.org> Date: Mon, 12 Dec 2022 15:20:46 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.5.1 Subject: Re: [bug#59994] [PATCH] tests: Don't try to prevent flex to include unistd.h Content-Language: en-US To: automake-patches@gnu.org References: <20221212070752.1635797-1-fberat@redhat.com> From: Zack Weinberg In-Reply-To: <20221212070752.1635797-1-fberat@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=66.111.4.28; envelope-from=zack@owlfolio.org; helo=out4-smtp.messagingengine.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.7 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.7 (--) On 2022-12-12 2:07 AM, Frederic Berat wrote: > > This patch is mainly a proposal. While the macro can simply be removed > as explained below, another possibility it to add a flex option > "--never-interactive" to prevent flex to make use of "isatty". > > This is related to an effort to prepare Automake for future GCC/Clang > versions which set c99 as default standard to be used. > > Future version of flex make the "NO_UNISTD" flag a no-op, and include > unistd.h by default. > > In current version of flex, not having this header leads to implicit > function declarations that are not compatible with c99 standard. > > On top of that, while flex dedicated test were having this macro set, > the yacc ones didn't have it despise their use of Flex. Thus, if this > macro was ever useful, it looks like nobody actually cared. I'm guessing that the idea here was to avoid using unistd.h on platforms that don't supply that header at all. I suggest that we should apply your patch *and* consistently test flex with "--never-interactive". zw From debbugs-submit-bounces@debbugs.gnu.org Fri Jan 13 01:30:22 2023 Received: (at 59994) by debbugs.gnu.org; 13 Jan 2023 06:30:22 +0000 Received: from localhost ([127.0.0.1]:49308 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pGDa2-0002rO-7V for submit@debbugs.gnu.org; Fri, 13 Jan 2023 01:30:22 -0500 Received: from woodpecker.gentoo.org ([140.211.166.183]:42940 helo=smtp.gentoo.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pGDZy-0002Ol-N4 for 59994@debbugs.gnu.org; Fri, 13 Jan 2023 01:30:19 -0500 Received: by smtp.gentoo.org (Postfix, from userid 559) id 346F4340A8E; Fri, 13 Jan 2023 06:30:13 +0000 (UTC) From: Mike Frysinger To: fberat@redhat.com Subject: Re: [bug#59994] [PATCH] tests: Don't try to prevent flex to include unistd.h User-Agent: GNU debbugs/0 Message-Id: <20230113063013.346F4340A8E@smtp.gentoo.org> Date: Fri, 13 Jan 2023 06:30:13 +0000 (UTC) X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 59994 Cc: 59994@debbugs.gnu.org, Zack Weinberg X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) On Mon, 12 Dec 2022 15:20:46 -0500, Zack Weinberg wrote: > On 2022-12-12 2:07 AM, Frederic Berat wrote: > > > > This patch is mainly a proposal. While the macro can simply be removed > > as explained below, another possibility it to add a flex option > > "--never-interactive" to prevent flex to make use of "isatty". > > > > This is related to an effort to prepare Automake for future GCC/Clang > > versions which set c99 as default standard to be used. > > > > Future version of flex make the "NO_UNISTD" flag a no-op, and include > > unistd.h by default. > > > > In current version of flex, not having this header leads to implicit > > function declarations that are not compatible with c99 standard. > > > > On top of that, while flex dedicated test were having this macro set, > > the yacc ones didn't have it despise their use of Flex. Thus, if this > > macro was ever useful, it looks like nobody actually cared. > > I'm guessing that the idea here was to avoid using unistd.h on platforms > that don't supply that header at all. I suggest that we should apply > your patch *and* consistently test flex with "--never-interactive". sounds fine. want to update your patch Frederic ? -mike From debbugs-submit-bounces@debbugs.gnu.org Fri Jan 13 07:49:43 2023 Received: (at 59994) by debbugs.gnu.org; 13 Jan 2023 12:49:43 +0000 Received: from localhost ([127.0.0.1]:49814 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pGJV8-0004W5-RR for submit@debbugs.gnu.org; Fri, 13 Jan 2023 07:49:43 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]:27008) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pGJV7-0004Vy-K9 for 59994@debbugs.gnu.org; Fri, 13 Jan 2023 07:49:42 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1673614181; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=SwmCWbK1P/tcaFa3VVRBE/VIA59cy8PTj/G68BqdKzA=; b=UQcwK1uHcksZugCdBLLVFl+V8Ty5OSc56VAOpdpAdUQyZPA/hMCWT4AbgWP1dkOtKXIw+8 I6vhZVRSMFnOR5d7InIS5dh9OGsRpW/hBiWnvQ1fIYAubXCS22/bukJm4MM9myer7cBh3W g/I3Uk0NCdY5S9cQ+8ZJUaEMJ+RTaro= Received: from mail-ed1-f70.google.com (mail-ed1-f70.google.com [209.85.208.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-313-ZvTAtlwYPYiBFuPtPMzyiw-1; Fri, 13 Jan 2023 07:49:39 -0500 X-MC-Unique: ZvTAtlwYPYiBFuPtPMzyiw-1 Received: by mail-ed1-f70.google.com with SMTP id w3-20020a056402268300b00487e0d9b53fso14567630edd.10 for <59994@debbugs.gnu.org>; Fri, 13 Jan 2023 04:49:39 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=SwmCWbK1P/tcaFa3VVRBE/VIA59cy8PTj/G68BqdKzA=; b=VKlQuMI8vNxkfKa3o0GfbUKXUPx5QDpKi7cpNwMH07VRSqGKd8YbQolv+hAgU+NQos 9E7r+Ol60/gh/tZ18ki+mODoL8KD179Tm2GJyLKm6eqPT2AcdvX++PgRdxwDP5fv0IO2 xe8A3lmONyggLDDqJaOu4W5HxImBwQJqeRh9oWErYCNGEzpLi1Q3sgJtV3AcUh7VPh/Q ztOoecnl3p5yokfcQcVxESUdVLBF0RYCpgMGvCrr+kgiMpNqqHhNi8fGDXY6dtvuU822 oIC5OfWXeQwME1/L7b7fOQtRAj4FO2rCNHxmpjEINEj9fLM/GP1oEBXLBC5l2gsFJ4a3 tVkw== X-Gm-Message-State: AFqh2koTG+t9v4xtiDEGWUv7pQDYLNRwkdNQwLQ1M7HMdsFq/rLKUMz3 8X6k3AvFqCW6vczsWAZMGTPefeUmxIocQhJUgvpPcHn5znEAZgsqXiG/yPV7MpJg0SUhSMq6ZFg MnokQHuqtKkSc3tTzHqa5DYdI/fuwpAc= X-Received: by 2002:a17:906:234a:b0:84d:47e7:ac8a with SMTP id m10-20020a170906234a00b0084d47e7ac8amr1661902eja.250.1673614178768; Fri, 13 Jan 2023 04:49:38 -0800 (PST) X-Google-Smtp-Source: AMrXdXt53Y7LuZcOgKwFiT2wvXjyn/eXUaDbU0Ndpg+tMu+azKiO4A9EKMMKnN9xuzB6U1qCjXLYw1Ktao7fRQ/BeVA= X-Received: by 2002:a17:906:234a:b0:84d:47e7:ac8a with SMTP id m10-20020a170906234a00b0084d47e7ac8amr1661899eja.250.1673614178585; Fri, 13 Jan 2023 04:49:38 -0800 (PST) MIME-Version: 1.0 References: <20221212070752.1635797-1-fberat@redhat.com> <20230113063013.346F4340A8E@smtp.gentoo.org> In-Reply-To: <20230113063013.346F4340A8E@smtp.gentoo.org> From: Frederic Berat Date: Fri, 13 Jan 2023 13:49:27 +0100 Message-ID: Subject: Re: [bug#59994] [PATCH] tests: Don't try to prevent flex to include unistd.h To: Mike Frysinger X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: multipart/alternative; boundary="0000000000009b38b805f224aa63" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 59994 Cc: Zack Weinberg , 59994@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --0000000000009b38b805f224aa63 Content-Type: text/plain; charset="UTF-8" I probably won't be able to do so before next week at least. If you happen to have time (and be willing) to do it earlier, don't hesitate ;) On Fri, Jan 13, 2023 at 7:31 AM Mike Frysinger wrote: > On Mon, 12 Dec 2022 15:20:46 -0500, Zack Weinberg wrote: > > On 2022-12-12 2:07 AM, Frederic Berat wrote: > > > > > > This patch is mainly a proposal. While the macro can simply be removed > > > as explained below, another possibility it to add a flex option > > > "--never-interactive" to prevent flex to make use of "isatty". > > > > > > This is related to an effort to prepare Automake for future GCC/Clang > > > versions which set c99 as default standard to be used. > > > > > > Future version of flex make the "NO_UNISTD" flag a no-op, and include > > > unistd.h by default. > > > > > > In current version of flex, not having this header leads to implicit > > > function declarations that are not compatible with c99 standard. > > > > > > On top of that, while flex dedicated test were having this macro set, > > > the yacc ones didn't have it despise their use of Flex. Thus, if this > > > macro was ever useful, it looks like nobody actually cared. > > > > I'm guessing that the idea here was to avoid using unistd.h on platforms > > that don't supply that header at all. I suggest that we should apply > > your patch *and* consistently test flex with "--never-interactive". > > sounds fine. want to update your patch Frederic ? > -mike > > > > --0000000000009b38b805f224aa63 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
I probably won't be able to do so before next wee= k at least.
If you happen to have time (and be willing) to do it = earlier, don't hesitate ;)

On Fri, Jan 13, 2023 at 7:31 AM Mik= e Frysinger <vapier@gentoo.org&= gt; wrote:
On Mo= n, 12 Dec 2022 15:20:46 -0500, Zack Weinberg wrote:
> On 2022-12-12 2:07 AM, Frederic Berat wrote:
> >
> > This patch is mainly a proposal. While the macro can simply be re= moved
> > as explained below, another possibility it to add a flex option > > "--never-interactive" to prevent flex to make use of &q= uot;isatty".
> >
> > This is related to an effort to prepare Automake for future GCC/C= lang
> > versions which set c99 as default standard to be used.
> >
> > Future version of flex make the "NO_UNISTD" flag a no-o= p, and include
> > unistd.h by default.
> >
> > In current version of flex, not having this header leads to impli= cit
> > function declarations that are not compatible with c99 standard.<= br> > >
> > On top of that, while flex dedicated test were having this macro = set,
> > the yacc ones didn't have it despise their use of Flex. Thus,= if this
> > macro was ever useful, it looks like nobody actually cared.
>
> I'm guessing that the idea here was to avoid using unistd.h on pla= tforms
> that don't supply that header at all.=C2=A0 I suggest that we shou= ld apply
> your patch *and* consistently test flex with "--never-interactive= ".

sounds fine.=C2=A0 want to update your patch Frederic ?
-mike



--0000000000009b38b805f224aa63-- From debbugs-submit-bounces@debbugs.gnu.org Fri Jan 13 09:25:29 2023 Received: (at 59994) by debbugs.gnu.org; 13 Jan 2023 14:25:29 +0000 Received: from localhost ([127.0.0.1]:49993 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pGKzo-0000wS-OT for submit@debbugs.gnu.org; Fri, 13 Jan 2023 09:25:28 -0500 Received: from woodpecker.gentoo.org ([140.211.166.183]:48136 helo=smtp.gentoo.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pGKzm-0000w7-HS for 59994@debbugs.gnu.org; Fri, 13 Jan 2023 09:25:26 -0500 Received: by smtp.gentoo.org (Postfix, from userid 559) id 35F95340DF6; Fri, 13 Jan 2023 14:25:20 +0000 (UTC) Date: Fri, 13 Jan 2023 09:25:18 -0500 From: Mike Frysinger To: Frederic Berat Subject: Re: [bug#59994] [PATCH] tests: Don't try to prevent flex to include unistd.h Message-ID: References: <20221212070752.1635797-1-fberat@redhat.com> <20230113063013.346F4340A8E@smtp.gentoo.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="5iIkqZ29eLm7jrzO" Content-Disposition: inline In-Reply-To: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 59994 Cc: Zack Weinberg , 59994@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) --5iIkqZ29eLm7jrzO Content-Type: text/plain; charset=utf-8 Content-Disposition: inline On 13 Jan 2023 13:49, Frederic Berat wrote: > I probably won't be able to do so before next week at least. > If you happen to have time (and be willing) to do it earlier, don't > hesitate ;) that timeframe is fine. as you can see, we take a long view in Automake. -mike --5iIkqZ29eLm7jrzO Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEuQK1JxMl+JKsJRrUQWM7n+g39YEFAmPBac4ACgkQQWM7n+g3 9YF1nBAA5V2IOwhhA6n4MQ0KTt2qDiRmTqGwkCPkucQm1imWHa/aKdwoSaHOji5a /KGf76Q7zw401VIFw26PuhNSg7AohVhvKg14rbt3JOAXCut3cHb7PwXe65tYZt2t jEtaalZzaJXdzH0d3SsZZ3/jGO5hjsyzfyV5MsLz6CqN/1GqbQaWYY4sfyr+qSfX 86fqSClHK/rjOSi1iKanGDw/r3OL2cIE78WMCoa3myYQ0cB8tpZRKY1yqpj6QtQc HIN8TVN5+r79Uce2vBiT0GdIgdtkyg53E5Tl0p9GrDm6dSuptGi8dhcmd72/zBtg Q8cv7bQxFsGZdGQH7qINkm4nYZ9qh/mtv9V8cyFRL/FY+c42aILxrhf6Xy3lCZj1 /yiKwAeJF2VTvNAYxSOK1vx34WNFJxex2eI1Wr4LCgmGwQZRG3UmAyJto5CqYYV8 rVeBTJKeWlfU7h6N7Rti/Hg90GhDvsy4Hirv3SlwUbFpKdWwQhv0qIFYK44pcMoe 4WxlDqwMvplD9BQTcU85lmDAw1uUSVj9bx5UzEQ3V5teHiHQCJVMbT6i1YSiOgYg EJr7rRBTSD/fFZPhAjh80OSDSHHZSodMyRdh+QT3SUpn8zmgTYp3DzQp/Xhsdt8U 5bM4AsXl6YZDGWdxSqw6zqMCSaznrhLZso/cpVksxk6G8zuQYn8= =ou83 -----END PGP SIGNATURE----- --5iIkqZ29eLm7jrzO-- From debbugs-submit-bounces@debbugs.gnu.org Fri Jan 13 18:33:53 2023 Received: (at 59994) by debbugs.gnu.org; 13 Jan 2023 23:33:53 +0000 Received: from localhost ([127.0.0.1]:52692 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pGTYX-0008WV-5z for submit@debbugs.gnu.org; Fri, 13 Jan 2023 18:33:53 -0500 Received: from freefriends.org ([96.88.95.60]:41662) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pGTYU-0008WL-W0 for 59994@debbugs.gnu.org; Fri, 13 Jan 2023 18:33:51 -0500 X-Envelope-From: karl@freefriends.org Received: from freefriends.org (freefriends.org [96.88.95.60]) by freefriends.org (8.14.7/8.14.7) with ESMTP id 30DNXnpP020171 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 13 Jan 2023 16:33:50 -0700 Received: (from apache@localhost) by freefriends.org (8.14.7/8.14.7/Submit) id 30DNXm1R020170; Fri, 13 Jan 2023 16:33:48 -0700 Date: Fri, 13 Jan 2023 16:33:48 -0700 Message-Id: <202301132333.30DNXm1R020170@freefriends.org> From: Karl Berry To: vapier@gentoo.org Subject: Re: [bug#59994] [PATCH] tests: Don't try to prevent flex to include unistd.h In-Reply-To: <20230113063013.346F4340A8E@smtp.gentoo.org> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 59994 Cc: zack@owlfolio.org, fberat@redhat.com, 59994@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > your patch *and* consistently test flex with "--never-interactive". Making flex non-interactive sounds desirable in any case, but --never-interactive is not mentioned in the 2.6.0 --help message. Instead there is -B (--batch), although --never-interactive is recognized, I can see experimentally. I do not know when --never-interactive, or any of its variants, was implemented. We should check that before using it ... --thanks, karl. From debbugs-submit-bounces@debbugs.gnu.org Sat Jan 14 11:16:16 2023 Received: (at submit) by debbugs.gnu.org; 14 Jan 2023 16:16:16 +0000 Received: from localhost ([127.0.0.1]:55398 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pGjCa-00026b-8S for submit@debbugs.gnu.org; Sat, 14 Jan 2023 11:16:16 -0500 Received: from lists.gnu.org ([209.51.188.17]:33968) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pGjCX-00026R-8u for submit@debbugs.gnu.org; Sat, 14 Jan 2023 11:16:14 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pGjCW-0002ib-VK for automake-patches@gnu.org; Sat, 14 Jan 2023 11:16:12 -0500 Received: from wout3-smtp.messagingengine.com ([64.147.123.19]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pGjCU-0006Rk-5P for automake-patches@gnu.org; Sat, 14 Jan 2023 11:16:12 -0500 Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.west.internal (Postfix) with ESMTP id 428043200921 for ; Sat, 14 Jan 2023 11:16:08 -0500 (EST) Received: from imap45 ([10.202.2.95]) by compute1.internal (MEProxy); Sat, 14 Jan 2023 11:16:08 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=owlfolio.org; h= cc:content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm2; t=1673712967; x=1673799367; bh=UVFw6KoKt7 wvhNqwgU18vgD1FzDlHN5iw4CckCluMIc=; b=bpGn4UmCyFHXYWK0T2Z8ofJNM6 Qkpaq2nA43eHI2yWS0k4x1uW9rOx54WmUGAdLDEfPcwsAd4nqdAdRpA9LEgJXVNg H7BXFf7qrAQBq/CFhHZIOwbmCuS7qOC9TmY7ofiH4mN8ZTyFOXcDFfpOcBkZ9XKX FH9QMhmLN4EmpfCV9yQrHwUIFgZh8uvHUYYQXHIfS4R4Rsmi7WpjU41pWchGCaAe QpiGnvdNVv3JdZ9VGfuhOu/VbRMsbKjScpNvVGoHaVoq0LW+akTqIOjWcAXWcOqo /+o9/wRzSiB7+ncuzywj540YWeBukGc8zD/hKPiHicTbFbMDM7W8ZF3gPA2w== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm3; t=1673712967; x=1673799367; bh=UVFw6KoKt7wvhNqwgU18vgD1FzDl HN5iw4CckCluMIc=; b=InXMiTjKq15h2mmhrTbiokUktp257FuVsHVpqcEbqRES Nr2JXo8XbaGSDRhe1tHZG2gA+xTxY53BU+VamqIqHhbf6JXSoqdMuQ0EodGkcRW1 SWgNvuoK1J+LzWdMEJKTFTLHjp5lFD+cTexPL1yoY23/6q+mDsyjGG2VdppJUKHd SCa6Ou2cYodRAUxo6aHW3BAOEHoxC+UFMfZGLWrtg95ReyYW5tWN7khEdaMFfqIh nqERb56WNEteTfreb+9AeT2ZX+IKL6DDlN108tXr8bOT7CdswxxD5aavvuI+2wjv vcVdpcdV5Ki7/gCk/X+0Kt6Sz4tFxkmWPvKVqeYs+A== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedruddttddgkeeiucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpefofgggkfgjfhffhffvufgtsehttd ertderredtnecuhfhrohhmpedfkggrtghkucghvghinhgsvghrghdfuceoiigrtghkseho fihlfhholhhiohdrohhrgheqnecuggftrfgrthhtvghrnhepfeelvdetudetfeelgfefle dujeeutdduudegueeifefggfetvdfggfelgfeffeeknecuffhomhgrihhnpehgihhthhhu sgdrtghomhenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhroh hmpeiirggtkhesohiflhhfohhlihhordhorhhg X-ME-Proxy: Feedback-ID: i876146a2:Fastmail Received: by mailuser.nyi.internal (Postfix, from userid 501) id 90774272007E; Sat, 14 Jan 2023 11:16:07 -0500 (EST) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.7.0-alpha0-1187-g678636ba0d-fm-20230113.001-g678636ba Mime-Version: 1.0 Message-Id: <161430b4-f47b-4ce2-8506-e87402fcb7b8@app.fastmail.com> In-Reply-To: <202301132333.30DNXm1R020170@freefriends.org> References: <20221212070752.1635797-1-fberat@redhat.com> <202301132333.30DNXm1R020170@freefriends.org> Date: Sat, 14 Jan 2023 11:15:46 -0500 From: "Zack Weinberg" To: automake-patches@gnu.org Subject: Re: [bug#59994] [PATCH] tests: Don't try to prevent flex to include unistd.h Content-Type: text/plain Received-SPF: pass client-ip=64.147.123.19; envelope-from=zack@owlfolio.org; helo=wout3-smtp.messagingengine.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.6 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.6 (--) On Fri, Jan 13, 2023, at 6:33 PM, Karl Berry wrote: >> your patch *and* consistently test flex with "--never-interactive". > > Making flex non-interactive sounds desirable in any case, but > --never-interactive is not mentioned in the 2.6.0 --help message. > Instead there is -B (--batch), although --never-interactive is > recognized, I can see experimentally. --never-interactive is documented in the Texinfo manual ("Options Affecting Scanner Behavior" node). It looks to me like the --help output intentionally lists only the most commonly used options. --never-interactive and --batch are technically orthogonal. I don't know any reason a *real* scanner would want to use --never-interactive *without* --batch. However, to address the specific problem with *test* scanners we are discussing here, --never-interactive is what we want, because --never-interactive is the option that makes the generated code not call isatty(). > I do not know when --never-interactive, or any of its variants, was > implemented. We should check that before using it ... I'm pleasantly surprised to report that the Git repo for flex at has history going back all the way to 1987. The *feature* of optionally not calling isatty() on the input file has been present since version 2.5.1 (released 1995-03-28), in the form of `%option {always,never}-interactive` directives inside the scanner. The *command line option* --never-interactive was added in version 2.5.6 (along with long command line options in general). That version was released somewhere between 2002-04-19 and 2002-04-23; the exact date is not recorded anywhere I can find. zw From debbugs-submit-bounces@debbugs.gnu.org Sat Jan 14 16:34:34 2023 Received: (at 59994) by debbugs.gnu.org; 14 Jan 2023 21:34:34 +0000 Received: from localhost ([127.0.0.1]:55659 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pGoAb-0001vc-TN for submit@debbugs.gnu.org; Sat, 14 Jan 2023 16:34:34 -0500 Received: from freefriends.org ([96.88.95.60]:60250) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pGoAY-0001vS-9y for 59994@debbugs.gnu.org; Sat, 14 Jan 2023 16:34:32 -0500 X-Envelope-From: karl@freefriends.org Received: from freefriends.org (freefriends.org [96.88.95.60]) by freefriends.org (8.14.7/8.14.7) with ESMTP id 30ELYSBg006062 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sat, 14 Jan 2023 14:34:29 -0700 Received: (from apache@localhost) by freefriends.org (8.14.7/8.14.7/Submit) id 30ELYSjb006061; Sat, 14 Jan 2023 14:34:28 -0700 Date: Sat, 14 Jan 2023 14:34:28 -0700 Message-Id: <202301142134.30ELYSjb006061@freefriends.org> From: Karl Berry To: zack@owlfolio.org Subject: Re: [bug#59994] [PATCH] tests: Don't try to prevent flex to include unistd.h In-Reply-To: <161430b4-f47b-4ce2-8506-e87402fcb7b8@app.fastmail.com> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 59994 Cc: 59994@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) The *command line option* --never-interactive was added in version 2.5.6 (along with long command line options in general). That version was released somewhere between 2002-04-19 and 2002-04-23; I guess 20 years ago is long enough, barely :). Though if it's just as easy to use the %option, why not ... since we already have to assume flex (specifically) either way ... --thanks, karl. From debbugs-submit-bounces@debbugs.gnu.org Fri Jan 20 05:36:09 2023 Received: (at submit) by debbugs.gnu.org; 20 Jan 2023 10:36:09 +0000 Received: from localhost ([127.0.0.1]:45698 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pIokf-0001Pt-Q3 for submit@debbugs.gnu.org; Fri, 20 Jan 2023 05:36:09 -0500 Received: from lists.gnu.org ([209.51.188.17]:47998) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pIokb-0001PX-AK for submit@debbugs.gnu.org; Fri, 20 Jan 2023 05:36:04 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pIoka-0000Vr-T3 for automake-patches@gnu.org; Fri, 20 Jan 2023 05:36:00 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pIokX-0002ws-LS for automake-patches@gnu.org; Fri, 20 Jan 2023 05:36:00 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1674210956; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=FNMgsNrb1qVq9oq1aiFpbt50k+H0MUQMqM2RVz/a3TU=; b=fCrswbNbxNcW/FsSBS95T7WpRkjELVAphLW6RJrJ35u1YycKq4qmeyTQ2IAoXumPJNxwlF dYSitn2IEaZNeVEgwlMbN199UcqhhQYQy0uK5i+NePLdUX7zHhXcKVUy0+Uqb+ZILFXRLU sU5xdQsA26G1xIV8kDzVetjbT0zTZoU= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-480-myQNuKfIOieFIZaFr_PySQ-1; Fri, 20 Jan 2023 05:35:54 -0500 X-MC-Unique: myQNuKfIOieFIZaFr_PySQ-1 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 5156E85A588 for ; Fri, 20 Jan 2023 10:35:54 +0000 (UTC) Received: from Nymeria-redhat.redhat.com (unknown [10.39.192.231]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 5254D492B02 for ; Fri, 20 Jan 2023 10:35:53 +0000 (UTC) From: =?UTF-8?q?Fr=C3=A9d=C3=A9ric=20B=C3=A9rat?= To: automake-patches@gnu.org Subject: [PATCH v2] tests: Don't try to prevent flex to include unistd.h Date: Fri, 20 Jan 2023 11:35:44 +0100 Message-Id: <20230120103544.191349-1-fberat@redhat.com> In-Reply-To: <20221212070752.1635797-1-fberat@redhat.com> References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.10 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=170.10.133.124; envelope-from=fberat@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) Hello, Changes since v1: - The "--never-interactive" option is added to AM_LFLAGS whenever a yacc or lex test needs to execute make. Since there is quite a lot of files being modified, please review carefully. Hopefully, I didn't forget anything, nor edited files that were not needed, multiple sets of eyes may be useful here. -- 8< -- This patch is related to an effort to prepare Automake for future GCC/Clang versions which set c99 as default standard to be used. Future version of flex make the "NO_UNISTD" flag a no-op, and include unistd.h by default. In current version of flex, not having this header leads to implicit function declarations that are not compatible with c99 standard. On top of that, while flex dedicated test were having this macro set, the yacc ones didn't have it despise their use of Flex. For consistency, all the YACC/Flex related tests now have the "--never-interactive" option set in AM_LFLAGS. Modified files: * t/cond35.sh * t/lex-clean-cxx.sh * t/lex-clean.sh * t/lex-depend-cxx.sh * t/lex-depend.sh * t/lex-header.sh * t/lex-lib-external.sh * t/lex-lib.sh * t/lex-libobj.sh * t/lex-line.sh * t/lex-multiple.sh * t/lex-nodist.sh * t/lex-noyywrap.sh * t/lex-pr204.sh * t/lex-subobj-nodep.sh * t/lex3.sh * t/lex5.sh * t/lexvpath.sh * t/silent-lex.sh * t/silent-many-languages.sh * t/silent-yacc-headers.sh * t/silent-yacc.sh * t/subpkg-yacc.sh * t/suffix10.tap * t/yacc-auxdir.sh * t/yacc-basic.sh * t/yacc-bison-skeleton-cxx.sh * t/yacc-bison-skeleton.sh * t/yacc-clean-cxx.sh * t/yacc-clean.sh * t/yacc-cxx-grepping.sh * t/yacc-cxx.sh * t/yacc-d-basic.sh * t/yacc-d-cxx.sh * t/yacc-d-vpath.sh * t/yacc-deleted-headers.sh * t/yacc-depend.sh * t/yacc-depend2.sh * t/yacc-dist-nobuild-subdir.sh * t/yacc-dist-nobuild.sh * t/yacc-dry.sh * t/yacc-grepping.sh * t/yacc-grepping2.sh * t/yacc-headers-and-dist-pr47.sh * t/yacc-line.sh * t/yacc-misc.sh * t/yacc-mix-c-cxx.sh * t/yacc-nodist.sh * t/yacc-pr204.sh * t/yacc-subdir.sh * t/yacc-vpath.sh * t/yacc-weirdnames.sh * t/yflags-cmdline-override.sh * t/yflags-cxx.sh * t/yflags-d-false-positives.sh * t/yflags-force-conditional.sh * t/yflags-force-override.sh * t/yflags-var-expand.sh * t/yflags.sh --- t/cond35.sh | 4 +--- t/lex-clean-cxx.sh | 4 ++-- t/lex-clean.sh | 5 ++--- t/lex-depend-cxx.sh | 4 ++-- t/lex-depend.sh | 5 ++--- t/lex-header.sh | 6 ++---- t/lex-lib-external.sh | 5 ++--- t/lex-lib.sh | 5 ++--- t/lex-libobj.sh | 5 ++--- t/lex-line.sh | 7 ++++--- t/lex-multiple.sh | 7 +++---- t/lex-nodist.sh | 5 ++--- t/lex-noyywrap.sh | 5 ++--- t/lex-pr204.sh | 5 ++--- t/lex-subobj-nodep.sh | 5 ++--- t/lex3.sh | 5 ++--- t/lex5.sh | 4 +--- t/lexvpath.sh | 11 ++--------- t/silent-lex.sh | 7 ++++--- t/silent-many-languages.sh | 1 + t/silent-yacc-headers.sh | 1 + t/silent-yacc.sh | 4 ++++ t/subpkg-yacc.sh | 2 ++ t/suffix10.tap | 2 ++ t/yacc-auxdir.sh | 4 ++++ t/yacc-basic.sh | 2 ++ t/yacc-bison-skeleton-cxx.sh | 2 ++ t/yacc-bison-skeleton.sh | 2 ++ t/yacc-clean-cxx.sh | 2 ++ t/yacc-clean.sh | 2 ++ t/yacc-cxx-grepping.sh | 2 ++ t/yacc-cxx.sh | 2 ++ t/yacc-d-basic.sh | 2 ++ t/yacc-d-cxx.sh | 2 ++ t/yacc-d-vpath.sh | 2 ++ t/yacc-deleted-headers.sh | 2 ++ t/yacc-depend.sh | 2 ++ t/yacc-depend2.sh | 2 ++ t/yacc-dist-nobuild-subdir.sh | 2 ++ t/yacc-dist-nobuild.sh | 2 ++ t/yacc-dry.sh | 2 ++ t/yacc-grepping.sh | 2 ++ t/yacc-grepping2.sh | 2 ++ t/yacc-headers-and-dist-pr47.sh | 2 ++ t/yacc-line.sh | 4 ++++ t/yacc-misc.sh | 2 ++ t/yacc-mix-c-cxx.sh | 2 ++ t/yacc-nodist.sh | 2 ++ t/yacc-pr204.sh | 2 ++ t/yacc-subdir.sh | 2 ++ t/yacc-vpath.sh | 2 ++ t/yacc-weirdnames.sh | 2 ++ t/yflags-cmdline-override.sh | 2 ++ t/yflags-cxx.sh | 2 ++ t/yflags-d-false-positives.sh | 2 ++ t/yflags-force-conditional.sh | 2 ++ t/yflags-force-override.sh | 2 ++ t/yflags-var-expand.sh | 2 ++ t/yflags.sh | 2 ++ 59 files changed, 125 insertions(+), 63 deletions(-) diff --git a/t/cond35.sh b/t/cond35.sh index dc3b8aae9..8b044644e 100644 --- a/t/cond35.sh +++ b/t/cond35.sh @@ -30,6 +30,7 @@ EOF cat > Makefile.am <<'EOF' AM_YFLAGS = -d +AM_LFLAGS = --never-interactive BUILT_SOURCES = tparse.h @@ -58,9 +59,6 @@ $FGREP 'tparse.h' Makefile.in # For debugging. test $($FGREP -c 'tparse.h:' Makefile.in) -eq 1 cat > tscan.l << 'END' -%{ -#define YY_NO_UNISTD_H 1 -%} %% "END" return EOF; %% diff --git a/t/lex-clean-cxx.sh b/t/lex-clean-cxx.sh index 3632d5c87..9f628accd 100644 --- a/t/lex-clean-cxx.sh +++ b/t/lex-clean-cxx.sh @@ -29,6 +29,8 @@ AC_OUTPUT END cat > Makefile.am << 'END' +AM_LFLAGS = --never-interactive + bin_PROGRAMS = foo bar baz qux foo_SOURCES = mainfoo.cc parsefoo.lxx @@ -55,8 +57,6 @@ cat > parsefoo.lxx << 'END' %{ #define YY_DECL int yylex (void) extern "C" YY_DECL; -#define YY_NO_UNISTD_H 1 -int isatty (int fd) { return 0; } %} %% "GOOD" return EOF; diff --git a/t/lex-clean.sh b/t/lex-clean.sh index 1ee7d8f5b..4668e97c7 100644 --- a/t/lex-clean.sh +++ b/t/lex-clean.sh @@ -29,6 +29,8 @@ AC_OUTPUT END cat > Makefile.am << 'END' +AM_LFLAGS = --never-interactive + bin_PROGRAMS = foo bar baz qux foo_SOURCES = main.c lexer.l @@ -52,9 +54,6 @@ LDADD = $(LEXLIB) END cat > lexer.l << 'END' -%{ -#define YY_NO_UNISTD_H 1 -%} %% "GOOD" return EOF; . diff --git a/t/lex-depend-cxx.sh b/t/lex-depend-cxx.sh index 60615a54e..51bd67b7b 100644 --- a/t/lex-depend-cxx.sh +++ b/t/lex-depend-cxx.sh @@ -27,6 +27,8 @@ AC_OUTPUT END cat > Makefile.am << 'END' +AM_LFLAGS = --never-interactive + noinst_PROGRAMS = joe moe joe_SOURCES = joe.ll moe_SOURCES = moe.l++ @@ -48,8 +50,6 @@ cat > joe.ll << 'END' %{ #define YY_DECL int yylex (void) extern "C" YY_DECL; -#define YY_NO_UNISTD_H 1 -int isatty (int fd) { return 0; } %} %% "foo" return EOF; diff --git a/t/lex-depend.sh b/t/lex-depend.sh index 16f937ef1..68cc5ee7b 100644 --- a/t/lex-depend.sh +++ b/t/lex-depend.sh @@ -27,6 +27,8 @@ AC_OUTPUT END cat > Makefile.am << 'END' +AM_LFLAGS = --never-interactive + bin_PROGRAMS = zoo zoo_SOURCES = joe.l LDADD = $(LEXLIB) @@ -42,9 +44,6 @@ test-obj-updated: joe.$(OBJEXT) END cat > joe.l << 'END' -%{ -#define YY_NO_UNISTD_H 1 -%} %% "foo" return EOF; . diff --git a/t/lex-header.sh b/t/lex-header.sh index 22567642e..48b42457a 100644 --- a/t/lex-header.sh +++ b/t/lex-header.sh @@ -33,6 +33,8 @@ AC_OUTPUT END cat > Makefile.am << 'END' +AM_LFLAGS = --never-interactive + bin_PROGRAMS = foo foo_SOURCES = lexer.l main.c mylex.h foo_LFLAGS = --header-file=mylex.h @@ -45,9 +47,6 @@ END cat > lexer.l << 'END' %option noyywrap -%{ -#define YY_NO_UNISTD_H 1 -%} %% "GOOD" return EOF; . @@ -55,7 +54,6 @@ cat > lexer.l << 'END' END cat > main.c <<'END' -#define YY_NO_UNISTD_H 1 #include "mylex.h" int main (void) { diff --git a/t/lex-lib-external.sh b/t/lex-lib-external.sh index 85403612f..25ad2a39b 100644 --- a/t/lex-lib-external.sh +++ b/t/lex-lib-external.sh @@ -28,6 +28,8 @@ AC_OUTPUT END cat > Makefile.am << 'END' +AM_LFLAGS = --never-interactive + bin_PROGRAMS = lexer lexer_SOURCES = foo.l lexer_LDADD = $(LEXLIB) @@ -42,9 +44,6 @@ have-lexlib: END cat > foo.l <<'END' -%{ -#define YY_NO_UNISTD_H 1 -%} %% "GOOD" return EOF; . diff --git a/t/lex-lib.sh b/t/lex-lib.sh index f0a0d37f6..7734fd228 100644 --- a/t/lex-lib.sh +++ b/t/lex-lib.sh @@ -31,6 +31,8 @@ AC_OUTPUT END cat > Makefile.am << 'END' +AM_LFLAGS = --never-interactive + bin_PROGRAMS = lexer lexer_SOURCES = foo.l lexer_LDADD = $(LEXLIB) @@ -47,9 +49,6 @@ int yywrap (void) END cat > foo.l <<'END' -%{ -#define YY_NO_UNISTD_H 1 -%} %% "END" return EOF; . diff --git a/t/lex-libobj.sh b/t/lex-libobj.sh index b26381fcf..6e36a98ed 100644 --- a/t/lex-libobj.sh +++ b/t/lex-libobj.sh @@ -32,6 +32,8 @@ AC_OUTPUT END cat > Makefile.am << 'END' +AM_LFLAGS = --never-interactive + noinst_PROGRAMS = foo foo_SOURCES = foo.l foo_LDADD = $(LEXLIB) $(LIBOBJS) @@ -45,9 +47,6 @@ int yywrap (void) END cat > foo.l <<'END' -%{ -#define YY_NO_UNISTD_H 1 -%} %% "END" return EOF; . diff --git a/t/lex-line.sh b/t/lex-line.sh index 340800ef2..5f9145847 100644 --- a/t/lex-line.sh +++ b/t/lex-line.sh @@ -32,6 +32,8 @@ END mkdir dir sub sub/dir cat > Makefile.am << 'END' +AM_LFLAGS = --never-interactive + SUBDIRS = sub bin_PROGRAMS = foo bar LDADD = $(LEXLIB) @@ -44,6 +46,8 @@ bar-quux.@OBJEXT@: bar-quux.c END cat > sub/Makefile.am << 'END' +AM_LFLAGS = --never-interactive + AUTOMAKE_OPTIONS = subdir-objects noinst_PROGRAMS = foo bar ## We already used $(LEXLIB) above, so try @LEXLIB@ now. @@ -57,9 +61,6 @@ dir/quux.@OBJEXT@: dir/quux.c END cat > zardoz.l << 'END' -%{ -#define YY_NO_UNISTD_H 1 -%} %% "END" return EOF; . diff --git a/t/lex-multiple.sh b/t/lex-multiple.sh index 9565bd6b8..6486a012f 100644 --- a/t/lex-multiple.sh +++ b/t/lex-multiple.sh @@ -31,7 +31,9 @@ AC_PROG_RANLIB AC_OUTPUT END -cat > Makefile.am << 'END' +cat > Makefile.am << 'END' +AM_LFLAGS = --never-interactive + bin_PROGRAMS = zardoz zardoz_SOURCES = main.c @@ -72,9 +74,6 @@ int main (int argc, char *argv[]) END cat > 0.l << 'END' -%{ -#define YY_NO_UNISTD_H 1 -%} %% "VANILLA" { printf (":%s:\n", yytext); return 121; } . { printf (":%s:\n", yytext); return 1; } diff --git a/t/lex-nodist.sh b/t/lex-nodist.sh index 73e23a13e..d499aea7f 100644 --- a/t/lex-nodist.sh +++ b/t/lex-nodist.sh @@ -31,6 +31,8 @@ AC_OUTPUT END cat > Makefile.am << 'END' +AM_LFLAGS = --never-interactive + .PHONY: test-build test-dist test-build: all ls -l @@ -45,9 +47,6 @@ check-local: test-build test-dist lexer.l: rm -f $@ $@-t :; { : \ - && echo '%{' \ - && echo '#define YY_NO_UNISTD_H 1' \ - && echo '%}' \ && echo '%%' \ && echo '"GOOD" return EOF;' \ && echo '.'; \ diff --git a/t/lex-noyywrap.sh b/t/lex-noyywrap.sh index 1c61a1ab3..5ec68b9ba 100644 --- a/t/lex-noyywrap.sh +++ b/t/lex-noyywrap.sh @@ -26,6 +26,8 @@ AC_OUTPUT END cat > Makefile.am << 'END' +AM_LFLAGS = --never-interactive + bin_PROGRAMS = foo foo_SOURCES = foo.l @@ -37,9 +39,6 @@ END cat > foo.l << 'END' %option noyywrap -%{ -#define YY_NO_UNISTD_H 1 -%} %% "GOOD" return EOF; . diff --git a/t/lex-pr204.sh b/t/lex-pr204.sh index ebfaafef5..cbad1c266 100644 --- a/t/lex-pr204.sh +++ b/t/lex-pr204.sh @@ -35,6 +35,8 @@ EOF # The LEXER2 intermediate variable is there to make sure Automake # matches 'nodist_' against the right variable name... cat > Makefile.am << 'EOF' +AM_LFLAGS = --never-interactive + EXTRA_PROGRAMS = foo LEXER2 = lexer2.l nodist_foo_SOURCES = lexer.l $(LEXER2) @@ -49,9 +51,6 @@ distdirtest: distdir EOF cat > lexer.l << 'END' -%{ -#define YY_NO_UNISTD_H 1 -%} %% "GOOD" return EOF; . diff --git a/t/lex-subobj-nodep.sh b/t/lex-subobj-nodep.sh index f8bb87a9c..8ef4d68b1 100644 --- a/t/lex-subobj-nodep.sh +++ b/t/lex-subobj-nodep.sh @@ -28,6 +28,8 @@ END cat >Makefile.am <<\END AUTOMAKE_OPTIONS = subdir-objects +AM_LFLAGS = --never-interactive + bin_PROGRAMS = p1 p2 p1_SOURCES = sub1/s1.l p2_SOURCES = sub2/s2.l @@ -37,9 +39,6 @@ END mkdir sub1 sub2 cat >sub1/s1.l <<\END -%{ -#define YY_NO_UNISTD_H 1 -%} %% "END" return EOF; . diff --git a/t/lex3.sh b/t/lex3.sh index 41b87dc06..4a20f85da 100644 --- a/t/lex3.sh +++ b/t/lex3.sh @@ -28,14 +28,13 @@ AC_OUTPUT END cat > Makefile.am << 'END' +AM_LFLAGS = --never-interactive + noinst_PROGRAMS = foo foo_SOURCES = foo.l END cat > foo.l << 'END' -%{ -#define YY_NO_UNISTD_H 1 -%} %% "GOOD" return EOF; . diff --git a/t/lex5.sh b/t/lex5.sh index 3d84d9b41..687903e65 100644 --- a/t/lex5.sh +++ b/t/lex5.sh @@ -28,6 +28,7 @@ END cat > Makefile.am << 'END' AUTOMAKE_OPTIONS = subdir-objects LDADD = @LEXLIB@ +AM_LFLAGS = --never-interactive bin_PROGRAMS = foo/foo foo_foo_SOURCES = foo/foo.l @@ -36,9 +37,6 @@ END mkdir foo cat > foo/foo.l << 'END' -%{ -#define YY_NO_UNISTD_H 1 -%} %% "END" return EOF; . diff --git a/t/lexvpath.sh b/t/lexvpath.sh index 5185a1f71..d064fd2bd 100644 --- a/t/lexvpath.sh +++ b/t/lexvpath.sh @@ -37,6 +37,8 @@ AC_OUTPUT END cat > Makefile.am << 'END' +AM_LFLAGS = --never-interactive + bin_PROGRAMS = foo foo_SOURCES = lexer.l foo.c LDADD = $(LEXLIB) @@ -44,9 +46,6 @@ END # Original lexer, with a "foobar" comment cat > lexer.l << 'END' -%{ -#define YY_NO_UNISTD_H 1 -%} %% "END" return EOF; . @@ -89,9 +88,6 @@ $sleep # New lexer, with 'fubar' comment. cat > ../lexer.l << 'END' -%{ -#define YY_NO_UNISTD_H 1 -%} %% "END" return EOF; . @@ -112,9 +108,6 @@ $sleep # New lexer, with 'maude' comment. cat > ../lexer.l << 'END' -%{ -#define YY_NO_UNISTD_H 1 -%} %% "END" return EOF; . diff --git a/t/silent-lex.sh b/t/silent-lex.sh index cfe1a9b5d..e424afc38 100644 --- a/t/silent-lex.sh +++ b/t/silent-lex.sh @@ -28,6 +28,8 @@ AC_OUTPUT EOF cat > Makefile.am <<'EOF' +AM_LFLAGS = --never-interactive + # Need generic and non-generic rules. bin_PROGRAMS = foo1 foo2 foo1_SOURCES = foo.l @@ -40,6 +42,8 @@ EOF cat > sub/Makefile.am <<'EOF' AUTOMAKE_OPTIONS = subdir-objects +AM_LFLAGS = --never-interactive + # Need generic and non-generic rules. bin_PROGRAMS = bar1 bar2 bar1_SOURCES = bar.l @@ -50,9 +54,6 @@ LDADD = $(LEXLIB) EOF cat > foo.l <<'EOF' -%{ -#define YY_NO_UNISTD_H 1 -%} %% "END" return EOF; . diff --git a/t/silent-many-languages.sh b/t/silent-many-languages.sh index 4edb46884..85773d339 100644 --- a/t/silent-many-languages.sh +++ b/t/silent-many-languages.sh @@ -151,6 +151,7 @@ ba2_YFLAGS = -v ba2_LFLAGS = -n ba2_LDADD = $(LEXLIB) AM_YFLAGS = -d +AM_LFLAGS = --never-interactive BUILT_SOURCES = baz6.h EOF diff --git a/t/silent-yacc-headers.sh b/t/silent-yacc-headers.sh index 98ae45b8a..f64342c82 100644 --- a/t/silent-yacc-headers.sh +++ b/t/silent-yacc-headers.sh @@ -31,6 +31,7 @@ EOF cat > Makefile.am <<'EOF' # Need generic and non-generic rules. AM_YFLAGS = -d +AM_LFLAGS = --never-interactive bin_PROGRAMS = foo bar foo_SOURCES = parse.y bar_SOURCES = $(foo_SOURCES) diff --git a/t/silent-yacc.sh b/t/silent-yacc.sh index 9645aff83..d89ff49a7 100644 --- a/t/silent-yacc.sh +++ b/t/silent-yacc.sh @@ -29,6 +29,8 @@ AC_OUTPUT EOF cat > Makefile.am <<'EOF' +AM_LFLAGS = --never-interactive + # Need generic and non-generic rules. bin_PROGRAMS = foo1 foo2 foo1_SOURCES = foo.y @@ -40,6 +42,8 @@ EOF cat > sub/Makefile.am <<'EOF' AUTOMAKE_OPTIONS = subdir-objects +AM_LFLAGS = --never-interactive + # Need generic and non-generic rules. bin_PROGRAMS = bar1 bar2 bar1_SOURCES = bar.y diff --git a/t/subpkg-yacc.sh b/t/subpkg-yacc.sh index edd14532b..782ee0957 100644 --- a/t/subpkg-yacc.sh +++ b/t/subpkg-yacc.sh @@ -61,6 +61,8 @@ AC_OUTPUT EOF cat >lib/Makefile.am <<'EOF' +AM_LFLAGS = --never-interactive + noinst_LIBRARIES = liblib.a liblib_a_SOURCES = src/x.c foo.y EXTRA_liblib_a_SOURCES = bar.y diff --git a/t/suffix10.tap b/t/suffix10.tap index 3869d07fd..8d3dc1756 100644 --- a/t/suffix10.tap +++ b/t/suffix10.tap @@ -31,6 +31,8 @@ AC_OUTPUT EOF cat >Makefile.am << 'END' +AM_LFLAGS = --never-interactive + lib_LTLIBRARIES = libfoo.la libfoo_la_SOURCES = foo.x_ .x_.y: diff --git a/t/yacc-auxdir.sh b/t/yacc-auxdir.sh index be8ac4fd4..f6ff7de48 100644 --- a/t/yacc-auxdir.sh +++ b/t/yacc-auxdir.sh @@ -35,12 +35,16 @@ cat > Makefile.am << 'END' SUBDIRS = sub bin_PROGRAMS = foo AM_YFLAGS = -d +AM_LFLAGS = --never-interactive + foo_SOURCES = foo.y END cat > sub/Makefile.am << 'END' bin_PROGRAMS = bar AM_YFLAGS = -d +AM_LFLAGS = --never-interactive + bar_SOURCES = bar.y main.c END diff --git a/t/yacc-basic.sh b/t/yacc-basic.sh index b7a35bd39..51ee5f6a3 100644 --- a/t/yacc-basic.sh +++ b/t/yacc-basic.sh @@ -27,6 +27,8 @@ AC_OUTPUT END cat > Makefile.am << 'END' +AM_LFLAGS = --never-interactive + bin_PROGRAMS = foo bar foo_SOURCES = parse.y foo.c bar_SOURCES = $(foo_SOURCES) diff --git a/t/yacc-bison-skeleton-cxx.sh b/t/yacc-bison-skeleton-cxx.sh index bded1a34f..da76238fa 100644 --- a/t/yacc-bison-skeleton-cxx.sh +++ b/t/yacc-bison-skeleton-cxx.sh @@ -27,6 +27,8 @@ AC_OUTPUT END cat > Makefile.am << 'END' +AM_LFLAGS = --never-interactive + bin_PROGRAMS = zardoz zardoz_SOURCES = zardoz.yy foo.cc diff --git a/t/yacc-bison-skeleton.sh b/t/yacc-bison-skeleton.sh index b77b29f1e..11b64b831 100644 --- a/t/yacc-bison-skeleton.sh +++ b/t/yacc-bison-skeleton.sh @@ -31,6 +31,8 @@ cat > Makefile.am << 'END' bin_PROGRAMS = zardoz zardoz_SOURCES = zardoz.y foo.c AM_YFLAGS = -d --skeleton glr.c +AM_LFLAGS = --never-interactive + BUILT_SOURCES = zardoz.h END diff --git a/t/yacc-clean-cxx.sh b/t/yacc-clean-cxx.sh index d12e02308..71eb4f315 100644 --- a/t/yacc-clean-cxx.sh +++ b/t/yacc-clean-cxx.sh @@ -39,6 +39,8 @@ END mkdir sub1 sub2 cat > sub1/Makefile.am << 'END' +AM_LFLAGS = --never-interactive + bin_PROGRAMS = foo bar baz qux foo_SOURCES = mainfoo.cc parsefoo.yxx diff --git a/t/yacc-clean.sh b/t/yacc-clean.sh index 0baf0afd8..d0f793843 100644 --- a/t/yacc-clean.sh +++ b/t/yacc-clean.sh @@ -38,6 +38,8 @@ END mkdir sub1 sub2 cat > sub1/Makefile.am << 'END' +AM_LFLAGS = --never-interactive + bin_PROGRAMS = foo bar baz qux foo_SOURCES = main.c parse.y diff --git a/t/yacc-cxx-grepping.sh b/t/yacc-cxx-grepping.sh index 7b3a6bc5e..e094d5f16 100644 --- a/t/yacc-cxx-grepping.sh +++ b/t/yacc-cxx-grepping.sh @@ -27,6 +27,8 @@ AC_PROG_YACC END cat > Makefile.am << 'END' +AM_LFLAGS = --never-interactive + bin_PROGRAMS = foo bar baz qux foo_SOURCES = foo.y++ bar_SOURCES = bar.ypp diff --git a/t/yacc-cxx.sh b/t/yacc-cxx.sh index 1bf75a975..52fca8c01 100644 --- a/t/yacc-cxx.sh +++ b/t/yacc-cxx.sh @@ -28,6 +28,8 @@ AC_OUTPUT END cat > Makefile.am << 'END' +AM_LFLAGS = --never-interactive + bin_PROGRAMS = foo1 foo2 foo3 foo4 foo1_SOURCES = parse1.yy foo.cc foo2_SOURCES = parse2.y++ bar.c++ diff --git a/t/yacc-d-basic.sh b/t/yacc-d-basic.sh index fe80a0888..166111fdb 100644 --- a/t/yacc-d-basic.sh +++ b/t/yacc-d-basic.sh @@ -35,6 +35,8 @@ END mkdir foo bar baz cat > foo/Makefile.am <<'END' +AM_LFLAGS = --never-interactive + bin_PROGRAMS = zardoz zardoz_SOURCES = parse.y main.c .PHONY: echo-distcom diff --git a/t/yacc-d-cxx.sh b/t/yacc-d-cxx.sh index 56f43c940..5f9a09a46 100644 --- a/t/yacc-d-cxx.sh +++ b/t/yacc-d-cxx.sh @@ -67,6 +67,8 @@ mkdir foo bar baz qux baz/sub # These makefiles will be extended later. cat > Makefile.am <<'END' +AM_LFLAGS = --never-interactive + .PHONY: echo-distcom echo-distcom: @echo ' ' $(DIST_COMMON) ' ' diff --git a/t/yacc-d-vpath.sh b/t/yacc-d-vpath.sh index dced4818f..3dcf17ade 100644 --- a/t/yacc-d-vpath.sh +++ b/t/yacc-d-vpath.sh @@ -32,6 +32,8 @@ AC_OUTPUT END cat > Makefile.am << 'END' +AM_LFLAGS = --never-interactive + bin_PROGRAMS = foo foo_SOURCES = parse.y foo.c AM_YFLAGS = -d diff --git a/t/yacc-deleted-headers.sh b/t/yacc-deleted-headers.sh index c3fdbeee4..8c27dcefb 100644 --- a/t/yacc-deleted-headers.sh +++ b/t/yacc-deleted-headers.sh @@ -26,6 +26,8 @@ AC_OUTPUT END cat > Makefile.am <<'END' +AM_LFLAGS = --never-interactive + bin_PROGRAMS = p1 p2 p3 p4 # The order in which files are listed in the p*_SOURCES variables # below is significant, since it causes make failures whenever diff --git a/t/yacc-depend.sh b/t/yacc-depend.sh index cf544359f..d1e09bc39 100644 --- a/t/yacc-depend.sh +++ b/t/yacc-depend.sh @@ -29,6 +29,8 @@ END cat > Makefile.am << 'END' bin_PROGRAMS = foo AM_YFLAGS = -d +AM_LFLAGS = --never-interactive + foo_SOURCES = foo.y main.c BUILT_SOURCES = foo.h END diff --git a/t/yacc-depend2.sh b/t/yacc-depend2.sh index a61e4957d..a52d4489f 100644 --- a/t/yacc-depend2.sh +++ b/t/yacc-depend2.sh @@ -28,6 +28,8 @@ AC_OUTPUT END cat > Makefile.am << 'END' +AM_LFLAGS = --never-interactive + bin_PROGRAMS = foo AM_YFLAGS = -d foo_SOURCES = foo.y main.c diff --git a/t/yacc-dist-nobuild-subdir.sh b/t/yacc-dist-nobuild-subdir.sh index d1788811f..56320fe48 100644 --- a/t/yacc-dist-nobuild-subdir.sh +++ b/t/yacc-dist-nobuild-subdir.sh @@ -49,6 +49,8 @@ END cat > Makefile.am <<'END' AUTOMAKE_OPTIONS = subdir-objects +AM_LFLAGS = --never-interactive + noinst_PROGRAMS = foo bar foo_SOURCES = sub/parse.y bar_SOURCES = $(foo_SOURCES) diff --git a/t/yacc-dist-nobuild.sh b/t/yacc-dist-nobuild.sh index a30fefec2..71be0d52c 100644 --- a/t/yacc-dist-nobuild.sh +++ b/t/yacc-dist-nobuild.sh @@ -28,6 +28,8 @@ AC_OUTPUT END cat > Makefile.am << 'END' +AM_LFLAGS = --never-interactive + bin_PROGRAMS = foobar zardoz foobar_SOURCES = parse.y main.c zardoz_SOURCES = $(foobar_SOURCES) diff --git a/t/yacc-dry.sh b/t/yacc-dry.sh index 9b08d3863..6500ba811 100644 --- a/t/yacc-dry.sh +++ b/t/yacc-dry.sh @@ -26,6 +26,8 @@ AC_OUTPUT END cat > Makefile.am << 'END' +AM_LFLAGS = --never-interactive + AM_YFLAGS = -d bin_PROGRAMS = foo foo_SOURCES = foo.c parse.y diff --git a/t/yacc-grepping.sh b/t/yacc-grepping.sh index b0cf91353..67381ba89 100644 --- a/t/yacc-grepping.sh +++ b/t/yacc-grepping.sh @@ -35,6 +35,8 @@ END $ACLOCAL cat > Makefile.am <<'END' +AM_LFLAGS = --never-interactive + bin_PROGRAMS = zardoz zardoz_SOURCES = zardoz.y END diff --git a/t/yacc-grepping2.sh b/t/yacc-grepping2.sh index 159dd3e15..4af321fbe 100644 --- a/t/yacc-grepping2.sh +++ b/t/yacc-grepping2.sh @@ -25,6 +25,8 @@ AC_PROG_YACC END cat > Makefile.am << 'END' +AM_LFLAGS = --never-interactive + bin_PROGRAMS = maude maude_SOURCES = sub/maude.y END diff --git a/t/yacc-headers-and-dist-pr47.sh b/t/yacc-headers-and-dist-pr47.sh index 57c8251ad..74ec525f9 100644 --- a/t/yacc-headers-and-dist-pr47.sh +++ b/t/yacc-headers-and-dist-pr47.sh @@ -30,6 +30,8 @@ AC_OUTPUT END cat > Makefile.am << 'END' +AM_LFLAGS = --never-interactive + bin_PROGRAMS = foo foo_SOURCES = foo.y AM_YFLAGS = -d diff --git a/t/yacc-line.sh b/t/yacc-line.sh index e7a4d6244..2319c9791 100644 --- a/t/yacc-line.sh +++ b/t/yacc-line.sh @@ -32,6 +32,8 @@ END mkdir dir sub sub/dir cat > Makefile.am << 'END' +AM_LFLAGS = --never-interactive + SUBDIRS = sub bin_PROGRAMS = foo bar AM_YFLAGS = -d @@ -45,6 +47,8 @@ END cat > sub/Makefile.am << 'END' AUTOMAKE_OPTIONS = subdir-objects +AM_LFLAGS = --never-interactive + noinst_PROGRAMS = foo bar foo_YFLAGS = -d foo_SOURCES = zardoz.y diff --git a/t/yacc-misc.sh b/t/yacc-misc.sh index 2bfb0c55e..fcc19aa49 100644 --- a/t/yacc-misc.sh +++ b/t/yacc-misc.sh @@ -26,6 +26,8 @@ AC_OUTPUT END cat > Makefile.am << 'END' +AM_LFLAGS = --never-interactive + bin_PROGRAMS = foo bar foo_SOURCES = parse.y foo.c bar_SOURCES = bar.y foo.c diff --git a/t/yacc-mix-c-cxx.sh b/t/yacc-mix-c-cxx.sh index a73935c39..bb58bb6fa 100644 --- a/t/yacc-mix-c-cxx.sh +++ b/t/yacc-mix-c-cxx.sh @@ -28,6 +28,8 @@ AC_OUTPUT END cat > Makefile.am << 'END' +AM_LFLAGS = --never-interactive + bin_PROGRAMS = c1 c2 cxx1 cxx2 cxx3 AM_YFLAGS = -d diff --git a/t/yacc-nodist.sh b/t/yacc-nodist.sh index dbb86bdb2..8e5338e94 100644 --- a/t/yacc-nodist.sh +++ b/t/yacc-nodist.sh @@ -31,6 +31,8 @@ AC_OUTPUT END cat > Makefile.am << 'END' +AM_LFLAGS = --never-interactive + SUBDIRS = sub1 sub2 .PHONY: test-build test-dist test-build: all diff --git a/t/yacc-pr204.sh b/t/yacc-pr204.sh index 91882e4d7..89acb1ee0 100644 --- a/t/yacc-pr204.sh +++ b/t/yacc-pr204.sh @@ -34,6 +34,8 @@ EOF # sure Automake match 'nodist_' against the right # variable name... cat > Makefile.am << 'EOF' +AM_LFLAGS = --never-interactive + AM_YFLAGS = -d EXTRA_PROGRAMS = foo PARSE2 = parse2.y diff --git a/t/yacc-subdir.sh b/t/yacc-subdir.sh index df31a3c51..d6c3f0cc8 100644 --- a/t/yacc-subdir.sh +++ b/t/yacc-subdir.sh @@ -28,6 +28,8 @@ END cat > Makefile.am << 'END' AUTOMAKE_OPTIONS = subdir-objects +AM_LFLAGS = --never-interactive + bin_PROGRAMS = foo/foo foo_foo_SOURCES = foo/parse.y AM_YFLAGS = -d diff --git a/t/yacc-vpath.sh b/t/yacc-vpath.sh index 52d2c45bd..42044ecf2 100644 --- a/t/yacc-vpath.sh +++ b/t/yacc-vpath.sh @@ -32,6 +32,8 @@ AC_OUTPUT END cat > Makefile.am << 'END' +AM_LFLAGS = --never-interactive + bin_PROGRAMS = foo foo_SOURCES = parse.y foo.c END diff --git a/t/yacc-weirdnames.sh b/t/yacc-weirdnames.sh index 60f199d2d..8397bc636 100644 --- a/t/yacc-weirdnames.sh +++ b/t/yacc-weirdnames.sh @@ -27,6 +27,8 @@ AC_OUTPUT END cat > Makefile.am << 'END' +AM_LFLAGS = --never-interactive + bin_PROGRAMS = foo bar foo2 bar2 foo_SOURCES = parse.y.y diff --git a/t/yflags-cmdline-override.sh b/t/yflags-cmdline-override.sh index 37304645c..73982753a 100644 --- a/t/yflags-cmdline-override.sh +++ b/t/yflags-cmdline-override.sh @@ -27,6 +27,8 @@ AC_OUTPUT END cat > Makefile.am <<'END' +AM_LFLAGS = --never-interactive + bin_PROGRAMS = foo foo_SOURCES = foo.y # A minor automake wart: automake doesn't generate code to clean diff --git a/t/yflags-cxx.sh b/t/yflags-cxx.sh index 9bd28b8ce..2596a95e3 100644 --- a/t/yflags-cxx.sh +++ b/t/yflags-cxx.sh @@ -39,6 +39,8 @@ END cat > Makefile.am <<'END' AUTOMAKE_OPTIONS = no-dependencies +AM_LFLAGS = --never-interactive + bin_PROGRAMS = foo bar foo_SOURCES = main.cc foo.yy bar_SOURCES = main.cc bar.y++ diff --git a/t/yflags-d-false-positives.sh b/t/yflags-d-false-positives.sh index 21efb2345..666dbe938 100644 --- a/t/yflags-d-false-positives.sh +++ b/t/yflags-d-false-positives.sh @@ -26,6 +26,8 @@ END $ACLOCAL cat > Makefile.am <<'END' +AM_LFLAGS = --never-interactive + bin_PROGRAMS = zardoz foobar zardoz_SOURCES = zardoz.y foobar_SOURCES = foobar.y diff --git a/t/yflags-force-conditional.sh b/t/yflags-force-conditional.sh index 3f9a13293..976b6f782 100644 --- a/t/yflags-force-conditional.sh +++ b/t/yflags-force-conditional.sh @@ -38,6 +38,8 @@ YACC=fake-yacc; export YACC cat > Makefile.am <<'END' AUTOMAKE_OPTIONS = no-dependencies +AM_LFLAGS = --never-interactive + bin_PROGRAMS = foo bar foo_SOURCES = foo.y main.c bar_SOURCES = $(foo_SOURCES) diff --git a/t/yflags-force-override.sh b/t/yflags-force-override.sh index b1c36ef0f..7c865935b 100644 --- a/t/yflags-force-override.sh +++ b/t/yflags-force-override.sh @@ -28,6 +28,8 @@ AC_OUTPUT END cat > Makefile.am <<'END' +AM_LFLAGS = --never-interactive + bin_PROGRAMS = foo foo_SOURCES = foo.y # Don't do this in a real-life Makefile.am! diff --git a/t/yflags-var-expand.sh b/t/yflags-var-expand.sh index 0e06e0d9c..bf34922a6 100644 --- a/t/yflags-var-expand.sh +++ b/t/yflags-var-expand.sh @@ -29,6 +29,8 @@ END $ACLOCAL cat > Makefile.am <<'END' +AM_LFLAGS = --never-interactive + bin_PROGRAMS = foo bar foo_SOURCES = foo.y bar_SOURCES = bar.y diff --git a/t/yflags.sh b/t/yflags.sh index 1f73776f8..2359a76b7 100644 --- a/t/yflags.sh +++ b/t/yflags.sh @@ -39,6 +39,8 @@ END cat > Makefile.am <<'END' AUTOMAKE_OPTIONS = no-dependencies +AM_LFLAGS = --never-interactive + bin_PROGRAMS = foo bar foo_SOURCES = main.c foo.y bar_SOURCES = main.c bar.y -- 2.39.0 From debbugs-submit-bounces@debbugs.gnu.org Mon Aug 28 21:33:34 2023 Received: (at 59994) by debbugs.gnu.org; 29 Aug 2023 01:33:34 +0000 Received: from localhost ([127.0.0.1]:49206 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qanbl-0004a1-5L for submit@debbugs.gnu.org; Mon, 28 Aug 2023 21:33:34 -0400 Received: from frenzy.freefriends.org ([198.99.81.75]:56920 helo=freefriends.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qanbf-0004Zf-Oc; Mon, 28 Aug 2023 21:33:25 -0400 X-Envelope-From: karl@freefriends.org Received: from freefriends.org (localhost [127.0.0.1]) by freefriends.org (8.14.7/8.14.7) with ESMTP id 37T1XGVJ006061 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 28 Aug 2023 19:33:16 -0600 Received: (from apache@localhost) by freefriends.org (8.14.7/8.14.7/Submit) id 37T1XFUo006060; Mon, 28 Aug 2023 19:33:15 -0600 Date: Mon, 28 Aug 2023 19:33:15 -0600 Message-Id: <202308290133.37T1XFUo006060@freefriends.org> From: Karl Berry To: fberat@redhat.com Subject: Re: [bug#59994] [PATCH v2] tests: Don't try to prevent flex to include unistd.h In-Reply-To: <20230120103544.191349-1-fberat@redhat.com> X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 59994 Cc: 59994@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) In current version of flex, not having this header leads to implicit function declarations that are not compatible with c99 standard. On top of that, while flex dedicated test were having this macro set, the yacc ones didn't have it despise their use of Flex. For consistency, all the YACC/Flex related tests now have the "--never-interactive" option set in AM_LFLAGS. I installed this change. Thank you for all that laborious effort to change all the yacc/flex tests. All the tests passed for me after applying the patches. For the record, a couple of the diffs (lex-clean-cxx.sh, lex-depend-cxx.sh) did not apply as written, since the prior extern "C" line had already been changed to be conditional, e.g., this failed: --- t/lex-clean-cxx.sh +++ t/lex-clean-cxx.sh @@ -57,8 +59,6 @@ cat > parsefoo.lxx << 'END' %{ #define YY_DECL int yylex (void) extern "C" YY_DECL; -#define YY_NO_UNISTD_H 1 -int isatty (int fd) { return 0; } %} %% "GOOD" return EOF; I simply removed the #define YY_NO_UNISTD_H and int isatty lines by hand. Final diff before commit is included below. Thanks again, Karl diff --git a/t/cond35.sh b/t/cond35.sh index dc3b8aae9..8b044644e 100644 --- a/t/cond35.sh +++ b/t/cond35.sh @@ -30,6 +30,7 @@ EOF cat > Makefile.am <<'EOF' AM_YFLAGS = -d +AM_LFLAGS = --never-interactive BUILT_SOURCES = tparse.h @@ -58,9 +59,6 @@ $FGREP 'tparse.h' Makefile.in # For debugging. test $($FGREP -c 'tparse.h:' Makefile.in) -eq 1 cat > tscan.l << 'END' -%{ -#define YY_NO_UNISTD_H 1 -%} %% "END" return EOF; %% diff --git a/t/lex-clean-cxx.sh b/t/lex-clean-cxx.sh index 8a086304f..fea054457 100644 --- a/t/lex-clean-cxx.sh +++ b/t/lex-clean-cxx.sh @@ -29,6 +29,8 @@ AC_OUTPUT END cat > Makefile.am << 'END' +AM_LFLAGS = --never-interactive + bin_PROGRAMS = foo bar baz qux foo_SOURCES = mainfoo.cc parsefoo.lxx @@ -60,8 +62,6 @@ cat > parsefoo.lxx << 'END' extern "C" #endif YY_DECL; -#define YY_NO_UNISTD_H 1 -int isatty (int fd) { return 0; } %} %% "GOOD" return EOF; diff --git a/t/lex-clean.sh b/t/lex-clean.sh index 1ee7d8f5b..4668e97c7 100644 --- a/t/lex-clean.sh +++ b/t/lex-clean.sh @@ -29,6 +29,8 @@ AC_OUTPUT END cat > Makefile.am << 'END' +AM_LFLAGS = --never-interactive + bin_PROGRAMS = foo bar baz qux foo_SOURCES = main.c lexer.l @@ -52,9 +54,6 @@ LDADD = $(LEXLIB) END cat > lexer.l << 'END' -%{ -#define YY_NO_UNISTD_H 1 -%} %% "GOOD" return EOF; . diff --git a/t/lex-depend-cxx.sh b/t/lex-depend-cxx.sh index 682b2ccc5..cc7004eab 100644 --- a/t/lex-depend-cxx.sh +++ b/t/lex-depend-cxx.sh @@ -27,6 +27,8 @@ AC_OUTPUT END cat > Makefile.am << 'END' +AM_LFLAGS = --never-interactive + noinst_PROGRAMS = joe moe joe_SOURCES = joe.ll moe_SOURCES = moe.l++ @@ -53,8 +55,6 @@ cat > joe.ll << 'END' extern "C" #endif YY_DECL; -#define YY_NO_UNISTD_H 1 -int isatty (int fd) { return 0; } %} %% "foo" return EOF; diff --git a/t/lex-depend.sh b/t/lex-depend.sh index 16f937ef1..68cc5ee7b 100644 --- a/t/lex-depend.sh +++ b/t/lex-depend.sh @@ -27,6 +27,8 @@ AC_OUTPUT END cat > Makefile.am << 'END' +AM_LFLAGS = --never-interactive + bin_PROGRAMS = zoo zoo_SOURCES = joe.l LDADD = $(LEXLIB) @@ -42,9 +44,6 @@ test-obj-updated: joe.$(OBJEXT) END cat > joe.l << 'END' -%{ -#define YY_NO_UNISTD_H 1 -%} %% "foo" return EOF; . diff --git a/t/lex-header.sh b/t/lex-header.sh index 22567642e..48b42457a 100644 --- a/t/lex-header.sh +++ b/t/lex-header.sh @@ -33,6 +33,8 @@ AC_OUTPUT END cat > Makefile.am << 'END' +AM_LFLAGS = --never-interactive + bin_PROGRAMS = foo foo_SOURCES = lexer.l main.c mylex.h foo_LFLAGS = --header-file=mylex.h @@ -45,9 +47,6 @@ END cat > lexer.l << 'END' %option noyywrap -%{ -#define YY_NO_UNISTD_H 1 -%} %% "GOOD" return EOF; . @@ -55,7 +54,6 @@ cat > lexer.l << 'END' END cat > main.c <<'END' -#define YY_NO_UNISTD_H 1 #include "mylex.h" int main (void) { diff --git a/t/lex-lib-external.sh b/t/lex-lib-external.sh index 85403612f..25ad2a39b 100644 --- a/t/lex-lib-external.sh +++ b/t/lex-lib-external.sh @@ -28,6 +28,8 @@ AC_OUTPUT END cat > Makefile.am << 'END' +AM_LFLAGS = --never-interactive + bin_PROGRAMS = lexer lexer_SOURCES = foo.l lexer_LDADD = $(LEXLIB) @@ -42,9 +44,6 @@ have-lexlib: END cat > foo.l <<'END' -%{ -#define YY_NO_UNISTD_H 1 -%} %% "GOOD" return EOF; . diff --git a/t/lex-lib.sh b/t/lex-lib.sh index f0a0d37f6..7734fd228 100644 --- a/t/lex-lib.sh +++ b/t/lex-lib.sh @@ -31,6 +31,8 @@ AC_OUTPUT END cat > Makefile.am << 'END' +AM_LFLAGS = --never-interactive + bin_PROGRAMS = lexer lexer_SOURCES = foo.l lexer_LDADD = $(LEXLIB) @@ -47,9 +49,6 @@ int yywrap (void) END cat > foo.l <<'END' -%{ -#define YY_NO_UNISTD_H 1 -%} %% "END" return EOF; . diff --git a/t/lex-libobj.sh b/t/lex-libobj.sh index b26381fcf..6e36a98ed 100644 --- a/t/lex-libobj.sh +++ b/t/lex-libobj.sh @@ -32,6 +32,8 @@ AC_OUTPUT END cat > Makefile.am << 'END' +AM_LFLAGS = --never-interactive + noinst_PROGRAMS = foo foo_SOURCES = foo.l foo_LDADD = $(LEXLIB) $(LIBOBJS) @@ -45,9 +47,6 @@ int yywrap (void) END cat > foo.l <<'END' -%{ -#define YY_NO_UNISTD_H 1 -%} %% "END" return EOF; . diff --git a/t/lex-line.sh b/t/lex-line.sh index 340800ef2..5f9145847 100644 --- a/t/lex-line.sh +++ b/t/lex-line.sh @@ -32,6 +32,8 @@ END mkdir dir sub sub/dir cat > Makefile.am << 'END' +AM_LFLAGS = --never-interactive + SUBDIRS = sub bin_PROGRAMS = foo bar LDADD = $(LEXLIB) @@ -44,6 +46,8 @@ bar-quux.@OBJEXT@: bar-quux.c END cat > sub/Makefile.am << 'END' +AM_LFLAGS = --never-interactive + AUTOMAKE_OPTIONS = subdir-objects noinst_PROGRAMS = foo bar ## We already used $(LEXLIB) above, so try @LEXLIB@ now. @@ -57,9 +61,6 @@ dir/quux.@OBJEXT@: dir/quux.c END cat > zardoz.l << 'END' -%{ -#define YY_NO_UNISTD_H 1 -%} %% "END" return EOF; . diff --git a/t/lex-multiple.sh b/t/lex-multiple.sh index 9565bd6b8..6486a012f 100644 --- a/t/lex-multiple.sh +++ b/t/lex-multiple.sh @@ -31,7 +31,9 @@ AC_PROG_RANLIB AC_OUTPUT END -cat > Makefile.am << 'END' +cat > Makefile.am << 'END' +AM_LFLAGS = --never-interactive + bin_PROGRAMS = zardoz zardoz_SOURCES = main.c @@ -72,9 +74,6 @@ int main (int argc, char *argv[]) END cat > 0.l << 'END' -%{ -#define YY_NO_UNISTD_H 1 -%} %% "VANILLA" { printf (":%s:\n", yytext); return 121; } . { printf (":%s:\n", yytext); return 1; } diff --git a/t/lex-nodist.sh b/t/lex-nodist.sh index 73e23a13e..d499aea7f 100644 --- a/t/lex-nodist.sh +++ b/t/lex-nodist.sh @@ -31,6 +31,8 @@ AC_OUTPUT END cat > Makefile.am << 'END' +AM_LFLAGS = --never-interactive + .PHONY: test-build test-dist test-build: all ls -l @@ -45,9 +47,6 @@ check-local: test-build test-dist lexer.l: rm -f $@ $@-t :; { : \ - && echo '%{' \ - && echo '#define YY_NO_UNISTD_H 1' \ - && echo '%}' \ && echo '%%' \ && echo '"GOOD" return EOF;' \ && echo '.'; \ diff --git a/t/lex-noyywrap.sh b/t/lex-noyywrap.sh index 1c61a1ab3..5ec68b9ba 100644 --- a/t/lex-noyywrap.sh +++ b/t/lex-noyywrap.sh @@ -26,6 +26,8 @@ AC_OUTPUT END cat > Makefile.am << 'END' +AM_LFLAGS = --never-interactive + bin_PROGRAMS = foo foo_SOURCES = foo.l @@ -37,9 +39,6 @@ END cat > foo.l << 'END' %option noyywrap -%{ -#define YY_NO_UNISTD_H 1 -%} %% "GOOD" return EOF; . diff --git a/t/lex-pr204.sh b/t/lex-pr204.sh index ebfaafef5..cbad1c266 100644 --- a/t/lex-pr204.sh +++ b/t/lex-pr204.sh @@ -35,6 +35,8 @@ EOF # The LEXER2 intermediate variable is there to make sure Automake # matches 'nodist_' against the right variable name... cat > Makefile.am << 'EOF' +AM_LFLAGS = --never-interactive + EXTRA_PROGRAMS = foo LEXER2 = lexer2.l nodist_foo_SOURCES = lexer.l $(LEXER2) @@ -49,9 +51,6 @@ distdirtest: distdir EOF cat > lexer.l << 'END' -%{ -#define YY_NO_UNISTD_H 1 -%} %% "GOOD" return EOF; . diff --git a/t/lex-subobj-nodep.sh b/t/lex-subobj-nodep.sh index f8bb87a9c..8ef4d68b1 100644 --- a/t/lex-subobj-nodep.sh +++ b/t/lex-subobj-nodep.sh @@ -28,6 +28,8 @@ END cat >Makefile.am <<\END AUTOMAKE_OPTIONS = subdir-objects +AM_LFLAGS = --never-interactive + bin_PROGRAMS = p1 p2 p1_SOURCES = sub1/s1.l p2_SOURCES = sub2/s2.l @@ -37,9 +39,6 @@ END mkdir sub1 sub2 cat >sub1/s1.l <<\END -%{ -#define YY_NO_UNISTD_H 1 -%} %% "END" return EOF; . diff --git a/t/lex3.sh b/t/lex3.sh index 41b87dc06..4a20f85da 100644 --- a/t/lex3.sh +++ b/t/lex3.sh @@ -28,14 +28,13 @@ AC_OUTPUT END cat > Makefile.am << 'END' +AM_LFLAGS = --never-interactive + noinst_PROGRAMS = foo foo_SOURCES = foo.l END cat > foo.l << 'END' -%{ -#define YY_NO_UNISTD_H 1 -%} %% "GOOD" return EOF; . diff --git a/t/lex5.sh b/t/lex5.sh index 3d84d9b41..687903e65 100644 --- a/t/lex5.sh +++ b/t/lex5.sh @@ -28,6 +28,7 @@ END cat > Makefile.am << 'END' AUTOMAKE_OPTIONS = subdir-objects LDADD = @LEXLIB@ +AM_LFLAGS = --never-interactive bin_PROGRAMS = foo/foo foo_foo_SOURCES = foo/foo.l @@ -36,9 +37,6 @@ END mkdir foo cat > foo/foo.l << 'END' -%{ -#define YY_NO_UNISTD_H 1 -%} %% "END" return EOF; . diff --git a/t/lexvpath.sh b/t/lexvpath.sh index 5185a1f71..d064fd2bd 100644 --- a/t/lexvpath.sh +++ b/t/lexvpath.sh @@ -37,6 +37,8 @@ AC_OUTPUT END cat > Makefile.am << 'END' +AM_LFLAGS = --never-interactive + bin_PROGRAMS = foo foo_SOURCES = lexer.l foo.c LDADD = $(LEXLIB) @@ -44,9 +46,6 @@ END # Original lexer, with a "foobar" comment cat > lexer.l << 'END' -%{ -#define YY_NO_UNISTD_H 1 -%} %% "END" return EOF; . @@ -89,9 +88,6 @@ $sleep # New lexer, with 'fubar' comment. cat > ../lexer.l << 'END' -%{ -#define YY_NO_UNISTD_H 1 -%} %% "END" return EOF; . @@ -112,9 +108,6 @@ $sleep # New lexer, with 'maude' comment. cat > ../lexer.l << 'END' -%{ -#define YY_NO_UNISTD_H 1 -%} %% "END" return EOF; . diff --git a/t/silent-lex.sh b/t/silent-lex.sh index cfe1a9b5d..e424afc38 100644 --- a/t/silent-lex.sh +++ b/t/silent-lex.sh @@ -28,6 +28,8 @@ AC_OUTPUT EOF cat > Makefile.am <<'EOF' +AM_LFLAGS = --never-interactive + # Need generic and non-generic rules. bin_PROGRAMS = foo1 foo2 foo1_SOURCES = foo.l @@ -40,6 +42,8 @@ EOF cat > sub/Makefile.am <<'EOF' AUTOMAKE_OPTIONS = subdir-objects +AM_LFLAGS = --never-interactive + # Need generic and non-generic rules. bin_PROGRAMS = bar1 bar2 bar1_SOURCES = bar.l @@ -50,9 +54,6 @@ LDADD = $(LEXLIB) EOF cat > foo.l <<'EOF' -%{ -#define YY_NO_UNISTD_H 1 -%} %% "END" return EOF; . diff --git a/t/silent-many-languages.sh b/t/silent-many-languages.sh index 4edb46884..85773d339 100644 --- a/t/silent-many-languages.sh +++ b/t/silent-many-languages.sh @@ -151,6 +151,7 @@ ba2_YFLAGS = -v ba2_LFLAGS = -n ba2_LDADD = $(LEXLIB) AM_YFLAGS = -d +AM_LFLAGS = --never-interactive BUILT_SOURCES = baz6.h EOF diff --git a/t/silent-yacc-headers.sh b/t/silent-yacc-headers.sh index 98ae45b8a..f64342c82 100644 --- a/t/silent-yacc-headers.sh +++ b/t/silent-yacc-headers.sh @@ -31,6 +31,7 @@ EOF cat > Makefile.am <<'EOF' # Need generic and non-generic rules. AM_YFLAGS = -d +AM_LFLAGS = --never-interactive bin_PROGRAMS = foo bar foo_SOURCES = parse.y bar_SOURCES = $(foo_SOURCES) diff --git a/t/silent-yacc.sh b/t/silent-yacc.sh index 9645aff83..d89ff49a7 100644 --- a/t/silent-yacc.sh +++ b/t/silent-yacc.sh @@ -29,6 +29,8 @@ AC_OUTPUT EOF cat > Makefile.am <<'EOF' +AM_LFLAGS = --never-interactive + # Need generic and non-generic rules. bin_PROGRAMS = foo1 foo2 foo1_SOURCES = foo.y @@ -40,6 +42,8 @@ EOF cat > sub/Makefile.am <<'EOF' AUTOMAKE_OPTIONS = subdir-objects +AM_LFLAGS = --never-interactive + # Need generic and non-generic rules. bin_PROGRAMS = bar1 bar2 bar1_SOURCES = bar.y diff --git a/t/subpkg-yacc.sh b/t/subpkg-yacc.sh index edd14532b..782ee0957 100644 --- a/t/subpkg-yacc.sh +++ b/t/subpkg-yacc.sh @@ -61,6 +61,8 @@ AC_OUTPUT EOF cat >lib/Makefile.am <<'EOF' +AM_LFLAGS = --never-interactive + noinst_LIBRARIES = liblib.a liblib_a_SOURCES = src/x.c foo.y EXTRA_liblib_a_SOURCES = bar.y diff --git a/t/suffix10.tap b/t/suffix10.tap index 3869d07fd..8d3dc1756 100644 --- a/t/suffix10.tap +++ b/t/suffix10.tap @@ -31,6 +31,8 @@ AC_OUTPUT EOF cat >Makefile.am << 'END' +AM_LFLAGS = --never-interactive + lib_LTLIBRARIES = libfoo.la libfoo_la_SOURCES = foo.x_ .x_.y: diff --git a/t/yacc-auxdir.sh b/t/yacc-auxdir.sh index be8ac4fd4..f6ff7de48 100644 --- a/t/yacc-auxdir.sh +++ b/t/yacc-auxdir.sh @@ -35,12 +35,16 @@ cat > Makefile.am << 'END' SUBDIRS = sub bin_PROGRAMS = foo AM_YFLAGS = -d +AM_LFLAGS = --never-interactive + foo_SOURCES = foo.y END cat > sub/Makefile.am << 'END' bin_PROGRAMS = bar AM_YFLAGS = -d +AM_LFLAGS = --never-interactive + bar_SOURCES = bar.y main.c END diff --git a/t/yacc-basic.sh b/t/yacc-basic.sh index b7a35bd39..51ee5f6a3 100644 --- a/t/yacc-basic.sh +++ b/t/yacc-basic.sh @@ -27,6 +27,8 @@ AC_OUTPUT END cat > Makefile.am << 'END' +AM_LFLAGS = --never-interactive + bin_PROGRAMS = foo bar foo_SOURCES = parse.y foo.c bar_SOURCES = $(foo_SOURCES) diff --git a/t/yacc-bison-skeleton-cxx.sh b/t/yacc-bison-skeleton-cxx.sh index bded1a34f..da76238fa 100644 --- a/t/yacc-bison-skeleton-cxx.sh +++ b/t/yacc-bison-skeleton-cxx.sh @@ -27,6 +27,8 @@ AC_OUTPUT END cat > Makefile.am << 'END' +AM_LFLAGS = --never-interactive + bin_PROGRAMS = zardoz zardoz_SOURCES = zardoz.yy foo.cc diff --git a/t/yacc-bison-skeleton.sh b/t/yacc-bison-skeleton.sh index b77b29f1e..11b64b831 100644 --- a/t/yacc-bison-skeleton.sh +++ b/t/yacc-bison-skeleton.sh @@ -31,6 +31,8 @@ cat > Makefile.am << 'END' bin_PROGRAMS = zardoz zardoz_SOURCES = zardoz.y foo.c AM_YFLAGS = -d --skeleton glr.c +AM_LFLAGS = --never-interactive + BUILT_SOURCES = zardoz.h END diff --git a/t/yacc-clean-cxx.sh b/t/yacc-clean-cxx.sh index d12e02308..71eb4f315 100644 --- a/t/yacc-clean-cxx.sh +++ b/t/yacc-clean-cxx.sh @@ -39,6 +39,8 @@ END mkdir sub1 sub2 cat > sub1/Makefile.am << 'END' +AM_LFLAGS = --never-interactive + bin_PROGRAMS = foo bar baz qux foo_SOURCES = mainfoo.cc parsefoo.yxx diff --git a/t/yacc-clean.sh b/t/yacc-clean.sh index 0baf0afd8..d0f793843 100644 --- a/t/yacc-clean.sh +++ b/t/yacc-clean.sh @@ -38,6 +38,8 @@ END mkdir sub1 sub2 cat > sub1/Makefile.am << 'END' +AM_LFLAGS = --never-interactive + bin_PROGRAMS = foo bar baz qux foo_SOURCES = main.c parse.y diff --git a/t/yacc-cxx-grepping.sh b/t/yacc-cxx-grepping.sh index 7b3a6bc5e..e094d5f16 100644 --- a/t/yacc-cxx-grepping.sh +++ b/t/yacc-cxx-grepping.sh @@ -27,6 +27,8 @@ AC_PROG_YACC END cat > Makefile.am << 'END' +AM_LFLAGS = --never-interactive + bin_PROGRAMS = foo bar baz qux foo_SOURCES = foo.y++ bar_SOURCES = bar.ypp diff --git a/t/yacc-cxx.sh b/t/yacc-cxx.sh index 5b385870c..0ce4116dd 100644 --- a/t/yacc-cxx.sh +++ b/t/yacc-cxx.sh @@ -28,6 +28,8 @@ AC_OUTPUT END cat > Makefile.am << 'END' +AM_LFLAGS = --never-interactive + bin_PROGRAMS = foo1 foo2 foo3 foo4 foo1_SOURCES = parse1.yy foo.cc foo2_SOURCES = parse2.y++ bar.c++ diff --git a/t/yacc-d-basic.sh b/t/yacc-d-basic.sh index fe80a0888..166111fdb 100644 --- a/t/yacc-d-basic.sh +++ b/t/yacc-d-basic.sh @@ -35,6 +35,8 @@ END mkdir foo bar baz cat > foo/Makefile.am <<'END' +AM_LFLAGS = --never-interactive + bin_PROGRAMS = zardoz zardoz_SOURCES = parse.y main.c .PHONY: echo-distcom diff --git a/t/yacc-d-cxx.sh b/t/yacc-d-cxx.sh index 576e8e2aa..40247d3c8 100644 --- a/t/yacc-d-cxx.sh +++ b/t/yacc-d-cxx.sh @@ -70,6 +70,8 @@ mkdir foo bar baz qux baz/sub # These makefiles will be extended later. cat > Makefile.am <<'END' +AM_LFLAGS = --never-interactive + .PHONY: echo-distcom echo-distcom: @echo ' ' $(DIST_COMMON) ' ' diff --git a/t/yacc-d-vpath.sh b/t/yacc-d-vpath.sh index dced4818f..3dcf17ade 100644 --- a/t/yacc-d-vpath.sh +++ b/t/yacc-d-vpath.sh @@ -32,6 +32,8 @@ AC_OUTPUT END cat > Makefile.am << 'END' +AM_LFLAGS = --never-interactive + bin_PROGRAMS = foo foo_SOURCES = parse.y foo.c AM_YFLAGS = -d diff --git a/t/yacc-deleted-headers.sh b/t/yacc-deleted-headers.sh index c3fdbeee4..8c27dcefb 100644 --- a/t/yacc-deleted-headers.sh +++ b/t/yacc-deleted-headers.sh @@ -26,6 +26,8 @@ AC_OUTPUT END cat > Makefile.am <<'END' +AM_LFLAGS = --never-interactive + bin_PROGRAMS = p1 p2 p3 p4 # The order in which files are listed in the p*_SOURCES variables # below is significant, since it causes make failures whenever diff --git a/t/yacc-depend.sh b/t/yacc-depend.sh index cf544359f..d1e09bc39 100644 --- a/t/yacc-depend.sh +++ b/t/yacc-depend.sh @@ -29,6 +29,8 @@ END cat > Makefile.am << 'END' bin_PROGRAMS = foo AM_YFLAGS = -d +AM_LFLAGS = --never-interactive + foo_SOURCES = foo.y main.c BUILT_SOURCES = foo.h END diff --git a/t/yacc-depend2.sh b/t/yacc-depend2.sh index a61e4957d..a52d4489f 100644 --- a/t/yacc-depend2.sh +++ b/t/yacc-depend2.sh @@ -28,6 +28,8 @@ AC_OUTPUT END cat > Makefile.am << 'END' +AM_LFLAGS = --never-interactive + bin_PROGRAMS = foo AM_YFLAGS = -d foo_SOURCES = foo.y main.c diff --git a/t/yacc-dist-nobuild-subdir.sh b/t/yacc-dist-nobuild-subdir.sh index d1788811f..56320fe48 100644 --- a/t/yacc-dist-nobuild-subdir.sh +++ b/t/yacc-dist-nobuild-subdir.sh @@ -49,6 +49,8 @@ END cat > Makefile.am <<'END' AUTOMAKE_OPTIONS = subdir-objects +AM_LFLAGS = --never-interactive + noinst_PROGRAMS = foo bar foo_SOURCES = sub/parse.y bar_SOURCES = $(foo_SOURCES) diff --git a/t/yacc-dist-nobuild.sh b/t/yacc-dist-nobuild.sh index a30fefec2..71be0d52c 100644 --- a/t/yacc-dist-nobuild.sh +++ b/t/yacc-dist-nobuild.sh @@ -28,6 +28,8 @@ AC_OUTPUT END cat > Makefile.am << 'END' +AM_LFLAGS = --never-interactive + bin_PROGRAMS = foobar zardoz foobar_SOURCES = parse.y main.c zardoz_SOURCES = $(foobar_SOURCES) diff --git a/t/yacc-dry.sh b/t/yacc-dry.sh index 9b08d3863..6500ba811 100644 --- a/t/yacc-dry.sh +++ b/t/yacc-dry.sh @@ -26,6 +26,8 @@ AC_OUTPUT END cat > Makefile.am << 'END' +AM_LFLAGS = --never-interactive + AM_YFLAGS = -d bin_PROGRAMS = foo foo_SOURCES = foo.c parse.y diff --git a/t/yacc-grepping.sh b/t/yacc-grepping.sh index b0cf91353..67381ba89 100644 --- a/t/yacc-grepping.sh +++ b/t/yacc-grepping.sh @@ -35,6 +35,8 @@ END $ACLOCAL cat > Makefile.am <<'END' +AM_LFLAGS = --never-interactive + bin_PROGRAMS = zardoz zardoz_SOURCES = zardoz.y END diff --git a/t/yacc-grepping2.sh b/t/yacc-grepping2.sh index 159dd3e15..4af321fbe 100644 --- a/t/yacc-grepping2.sh +++ b/t/yacc-grepping2.sh @@ -25,6 +25,8 @@ AC_PROG_YACC END cat > Makefile.am << 'END' +AM_LFLAGS = --never-interactive + bin_PROGRAMS = maude maude_SOURCES = sub/maude.y END diff --git a/t/yacc-headers-and-dist-pr47.sh b/t/yacc-headers-and-dist-pr47.sh index 57c8251ad..74ec525f9 100644 --- a/t/yacc-headers-and-dist-pr47.sh +++ b/t/yacc-headers-and-dist-pr47.sh @@ -30,6 +30,8 @@ AC_OUTPUT END cat > Makefile.am << 'END' +AM_LFLAGS = --never-interactive + bin_PROGRAMS = foo foo_SOURCES = foo.y AM_YFLAGS = -d diff --git a/t/yacc-line.sh b/t/yacc-line.sh index e7a4d6244..2319c9791 100644 --- a/t/yacc-line.sh +++ b/t/yacc-line.sh @@ -32,6 +32,8 @@ END mkdir dir sub sub/dir cat > Makefile.am << 'END' +AM_LFLAGS = --never-interactive + SUBDIRS = sub bin_PROGRAMS = foo bar AM_YFLAGS = -d @@ -45,6 +47,8 @@ END cat > sub/Makefile.am << 'END' AUTOMAKE_OPTIONS = subdir-objects +AM_LFLAGS = --never-interactive + noinst_PROGRAMS = foo bar foo_YFLAGS = -d foo_SOURCES = zardoz.y diff --git a/t/yacc-misc.sh b/t/yacc-misc.sh index 2bfb0c55e..fcc19aa49 100644 --- a/t/yacc-misc.sh +++ b/t/yacc-misc.sh @@ -26,6 +26,8 @@ AC_OUTPUT END cat > Makefile.am << 'END' +AM_LFLAGS = --never-interactive + bin_PROGRAMS = foo bar foo_SOURCES = parse.y foo.c bar_SOURCES = bar.y foo.c diff --git a/t/yacc-mix-c-cxx.sh b/t/yacc-mix-c-cxx.sh index 7c44e0926..de05cdab8 100644 --- a/t/yacc-mix-c-cxx.sh +++ b/t/yacc-mix-c-cxx.sh @@ -28,6 +28,8 @@ AC_OUTPUT END cat > Makefile.am << 'END' +AM_LFLAGS = --never-interactive + bin_PROGRAMS = c1 c2 cxx1 cxx2 cxx3 AM_YFLAGS = -d diff --git a/t/yacc-nodist.sh b/t/yacc-nodist.sh index dbb86bdb2..8e5338e94 100644 --- a/t/yacc-nodist.sh +++ b/t/yacc-nodist.sh @@ -31,6 +31,8 @@ AC_OUTPUT END cat > Makefile.am << 'END' +AM_LFLAGS = --never-interactive + SUBDIRS = sub1 sub2 .PHONY: test-build test-dist test-build: all diff --git a/t/yacc-pr204.sh b/t/yacc-pr204.sh index 91882e4d7..89acb1ee0 100644 --- a/t/yacc-pr204.sh +++ b/t/yacc-pr204.sh @@ -34,6 +34,8 @@ EOF # sure Automake match 'nodist_' against the right # variable name... cat > Makefile.am << 'EOF' +AM_LFLAGS = --never-interactive + AM_YFLAGS = -d EXTRA_PROGRAMS = foo PARSE2 = parse2.y diff --git a/t/yacc-subdir.sh b/t/yacc-subdir.sh index df31a3c51..d6c3f0cc8 100644 --- a/t/yacc-subdir.sh +++ b/t/yacc-subdir.sh @@ -28,6 +28,8 @@ END cat > Makefile.am << 'END' AUTOMAKE_OPTIONS = subdir-objects +AM_LFLAGS = --never-interactive + bin_PROGRAMS = foo/foo foo_foo_SOURCES = foo/parse.y AM_YFLAGS = -d diff --git a/t/yacc-vpath.sh b/t/yacc-vpath.sh index 52d2c45bd..42044ecf2 100644 --- a/t/yacc-vpath.sh +++ b/t/yacc-vpath.sh @@ -32,6 +32,8 @@ AC_OUTPUT END cat > Makefile.am << 'END' +AM_LFLAGS = --never-interactive + bin_PROGRAMS = foo foo_SOURCES = parse.y foo.c END diff --git a/t/yacc-weirdnames.sh b/t/yacc-weirdnames.sh index 60f199d2d..8397bc636 100644 --- a/t/yacc-weirdnames.sh +++ b/t/yacc-weirdnames.sh @@ -27,6 +27,8 @@ AC_OUTPUT END cat > Makefile.am << 'END' +AM_LFLAGS = --never-interactive + bin_PROGRAMS = foo bar foo2 bar2 foo_SOURCES = parse.y.y diff --git a/t/yflags-cmdline-override.sh b/t/yflags-cmdline-override.sh index 37304645c..73982753a 100644 --- a/t/yflags-cmdline-override.sh +++ b/t/yflags-cmdline-override.sh @@ -27,6 +27,8 @@ AC_OUTPUT END cat > Makefile.am <<'END' +AM_LFLAGS = --never-interactive + bin_PROGRAMS = foo foo_SOURCES = foo.y # A minor automake wart: automake doesn't generate code to clean diff --git a/t/yflags-cxx.sh b/t/yflags-cxx.sh index 9bd28b8ce..2596a95e3 100644 --- a/t/yflags-cxx.sh +++ b/t/yflags-cxx.sh @@ -39,6 +39,8 @@ END cat > Makefile.am <<'END' AUTOMAKE_OPTIONS = no-dependencies +AM_LFLAGS = --never-interactive + bin_PROGRAMS = foo bar foo_SOURCES = main.cc foo.yy bar_SOURCES = main.cc bar.y++ diff --git a/t/yflags-d-false-positives.sh b/t/yflags-d-false-positives.sh index 21efb2345..666dbe938 100644 --- a/t/yflags-d-false-positives.sh +++ b/t/yflags-d-false-positives.sh @@ -26,6 +26,8 @@ END $ACLOCAL cat > Makefile.am <<'END' +AM_LFLAGS = --never-interactive + bin_PROGRAMS = zardoz foobar zardoz_SOURCES = zardoz.y foobar_SOURCES = foobar.y diff --git a/t/yflags-force-conditional.sh b/t/yflags-force-conditional.sh index 3f9a13293..976b6f782 100644 --- a/t/yflags-force-conditional.sh +++ b/t/yflags-force-conditional.sh @@ -38,6 +38,8 @@ YACC=fake-yacc; export YACC cat > Makefile.am <<'END' AUTOMAKE_OPTIONS = no-dependencies +AM_LFLAGS = --never-interactive + bin_PROGRAMS = foo bar foo_SOURCES = foo.y main.c bar_SOURCES = $(foo_SOURCES) diff --git a/t/yflags-force-override.sh b/t/yflags-force-override.sh index b1c36ef0f..7c865935b 100644 --- a/t/yflags-force-override.sh +++ b/t/yflags-force-override.sh @@ -28,6 +28,8 @@ AC_OUTPUT END cat > Makefile.am <<'END' +AM_LFLAGS = --never-interactive + bin_PROGRAMS = foo foo_SOURCES = foo.y # Don't do this in a real-life Makefile.am! diff --git a/t/yflags-var-expand.sh b/t/yflags-var-expand.sh index 0e06e0d9c..bf34922a6 100644 --- a/t/yflags-var-expand.sh +++ b/t/yflags-var-expand.sh @@ -29,6 +29,8 @@ END $ACLOCAL cat > Makefile.am <<'END' +AM_LFLAGS = --never-interactive + bin_PROGRAMS = foo bar foo_SOURCES = foo.y bar_SOURCES = bar.y diff --git a/t/yflags.sh b/t/yflags.sh index 1f73776f8..2359a76b7 100644 --- a/t/yflags.sh +++ b/t/yflags.sh @@ -39,6 +39,8 @@ END cat > Makefile.am <<'END' AUTOMAKE_OPTIONS = no-dependencies +AM_LFLAGS = --never-interactive + bin_PROGRAMS = foo bar foo_SOURCES = main.c foo.y bar_SOURCES = main.c bar.y compile finished at Mon Aug 28 18:31:34 2023 From unknown Sun Jun 15 08:40:00 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Tue, 26 Sep 2023 11:24:10 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator From debbugs-submit-bounces@debbugs.gnu.org Sat Dec 30 17:56:29 2023 Received: (at control) by debbugs.gnu.org; 30 Dec 2023 22:56:29 +0000 Received: from localhost ([127.0.0.1]:45197 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rJiFp-0001gh-D9 for submit@debbugs.gnu.org; Sat, 30 Dec 2023 17:56:29 -0500 Received: from frenzy.freefriends.org ([198.99.81.75]:56344 helo=freefriends.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rJiFn-0001gY-BQ for control@debbugs.gnu.org; Sat, 30 Dec 2023 17:56:28 -0500 X-Envelope-From: karl@freefriends.org X-Envelope-To: Received: from freefriends.org (localhost [127.0.0.1]) by freefriends.org (8.14.7/8.14.7) with ESMTP id 3BUMuOg2019587 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Sat, 30 Dec 2023 15:56:24 -0700 Received: (from apache@localhost) by freefriends.org (8.14.7/8.14.7/Submit) id 3BUMuOo8019586; Sat, 30 Dec 2023 15:56:24 -0700 Date: Sat, 30 Dec 2023 15:56:24 -0700 Message-Id: <202312302256.3BUMuOo8019586@freefriends.org> From: Karl Berry To: control@debbugs.gnu.org Subject: X-Spam-Score: 2.0 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: unarchive 59994 Content analysis details: (2.0 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 SPF_PASS SPF: sender matches SPF record -0.0 SPF_HELO_PASS SPF: HELO matches SPF record -0.0 T_SCC_BODY_TEXT_LINE No description available. 2.0 BLANK_SUBJECT Subject is present but empty X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) unarchive 59994 From unknown Sun Jun 15 08:40:00 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sun, 28 Jan 2024 12:24:11 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator