From unknown Sat Jun 21 05:10:36 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#59990] [PATCH] tests: depcomp: ensure make_ok() fails when run_make fails Resent-From: Frederic Berat Original-Sender: "Debbugs-submit" Resent-CC: automake-patches@gnu.org Resent-Date: Mon, 12 Dec 2022 08:44:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 59990 X-GNU-PR-Package: automake-patches X-GNU-PR-Keywords: patch To: 59990@debbugs.gnu.org Cc: =?UTF-8?Q?Fr=C3=A9d=C3=A9ric_?= =?UTF-8?Q?B=C3=A9rat?= X-Debbugs-Original-To: automake-patches@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.167083459318579 (code B ref -1); Mon, 12 Dec 2022 08:44:03 +0000 Received: (at submit) by debbugs.gnu.org; 12 Dec 2022 08:43:13 +0000 Received: from localhost ([127.0.0.1]:51435 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p4eP3-0004pV-24 for submit@debbugs.gnu.org; Mon, 12 Dec 2022 03:43:13 -0500 Received: from lists.gnu.org ([209.51.188.17]:35056) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p4cMp-0000r0-Ko for submit@debbugs.gnu.org; Mon, 12 Dec 2022 01:32:48 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p4cMp-0005sp-C6 for automake-patches@gnu.org; Mon, 12 Dec 2022 01:32:47 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p4cMn-0002Bm-QQ for automake-patches@gnu.org; Mon, 12 Dec 2022 01:32:47 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1670826764; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=K/Fm7nalYrxvQmLkMmTs0YfgoA2OA+ZhbPh0YrzjWz0=; b=C8amGQr5Lo3/mNHylm9jCIC6qVuZMnggIlPQcgCEMR18/BSHjjpXOqxYFvMdbFB/Ola9ao b3kVUsd372xvQ65mebCtM/oOMjt1CeX1w+CuhWcqG0hevJ59AOazI8g3UfdfmOqenBKui3 6MtLJb5fK9OD+yXieyigeqtnjczqszg= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-182-d9RUTTZ9PlyinQ5GjYTV3g-1; Mon, 12 Dec 2022 01:32:43 -0500 X-MC-Unique: d9RUTTZ9PlyinQ5GjYTV3g-1 Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 26D15101E9B7 for ; Mon, 12 Dec 2022 06:32:43 +0000 (UTC) Received: from Nymeria-redhat.redhat.com (unknown [10.39.192.133]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 8DE31492C13; Mon, 12 Dec 2022 06:32:42 +0000 (UTC) From: Frederic Berat Date: Mon, 12 Dec 2022 07:32:13 +0100 Message-Id: <20221212063213.1635570-1-fberat@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.9 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=170.10.133.124; envelope-from=fberat@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-Mailman-Approved-At: Mon, 12 Dec 2022 03:43:10 -0500 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) From: Frédéric Bérat While running automake tests with -std-gnu=c99, the compiler report errors which lead to make to fail. Yet, these failures are ignored during the tests, which considers them to be successful as stderror is check for one specific pattern. If make fails, investigation should be made to discover why, whatever the reason for the failure is. --- t/ax/depcomp.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/t/ax/depcomp.sh b/t/ax/depcomp.sh index f23635086..e4e7565df 100644 --- a/t/ax/depcomp.sh +++ b/t/ax/depcomp.sh @@ -160,7 +160,7 @@ case $depcomp_with_libtool in echo lib_LTLIBRARIES = libfoo.la >> Makefile.am make_ok () { - run_make -M -- ${1+"$@"} + run_make -M -- ${1+"$@"} || return 1 $FGREP 'unknown directive' output && return 1 rm -f output # Checks for stray files possibly left around by less common -- 2.38.1 From unknown Sat Jun 21 05:10:36 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#59990] [PATCH] tests: depcomp: ensure make_ok() fails when run_make fails References: <20221212063213.1635570-1-fberat@redhat.com> In-Reply-To: <20221212063213.1635570-1-fberat@redhat.com> Resent-From: Mike Frysinger Original-Sender: "Debbugs-submit" Resent-CC: automake-patches@gnu.org Resent-Date: Sun, 15 Jan 2023 21:56:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59990 X-GNU-PR-Package: automake-patches X-GNU-PR-Keywords: patch To: Frederic Berat Cc: 59990@debbugs.gnu.org Received: via spool by 59990-submit@debbugs.gnu.org id=B59990.167381970818670 (code B ref 59990); Sun, 15 Jan 2023 21:56:02 +0000 Received: (at 59990) by debbugs.gnu.org; 15 Jan 2023 21:55:08 +0000 Received: from localhost ([127.0.0.1]:59723 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pHAy3-0004r4-KY for submit@debbugs.gnu.org; Sun, 15 Jan 2023 16:55:07 -0500 Received: from woodpecker.gentoo.org ([140.211.166.183]:53418 helo=smtp.gentoo.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pHAy1-0004qK-Jp for 59990@debbugs.gnu.org; Sun, 15 Jan 2023 16:55:05 -0500 Received: by smtp.gentoo.org (Postfix, from userid 559) id 307C1340EC8; Sun, 15 Jan 2023 21:55:00 +0000 (UTC) From: Mike Frysinger User-Agent: GNU debbugs/0 Message-Id: <20230115215500.307C1340EC8@smtp.gentoo.org> Date: Sun, 15 Jan 2023 21:55:00 +0000 (UTC) X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) thanks, lgtm, merged -mike From debbugs-submit-bounces@debbugs.gnu.org Sun Jan 15 16:55:25 2023 Received: (at control) by debbugs.gnu.org; 15 Jan 2023 21:55:25 +0000 Received: from localhost ([127.0.0.1]:59726 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pHAyK-0004re-V4 for submit@debbugs.gnu.org; Sun, 15 Jan 2023 16:55:25 -0500 Received: from woodpecker.gentoo.org ([140.211.166.183]:53486 helo=smtp.gentoo.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pHAyJ-0004rR-Vy for control@debbugs.gnu.org; Sun, 15 Jan 2023 16:55:24 -0500 Received: by smtp.gentoo.org (Postfix, from userid 559) id 73E1D340D46; Sun, 15 Jan 2023 21:55:18 +0000 (UTC) From: Mike Frysinger To: control@debbugs.gnu.org Subject: Control message User-Agent: GNU debbugs/0 Message-Id: <20230115215518.73E1D340D46@smtp.gentoo.org> Date: Sun, 15 Jan 2023 21:55:18 +0000 (UTC) X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) close 59990 thankyou