GNU bug report logs - #5999
new snapshot available: coreutils-8.4.100-81926

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 5999 in the body.
You can then email your comments to 5999 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Jim Meyering <jim <at> meyering.net>
To: bug-coreutils <at> gnu.org
Cc: coordinator <at> translationproject.org
Subject: new snapshot available: coreutils-8.4.100-81926
Date: Wed, 21 Apr 2010 22:33:23 +0200

[Message part 1 (text/plain, inline)]

I think we're ready for coreutils-8.5.
In preparation, here's a snapshot.  Please beat it up.

coreutils snapshot: (.gz files are here, too)
  http://meyering.net/cu/coreutils-ss.tar.xz      4.4 MB
  http://meyering.net/cu/coreutils-ss.tar.xz.sig
  http://meyering.net/cu/coreutils-8.4.100-81926.tar.xz

There are .gz and .sig files here, too:
  http://people.redhat.com/meyering/cu/coreutils-ss.tar.xz
  http://people.redhat.com/meyering/cu/coreutils-8.4.100-81926.tar.xz

Here's the NEWS
----------------------------------------------------------------------
** Bug fixes

  cp and mv once again support preserving extended attributes.
  [bug introduced in coreutils-8.4]

  cp now preserves "capabilities" when also preserving file ownership.

  ls --color once again honors the 'NORMAL' dircolors directive.
  [bug introduced in coreutils-6.11]

  sort -M now handles abbreviated months that are aligned using blanks
  in the locale database.  Also locales with 8 bit characters are
  handled correctly, including multi byte locales with the caveat
  that multi byte characters are matched case sensitively.

  sort again handles obsolescent key formats (+POS -POS) correctly.
  Previously if -POS was specified, 1 field too many was used in the sort.
  [bug introduced in coreutils-7.2]

** New features

  join now accepts the --header option, to treat the first line of each
  file as a header line to be joined and printed unconditionally.

  timeout now accepts the --kill-after option which sends a kill
  signal to the monitored command if it's still running the specified
  duration after the initial signal was sent.

  who: the "+/-" --mesg (-T) indicator of whether a user/tty is accepting
  messages could be incorrectly listed as "+", when in fact, the user was
  not accepting messages (mesg no).  Before, who would examine only the
  permission bits, and not consider the group of the TTY device file.
  Thus, if a login tty's group would change somehow e.g., to "root",
  that would make it unwritable (via write(1)) by normal users, in spite
  of whatever the permission bits might imply.  Now, when configured
  using the --with-tty-group[=NAME] option, who also compares the group
  of the TTY device with NAME (or "tty" if no group name is specified).

** Changes in behavior

  ls --color no longer emits the final 3-byte color-resetting escape
  sequence when it would be a no-op.

  join -t '' no longer emits an error and instead operates on
  each line as a whole (even if they contain NUL characters).

----------------------------------------------------------------------
Changes in coreutils since 8.4:

Assaf Gordon (1):
      join: add --header option to always output the first line

Bruno Haible (1):
      build: update after change in gnulib's lib-ignore module

Eric Blake (10):
      build: fix failure from bogus USE_XATTR definition
      dirname: improve man page description
      build: ignore another gnulib artifact
      expr: clarify error message
      bootstrap: resynchronize from gnulib
      maint: ignore *.xz files
      maint: drop *.lzma suport
      doc: improve ls --help's description of --escape (-b)
      rm: tweak wording about loss of data warning
      docs: document transformation of obsolete sort syntax

James R. Van Zandt (1):
      doc: add a cross reference from tac's man page to "rev"

James Youngman (1):
      doc: make wc --help say how it defines a 'word'

Jie Liu (1):
      build: tell ./bootstrap to check for xz up-front

Jim Meyering (46):
      post-release administrivia
      maint: add missing "post-release push" step to release procedure
      pr: avoid two over-allocations
      libstdbuf: plug a very unlikely leak
      tests: fix a syntax-check rule to pass in non-srcdir build
      maint: add a syntax-check rule to check for vulnerable Makefile.in
      maint: move vulnerable-Makefile.in-check to gnulib
      ls --color: don't emit a final no-op escape sequence
      sync with gnulib
      doc: rewrite part of README-release
      tests: include help-version test settings used by gzip and grep
      copy.c: improve a comment
      doc: add a TODO item
      remove.c: remove three unnecessary #include directives
      tests: don't let the LANGUAGE envvar perturb tests
      remove: without -f, avoid unnecessary-expense/issues with euidaccess
      build: update gnulib submodule to latest
      revert to previous working version of gnulib
      build: update gnulib submodule to latest
      maint: add a space before open-paren, where lacking
      maint: mark makefile "dist-hook" target as PHONY
      doc: make README-prereq more generic
      doc: tweak README-prereq again
      maint: code formatting nit
      maint: enforce one small aspect of formatting style: space-before-"("
      cfg.mk: fix copy-paste-o in a diagnostic
      cfg.mk: remove comments with sed rather than cpp -fpreprocessed
      tests: fix typos in envvar-check script
      tests: avoid spurious sc_prohibit_test_minus_ao syntax-check failures
      tests: disable new texinfo-acronym syntax-check from gnulib
      build: update gnulib submodule to latest
      doc: synchronize parts of README-release from grep's version
      build: update gnulib submodule to latest
      build: update gnulib submodule to latest
      build: update gnulib submodule to latest
      maint: fix a masked syntax-check violation
      tests: add a PATH-sanity-check to help-version
      doc: adjust a header in announcement email template
      maint: ftruncate is always available, even without gnulib
      maint: new syntax-check rule: prohibit empty lines at EOF
      tests: more syntax-checks
      tests: avoid spurious failure of root-only ls/capability test
      doc: document our code formatting policy regarding curly braces
      doc: tweak HACKING
      * HACKING (Add tests): Change example name, "newtest" to "new-test".
      build: update gnulib submodule to latest

Joey Degges (1):
      sort: inform the system about our input access pattern

Kamil Dudka (1):
      who --mesg (-T) can use a more accurate test for TTY writability

Kim Hansen (1):
      timeout: use more standard option parsing

Marc Kleine-Budde (1):
      tail: include sys/vfs.h (if possible) when sys/statfs.h is absent

Mike Frysinger (1):
      dircolors: add rxvt-256color and rxvt-unicode256

Moritz Orbach (1):
      ls: fix a regression by honoring NORMAL attributes again

Ondřej Vašík (1):
      tests: cp-a-selinux: skip the test if mounting a loop device fails

Paolo Bonzini (1):
      tests: change help-version to per-program functions

Pádraig Brady (29):
      maint: ensure test independence from config macro format
      doc: add nproc to the texinfo overview menu
      tests: make cp-mv-enotsup-xattr independent of the host file system
      maint: use $(CONFIG_INCLUDE) rather than the hardcoding lib/config.h
      maint: fix an inconsequential memory leak in join
      join: make -t '' operate on the whole line
      maint: fix a typo in NEWS
      tests: fix various timeout races
      doc: remove extraneous periods from --help output
      doc: fix inconsistent capitalization in --help output
      tests: fix an unlikely race in tail-2/inotify-hash-abuse2
      maint: fix the man page correlation tests
      maint: clean up the output from syntax-check rules
      sort: fix issues with month sorting in some locales
      maint: rename the si_present variable in sort to iec_present
      doc: Add an example for cutting fields separated by runs of blanks
      timeout: add the --kill-after option
      maint: update the mbsalign module
      maint: mbsalign: fix an edge case where we truncate too much
      doc: fix info on cp --preserve=all, which does _not_ give xattr warnings
      nice,chroot: use more standard option parsing
      doc: mention that "capabilities" are preserved by cp/mv
      doc: clarify when cp and mv output xattr warnings
      cp: treat selinux warnings consistently
      tests: avoid spurious failure of ls/color-norm test
      maint: fix build on platforms that replace strsignal
      cp: preserve "capabilities" when also preserving file ownership
      sort: fix parsing of end field in obsolescent key formats
      maint: update a couple of NEWS items for the pending release

Ralf Wildenhues (1):
      revert "maint: mark makefile "dist-hook" target as PHONY"

Thien-Thi Nguyen (1):
      doc: use mktemp, not tempfile, in a shred usage example

[Message part 2 (application/pgp-signature, inline)]

Message #8 received at 5999 <at> debbugs.gnu.org (full text, mbox):

From: "Gilles Espinasse" <g.esp <at> free.fr>
To: <5999 <at> debbugs.gnu.org>,
	"Jim Meyering" <jim <at> meyering.net>
Subject: Re: bug#5999: new snapshot available: coreutils-8.4.100-81926
Date: Thu, 22 Apr 2010 07:29:43 +0200

----- Original Message ----- 
From: "Jim Meyering" <jim <at> meyering.net>
To: <5999 <at> debbugs.gnu.org>
Cc: <coordinator <at> translationproject.org>
Sent: Wednesday, April 21, 2010 10:33 PM
Subject: bug#5999: new snapshot available: coreutils-8.4.100-81926

> I think we're ready for coreutils-8.5.
> In preparation, here's a snapshot.  Please beat it up.

A few warning during tests (x86, gcc-4.4.3) in gnulib-tests, but less than
8.4 with same compiler.
Every test PASS or SKIP

There is a few SKIP that I am not sure of the real cause
./misc/pwd-unreadable-parent: skipping test: can't use buggy system getcwd
SKIP: misc/pwd-unreadable-parent

./df/total-verify: skipping test: df fails
SKIP: df/total-verify

(FS is ext3)
./du/slink: skipping test: `.' is on an XFS file system
SKIP: du/slink

./mv/i-3: skipping test: /dev/stdin is not readable
SKIP: mv/i-3

Here is the diff of the tests log between 8.4 and 8.4.100-81926 (I removed
some noise entering and exiting directories), first run as root, then as
nobody.

-make[4]: Entering directory `/usr/src/coreutils-8.4/tests'
-make[5]: Entering directory `/usr/src/coreutils-8.4/tests'
+make[4]: Entering directory `/usr/src/coreutils-8.4.100-81926/tests'
+make[5]: Entering directory `/usr/src/coreutils-8.4.100-81926/tests'
 PASS: chown/basic
 ./cp/cp-a-selinux: skipping test: this system (or maybe just the current
file system) lacks SELinux support
 SKIP: cp/cp-a-selinux
@@ -13,6 +13,8 @@
 PASS: cp/special-bits
 ./cp/cp-mv-enotsup-xattr: skipping test: failed to get xattr of file
 SKIP: cp/cp-mv-enotsup-xattr
+./cp/capability: skipping test: configured without libcap support
+SKIP: cp/capability
 ./dd/skip-seek-past-dev: skipping test: failed to determine size of -
 SKIP: dd/skip-seek-past-dev
 PASS: install/install-C-root
@@ -36,36 +38,36 @@
 PASS: touch/now-owned-by-other
 ======================
 All 14 tests passed
-(7 tests were not run)
+(8 tests were not run)
 ======================
...
@@ -115,7 +117,7 @@
 PASS: rm/empty-name
 PASS: rm/f-1
 PASS: rm/fail-eacces
-PASS: rm/fail-eperm
+SKIP: rm/fail-eperm
 ./tail-2/assert: skipping test: very expensive: disabled by default
 SKIP: tail-2/assert
 PASS: rm/hash
@@ -248,6 +250,7 @@
 PASS: misc/sort-files0-from
 PASS: misc/sort-merge
 PASS: misc/sort-merge-fdlimit
+PASS: misc/sort-month
 PASS: misc/sort-rand
 PASS: misc/sort-version
 PASS: misc/split-a
@@ -260,8 +263,7 @@
 PASS: misc/stdbuf
 PASS: misc/stty
 PASS: misc/stty-invalid
-./misc/stty-row-col: skipping test: can't increase window size
-SKIP: misc/stty-row-col
+PASS: misc/stty-row-col
 ./misc/su-fail: skipping test: required program(s) not built
 SKIP: misc/su-fail
 PASS: misc/sum
@@ -405,6 +407,7 @@
 PASS: ls/abmon-align
 PASS: ls/color-clear-to-eol
 PASS: ls/color-dtype-dir
+PASS: ls/color-norm
 PASS: ls/dangle
 PASS: ls/dired
 PASS: ls/file-type
@@ -530,6 +533,8 @@
 SKIP: cp/special-bits
 ./cp/cp-mv-enotsup-xattr: skipping test: must be run as root
 SKIP: cp/cp-mv-enotsup-xattr
+./cp/capability: skipping test: must be run as root
+SKIP: cp/capability
 ./dd/skip-seek-past-dev: skipping test: must be run as root
 SKIP: dd/skip-seek-past-dev
 ./install/install-C-root: skipping test: must be run as root
@@ -563,20 +568,22 @@
 ./touch/now-owned-by-other: skipping test: must be run as root
 SKIP: touch/now-owned-by-other
 =======================
-All 357 tests passed
-(59 tests were not run)
+All 359 tests passed
+(60 tests were not run)
 =======================
...
 Making check in gnulib-tests
...
+make[6]: Entering directory `/usr/src/coreutils-8.4.100-81926/gnulib-tests'
   CC       glthread/thread.o
+  CC       ioctl.o
   CC       read-file.o
   CC       unlinkdir.o
   AR       libtests.a
@@ -593,16 +600,10 @@
   CC       test-alloca-opt.o
   CCLD     test-alloca-opt
   CC       test-areadlink.o
-test-areadlink.c: In function 'main':
-test-areadlink.c:49: warning: ignoring return value of 'system', declared
with attribute warn_unused_result
   CCLD     test-areadlink
   CC       test-areadlink-with-size.o
-test-areadlink-with-size.c: In function 'main':
-test-areadlink-with-size.c:42: warning: ignoring return value of 'system',
declared with attribute warn_unused_result
   CCLD     test-areadlink-with-size
   CC       test-areadlinkat.o
-test-areadlinkat.c: In function 'main':
-test-areadlinkat.c:53: warning: ignoring return value of 'system', declared
with attribute warn_unused_result
   CCLD     test-areadlinkat
   CC       test-argmatch.o
   CCLD     test-argmatch
@@ -627,18 +628,12 @@
   CC       test-c-strncasecmp.o
   CCLD     test-c-strncasecmp
   CC       test-canonicalize.o
-test-canonicalize.c: In function 'main':
-test-canonicalize.c:49: warning: ignoring return value of 'system',
declared with attribute warn_unused_result
   CCLD     test-canonicalize
   CC       test-chown.o
-test-chown.c: In function 'main':
-test-chown.c:45: warning: ignoring return value of 'system', declared with
attribute warn_unused_result
   CCLD     test-chown
   CC       test-cloexec.o
   CCLD     test-cloexec
   CC       test-closein.o
-test-closein.c: In function 'main':
-test-closein.c:50: warning: ignoring return value of 'fread', declared with
attribute warn_unused_result
   CCLD     test-closein
   CC       test-md5.o
   CCLD     test-md5
@@ -735,12 +730,13 @@
   CC       test-getopt.o
   CCLD     test-getopt
   CC       test-gettimeofday.o
-test-gettimeofday.c:23: warning: initialization from incompatible pointer
type
   CCLD     test-gettimeofday
   CC       test-hash.o
   CCLD     test-hash
   CC       test-i-ring.o
   CCLD     test-i-ring
+  CC       test-iconv-h.o
+  CCLD     test-iconv-h
   CC       test-iconv.o
   CCLD     test-iconv
   CC       test-inet_ntop.o
@@ -760,16 +756,10 @@
   CC       test-langinfo.o
   CCLD     test-langinfo
   CC       test-lchown.o
-test-lchown.c: In function 'main':
-test-lchown.c:45: warning: ignoring return value of 'system', declared with
attribute warn_unused_result
   CCLD     test-lchown
   CC       test-link.o
-test-link.c: In function 'main':
-test-link.c:43: warning: ignoring return value of 'system', declared with
attribute warn_unused_result
   CCLD     test-link
   CC       test-linkat.o
-test-linkat.c: In function 'main':
-test-linkat.c:84: warning: ignoring return value of 'system', declared with
attribute warn_unused_result
   CCLD     test-linkat
   CC       test-locale.o
   CCLD     test-locale
@@ -778,8 +768,6 @@
   CC       test-lseek.o
   CCLD     test-lseek
   CC       test-lstat.o
-test-lstat.c: In function 'main':
-test-lstat.c:56: warning: ignoring return value of 'system', declared with
attribute warn_unused_result
   CCLD     test-lstat
   CC       test-malloca.o
   CCLD     test-malloca
@@ -787,6 +775,8 @@
   CCLD     test-math
   CC       test-mbrtowc.o
   CCLD     test-mbrtowc
+  CC       test-mbsalign.o
+  CCLD     test-mbsalign
   CC       test-mbscasecmp.o
   CCLD     test-mbscasecmp
   CC       test-mbsinit.o
@@ -808,8 +798,6 @@
   CC       test-memrchr.o
   CCLD     test-memrchr
   CC       test-mkdir.o
-test-mkdir.c: In function 'main':
-test-mkdir.c:43: warning: ignoring return value of 'system', declared with
attribute warn_unused_result
   CCLD     test-mkdir
   CC       test-nanosleep.o
   CCLD     test-nanosleep
@@ -824,22 +812,14 @@
   CC       test-openat-safer.o
   CCLD     test-openat-safer
   CC       test-fchownat.o
-test-fchownat.c: In function 'main':
-test-fchownat.c:66: warning: ignoring return value of 'system', declared
with attribute warn_unused_result
   CCLD     test-fchownat
   CC       test-fstatat.o
-test-fstatat.c: In function 'main':
-test-fstatat.c:65: warning: ignoring return value of 'system', declared
with attribute warn_unused_result
   CCLD     test-fstatat
   CC       test-mkdirat.o
-test-mkdirat.c: In function 'main':
-test-mkdirat.c:54: warning: ignoring return value of 'system', declared
with attribute warn_unused_result
   CCLD     test-mkdirat
   CC       test-openat.o
   CCLD     test-openat
   CC       test-unlinkat.o
-test-unlinkat.c: In function 'main':
-test-unlinkat.c:65: warning: ignoring return value of 'system', declared
with attribute warn_unused_result
   CCLD     test-unlinkat
   CC       test-perror.o
   CCLD     test-perror
@@ -856,41 +836,33 @@
   CC       test-read-file.o
   CCLD     test-read-file
   CC       test-readlink.o
-test-readlink.c: In function 'main':
-test-readlink.c:44: warning: ignoring return value of 'system', declared
with attribute warn_unused_result
   CCLD     test-readlink
   CC       test-remove.o
-test-remove.c: In function 'main':
-test-remove.c:41: warning: ignoring return value of 'system', declared with
attribute warn_unused_result
   CCLD     test-remove
   CC       test-rename.o
-test-rename.c: In function 'main':
-test-rename.c:42: warning: ignoring return value of 'system', declared with
attribute warn_unused_result
   CCLD     test-rename
   CC       test-rmdir.o
-test-rmdir.c: In function 'main':
-test-rmdir.c:43: warning: ignoring return value of 'system', declared with
attribute warn_unused_result
   CCLD     test-rmdir
   CC       test-select.o
 test-select.c: In function 'test_accept_first':
-test-select.c:293: warning: ignoring return value of 'write', declared with
attribute warn_unused_result
-test-select.c:294: warning: ignoring return value of 'read', declared with
attribute warn_unused_result
-test-select.c:305: warning: ignoring return value of 'write', declared with
attribute warn_unused_result
-test-select.c:309: warning: ignoring return value of 'read', declared with
attribute warn_unused_result
-test-select.c:310: warning: ignoring return value of 'write', declared with
attribute warn_unused_result
+test-select.c:295: warning: ignoring return value of 'write', declared with
attribute warn_unused_result
+test-select.c:296: warning: ignoring return value of 'read', declared with
attribute warn_unused_result
+test-select.c:307: warning: ignoring return value of 'write', declared with
attribute warn_unused_result
+test-select.c:311: warning: ignoring return value of 'read', declared with
attribute warn_unused_result
+test-select.c:312: warning: ignoring return value of 'write', declared with
attribute warn_unused_result
 test-select.c: In function 'test_pair':
-test-select.c:328: warning: ignoring return value of 'write', declared with
attribute warn_unused_result
-test-select.c:334: warning: ignoring return value of 'read', declared with
attribute warn_unused_result
+test-select.c:330: warning: ignoring return value of 'write', declared with
attribute warn_unused_result
+test-select.c:336: warning: ignoring return value of 'read', declared with
attribute warn_unused_result
 test-select.c: In function 'test_socket_pair':
-test-select.c:354: warning: ignoring return value of 'write', declared with
attribute warn_unused_result
+test-select.c:356: warning: ignoring return value of 'write', declared with
attribute warn_unused_result
 test-select.c: In function 'test_pipe':
-test-select.c:366: warning: ignoring return value of 'pipe', declared with
attribute warn_unused_result
+test-select.c:368: warning: ignoring return value of 'pipe', declared with
attribute warn_unused_result
   CCLD     test-select
   CC       test-select-fd.o
   CCLD     test-select-fd
   CC       test-select-stdin.o
 test-select-stdin.c: In function 'main':
-test-select-stdin.c:77: warning: ignoring return value of 'read', declared
with attribute warn_unused_result
+test-select-stdin.c:79: warning: ignoring return value of 'read', declared
with attribute warn_unused_result
   CCLD     test-select-stdin
   CC       test-setenv.o
   CCLD     test-setenv
@@ -931,12 +903,8 @@
   CC       test-strtod.o
   CCLD     test-strtod
   CC       test-symlink.o
-test-symlink.c: In function 'main':
-test-symlink.c:43: warning: ignoring return value of 'system', declared
with attribute warn_unused_result
   CCLD     test-symlink
   CC       test-symlinkat.o
-test-symlinkat.c: In function 'main':
-test-symlinkat.c:67: warning: ignoring return value of 'system', declared
with attribute warn_unused_result
   CCLD     test-symlinkat
   CC       test-sys_ioctl.o
   CCLD     test-sys_ioctl
@@ -969,16 +937,14 @@
   CC       uniwidth/test-uc_width2.o
   CCLD     test-uc_width2
   CC       test-unlink.o
-test-unlink.c: In function 'main':
-test-unlink.c:45: warning: ignoring return value of 'system', declared with
attribute warn_unused_result
   CCLD     test-unlink
   CC       test-unsetenv.o
   CCLD     test-unsetenv
+  CC       test-userspec.o
+  CCLD     test-userspec
   CC       test-usleep.o
   CCLD     test-usleep
   CC       test-utimens.o
-test-utimens.c: In function 'main':
-test-utimens.c:69: warning: ignoring return value of 'system', declared
with attribute warn_unused_result
   CCLD     test-utimens
   CC       test-vasnprintf.o
   CCLD     test-vasnprintf
@@ -1018,10 +984,10 @@
   CCLD     test-xvasprintf
   CC       test-yesno.o
   CCLD     test-yesno
-make[6]: Leaving directory `/usr/src/coreutils-8.4/gnulib-tests'
+make[6]: Leaving directory `/usr/src/coreutils-8.4.100-81926/gnulib-tests'
 make  check-TESTS
-make[6]: Entering directory `/usr/src/coreutils-8.4/gnulib-tests'
-make[7]: Entering directory `/usr/src/coreutils-8.4/gnulib-tests'
+make[6]: Entering directory `/usr/src/coreutils-8.4.100-81926/gnulib-tests'
+make[7]: Entering directory `/usr/src/coreutils-8.4.100-81926/gnulib-tests'
 SKIP: test-file-has-acl.sh
 PASS: test-set-mode-acl.sh
 SKIP: test-copy-acl.sh
@@ -1038,7 +1004,7 @@
 PASS: test-binary-io.sh
 PASS: test-bitrotate
 SKIP: test-btowc1.sh
-SKIP: test-btowc2.sh
+PASS: test-btowc2.sh
 PASS: test-c-ctype
 PASS: test-c-strcase.sh
 PASS: test-canonicalize
@@ -1090,7 +1056,7 @@
 PASS: test-fsync
 PASS: test-ftello.sh
 PASS: test-ftello2.sh
-PASS: test-getaddrinfo
+SKIP: test-getaddrinfo
 PASS: test-getcwd
 PASS: test-getdate
 PASS: test-getdelim
@@ -1103,6 +1069,7 @@
 PASS: test-gettimeofday
 PASS: test-hash
 PASS: test-i-ring
+PASS: test-iconv-h
 PASS: test-iconv
 PASS: test-inet_ntop
 PASS: test-inet_pton
@@ -1122,17 +1089,18 @@
 PASS: test-malloca
 PASS: test-math
 SKIP: test-mbrtowc1.sh
-SKIP: test-mbrtowc2.sh
+PASS: test-mbrtowc2.sh
 SKIP: test-mbrtowc3.sh
 SKIP: test-mbrtowc4.sh
-SKIP: test-mbscasecmp.sh
-SKIP: test-mbsinit.sh
+PASS: test-mbsalign
+PASS: test-mbscasecmp.sh
+PASS: test-mbsinit.sh
 SKIP: test-mbsrtowcs1.sh
-SKIP: test-mbsrtowcs2.sh
+PASS: test-mbsrtowcs2.sh
 SKIP: test-mbsrtowcs3.sh
 SKIP: test-mbsrtowcs4.sh
 PASS: test-mbsstr1
-SKIP: test-mbsstr2.sh
+PASS: test-mbsstr2.sh
 SKIP: test-mbsstr3.sh
 PASS: test-memchr
 PASS: test-memchr2
@@ -1203,6 +1171,7 @@
 PASS: test-unlink
 PASS: test-unsetenv
 PASS: test-update-copyright.sh
+PASS: test-userspec
 PASS: test-usleep
 PASS: test-utimens
 PASS: test-vasnprintf
@@ -1225,16 +1194,16 @@
 PASS: test-xvasprintf
 PASS: test-yesno.sh
 =======================
-All 184 tests passed
-(18 tests were not run)
+All 192 tests passed
+(13 tests were not run)
 =======================

Message #13 received at 5999-done <at> debbugs.gnu.org (full text, mbox):

From: Jim Meyering <jim <at> meyering.net>
To: "Gilles Espinasse" <g.esp <at> free.fr>
Cc: 5999-done <at> debbugs.gnu.org
Subject: Re: bug#5999: new snapshot available: coreutils-8.4.100-81926
Date: Thu, 22 Apr 2010 11:14:01 +0200

Gilles Espinasse wrote:
> ----- Original Message -----
> From: "Jim Meyering" <jim <at> meyering.net>
> Subject: bug#5999: new snapshot available: coreutils-8.4.100-81926
>
>> I think we're ready for coreutils-8.5.
>> In preparation, here's a snapshot.  Please beat it up.
>
> A few warning during tests (x86, gcc-4.4.3) in gnulib-tests, but less than
> 8.4 with same compiler.
> Every test PASS or SKIP

Thanks for the quick and detailed feedback.

> There is a few SKIP that I am not sure of the real cause
> ./misc/pwd-unreadable-parent: skipping test: can't use buggy system getcwd
> SKIP: misc/pwd-unreadable-parent

This test works only when the system getcwd works
in spite of an unreadable parent.  Yours is replaced,
so the test must be skipped.

> ./df/total-verify: skipping test: df fails
> SKIP: df/total-verify

That test runs df and skips if it exits nonzero on your system.
Look in tests/df/total-verify.log for details.

> (FS is ext3)
> ./du/slink: skipping test: `.' is on an XFS file system
> SKIP: du/slink

This test would generate spurious failures when using an XFS file
system.  Here's the code:

  if df --type=xfs . >/dev/null 2>&1; then
    # At least on Irix-6.5.19, when using an xfs file system,
    # each created symlink (name lengths up to 255) would have a size of `0'.
    skip_test_ "\`.' is on an XFS file system"
  fi

> ./mv/i-3: skipping test: /dev/stdin is not readable
> SKIP: mv/i-3

Normally, the special file, /dev/stdin is readable.
Without that, we must skip this test.

> Here is the diff of the tests log between 8.4 and 8.4.100-81926 (I removed
> some noise entering and exiting directories), first run as root, then as
> nobody.
>
> -make[4]: Entering directory `/usr/src/coreutils-8.4/tests'

Thanks again!

Message #16 received at 5999 <at> debbugs.gnu.org (full text, mbox):

From: Pádraig Brady <P <at> draigBrady.com>
To: 5999 <at> debbugs.gnu.org
Subject: Re: bug#5999: new snapshot available: coreutils-8.4.100-81926
Date: Thu, 22 Apr 2010 12:36:01 +0100

On 21/04/10 21:33, Jim Meyering wrote:
> I think we're ready for coreutils-8.5.
> In preparation, here's a snapshot.  Please beat it up.

Platform         Passed    Failed    Skipped
--------------------------------------------
Fedora 11 x86       372         0         47
  gnulib            204         0          1
Fedora  5 x86       370         0         49
  gnulib            203         0          2
Solaris 10 x86      348         0         71
Ubuntu 7.10 x86     369         1         49
  FAIL: misc/env (exit: 1)
  ============================
    ++ env sh -c '\c=d echo fail'
    + test xfail = xpass
    + fail=1
Mac OS X 10.6.3     343         0         76
  gnulib            201         2          2
  FAIL: test-posixtm (exit: 1)
  ============================
    000001010000.00 mismatch (-: actual; +:expected)
    --62167132800
    +-62167219200
  FAIL: test-utimens (exit: 134)
  ==============================
    test-utimens.h:91: assertion failed

Might get to investigate this evening.

cheers,
Pádraig.

Message #17 received at 5999-done <at> debbugs.gnu.org (full text, mbox):

From: "Gilles Espinasse" <g.esp <at> free.fr>
To: "Jim Meyering" <jim <at> meyering.net>
Cc: 5999-done <at> debbugs.gnu.org
Subject: Re: bug#5999: new snapshot available: coreutils-8.4.100-81926
Date: Fri, 23 Apr 2010 08:54:27 +0200

----- Original Message ----- 
From: "Jim Meyering" <jim <at> meyering.net>
To: "Gilles Espinasse" <g.esp <at> free.fr>
Cc: <5999-done <at> debbugs.gnu.org>
Sent: Thursday, April 22, 2010 11:14 AM
Subject: Re: bug#5999: new snapshot available: coreutils-8.4.100-81926


> Gilles Espinasse wrote:
> > ----- Original Message -----
> > From: "Jim Meyering" <jim <at> meyering.net>
> > Subject: bug#5999: new snapshot available: coreutils-8.4.100-81926
> >
> >> I think we're ready for coreutils-8.5.
> >> In preparation, here's a snapshot.  Please beat it up.
> >
> > A few warning during tests (x86, gcc-4.4.3) in gnulib-tests, but less
than
> > 8.4 with same compiler.
> > Every test PASS or SKIP
>
> Thanks for the quick and detailed feedback.
>
I forgot to report the spurious configure test
util-linux-ng
[     2.17.2 ] [         0 ] [ DONE ]
e2fsprogs
[    1.41.11 ] [         0 ] [ DONE ]
coreutils
[ 8.4..81926 ]*** %n in writable segment detected ***

To hide that, we use
 gl_cv_func_printf_directive_n=no ./configure

We use gl_cv_func_printf_directive_n=no in gzip and m4 too where the same
problem happen.

> > There is a few SKIP that I am not sure of the real cause
> > ./misc/pwd-unreadable-parent: skipping test: can't use buggy system
getcwd
...
>
> > (FS is ext3)
> > ./du/slink: skipping test: `.' is on an XFS file system
> > SKIP: du/slink
>
> This test would generate spurious failures when using an XFS file
> system.  Here's the code:
>
>   if df --type=xfs . >/dev/null 2>&1; then
>     # At least on Irix-6.5.19, when using an xfs file system,
>     # each created symlink (name lengths up to 255) would have a size of
`0'.
>     skip_test_ "\`.' is on an XFS file system"
>   fi

Should not "\`.' is not an XFS file system" be reported?
>
> > ./mv/i-3: skipping test: /dev/stdin is not readable
> > SKIP: mv/i-3
>
> Normally, the special file, /dev/stdin is readable.
> Without that, we must skip this test.
>
I suspect it is skipped for a bad reason
[chroot-i486] root:/$  ls -l /dev/stdin
lrwxrwxrwx 1 root root 4 Apr 22 17:51 /dev/stdin -> fd/0
[chroot-i486] root:/$ test -r /dev/stdin || echo not readable

I will try to look at that.

Gilles

Message #18 received at 5999-done <at> debbugs.gnu.org (full text, mbox):

From: Jim Meyering <jim <at> meyering.net>
To: "Gilles Espinasse" <g.esp <at> free.fr>
Cc: 5999-done <at> debbugs.gnu.org
Subject: Re: bug#5999: new snapshot available: coreutils-8.4.100-81926
Date: Fri, 23 Apr 2010 09:15:33 +0200

Gilles Espinasse wrote:
...
> I forgot to report the spurious configure test
> util-linux-ng
> [     2.17.2 ] [         0 ] [ DONE ]
> e2fsprogs
> [    1.41.11 ] [         0 ] [ DONE ]
> coreutils
> [ 8.4..81926 ]*** %n in writable segment detected ***

I'm pretty sure that output comes from the C library writing to /dev/tty
during a "run test".

> To hide that, we use
>  gl_cv_func_printf_directive_n=no ./configure
>
> We use gl_cv_func_printf_directive_n=no in gzip and m4 too where the same
> problem happen.

Priming the cache with a value saying "the %n directive is mishandled"
does indeed skip the test and avoid the warning-to-tty, but it may make
the resulting tools unnecessarily avoid using your C library's functions.
Why did you choose "no" rather than "yes"?  At least on glibc-based
systems, %n does work the way it's supposed to.

>> > There is a few SKIP that I am not sure of the real cause
>> > ./misc/pwd-unreadable-parent: skipping test: can't use buggy system
> getcwd
> ...
>>
>> > (FS is ext3)
>> > ./du/slink: skipping test: `.' is on an XFS file system
>> > SKIP: du/slink
>>
>> This test would generate spurious failures when using an XFS file
>> system.  Here's the code:
>>
>>   if df --type=xfs . >/dev/null 2>&1; then
>>     # At least on Irix-6.5.19, when using an xfs file system,
>>     # each created symlink (name lengths up to 255) would have a size of
> `0'.
>>     skip_test_ "\`.' is on an XFS file system"
>>   fi
>
> Should not "\`.' is not an XFS file system" be reported?

The above runs "df --type=xfs .".
If that fails (as it should on an ext3 FS), the "if"-block
should not be run.  Here's what I get:

    $ df --type=xfs .
    df: no file systems processed
    [Exit 1]

>> > ./mv/i-3: skipping test: /dev/stdin is not readable
>> > SKIP: mv/i-3
>>
>> Normally, the special file, /dev/stdin is readable.
>> Without that, we must skip this test.
>>
> I suspect it is skipped for a bad reason
> [chroot-i486] root:/$  ls -l /dev/stdin
> lrwxrwxrwx 1 root root 4 Apr 22 17:51 /dev/stdin -> fd/0
> [chroot-i486] root:/$ test -r /dev/stdin || echo not readable
>
> I will try to look at that.

What does ls -L /dev/stdin print?
Or ls -l /dev/fd/0 ?

Message #19 received at 5999-done <at> debbugs.gnu.org (full text, mbox):

From: "Gilles Espinasse" <g.esp <at> free.fr>
To: "Jim Meyering" <jim <at> meyering.net>
Cc: 5999-done <at> debbugs.gnu.org
Subject: Re: bug#5999: new snapshot available: coreutils-8.4.100-81926
Date: Sat, 24 Apr 2010 08:59:28 +0200

----- Original Message ----- 
From: "Jim Meyering" <jim <at> meyering.net>
To: "Gilles Espinasse" <g.esp <at> free.fr>
Cc: <5999-done <at> debbugs.gnu.org>
Sent: Friday, April 23, 2010 9:15 AM
Subject: Re: bug#5999: new snapshot available: coreutils-8.4.100-81926


> Gilles Espinasse wrote:
> ...
> > I forgot to report the spurious configure test
> > util-linux-ng  [     2.17.2 ] [         0 ] [ DONE ]
> > e2fsprogs     [    1.41.11 ] [         0 ] [ DONE ]
> > coreutils       [ 8.4..81926 ]*** %n in writable segment detected ***
>
> I'm pretty sure that output comes from the C library writing to /dev/tty
> during a "run test".
>
> > To hide that, we use
> >  gl_cv_func_printf_directive_n=no ./configure
> >
> > We use gl_cv_func_printf_directive_n=no in gzip and m4 too where the
same
> > problem happen.
>
> Priming the cache with a value saying "the %n directive is mishandled"
> does indeed skip the test and avoid the warning-to-tty, but it may make
> the resulting tools unnecessarily avoid using your C library's functions.
> Why did you choose "no" rather than "yes"?  At least on glibc-based
> systems, %n does work the way it's supposed to.
>
Thank for the suggestion.
That's not me wich do that change.
I suppose it was set to the value resulting of the test.
I checked to have gl_cv_func_printf_directive_n=no in config.log when using
only ./configure

As the comment in the test program say
| int main ()
| {
|   int count = -1;
|   /* Copy the format string.  Some systems (glibc with _FORTIFY_SOURCE=2)
|      support %n in format strings in read-only memory but not in writable
|      memory.  */
|   strcpy (fmtstring, "%d %n");
|   if (sprintf (buf, fmtstring, 123, &count, 33, 44, 55) < 0
|       || strcmp (buf, "123 ") != 0
|       || count != 4)
|     return 1;
|   return 0;
| }
configure:19018: result: no

We compile now glibc with _FORTIFY_SOURCE=2 and that's the reason of the
failure in the test and why we have the spurious message.
If the test is right, to my understanding, we should not set
gl_cv_func_printf_directive_n=yes

I will change to LIBC_FATAL_STDERR_=1 ./configure so the spurious message is
redirected to stderr. Probably the advice to set LIBC_FATAL_STDERR_=1 to
avoid the spurious character of the message should be added to the test
program.

http://sourceware.org/bugzilla/show_bug.cgi?id=9854

Gilles

Message #20 received at 5999-done <at> debbugs.gnu.org (full text, mbox):

From: Jim Meyering <jim <at> meyering.net>
To: "Gilles Espinasse" <g.esp <at> free.fr>
Cc: Bruno Haible <bruno <at> clisp.org>, 5999-done <at> debbugs.gnu.org,
	bug-gnulib <at> gnu.org
Subject: Re: bug#5999: new snapshot available: coreutils-8.4.100-81926
Date: Mon, 26 Apr 2010 09:05:20 +0200

Gilles Espinasse wrote:
...
>> Priming the cache with a value saying "the %n directive is mishandled"
>> does indeed skip the test and avoid the warning-to-tty, but it may make
>> the resulting tools unnecessarily avoid using your C library's functions.
>> Why did you choose "no" rather than "yes"?  At least on glibc-based
>> systems, %n does work the way it's supposed to.
>>
> Thank for the suggestion.
> That's not me wich do that change.
> I suppose it was set to the value resulting of the test.
> I checked to have gl_cv_func_printf_directive_n=no in config.log when using
> only ./configure
>
> As the comment in the test program say
> | int main ()
> | {
> |   int count = -1;
> |   /* Copy the format string.  Some systems (glibc with _FORTIFY_SOURCE=2)
> |      support %n in format strings in read-only memory but not in writable
> |      memory.  */
> |   strcpy (fmtstring, "%d %n");
> |   if (sprintf (buf, fmtstring, 123, &count, 33, 44, 55) < 0
> |       || strcmp (buf, "123 ") != 0
> |       || count != 4)
> |     return 1;
> |   return 0;
> | }
> configure:19018: result: no
>
> We compile now glibc with _FORTIFY_SOURCE=2 and that's the reason of the
> failure in the test and why we have the spurious message.
> If the test is right, to my understanding, we should not set
> gl_cv_func_printf_directive_n=yes
>
> I will change to LIBC_FATAL_STDERR_=1 ./configure so the spurious message is
> redirected to stderr. Probably the advice to set LIBC_FATAL_STDERR_=1 to
> avoid the spurious character of the message should be added to the test
> program.
>
> http://sourceware.org/bugzilla/show_bug.cgi?id=9854

Thanks, but you should not have to do that.
Here's a patch to make that diagnostic go where it belongs
for all gnulib-using projects:

Bruno, I could have factored out the 4-line snippet into its own
macro instead of writing it twice, but it didn't seem worthwhile...
Ok to commit?


From e793f628df456cece652c3e3b296a113ced676a9 Mon Sep 17 00:00:00 2001
From: Jim Meyering <meyering <at> redhat.com>
Date: Mon, 26 Apr 2010 08:38:15 +0200
Subject: [PATCH] printf: redirect configure time diag, "%n in writable segment detected"

* m4/printf.m4 (gl_PRINTF_DIRECTIVE_N): Arrange for glibc's "%n in
writable segment detected" diagnostic to be written to stderr, where
we can redirect it.
(gl_SNPRINTF_DIRECTIVE_N): Likewise.
Prompted by an exchange with Gilles Espinasse.
---
 ChangeLog    |    9 +++++++++
 m4/printf.m4 |    8 ++++++++
 2 files changed, 17 insertions(+), 0 deletions(-)

diff --git a/ChangeLog b/ChangeLog
index 9208e2f..f39450d 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,12 @@
+2010-04-26  Jim Meyering  <meyering <at> redhat.com>
+
+	printf: redirect configure time diag, "%n in writable segment detected"
+	* m4/printf.m4 (gl_PRINTF_DIRECTIVE_N): Arrange for glibc's "%n in
+	writable segment detected" diagnostic to be written to stderr, where
+	we can redirect it.
+	(gl_SNPRINTF_DIRECTIVE_N): Likewise.
+	Prompted by an exchange with Gilles Espinasse.
+
 2010-04-25  Bruno Haible  <bruno <at> clisp.org>

 	ptsname: Fix misuse of ttyname_r.
diff --git a/m4/printf.m4 b/m4/printf.m4
index ebca536..12649b5 100644
--- a/m4/printf.m4
+++ b/m4/printf.m4
@@ -594,6 +594,10 @@ AC_DEFUN([gl_PRINTF_DIRECTIVE_N],
 [
   AC_REQUIRE([AC_PROG_CC])
   AC_REQUIRE([AC_CANONICAL_HOST]) dnl for cross-compiles
+  # Tell glibc to write its "%n in writable segment detected" diagnostic
+  # to stderr, not to the tty, so that we can redirect it.
+  LIBC_FATAL_STDERR_=1
+  export LIBC_FATAL_STDERR_
   AC_CACHE_CHECK([whether printf supports the 'n' directive],
     [gl_cv_func_printf_directive_n],
     [
@@ -1162,6 +1166,10 @@ AC_DEFUN([gl_SNPRINTF_DIRECTIVE_N],
 [
   AC_REQUIRE([AC_PROG_CC])
   AC_REQUIRE([AC_CANONICAL_HOST]) dnl for cross-compiles
+  # Tell glibc to write its "%n in writable segment detected" diagnostic
+  # to stderr, not to the tty, so that we can redirect it.
+  LIBC_FATAL_STDERR_=1
+  export LIBC_FATAL_STDERR_
   AC_CACHE_CHECK([whether snprintf fully supports the 'n' directive],
     [gl_cv_func_snprintf_directive_n],
     [
--
1.7.1.rc2.340.g38e7f

Message #21 received at 5999-done <at> debbugs.gnu.org (full text, mbox):

From: Paolo Bonzini <bonzini <at> gnu.org>
To: Jim Meyering <jim <at> meyering.net>
Cc: Bruno Haible <bruno <at> clisp.org>, 5999-done <at> debbugs.gnu.org,
	bug-gnulib <at> gnu.org, Gilles Espinasse <g.esp <at> free.fr>
Subject: Re: bug#5999: new snapshot available: coreutils-8.4.100-81926
Date: Mon, 26 Apr 2010 10:26:23 +0200

> Thanks, but you should not have to do that.
> Here's a patch to make that diagnostic go where it belongs
> for all gnulib-using projects:

I wonder if we shouldn't do that for all _autoconf_-using projects!

Paolo

Message #22 received at 5999-done <at> debbugs.gnu.org (full text, mbox):

From: Bruno Haible <bruno <at> clisp.org>
To: Paolo Bonzini <bonzini <at> gnu.org>
Cc: bug-gnulib <at> gnu.org, 5999-done <at> debbugs.gnu.org,
	Gilles Espinasse <g.esp <at> free.fr>, Jim Meyering <jim <at> meyering.net>
Subject: Re: bug#5999: new snapshot available: coreutils-8.4.100-81926
Date: Tue, 27 Apr 2010 01:27:37 +0200

Paolo Bonzini wrote:
> > Here's a patch to make that diagnostic go where it belongs
> > for all gnulib-using projects:
> 
> I wonder if we shouldn't do that for all _autoconf_-using projects!

Or, at least, for all tests in all gnulib-using projects. There are
more possible causes of a FORTIFY message, according to
  <https://wiki.edubuntu.org/CompilerFlags>

How about this proposed patch?


2010-04-26  Jim Meyering  <jim <at> meyering.net>
            Bruno Haible  <bruno <at> clisp.org>

	* m4/gnulib-common.m4 (gl_COMMON_BODY): Set LIBC_FATAL_STDERR_.

--- m4/gnulib-common.m4.orig	Tue Apr 27 01:25:33 2010
+++ m4/gnulib-common.m4	Tue Apr 27 00:01:03 2010
@@ -1,4 +1,4 @@
-# gnulib-common.m4 serial 19
+# gnulib-common.m4 serial 20
 dnl Copyright (C) 2007-2010 Free Software Foundation, Inc.
 dnl This file is free software; the Free Software Foundation
 dnl gives unlimited permission to copy and/or distribute it,
@@ -35,6 +35,12 @@
    is a misnomer outside of parameter lists.  */
 #define _UNUSED_PARAMETER_ _GL_UNUSED
 ])
+  dnl Preparation for running test programs:
+  dnl Tell glibc to write diagnostics from -D_FORTIFY_SOURCE=2 to stderr, not
+  dnl to /dev/tty, so that can be redirected to log files. Such diagnostics
+  dnl occur e.g. in the macros gl_PRINTF_DIRECTIVE_N, gl_SNPRINTF_DIRECTIVE_N.
+  LIBC_FATAL_STDERR_=1
+  export LIBC_FATAL_STDERR_
 ])
 
 # gl_MODULE_INDICATOR_CONDITION

Message #23 received at 5999-done <at> debbugs.gnu.org (full text, mbox):

From: Eric Blake <eblake <at> redhat.com>
To: Bruno Haible <bruno <at> clisp.org>
Cc: Gilles Espinasse <g.esp <at> free.fr>, Paolo Bonzini <bonzini <at> gnu.org>,
	bug-gnulib <at> gnu.org, 5999-done <at> debbugs.gnu.org,
	Jim Meyering <jim <at> meyering.net>
Subject: Re: bug#5999: new snapshot available: coreutils-8.4.100-81926
Date: Mon, 26 Apr 2010 17:31:18 -0600

[Message part 1 (text/plain, inline)]

On 04/26/2010 05:27 PM, Bruno Haible wrote:
>> I wonder if we shouldn't do that for all _autoconf_-using projects!
> 
> Or, at least, for all tests in all gnulib-using projects. There are
> more possible causes of a FORTIFY message, according to
>   <https://wiki.edubuntu.org/CompilerFlags>
> 
> How about this proposed patch?

I like it.

-- 
Eric Blake   eblake <at> redhat.com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

[signature.asc (application/pgp-signature, attachment)]

Message #24 received at 5999-done <at> debbugs.gnu.org (full text, mbox):

From: "Gilles Espinasse" <g.esp <at> free.fr>
To: "Bruno Haible" <bruno <at> clisp.org>,
	"Paolo Bonzini" <bonzini <at> gnu.org>
Cc: 5999-done <at> debbugs.gnu.org, bug-gnulib <at> gnu.org,
	Jim Meyering <jim <at> meyering.net>
Subject: Re: bug#5999: new snapshot available: coreutils-8.4.100-81926
Date: Tue, 27 Apr 2010 07:44:43 +0200

[Message part 1 (text/plain, inline)]

----- Original Message ----- 
From: "Bruno Haible" <bruno <at> clisp.org>
To: "Paolo Bonzini" <bonzini <at> gnu.org>
Cc: "Jim Meyering" <jim <at> meyering.net>; "Gilles Espinasse" <g.esp <at> free.fr>;
<5999-done <at> debbugs.gnu.org>; <bug-gnulib <at> gnu.org>
Sent: Tuesday, April 27, 2010 1:27 AM
Subject: Re: bug#5999: new snapshot available: coreutils-8.4.100-81926


> Paolo Bonzini wrote:
> > > Here's a patch to make that diagnostic go where it belongs
> > > for all gnulib-using projects:
> >
> > I wonder if we shouldn't do that for all _autoconf_-using projects!
>
> Or, at least, for all tests in all gnulib-using projects. There are
> more possible causes of a FORTIFY message, according to
>   <https://wiki.edubuntu.org/CompilerFlags>
>
> How about this proposed patch?
>
>
> 2010-04-26  Jim Meyering  <jim <at> meyering.net>
>             Bruno Haible  <bruno <at> clisp.org>
>
> * m4/gnulib-common.m4 (gl_COMMON_BODY): Set LIBC_FATAL_STDERR_.
>
> --- m4/gnulib-common.m4.orig Tue Apr 27 01:25:33 2010
> +++ m4/gnulib-common.m4 Tue Apr 27 00:01:03 2010
> @@ -1,4 +1,4 @@
> -# gnulib-common.m4 serial 19
> +# gnulib-common.m4 serial 20
>  dnl Copyright (C) 2007-2010 Free Software Foundation, Inc.
>  dnl This file is free software; the Free Software Foundation
>  dnl gives unlimited permission to copy and/or distribute it,
> @@ -35,6 +35,12 @@
>     is a misnomer outside of parameter lists.  */
>  #define _UNUSED_PARAMETER_ _GL_UNUSED
>  ])
> +  dnl Preparation for running test programs:
> +  dnl Tell glibc to write diagnostics from -D_FORTIFY_SOURCE=2 to stderr,
not
> +  dnl to /dev/tty, so that can be redirected to log files. Such
diagnostics
> +  dnl occur e.g. in the macros gl_PRINTF_DIRECTIVE_N,
gl_SNPRINTF_DIRECTIVE_N.
> +  LIBC_FATAL_STDERR_=1
> +  export LIBC_FATAL_STDERR_
>  ])
>
>  # gl_MODULE_INDICATOR_CONDITION

I understand there is a problem but I am unsure of the direction to go.
I made this stupid patch (attached) that include the same test than
gl_cv_func_printf_directive_n in  coreutils sleep usage

[chroot-i486] root:/usr/src/coreutils-8.5$ gl_cv_func_printf_directive_n=no
./configure --prefix=/usr
[chroot-i486] root:/usr/src/coreutils-8.5$ make
[chroot-i486] root:/usr/src/coreutils-8.5$ ./src/sleep; echo $?
./src/sleep: missing operand
Try `./src/sleep --help' for more information.
*** %n in writable segment detected ***
Aborted
134
[chroot-i486] root:/usr/src/coreutils-8.5$ make clean
[chroot-i486] root:/usr/src/coreutils-8.5$ gl_cv_func_printf_directive_n=yes
./configure --prefix=/usr
[chroot-i486] root:/usr/src/coreutils-8.5$ make
[chroot-i486] root:/usr/src/coreutils-8.5$ ./src/sleep; echo $?
./src/sleep: missing operand
Try `./src/sleep --help' for more information.
*** %n in writable segment detected ***
Aborted
134

So result is the same with gl_cv_func_printf_directive_n=no or
gl_cv_func_printf_directive_n=yes.
Am I wrong somewhere?
What is the gain that this test is so written?

Gilles

[sleep_writable-format.patch (application/octet-stream, attachment)]

Message #25 received at 5999-done <at> debbugs.gnu.org (full text, mbox):

From: Jim Meyering <jim <at> meyering.net>
To: Bruno Haible <bruno <at> clisp.org>
Cc: bug-gnulib <at> gnu.org, Paolo Bonzini <bonzini <at> gnu.org>,
	Gilles Espinasse <g.esp <at> free.fr>, 5999-done <at> debbugs.gnu.org
Subject: Re: bug#5999: new snapshot available: coreutils-8.4.100-81926
Date: Tue, 27 Apr 2010 09:04:18 +0200

Bruno Haible wrote:
> Paolo Bonzini wrote:
>> > Here's a patch to make that diagnostic go where it belongs
>> > for all gnulib-using projects:
>>
>> I wonder if we shouldn't do that for all _autoconf_-using projects!
>
> Or, at least, for all tests in all gnulib-using projects. There are
> more possible causes of a FORTIFY message, according to
>   <https://wiki.edubuntu.org/CompilerFlags>
>
> How about this proposed patch?

I like it.  Thanks.
Adjusted and pushed like this:

...
+2010-04-26  Jim Meyering  <jim <at> meyering.net>
+	    Bruno Haible  <bruno <at> clisp.org>
+
+	gnulib-common.m4: make glibc write diagnostics to stderr, not /dev/tty
+	* m4/gnulib-common.m4 (gl_COMMON_BODY): Set LIBC_FATAL_STDERR_.
+	Prompted by an exchange with Gilles Espinasse.
+
 2010-04-26  Jim Meyering  <meyering <at> redhat.com>

 	git-version-gen: aesthetic tweak
diff --git a/m4/gnulib-common.m4 b/m4/gnulib-common.m4
index 54b2517..4c7ac30 100644
--- a/m4/gnulib-common.m4
+++ b/m4/gnulib-common.m4
@@ -1,4 +1,4 @@
-# gnulib-common.m4 serial 19
+# gnulib-common.m4 serial 20
 dnl Copyright (C) 2007-2010 Free Software Foundation, Inc.
 dnl This file is free software; the Free Software Foundation
 dnl gives unlimited permission to copy and/or distribute it,
@@ -35,6 +35,12 @@ AC_DEFUN([gl_COMMON_BODY], [
    is a misnomer outside of parameter lists.  */
 #define _UNUSED_PARAMETER_ _GL_UNUSED
 ])
+  dnl Preparation for running test programs:
+  dnl Tell glibc to write diagnostics from -D_FORTIFY_SOURCE=2 to stderr, not
+  dnl to /dev/tty, so they can be redirected to log files.  Such diagnostics
+  dnl arise e.g., in the macros gl_PRINTF_DIRECTIVE_N, gl_SNPRINTF_DIRECTIVE_N.
+  LIBC_FATAL_STDERR_=1
+  export LIBC_FATAL_STDERR_
 ])

 # gl_MODULE_INDICATOR_CONDITION
--
1.7.1.328.g9993c

Message #26 received at 5999-done <at> debbugs.gnu.org (full text, mbox):

From: Jim Meyering <jim <at> meyering.net>
To: "Gilles Espinasse" <g.esp <at> free.fr>
Cc: bug-gnulib <at> gnu.org, Paolo Bonzini <bonzini <at> gnu.org>,
	Bruno Haible <bruno <at> clisp.org>, 5999-done <at> debbugs.gnu.org
Subject: Re: bug#5999: new snapshot available: coreutils-8.4.100-81926
Date: Tue, 27 Apr 2010 09:12:21 +0200

Gilles Espinasse wrote:
...
> I understand there is a problem but I am unsure of the direction to go.
> I made this stupid patch (attached) that include the same test than
> gl_cv_func_printf_directive_n in  coreutils sleep usage

You should be able to consider this resolved.
Once you start using the latest from gnulib,
you will no longer see that glibc diagnostic mixed in
with configure-output "checking..." messages.

> [chroot-i486] root:/usr/src/coreutils-8.5$ gl_cv_func_printf_directive_n=no
> ./configure --prefix=/usr
> [chroot-i486] root:/usr/src/coreutils-8.5$ make
> [chroot-i486] root:/usr/src/coreutils-8.5$ ./src/sleep; echo $?
> ./src/sleep: missing operand
> Try `./src/sleep --help' for more information.
> *** %n in writable segment detected ***
> Aborted
> 134
> [chroot-i486] root:/usr/src/coreutils-8.5$ make clean
> [chroot-i486] root:/usr/src/coreutils-8.5$ gl_cv_func_printf_directive_n=yes
> ./configure --prefix=/usr
> [chroot-i486] root:/usr/src/coreutils-8.5$ make
> [chroot-i486] root:/usr/src/coreutils-8.5$ ./src/sleep; echo $?
> ./src/sleep: missing operand
> Try `./src/sleep --help' for more information.
> *** %n in writable segment detected ***
> Aborted
> 134
>
> So result is the same with gl_cv_func_printf_directive_n=no or
> gl_cv_func_printf_directive_n=yes.
> Am I wrong somewhere?
> What is the gain that this test is so written?

The success or failure of that test contributes
to whether a project uses the native vasnprintf (because
it passes all tests) or a replacement.
See the many conditions in gnulib/m4/vasnprintf-posix.m4.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.