From unknown Fri Sep 05 09:10:43 2025 X-Loop: help-debbugs@gnu.org Subject: bug#59979: 30.0.50; dockerfile-ts-mode imenu issue Resent-From: Eshel Yaron Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 11 Dec 2022 23:01:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 59979 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 59979@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.167079963916698 (code B ref -1); Sun, 11 Dec 2022 23:01:02 +0000 Received: (at submit) by debbugs.gnu.org; 11 Dec 2022 23:00:39 +0000 Received: from localhost ([127.0.0.1]:48712 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p4VJG-0004LB-DI for submit@debbugs.gnu.org; Sun, 11 Dec 2022 18:00:38 -0500 Received: from lists.gnu.org ([209.51.188.17]:46790) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p4T6x-0002q3-Jt for submit@debbugs.gnu.org; Sun, 11 Dec 2022 15:39:48 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p4T6x-0003x0-98 for bug-gnu-emacs@gnu.org; Sun, 11 Dec 2022 15:39:47 -0500 Received: from mail.eshelyaron.com ([107.175.124.16] helo=eshelyaron.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p4T6v-0003qI-FR for bug-gnu-emacs@gnu.org; Sun, 11 Dec 2022 15:39:47 -0500 From: Eshel Yaron DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=eshelyaron.com; s=mail; t=1670791184; bh=RkQebpqthyivYVAJ5YsHwN8imiC4iXXVDlRuoPfAHqU=; h=From:To:Subject:Date:From; b=lH7WK6gxGdeJYXDDe7tK7P0gLvaZw55W9v46MCp/W66oiDvV7M7w9YXXeP1u797KG Bpa8JxToJUAv8ld8hqDDLJZwdFbsD5RFb3HzP1MzwZkDLbXOWeAf5YNDKnvfa8IMad Ip621Or4Wr5tz1dq4x0eYPB+V6J6X21JigHJ8wzF7z8xZ/FApQj2wmgJrruqcGKeF2 eDDetCJFDzIfzXEwD5rXb0gelP1DOk8EdfxLaRbh8SJFI+NVG+jlQ1jTY4tS1zjr20 94sIEBf7+LHLbPPE9vCzhVJGVTNBsBFNM8qEgf9BTErwXlmRYR9YXtGefdS64F49Lr bT6kwVWlLOFSA== Date: Sun, 11 Dec 2022 22:39:40 +0200 Message-ID: MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=107.175.124.16; envelope-from=me@eshelyaron.com; helo=eshelyaron.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-Mailman-Approved-At: Sun, 11 Dec 2022 18:00:37 -0500 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) I stumbled upon the following issue while checking out the new dockerfile-ts-mode. 1. emacs -Q 2. C-x C-f /tmp/Dockerfile 3. Insert the following contents (taken from https://docs.docker.com/build/building/multi-stage/#use-a-previous-stage-as-a-new-stage): FROM ubuntu AS base RUN echo "base" FROM base AS stage1 RUN echo "stage1" FROM base AS stage2 RUN echo "stage2" 4. Try to use M-x imenu to navigate to the last build stage 4.a. We get the following imenu--index-alist: (("Stage" ("ubuntu" . #) ("base" . #) ("base" . #))) 4.b. Consequently, we can't choose and jump to the last stage, because dockerfile-ts-mode calls both of the last two stages by the same name ("base"). The crux of the issue is that dockerfile-ts-mode uses a stage's base image as its name, which seems kinda wrong and leads to ambiguity since many stages can have a common base image. Instead, it would be preferable IMO to use the index of the stage or, when available, its unique name (such as "stage1" in the example above). Thanks! In GNU Emacs 30.0.50 (build 9, x86_64-apple-darwin22.1.0, NS appkit-2299.00 Version 13.0 (Build 22A380)) of 2022-12-11 built on esmac.lan Repository revision: 85108d541217f0333860c4f86c3b16b4349f85a4 Repository branch: master Windowing system distributor 'Apple', version 10.3.2299 System Description: macOS 13.0 Configured using: 'configure --with-native-compilation --enable-link-time-optimization --with-json --with-xwidgets --with-mailutils --with-imagemagick --without-dbus' Configured features: ACL GIF GLIB GMP GNUTLS IMAGEMAGICK JPEG JSON LCMS2 LIBXML2 MODULES NATIVE_COMP NOTIFY KQUEUE NS PDUMPER PNG RSVG SQLITE3 THREADS TIFF TOOLKIT_SCROLL_BARS TREE_SITTER WEBP XIM XWIDGETS ZLIB Important settings: value of $LC_CTYPE: UTF-8 locale-coding-system: utf-8-unix Major mode: Dockerfile Minor modes in effect: tooltip-mode: t global-eldoc-mode: t show-paren-mode: t electric-indent-mode: t mouse-wheel-mode: t tool-bar-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t line-number-mode: t indent-tabs-mode: t transient-mark-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t Load-path shadows: None found. Features: (shadow sort mail-extr emacsbug message mailcap yank-media puny dired dired-loaddefs rfc822 mml mml-sec password-cache epa derived epg rfc6068 epg-config gnus-util text-property-search time-date mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader sendmail rfc2047 rfc2045 ietf-drums mm-util mail-prsvr mail-utils pp cl-print byte-opt help-fns radix-tree thingatpt imenu comp comp-cstr warnings icons subr-x rx cl-macs gv cl-extra help-mode bytecomp byte-compile dockerfile-ts-mode treesit cl-seq cl-loaddefs cl-lib rmc iso-transl tooltip cconv eldoc paren electric uniquify ediff-hook vc-hooks lisp-float-type elisp-mode mwheel term/ns-win ns-win ucs-normalize mule-util term/common-win tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow isearch easymenu timer select scroll-bar mouse jit-lock font-lock syntax font-core term/tty-colors frame minibuffer nadvice seq simple cl-generic indonesian philippine cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite emoji-zwj charscript charprop case-table epa-hook jka-cmpr-hook help abbrev obarray oclosure cl-preloaded button loaddefs theme-loaddefs faces cus-face macroexp files window text-properties overlay sha1 md5 base64 format env code-pages mule custom widget keymap hashtable-print-readable backquote threads xwidget-internal kqueue cocoa ns lcms2 multi-tty make-network-process native-compile emacs) Memory information: ((conses 16 111634 8544) (symbols 48 7501 0) (strings 32 31342 3006) (string-bytes 1 961129) (vectors 16 23207) (vector-slots 8 403727 9539) (floats 8 60 40) (intervals 56 396 0) (buffers 984 14)) From unknown Fri Sep 05 09:10:43 2025 X-Loop: help-debbugs@gnu.org Subject: bug#59979: 30.0.50; dockerfile-ts-mode imenu issue Resent-From: Randy Taylor Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 11 Dec 2022 23:58:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59979 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eshel Yaron Cc: 59979@debbugs.gnu.org Received: via spool by 59979-submit@debbugs.gnu.org id=B59979.167080305618708 (code B ref 59979); Sun, 11 Dec 2022 23:58:02 +0000 Received: (at 59979) by debbugs.gnu.org; 11 Dec 2022 23:57:36 +0000 Received: from localhost ([127.0.0.1]:48947 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p4WCO-0004rg-EP for submit@debbugs.gnu.org; Sun, 11 Dec 2022 18:57:36 -0500 Received: from mail-4323.proton.ch ([185.70.43.23]:14291) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p4WCN-0004rX-8Y for 59979@debbugs.gnu.org; Sun, 11 Dec 2022 18:57:35 -0500 Date: Sun, 11 Dec 2022 23:57:23 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rjt.dev; s=protonmail2; t=1670803049; x=1671062249; bh=vbS/kaIxCL5LmC0b5oLt80PwXJcOIVBwmuSGMCbytao=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector; b=VT3zDOY2RqwpYumxlkQNKVHHCTdNycALxi9CNsxvSguUHYg3LS70SnBIsblrJMh3P EZmBWgvW/r98PXPzQsI2s5HkRwfIkqAiUK1XcKUc7P0a/WyVVc+Tms/ffiStLyPQul 5BqhyRR9gMBENXZV9ZQpdpSd3KPNZ86IxJvk4UIHoc0pyV8NIt0kAaYkUDu7oIRAzM vSmu0XPp5X/cb0UtbwrG4bnZlmyRSGYmTH/+aU6B9s+rhAZvjoS/WrxHJwhhHhOsnb TzDRdbxOkjhCXlY7uHcwTlYxakaQqexpTktgPggnl3kL/UJG9a0n8ETWOv8y3iQ7fR HgIeXJzasD2Bw== From: Randy Taylor Message-ID: In-Reply-To: References: Feedback-ID: 44397038:user:proton MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Sunday, December 11th, 2022 at 15:39, Eshel Yaron via "Bug reports for G= NU Emacs, the Swiss army knife of text editors" wro= te: >=20 > I stumbled upon the following issue while checking out the new > dockerfile-ts-mode. >=20 > 1. emacs -Q > 2. C-x C-f /tmp/Dockerfile > 3. Insert the following contents (taken from > https://docs.docker.com/build/building/multi-stage/#use-a-previous-stage-= as-a-new-stage): >=20 > FROM ubuntu AS base > RUN echo "base" >=20 > FROM base AS stage1 > RUN echo "stage1" >=20 > FROM base AS stage2 > RUN echo "stage2" >=20 > 4. Try to use M-x imenu to navigate to the last build stage > 4.a. We get the following imenu--index-alist: >=20 > (("Stage" > ("ubuntu" . #) >=20 > ("base" . #) >=20 > ("base" . #))) >=20 >=20 > 4.b. Consequently, we can't choose and jump to the last stage, because > dockerfile-ts-mode calls both of the last two stages by the same name > ("base"). >=20 > The crux of the issue is that dockerfile-ts-mode uses a stage's base > image as its name, which seems kinda wrong and leads to ambiguity since > many stages can have a common base image. Instead, it would be > preferable IMO to use the index of the stage or, when available, its > unique name (such as "stage1" in the example above). >=20 > Thanks! >=20 Thanks, I'll take a look and hopefully reply back with a patch in a bit. From unknown Fri Sep 05 09:10:43 2025 X-Loop: help-debbugs@gnu.org Subject: bug#59979: 30.0.50; dockerfile-ts-mode imenu issue Resent-From: Randy Taylor Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 12 Dec 2022 02:31:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59979 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eshel Yaron Cc: 59979@debbugs.gnu.org Received: via spool by 59979-submit@debbugs.gnu.org id=B59979.167081224924220 (code B ref 59979); Mon, 12 Dec 2022 02:31:01 +0000 Received: (at 59979) by debbugs.gnu.org; 12 Dec 2022 02:30:49 +0000 Received: from localhost ([127.0.0.1]:49640 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p4Yae-0006Ia-NG for submit@debbugs.gnu.org; Sun, 11 Dec 2022 21:30:49 -0500 Received: from mail-4317.proton.ch ([185.70.43.17]:54459) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p4Yac-0006II-JC for 59979@debbugs.gnu.org; Sun, 11 Dec 2022 21:30:47 -0500 Date: Mon, 12 Dec 2022 02:30:28 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rjt.dev; s=protonmail2; t=1670812239; x=1671071439; bh=a8LJKsaRtBsaVJgbQAiJgfASbyWFt4VMHPyqNz9/70k=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector; b=ZNb+MSaLq6oRmrjh9VpVaLNAuKoBgqX3dRBkb70KM8xLb1cKLmewQeBY8opvPhTHl 0TIt+WC6akfcwcEFeHtxodZmkWSjg+8nLJRpU6j+WD3v5zo90wdFoJEZmghQKNQ/4e D6WX1dBd5dWDNt3Gr3J7obRsq96EsjElm+z1pQwRAxRyZp69ubW4QCy8Nbitkmcjqq yWnxejdkjQWWqo/rEXICnyrTlhLorHzwh2YP948yqAo7kvtN32kjudt1HVdwmz7JsO kxaEdcAfHh5VdmYyJB0IMbiy+4ueRRPNr78W+Wx3vPOPosGPA12PPLm51NTTmQ1C3h k6q/LH2Jv9gRg== From: Randy Taylor Message-ID: In-Reply-To: References: Feedback-ID: 44397038:user:proton MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="b1_Qjx0tQRLpbbgPXWMP0wR8rri8c5YK44wTY7AdQmSMg" X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) This is a multi-part message in MIME format. --b1_Qjx0tQRLpbbgPXWMP0wR8rri8c5YK44wTY7AdQmSMg Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On Sunday, December 11th, 2022 at 18:57, Randy Taylor wrote: >=20 > On Sunday, December 11th, 2022 at 15:39, Eshel Yaron via "Bug reports for= GNU Emacs, the Swiss army knife of text editors" bug-gnu-emacs@gnu.org wro= te: >=20 > > I stumbled upon the following issue while checking out the new > > dockerfile-ts-mode. > >=20 > > 1. emacs -Q > > 2. C-x C-f /tmp/Dockerfile > > 3. Insert the following contents (taken from > > https://docs.docker.com/build/building/multi-stage/#use-a-previous-stag= e-as-a-new-stage): > >=20 > > FROM ubuntu AS base > > RUN echo "base" > >=20 > > FROM base AS stage1 > > RUN echo "stage1" > >=20 > > FROM base AS stage2 > > RUN echo "stage2" > >=20 > > 4. Try to use M-x imenu to navigate to the last build stage > > 4.a. We get the following imenu--index-alist: > >=20 > > (("Stage" > > ("ubuntu" . #) > >=20 > > ("base" . #) > >=20 > > ("base" . #))) > >=20 > > 4.b. Consequently, we can't choose and jump to the last stage, because > > dockerfile-ts-mode calls both of the last two stages by the same name > > ("base"). > >=20 > > The crux of the issue is that dockerfile-ts-mode uses a stage's base > > image as its name, which seems kinda wrong and leads to ambiguity since > > many stages can have a common base image. Instead, it would be > > preferable IMO to use the index of the stage or, when available, its > > unique name (such as "stage1" in the example above). > >=20 > > Thanks! >=20 >=20 > Thanks, I'll take a look and hopefully reply back with a patch in a bit. >=20 I didn't notice this because I use conult-imenu, which will add an index fo= r any duplicates. imenu doesn't do this, and for other modes like c-mode, c= ++-mode, org-mode, etc., only the first entry gets shown. I've attached a patch which will use the stage name if it's available, othe= rwise use the base image. --b1_Qjx0tQRLpbbgPXWMP0wR8rri8c5YK44wTY7AdQmSMg Content-Type: text/x-patch; name=0001-Improve-dockerfile-ts-mode-imenu-generation-Bug-5997.patch Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename=0001-Improve-dockerfile-ts-mode-imenu-generation-Bug-5997.patch RnJvbSAwOWZmYWRkOWY1ZGIxOTE3NGRjZWQ1NzJmM2YwYWM5OGY3ZDJhM2EzIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBSYW5keSBUYXlsb3IgPGRldkByanQuZGV2PgpEYXRlOiBTdW4s IDExIERlYyAyMDIyIDIwOjUwOjU0IC0wNTAwClN1YmplY3Q6IFtQQVRDSF0gSW1wcm92ZSBkb2Nr ZXJmaWxlLXRzLW1vZGUgaW1lbnUgZ2VuZXJhdGlvbiAoQnVnIzU5OTc5KQoKKiBsaXNwL3Byb2dt b2Rlcy9kb2NrZXJmaWxlLXRzLW1vZGUuZWwgKHRyZWVzaXQtbm9kZS1jaGlsZC1ieS1maWVsZC1u YW1lKToKRGVjbGFyZS4KKGRvY2tlcmZpbGUtdHMtbW9kZS0taW1lbnUtMSk6IFVzZSBzdGFnZSBu YW1lIGlmIGF2YWlsYWJsZS4KLS0tCiBsaXNwL3Byb2dtb2Rlcy9kb2NrZXJmaWxlLXRzLW1vZGUu ZWwgfCA3ICsrKysrLS0KIDEgZmlsZSBjaGFuZ2VkLCA1IGluc2VydGlvbnMoKyksIDIgZGVsZXRp b25zKC0pCgpkaWZmIC0tZ2l0IGEvbGlzcC9wcm9nbW9kZXMvZG9ja2VyZmlsZS10cy1tb2RlLmVs IGIvbGlzcC9wcm9nbW9kZXMvZG9ja2VyZmlsZS10cy1tb2RlLmVsCmluZGV4IDU0NGUwZjgyZDYu LjQwZDkwY2MyZGYgMTAwNjQ0Ci0tLSBhL2xpc3AvcHJvZ21vZGVzL2RvY2tlcmZpbGUtdHMtbW9k ZS5lbAorKysgYi9saXNwL3Byb2dtb2Rlcy9kb2NrZXJmaWxlLXRzLW1vZGUuZWwKQEAgLTMzLDYg KzMzLDcgQEAKIChkZWNsYXJlLWZ1bmN0aW9uIHRyZWVzaXQtcGFyc2VyLWNyZWF0ZSAidHJlZXNp dC5jIikKIChkZWNsYXJlLWZ1bmN0aW9uIHRyZWVzaXQtaW5kdWNlLXNwYXJzZS10cmVlICJ0cmVl c2l0LmMiKQogKGRlY2xhcmUtZnVuY3Rpb24gdHJlZXNpdC1ub2RlLWNoaWxkICJ0cmVlc2l0LmMi KQorKGRlY2xhcmUtZnVuY3Rpb24gdHJlZXNpdC1ub2RlLWNoaWxkLWJ5LWZpZWxkLW5hbWUgInRy ZWVzaXQuYyIpCiAoZGVjbGFyZS1mdW5jdGlvbiB0cmVlc2l0LW5vZGUtc3RhcnQgInRyZWVzaXQu YyIpCiAoZGVjbGFyZS1mdW5jdGlvbiB0cmVlc2l0LW5vZGUtdHlwZSAidHJlZXNpdC5jIikKIApA QCAtMTE3LDggKzExOCwxMCBAQCBkb2NrZXJmaWxlLXRzLW1vZGUtLWltZW51LTEKICAgICAgICAg ICAgICAgICAgICAgICAgICAgIGNoaWxkcmVuKSkKICAgICAgICAgIChuYW1lICh3aGVuIHRzLW5v ZGUKICAgICAgICAgICAgICAgICAgKHBjYXNlICh0cmVlc2l0LW5vZGUtdHlwZSB0cy1ub2RlKQot ICAgICAgICAgICAgICAgICAgICgiZnJvbV9pbnN0cnVjdGlvbiIgKHRyZWVzaXQtbm9kZS10ZXh0 Ci0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgKHRyZWVzaXQtbm9kZS1j aGlsZCB0cy1ub2RlIDEpIHQpKSkpKQorICAgICAgICAgICAgICAgICAgICgiZnJvbV9pbnN0cnVj dGlvbiIKKyAgICAgICAgICAgICAgICAgICAgKHRyZWVzaXQtbm9kZS10ZXh0CisgICAgICAgICAg ICAgICAgICAgICAob3IgKHRyZWVzaXQtbm9kZS1jaGlsZC1ieS1maWVsZC1uYW1lIHRzLW5vZGUg ImFzIikKKyAgICAgICAgICAgICAgICAgICAgICAgICAodHJlZXNpdC1ub2RlLWNoaWxkIHRzLW5v ZGUgMSkpIHQpKSkpKQogICAgICAgICAgKG1hcmtlciAod2hlbiB0cy1ub2RlCiAgICAgICAgICAg ICAgICAgICAgKHNldC1tYXJrZXIgKG1ha2UtbWFya2VyKQogICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICh0cmVlc2l0LW5vZGUtc3RhcnQgdHMtbm9kZSkpKSkpCi0tIAoyLjM4LjEKCg== --b1_Qjx0tQRLpbbgPXWMP0wR8rri8c5YK44wTY7AdQmSMg-- From unknown Fri Sep 05 09:10:43 2025 X-Loop: help-debbugs@gnu.org Subject: bug#59979: 30.0.50; dockerfile-ts-mode imenu issue Resent-From: Eshel Yaron Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 12 Dec 2022 08:29:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59979 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Randy Taylor Cc: 59979@debbugs.gnu.org Received: via spool by 59979-submit@debbugs.gnu.org id=B59979.167083372117817 (code B ref 59979); Mon, 12 Dec 2022 08:29:02 +0000 Received: (at 59979) by debbugs.gnu.org; 12 Dec 2022 08:28:41 +0000 Received: from localhost ([127.0.0.1]:51359 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p4eAz-0004dJ-8R for submit@debbugs.gnu.org; Mon, 12 Dec 2022 03:28:41 -0500 Received: from mail.eshelyaron.com ([107.175.124.16]:52560 helo=eshelyaron.com) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p4eAx-0004dD-3K for 59979@debbugs.gnu.org; Mon, 12 Dec 2022 03:28:39 -0500 From: Eshel Yaron DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=eshelyaron.com; s=mail; t=1670833717; bh=hJE2OpmRaX3HNmRgztaPIKvTy/dlWf9scOHJIfoH8yc=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=HfCrHh6nPLXaWXBhV0H7mChhylh8ibl7PeZROMPXP97xC/R2Dto4BORuTcNir7GoM NFD48soZhqpRb6xWO/ODM1phwGonyzjiYxA5f/JCZ2pc3dZd+dkdy5/nNyvH+or0d4 W1BRdcCnkmWczz5JLxf1AZOZ5gGC7LTmNLFIHinkZgYXC3qraTnA0BozT55YuCm0OR OLPegnDEaz7KDLv9fAuSKcki8F1ebO0kQnV++34nOq55W7RsXE8dq8VJKCxHYhlI4s YZTUq3e3AbjfrhLLzsdjOc4tj8w8MuhV5i+KJFXRDsNWlUbfUYtWYC/lJbE3ukQHVx SKtgdvtQRVdBQ== In-Reply-To: (Randy Taylor's message of "Mon, 12 Dec 2022 02:30:28 +0000") References: Date: Mon, 12 Dec 2022 10:28:34 +0200 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Randy Taylor writes: > On Sunday, December 11th, 2022 at 18:57, Randy Taylor wrote: > > I didn't notice this because I use conult-imenu, which will add an > index for any duplicates. imenu doesn't do this, and for other modes > like c-mode, c++-mode, org-mode, etc., only the first entry gets > shown. > > I've attached a patch which will use the stage name if it's available, > otherwise use the base image. Great :) That's certainly an improvement. I still maintain that using the base image as an identifier of the build stage is not that useful, it doesn't really identify the stage in any way, like identifying functions their arguments doesn't make a lot of sense. I do see how in practice that'll probably be fine in most cases. From unknown Fri Sep 05 09:10:43 2025 X-Loop: help-debbugs@gnu.org Subject: bug#59979: 30.0.50; dockerfile-ts-mode imenu issue Resent-From: Randy Taylor Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 12 Dec 2022 20:17:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59979 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eshel Yaron Cc: 59979@debbugs.gnu.org Received: via spool by 59979-submit@debbugs.gnu.org id=B59979.167087619913128 (code B ref 59979); Mon, 12 Dec 2022 20:17:02 +0000 Received: (at 59979) by debbugs.gnu.org; 12 Dec 2022 20:16:39 +0000 Received: from localhost ([127.0.0.1]:55093 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p4pE7-0003Pg-3r for submit@debbugs.gnu.org; Mon, 12 Dec 2022 15:16:39 -0500 Received: from mail-4317.proton.ch ([185.70.43.17]:28219) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p4pE4-0003PY-8Z for 59979@debbugs.gnu.org; Mon, 12 Dec 2022 15:16:37 -0500 Date: Mon, 12 Dec 2022 20:16:17 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rjt.dev; s=protonmail2; t=1670876189; x=1671135389; bh=nyKEoO3uPXGJ4IEv7kAc23J1OSKTXAyr8x6a+1KKP5I=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector; b=uLS6ZqJMkdEG8QyVfXtTuXcW1kf3gomBVBGGQtoYIPhR83TrsDDPRlPedw+zbTCwY p5oDtEUa5ubif1DeMbBcmQEAW1e1Kn3HiKTwKmCQLJi9e/L4Gjm1CRtYT8oGaDjVPz HhEJIYJDOUAmr4Nr6AwfmsHrXKyI6stxgAZykl7Jmexi/dAIvo+tp9U1RAKQMOhEEZ 7xKBc2BGb5h2VagjJeX2ARE5WA2FAxdcz+EeYZLzA0YJyWnUj10APHCDaLQdcVE/Cn v3Ja8dYPHahvZ0fXPUyvhyXm9kRf1F9DekmS/Qgetle7iVqVAt0p/5LWDwx83Nfa75 +Td6vntCpg6jg== From: Randy Taylor Message-ID: In-Reply-To: References: Feedback-ID: 44397038:user:proton MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Monday, December 12th, 2022 at 03:28, Eshel Yaron via "Bug reports for G= NU Emacs, the Swiss army knife of text editors" wro= te: >=20 > Randy Taylor dev@rjt.dev writes: >=20 > > On Sunday, December 11th, 2022 at 18:57, Randy Taylor dev@rjt.dev wrote= : > >=20 > > I didn't notice this because I use conult-imenu, which will add an > > index for any duplicates. imenu doesn't do this, and for other modes > > like c-mode, c++-mode, org-mode, etc., only the first entry gets > > shown. > >=20 > > I've attached a patch which will use the stage name if it's available, > > otherwise use the base image. >=20 >=20 > Great :) That's certainly an improvement. >=20 > I still maintain that using the base image as an identifier of the build > stage is not that useful, it doesn't really identify the stage in any > way, like identifying functions their arguments doesn't make a lot of > sense. I do see how in practice that'll probably be fine in most cases. >=20 We don't get any information about which stage is which beyond the base ima= ge and potential alias (which is all Dockerfiles themselves have anyway), s= o we would need to track that stuff ourselves, and I don't think it's worth= the complexity. Dockerfiles give us a solution to this anyway: use aliases= . Perhaps consider trying a different imenu implementation? I use consult-ime= nu which gives indexes for any duplicates (it also flattens imenu which I r= eally like). Maybe someone could add something like that to imenu. Can someone install the patch? Thanks. From unknown Fri Sep 05 09:10:43 2025 X-Loop: help-debbugs@gnu.org Subject: bug#59979: 30.0.50; dockerfile-ts-mode imenu issue References: In-Reply-To: Resent-From: Yuan Fu Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 12 Dec 2022 23:00:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59979 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Randy Taylor Cc: 59979@debbugs.gnu.org, me@eshelyaron.com Received: via spool by 59979-submit@debbugs.gnu.org id=B59979.167088596921207 (code B ref 59979); Mon, 12 Dec 2022 23:00:01 +0000 Received: (at 59979) by debbugs.gnu.org; 12 Dec 2022 22:59:29 +0000 Received: from localhost ([127.0.0.1]:56035 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p4rlh-0005Vz-Fh for submit@debbugs.gnu.org; Mon, 12 Dec 2022 17:59:29 -0500 Received: from mail-pl1-f181.google.com ([209.85.214.181]:46767) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p4rlf-0005Vr-GG for 59979@debbugs.gnu.org; Mon, 12 Dec 2022 17:59:28 -0500 Received: by mail-pl1-f181.google.com with SMTP id jn7so13642594plb.13 for <59979@debbugs.gnu.org>; Mon, 12 Dec 2022 14:59:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:cc:date:message-id:subject:mime-version :content-transfer-encoding:from:from:to:cc:subject:date:message-id :reply-to; bh=D/6uINqlvriBivfnoW3Q+bX9z6tqI5SqlVhNX3TzEuo=; b=UjGOk2rso+vvrJbOSFDnu0WSxALyF7XMspoPUJbP3kTHwBeBzfiIzing6piBa9gjb9 b8oXY/S89lCK4YpvZuMFCUt9W0MPrl+4sqiP6BjDHvulUmY4LlWWOPbecLCsOh4sG14J vFCp2TiU5CvBugcW0rFnEb8x3jsrzoyNhCa6J9/JvaVQenFFTE3cTITM/y5s9wGp8+51 eve50mI9gQpZ5Q4K0g+bj0R0By95m9t465Hx0cr0HwnFoqTc459gwwPaXuMoJ2mroKNz QpgBOfh6IkorwydSf302gXzKRLlpdOv1CWuCVLodYfbdXfIOT/esG3JUtqeqwcq+zWfr spNg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:cc:date:message-id:subject:mime-version :content-transfer-encoding:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=D/6uINqlvriBivfnoW3Q+bX9z6tqI5SqlVhNX3TzEuo=; b=TrQSHg8d/MuqV9hvGMLvk8++CQyngkbCtR82NMqqvKcEDQagTid1igzY33aVc47XFe ToYSj/ey04LbPrcjSmhCAxjnl84O+ZnM5KWYlK2lUHvY4yh2zXEuSyGX6xihenTOX0kc nRqEljSRcDwApw7MfYS4i75Cy4hxjJWX0+Bc/NxVn/5AzPgx6Fp2QSA3+6vTGuBlutWw EOsSb298H8cIanmUEi5FI8mdKtBlM9MUuV5o/VoMOpg+RkWOZx+UffZn7xuuJm4K37Yy 3pGy0zq63g2qn97Yutg7wP+Ess+j6ShQKo1ju0lYPTOCh51WvXrEQYBNcpyrK3VXrxN+ 8JbA== X-Gm-Message-State: ANoB5pmnZvSsyPmeBvxp9m64hX6nyOBygfs6jSFBeKzDuZ++y1jMxFbI gbOo3CkhibXi0AEfxvv5Qh+imItehHR5rw== X-Google-Smtp-Source: AA0mqf5lhSeIcL21CFKS/WSqZffNpgo1rbnFpB1cIJuwPgu7feVLpRe4HF3cWQ92qkk5wwkJF4Oxqw== X-Received: by 2002:a17:903:4cd:b0:189:c57c:9a19 with SMTP id jm13-20020a17090304cd00b00189c57c9a19mr16466659plb.58.1670885961785; Mon, 12 Dec 2022 14:59:21 -0800 (PST) Received: from smtpclient.apple (cpe-172-117-161-177.socal.res.rr.com. [172.117.161.177]) by smtp.gmail.com with ESMTPSA id k5-20020a170902c40500b001766a3b2a26sm6931963plk.105.2022.12.12.14.59.20 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 12 Dec 2022 14:59:21 -0800 (PST) From: Yuan Fu Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.1\)) Message-Id: Date: Mon, 12 Dec 2022 14:59:19 -0800 X-Mailer: Apple Mail (2.3696.120.41.1.1) X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Randy Taylor writes: > On Monday, December 12th, 2022 at 03:28, Eshel Yaron via "Bug reports > for GNU Emacs, the Swiss army knife of text editors" > wrote: >>=20 >> Randy Taylor dev@rjt.dev writes: >>=20 >> > On Sunday, December 11th, 2022 at 18:57, Randy Taylor dev@rjt.dev = wrote: >> >=20 >> > I didn't notice this because I use conult-imenu, which will add an >> > index for any duplicates. imenu doesn't do this, and for other = modes >> > like c-mode, c++-mode, org-mode, etc., only the first entry gets >> > shown. >> >=20 >> > I've attached a patch which will use the stage name if it's = available, >> > otherwise use the base image. >>=20 >>=20 >> Great :) That's certainly an improvement. >>=20 >> I still maintain that using the base image as an identifier of the = build >> stage is not that useful, it doesn't really identify the stage in any >> way, like identifying functions their arguments doesn't make a lot of >> sense. I do see how in practice that'll probably be fine in most = cases. >>=20 > > We don't get any information about which stage is which beyond the > base image and potential alias (which is all Dockerfiles themselves > have anyway), so we would need to track that stuff ourselves, and I > don't think it's worth the complexity. Dockerfiles give us a solution > to this anyway: use aliases. > > Perhaps consider trying a different imenu implementation? I use > consult-imenu which gives indexes for any duplicates (it also flattens > imenu which I really like). Maybe someone could add something like > that to imenu. > > Can someone install the patch? Thanks. Applied, thanks! I=E2=80=99ll leave closing the report to one of you = guys :-) Yuan From unknown Fri Sep 05 09:10:43 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Eshel Yaron Subject: bug#59979: closed (Re: bug#59979: 30.0.50; dockerfile-ts-mode imenu issue) Message-ID: References: X-Gnu-PR-Message: they-closed 59979 X-Gnu-PR-Package: emacs Reply-To: 59979@debbugs.gnu.org Date: Tue, 13 Dec 2022 00:42:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1670892122-3059-1" This is a multi-part message in MIME format... ------------=_1670892122-3059-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #59979: 30.0.50; dockerfile-ts-mode imenu issue which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 59979@debbugs.gnu.org. --=20 59979: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D59979 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1670892122-3059-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 59979-done) by debbugs.gnu.org; 13 Dec 2022 00:41:45 +0000 Received: from localhost ([127.0.0.1]:56543 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p4tMf-0000mz-C0 for submit@debbugs.gnu.org; Mon, 12 Dec 2022 19:41:45 -0500 Received: from mail-4317.proton.ch ([185.70.43.17]:19101) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p4tMc-0000mo-D4 for 59979-done@debbugs.gnu.org; Mon, 12 Dec 2022 19:41:44 -0500 Date: Tue, 13 Dec 2022 00:41:28 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rjt.dev; s=protonmail2; t=1670892094; x=1671151294; bh=0eLliOQW/TAdO076CagrGP/4k4zLAY4rNsJeB6sDj1o=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector; b=fPXXscf7/s7tXhiUyQIPYSfVR3DtdXfytzAcX7Q2MYqcnqSMMm2Uy8S9uL3O6ADdw T20847YU8Y9OvAAJPdWrMazb+tK5pzUPuofIhKnph55V6KqmK4sReaRNuSlbvGYyzY BYCzG1FvJBfCTckiQrpcDYuYBJX/GetQ57HRjAjrdvnIg/7Q7t00d0PZ99brxF8QmH P66JoN28cPv10HA0OiwhhXCKh8fkiBnivQxLfXa2NTmni/Vyl/D5UkySRzD/sJJQYO R8xDONeji/CUySA3xzBlYEwEFW/de2qwtKGCjIbISTErfDEQeY58G0i42UQA3W0bPS u6kOBhR2o8WjQ== To: Yuan Fu From: Randy Taylor Subject: Re: bug#59979: 30.0.50; dockerfile-ts-mode imenu issue Message-ID: In-Reply-To: References: Feedback-ID: 44397038:user:proton MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 59979-done Cc: "59979-done@debbugs.gnu.org" <59979-done@debbugs.gnu.org>, me@eshelyaron.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Monday, December 12th, 2022 at 17:59, Yuan Fu wrote: > > Applied, thanks! I=E2=80=99ll leave closing the report to one of you guys= :-) >=20 > Yuan Thanks! Closing. ------------=_1670892122-3059-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 11 Dec 2022 23:00:39 +0000 Received: from localhost ([127.0.0.1]:48712 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p4VJG-0004LB-DI for submit@debbugs.gnu.org; Sun, 11 Dec 2022 18:00:38 -0500 Received: from lists.gnu.org ([209.51.188.17]:46790) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p4T6x-0002q3-Jt for submit@debbugs.gnu.org; Sun, 11 Dec 2022 15:39:48 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p4T6x-0003x0-98 for bug-gnu-emacs@gnu.org; Sun, 11 Dec 2022 15:39:47 -0500 Received: from mail.eshelyaron.com ([107.175.124.16] helo=eshelyaron.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p4T6v-0003qI-FR for bug-gnu-emacs@gnu.org; Sun, 11 Dec 2022 15:39:47 -0500 From: Eshel Yaron DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=eshelyaron.com; s=mail; t=1670791184; bh=RkQebpqthyivYVAJ5YsHwN8imiC4iXXVDlRuoPfAHqU=; h=From:To:Subject:Date:From; b=lH7WK6gxGdeJYXDDe7tK7P0gLvaZw55W9v46MCp/W66oiDvV7M7w9YXXeP1u797KG Bpa8JxToJUAv8ld8hqDDLJZwdFbsD5RFb3HzP1MzwZkDLbXOWeAf5YNDKnvfa8IMad Ip621Or4Wr5tz1dq4x0eYPB+V6J6X21JigHJ8wzF7z8xZ/FApQj2wmgJrruqcGKeF2 eDDetCJFDzIfzXEwD5rXb0gelP1DOk8EdfxLaRbh8SJFI+NVG+jlQ1jTY4tS1zjr20 94sIEBf7+LHLbPPE9vCzhVJGVTNBsBFNM8qEgf9BTErwXlmRYR9YXtGefdS64F49Lr bT6kwVWlLOFSA== To: bug-gnu-emacs@gnu.org Subject: 30.0.50; dockerfile-ts-mode imenu issue Date: Sun, 11 Dec 2022 22:39:40 +0200 Message-ID: MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=107.175.124.16; envelope-from=me@eshelyaron.com; helo=eshelyaron.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Sun, 11 Dec 2022 18:00:37 -0500 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) I stumbled upon the following issue while checking out the new dockerfile-ts-mode. 1. emacs -Q 2. C-x C-f /tmp/Dockerfile 3. Insert the following contents (taken from https://docs.docker.com/build/building/multi-stage/#use-a-previous-stage-as-a-new-stage): FROM ubuntu AS base RUN echo "base" FROM base AS stage1 RUN echo "stage1" FROM base AS stage2 RUN echo "stage2" 4. Try to use M-x imenu to navigate to the last build stage 4.a. We get the following imenu--index-alist: (("Stage" ("ubuntu" . #) ("base" . #) ("base" . #))) 4.b. Consequently, we can't choose and jump to the last stage, because dockerfile-ts-mode calls both of the last two stages by the same name ("base"). The crux of the issue is that dockerfile-ts-mode uses a stage's base image as its name, which seems kinda wrong and leads to ambiguity since many stages can have a common base image. Instead, it would be preferable IMO to use the index of the stage or, when available, its unique name (such as "stage1" in the example above). Thanks! In GNU Emacs 30.0.50 (build 9, x86_64-apple-darwin22.1.0, NS appkit-2299.00 Version 13.0 (Build 22A380)) of 2022-12-11 built on esmac.lan Repository revision: 85108d541217f0333860c4f86c3b16b4349f85a4 Repository branch: master Windowing system distributor 'Apple', version 10.3.2299 System Description: macOS 13.0 Configured using: 'configure --with-native-compilation --enable-link-time-optimization --with-json --with-xwidgets --with-mailutils --with-imagemagick --without-dbus' Configured features: ACL GIF GLIB GMP GNUTLS IMAGEMAGICK JPEG JSON LCMS2 LIBXML2 MODULES NATIVE_COMP NOTIFY KQUEUE NS PDUMPER PNG RSVG SQLITE3 THREADS TIFF TOOLKIT_SCROLL_BARS TREE_SITTER WEBP XIM XWIDGETS ZLIB Important settings: value of $LC_CTYPE: UTF-8 locale-coding-system: utf-8-unix Major mode: Dockerfile Minor modes in effect: tooltip-mode: t global-eldoc-mode: t show-paren-mode: t electric-indent-mode: t mouse-wheel-mode: t tool-bar-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t line-number-mode: t indent-tabs-mode: t transient-mark-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t Load-path shadows: None found. Features: (shadow sort mail-extr emacsbug message mailcap yank-media puny dired dired-loaddefs rfc822 mml mml-sec password-cache epa derived epg rfc6068 epg-config gnus-util text-property-search time-date mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader sendmail rfc2047 rfc2045 ietf-drums mm-util mail-prsvr mail-utils pp cl-print byte-opt help-fns radix-tree thingatpt imenu comp comp-cstr warnings icons subr-x rx cl-macs gv cl-extra help-mode bytecomp byte-compile dockerfile-ts-mode treesit cl-seq cl-loaddefs cl-lib rmc iso-transl tooltip cconv eldoc paren electric uniquify ediff-hook vc-hooks lisp-float-type elisp-mode mwheel term/ns-win ns-win ucs-normalize mule-util term/common-win tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow isearch easymenu timer select scroll-bar mouse jit-lock font-lock syntax font-core term/tty-colors frame minibuffer nadvice seq simple cl-generic indonesian philippine cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite emoji-zwj charscript charprop case-table epa-hook jka-cmpr-hook help abbrev obarray oclosure cl-preloaded button loaddefs theme-loaddefs faces cus-face macroexp files window text-properties overlay sha1 md5 base64 format env code-pages mule custom widget keymap hashtable-print-readable backquote threads xwidget-internal kqueue cocoa ns lcms2 multi-tty make-network-process native-compile emacs) Memory information: ((conses 16 111634 8544) (symbols 48 7501 0) (strings 32 31342 3006) (string-bytes 1 961129) (vectors 16 23207) (vector-slots 8 403727 9539) (floats 8 60 40) (intervals 56 396 0) (buffers 984 14)) ------------=_1670892122-3059-1--