From debbugs-submit-bounces@debbugs.gnu.org Sun Dec 11 15:27:40 2022 Received: (at submit) by debbugs.gnu.org; 11 Dec 2022 20:27:40 +0000 Received: from localhost ([127.0.0.1]:48068 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p4SvD-0002i6-7h for submit@debbugs.gnu.org; Sun, 11 Dec 2022 15:27:40 -0500 Received: from lists.gnu.org ([209.51.188.17]:45604) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p4SvA-0002hz-Ry for submit@debbugs.gnu.org; Sun, 11 Dec 2022 15:27:38 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p4SvA-0006TZ-H7 for bug-gnu-emacs@gnu.org; Sun, 11 Dec 2022 15:27:36 -0500 Received: from wout3-smtp.messagingengine.com ([64.147.123.19]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p4Sv5-0007gb-S2; Sun, 11 Dec 2022 15:27:35 -0500 Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.west.internal (Postfix) with ESMTP id 8115432003F4; Sun, 11 Dec 2022 15:27:28 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Sun, 11 Dec 2022 15:27:28 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= secure.kjonigsen.net; h=cc:cc:content-type:date:date:from:from :in-reply-to:message-id:mime-version:reply-to:reply-to:sender :subject:subject:to:to; s=fm1; t=1670790448; x=1670876848; bh=CK owZeWahaGA1F6Vwb8U2cIoOsZtf/tOMifhZCNsCew=; b=hiNoPuy0CSBm+S6KhC xjOm4uxHbxLQerj0FJPHFXZLcHal068M/skuSmIiEfO6mVqW1FphBieSHmW/dXr3 0M/HwIG/dr65yc6qOgVPSAlEpmDF8zBdi7xYptc2CTqHEOe1UP0bDcnMwGx517xE oqeCGujgi36eomLLTcQ4qBndrxq4S6Tr8kVEX4TbihIKod5mWae+ivZ8MdIRpotV CvWQDcWBDSBgvVrr8UnfFRmsYFBLcXVREA7kjkW6Phowxs2u1J5v7t8+UKRZ0NWj DAsH3awDjwkyMopNIMPHkkN0uj9oEfylyNcI3wYaU+KtXqKKSqRkhLdhATocNdQP t/Qw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:message-id:mime-version :reply-to:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t= 1670790448; x=1670876848; bh=CKowZeWahaGA1F6Vwb8U2cIoOsZtf/tOMif hZCNsCew=; b=IzJ4B5L0HTsYC9Q4mOnKt+IKM60g/63CH945lrLZnw4HCxXJH+O enPB5mIhKEFDmKSav4gNOzdJoFCvW5D/MZi604NLVI3W65+STu9+CklLKvarFG8g ES6m3Lh8SSPs7Jt22BFOBU3QkzQPYth3sfNlISN678onAfP5fCpH9cjxQTGqXEFn a7ZPYPPRkMb3cnoXy74R5CqNa8rulb/f/UjfRqTFI5BozOSNSBOza//ROq6DOMnv wsSeeP7pZiFZYNl+BCMnpaXidcrJQtNgI5V76K7gXsACQQ5knKn5N20hKnkm85CL 3v844U7cXHZbgQ1PgcFk+erz1JVIUZTxGLg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrvdeigddufeekucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurheptgfkffggfghrvfevhffusehmtderredtfeejnecuhfhrohhmpeflohhsthgv ihhnucfmjhppnhhighhsvghnuceojhhoshhtvghinhesshgvtghurhgvrdhkjhhonhhigh hsvghnrdhnvghtqeenucggtffrrghtthgvrhhnpedufffggfffgfevtdehvefhffevleeg jeeggeevieekkeekudfgtefgteffteehfeenucffohhmrghinhepkhhjnhhighhsvghnrd hnohenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehj ohhsthgvihhnsehsvggtuhhrvgdrkhhjohhnihhgshgvnhdrnhgvth X-ME-Proxy: Feedback-ID: ib2f84088:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun, 11 Dec 2022 15:27:27 -0500 (EST) Content-Type: multipart/mixed; boundary="------------iAGiZPJyoiBh1xDVRpZ2Oo6R" Message-ID: Date: Sun, 11 Dec 2022 21:27:26 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.1 Content-Language: nb-NO To: "bug-gnu-emacs@gnu.org" From: =?UTF-8?Q?Jostein_Kj=c3=b8nigsen?= Subject: 29.0.60; python-ts-mode does not fontify function-invocations using font-lock-function-name [PATCH] Received-SPF: pass client-ip=64.147.123.19; envelope-from=jostein@secure.kjonigsen.net; helo=wout3-smtp.messagingengine.com X-Spam_score_int: -26 X-Spam_score: -2.7 X-Spam_bar: -- X-Spam_report: (-2.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.6 (-) X-Debbugs-Envelope-To: submit Cc: =?UTF-8?Q?Fabi=c3=a1n_E=2e_Gallina?= , Yuan Fu X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: jostein@kjonigsen.net Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.6 (--) This is a multi-part message in MIME format. --------------iAGiZPJyoiBh1xDVRpZ2Oo6R Content-Type: multipart/alternative; boundary="------------equxT040k8tf9iAaJx5mku01" --------------equxT040k8tf9iAaJx5mku01 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Open a python buffer, activate python-ts-mode and write a simple statement invoking a function. Example code: def somefunc(val)     return val result = someFunc("123"); Observe how function-name is fontified as function name in the function definition, but not when invoked. This is inconsistent with how other major-modes fontify function names. Attached is a patch which fixes this issue. -- In GNU Emacs 29.0.60 (build 1, x86_64-pc-linux-gnu, GTK+ Version  3.24.34, cairo version 1.16.0) of 2022-12-09 built on ThinkPad-T14s Repository revision: 37f3038d791c1e52b92fbbaf8221092ae8a2f284 Repository branch: emacs-29 Windowing system distributor 'The X.Org Foundation', version 11.0.12201003 System Description: Ubuntu 22.10 Configured using:  'configure --with-json --with-tree-sitter' Configured features: ACL CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GPM GSETTINGS HARFBUZZ JPEG JSON LCMS2 LIBOTF LIBSELINUX LIBSYSTEMD LIBXML2 M17N_FLT MODULES NOTIFY INOTIFY PDUMPER PNG RSVG SECCOMP SOUND THREADS TIFF TOOLKIT_SCROLL_BARS TREE_SITTER X11 XDBE XIM XINPUT2 XPM GTK3 ZLIB Important settings:   value of $LC_MONETARY: nb_NO.UTF-8   value of $LC_NUMERIC: nb_NO.UTF-8   value of $LC_TIME: nb_NO.UTF-8   value of $LANG: en_US.UTF-8   locale-coding-system: utf-8-unix Major mode: Magit Minor modes in effect:   global-git-commit-mode: t   magit-auto-revert-mode: t   treemacs-filewatch-mode: t   treemacs-follow-mode: t   treemacs-git-mode: t   treemacs-fringe-indicator-mode: t   editorconfig-mode: t   which-function-mode: t   helm-mode: t   helm-minibuffer-history-mode: t   shell-dirtrack-mode: t   helm--remap-mouse-mode: t   async-bytecomp-package-mode: t   delete-selection-mode: t   global-auto-revert-mode: t   yas-global-mode: t   yas-minor-mode: t   global-nlinum-mode: t   ido-yes-or-no-mode: t   override-global-mode: t   server-mode: t   global-hl-line-mode: t   pixel-scroll-precision-mode: t   doom-modeline-mode: t   tooltip-mode: t   global-eldoc-mode: t   show-paren-mode: t   electric-indent-mode: t   mouse-wheel-mode: t   menu-bar-mode: t   file-name-shadow-mode: t   global-font-lock-mode: t   font-lock-mode: t   blink-cursor-mode: t   buffer-read-only: t   column-number-mode: t   line-number-mode: t   transient-mark-mode: t   auto-composition-mode: t   auto-encryption-mode: t   auto-compression-mode: t Load-path shadows: /home/jostein/.emacs.d/elpa/transient-20221202.1727/transient hides /home/jostein/build/emacs/lisp/transient Features: (shadow sort emacsbug mail-extr misearch multi-isearch lsp-diagnostics lsp-headerline lsp-icons lsp-modeline dap-mouse dap-ui gdb-mi bindat gud bui bui-list bui-info bui-entry bui-core bui-history bui-button bui-utils lsp-lens dap-gdb-lldb dap-netcore dap-node dap-utils dap-pwsh dap-python dap-mode dap-tasks dap-launch posframe dap-overlays view python skeleton helm-bookmark helm-net helm-adaptive magit-bookmark treemacs-bookmarks treemacs-tags bookmark help-fns radix-tree apropos goto-addr helm-command helm-elisp helm-eval edebug debug backtrace helm-info git-rebase magit-extras flyspell ispell face-remap magit-submodule magit-obsolete magit-blame magit-stash magit-reflog magit-bisect magit-push magit-pull magit-fetch magit-clone magit-remote magit-commit magit-sequence magit-notes magit-worktree magit-tag magit-merge magit-branch magit-reset magit-files magit-refs magit-status magit magit-repos magit-apply magit-wip magit-log magit-diff smerge-mode diff git-commit log-edit message sendmail yank-media rfc822 mml mml-sec epa mm-decode mm-bodies mm-encode mail-parse rfc2231 rfc2047 rfc2045 ietf-drums mailabbrev gmm-utils mailheader pcvs-util magit-core magit-autorevert magit-margin magit-transient magit-process with-editor magit-mode transient magit-git magit-base magit-section crm compat-27 compat-26 elec-pair toml-ts-mode treesit executable disp-table bug-reference vc-git diff-mode vc-dispatcher vc-svn winner ffap tramp-archive tramp-gvfs zeroconf tramp-cache time-stamp dbus add-log lsp-zig lsp-steep lsp-svelte lsp-sqls lsp-ruby-syntax-tree lsp-yaml lsp-xml lsp-vimscript lsp-vhdl lsp-volar lsp-vetur lsp-html lsp-verilog lsp-vala lsp-v lsp-typeprof lsp-ttcn3 lsp-toml lsp-terraform lsp-tex lsp-sorbet lsp-solargraph lsp-rust lsp-rf lsp-remark lsp-racket lsp-r lsp-purescript lsp-pylsp lsp-pyls lsp-pwsh lsp-php lsp-pls lsp-perlnavigator lsp-perl lsp-openscad lsp-ocaml lsp-magik lsp-nix lsp-nim lsp-nginx lsp-mint lsp-marksman lsp-markdown lsp-lua lsp-kotlin lsp-json lsp-javascript lsp-idris lsp-haxe lsp-groovy lsp-hack lsp-graphql lsp-gleam lsp-go lsp-completion lsp-gdscript lsp-fsharp lsp-fortran lsp-eslint lsp-erlang lsp-emmet lsp-elixir lsp-elm lsp-dockerfile lsp-docker yaml lsp-dhall lsp-d lsp-css lsp-csharp gnutls lsp-crystal lsp-cmake lsp-clojure lsp-treemacs lsp-treemacs-generic lsp-treemacs-themes treemacs-treelib treemacs treemacs-header-line treemacs-compatibility treemacs-mode treemacs-interface treemacs-persistence treemacs-filewatch-mode treemacs-follow-mode treemacs-rendering treemacs-annotations treemacs-async treemacs-workspaces treemacs-dom treemacs-visuals treemacs-fringe-indicator treemacs-scope pulse treemacs-faces treemacs-icons treemacs-themes treemacs-core-utils pfuture treemacs-logging treemacs-customization treemacs-macros lsp-semantic-tokens lsp-clangd lsp-beancount lsp-bash lsp-astro lsp-ansible lsp-angular lsp-ada warnings lsp-actionscript ido-completing-read+ memoize minibuf-eldef elisp-slime-nav paredit lsp-mode lsp-protocol tree-widget spinner network-stream nsm markdown-mode color lv inline ht ewoc epg rfc6068 epg-config highlight-symbol flycheck editorconfig editorconfig-core editorconfig-core-handle editorconfig-fnmatch company-oddmuse company-keywords company-etags etags fileloop generator company-gtags company-dabbrev-code company-dabbrev company-files company-clang company-capf company-cmake company-semantic company-template company-bbdb company which-func hideshow eww url-queue thingatpt shr pixel-fill kinsoku url-file svg xml dom puny mm-url gnus nnheader gnus-util mail-utils range mm-util mail-prsvr helm-imenu pcase imenu ob-plantuml org ob ob-tangle ob-ref ob-lob ob-table ob-exp org-macro org-src ob-comint org-pcomplete org-list org-footnote org-faces org-entities noutline outline ob-emacs-lisp ob-core ob-eval org-cycle org-table ol org-fold org-fold-core org-keys oc org-loaddefs find-func cal-menu calendar cal-loaddefs org-version org-compat org-macs helm-mode helm-misc helm-files image-dired image-dired-tags image-dired-external image-dired-util xdg image-mode dired dired-loaddefs exif tramp tramp-loaddefs trampver tramp-integration cus-edit pp cus-load icons wid-edit files-x tramp-compat shell pcomplete parse-time iso8601 time-date ls-lisp helm-buffers helm-occur helm-tags helm-locate helm-grep helm-regexp format-spec helm-utils helm-help helm-types helm helm-global-bindings helm-easymenu helm-core async-bytecomp helm-source helm-multi-match helm-lib async helm-config delsel autorevert filenotify yasnippet derived nlinum linum ido-yes-or-no advice ido edmacro kmacro use-package-bind-key bind-key easy-mmode xref project server hl-line pixel-scroll cua-base compile-eslint compile comint ansi-osc ansi-color ring doom-modeline doom-modeline-segments doom-modeline-env doom-modeline-core all-the-icons all-the-icons-faces data-material data-weathericons data-octicons data-fileicons data-faicons data-alltheicons shrink-path rx f f-shortdoc shortdoc text-property-search s dash compat compat-macs dracula-theme cl-extra help-mode use-package-ensure use-package-core finder-inf flycheck-autoloads helm-autoloads helm-core-autoloads expand-region-autoloads all-the-icons-autoloads bmx-mode-autoloads doom-modeline-autoloads async-autoloads dracula-theme-autoloads highlight-symbol-autoloads multiple-cursors-autoloads nlinum-autoloads toml-mode-autoloads pkg-info-autoloads epl-autoloads undo-tree-autoloads rust-mode-autoloads editorconfig-autoloads magit-autoloads yasnippet-autoloads elisp-slime-nav-autoloads crontab-mode-autoloads ido-yes-or-no-autoloads magit-section-autoloads cargo-autoloads ido-completing-read+-autoloads memoize-autoloads paredit-autoloads company-autoloads yaml-mode-autoloads powershell-autoloads dap-mode-autoloads lsp-docker-autoloads yaml-autoloads lsp-treemacs-autoloads treemacs-autoloads cfrs-autoloads posframe-autoloads hydra-autoloads pfuture-autoloads ace-window-autoloads avy-autoloads bui-autoloads lsp-mode-autoloads lv-autoloads markdown-mode-autoloads spinner-autoloads ht-autoloads git-commit-autoloads transient-autoloads compat-autoloads cmake-mode-autoloads shrink-path-autoloads f-autoloads info dash-autoloads s-autoloads popup-autoloads queue-autoloads package browse-url url url-proxy url-privacy url-expand url-methods url-history url-cookie generate-lisp-file url-domsuf url-util mailcap url-handlers url-parse auth-source cl-seq eieio eieio-core cl-macs password-cache json subr-x map byte-opt gv bytecomp byte-compile url-vars cl-loaddefs cl-lib rmc iso-transl tooltip cconv eldoc paren electric uniquify ediff-hook vc-hooks lisp-float-type elisp-mode mwheel term/x-win x-win term/common-win x-dnd tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow isearch easymenu timer select scroll-bar mouse jit-lock font-lock syntax font-core term/tty-colors frame minibuffer nadvice seq simple cl-generic indonesian philippine cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite emoji-zwj charscript charprop case-table epa-hook jka-cmpr-hook help abbrev obarray oclosure cl-preloaded button loaddefs theme-loaddefs faces cus-face macroexp files window text-properties overlay sha1 md5 base64 format env code-pages mule custom widget keymap hashtable-print-readable backquote threads dbusbind inotify lcms2 dynamic-setting system-font-setting font-render-setting cairo move-toolbar gtk x-toolkit xinput2 x multi-tty make-network-process emacs) Memory information: ((conses 16 817351 95196)  (symbols 48 56343 1)  (strings 32 240462 14017)  (string-bytes 1 6962558)  (vectors 16 116127)  (vector-slots 8 2199610 186656)  (floats 8 1040 698)  (intervals 56 9967 4449)  (buffers 992 53)) -- Vennlig hilsen *Jostein Kjønigsen* jostein@kjonigsen.net 🍵 jostein@gmail.com https://jostein.kjønigsen.no --------------equxT040k8tf9iAaJx5mku01 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 8bit

Open a python buffer, activate python-ts-mode and write a simple statement invoking a function. Example code:

def somefunc(val)
    return val

result = someFunc("123");

Observe how function-name is fontified as function name in the function definition, but not when invoked.

This is inconsistent with how other major-modes fontify function names.

Attached is a patch which fixes this issue.

--


In GNU Emacs 29.0.60 (build 1, x86_64-pc-linux-gnu, GTK+ Version
 3.24.34, cairo version 1.16.0) of 2022-12-09 built on ThinkPad-T14s
Repository revision: 37f3038d791c1e52b92fbbaf8221092ae8a2f284
Repository branch: emacs-29
Windowing system distributor 'The X.Org Foundation', version 11.0.12201003
System Description: Ubuntu 22.10

Configured using:
 'configure --with-json --with-tree-sitter'

Configured features:
ACL CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GPM GSETTINGS HARFBUZZ JPEG
JSON LCMS2 LIBOTF LIBSELINUX LIBSYSTEMD LIBXML2 M17N_FLT MODULES NOTIFY
INOTIFY PDUMPER PNG RSVG SECCOMP SOUND THREADS TIFF TOOLKIT_SCROLL_BARS
TREE_SITTER X11 XDBE XIM XINPUT2 XPM GTK3 ZLIB

Important settings:
  value of $LC_MONETARY: nb_NO.UTF-8
  value of $LC_NUMERIC: nb_NO.UTF-8
  value of $LC_TIME: nb_NO.UTF-8
  value of $LANG: en_US.UTF-8
  locale-coding-system: utf-8-unix

Major mode: Magit

Minor modes in effect:
  global-git-commit-mode: t
  magit-auto-revert-mode: t
  treemacs-filewatch-mode: t
  treemacs-follow-mode: t
  treemacs-git-mode: t
  treemacs-fringe-indicator-mode: t
  editorconfig-mode: t
  which-function-mode: t
  helm-mode: t
  helm-minibuffer-history-mode: t
  shell-dirtrack-mode: t
  helm--remap-mouse-mode: t
  async-bytecomp-package-mode: t
  delete-selection-mode: t
  global-auto-revert-mode: t
  yas-global-mode: t
  yas-minor-mode: t
  global-nlinum-mode: t
  ido-yes-or-no-mode: t
  override-global-mode: t
  server-mode: t
  global-hl-line-mode: t
  pixel-scroll-precision-mode: t
  doom-modeline-mode: t
  tooltip-mode: t
  global-eldoc-mode: t
  show-paren-mode: t
  electric-indent-mode: t
  mouse-wheel-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  buffer-read-only: t
  column-number-mode: t
  line-number-mode: t
  transient-mark-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t

Load-path shadows:
/home/jostein/.emacs.d/elpa/transient-20221202.1727/transient hides /home/jostein/build/emacs/lisp/transient

Features:
(shadow sort emacsbug mail-extr misearch multi-isearch lsp-diagnostics
lsp-headerline lsp-icons lsp-modeline dap-mouse dap-ui gdb-mi bindat gud
bui bui-list bui-info bui-entry bui-core bui-history bui-button
bui-utils lsp-lens dap-gdb-lldb dap-netcore dap-node dap-utils dap-pwsh
dap-python dap-mode dap-tasks dap-launch posframe dap-overlays view
python skeleton helm-bookmark helm-net helm-adaptive magit-bookmark
treemacs-bookmarks treemacs-tags bookmark help-fns radix-tree apropos
goto-addr helm-command helm-elisp helm-eval edebug debug backtrace
helm-info git-rebase magit-extras flyspell ispell face-remap
magit-submodule magit-obsolete magit-blame magit-stash magit-reflog
magit-bisect magit-push magit-pull magit-fetch magit-clone magit-remote
magit-commit magit-sequence magit-notes magit-worktree magit-tag
magit-merge magit-branch magit-reset magit-files magit-refs magit-status
magit magit-repos magit-apply magit-wip magit-log magit-diff smerge-mode
diff git-commit log-edit message sendmail yank-media rfc822 mml mml-sec
epa mm-decode mm-bodies mm-encode mail-parse rfc2231 rfc2047 rfc2045
ietf-drums mailabbrev gmm-utils mailheader pcvs-util magit-core
magit-autorevert magit-margin magit-transient magit-process with-editor
magit-mode transient magit-git magit-base magit-section crm compat-27
compat-26 elec-pair toml-ts-mode treesit executable disp-table
bug-reference vc-git diff-mode vc-dispatcher vc-svn winner ffap
tramp-archive tramp-gvfs zeroconf tramp-cache time-stamp dbus add-log
lsp-zig lsp-steep lsp-svelte lsp-sqls lsp-ruby-syntax-tree lsp-yaml
lsp-xml lsp-vimscript lsp-vhdl lsp-volar lsp-vetur lsp-html lsp-verilog
lsp-vala lsp-v lsp-typeprof lsp-ttcn3 lsp-toml lsp-terraform lsp-tex
lsp-sorbet lsp-solargraph lsp-rust lsp-rf lsp-remark lsp-racket lsp-r
lsp-purescript lsp-pylsp lsp-pyls lsp-pwsh lsp-php lsp-pls
lsp-perlnavigator lsp-perl lsp-openscad lsp-ocaml lsp-magik lsp-nix
lsp-nim lsp-nginx lsp-mint lsp-marksman lsp-markdown lsp-lua lsp-kotlin
lsp-json lsp-javascript lsp-idris lsp-haxe lsp-groovy lsp-hack
lsp-graphql lsp-gleam lsp-go lsp-completion lsp-gdscript lsp-fsharp
lsp-fortran lsp-eslint lsp-erlang lsp-emmet lsp-elixir lsp-elm
lsp-dockerfile lsp-docker yaml lsp-dhall lsp-d lsp-css lsp-csharp gnutls
lsp-crystal lsp-cmake lsp-clojure lsp-treemacs lsp-treemacs-generic
lsp-treemacs-themes treemacs-treelib treemacs treemacs-header-line
treemacs-compatibility treemacs-mode treemacs-interface
treemacs-persistence treemacs-filewatch-mode treemacs-follow-mode
treemacs-rendering treemacs-annotations treemacs-async
treemacs-workspaces treemacs-dom treemacs-visuals
treemacs-fringe-indicator treemacs-scope pulse treemacs-faces
treemacs-icons treemacs-themes treemacs-core-utils pfuture
treemacs-logging treemacs-customization treemacs-macros
lsp-semantic-tokens lsp-clangd lsp-beancount lsp-bash lsp-astro
lsp-ansible lsp-angular lsp-ada warnings lsp-actionscript
ido-completing-read+ memoize minibuf-eldef elisp-slime-nav paredit
lsp-mode lsp-protocol tree-widget spinner network-stream nsm
markdown-mode color lv inline ht ewoc epg rfc6068 epg-config
highlight-symbol flycheck editorconfig editorconfig-core
editorconfig-core-handle editorconfig-fnmatch company-oddmuse
company-keywords company-etags etags fileloop generator company-gtags
company-dabbrev-code company-dabbrev company-files company-clang
company-capf company-cmake company-semantic company-template
company-bbdb company which-func hideshow eww url-queue thingatpt shr
pixel-fill kinsoku url-file svg xml dom puny mm-url gnus nnheader
gnus-util mail-utils range mm-util mail-prsvr helm-imenu pcase imenu
ob-plantuml org ob ob-tangle ob-ref ob-lob ob-table ob-exp org-macro
org-src ob-comint org-pcomplete org-list org-footnote org-faces
org-entities noutline outline ob-emacs-lisp ob-core ob-eval org-cycle
org-table ol org-fold org-fold-core org-keys oc org-loaddefs find-func
cal-menu calendar cal-loaddefs org-version org-compat org-macs helm-mode
helm-misc helm-files image-dired image-dired-tags image-dired-external
image-dired-util xdg image-mode dired dired-loaddefs exif tramp
tramp-loaddefs trampver tramp-integration cus-edit pp cus-load icons
wid-edit files-x tramp-compat shell pcomplete parse-time iso8601
time-date ls-lisp helm-buffers helm-occur helm-tags helm-locate
helm-grep helm-regexp format-spec helm-utils helm-help helm-types helm
helm-global-bindings helm-easymenu helm-core async-bytecomp helm-source
helm-multi-match helm-lib async helm-config delsel autorevert filenotify
yasnippet derived nlinum linum ido-yes-or-no advice ido edmacro kmacro
use-package-bind-key bind-key easy-mmode xref project server hl-line
pixel-scroll cua-base compile-eslint compile comint ansi-osc ansi-color
ring doom-modeline doom-modeline-segments doom-modeline-env
doom-modeline-core all-the-icons all-the-icons-faces data-material
data-weathericons data-octicons data-fileicons data-faicons
data-alltheicons shrink-path rx f f-shortdoc shortdoc
text-property-search s dash compat compat-macs dracula-theme cl-extra
help-mode use-package-ensure use-package-core finder-inf
flycheck-autoloads helm-autoloads helm-core-autoloads
expand-region-autoloads all-the-icons-autoloads bmx-mode-autoloads
doom-modeline-autoloads async-autoloads dracula-theme-autoloads
highlight-symbol-autoloads multiple-cursors-autoloads nlinum-autoloads
toml-mode-autoloads pkg-info-autoloads epl-autoloads undo-tree-autoloads
rust-mode-autoloads editorconfig-autoloads magit-autoloads
yasnippet-autoloads elisp-slime-nav-autoloads crontab-mode-autoloads
ido-yes-or-no-autoloads magit-section-autoloads cargo-autoloads
ido-completing-read+-autoloads memoize-autoloads paredit-autoloads
company-autoloads yaml-mode-autoloads powershell-autoloads
dap-mode-autoloads lsp-docker-autoloads yaml-autoloads
lsp-treemacs-autoloads treemacs-autoloads cfrs-autoloads
posframe-autoloads hydra-autoloads pfuture-autoloads
ace-window-autoloads avy-autoloads bui-autoloads lsp-mode-autoloads
lv-autoloads markdown-mode-autoloads spinner-autoloads ht-autoloads
git-commit-autoloads transient-autoloads compat-autoloads
cmake-mode-autoloads shrink-path-autoloads f-autoloads info
dash-autoloads s-autoloads popup-autoloads queue-autoloads package
browse-url url url-proxy url-privacy url-expand url-methods url-history
url-cookie generate-lisp-file url-domsuf url-util mailcap url-handlers
url-parse auth-source cl-seq eieio eieio-core cl-macs password-cache
json subr-x map byte-opt gv bytecomp byte-compile url-vars cl-loaddefs
cl-lib rmc iso-transl tooltip cconv eldoc paren electric uniquify
ediff-hook vc-hooks lisp-float-type elisp-mode mwheel term/x-win x-win
term/common-win x-dnd tool-bar dnd fontset image regexp-opt fringe
tabulated-list replace newcomment text-mode lisp-mode prog-mode register
page tab-bar menu-bar rfn-eshadow isearch easymenu timer select
scroll-bar mouse jit-lock font-lock syntax font-core term/tty-colors
frame minibuffer nadvice seq simple cl-generic indonesian philippine
cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao
korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech
european ethiopic indian cyrillic chinese composite emoji-zwj charscript
charprop case-table epa-hook jka-cmpr-hook help abbrev obarray oclosure
cl-preloaded button loaddefs theme-loaddefs faces cus-face macroexp
files window text-properties overlay sha1 md5 base64 format env
code-pages mule custom widget keymap hashtable-print-readable backquote
threads dbusbind inotify lcms2 dynamic-setting system-font-setting
font-render-setting cairo move-toolbar gtk x-toolkit xinput2 x multi-tty
make-network-process emacs)

Memory information:
((conses 16 817351 95196)
 (symbols 48 56343 1)
 (strings 32 240462 14017)
 (string-bytes 1 6962558)
 (vectors 16 116127)
 (vector-slots 8 2199610 186656)
 (floats 8 1040 698)
 (intervals 56 9967 4449)
 (buffers 992 53))
--
Vennlig hilsen
 Jostein Kjønigsen
jostein@kjonigsen.net 🍵 jostein@gmail.com
 https://jostein.kjønigsen.no
--------------equxT040k8tf9iAaJx5mku01-- --------------iAGiZPJyoiBh1xDVRpZ2Oo6R Content-Type: text/x-patch; charset=UTF-8; name="0004-python-ts-mode-fontify-function-invocations-using-fo.patch" Content-Disposition: attachment; filename*0="0004-python-ts-mode-fontify-function-invocations-using-fo.pa"; filename*1="tch" Content-Transfer-Encoding: base64 RnJvbSBhNmUxZjYxMWM2MWQyZjhhOGViZjY2M2ExOTk4MmNkMjUxNTJjZjRhIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiA9P1VURi04P3E/Sm9zdGVpbj0yMEtqPUMzPUI4bmln c2VuPz0gPGpvc3RlaW5Aa2pvbmlnc2VuLm5ldD4KRGF0ZTogU3VuLCAxMSBEZWMgMjAyMiAy MToyMDoyNyArMDEwMApTdWJqZWN0OiBbUEFUQ0ggNC80XSBweXRob24tdHMtbW9kZTogZm9u dGlmeSBmdW5jdGlvbi1pbnZvY2F0aW9ucyB1c2luZwogZm9udC1sb2NrLWZ1bmN0aW9uLW5h bWUuCgpUaGlzIGlzIGNvbnNpc3RlbnQgd2l0aCBob3cgbWFueSBvdGhlciB0cmVlLXNpdHRl ciBiYXNlZCBtYWpvci1tb2Rlcwpkb2VzIGl0LCBhbmQgd291bGQgaW1wcm92ZSBjb25zaXN0 ZW5jeSBmb3IgZm9udGlmaWNhdGlvbiBpbiBFbWFjcy4KLS0tCiBsaXNwL3Byb2dtb2Rlcy9w eXRob24uZWwgfCA3ICsrKysrLS0KIDEgZmlsZSBjaGFuZ2VkLCA1IGluc2VydGlvbnMoKyks IDIgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvbGlzcC9wcm9nbW9kZXMvcHl0aG9uLmVs IGIvbGlzcC9wcm9nbW9kZXMvcHl0aG9uLmVsCmluZGV4IGViZWU3MDM0OTlhLi5mODZmYzRi YmVhYyAxMDA2NDQKLS0tIGEvbGlzcC9wcm9nbW9kZXMvcHl0aG9uLmVsCisrKyBiL2xpc3Av cHJvZ21vZGVzL3B5dGhvbi5lbApAQCAtMTA4OSwxMCArMTA4OSwxNCBAQCBweXRob24tLXRy ZWVzaXQtc2V0dGluZ3MKIAogICAgOmZlYXR1cmUgJ2RlZmluaXRpb24KICAgIDpsYW5ndWFn ZSAncHl0aG9uCisgICA6b3ZlcnJpZGUgdAogICAgJygoZnVuY3Rpb25fZGVmaW5pdGlvbgog ICAgICAgbmFtZTogKGlkZW50aWZpZXIpIEBmb250LWxvY2stZnVuY3Rpb24tbmFtZS1mYWNl KQogICAgICAoY2xhc3NfZGVmaW5pdGlvbgotICAgICAgbmFtZTogKGlkZW50aWZpZXIpIEBm b250LWxvY2stdHlwZS1mYWNlKSkKKyAgICAgIG5hbWU6IChpZGVudGlmaWVyKSBAZm9udC1s b2NrLXR5cGUtZmFjZSkKKyAgICAgKGNhbGwgZnVuY3Rpb246IChpZGVudGlmaWVyKSBAZm9u dC1sb2NrLWZ1bmN0aW9uLW5hbWUtZmFjZSkKKyAgICAgKGNhbGwgZnVuY3Rpb246IChhdHRy aWJ1dGUKKyAgICAgICAgICAgICAgICAgICAgICBhdHRyaWJ1dGU6IChpZGVudGlmaWVyKSBA Zm9udC1sb2NrLWZ1bmN0aW9uLW5hbWUtZmFjZSkpKQogCiAgICA6ZmVhdHVyZSAna2V5d29y ZAogICAgOmxhbmd1YWdlICdweXRob24KQEAgLTExNTgsNyArMTE2Miw2IEBAIHB5dGhvbi0t dHJlZXNpdC1zZXR0aW5ncwogCiAgICA6ZmVhdHVyZSAncHJvcGVydHkKICAgIDpsYW5ndWFn ZSAncHl0aG9uCi0gICA6b3ZlcnJpZGUgdAogICAgJygoYXR0cmlidXRlCiAgICAgICBhdHRy aWJ1dGU6IChpZGVudGlmaWVyKSBAZm9udC1sb2NrLXByb3BlcnR5LWZhY2UpCiAgICAgIChj bGFzc19kZWZpbml0aW9uCi0tIAoyLjM3LjIKCg== --------------iAGiZPJyoiBh1xDVRpZ2Oo6R-- From debbugs-submit-bounces@debbugs.gnu.org Mon Dec 12 17:54:42 2022 Received: (at 59977) by debbugs.gnu.org; 12 Dec 2022 22:54:42 +0000 Received: from localhost ([127.0.0.1]:55990 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p4rh3-0005RJ-QL for submit@debbugs.gnu.org; Mon, 12 Dec 2022 17:54:42 -0500 Received: from mail-pl1-f182.google.com ([209.85.214.182]:42504) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p4rh2-0005R8-NI for 59977@debbugs.gnu.org; Mon, 12 Dec 2022 17:54:41 -0500 Received: by mail-pl1-f182.google.com with SMTP id d7so13644859pll.9 for <59977@debbugs.gnu.org>; Mon, 12 Dec 2022 14:54:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:cc:date:message-id:subject:mime-version :content-transfer-encoding:from:from:to:cc:subject:date:message-id :reply-to; bh=uKNpVq873066Q43ExHZyApx4EJT3h3wfyzSlZbtdhqY=; b=Jn4nxOegLhm4DgRAov9ZlAAHBSbbwBFJOV8ClFXR5SJ7NCvTxdh4jEdPZt+tp+V2J3 EkWlpAdtIFh34joE4krZNnylGlt15yK3R992fJ9pI/9SEPqHfbBy1i9BjXeI/QvAscTm holKuwDMjy21r9BFr6dWVS5UQiGqIEOih4n+m3+C4TSy9a4zCunnIxz5tbtUYljvp2EN 7XSiuERBXg4pBWa2ZEtxI04RtgXI5Bks+OZkkA9gAoaUNvMwvtZz9QewHCjdt33Uio7E xd2eTkHgBygYB72owTKoh1fTVdDRDNeDXvde4omF5i+FXVgXvGkJC4VvRKHNhmtiaFYH gQ1Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:cc:date:message-id:subject:mime-version :content-transfer-encoding:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=uKNpVq873066Q43ExHZyApx4EJT3h3wfyzSlZbtdhqY=; b=6KzPkPH5G9vopTQVKxKnUWIWSTjmkf6ZIgn6OcmYYL44ygXGlCa7GdD/m0YGfKLkSF /SQxvGhwbaeIo5YnTswcRKMsAyZjq4SRFY6xm5KGEe4tMyhrpopaSkpA2YUDgEq63WcH AZQw+JDVoTH8N5TFN+KwjwsmnrOmeZkIVEVhVqsHIgZTKLL+lN5TyzPvhembcltxJSis yLZsVEDd5/8WGjbUSQPiP5BVUsUfcrMYkQz6pbL5dSfKwDo8pxX9OcKX2qeajEE8m8rV anBpOihhNBaqzwOipCIGqRy846EA2IJcqIQxQNT6l705qVnp0Z9TDGfg9yvxZBSIC8JZ K4Ug== X-Gm-Message-State: ANoB5pmR/daVJIyro2Gxtq8ctVF/IH1QAfRYnejoNFPrqvObSosd7ycu 0iCFh1SIpSUwSY34VbkS4zk= X-Google-Smtp-Source: AA0mqf60h9wnN0P7WEZW3CbcWl3C+O+tG9sDOnnbRVJ6EASnWqqNnF+jt8rN4W81eXuGSqaQs4kZuA== X-Received: by 2002:a17:902:7441:b0:189:80d1:9d19 with SMTP id e1-20020a170902744100b0018980d19d19mr21568644plt.26.1670885674762; Mon, 12 Dec 2022 14:54:34 -0800 (PST) Received: from smtpclient.apple (cpe-172-117-161-177.socal.res.rr.com. [172.117.161.177]) by smtp.gmail.com with ESMTPSA id j16-20020a170902da9000b00189c62eac37sm6935453plx.32.2022.12.12.14.54.33 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 12 Dec 2022 14:54:34 -0800 (PST) From: Yuan Fu Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.1\)) Subject: Re: bug#59977: 29.0.60; python-ts-mode does not fontify function-invocations using font-lock-function-name [PATCH] Message-Id: Date: Mon, 12 Dec 2022 14:54:32 -0800 To: =?utf-8?Q?Jostein_Kj=C3=B8nigsen?= X-Mailer: Apple Mail (2.3696.120.41.1.1) X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 59977 Cc: fgallina@gnu.org, 59977@debbugs.gnu.org, jostein@kjonigsen.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Jostein Kj=C3=B8nigsen writes: > Open a python buffer, activate python-ts-mode and write a simple = statement invoking a function. Example code: > > def somefunc(val) > return val > > result =3D someFunc("123"); > > Observe how function-name is fontified as function name in the = function definition, but not when invoked. > > This is inconsistent with how other major-modes fontify function > names. Ah, yes. That=E2=80=99s because the "definition" feature, which is by = enabled by default, only highlights definition and ignores invocation. OTOH, the "function" feature highlights every instance of a function identifier, but it isn=E2=80=99t enabled by default. Other tree-sitter major modes = doesn=E2=80=99t have "definition" and enable "function" by default, I think. I=E2=80=99m planning to standardize the features in each major mode = according to the list I showed you earlier. It=E2=80=99d be great if you can have a = look at that list and see if you have any opinions, before we decide on the final form of it and start to standardize those features in major modes. (Of course, each language is different, the standard feature list is just a base upon which major modes will extend/modify.) Yuan From debbugs-submit-bounces@debbugs.gnu.org Mon Dec 12 19:48:42 2022 Received: (at control) by debbugs.gnu.org; 13 Dec 2022 00:48:43 +0000 Received: from localhost ([127.0.0.1]:56606 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p4tTO-0000yt-NF for submit@debbugs.gnu.org; Mon, 12 Dec 2022 19:48:42 -0500 Received: from mail-oi1-f180.google.com ([209.85.167.180]:40524) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p4tTN-0000yh-3m for control@debbugs.gnu.org; Mon, 12 Dec 2022 19:48:41 -0500 Received: by mail-oi1-f180.google.com with SMTP id k189so12887507oif.7 for ; Mon, 12 Dec 2022 16:48:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:subject:message-id:date:mime-version:from:from:to:cc:subject :date:message-id:reply-to; bh=xjehOws0/lZPS5+9Fmd4l1nNmlT0hOw57UwoIE9dBWU=; b=YhT3Le0dZ4pLhWAeEY5BAc2Fl/tNnsuOVXBUYytQV1DhjO44FV26wbvLVVjuoIhpOk 6BPAXOhSsLnldhcdrPBIm0ewgC49rQcuNHistesbRxOuJRohv3nsS0pxRl00R18IMV34 e8cHcY7Eya4tlrEIlEJ0ie+w23gvByrsvPsfjfnV0uBOqyJgM7uUoIsvxlLD4g1hNk7n I+iC2CEHMQNR3QfrX7Nrru+v0wkkLnQYN0kJBaszTbwsPNsPyWMSgY5veTzaXvrY0F0+ 8fGLeo1HmgjNx3NmTtvtIR9cx+93ZccMomzcuIwEcz2VLEaiCn4tEoTIY1quGSDQf6N+ tZZg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:subject:message-id:date:mime-version:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=xjehOws0/lZPS5+9Fmd4l1nNmlT0hOw57UwoIE9dBWU=; b=RVnmcS+onYWIdyOIfeUPWkCXfuPruxirXTOMISAC3o1QsK8obvLZY4BD7i+tculujT 8zoVQ0RD6EqTC9nxklCjSRuRnRrJqDI0lS09Wp3YO6HODORxjFZ6SRrC0t8IbsOK5pDv yhgXUURY0SyTrIIvBQlaj331vYxCsaMEJGhWU9Smbk3qbogsH4+Ki8n2qSHyKIeKSAwU xuX5m5vhMpRZUa8T1yvwB7PF8QaxlhVtKjsUv3sBdFbEgmqsSStJWjiPsEM4r9PZaOrf ELVDfv86kfZwJ9841Oggp6Efo5+zcgpaiSepf9oUmMp0lSsehMTiLtziL3ptWaIj2fG4 6bsQ== X-Gm-Message-State: ANoB5plXQ/4sfr7yyVWSvlq3JSL15EDV+LooRQSoQ6JR/LxsoBbUQVr9 1MTKf2DNV27YBjTx9/hKCPkCqqrYfEGSeBovZObn8wdK X-Google-Smtp-Source: AA0mqf7VxzqSsHv0FYYU7iawnzuxfqfarxGha6/Zs6+DyJoOvF5FPPbNGbSE9VxT9b/RKypWOWBhqLsypByCv++nfH4= X-Received: by 2002:a05:6808:493:b0:35e:ac60:2452 with SMTP id z19-20020a056808049300b0035eac602452mr5350oid.92.1670892515639; Mon, 12 Dec 2022 16:48:35 -0800 (PST) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Mon, 12 Dec 2022 16:48:35 -0800 From: Stefan Kangas X-Hashcash: 1:20:221213:control@debbugs.gnu.org::jwqhbkP5adG6dOi/:39xp MIME-Version: 1.0 Date: Mon, 12 Dec 2022 16:48:35 -0800 Message-ID: Subject: control message for bug #59977 To: control@debbugs.gnu.org Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) severity 59977 minor quit From debbugs-submit-bounces@debbugs.gnu.org Thu Dec 15 09:15:57 2022 Received: (at 59977) by debbugs.gnu.org; 15 Dec 2022 14:15:57 +0000 Received: from localhost ([127.0.0.1]:43051 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p5p1h-0006dy-FU for submit@debbugs.gnu.org; Thu, 15 Dec 2022 09:15:57 -0500 Received: from out2-smtp.messagingengine.com ([66.111.4.26]:42383) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p5p1f-0006ds-8n for 59977@debbugs.gnu.org; Thu, 15 Dec 2022 09:15:56 -0500 Received: from compute6.internal (compute6.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id 52BD05C0112; Thu, 15 Dec 2022 09:07:06 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute6.internal (MEProxy); Thu, 15 Dec 2022 09:07:06 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= secure.kjonigsen.net; h=cc:cc:content-transfer-encoding :content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm1; t=1671113226; x=1671199626; bh=1SllV+6xH6 voO3fJTA+3hvOBIyok7EAq3oG9HQUHYl8=; b=N40dfLR1dL+QjoP11BMvs1ggYc FPteH9dpPhDGe/WxwJVCzqsnsX/G8SFV5dMFJdyvXaDndMVHuaRJhPyXOpVqiJRR AXRS83zriOsLpATNOuxajv799NHpOPiqwe11VfZF4C5QfiKjvCXXIrwy6LFLuIWX G7X5crsBOIWh7NApx2CksJWZYgDmws52fkowBogqDG1lhaKQpsQrvjZ0la9st75K kmU1EYz8rEj+2rTaltcE/DqKOLx9H5Cp5jX7c3O4vTw+BnU14CGdeDuxrvNKZx9h LSld0zFA+fTsXgw4Ae8OzFHIg6c/u8NOvsFNitrONrWTghHQe52+dqbAroSg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1671113226; x= 1671199626; bh=1SllV+6xH6voO3fJTA+3hvOBIyok7EAq3oG9HQUHYl8=; b=x DuSt8tctW8YNN5lchu+5geBGB2uClFk69ZiUCYN3fLTqcpvF4Fng2xomwluqhqBX p64RjUQAx7arj3Ncu8WbFM6rKE1YjfglpNKBgzzUsCW2E4nLyDzRiOUDeTWb7Dxs RH181x5bDwEE5NG5kdD6uzf+8I52Ar7hnhbPy/Z5luCQ4lR+6cKmxS1V6IXwKGiB lKZh7tvHDCvaMbga7FP+YccUDkCLtWyikCMRMA1qvAIglwmMLxWj2mV86LNkU5D3 0ga3SQWLF5f73PZF3e77AOD4pNiM1l16TqFzR4tveEEW/79sp2quTbH2TZOROpGa yMyG+A1DaCeIjlkNjaSRw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrfeehgdehlecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefkffggfgfuvfevfhfhjggtgfesthekredttdefjeenucfhrhhomheplfhoshht vghinhcumfhjpphnihhgshgvnhcuoehjohhsthgvihhnsehsvggtuhhrvgdrkhhjohhnih hgshgvnhdrnhgvtheqnecuggftrfgrthhtvghrnheptddujefhvdekudefudffuddvuddu ieetheehkeelhedvgedtieevvdefieejtdffnecuvehluhhsthgvrhfuihiivgeptdenuc frrghrrghmpehmrghilhhfrhhomhepjhhoshhtvghinhesshgvtghurhgvrdhkjhhonhhi ghhsvghnrdhnvght X-ME-Proxy: Feedback-ID: ib2f84088:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 15 Dec 2022 09:07:05 -0500 (EST) Message-ID: <5fdb336f-f6cd-70c6-9390-ef284c283130@secure.kjonigsen.net> Date: Thu, 15 Dec 2022 15:07:04 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: bug#59977: 29.0.60; python-ts-mode does not fontify function-invocations using font-lock-function-name [PATCH] Content-Language: en-US To: Yuan Fu References: From: =?UTF-8?Q?Jostein_Kj=c3=b8nigsen?= In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 59977 Cc: fgallina@gnu.org, 59977@debbugs.gnu.org, Theodor Thornhill X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) On 12.12.2022 23:54, Yuan Fu wrote: > Ah, yes. That’s because the "definition" feature, which is by enabled by > default, only highlights definition and ignores invocation. OTOH, the > "function" feature highlights every instance of a function identifier, > but it isn’t enabled by default. I've tried latest python-ts-mode from latest emacs-29 branch, with fontification set to level 4 and I can still reproduce this error. Looking at the code, I cannot see any "function" feature defined, and to me it seems a patch like the one I added is required to introduce this functionality. > Other tree-sitter major modes doesn’t > have "definition" and enable "function" by default, I think. I believe this is standard for js-ts-mode, typescript-ts-mode, tsx-ts-mode and csharp-ts-mode. Even on level 3, and if it wasn't, as a user of those languages, I would argue in support of having it there :) I can't "speak" on behalf of the other major-modes though. > I’m planning to standardize the features in each major mode according to > the list I showed you earlier. It’d be great if you can have a look at > that list and see if you have any opinions, before we decide on the > final form of it and start to standardize those features in major modes. > (Of course, each language is different, the standard feature list is > just a base upon which major modes will extend/modify.) > > Yuan I guess that is another discussion entirely (how to implement a given set of features). This bug is about a feature (function-call highlighting)  being fully missing :) -- Jostein From debbugs-submit-bounces@debbugs.gnu.org Thu Dec 15 20:35:50 2022 Received: (at 59977) by debbugs.gnu.org; 16 Dec 2022 01:35:50 +0000 Received: from localhost ([127.0.0.1]:46100 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p5zde-00077z-Ci for submit@debbugs.gnu.org; Thu, 15 Dec 2022 20:35:50 -0500 Received: from mail-pj1-f50.google.com ([209.85.216.50]:34707) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p5zdY-00077k-Oa for 59977@debbugs.gnu.org; Thu, 15 Dec 2022 20:35:48 -0500 Received: by mail-pj1-f50.google.com with SMTP id hd14-20020a17090b458e00b0021909875bccso7352860pjb.1 for <59977@debbugs.gnu.org>; Thu, 15 Dec 2022 17:35:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:cc:date:message-id:subject:mime-version :content-transfer-encoding:from:from:to:cc:subject:date:message-id :reply-to; bh=CenX/ORrYQPBFXLb0sM78wqsDB/0JWu1LbuF3cIgBWU=; b=bIUpt+1yD0qVzz8/vjR1NUdfCDA6O4XycxqxsYSQ8QoYjbMwRnJzggkbVpbn7PN70a mD/YtjenYJBsGrsRfFWQocgps/uThrWitp2vdGplvLUdJ2CeNKSizwZrETLWH9s58azS iLM9e44K+TTBV4vcD6ytigRxyPJk4pHz665iQNF1lhWbSMMl/vJ+K1UA4u96c3FAJFAV 2Pm8Lk/MabP1JzKJUc2ttGMRD2yCvSV9kBYG20ncXMFFGHmo4kfzi1x/vlNA/2gh5HiA bNxnP8IkA3FAWyhADd7WE2fAR+IJqtKFDFqznnDnWCi6MwbUdIA0jKp33s12gDMiqkGP frjw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:cc:date:message-id:subject:mime-version :content-transfer-encoding:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=CenX/ORrYQPBFXLb0sM78wqsDB/0JWu1LbuF3cIgBWU=; b=QpS7h0z59M9uqtUlT3mlN+TObPXz6qY9kwtEZV47f2OGJQPr42cIsmIOsS8kQfR+mU bMMz1kGHLqO/rt8PPUm6E8mPZwRUFpGOhwLouePjYSEwwqDs4kFCiower5SRMX6+Kdob 1Hgvn2qqIGgzy08c9P5tXowK3isJf6JFY3DQsp6OTfsFokCRhhGSYxXRom2rRne0dYvx HQFPwvnAQPHbBAtBnmsdhqICkvYf/WFcdmve3lp8Ec4GqSkXK5y5gXvkb9vJF7d0JgZB HtACkek6SS5+ntUtguXrMXWQh0x4EkYrrn6+QWcxt+esGwtEYRtL7KPAGJdIIQM/Qd8P +eWg== X-Gm-Message-State: ANoB5pmfpC7OLiM0BiLBq9+7DWNsG1BAvNbPg8243lJW+yZKlyspjolU TiBBRGAoasd+HET4cCNqYLM= X-Google-Smtp-Source: AA0mqf7Q5SOBa27uQa3V0XT3eeJnKiVkmXDY3VsnMzmdt1IHbwoNhMIxzOyVGn+4Q5l/Ykw4T1p/Ow== X-Received: by 2002:a17:903:328b:b0:189:f7c2:7245 with SMTP id jh11-20020a170903328b00b00189f7c27245mr33589612plb.45.1671154538759; Thu, 15 Dec 2022 17:35:38 -0800 (PST) Received: from smtpclient.apple (cpe-172-117-161-177.socal.res.rr.com. [172.117.161.177]) by smtp.gmail.com with ESMTPSA id h14-20020a170902f54e00b0018957322953sm297865plf.45.2022.12.15.17.35.37 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 15 Dec 2022 17:35:38 -0800 (PST) From: Yuan Fu Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.1\)) Subject: Re: bug#59977: 29.0.60; python-ts-mode does not fontify function-invocations using font-lock-function-name [PATCH] Message-Id: Date: Thu, 15 Dec 2022 17:35:37 -0800 To: =?utf-8?Q?Jostein_Kj=C3=B8nigsen?= X-Mailer: Apple Mail (2.3696.120.41.1.1) X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 59977 Cc: fgallina@gnu.org, 59977@debbugs.gnu.org, theo@thornhill.no X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Jostein Kj=C3=B8nigsen writes: > On 12.12.2022 23:54, Yuan Fu wrote: >> Ah, yes. That=E2=80=99s because the "definition" feature, which is by = enabled by >> default, only highlights definition and ignores invocation. OTOH, the >> "function" feature highlights every instance of a function = identifier, >> but it isn=E2=80=99t enabled by default. > > I've tried latest python-ts-mode from latest emacs-29 branch, with > fontification set to level 4 and I can still reproduce this error. > > Looking at the code, I cannot see any "function" feature defined, and > to me it seems a patch like the one I added is required to introduce > this functionality. Yes, you are exactly right. My point is that the change belongs to "function" feature and not definition. I made a change that added your rules to a new "function" feature. >> Other tree-sitter major modes doesn=E2=80=99t >> have "definition" and enable "function" by default, I think. > > I believe this is standard for js-ts-mode, typescript-ts-mode, > tsx-ts-mode and csharp-ts-mode. Even on level 3, and if it wasn't, as > a user of those languages, I would argue in support of having it there > :) > > I can't "speak" on behalf of the other major-modes though. I=E2=80=99m sure a lot of people would prefer that, no doubt. The other = modes currently having them on level 3 is something we should fix (unless we end up deciding that we want "function" feature on level 3). >> I=E2=80=99m planning to standardize the features in each major mode = according to >> the list I showed you earlier. It=E2=80=99d be great if you can have = a look at >> that list and see if you have any opinions, before we decide on the >> final form of it and start to standardize those features in major = modes. >> (Of course, each language is different, the standard feature list is >> just a base upon which major modes will extend/modify.) >> >> Yuan > I guess that is another discussion entirely (how to implement a given > set of features). > > This bug is about a feature (function-call highlighting) being fully > missing :) Yes, I understand, I=E2=80=99m not against adding this in any way. Yuan From debbugs-submit-bounces@debbugs.gnu.org Mon Jan 02 04:04:34 2023 Received: (at 59977) by debbugs.gnu.org; 2 Jan 2023 09:04:34 +0000 Received: from localhost ([127.0.0.1]:42455 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pCGkD-0005n8-U7 for submit@debbugs.gnu.org; Mon, 02 Jan 2023 04:04:34 -0500 Received: from wout1-smtp.messagingengine.com ([64.147.123.24]:57079) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pCGkB-0005mp-Nl; Mon, 02 Jan 2023 04:04:32 -0500 Received: from compute6.internal (compute6.nyi.internal [10.202.2.47]) by mailout.west.internal (Postfix) with ESMTP id B7A69320090F; Mon, 2 Jan 2023 04:04:23 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute6.internal (MEProxy); Mon, 02 Jan 2023 04:04:23 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= secure.kjonigsen.net; h=cc:content-type:date:date:from:from :in-reply-to:message-id:mime-version:reply-to:sender:subject :subject:to:to; s=fm1; t=1672650263; x=1672736663; bh=5wZuSwtYoZ I6Bi6WxfIpDOPltUcC0RVxkG0Vb8zMTIE=; b=AgljJURFvWFPWL+ESH01RtcasN HOi7Vi6ySSH5P333vFL4mxXPbxQowxYzvevj9hIdkCRPTzdAIgd8ht/se3i0LxP6 Gh154mN8QNKLRAp7FWK66Ea9AF0j/qYTyHdJQAP/2aqrIk2ip2QxWG5CSwP0J8PM yBaqkBAB+Od48ZB3hQzt0+HnhyCjcvWtYMWrlaW+IYqqXLSsAP3dGatUawLTacWN SlQvnUsxp8b/Rqir1zzM79cPR241DLzhhhEgAsnFM7pu0ubaYK9t76ea4oUkISaM nuEqmCj59rOxHRTe513dcJael0phcBOpSp13XXWL9D5c7pG6nqov9KJV4khg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:message-id:mime-version :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1672650263; x= 1672736663; bh=5wZuSwtYoZI6Bi6WxfIpDOPltUcC0RVxkG0Vb8zMTIE=; b=x UY70oWvVxcUxru8tnMIuQDsPmXa7RC55b3wRYMKEgiBqbzlk1YlFzAIq+xVJiqPH Fh6G6X8fwJrZPQkdxt2J6wCSMFdECUtrLwDy/0HRKfm7VxgIe/uprwYxB67+aJ/O 3SGWW5ezMo0OWjxCQgrAIRM2yTlDYE+CCjDSRqUMUGvu+97tN01W0WmsuyDOWWS4 afGbjz0NJn8TQUyiYPpAENMAycVvuonTCH8bo4C2B5hRgOMHUnA2/LF0FG9iAfZ9 Jd6fHyhsfOE8AL4f1Vx3kIYeIMY4Z4oVdMJhU4hPNYEOaUrFloZtwOX6nCMtkg2X ptmkxJ3Oz6zv3ETOwEJDg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrjedvucetufdoteggodetrfdotffvucfrrh hofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgenuceurghi lhhouhhtmecufedttdenucenucfjughrpegtkfffgggfvffhufesrgdtreertdefjeenuc fhrhhomheplfhoshhtvghinhcumfhjpphnihhgshgvnhcuoehjohhsthgvihhnsehsvggt uhhrvgdrkhhjohhnihhgshgvnhdrnhgvtheqnecuggftrfgrthhtvghrnhepfeegfeefke ehleetgfdvkeetieffudfghfeludevfefhheehffelheeitdevjedunecuffhomhgrihhn pehkjhhnihhgshgvnhdrnhhonecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpe hmrghilhhfrhhomhepjhhoshhtvghinhesshgvtghurhgvrdhkjhhonhhighhsvghnrdhn vght X-ME-Proxy: Feedback-ID: ib2f84088:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 2 Jan 2023 04:04:22 -0500 (EST) Content-Type: multipart/alternative; boundary="------------BpQZSXMYJxnaT3LpbBh5ckur" Message-ID: <4e7c018c-9ac2-0f84-5f63-ae857b2416e6@secure.kjonigsen.net> Date: Mon, 2 Jan 2023 10:04:21 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Content-Language: en-US To: 59977-done@debbugs.gnu.org, 59977@debbugs.gnu.org From: =?UTF-8?Q?Jostein_Kj=c3=b8nigsen?= Subject: 29.0.60; python-ts-mode does not fontify function-invocations using font-lock-function-name [PATCH] X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 59977 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) This is a multi-part message in MIME format. --------------BpQZSXMYJxnaT3LpbBh5ckur Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit I guess this one can be closed now :) -- *Jostein Kjønigsen* jostein.kjønigsen.no jostein@kjonigsen.net - jostein@gmail.com --------------BpQZSXMYJxnaT3LpbBh5ckur Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 8bit

I guess this one can be closed now :)

--
Jostein Kjønigsen
jostein.kjønigsen.no
jostein@kjonigsen.net - jostein@gmail.com
--------------BpQZSXMYJxnaT3LpbBh5ckur-- From unknown Tue Aug 19 21:02:42 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Mon, 30 Jan 2023 12:24:05 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator